Hi,
0x1 would make me more comfortable.
I am guessing index + shift is almost always< 31,
but still.
fixed.
This actually gives a bigger value than
necessary if the input is a power of 2 already.
fixed.
+ struct pci_bus *s = busses + dev->secondary_bus;
would be nice to move to top of the scope.
that is actually seabios code style ;)
+ if (pci_bios_init_root_regions(start, end) != 0) {
+ dprintf(1, "PCI: out of address space\n");
+ /* Hmm, what do now? */
stall?
patch #2 makes that a panic.
cheers,
Gerd
_______________________________________________
SeaBIOS mailing list
[email protected]
http://www.seabios.org/mailman/listinfo/seabios
