[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

2019-02-08 Thread Nico Weber via Phabricator via cfe-commits 
thakis added a comment.
Herald added a project: clang.

Did you see the "Should we remove this check that currently requires 
ENABLE_ARCMT => ENABLE_SA? 
http://llvm-cs.pcc.me.uk/tools/clang/CMakeLists.txt#441; question?

In D57127#1373949 , @george.karpenkov 
wrote:

> @thakis Sorry I don't understand your point. At the end of the day, 
> ProgramPoint and BodyFarm are only used by the static analyzer.


They are used by StaticAnalyzer/Core, which clang does depend on.

> If you disagree, what is your proposed directory structure? What would be the 
> benefits?

I'd put this in a library that isn't linked into clang. The benefit is that 
it's easier to keep clang itself small(er) that way.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57127/new/

https://reviews.llvm.org/D57127



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

2019-01-28 Thread George Karpenkov via Phabricator via cfe-commits 
george.karpenkov added a comment.

@thakis Sorry I don't understand your point. At the end of the day, 
ProgramPoint and BodyFarm are only used by the static analyzer.
If you disagree, what is your proposed directory structure? What would be the 
benefits?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57127/new/

https://reviews.llvm.org/D57127



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

2019-01-28 Thread Nico Weber via Phabricator via cfe-commits 
thakis added a comment.

In D57127#1371563 , @george.karpenkov 
wrote:

> > Also, isn't lib/Analysis a strange place for this? lib/Analysis is used by 
> > the compiler proper (CodeGen, Sema, …), while RetainSummaryManager is only 
> > used by tooling-like things (static analyzer, arcmigrate).
>
> Not only, it has utilities used by the static analyzer which are too generic 
> to be in the static analyzer itself - ProgramPoint.cpp, BodyFarm.cpp, 
> CocoaConventions.cpp to name a few.


ProgramPoint.cpp and BodyFarm.cpp are used by StaticAnalyzer/Core, which the 
compiler itself uses for CFG-based warnings. Sema also uses CocoaConventions.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57127/new/

https://reviews.llvm.org/D57127



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

2019-01-28 Thread Nico Weber via Phabricator via cfe-commits 
thakis added a comment.

In D57127#1371562 , @george.karpenkov 
wrote:

> > Can you elaborate a bit in what sense this decouples ARCMT from the 
> > analyzer?
>
> ARCMT now does not need to link against the analyzer
>
> > Can CLANG_ENABLE_STATIC_ANALYZER now be set independently of 
> > CLANG_ENABLE_ARCMT?
>
> Yes


Should we remove this check that currently requires ENABLE_ARCMT => ENABLE_SA? 
http://llvm-cs.pcc.me.uk/tools/clang/CMakeLists.txt#441


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57127/new/

https://reviews.llvm.org/D57127



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

2019-01-25 Thread George Karpenkov via Phabricator via cfe-commits 
george.karpenkov added a comment.

> Also, isn't lib/Analysis a strange place for this? lib/Analysis is used by 
> the compiler proper (CodeGen, Sema, …), while RetainSummaryManager is only 
> used by tooling-like things (static analyzer, arcmigrate).

Not only, it has utilities used by the static analyzer which are too generic to 
be in the static analyzer itself - ProgramPoint.cpp, BodyFarm.cpp, 
CocoaConventions.cpp to name a few.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57127/new/

https://reviews.llvm.org/D57127



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

2019-01-25 Thread George Karpenkov via Phabricator via cfe-commits 
george.karpenkov added a comment.

> Can you elaborate a bit in what sense this decouples ARCMT from the analyzer?

ARCMT now does not need to link against the analyzer

> Can CLANG_ENABLE_STATIC_ANALYZER now be set independently of 
> CLANG_ENABLE_ARCMT?

Yes


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57127/new/

https://reviews.llvm.org/D57127



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

2019-01-25 Thread Nico Weber via Phabricator via cfe-commits 
thakis added a comment.

Also, isn't lib/Analysis a strange place for this? lib/Analysis is used by the 
compiler proper (CodeGen, Sema, …), while RetainSummaryManager is only used by 
tooling-like things (static analyzer, arcmigrate).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57127/new/

https://reviews.llvm.org/D57127



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

2019-01-25 Thread Nico Weber via Phabricator via cfe-commits 
thakis added a comment.

Can you elaborate a bit in what sense this decouples ARCMT from the analyzer? 
Can CLANG_ENABLE_STATIC_ANALYZER now be set independently of CLANG_ENABLE_ARCMT?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57127/new/

https://reviews.llvm.org/D57127



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits