Re: [chromium-dev] linux printing support and PrintingContext::AskUserForSettings

[Peter Kasting]

On Wed, Dec 23, 2009 at 10:39 AM, Andy Ames  wrote:

> Does anyone have suggestions on where to put the suppress print dialog
> setting? In Firefox, this is done in about:config. Since it's typically a
> developer feature, I want to hide it from the casual user.
>

Unless mhm never landed it, we already have a Kiosk mode command line
switch; it would probably make sense to add it to that.

Also, since security is important, I need to make sure a website cannot
> install a malicious script that can change the value of this setting and
> start sending print jobs.
>

Our settings aren't accessible from JS.  If you add the behavior to a
command-line switch, the only way to "change the value" would be for the
site to be able to kill your process and launch a new one with different
switches.  If the site can do that it can do pretty much anything, so I
don't think you have any situation-specific worries here, just the general
don't-allow-remote-code-local-execution.

PK

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] buildbot failure in Chromium on Mac10.5 Tests (dbg)(1), revision 35295

[buildbot]

Automatically closing tree for "unit_tests" on "Mac10.5 Tests (dbg)(1)"

http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests%20%28dbg%29%281%29/builds/10660

http://build.chromium.org/buildbot/waterfall/waterfall?builder=Mac10.5%20Tests%20%28dbg%29%281%29

--=>  Automatically closing tree for "unit_tests" on "Mac10.5 Tests (dbg)(1)"  
<=--

Revision: 35295
Blame list: j...@chromium.org

Buildbot waterfall: http://build.chromium.org/

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] Make found no targets (missing Makefile)

[Andrew Ames]

I am having trouble compiling on

Ubuntu 9.10 (karmic)
Kernel Linux 2.6.31-14-generic
GNOME 2.28.1

AMD Athlon 64

I have successfully built before on a 32-bit i386 Ubuntu installation.

Any ideas?

Here's my session:

BEGIN
a...@ubuntu:~/projects/chromium$ export GYP_GENERATORS=make
a...@ubuntu:~/projects/chromium$ gclient config \
http://src.chromium.org/svn/trunk/src \
http://chromium-status.appspot.com/lkgr
a...@ubuntu:~/projects/chromium$ gclient sync
a...@ubuntu:~/projects/chromium$ gclient runhooks --force --verbose

solutions = [
  { "name": "src",
"url" : "http://src.chromium.org/svn/trunk/src";,
"custom_deps" : {
  "src/third_party/WebKit/LayoutTests": None
},
"safesync_url": "http://chromium-status.appspot.com/lkgr";
  },
]

DEBUG:root:['/usr/bin/python', 'src/build/gyp_chromium']

 running '/usr/bin/python src/build/gyp_chromium' in
'/home/andy/projects/chromium'
Updating projects from gyp files...
DEBUG:root:['/usr/bin/python',
'src/build/win/clobber_generated_headers.py']

 running '/usr/bin/python
src/build/win/clobber_generated_headers.py' in
'/home/andy/projects/chromium'
DEBUG:root:['/usr/bin/python',
'src/build/mac/clobber_generated_headers.py']

 running '/usr/bin/python
src/build/mac/clobber_generated_headers.py' in
'/home/andy/projects/chromium'
a...@ubuntu:~/projects/chromium$ make chrome
make: *** No rule to make target `chrome'.  Stop.
a...@ubuntu:~/projects/chromium$
END

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] linux printing support and PrintingContext::AskUserForSettings

[Andy Ames]

Ok, great.

I will take on the Linux printer settings dialog and also implement a  
cross-platform mechanism for suppressing the printer dialog. This will  
cause printing to use the last settings (or default settings).

This is an important feature for using Chromium in a kiosk or Point-Of- 
Sale terminal, which we are doing.

Currently, we've had to run a Firefox window in the background to  
handle the print queue, while the front-end uses the fast JavaScript  
of Chromium.

Does anyone have suggestions on where to put the suppress print dialog  
setting? In Firefox, this is done in about:config. Since it's  
typically a developer feature, I want to hide it from the casual user.

Also, since security is important, I need to make sure a website  
cannot install a malicious script that can change the value of this  
setting and start sending print jobs.

Any help is greatly appreciated.

Andy

P.S. I've read all the developer docs regarding development process,  
coding style, and so on.

On Dec 23, 2009, at 7:53 AM, Tony Chang wrote:

> I believe modifying printer settings just hasn't been implemented  
> yet on Linux.  If you would like to make a patch to do this, that  
> would be great since there's no one actively working on Linux  
> printing right now.
>
> On Tue, Dec 22, 2009 at 4:28 PM, Andy Ames  wrote:
> I noticed that the Linux printing implementation is not going  
> through the same PrintingContext framework.
>
> Anyone know why?
>
> I am interested in modifying the source to add the ability to  
> suppress printing in a cross-platform way. It looks like  
> PrintJobWorker::GetSettings implements a flag for whether or not the  
> user should be asked for printer settings. Depending on the value of  
> this flag, either PrintingContext::UseDefaultSettings or  
> PrintingContext::AskUserForSettings is called. This code seems to  
> only be executed on Mac and Windows, not on Linux.
>
> Is there a known barrier to getting the linux printing flow, which  
> is described at http://code.google.com/p/chromium/wiki/ 
> LinuxPrinting, to work with UseDefaultSettings and AskUserForSettings?
>
> Thanks in advance.
>
> Andy
>
> -- 
> Chromium Developers mailing list: chromium-dev@googlegroups.com
> View archives, change email options, or unsubscribe:
> http://groups.google.com/group/chromium-dev
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Modifying .gyp files

[Mark Mentovai]

Igor Gatis  wrote:
> Great, just wrote a rule for that. I placed it on the final target of my
> project. What would be nice is to define such rule on the protobuf library
> gyp and export it. It seems this file does that. But when I try doing the
> same, I get the following error:
[...]
>   File
> "/home/wgatis/google-apis/tools/third_party/gyp/pylib/gyp/generator/make.py",
> line 606, in WriteRules
>     for rule_source in rule['rule_sources']:
> KeyError: 'rule_sources'

Sounds like a bug in the make generator.  It shouldn't be an error to
define a rule but not have any sources that match its extension in a
specific target.  Try changing line 606 of make.py to:

  for rule_source in rule.get('rule_sources', []):

although that may be incomplete: you may also need to keep the block
at lines 666-668 from executing if |not 'rule_sources' in rule| too.

Mark

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Modifying .gyp files

[Igor Gatis]

Great, just wrote a rule for that. I placed it on the final target of my
project. What would be nice is to define such rule on the protobuf library
gyp and export it. It seems this file does
that.
But when I try doing the same, I get the following error:

Traceback (most recent call last):
  File "/home/wgatis/google-apis/tools/third_party/gyp/gyp", line 18, in

sys.exit(gyp.main(sys.argv[1:]))
  File
"/home/wgatis/google-apis/tools/third_party/gyp/pylib/gyp/__init__.py", line
432, in main
generator.GenerateOutput(flat_list, targets, data, params)
  File
"/home/wgatis/google-apis/tools/third_party/gyp/pylib/gyp/generator/make.py",
line 1104, in GenerateOutput
part_of_all=qualified_target in needed_targets)
  File
"/home/wgatis/google-apis/tools/third_party/gyp/pylib/gyp/generator/make.py",
line 480, in Write
self.WriteRules(spec['rules'], extra_sources, extra_outputs,
part_of_all)
  File
"/home/wgatis/google-apis/tools/third_party/gyp/pylib/gyp/generator/make.py",
line 606, in WriteRules
for rule_source in rule['rule_sources']:
KeyError: 'rule_sources'

I attached my protobuf gyp file.

On Sun, Dec 27, 2009 at 2:01 PM, Mark Mentovai  wrote:
> Igor Gatis wrote:
>> Really? At least, it does not seem to be the case for make generator.
>> There are no rules for handling .proto files in make generator. That's
>> actually what I've been trying to do in the last couple of days.
>
> GYP rules are something that you have to write yourself, there aren't
> any pre-baked ones other than the native support each environment
> provides to compile C++.  A GYP rule applies to input files in a
> 'sources' section based on the file's extension.
>
> Look at the 'rules' sections in some of Chromium's .gyp files for
examples.
>
> Mark
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

protobuf.gyp
Description: Binary data

Re: [chromium-dev] Modifying .gyp files

[Mark Mentovai]

Igor Gatis wrote:
> Really? At least, it does not seem to be the case for make generator.
> There are no rules for handling .proto files in make generator. That's
> actually what I've been trying to do in the last couple of days.

GYP rules are something that you have to write yourself, there aren't
any pre-baked ones other than the native support each environment
provides to compile C++.  A GYP rule applies to input files in a
'sources' section based on the file's extension.

Look at the 'rules' sections in some of Chromium's .gyp files for examples.

Mark

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Modifying .gyp files

[Igor Gatis]

Really? At least, it does not seem to be the case for make generator.
There are no rules for handling .proto files in make generator. That's
actually what I've been trying to do in the last couple of days.

On Sun, Dec 27, 2009 at 12:47 PM, Mark Mentovai  wrote:
> Igor Gatis wrote:
>> Is there a wishlist? I'd like to vote for support for both configure
>> step and .proto files.
>
> GYP rules should be able to support .proto files.
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Modifying .gyp files

[Mark Mentovai]

Igor Gatis wrote:
> Is there a wishlist? I'd like to vote for support for both configure
> step and .proto files.

GYP rules should be able to support .proto files.

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev