[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-07-31 Thread Ben Goodger (Google)

I would be interested in knowing this too. I think I'm going to create
a second email address (e.g. ben-cc) to handle CC'ed reviews.

-Ben

On Fri, Jul 31, 2009 at 5:18 PM, Brett Wilson wrote:
>
> I added myself to some watchlists and I get a bunch of email about a
> lot of reviews
>
> But this has confused my Gmail filters, which automatic ally label and
> archive code reviews not addressed directly to me, and all of my CCd
> code reviews show up in my inbox.
>
> Anybody know how to reliably detect the difference between "I'm the
> reviewer" and "I'm CC'd on a review" in a Gmail filter?
>
> Brett
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-07-31 Thread Rahul Kuchhal
I thought to: and -cc: would work in this case? Have you tried
using that in "Has the words" on Filter edit screen?

On Fri, Jul 31, 2009 at 5:18 PM, Brett Wilson  wrote:

>
> I added myself to some watchlists and I get a bunch of email about a
> lot of reviews
>
> But this has confused my Gmail filters, which automatic ally label and
> archive code reviews not addressed directly to me, and all of my CCd
> code reviews show up in my inbox.
>
> Anybody know how to reliably detect the difference between "I'm the
> reviewer" and "I'm CC'd on a review" in a Gmail filter?
>
> Brett
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-07-31 Thread Mohamed Mansour
I thought all those cc's from code reviews, is about the last couple of
people who edited that part of the code in the past. I have been getting a
couple of code reviews cc's and the code I was cc'd is what I have touched
within a month or so.
I could imagine Ben receiving a ton of reviews, he touched almost all
browser code base.


-- Mohamed Mansour


On Fri, Jul 31, 2009 at 8:44 PM, Rahul Kuchhal  wrote:

> I thought to: and -cc: would work in this case? Have you tried
> using that in "Has the words" on Filter edit screen?
>
> On Fri, Jul 31, 2009 at 5:18 PM, Brett Wilson  wrote:
>
>>
>> I added myself to some watchlists and I get a bunch of email about a
>> lot of reviews
>>
>> But this has confused my Gmail filters, which automatic ally label and
>> archive code reviews not addressed directly to me, and all of my CCd
>> code reviews show up in my inbox.
>>
>> Anybody know how to reliably detect the difference between "I'm the
>> reviewer" and "I'm CC'd on a review" in a Gmail filter?
>>
>> Brett
>>
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-07-31 Thread Ben Goodger (Google)

I get a lot of mail since I set up a watchlist filter on browser/.

-Ben

On Fri, Jul 31, 2009 at 7:28 PM, Mohamed
Mansour wrote:
> I thought all those cc's from code reviews, is about the last couple of
> people who edited that part of the code in the past. I have been getting a
> couple of code reviews cc's and the code I was cc'd is what I have touched
> within a month or so.
> I could imagine Ben receiving a ton of reviews, he touched almost all
> browser code base.
>
> -- Mohamed Mansour
>
>
> On Fri, Jul 31, 2009 at 8:44 PM, Rahul Kuchhal  wrote:
>>
>> I thought to: and -cc: would work in this case? Have you tried
>> using that in "Has the words" on Filter edit screen?
>>
>> On Fri, Jul 31, 2009 at 5:18 PM, Brett Wilson  wrote:
>>>
>>> I added myself to some watchlists and I get a bunch of email about a
>>> lot of reviews
>>>
>>> But this has confused my Gmail filters, which automatic ally label and
>>> archive code reviews not addressed directly to me, and all of my CCd
>>> code reviews show up in my inbox.
>>>
>>> Anybody know how to reliably detect the difference between "I'm the
>>> reviewer" and "I'm CC'd on a review" in a Gmail filter?
>>>
>>> Brett
>>>
>>>
>>
>>
>>
>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-08-03 Thread Brett Wilson

On Fri, Jul 31, 2009 at 5:44 PM, Rahul Kuchhal wrote:
> I thought to: and -cc: would work in this case? Have you tried
> using that in "Has the words" on Filter edit screen?

One problem with this is that it doesn't fix the case where people
respond to the review mail via email rather than Reitveld. Then I get
put on the "to" line since I was originally in the "reply-to" line.

I doubt I will have much luck making people stop using email this way,
so I will try one of the "second email" approaches.

Brett

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-08-03 Thread Jeremy Orlow
On Mon, Aug 3, 2009 at 10:11 AM, Brett Wilson  wrote:

>
> On Fri, Jul 31, 2009 at 5:44 PM, Rahul Kuchhal
> wrote:
> > I thought to: and -cc: would work in this case? Have you
> tried
> > using that in "Has the words" on Filter edit screen?
>
> One problem with this is that it doesn't fix the case where people
> respond to the review mail via email rather than Reitveld. Then I get
> put on the "to" line since I was originally in the "reply-to" line.
>
> I doubt I will have much luck making people stop using email this way,


This is actually completely supported now (i.e. your comments end up in the
review log).  I don't see why you talk like people doing this is improper.


> so I will try one of the "second email" approaches.


It might also work to use brettw...@chromium.org
as your CC address and then filter
everything that's to that address.  (I've
never used the +foo trick with Gmail, but I think I've seen others using
it.)  If it works, then you don't need to worry about creating a second
email address.

J

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---