[chromium-dev] Re: V8DOMMap
Wow - that might get messy. I wonder if use of v8 hidden properties might be useful here. You could potentially add a hidden object to the wrapper. But this may not work well. Mike On Wed, Jun 3, 2009 at 10:54 PM, Adam Barth aba...@google.com wrote: Thanks Mike. As I mentioned to Dimitri, what I'm trying to do is run content scripts from extensions in their own world. Specifically, we don't want the extension scripts to exchange any JavaScript pointers with the page's scripts. To do this, we need to have separate DOM wrappers for the page's scripts and for the extension's scripts, which is what I'm trying to teach DOMMap. I'll ping you two with specific questions as they come up. Thanks, Adam On Wed, Jun 3, 2009 at 10:08 PM, Mike Belshe mbel...@google.com wrote: I may be able to help too. I'm very worried about adding more dependencies on it. void* casting is not good! Mike On Wed, Jun 3, 2009 at 5:53 PM, Dimitri Glazkov dglaz...@chromium.org wrote: /me raises hand sheepishly. Whatcha need? :) :DG On Wed, Jun 3, 2009 at 5:37 PM, Adam Barth aba...@chromium.org wrote: Who's a good contact for V8DOMMap? It's probably going to need some surgery to support isolated user scripts, and I want to make sure I'm not screwing it up. Thanks, Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: V8DOMMap
You mean the idea in general won't work well, or this particular approach? I talked it over with Feng awhile ago, and he seemed to think the general idea was implementable. I think the code has changed since then though, with workers. - a On Thu, Jun 4, 2009 at 10:00 AM, Mike Belshe mbel...@google.com wrote: Wow - that might get messy. I wonder if use of v8 hidden properties might be useful here. You could potentially add a hidden object to the wrapper. But this may not work well. Mike On Wed, Jun 3, 2009 at 10:54 PM, Adam Barth aba...@google.com wrote: Thanks Mike. As I mentioned to Dimitri, what I'm trying to do is run content scripts from extensions in their own world. Specifically, we don't want the extension scripts to exchange any JavaScript pointers with the page's scripts. To do this, we need to have separate DOM wrappers for the page's scripts and for the extension's scripts, which is what I'm trying to teach DOMMap. I'll ping you two with specific questions as they come up. Thanks, Adam On Wed, Jun 3, 2009 at 10:08 PM, Mike Belshe mbel...@google.com wrote: I may be able to help too. I'm very worried about adding more dependencies on it. void* casting is not good! Mike On Wed, Jun 3, 2009 at 5:53 PM, Dimitri Glazkov dglaz...@chromium.org wrote: /me raises hand sheepishly. Whatcha need? :) :DG On Wed, Jun 3, 2009 at 5:37 PM, Adam Barth aba...@chromium.org wrote: Who's a good contact for V8DOMMap? It's probably going to need some surgery to support isolated user scripts, and I want to make sure I'm not screwing it up. Thanks, Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: V8DOMMap
On Thu, Jun 4, 2009 at 10:33 AM, Aaron Boodman a...@chromium.org wrote: You mean the idea in general won't work well, or this particular approach? I talked it over with Feng awhile ago, and he seemed to think the general idea was implementable. I think the code has changed since then though, with workers. Oh - it can work, don't get me wrong. But the dom maps are getting really complicated (especially since workers dropped in). It was difficult before, and worse now. The void* conversions are a big problem. Coming up with an answer to avoid those casts might make your changes simpler, but it's not really your problem. Mike - a On Thu, Jun 4, 2009 at 10:00 AM, Mike Belshe mbel...@google.com wrote: Wow - that might get messy. I wonder if use of v8 hidden properties might be useful here. You could potentially add a hidden object to the wrapper. But this may not work well. Mike On Wed, Jun 3, 2009 at 10:54 PM, Adam Barth aba...@google.com wrote: Thanks Mike. As I mentioned to Dimitri, what I'm trying to do is run content scripts from extensions in their own world. Specifically, we don't want the extension scripts to exchange any JavaScript pointers with the page's scripts. To do this, we need to have separate DOM wrappers for the page's scripts and for the extension's scripts, which is what I'm trying to teach DOMMap. I'll ping you two with specific questions as they come up. Thanks, Adam On Wed, Jun 3, 2009 at 10:08 PM, Mike Belshe mbel...@google.com wrote: I may be able to help too. I'm very worried about adding more dependencies on it. void* casting is not good! Mike On Wed, Jun 3, 2009 at 5:53 PM, Dimitri Glazkov dglaz...@chromium.org wrote: /me raises hand sheepishly. Whatcha need? :) :DG On Wed, Jun 3, 2009 at 5:37 PM, Adam Barth aba...@chromium.org wrote: Who's a good contact for V8DOMMap? It's probably going to need some surgery to support isolated user scripts, and I want to make sure I'm not screwing it up. Thanks, Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: V8DOMMap
On Thu, Jun 4, 2009 at 10:36 AM, Mike Belshe mbel...@google.com wrote: On Thu, Jun 4, 2009 at 10:33 AM, Aaron Boodman a...@chromium.org wrote: You mean the idea in general won't work well, or this particular approach? I talked it over with Feng awhile ago, and he seemed to think the general idea was implementable. I think the code has changed since then though, with workers. Oh - it can work, don't get me wrong. But the dom maps are getting really complicated (especially since workers dropped in). It was difficult before, and worse now. The void* conversions are a big problem. Coming up with an answer to avoid those casts might make your changes simpler, but it's not really your problem. I'm trying to merge the ideas of thread-specific DOMMaps with world-specific DOMMaps because they're more or less the same idea. Hopefully this won't add too much more complexity. How do v8 hidden properties work? Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: V8DOMMap
/me raises hand sheepishly. Whatcha need? :) :DG On Wed, Jun 3, 2009 at 5:37 PM, Adam Barth aba...@chromium.org wrote: Who's a good contact for V8DOMMap? It's probably going to need some surgery to support isolated user scripts, and I want to make sure I'm not screwing it up. Thanks, Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: V8DOMMap
I may be able to help too. I'm very worried about adding more dependencies on it. void* casting is not good! Mike On Wed, Jun 3, 2009 at 5:53 PM, Dimitri Glazkov dglaz...@chromium.orgwrote: /me raises hand sheepishly. Whatcha need? :) :DG On Wed, Jun 3, 2009 at 5:37 PM, Adam Barth aba...@chromium.org wrote: Who's a good contact for V8DOMMap? It's probably going to need some surgery to support isolated user scripts, and I want to make sure I'm not screwing it up. Thanks, Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
