[jira] [Updated] (CASSANDRA-15981) jvm-dtests crash on java 11
[
https://issues.apache.org/jira/browse/CASSANDRA-15981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15981:
--
Fix Version/s: (was: 4.0-beta)
4.0-beta2
Since Version: 4.0-alpha2
Source Control Link:
https://github.com/apache/cassandra/commit/528e3ad00b78f3cc03f27248914249798f2c0aa9
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
CI results:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-15981-trunk-CC886567-B80F-4C47-AE29-63CF0A3A2687
Green.
> jvm-dtests crash on java 11
> ---
>
> Key: CASSANDRA-15981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15981
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> There is a race condition bug with CMS and class unloading which cause the
> JVM to crash. Since jvm-dtests rely on class loaders and unloading, this
> causes sporadic JVM crashes that look like the following in CI logs
> {code}
> junit.framework.AssertionFailedError: Forked Java VM exited abnormally.
> Please note the time in the report does not reflect the time until the VM
> exit.
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15981) jvm-dtests crash on java 11
[
https://issues.apache.org/jira/browse/CASSANDRA-15981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15981:
--
Status: Ready to Commit (was: Review In Progress)
> jvm-dtests crash on java 11
> ---
>
> Key: CASSANDRA-15981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15981
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
>
> There is a race condition bug with CMS and class unloading which cause the
> JVM to crash. Since jvm-dtests rely on class loaders and unloading, this
> causes sporadic JVM crashes that look like the following in CI logs
> {code}
> junit.framework.AssertionFailedError: Forked Java VM exited abnormally.
> Please note the time in the report does not reflect the time until the VM
> exit.
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: jvm-dtests crash on java 11
This is an automated email from the ASF dual-hosted git repository. dcapwell pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 528e3ad jvm-dtests crash on java 11 528e3ad is described below commit 528e3ad00b78f3cc03f27248914249798f2c0aa9 Author: David Capwell AuthorDate: Wed Aug 5 20:47:14 2020 -0700 jvm-dtests crash on java 11 patch by David Capwell; reviewed by Alex Petrov, Jon Meredith for CASSANDRA-15981 --- build.xml | 34 -- 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/build.xml b/build.xml index d861920..7b67314 100644 --- a/build.xml +++ b/build.xml @@ -204,6 +204,31 @@ + + +-XX:MaxMetaspaceExpansion=64M +-XX:MaxMetaspaceSize=512M +-XX:MetaspaceSize=128M + + + +-XX:-CMSClassUnloadingEnabled + + + + + + + + @@ -1418,9 +1443,6 @@ algorithm to limit the metaspace size and clean up SoftReferences more aggressively rather than waiting. See CASSANDRA-14922 for more details. --> - - - @@ -1430,10 +1452,11 @@ - + - + +
[jira] [Commented] (CASSANDRA-14939) fix some operational holes in incremental repair
[ https://issues.apache.org/jira/browse/CASSANDRA-14939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171836#comment-17171836 ] Blake Eggleston commented on CASSANDRA-14939: - [~marcuse] rebased on current trunk and addressed all review comments > fix some operational holes in incremental repair > > > Key: CASSANDRA-14939 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14939 > Project: Cassandra > Issue Type: Bug >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > Fix For: 4.0 > > > Incremental repair has a few operational rough spots that make it more > difficult to fully automate and operate at scale than it should be. > * Visibility into whether pending repair data exists for a given token range. > * Ability to force promotion/demotion of data for completed sessions instead > of waiting for compaction. > * Get the most recent repairedAt timestamp for a given token range. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171803#comment-17171803 ] Caleb Rackliffe commented on CASSANDRA-15393: - [~marcuse] [~samt] I'm going to make a pass at review here if you two don't mind... > Add byte array backed cells > --- > > Key: CASSANDRA-15393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15393 > Project: Cassandra > Issue Type: Sub-task > Components: Local/Compaction >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > Fix For: 4.0-beta > > > We currently materialize all values as on heap byte buffers. Byte buffers > have a fairly high overhead given how frequently they’re used, and on the > compaction and local read path we don’t do anything that needs them. Use of > byte buffer methods only happens on the coordinator. Using cells that are > backed by byte arrays instead in these situations reduces compaction and read > garbage up to 22% in many cases. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15234) Standardise config and JVM parameters
[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171797#comment-17171797
]
Caleb Rackliffe commented on CASSANDRA-15234:
-
bq. Maybe we can only create now a separate new ticket on the in-jvm api change
so a snapshot release could be voted, etc.
[~e.dimitrova] I like that idea. I'd volunteer to review a separate Jira...
> Standardise config and JVM parameters
> -
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Benedict Elliott Smith
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15873) Update Netty 4.0.44 -> 4.1.50 (fix security/performance issues)
[ https://issues.apache.org/jira/browse/CASSANDRA-15873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171781#comment-17171781 ] Matt Davis commented on CASSANDRA-15873: Thanks Brandon - if that's the case it may not be possible to integrate this without additional changes, and I wonder how much interest there is in making further changes for this. One last check - I see the comparison is from trunk on 4.0, would the 3.11.x branch yield the same results? > Update Netty 4.0.44 -> 4.1.50 (fix security/performance issues) > --- > > Key: CASSANDRA-15873 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15873 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Matt Davis >Priority: Normal > Fix For: 3.11.x > > Attachments: dependency-check-report.html, unittest_netty.log > > > See https://issues.apache.org/jira/browse/CASSANDRA-15868 for the same issue > on 4.0 / trunk. Attached is an OWASP dependency report for Netty 4.0.44, > which identifies 3 of the same vulnerabilities as above. > > Additionally, 4.1.50 contains aarch64 native libraries which can improve > performance on ARM processors. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15459) Short read protection doesn't work on group-by queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171769#comment-17171769
]
Caleb Rackliffe commented on CASSANDRA-15459:
-
[~adelapena] I've created CASSANDRA-16030 to follow what happens to
{{test_node_cannot_join_as_hibernating_node_without_replace_address}}.
> Short read protection doesn't work on group-by queries
> --
>
> Key: CASSANDRA-15459
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: ZhaoYang
>Assignee: Andres de la Peña
>Priority: Normal
> Labels: correctness
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> [DTest to
> reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]:
> it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate
> limits used for SRP query, rather than "row counted".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16030) TestBootstrap::test_node_cannot_join_as_hibernating_node_without_replace_address failing on trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-16030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16030:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Adhoc Test
Severity: Low
Status: Open (was: Triage Needed)
> TestBootstrap::test_node_cannot_join_as_hibernating_node_without_replace_address
> failing on trunk
> -
>
> Key: CASSANDRA-16030
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16030
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0-rc
>
>
> {{TestBootstrap::test_node_cannot_join_as_hibernating_node_without_replace_address}}
> seems to think that the new replacement node is running when it shouldn’t
> be. We’ve got two confirmed failures, one on trunk and one on a recent
> trunk-based patch:
> https://ci-cassandra.apache.org/job/Cassandra-trunk/259/testReport/dtest-novnode.bootstrap_test/TestBootstrap/test_node_cannot_join_as_hibernating_node_without_replace_address/
> https://app.circleci.com/pipelines/github/adelapena/cassandra/79/workflows/1fa1cbcf-820d-438f-97bd-91e20a50baba/jobs/604
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16030) TestBootstrap::test_node_cannot_join_as_hibernating_node_without_replace_address failing on trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-16030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16030:
Fix Version/s: 4.0-rc
> TestBootstrap::test_node_cannot_join_as_hibernating_node_without_replace_address
> failing on trunk
> -
>
> Key: CASSANDRA-16030
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16030
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0-rc
>
>
> {{TestBootstrap::test_node_cannot_join_as_hibernating_node_without_replace_address}}
> seems to think that the new replacement node is running when it shouldn’t
> be. We’ve got two confirmed failures, one on trunk and one on a recent
> trunk-based patch:
> https://ci-cassandra.apache.org/job/Cassandra-trunk/259/testReport/dtest-novnode.bootstrap_test/TestBootstrap/test_node_cannot_join_as_hibernating_node_without_replace_address/
> https://app.circleci.com/pipelines/github/adelapena/cassandra/79/workflows/1fa1cbcf-820d-438f-97bd-91e20a50baba/jobs/604
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16030) TestBootstrap::test_node_cannot_join_as_hibernating_node_without_replace_address failing on trunk
Caleb Rackliffe created CASSANDRA-16030:
---
Summary:
TestBootstrap::test_node_cannot_join_as_hibernating_node_without_replace_address
failing on trunk
Key: CASSANDRA-16030
URL: https://issues.apache.org/jira/browse/CASSANDRA-16030
Project: Cassandra
Issue Type: Bug
Components: Test/dtest
Reporter: Caleb Rackliffe
{{TestBootstrap::test_node_cannot_join_as_hibernating_node_without_replace_address}}
seems to think that the new replacement node is running when it shouldn’t be.
We’ve got two confirmed failures, one on trunk and one on a recent trunk-based
patch:
https://ci-cassandra.apache.org/job/Cassandra-trunk/259/testReport/dtest-novnode.bootstrap_test/TestBootstrap/test_node_cannot_join_as_hibernating_node_without_replace_address/
https://app.circleci.com/pipelines/github/adelapena/cassandra/79/workflows/1fa1cbcf-820d-438f-97bd-91e20a50baba/jobs/604
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15459) Short read protection doesn't work on group-by queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171739#comment-17171739
]
Andres de la Peña commented on CASSANDRA-15459:
---
It seems that
{{test_node_cannot_join_as_hibernating_node_without_replace_address}} has
failed in the two last CI rounds for trunk
([259|https://ci-cassandra.apache.org/job/Cassandra-trunk/259/testReport/dtest-novnode.bootstrap_test/TestBootstrap/test_node_cannot_join_as_hibernating_node_without_replace_address/]
and
[258|https://ci-cassandra.apache.org/job/Cassandra-trunk/258/testReport/dtest-novnode.bootstrap_test/TestBootstrap/test_node_cannot_join_as_hibernating_node_without_replace_address/]),
and doesn't seem related with the changes.
> Short read protection doesn't work on group-by queries
> --
>
> Key: CASSANDRA-15459
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: ZhaoYang
>Assignee: Andres de la Peña
>Priority: Normal
> Labels: correctness
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> [DTest to
> reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]:
> it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate
> limits used for SRP query, rather than "row counted".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15459) Short read protection doesn't work on group-by queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171734#comment-17171734
]
Caleb Rackliffe commented on CASSANDRA-15459:
-
Also linked the run with what look like unrelated failures in {{TestRepair}} to
CASSANDRA-15986.
> Short read protection doesn't work on group-by queries
> --
>
> Key: CASSANDRA-15459
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: ZhaoYang
>Assignee: Andres de la Peña
>Priority: Normal
> Labels: correctness
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> [DTest to
> reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]:
> it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate
> limits used for SRP query, rather than "row counted".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15986) Repair tests flakiness
[ https://issues.apache.org/jira/browse/CASSANDRA-15986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171733#comment-17171733 ] Caleb Rackliffe commented on CASSANDRA-15986: - Just adding two more failure reports for reference: https://app.circleci.com/pipelines/github/adelapena/cassandra/79/workflows/a841da8f-d565-4608-85c6-1432733faeb3/jobs/606 https://app.circleci.com/pipelines/github/dineshjoshi/cassandra/47/workflows/de5f7cdb-06b6-4869-9d19-81a145e79f3f/jobs/2531 > Repair tests flakiness > -- > > Key: CASSANDRA-15986 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15986 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > Repair tests come up in test failure reports every now and then. I have tried > to repro the > [latest|https://ci-cassandra.apache.org/job/Cassandra-trunk/241/testReport/junit/dtest-novnode.repair_tests.repair_test/TestRepair/test_simple_sequential_repair/] > locally 100 times with no luck. > Still from experience from fixing other flaky tests I have some intuition > where the problems may lie. The proposed fix should add no harm if merged. We > can reopen the ticket if repair tests keep failing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15459) Short read protection doesn't work on group-by queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171731#comment-17171731
]
Caleb Rackliffe commented on CASSANDRA-15459:
-
I haven't seen the trunk failure of
[TestBootstrap::test_node_cannot_join_as_hibernating_node_without_replace_address|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/3/label=cassandra,split=16/testReport/junit/dtest.bootstrap_test/TestBootstrap/test_node_cannot_join_as_hibernating_node_without_replace_address/]
before, but it may just be flaky test that hasn't been reported yet. Otherwise
things look clean.
> Short read protection doesn't work on group-by queries
> --
>
> Key: CASSANDRA-15459
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: ZhaoYang
>Assignee: Andres de la Peña
>Priority: Normal
> Labels: correctness
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> [DTest to
> reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]:
> it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate
> limits used for SRP query, rather than "row counted".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16029) Create better Apache Cassandra 4.0 docs
Lorina Poland created CASSANDRA-16029: - Summary: Create better Apache Cassandra 4.0 docs Key: CASSANDRA-16029 URL: https://issues.apache.org/jira/browse/CASSANDRA-16029 Project: Cassandra Issue Type: Improvement Components: Documentation/Website Reporter: Lorina Poland Assignee: Lorina Poland Attachments: CurrentDocs.png, NewImprovedDocs.png The proof of concept to create new Documentation showed that a combination of the static site generator (SSG) Antora + Asciidoc files would provide the most flexibility in redesigning the Apache C* OSS pages. Current proof of concept: [https://polandll.github.io/site/Cassandra/4.0/] To update the docs, the tools to write needed an update, too, to provide a better UX and modern look and feel. The old tools (reStructured Text, Sphinx) will be replaced with the new tools ([AsciiDoc|http://asciidoc.org], [Antora|http://antora.org]). See the attachments for screenshots of the current docs and the POC docs. The advantages of asciidoc+antora: * Rich markdown language that is directly editable. * Good organizational structure for docs files * Flexible build/publishing capabilities, including content from multiple repositories and branches * Flexible web UI, built separately from the doc files and static site. * JS extensions that enable additional functionality. To complete the conversion, the following steps are required: * Pandoc used for conversion of rSt files to adoc files ** Followed by significant manual editing to fix the errors left over after conversion * Creation of new antora files (site.yml, antora.yml, CSS and layout) ** Integration with plug-ins (lunr for search, tabs for additional codeblock capabilities) ** Finish the UI to match current Apache C* UI, or engage designer to do a new design *** Put the ASF pulldown in the main header banner, like Apache Spark does ([https://spark.apache.org/downloads.html]) * Modification of build scripts to work with Antora ** Modification of python scripts that generation YAML and nodetool docs *** Make sure that these scripts are run for each version ** Modification of cassandra/doc Makefile ** Dockerfile and docker-entrypoint.sh files to use Docker for documentation build * Modification of cassandra-website to work with Antora ** Dockerfile and docker-entrypoint.sh files to use Docker for documentation build * Figure out how to handle older versions that are not converted to asciidoc now ** Put in TBD? Copy 4.0 branch with note to rewrite later? * Figure out why tabs-block antora extension is working locally but not in GH pages (may or may not be important) Other tasks: * Complete conversion, plus editing the current docs before Apache C* 4.0 GA * Further improvements for docs organization ** [https://docs.google.com/document/d/1aeNtgyPAsKcNa0GSKvl2ywlFEj30714ry4Sb5turWeE/edit?usp=sharing] ** Get some sections out of Docs, like Developing Code info -> Community * Solve the issue of CQL highlighting/lexer/parser issue ** Need CQL to be submitted to pygments * Addition of more useful documentation - tutorials, how-to guides, separate reference guide Current work: [https://github.com/polandll/cassandra/blob/doc_redo_asciidoc/|https://github.com/polandll/cassandra/blob/doc_redo_asciidoc/doc/Dockerfile] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15459) Short read protection doesn't work on group-by queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171713#comment-17171713
]
Andres de la Peña commented on CASSANDRA-15459:
---
New CI round:
||PR||utest||dtest||CircleCI j8||CircleCI j11||
|[3.11
|https://github.com/apache/cassandra/pull/635]|[206|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-test/206/]|[2|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/2/]|[link|https://app.circleci.com/pipelines/github/adelapena/cassandra/77/workflows/e0030e7d-bdc3-4584-b82d-4eea55bbc599]|-|
|[trunk|https://github.com/apache/cassandra/pull/636]|[207|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-test/207/]|[3|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/3/]|[link|https://app.circleci.com/pipelines/github/adelapena/cassandra/79/workflows/1fa1cbcf-820d-438f-97bd-91e20a50baba]|[link|https://app.circleci.com/pipelines/github/adelapena/cassandra/79/workflows/a841da8f-d565-4608-85c6-1432733faeb3]|
> Short read protection doesn't work on group-by queries
> --
>
> Key: CASSANDRA-15459
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: ZhaoYang
>Assignee: Andres de la Peña
>Priority: Normal
> Labels: correctness
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> [DTest to
> reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]:
> it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate
> limits used for SRP query, rather than "row counted".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15976) Incorrect parsing of the timestamp with less than 3 digits in the milliseconds
[
https://issues.apache.org/jira/browse/CASSANDRA-15976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg reassigned CASSANDRA-15976:
-
Assignee: Adam Holmberg
> Incorrect parsing of the timestamp with less than 3 digits in the milliseconds
> --
>
> Key: CASSANDRA-15976
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15976
> Project: Cassandra
> Issue Type: Bug
>Reporter: Alex Ott
>Assignee: Adam Holmberg
>Priority: Normal
>
> (tested on 4.0-beta1, but should be in all versions)
> Right now, Cassandra incorrectly handles timestamps with less than 3 digits
> in the milliseconds part. Timestamps (valid from the Java point of view (see
> below output in Scala) are either rejected (if we have 1 digit only), or
> incorrectly parsed when 2 digits are specified:
> {noformat}
> cqlsh> create table test.tm (id int primary key, tm timestamp);
> cqlsh> insert into test.tm(id, tm) values (2, '2020-07-24T10:00:01.2Z');
> InvalidRequest: Error from server: code=2200 [Invalid query] message="Unable
> to coerce '2020-07-24T10:00:01.2Z' to a formatted date (long)"
> cqlsh> insert into test.tm(id, tm) values (1, '2020-07-24T10:00:01.12Z');
> cqlsh> select * from test.tm;
> id | tm
> +-
> 1 | 2020-07-24 10:00:01.012000+
> (1 rows)
> {noformat}
> Checking with Instant:
> {noformat}
> scala> java.time.Instant.parse("2020-07-24T10:00:01.12Z")
> res0: java.time.Instant = 2020-07-24T10:00:01.120Z
> scala> java.time.Instant.parse("2020-07-24T10:00:01.2Z")
> res1: java.time.Instant = 2020-07-24T10:00:01.200Z
> {noformat}
> Imho it should be fixed (Cc: [~aholmber])
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
[
https://issues.apache.org/jira/browse/CASSANDRA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16028:
-
Since Version: 2.1.21
Source Control Link:
https://github.com/apache/cassandra/commit/f93c5631636020cd3fa1f39d0ac92959102bd5eb
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed, thanks!
> cqlsh tests broken in Python 3.7+
> -
>
> Key: CASSANDRA-16028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> {code:java}
> // cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
> if not isinstance(until, re._pattern_type):
> AttributeError: module 're' has no attribute '_pattern_type'
> {code}
> An internal module attribute was changed/removed from Python 3.7 on.
> [https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272]
> This breakage did not manifest in CI because the test use the Jenkins host
> system Python, which is 3.6.
> I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
[
https://issues.apache.org/jira/browse/CASSANDRA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16028:
-
Reviewers: Brandon Williams, Brandon Williams (was: Brandon Williams)
Brandon Williams, Brandon Williams
Status: Review In Progress (was: Patch Available)
> cqlsh tests broken in Python 3.7+
> -
>
> Key: CASSANDRA-16028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> {code:java}
> // cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
> if not isinstance(until, re._pattern_type):
> AttributeError: module 're' has no attribute '_pattern_type'
> {code}
> An internal module attribute was changed/removed from Python 3.7 on.
> [https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272]
> This breakage did not manifest in CI because the test use the Jenkins host
> system Python, which is 3.6.
> I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Make cqlsh tests with with Python 3.7 re changes
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new f93c563 Make cqlsh tests with with Python 3.7 re changes
f93c563 is described below
commit f93c5631636020cd3fa1f39d0ac92959102bd5eb
Author: Adam Holmberg
AuthorDate: Wed Aug 5 13:18:43 2020 -0500
Make cqlsh tests with with Python 3.7 re changes
Patch by Adam Holmberg, reviewed by brandonwilliams for CASSANDRA-16028
---
pylib/cqlshlib/test/run_cqlsh.py | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/pylib/cqlshlib/test/run_cqlsh.py b/pylib/cqlshlib/test/run_cqlsh.py
index 1c90d58..2d0931c 100644
--- a/pylib/cqlshlib/test/run_cqlsh.py
+++ b/pylib/cqlshlib/test/run_cqlsh.py
@@ -43,6 +43,12 @@ else:
DEFAULT_CQLSH_PROMPT = DEFAULT_PREFIX + '(\S+@)?cqlsh(:\S+)?> '
DEFAULT_CQLSH_TERM = 'xterm'
+try:
+Pattern = re._pattern_type
+except AttributeError:
+# Python 3.7+
+Pattern = re.Pattern
+
def get_smm_sequence(term='xterm'):
"""
Return the set meta mode (smm) sequence, if any.
@@ -218,7 +224,7 @@ class ProcRunner:
def read_until(self, until, blksize=4096, timeout=None,
flags=0, ptty_timeout=None, replace=[]):
-if not isinstance(until, re._pattern_type):
+if not isinstance(until, Pattern):
until = re.compile(until, flags)
cqlshlog.debug("Searching for %r" % (until.pattern,))
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
[
https://issues.apache.org/jira/browse/CASSANDRA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16028:
-
Status: Ready to Commit (was: Review In Progress)
> cqlsh tests broken in Python 3.7+
> -
>
> Key: CASSANDRA-16028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> {code:java}
> // cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
> if not isinstance(until, re._pattern_type):
> AttributeError: module 're' has no attribute '_pattern_type'
> {code}
> An internal module attribute was changed/removed from Python 3.7 on.
> [https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272]
> This breakage did not manifest in CI because the test use the Jenkins host
> system Python, which is 3.6.
> I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
[
https://issues.apache.org/jira/browse/CASSANDRA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-16028:
--
Test and Documentation Plan:
repro/validation:
- activate python 3.7+
- cd pylib/cqlshlib; nosetests
- apply patch
- run tests again, expecting success
- activate python 3.6 and/or 2.7 and verify
No docs required.
Status: Patch Available (was: In Progress)
https://github.com/apache/cassandra/pull/710
> cqlsh tests broken in Python 3.7+
> -
>
> Key: CASSANDRA-16028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> {code:java}
> // cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
> if not isinstance(until, re._pattern_type):
> AttributeError: module 're' has no attribute '_pattern_type'
> {code}
> An internal module attribute was changed/removed from Python 3.7 on.
> [https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272]
> This breakage did not manifest in CI because the test use the Jenkins host
> system Python, which is 3.6.
> I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
[
https://issues.apache.org/jira/browse/CASSANDRA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-16028:
--
Description:
{code:java}
// cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
if not isinstance(until, re._pattern_type):
AttributeError: module 're' has no attribute '_pattern_type'
{code}
An internal module attribute was changed/removed from Python 3.7 on.
[https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272]
This breakage did not manifest in CI because the test use the Jenkins host
system Python, which is 3.6.
I have a trivial patch I'll add shortly.
was:
{code:java}
// cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
if not isinstance(until, re._pattern_type):
AttributeError: module 're' has no attribute '_pattern_type'
{code}
An internal module attribute was changed/removed from Python 3.7 on.
This breakage did not manifest in CI because the test use the Jenkins host
system Python, which is 3.6.
I have a trivial patch I'll add shortly.
> cqlsh tests broken in Python 3.7+
> -
>
> Key: CASSANDRA-16028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> {code:java}
> // cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
> if not isinstance(until, re._pattern_type):
> AttributeError: module 're' has no attribute '_pattern_type'
> {code}
> An internal module attribute was changed/removed from Python 3.7 on.
> [https://github.com/python/cpython/pull/1646/files#diff-daea55f2fca784d9a64ca8f190403904R267-L272]
> This breakage did not manifest in CI because the test use the Jenkins host
> system Python, which is 3.6.
> I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15873) Update Netty 4.0.44 -> 4.1.50 (fix security/performance issues)
[
https://issues.apache.org/jira/browse/CASSANDRA-15873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171661#comment-17171661
]
Brandon Williams commented on CASSANDRA-15873:
--
I ran them again here:
[https://ci-cassandra.apache.org/job/Cassandra-devbranch/230/]
A lot of those can probably be ignore, but I'm talking about the ones like
this:
[https://ci-cassandra.apache.org/job/Cassandra-devbranch/230/testReport/junit/dtest.materialized_views_test/TestMaterializedViews/test_view_metadata_cleanup/]
{code:java}
Unexpected error found in node logs (see stdout for full details). Errors:
[WARN [epollEventLoopGroup-2-8] 2020-08-05 17:37:18,666
AbstractChannelHandlerContext.java:311 - An exception
'java.lang.NullPointerException' [enable DEBUG level for full stacktrace] was
thrown by a user handler's exceptionCaught() method while handling the
following exception:
java.nio.channels.ClosedChannelException: null
{code}
This one:
https://ci-cassandra.apache.org/job/Cassandra-devbranch/230/testReport/junit/dtest.native_transport_ssl_test/TestNativeTransportSSL/test_connect_to_ssl/
also looks a bit fishy.
Here's a random run from trunk to compare (also not completely successful,
that's still rare): https://ci-cassandra.apache.org/job/Cassandra-trunk/258/
> Update Netty 4.0.44 -> 4.1.50 (fix security/performance issues)
> ---
>
> Key: CASSANDRA-15873
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15873
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Matt Davis
>Priority: Normal
> Fix For: 3.11.x
>
> Attachments: dependency-check-report.html, unittest_netty.log
>
>
> See https://issues.apache.org/jira/browse/CASSANDRA-15868 for the same issue
> on 4.0 / trunk. Attached is an OWASP dependency report for Netty 4.0.44,
> which identifies 3 of the same vulnerabilities as above.
>
> Additionally, 4.1.50 contains aarch64 native libraries which can improve
> performance on ARM processors.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
[
https://issues.apache.org/jira/browse/CASSANDRA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-16028:
--
Bug Category: Parent values: Code(13163)
Complexity: Low Hanging Fruit
Discovered By: Unit Test
Fix Version/s: 4.0-beta2
Severity: Low
Status: Open (was: Triage Needed)
> cqlsh tests broken in Python 3.7+
> -
>
> Key: CASSANDRA-16028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Adam Holmberg
>Assignee: Adam Holmberg
>Priority: Normal
> Fix For: 4.0-beta2
>
>
> {code:java}
> // cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
> if not isinstance(until, re._pattern_type):
> AttributeError: module 're' has no attribute '_pattern_type'
> {code}
> An internal module attribute was changed/removed from Python 3.7 on.
> This breakage did not manifest in CI because the test use the Jenkins host
> system Python, which is 3.6.
> I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16028) cqlsh tests broken in Python 3.7+
Adam Holmberg created CASSANDRA-16028:
-
Summary: cqlsh tests broken in Python 3.7+
Key: CASSANDRA-16028
URL: https://issues.apache.org/jira/browse/CASSANDRA-16028
Project: Cassandra
Issue Type: Bug
Components: Tool/cqlsh
Reporter: Adam Holmberg
Assignee: Adam Holmberg
{code:java}
// cassandra/pylib/cqlshlib/test/run_cqlsh.py", line 221, in read_until
if not isinstance(until, re._pattern_type):
AttributeError: module 're' has no attribute '_pattern_type'
{code}
An internal module attribute was changed/removed from Python 3.7 on.
This breakage did not manifest in CI because the test use the Jenkins host
system Python, which is 3.6.
I have a trivial patch I'll add shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15459) Short read protection doesn't work on group-by queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171622#comment-17171622
]
Caleb Rackliffe edited comment on CASSANDRA-15459 at 8/5/20, 5:03 PM:
--
+1 on both 3.11 and trunk PRs (and the decision to discard the Python dtest PR)
Especially w/ the trunk patch, there are some nice simplifications/readability
improvements.
Might want to run the unit tests one more time to account for CASSANDRA-15872
and CASSANDRA-15677.
was (Author: maedhroz):
+1 on both 3.11 and trunk PRs (and the decision to discard the Python dtest PR)
Especially w/ the trunk patch, there are some nice simplifications/readability
improvements.
Might want to run the unit tests one more time to account for CASSANDRA-15872.
> Short read protection doesn't work on group-by queries
> --
>
> Key: CASSANDRA-15459
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: ZhaoYang
>Assignee: Andres de la Peña
>Priority: Normal
> Labels: correctness
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> [DTest to
> reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]:
> it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate
> limits used for SRP query, rather than "row counted".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15459) Short read protection doesn't work on group-by queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171622#comment-17171622
]
Caleb Rackliffe commented on CASSANDRA-15459:
-
+1 on both 3.11 and trunk PRs (and the decision to discard the Python dtest PR)
Especially w/ the trunk patch, there are some nice simplifications/readability
improvements.
Might want to run the unit tests one more time to account for CASSANDRA-15872.
> Short read protection doesn't work on group-by queries
> --
>
> Key: CASSANDRA-15459
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: ZhaoYang
>Assignee: Andres de la Peña
>Priority: Normal
> Labels: correctness
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> [DTest to
> reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]:
> it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate
> limits used for SRP query, rather than "row counted".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14425) cassandra-stress doesn't report correctly when profile file is not found
[ https://issues.apache.org/jira/browse/CASSANDRA-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14425: - Since Version: 3.6 Source Control Link: https://github.com/apache/cassandra/commit/6d9465a00dc26ad0ba589252686de52b4a537bd9 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed, thanks! > cassandra-stress doesn't report correctly when profile file is not found > > > Key: CASSANDRA-14425 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14425 > Project: Cassandra > Issue Type: Bug > Components: Tool/stress >Reporter: Alex Ott >Assignee: Alex Ott >Priority: Low > Fix For: 4.0-beta2 > > > Right now, when there is an error in the profile file name cassandra-stress > reports very not understandable error "URI is not absolute" instead of > reporting something like "File doesn't exist" or something like. > It would be very helpful to improve user experience by reporting correct > reason for error. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14425) cassandra-stress doesn't report correctly when profile file is not found
[ https://issues.apache.org/jira/browse/CASSANDRA-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14425: - Status: Ready to Commit (was: Review In Progress) > cassandra-stress doesn't report correctly when profile file is not found > > > Key: CASSANDRA-14425 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14425 > Project: Cassandra > Issue Type: Bug > Components: Tool/stress >Reporter: Alex Ott >Assignee: Alex Ott >Priority: Low > Fix For: 4.0-beta2 > > > Right now, when there is an error in the profile file name cassandra-stress > reports very not understandable error "URI is not absolute" instead of > reporting something like "File doesn't exist" or something like. > It would be very helpful to improve user experience by reporting correct > reason for error. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14425) cassandra-stress doesn't report correctly when profile file is not found
[ https://issues.apache.org/jira/browse/CASSANDRA-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14425: - Reviewers: Brandon Williams, Brandon Williams (was: Brandon Williams) Brandon Williams, Brandon Williams Status: Review In Progress (was: Patch Available) > cassandra-stress doesn't report correctly when profile file is not found > > > Key: CASSANDRA-14425 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14425 > Project: Cassandra > Issue Type: Bug > Components: Tool/stress >Reporter: Alex Ott >Assignee: Alex Ott >Priority: Low > Fix For: 4.0-beta2 > > > Right now, when there is an error in the profile file name cassandra-stress > reports very not understandable error "URI is not absolute" instead of > reporting something like "File doesn't exist" or something like. > It would be very helpful to improve user experience by reporting correct > reason for error. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Improve cassandra-stress logging when using a profile file that doesn't exist.
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 6d9465a Improve cassandra-stress logging when using a profile file
that doesn't exist.
6d9465a is described below
commit 6d9465a00dc26ad0ba589252686de52b4a537bd9
Author: Alex Ott
AuthorDate: Sat Apr 28 19:35:17 2018 +0200
Improve cassandra-stress logging when using a profile file that doesn't
exist.
Patch by Alex Ott, reviewed by brandonwilliams for CASSANDRA-14425
---
CHANGES.txt | 1 +
tools/stress/src/org/apache/cassandra/stress/Stress.java| 12
.../cassandra/stress/settings/SettingsCommandUser.java | 13 -
3 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 7287c0b..dcefef0 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0-beta2
+ * Improve cassandra-stress logging when using a profile file that doesn't
exist (CASSANDRA-14425)
* Improve logging for socket connection/disconnection (CASSANDRA-15980)
* Throw FSWriteError upon write failures in order to apply DiskFailurePolicy
(CASSANDRA-15928)
* Forbid altering UDTs used in partition keys (CASSANDRA-15933)
diff --git a/tools/stress/src/org/apache/cassandra/stress/Stress.java
b/tools/stress/src/org/apache/cassandra/stress/Stress.java
index 3c0fa96..1fd808f 100644
--- a/tools/stress/src/org/apache/cassandra/stress/Stress.java
+++ b/tools/stress/src/org/apache/cassandra/stress/Stress.java
@@ -26,6 +26,7 @@ import org.apache.cassandra.stress.settings.StressSettings;
import org.apache.cassandra.stress.util.MultiResultLogger;
import org.apache.cassandra.utils.FBUtilities;
import org.apache.cassandra.utils.WindowsTimer;
+import org.apache.commons.lang3.exception.ExceptionUtils;
public final class Stress
{
@@ -87,6 +88,17 @@ public final class Stress
printHelpMessage();
return 1;
}
+catch (Throwable e)
+{
+ Throwable rc = ExceptionUtils.getRootCause(e);
+ if (rc instanceof FileNotFoundException)
+ {
+System.out.printf("File '%s' doesn't exist!%n",
rc.getMessage());
+printHelpMessage();
+return 1;
+ }
+ throw e;
+}
MultiResultLogger logout = settings.log.getOutput();
diff --git
a/tools/stress/src/org/apache/cassandra/stress/settings/SettingsCommandUser.java
b/tools/stress/src/org/apache/cassandra/stress/settings/SettingsCommandUser.java
index fd34d74..cbf8a3a 100644
---
a/tools/stress/src/org/apache/cassandra/stress/settings/SettingsCommandUser.java
+++
b/tools/stress/src/org/apache/cassandra/stress/settings/SettingsCommandUser.java
@@ -22,6 +22,7 @@ package org.apache.cassandra.stress.settings;
import java.io.File;
+import java.io.FileNotFoundException;
import java.net.URI;
import java.util.Arrays;
import java.util.Collections;
@@ -73,7 +74,17 @@ public class SettingsCommandUser extends SettingsCommand
for (String curYamlPath : yamlPaths)
{
File yamlFile = new File(curYamlPath);
-StressProfile profile = StressProfile.load(yamlFile.exists() ?
yamlFile.toURI() : URI.create(curYamlPath));
+URI yamlURI;
+if (yamlFile.exists()) {
+ yamlURI = yamlFile.toURI();
+} else {
+ yamlURI = URI.create(curYamlPath);
+ String uriScheme = yamlURI.getScheme();
+ if (uriScheme == null || "file".equals(uriScheme)) {
+throw new IllegalArgumentException("File '" +
yamlURI.getPath() + "' doesn't exist!");
+ }
+}
+StressProfile profile = StressProfile.load(yamlURI);
String specName = profile.specName;
if (default_profile_name == null) {default_profile_name=specName;}
//first file is default
if (profiles.containsKey(specName))
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] branch master updated: ninja-fix: dtest-large jobs need smaller number of splits (empty splits fail bc no test reports)
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git
The following commit(s) were added to refs/heads/master by this push:
new 5033442 ninja-fix: dtest-large jobs need smaller number of splits
(empty splits fail bc no test reports)
5033442 is described below
commit 50334421d70cbaff1a024db4b7f293a00da46d9c
Author: mck
AuthorDate: Wed Aug 5 18:52:18 2020 +0200
ninja-fix: dtest-large jobs need smaller number of splits (empty splits
fail bc no test reports)
---
jenkins-dsl/cassandra_job_dsl_seed.groovy | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/jenkins-dsl/cassandra_job_dsl_seed.groovy
b/jenkins-dsl/cassandra_job_dsl_seed.groovy
index fdc53fc..646acb8 100644
--- a/jenkins-dsl/cassandra_job_dsl_seed.groovy
+++ b/jenkins-dsl/cassandra_job_dsl_seed.groovy
@@ -443,10 +443,11 @@ cassandraBranches.each {
axes {
List values = new ArrayList()
if (targetName == 'dtest-large') {
-(1..dtestLargeSplits).each { values << it.toString() }
+splits = dtestLargeSplits
} else {
-(1..dtestSplits).each { values << it.toString() }
+splits = dtestSplits
}
+(1..splits).each { values << it.toString() }
text('split', values)
label('label', slaveLabel)
}
@@ -454,7 +455,7 @@ cassandraBranches.each {
node / scm / branches / 'hudson.plugins.git.BranchSpec' /
name(branchName)
}
steps {
-shell("sh
./cassandra-builds/docker/jenkins/jenkinscommand.sh apache ${branchName}
https://github.com/apache/cassandra-dtest.git master ${buildsRepo}
${buildsBranch} ${dtestDockerImage} ${targetName} \${split}/${dtestSplits}")
+shell("sh
./cassandra-builds/docker/jenkins/jenkinscommand.sh apache ${branchName}
https://github.com/apache/cassandra-dtest.git master ${buildsRepo}
${buildsBranch} ${dtestDockerImage} ${targetName} \${split}/${splits}")
}
}
}
@@ -692,7 +693,12 @@ dtestTargets.each {
}
axes {
List values = new ArrayList()
-(1..dtestSplits).each { values << it.toString() }
+if (targetName == 'dtest-large') {
+splits = dtestLargeSplits
+} else {
+splits = dtestSplits
+}
+(1..splits).each { values << it.toString() }
text('split', values)
label('label', slaveLabel)
}
@@ -714,7 +720,7 @@ dtestTargets.each {
steps {
buildDescription('', buildDescStr)
shell("git clean -xdff ; git clone --depth 1 --single-branch -b
${buildsBranch} ${buildsRepo}")
-shell("sh ./cassandra-builds/docker/jenkins/jenkinscommand.sh
\$REPO \$BRANCH \$DTEST_REPO \$DTEST_BRANCH ${buildsRepo} ${buildsBranch}
\$DOCKER_IMAGE ${targetName} \${split}/${dtestSplits}")
+shell("sh ./cassandra-builds/docker/jenkins/jenkinscommand.sh
\$REPO \$BRANCH \$DTEST_REPO \$DTEST_BRANCH ${buildsRepo} ${buildsBranch}
\$DOCKER_IMAGE ${targetName} \${split}/${splits}")
}
publishers {
archiveArtifacts {
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] branch master updated: ninja-fix: dtest-large jobs need smaller number of splits (empty splits fail bc no test reports)
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git
The following commit(s) were added to refs/heads/master by this push:
new cdfa72a ninja-fix: dtest-large jobs need smaller number of splits
(empty splits fail bc no test reports)
cdfa72a is described below
commit cdfa72a892d5048f3590fada007ac5236ea81e8e
Author: mck
AuthorDate: Wed Aug 5 18:19:51 2020 +0200
ninja-fix: dtest-large jobs need smaller number of splits (empty splits
fail bc no test reports)
---
jenkins-dsl/cassandra_job_dsl_seed.groovy | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/jenkins-dsl/cassandra_job_dsl_seed.groovy
b/jenkins-dsl/cassandra_job_dsl_seed.groovy
index 4047963..fdc53fc 100644
--- a/jenkins-dsl/cassandra_job_dsl_seed.groovy
+++ b/jenkins-dsl/cassandra_job_dsl_seed.groovy
@@ -70,9 +70,13 @@ if(binding.hasVariable("MAX_JOB_HOURS")) {
// how many splits are dtest jobs matrixed into
def dtestSplits = 64
+def dtestLargeSplits = 8
if(binding.hasVariable("DTEST_SPLITS")) {
dtestSplits = "${DTEST_SPLITS}"
}
+if(binding.hasVariable("DTEST_LARGE_SPLITS")) {
+dtestLargeSplits = "${DTEST_LARGE_SPLITS}"
+}
//
@@ -438,7 +442,11 @@ cassandraBranches.each {
using('Cassandra-template-dtest-matrix')
axes {
List values = new ArrayList()
-(1..dtestSplits).each { values << it.toString() }
+if (targetName == 'dtest-large') {
+(1..dtestLargeSplits).each { values << it.toString() }
+} else {
+(1..dtestSplits).each { values << it.toString() }
+}
text('split', values)
label('label', slaveLabel)
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15459) Short read protection doesn't work on group-by queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-15459:
Status: Review In Progress (was: Changes Suggested)
> Short read protection doesn't work on group-by queries
> --
>
> Key: CASSANDRA-15459
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: ZhaoYang
>Assignee: Andres de la Peña
>Priority: Normal
> Labels: correctness
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> [DTest to
> reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]:
> it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate
> limits used for SRP query, rather than "row counted".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16006) Parallelise Jenkins dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-16006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16006: --- Fix Version/s: (was: 4.0-rc) 4.0-beta2 Source Control Link: https://github.com/apache/cassandra-builds/commit/6fc260ae265e7c8f8c29445264ae143e1693cf14 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as [6fc260ae265e7c8f8c29445264ae143e1693cf14 |https://github.com/apache/cassandra-builds/commit/6fc260ae265e7c8f8c29445264ae143e1693cf14]. > Parallelise Jenkins dtests > -- > > Key: CASSANDRA-16006 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16006 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.0-beta2 > > > Currently dtests in Jenkins take ~10 hours. > Using the Jenkins Matrix plugin these jobs can be split into smaller lists of > dtests and run in parallel. This is the approach CircleCI takes. > This approach was > [trialed|https://github.com/apache/cassandra-builds/pull/29] with the > dtest-upgrade jobs (which are not yet part of the branch pipelines, and > haven't previously worked at all due to their duration). > In addition to the Matrix plugin, the Priority-Sorter and Matrix Reloaded > plugins also needed to be added. > The splits will occupy all executors, and multiple builds will lead to a long > build queue. More important builds (artifacts and unit tests) need a way to > be prioritised in such saturated situations. > Splits can fail for silly reasons (false-positive), like > [full|https://issues.apache.org/jira/browse/INFRA-19793] /tmp disks, or > [connectivity issues|https://issues.apache.org/jira/browse/INFRA-20107] > between the donated agent servers. The Matrix Reloaded plugin makes it easy > to rebuilt just those failed splits. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13701) Lower default num_tokens
[ https://issues.apache.org/jira/browse/CASSANDRA-13701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171556#comment-17171556 ] Jeremy Hanna edited comment on CASSANDRA-13701 at 8/5/20, 3:29 PM: --- I started down this road but don't think I can get through fixing all of the dtests. On this line in bootstrap-test.py I changed the time.sleep to 10 seconds and it appears to solve that problem - https://github.com/apache/cassandra-dtest/blob/master/bootstrap_test.py#L485 However there were many tests with replace_address that I'm not sure about. I don't know how or why replace address would be affected by the new token allocation algorithm. Dimitar said something about parallel bootstrap but I don't see that - sometimes no_wait or wait_other_notice is true or false so I thought it was that, but perhaps someone more familiar with ccm could see. I'm sorry - I really want this to get in for the release but I don't have the time to dedicate to learning dtest at a deeper level to fix all of these in time. was (Author: jeromatron): I started down this road but don't think I can get through fixing all of the dtests. On this line in bootstrap-test.py I changed the time.sleep to 10 seconds and it appears to solve that problem - https://github.com/apache/cassandra-dtest/blob/master/bootstrap_test.py#L485 However there were many tests with replace_address that I'm not sure about. I don't know how or why replace address would be affected by the new token allocation algorithm. Dmitri said something about parallel bootstrap but I don't see that - sometimes no_wait or wait_other_notice is true or false so I thought it was that, but perhaps someone more familiar with ccm could see. I'm sorry - I really want this to get in for the release but I don't have the time to dedicate to learning dtest at a deeper level to fix all of these in time. > Lower default num_tokens > > > Key: CASSANDRA-13701 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13701 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Chris Lohfink >Priority: Low > Fix For: 4.0-alpha > > > For reasons highlighted in CASSANDRA-7032, the high number of vnodes is not > necessary. It is very expensive for operations processes and scanning. Its > come up a lot and its pretty standard and known now to always reduce the > num_tokens within the community. We should just lower the defaults. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13701) Lower default num_tokens
[ https://issues.apache.org/jira/browse/CASSANDRA-13701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-13701: -- Fix Version/s: (was: 4.0-beta) 4.0-alpha > Lower default num_tokens > > > Key: CASSANDRA-13701 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13701 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Chris Lohfink >Assignee: Jeremy Hanna >Priority: Low > Fix For: 4.0-alpha > > > For reasons highlighted in CASSANDRA-7032, the high number of vnodes is not > necessary. It is very expensive for operations processes and scanning. Its > come up a lot and its pretty standard and known now to always reduce the > num_tokens within the community. We should just lower the defaults. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13701) Lower default num_tokens
[ https://issues.apache.org/jira/browse/CASSANDRA-13701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171556#comment-17171556 ] Jeremy Hanna commented on CASSANDRA-13701: -- I started down this road but don't think I can get through fixing all of the dtests. On this line in bootstrap-test.py I changed the time.sleep to 10 seconds and it appears to solve that problem - https://github.com/apache/cassandra-dtest/blob/master/bootstrap_test.py#L485 However there were many tests with replace_address that I'm not sure about. I don't know how or why replace address would be affected by the new token allocation algorithm. Dmitri said something about parallel bootstrap but I don't see that - sometimes no_wait or wait_other_notice is true or false so I thought it was that, but perhaps someone more familiar with ccm could see. I'm sorry - I really want this to get in for the release but I don't have the time to dedicate to learning dtest at a deeper level to fix all of these in time. > Lower default num_tokens > > > Key: CASSANDRA-13701 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13701 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Chris Lohfink >Priority: Low > Fix For: 4.0-alpha > > > For reasons highlighted in CASSANDRA-7032, the high number of vnodes is not > necessary. It is very expensive for operations processes and scanning. Its > come up a lot and its pretty standard and known now to always reduce the > num_tokens within the community. We should just lower the defaults. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-13701) Lower default num_tokens
[ https://issues.apache.org/jira/browse/CASSANDRA-13701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Hanna reassigned CASSANDRA-13701: Assignee: (was: Jeremy Hanna) > Lower default num_tokens > > > Key: CASSANDRA-13701 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13701 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Chris Lohfink >Priority: Low > Fix For: 4.0-alpha > > > For reasons highlighted in CASSANDRA-7032, the high number of vnodes is not > necessary. It is very expensive for operations processes and scanning. Its > come up a lot and its pretty standard and known now to always reduce the > num_tokens within the community. We should just lower the defaults. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15873) Update Netty 4.0.44 -> 4.1.50 (fix security/performance issues)
[ https://issues.apache.org/jira/browse/CASSANDRA-15873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171510#comment-17171510 ] Matt Davis commented on CASSANDRA-15873: [~brandon.williams] - I may not understand the nature of the failures you saw in CI, it appears to me they are random and happen on a small number of test iterations, rather than specific tests failing. Is that correct? If so, makes it very difficult to track down why the change would cause failures. Could you point me to a successful run for comparison? > Update Netty 4.0.44 -> 4.1.50 (fix security/performance issues) > --- > > Key: CASSANDRA-15873 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15873 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Matt Davis >Priority: Normal > Fix For: 3.11.x > > Attachments: dependency-check-report.html, unittest_netty.log > > > See https://issues.apache.org/jira/browse/CASSANDRA-15868 for the same issue > on 4.0 / trunk. Attached is an OWASP dependency report for Netty 4.0.44, > which identifies 3 of the same vulnerabilities as above. > > Additionally, 4.1.50 contains aarch64 native libraries which can improve > performance on ARM processors. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15889) Debian package fails to download on Arm-based hosts
[
https://issues.apache.org/jira/browse/CASSANDRA-15889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171507#comment-17171507
]
Matt Davis commented on CASSANDRA-15889:
Have not tested it yet, I'll try to get to it this week. If I understand the
documentation correctly that flag shouldn't be necessary, we probably need
guidance here from someone with more Debian packaging experience.
> Debian package fails to download on Arm-based hosts
> ---
>
> Key: CASSANDRA-15889
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15889
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Matt Davis
>Priority: Normal
> Labels: ARM, debian
>
> Following the first three steps of the [Debian install
> process|https://cassandra.apache.org/download/], after an apt-get update
> you'll see this line:
> {code:bash}
> $ sudo apt-get update
> ...
> N: Skipping acquire of configured file 'main/binary-arm64/Packages' as
> repository 'https://downloads.apache.org/cassandra/debian 311x InRelease'
> doesn't support architecture 'arm64'
> {code}
> Checking the [Debian
> repo|https://dl.bintray.com/apache/cassandra/dists/311x/main/] confirms there
> is no aarch64 variant available.
> Should you then attempt to install Cassandra:
> {code:bash}
> $ sudo apt-get install cassandra
> Reading package lists... Done
> Building dependency tree
> Reading state information... Done
> Package cassandra is not available, but is referred to by another package.
> This may mean that the package is missing, has been obsoleted, or
> is only available from another source
> E: Package 'cassandra' has no installation candidate
> {code}
> The Redhat RPM contains a "noarch" arch type, so it will download on any
> host. (Cassandra does not use separate binaries/releases for different
> architectures, so this seems to be the correct approach, but adding an
> aarch64 variant would also suffice.)
> Note that there is a workaround available: if you specify "amd64" as the arch
> for the source, it downloads and runs on Arm without issue:
> {code:bash}
> deb [arch=amd64] https://downloads.apache.org/cassandra/debian 311x main
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15980) Improve log messages for socket connection/disconnection
[
https://issues.apache.org/jira/browse/CASSANDRA-15980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-15980:
--
Fix Version/s: (was: 4.0-beta)
4.0-beta2
Since Version: 4.0-alpha1
Source Control Link:
[c9b41c1f8ad03719918c4d3c29719056ae6b3995|https://github.com/apache/cassandra/commit/c9b41c1f8ad03719918c4d3c29719056ae6b3995]
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Improve log messages for socket connection/disconnection
>
>
> Key: CASSANDRA-15980
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15980
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Logging
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 4.0-beta2
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Logging for inbound SSL connections can take place before protocol
> negotiation has taken place and logs a misleading cipher that could cause
> problems for security auditing.
>
>
> {code:java}
> INFO 2020-07-03T13:57:58,380 [Messaging-EventLoop-3-1]
> org.apache.cassandra.net.InboundConnectionInitiator:242 - connection from
> peer /1.1.1.1:57899 to /2.2.2.2:7000, protocol = TLSv1.2, cipher suite =
> SSL_NULL_WITH_NULL_NULL
> {code}
>
> Instead Cassandra should log the connection & protocol, then once the cipher
> has been negotiated log the agreed upon cipher.
>
>
> If the inbound SSL connection does not present a client certificate,
> Cassandra logs this error, even if the client wasn't required to.
> {code:java}
> ERROR 2020-07-14T11:58:45,925 [Native-Transport-Requests-1]
> org.apache.cassandra.transport.ServerConnection:140 - Failed to get peer
> certificates for peer /4.3.2.1:59263
> {code}
>
> Logging the absense of verified certificates should be a concern of the
> SaslNegotiator if it requires it, and not something worth alerting the
> operator for generally. Downgrade to debug message to make investigation
> possible if needed.
>
>
> Finally, to help with logging issues related to disconnection, add a log
> statement when an instance decides it no longer needs to keep a gossip
> connection open when cleaning up connections in
> org.apache.cassandra.net.OutboundConnections.UnusedConnectionMonitor#closeUnusedSinceLastRun
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15980) Improve log messages for socket connection/disconnection
[
https://issues.apache.org/jira/browse/CASSANDRA-15980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-15980:
--
Status: Ready to Commit (was: Review In Progress)
> Improve log messages for socket connection/disconnection
>
>
> Key: CASSANDRA-15980
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15980
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Logging
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Logging for inbound SSL connections can take place before protocol
> negotiation has taken place and logs a misleading cipher that could cause
> problems for security auditing.
>
>
> {code:java}
> INFO 2020-07-03T13:57:58,380 [Messaging-EventLoop-3-1]
> org.apache.cassandra.net.InboundConnectionInitiator:242 - connection from
> peer /1.1.1.1:57899 to /2.2.2.2:7000, protocol = TLSv1.2, cipher suite =
> SSL_NULL_WITH_NULL_NULL
> {code}
>
> Instead Cassandra should log the connection & protocol, then once the cipher
> has been negotiated log the agreed upon cipher.
>
>
> If the inbound SSL connection does not present a client certificate,
> Cassandra logs this error, even if the client wasn't required to.
> {code:java}
> ERROR 2020-07-14T11:58:45,925 [Native-Transport-Requests-1]
> org.apache.cassandra.transport.ServerConnection:140 - Failed to get peer
> certificates for peer /4.3.2.1:59263
> {code}
>
> Logging the absense of verified certificates should be a concern of the
> SaslNegotiator if it requires it, and not something worth alerting the
> operator for generally. Downgrade to debug message to make investigation
> possible if needed.
>
>
> Finally, to help with logging issues related to disconnection, add a log
> statement when an instance decides it no longer needs to keep a gossip
> connection open when cleaning up connections in
> org.apache.cassandra.net.OutboundConnections.UnusedConnectionMonitor#closeUnusedSinceLastRun
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15980) Improve log messages for socket connection/disconnection
[
https://issues.apache.org/jira/browse/CASSANDRA-15980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-15980:
--
Reviewers: Aleksey Yeschenko, David Capwell, Aleksey Yeschenko (was:
Aleksey Yeschenko, David Capwell)
Aleksey Yeschenko, David Capwell, Aleksey Yeschenko (was:
Aleksey Yeschenko, David Capwell)
Status: Review In Progress (was: Patch Available)
> Improve log messages for socket connection/disconnection
>
>
> Key: CASSANDRA-15980
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15980
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Logging
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Logging for inbound SSL connections can take place before protocol
> negotiation has taken place and logs a misleading cipher that could cause
> problems for security auditing.
>
>
> {code:java}
> INFO 2020-07-03T13:57:58,380 [Messaging-EventLoop-3-1]
> org.apache.cassandra.net.InboundConnectionInitiator:242 - connection from
> peer /1.1.1.1:57899 to /2.2.2.2:7000, protocol = TLSv1.2, cipher suite =
> SSL_NULL_WITH_NULL_NULL
> {code}
>
> Instead Cassandra should log the connection & protocol, then once the cipher
> has been negotiated log the agreed upon cipher.
>
>
> If the inbound SSL connection does not present a client certificate,
> Cassandra logs this error, even if the client wasn't required to.
> {code:java}
> ERROR 2020-07-14T11:58:45,925 [Native-Transport-Requests-1]
> org.apache.cassandra.transport.ServerConnection:140 - Failed to get peer
> certificates for peer /4.3.2.1:59263
> {code}
>
> Logging the absense of verified certificates should be a concern of the
> SaslNegotiator if it requires it, and not something worth alerting the
> operator for generally. Downgrade to debug message to make investigation
> possible if needed.
>
>
> Finally, to help with logging issues related to disconnection, add a log
> statement when an instance decides it no longer needs to keep a gossip
> connection open when cleaning up connections in
> org.apache.cassandra.net.OutboundConnections.UnusedConnectionMonitor#closeUnusedSinceLastRun
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15980) Improve log messages for socket connection/disconnection
[
https://issues.apache.org/jira/browse/CASSANDRA-15980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171506#comment-17171506
]
Aleksey Yeschenko commented on CASSANDRA-15980:
---
LGTM. Committed with unused imports cleaned up and some minor formatting
changes made, to trunk as
[c9b41c1f8ad03719918c4d3c29719056ae6b3995|https://github.com/apache/cassandra/commit/c9b41c1f8ad03719918c4d3c29719056ae6b3995].
> Improve log messages for socket connection/disconnection
>
>
> Key: CASSANDRA-15980
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15980
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Logging
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Logging for inbound SSL connections can take place before protocol
> negotiation has taken place and logs a misleading cipher that could cause
> problems for security auditing.
>
>
> {code:java}
> INFO 2020-07-03T13:57:58,380 [Messaging-EventLoop-3-1]
> org.apache.cassandra.net.InboundConnectionInitiator:242 - connection from
> peer /1.1.1.1:57899 to /2.2.2.2:7000, protocol = TLSv1.2, cipher suite =
> SSL_NULL_WITH_NULL_NULL
> {code}
>
> Instead Cassandra should log the connection & protocol, then once the cipher
> has been negotiated log the agreed upon cipher.
>
>
> If the inbound SSL connection does not present a client certificate,
> Cassandra logs this error, even if the client wasn't required to.
> {code:java}
> ERROR 2020-07-14T11:58:45,925 [Native-Transport-Requests-1]
> org.apache.cassandra.transport.ServerConnection:140 - Failed to get peer
> certificates for peer /4.3.2.1:59263
> {code}
>
> Logging the absense of verified certificates should be a concern of the
> SaslNegotiator if it requires it, and not something worth alerting the
> operator for generally. Downgrade to debug message to make investigation
> possible if needed.
>
>
> Finally, to help with logging issues related to disconnection, add a log
> statement when an instance decides it no longer needs to keep a gossip
> connection open when cleaning up connections in
> org.apache.cassandra.net.OutboundConnections.UnusedConnectionMonitor#closeUnusedSinceLastRun
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Improve logging for socket connection/disconnection
This is an automated email from the ASF dual-hosted git repository.
aleksey pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new c9b41c1 Improve logging for socket connection/disconnection
c9b41c1 is described below
commit c9b41c1f8ad03719918c4d3c29719056ae6b3995
Author: Jon Meredith
AuthorDate: Fri Jul 24 07:58:13 2020 -0600
Improve logging for socket connection/disconnection
Patch by Jon Meredith; reviewed by David Capwell and Aleksey Yeschenko
for CASSANDRA-15980
---
CHANGES.txt| 1 +
.../cassandra/net/InboundConnectionInitiator.java | 19 +++
.../cassandra/net/InboundConnectionSettings.java | 2 +-
.../apache/cassandra/net/OutboundConnection.java | 2 +-
.../apache/cassandra/net/OutboundConnections.java | 7 ++
.../org/apache/cassandra/net/SocketFactory.java| 28 +-
.../cassandra/transport/ServerConnection.java | 2 +-
7 files changed, 53 insertions(+), 8 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index adc97dd..7287c0b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0-beta2
+ * Improve logging for socket connection/disconnection (CASSANDRA-15980)
* Throw FSWriteError upon write failures in order to apply DiskFailurePolicy
(CASSANDRA-15928)
* Forbid altering UDTs used in partition keys (CASSANDRA-15933)
* Fix version parsing logic when upgrading from 3.0 (CASSANDRA-15973)
diff --git a/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
b/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
index 4ad3d8c..e02512b 100644
--- a/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
+++ b/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
@@ -237,8 +237,8 @@ public class InboundConnectionInitiator
if (sslHandler != null)
{
SSLSession session = sslHandler.engine().getSession();
-logger.info("connection from peer {} to {}, protocol = {},
cipher suite = {}",
-ctx.channel().remoteAddress(),
ctx.channel().localAddress(), session.getProtocol(), session.getCipherSuite());
+logger.info("connection from peer {} to {}, protocol = {}",
+ctx.channel().remoteAddress(),
ctx.channel().localAddress(), session.getProtocol());
}
}
@@ -391,6 +391,17 @@ public class InboundConnectionInitiator
BufferPool.setRecycleWhenFreeForCurrentThread(false);
pipeline.replace(this, "streamInbound", new
StreamingInboundHandler(from, current_version, null));
+
+logger.info("{} streaming connection established, version = {},
framing = {}, encryption = {}",
+SocketFactory.channelId(from,
+(InetSocketAddress)
channel.remoteAddress(),
+settings.bindAddress,
+(InetSocketAddress)
channel.localAddress(),
+ConnectionType.STREAMING,
+channel.id().asShortText()),
+current_version,
+initiate.framing,
+pipeline.get("ssl") != null ?
encryptionLogStatement(pipeline.channel(), settings.encryption) : "disabled");
}
@VisibleForTesting
@@ -445,11 +456,11 @@ public class InboundConnectionInitiator
InboundMessageHandler handler =
settings.handlers.apply(from).createHandler(frameDecoder,
initiate.type, pipeline.channel(), useMessagingVersion);
-logger.info("{} connection established, version = {}, framing =
{}, encryption = {}",
+logger.info("{} messaging connection established, version = {},
framing = {}, encryption = {}",
handler.id(true),
useMessagingVersion,
initiate.framing,
-pipeline.get("ssl") != null ?
encryptionLogStatement(settings.encryption) : "disabled");
+pipeline.get("ssl") != null ?
encryptionLogStatement(pipeline.channel(), settings.encryption) : "disabled");
pipeline.addLast("deserialize", handler);
diff --git a/src/java/org/apache/cassandra/net/InboundConnectionSettings.java
b/src/java/org/apache/cassandra/net/InboundConnectionSettings.java
index a07395b..20f185a 100644
--- a/src/java/org/apache/cassandra/net/InboundConnectionSettings.java
+++ b/src/java/org/apache/cassandra/net/InboundConnectionSettings.java
@@ -84,7 +84,7 @@ public class InboundConnectionSettings
public String toString()
{
return format("address: (%s), nic: %s, encryption: %s",
-
[cassandra-builds] branch master updated: Apply matrix splits to all dtest jenkins jobs
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git
The following commit(s) were added to refs/heads/master by this push:
new 6fc260a Apply matrix splits to all dtest jenkins jobs
6fc260a is described below
commit 6fc260ae265e7c8f8c29445264ae143e1693cf14
Author: mck
AuthorDate: Fri Jul 31 16:25:00 2020 +0200
Apply matrix splits to all dtest jenkins jobs
patch by Mick Semb Wever; reviewed by Eduard Tudenhöfner for
CASSANDRA-16006
---
jenkins-dsl/cassandra_job_dsl_seed.groovy | 102 ++
1 file changed, 19 insertions(+), 83 deletions(-)
diff --git a/jenkins-dsl/cassandra_job_dsl_seed.groovy
b/jenkins-dsl/cassandra_job_dsl_seed.groovy
index 619ddd5..4047963 100644
--- a/jenkins-dsl/cassandra_job_dsl_seed.groovy
+++ b/jenkins-dsl/cassandra_job_dsl_seed.groovy
@@ -68,6 +68,12 @@ if(binding.hasVariable("MAX_JOB_HOURS")) {
maxJobHours = "${MAX_JOB_HOURS}"
}
+// how many splits are dtest jobs matrixed into
+def dtestSplits = 64
+if(binding.hasVariable("DTEST_SPLITS")) {
+dtestSplits = "${DTEST_SPLITS}"
+}
+
//
// Job Templates
@@ -224,67 +230,6 @@ job('Cassandra-template-test') {
/**
* Dtest template
*/
-job('Cassandra-template-dtest') {
-disabled(true)
-description(jobDescription)
-concurrentBuild()
-jdk(jdkLabel)
-label(slaveLabel)
-compressBuildLog()
-logRotator {
-numToKeep(10)
-artifactNumToKeep(10)
-}
-wrappers {
-timeout {
-noActivity(1200)
-}
-timestamps()
-}
-properties {
-githubProjectUrl(githubRepo)
-priority(5)
-}
-scm {
-git {
-remote {
-url(mainRepo)
-}
-branch('*/null')
-extensions {
-cleanAfterCheckout()
-}
-}
-}
-steps {
-buildDescription('', buildDescStr)
-shell("git clean -xdff ; git clone --depth 1 --single-branch -b
${buildsBranch} ${buildsRepo} ; git clone --depth 1 --single-branch
${dtestRepo}")
-}
-publishers {
-archiveArtifacts {
-pattern('**/test_stdout.txt,**/nosetests.xml,**/ccm_logs.tar.xz')
-allowEmpty()
-fingerprint()
-}
-archiveJunit('nosetests.xml') {
-testDataPublishers {
-publishTestStabilityData()
-}
-}
-postBuildTask {
-task('.', """
-echo "Cleaning project…"; git clean -xdff ;
-echo "Pruning docker…" ; if pgrep -af jenkinscommand.sh; then
docker system prune -f --filter 'until=${maxJobHours}h'; else docker system
prune -f --volumes ; fi;
-echo "Reporting disk usage…"; df -h ; du -hs ../* ; du -hs
../../* ;
-echo "Cleaning tmp…";
-find . -type d -name tmp -delete 2>/dev/null ;
-find /tmp -type f -atime +2 -user jenkins -and -not -exec
fuser -s {} ';' -and -delete 2>/dev/null
-""")
-}
-}
-}
-
-// wip – parallelise dtests, starting with just upgrade dtests
matrixJob('Cassandra-template-dtest-matrix') {
disabled(true)
description(jobDescription)
@@ -487,15 +432,13 @@ cassandraBranches.each {
// Skip dtest-offheap on cassandra-3.0 branch
if ((targetName == 'dtest-offheap') && (branchName ==
'cassandra-3.0')) {
println("Skipping ${targetName} on branch ${branchName}")
-} else if (targetName == 'dtest-upgrade') {
-// wip – parallelise dtests, starting with just upgrade dtests
+} else {
matrixJob("${jobNamePrefix}-${targetName}") {
disabled(false)
using('Cassandra-template-dtest-matrix')
axes {
-splits = 64
List values = new ArrayList()
-(1..splits).each { values << it.toString() }
+(1..dtestSplits).each { values << it.toString() }
text('split', values)
label('label', slaveLabel)
}
@@ -503,21 +446,7 @@ cassandraBranches.each {
node / scm / branches / 'hudson.plugins.git.BranchSpec' /
name(branchName)
}
steps {
-shell("sh
./cassandra-builds/docker/jenkins/jenkinscommand.sh apache ${branchName}
https://github.com/apache/cassandra-dtest.git master ${buildsRepo}
${buildsBranch} ${dtestDockerImage} ${targetName} \${split}/${splits}")
-}
-}
-} else {
-job("${jobNamePrefix}-${targetName}") {
-disabled(false)
-using('Cassandra-template-dtest')
-if (targetName == 'dtest-large') {
-
[jira] [Updated] (CASSANDRA-15234) Standardise config and JVM parameters
[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh McKenzie updated CASSANDRA-15234:
--
Fix Version/s: (was: 4.0-beta)
4.0-alpha
> Standardise config and JVM parameters
> -
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Benedict Elliott Smith
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15299) CASSANDRA-13304 follow-up: improve checksumming and compression in protocol v5-beta
[
https://issues.apache.org/jira/browse/CASSANDRA-15299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh McKenzie updated CASSANDRA-15299:
--
Fix Version/s: (was: 4.0-beta)
4.0-alpha
> CASSANDRA-13304 follow-up: improve checksumming and compression in protocol
> v5-beta
> ---
>
> Key: CASSANDRA-15299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15299
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Client
>Reporter: Aleksey Yeschenko
>Assignee: Alex Petrov
>Priority: Normal
> Labels: protocolv5
> Fix For: 4.0-alpha
>
>
> CASSANDRA-13304 made an important improvement to our native protocol: it
> introduced checksumming/CRC32 to request and response bodies. It’s an
> important step forward, but it doesn’t cover the entire stream. In
> particular, the message header is not covered by a checksum or a crc, which
> poses a correctness issue if, for example, {{streamId}} gets corrupted.
> Additionally, we aren’t quite using CRC32 correctly, in two ways:
> 1. We are calculating the CRC32 of the *decompressed* value instead of
> computing the CRC32 on the bytes written on the wire - losing the properties
> of the CRC32. In some cases, due to this sequencing, attempting to decompress
> a corrupt stream can cause a segfault by LZ4.
> 2. When using CRC32, the CRC32 value is written in the incorrect byte order,
> also losing some of the protections.
> See https://users.ece.cmu.edu/~koopman/pubs/KoopmanCRCWebinar9May2012.pdf for
> explanation for the two points above.
> Separately, there are some long-standing issues with the protocol - since
> *way* before CASSANDRA-13304. Importantly, both checksumming and compression
> operate on individual message bodies rather than frames of multiple complete
> messages. In reality, this has several important additional downsides. To
> name a couple:
> # For compression, we are getting poor compression ratios for smaller
> messages - when operating on tiny sequences of bytes. In reality, for most
> small requests and responses we are discarding the compressed value as it’d
> be smaller than the uncompressed one - incurring both redundant allocations
> and compressions.
> # For checksumming and CRC32 we pay a high overhead price for small messages.
> 4 bytes extra is *a lot* for an empty write response, for example.
> To address the correctness issue of {{streamId}} not being covered by the
> checksum/CRC32 and the inefficiency in compression and checksumming/CRC32, we
> should switch to a framing protocol with multiple messages in a single frame.
> I suggest we reuse the framing protocol recently implemented for internode
> messaging in CASSANDRA-15066 to the extent that its logic can be borrowed,
> and that we do it before native protocol v5 graduates from beta. See
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/FrameDecoderCrc.java
> and
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/FrameDecoderLZ4.java.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16016) sstablemetadata unit test, docs and params parsing hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16016:
Description: During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit
test coverage for this tool is minimal. There is a unit test to enhance upon
under {{test/unit/org/apache/cassandra/tools}}. Also docs are missing some
options and args parsing is brittle. (was: During CASSANDRA-15883 /
CASSANDRA-15991 it was detected unit test coverage for this tool is minimal.
There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}. Also docs are missing some options
and args parsing is brittle, they should be moved to some args parsing
framework.)
> sstablemetadata unit test, docs and params parsing hardening
>
>
> Key: CASSANDRA-16016
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16016
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}. Also docs are missing some options
> and args parsing is brittle.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15583) 4.0 quality testing: Tooling, Bundled and First Party
[
https://issues.apache.org/jira/browse/CASSANDRA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-15583:
Description:
Reference [doc from
NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#]
for context.
*Shepherd: Sam Tunnicliffe*
Test plans should cover bundled first-party tooling and CLIs such as nodetool,
cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983,
CASSANDRA-12151).
*Progress as of Aug 2020*
{{ToolRunner}} has been added enabling us to test tools in java unit tests.
This includes capturing their stdout/err and stdin i.e. Most tools have a
starting unit test testing their cmd line args happy path. Tickets have been
created to improve coverage of those and flagged LHF. Also for those tools big
enough they can't be addressed in a simple ticket such as nodetool, a
placeholder ticket for future improvements has been created as well. Tickets
and status are:
||Tool||UX test||UT coverage||dtest coverage||Comments||
|Nodetool|(x)|(x) CASSANDRA-16026|(!)|Not all the sub commands are tested.
Dtest also test nodetool as a side effect|
|Cqlsh|(x)|(x) CASSANDRA-16025|(!)| |
|Cassandra-stress|(x)|(x) CASSANDRA-16024|(x)| |
|debug-cql|(x)|(x) CASSANDRA-16023|(x)| |
|fqltool|(x)|(/) CASSANDRA-16022|(!)| |
|auditlogviewer|(/) CASSANDRA-15991|(!) CASSANDRA-16021|(!)| |
|*Sstable utilities*| | | | |
|sstabledump|(/) CASSANDRA-15991|(/) CASSANDRA-16020|(!)| |
|sstableexpiredblockers|(/) CASSANDRA-15991|(x) CASSANDRA-16019|(!)| |
|sstablelevelreset|(/) CASSANDRA-15991|(x) CASSANDRA-16018|(!)| |
|sstableloader|(x)|(x) CASSANDRA-16017|(!)| |
|sstablemetadata|(/) CASSANDRA-15991|(x) CASSANDRA-16016|(x)|Ran in dtests, no
dedicated test|
|sstableofflinerelevel|(/) CASSANDRA-15991|(x) CASSANDRA-16015|(!)| |
|sstablerepairedset|(/) CASSANDRA-15991|(x) CASSANDRA-16014|(x)|Ran in dtests,
no dedicated test|
|sstablescrub|(/) CASSANDRA-15991|(x) CASSANDRA-16013|(!)| |
|sstablesplit|(/) CASSANDRA-15991|(x) CASSANDRA-16012|(!)| |
|sstableupgrade|(/) CASSANDRA-15991|(x) CASSANDRA-16011|(!)| |
|sstableutil|(/) CASSANDRA-15991|(x) CASSANDRA-16010|(!)| |
|sstableverify|(/) CASSANDRA-15991|(x) CASSANDRA-16009|(!)| |
was:
Reference [doc from
NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#]
for context.
*Shepherd: Sam Tunnicliffe*
Test plans should cover bundled first-party tooling and CLIs such as nodetool,
cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983,
CASSANDRA-12151).
*Progress as of Aug 2020*
{{ToolRunner}} has been added enabling us to test tools in java unit tests.
This includes capturing their stdout/err and stdin i.e. Most tools have a
starting unit test testing their cmd line args happy path. Tickets have been
created to improve coverage of those and flagged LHF. Also for those tools big
enough they can't be addressed in a simple ticket such as nodetool, a
placeholder ticket for future improvements has been created as well. Tickets
and status are:
||Tool||UX test||UT coverage||dtest coverage||Comments||
|Nodetool|(x)|(x) CASSANDRA-16026|(!)|Not all the sub commands are tested.
Dtest also test nodetool as a side effect|
|Cqlsh|(x)|(x) CASSANDRA-16025|(!)| |
|Cassandra-stress|(x)|(x) CASSANDRA-16024|(x)| |
|debug-cql|(x)|(x) CASSANDRA-16023|(x)| |
|fqltool|(x)|(/) CASSANDRA-16022|(!)| |
|auditlogviewer|(/) CASSANDRA-15991|(!) CASSANDRA-16021|(!)| |
|*Sstable utilities*| | | | |
|sstabledump|(/) CASSANDRA-15991|(x) CASSANDRA-16020|(!)| |
|sstableexpiredblockers|(/) CASSANDRA-15991|(x) CASSANDRA-16019|(!)| |
|sstablelevelreset|(/) CASSANDRA-15991|(x) CASSANDRA-16018|(!)| |
|sstableloader|(x)|(x) CASSANDRA-16017|(!)| |
|sstablemetadata|(/) CASSANDRA-15991|(x) CASSANDRA-16016|(x)|Ran in dtests, no
dedicated test|
|sstableofflinerelevel|(/) CASSANDRA-15991|(x) CASSANDRA-16015|(!)| |
|sstablerepairedset|(/) CASSANDRA-15991|(x) CASSANDRA-16014|(x)|Ran in dtests,
no dedicated test|
|sstablescrub|(/) CASSANDRA-15991|(x) CASSANDRA-16013|(!)| |
|sstablesplit|(/) CASSANDRA-15991|(x) CASSANDRA-16012|(!)| |
|sstableupgrade|(/) CASSANDRA-15991|(x) CASSANDRA-16011|(!)| |
|sstableutil|(/) CASSANDRA-15991|(x) CASSANDRA-16010|(!)| |
|sstableverify|(/) CASSANDRA-15991|(x) CASSANDRA-16009|(!)| |
> 4.0 quality testing: Tooling, Bundled and First Party
> -
>
> Key: CASSANDRA-15583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15583
> Project: Cassandra
> Issue Type: Task
> Components: Test/dtest, Test/unit
>Reporter: Josh McKenzie
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Reference [doc from
> NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO
[jira] [Updated] (CASSANDRA-16020) sstabledump unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16020:
Since Version: 4.0-beta
Source Control Link: See CASSANDRA-15991
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> sstabledump unit test hardening
> ---
>
> Key: CASSANDRA-16020
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16020
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 4.0-beta
>
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16020) sstabledump unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16020:
Test and Documentation Plan: See CASSANDRA-15991
Status: Patch Available (was: In Progress)
> sstabledump unit test hardening
> ---
>
> Key: CASSANDRA-16020
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16020
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 4.0-beta
>
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16020) sstabledump unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16020:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: User Report
Severity: Normal
Assignee: Berenguer Blasi
Status: Open (was: Triage Needed)
> sstabledump unit test hardening
> ---
>
> Key: CASSANDRA-16020
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16020
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16020) sstabledump unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16020:
Reviewers: Berenguer Blasi, Berenguer Blasi (was: Berenguer Blasi)
Berenguer Blasi, Berenguer Blasi
Status: Review In Progress (was: Patch Available)
> sstabledump unit test hardening
> ---
>
> Key: CASSANDRA-16020
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16020
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 4.0-beta
>
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16020) sstabledump unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16020:
Status: Ready to Commit (was: Review In Progress)
> sstabledump unit test hardening
> ---
>
> Key: CASSANDRA-16020
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16020
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 4.0-beta
>
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16020) sstabledump unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16020:
Fix Version/s: 4.0-beta
> sstabledump unit test hardening
> ---
>
> Key: CASSANDRA-16020
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16020
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 4.0-beta
>
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16020) sstabledump unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171476#comment-17171476
]
Berenguer Blasi commented on CASSANDRA-16020:
-
Fixes for this ticket have been folded into CASSANDRA-15991
> sstabledump unit test hardening
> ---
>
> Key: CASSANDRA-16020
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16020
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15986) Repair tests flakiness
[ https://issues.apache.org/jira/browse/CASSANDRA-15986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi reassigned CASSANDRA-15986: --- Assignee: (was: Berenguer Blasi) > Repair tests flakiness > -- > > Key: CASSANDRA-15986 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15986 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > Repair tests come up in test failure reports every now and then. I have tried > to repro the > [latest|https://ci-cassandra.apache.org/job/Cassandra-trunk/241/testReport/junit/dtest-novnode.repair_tests.repair_test/TestRepair/test_simple_sequential_repair/] > locally 100 times with no luck. > Still from experience from fixing other flaky tests I have some intuition > where the problems may lie. The proposed fix should add no harm if merged. We > can reopen the ticket if repair tests keep failing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15889) Debian package fails to download on Arm-based hosts
[
https://issues.apache.org/jira/browse/CASSANDRA-15889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171381#comment-17171381
]
Michael Semb Wever commented on CASSANDRA-15889:
bq. Does dpkg-buildpackage need to be called here with -A?
Have you tried this? If you could test and verify then I would be happy to work
with getting the patch together and committed.
> Debian package fails to download on Arm-based hosts
> ---
>
> Key: CASSANDRA-15889
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15889
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Matt Davis
>Priority: Normal
> Labels: ARM, debian
>
> Following the first three steps of the [Debian install
> process|https://cassandra.apache.org/download/], after an apt-get update
> you'll see this line:
> {code:bash}
> $ sudo apt-get update
> ...
> N: Skipping acquire of configured file 'main/binary-arm64/Packages' as
> repository 'https://downloads.apache.org/cassandra/debian 311x InRelease'
> doesn't support architecture 'arm64'
> {code}
> Checking the [Debian
> repo|https://dl.bintray.com/apache/cassandra/dists/311x/main/] confirms there
> is no aarch64 variant available.
> Should you then attempt to install Cassandra:
> {code:bash}
> $ sudo apt-get install cassandra
> Reading package lists... Done
> Building dependency tree
> Reading state information... Done
> Package cassandra is not available, but is referred to by another package.
> This may mean that the package is missing, has been obsoleted, or
> is only available from another source
> E: Package 'cassandra' has no installation candidate
> {code}
> The Redhat RPM contains a "noarch" arch type, so it will download on any
> host. (Cassandra does not use separate binaries/releases for different
> architectures, so this seems to be the correct approach, but adding an
> aarch64 variant would also suffice.)
> Note that there is a workaround available: if you specify "amd64" as the arch
> for the source, it downloads and runs on Arm without issue:
> {code:bash}
> deb [arch=amd64] https://downloads.apache.org/cassandra/debian 311x main
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15406) Show the progress of data streaming and index build
[ https://issues.apache.org/jira/browse/CASSANDRA-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171377#comment-17171377 ] Stefan Miklosovic commented on CASSANDRA-15406: --- I have updated PR with a test, it is testing the output of the netstats command [https://github.com/apache/cassandra/pull/558] > Show the progress of data streaming and index build > > > Key: CASSANDRA-15406 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15406 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Streaming, Legacy/Streaming and Messaging, > Tool/nodetool >Reporter: maxwellguo >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.0, 4.x > > Time Spent: 40m > Remaining Estimate: 0h > > I found that we should supply a command to show the progress of streaming > when we do the operation of bootstrap/move/decommission/removenode. For when > do data streaming , noboday knows which steps there program are in , so I > think a command to show the joing/leaving node's is needed . > > PR [https://github.com/apache/cassandra/pull/558] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16003) ToolRunner added in CASSANDRA-15942 stdErr checks improvements
[
https://issues.apache.org/jira/browse/CASSANDRA-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171316#comment-17171316
]
Berenguer Blasi commented on CASSANDRA-16003:
-
Thx [~dcapwell] . Changed as per your suggestion
> ToolRunner added in CASSANDRA-15942 stdErr checks improvements
> --
>
> Key: CASSANDRA-16003
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16003
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The JVM will output to stderr on some environments to show what flags that
> were picked up, when this happens all tests which validate stderr start to
> fail. This was found in the org.apache.cassandra.tools.ClearSnapshotTest as
> it switched to use the ToolRunner; below is a sample failure on my laptop (I
> had to modify the asserts since they don’t include the input)
> {code}
> java.lang.AssertionError:
> Expecting empty but was:<"Picked up _JAVA_OPTIONS:
> -Djava.net.preferIPv4Stack=true
> ">
> at
> org.apache.cassandra.tools.ToolRunner.assertEmptyStdErr(ToolRunner.java:339)
> at
> org.apache.cassandra.tools.ToolRunner.waitAndAssertOnCleanExit(ToolRunner.java:334)
> at
> org.apache.cassandra.tools.ClearSnapshotTest.testClearSnapshot_RemoveMultiple(ClearSnapshotTest.java:91)
> {code}
> Here _JAVA_OPTIONS is used globally on my system so fails the test; there is
> also JAVA_TOOL_RUNNER which is used the same way.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
