Re: [PR] [HUDI-7743] Fix Simple Mistakes with StoragePath [hudi]
yihua commented on code in PR #11189: URL: https://github.com/apache/hudi/pull/11189#discussion_r1597244371 ## hudi-cli/src/main/java/org/apache/hudi/cli/commands/RepairsCommand.java: ## @@ -123,7 +121,7 @@ public String addPartitionMeta( client.getActiveTimeline().getCommitTimeline().lastInstant().get().getTimestamp(); List partitionPaths = FSUtils.getAllPartitionFoldersThreeLevelsDown(HoodieCLI.storage, client.getBasePath()); -StoragePath basePath = new StoragePath(client.getBasePath()); +StoragePath basePath = client.getBasePathV2(); Review Comment: Could you create a JIRA to remove `getBasePathV2()` and return `StoragePath` from `getBasePath()` as a follow-up? ## hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java: ## @@ -294,11 +294,20 @@ public HoodieTableType getTableType() { /** * @return Meta path + * @deprecated please use {@link #getMetaPathV2()} */ + @Deprecated Review Comment: Can we directly change this method to return `StoragePath` and `metaPath`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Fix Simple Mistakes with StoragePath [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105087264 ## CI report: * 975a7d92617080bb4c32e832796e8d13cd8d9857 UNKNOWN * 51a199199691df091162a3d8cb71f9ee448b079a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23829) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Fix Simple Mistakes with StoragePath [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105015090 ## CI report: * 975a7d92617080bb4c32e832796e8d13cd8d9857 UNKNOWN * 51a199199691df091162a3d8cb71f9ee448b079a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23829) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Fix Simple Mistakes with StoragePath [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2105004867 ## CI report: * 975a7d92617080bb4c32e832796e8d13cd8d9857 UNKNOWN * 51a199199691df091162a3d8cb71f9ee448b079a UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7743] Fix Simple Mistakes with StoragePath [hudi]
hudi-bot commented on PR #11189: URL: https://github.com/apache/hudi/pull/11189#issuecomment-2104922265 ## CI report: * 975a7d92617080bb4c32e832796e8d13cd8d9857 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org