Integrated: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags
On Mon, 4 Dec 2023 10:39:05 GMT, Darragh Clarke wrote: > Updated tests to use vm.flagless as they already ignore Vm flags This pull request has now been integrated. Changeset: 62b7c5ea Author: Darragh Clarke URL: https://git.openjdk.org/jdk/commit/62b7c5eaed1e6ffd6f2c8371eb4cf01dd9d53a06 Stats: 14 lines in 7 files changed: 7 ins; 0 del; 7 mod 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags Reviewed-by: lmesnik - PR: https://git.openjdk.org/jdk/pull/16946
RFR: 8319647: Update or mark as vm.flagless tests that ignore external VM flags
Updated tests to use vm.flagless as they already ignore Vm flags - Commit messages: - ignore vm flags Changes: https://git.openjdk.org/jdk/pull/16946/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16946=00 Issue: https://bugs.openjdk.org/browse/JDK-8319647 Stats: 14 lines in 7 files changed: 7 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk/pull/16946.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16946/head:pull/16946 PR: https://git.openjdk.org/jdk/pull/16946
Integrated: 8317834: java/lang/Thread/IsAlive.java timed out
On Tue, 14 Nov 2023 16:41:31 GMT, Darragh Clarke wrote: > Currently the `IsAlive` test occasionally times out. > > This PR changes the timeout from `10` to `25` which I think is an adequate > increase based on the failures I've seen. Though I'd be happy to change it to > another value if someone thinks `25` isn't ideal. This pull request has now been integrated. Changeset: 5522656a Author: Darragh Clarke URL: https://git.openjdk.org/jdk/commit/5522656af73347439eac6ecfef35d4a8f3dce77d Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8317834: java/lang/Thread/IsAlive.java timed out Reviewed-by: dfuchs, alanb, dholmes, shade - PR: https://git.openjdk.org/jdk/pull/16659
Re: RFR: 8317834: java/lang/Thread/IsAlive.java timed out [v2]
> Currently the `IsAlive` test occasionally times out. > > This PR changes the timeout from `10` to `25` which I think is an adequate > increase based on the failures I've seen. Though I'd be happy to change it to > another value if someone thinks `25` isn't ideal. Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision: use default timeout - Changes: - all: https://git.openjdk.org/jdk/pull/16659/files - new: https://git.openjdk.org/jdk/pull/16659/files/cd13a00c..d3ac2694 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=16659=01 - incr: https://webrevs.openjdk.org/?repo=jdk=16659=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/16659.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16659/head:pull/16659 PR: https://git.openjdk.org/jdk/pull/16659
RFR: 8317834: java/lang/Thread/IsAlive.java timed out
Currently the `IsAlive` test occasionally times out. This PR changes the timeout from `10` to `25` which I think is an adequate increase based on the failures I've seen. Though I'd be happy to change it to another value if someone thinks `25` isn't ideal. - Commit messages: - bumped timeout from 10 to 25 Changes: https://git.openjdk.org/jdk/pull/16659/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16659=00 Issue: https://bugs.openjdk.org/browse/JDK-8317834 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/16659.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16659/head:pull/16659 PR: https://git.openjdk.org/jdk/pull/16659
Integrated: 7065228: To interpret case-insensitive string locale independently
On Tue, 16 May 2023 10:38:52 GMT, Darragh Clarke wrote: > Updated instances of `toLowerCase` and `toUpperCase` in several net and io > files to specify `Locale.ROOT` to ensure that case conversion issues don't > occur, > > I didn't add any new tests but ran tier 1-3 with no issues This pull request has now been integrated. Changeset: 05e99db4 Author: Darragh Clarke Committer: Jaikiran Pai URL: https://git.openjdk.org/jdk/commit/05e99db466e7ef5c26f089db772a21cb2ca62e93 Stats: 74 lines in 20 files changed: 14 ins; 0 del; 60 mod 7065228: To interpret case-insensitive string locale independently Reviewed-by: dfuchs, naoto, djelinski, jpai, michaelm - PR: https://git.openjdk.org/jdk/pull/14006
Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]
On Fri, 19 May 2023 11:24:30 GMT, Michael McMahon wrote: > Seems like a useful change and I can see how issues could arise if strings > were stored somewhere after being upper/lower cased and then reused in a > different locale. > > Is it correct to say that the assumption is these strings are all supposed to > be US ASCII (eg protocol defined identifiers, or hostnames etc) rather than > user generated text strings? That seems to be the case as far as I can see. Yes - PR Comment: https://git.openjdk.org/jdk/pull/14006#issuecomment-1556955595
Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]
On Wed, 17 May 2023 10:41:57 GMT, Daniel Jeliński wrote:
>> Darragh Clarke has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update
>> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java
>>
>>Co-authored-by: Daniel Jelinski
>> - removed StreamTokenizer changes, will make seperate ticket for those
>
> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java
> line 516:
>
>> 514:
>> 515: if (nccount != -1) {
>> 516: ncstring = Integer.toHexString
>> (nccount).toLowerCase(Locale.ROOT);
>
> Suggestion:
>
> ncstring = Integer.toHexString(nccount);
>
> `toHexString` returns lowercase string
Thanks for pointing that out!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14006#discussion_r1196555183
Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]
> Updated instances of `toLowerCase` and `toUpperCase` in several net and io > files to specify `Locale.ROOT` to ensure that case conversion issues don't > occur, > > I didn't add any new tests but ran tier 1-3 with no issues Darragh Clarke has updated the pull request incrementally with two additional commits since the last revision: - Update src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java Co-authored-by: Daniel Jelinski - removed StreamTokenizer changes, will make seperate ticket for those - Changes: - all: https://git.openjdk.org/jdk/pull/14006/files - new: https://git.openjdk.org/jdk/pull/14006/files/a79969c2..6d40e1c8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=14006=01 - incr: https://webrevs.openjdk.org/?repo=jdk=14006=00-01 Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/14006.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14006/head:pull/14006 PR: https://git.openjdk.org/jdk/pull/14006
RFR: 7065228: To interpret case-insensitive string locale independently
Updated instances of `toLowerCase` and `toUpperCase` in several net and io files to specify `Locale.ROOT` to ensure that case conversion issues don't occur, I didn't add any new tests but ran tier 1-3 with no issues - Commit messages: - added some case conversions missed previously - updated copyright year and cleaned up some formatting of imports - merged master into branch - Specify use of Locale.Root to avoid issues with case conversion Changes: https://git.openjdk.org/jdk/pull/14006/files Webrev: https://webrevs.openjdk.org/?repo=jdk=14006=00 Issue: https://bugs.openjdk.org/browse/JDK-7065228 Stats: 76 lines in 21 files changed: 15 ins; 0 del; 61 mod Patch: https://git.openjdk.org/jdk/pull/14006.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14006/head:pull/14006 PR: https://git.openjdk.org/jdk/pull/14006
Integrated: 8286394: Address possibly lossy conversions in jdk.naming.dns
On Fri, 7 Oct 2022 14:14:13 GMT, Darragh Clarke wrote: > Added an int cast for the `timeoutLeft` assignment, looking through the code > and other uses of the variable it seems to show no issues with lossy > conversion. As part of this I removed the file to disable the conversion > warning > > I tested this build and it doesn't give any warnings on this file This pull request has now been integrated. Changeset: 67210abd Author:Darragh Clarke Committer: Aleksei Efimov URL: https://git.openjdk.org/jdk/commit/67210abd04683a3a16ec8af0948030a934e5ce15 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod 8286394: Address possibly lossy conversions in jdk.naming.dns Reviewed-by: rriggs, aefimov - PR: https://git.openjdk.org/jdk/pull/10607
RFR: 8286394: Address possibly lossy conversions in jdk.naming.dns
Added an int cast for the `timeoutLeft` assignment, looking through the code and other uses of the variable it seems to show no issues with lossy conversion. As part of this I removed the file to disable the conversion warning I tested this build and it doesn't give any warnings on this file - Commit messages: - added int cast and reenabled warning for lossy conversion Changes: https://git.openjdk.org/jdk/pull/10607/files Webrev: https://webrevs.openjdk.org/?repo=jdk=10607=00 Issue: https://bugs.openjdk.org/browse/JDK-8286394 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/10607.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10607/head:pull/10607 PR: https://git.openjdk.org/jdk/pull/10607
