Bug#528262: [Pkg-nagios-devel] Bug#528262: Bug#528262: nagios-plugins-standard: Error in command_line in nt.cfg causes errors
Hi!
Jan Wagner wrote:
On Tuesday 12 May 2009, Sven Velt wrote:
Maybe we could add another one with -l '$ARGV2' add... ;-)
Hmm ... I personly prefer general solutions and the one just with $ARGV1 is
one in my eyes ... beside the documentaion shipped with nagios (upstream and
with our package), where they use also $ARGV2, we didn't reference anything
about such a way in our package. Why should we use different checks, if we
can do the same with one?
For example check_command check_nt!'MEMUSE -w 80 -c 90' works like a charm.
I think this isn't exactly the scope of this bug report but I want to
add a last statement to this.
In upstream commands.cfg many commands are defined like:
-- snip --
define command{
command_namecheck_http
command_line$USER1$/check_http -I $HOSTADDRESS$ $ARG1$
}
-- snip --
So everyone can put whatever command line arguments to check_http into
the service description like:
...
check_command check_http!-u /demo/ -w 10 -c 15 -t 20 -a user:pw -f follow
-s Linux -m 2000:5000 -M 86400
...
This may be flexible, yes, but not nice. Do you know all of the switches
to check_* which are in nagios-plugins-(basic|standard)? I don't. I told
Ethan on Nagios Konferenz 2008 that I don't like this syntax and that I
wish a more clearly way of configured check commands in the upstream
code/sample config.
As I do trainings and consulting for Nagios you can believe me that this
flexible way of doing service definitions and check commands is one of
the main source of problems if different people (some of them maybe not
so/100% familiar with Nagios) administer one Nagios server.
*I* prefer check_command check_nscp!CLIENTVERSION and check_command
check_nscp_var_wc!USEDDISKSPACE!C:!80%!90%
Maybe we should discuss this in private?
Just IMHO. YMMV ;-)
bye
Sven
--
Leukämie - http://de.wikipedia.org/wiki/Leuk%C3%A4mie
Heilung - http://de.wikipedia.org/wiki/Knochenmark#Knochenmarkspende
Typisierung - http://www.knochenmarkspende.de/html/reg_akb.php
WarumFragen - s...@velt.de
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#528262: [Pkg-nagios-devel] Bug#528262: Bug#528262: nagios-plugins-standard: Error in command_line in nt.cfg causes errors
Hi! Jan Wagner wrote: [...] I see Jan's problem here with changing the default port. But IMHO it would be more up2date to change from NSClient to NSClient++/nscp and from port 1248 to 12489. I would say, we could write a new check check_ntplus with set -p 12489, wouldn't that be nice? I *would* prefer check_nscp as the author named the software. But yes, it would be a nice solution (independent of chosen command_name) for the Debian packages. Maybe we could add another one with -l '$ARGV2' add... ;-) bye Sven -- Leukämie - http://de.wikipedia.org/wiki/Leuk%C3%A4mie Heilung - http://de.wikipedia.org/wiki/Knochenmark#Knochenmarkspende Typisierung - http://www.knochenmarkspende.de/html/reg_akb.php WarumFragen - s...@velt.de -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#528262: [Pkg-nagios-devel] Bug#528262: Bug#528262: nagios-plugins-standard: Error in command_line in nt.cfg causes errors
Hi Sven, On Tuesday 12 May 2009, Sven Velt wrote: I *would* prefer check_nscp as the author named the software. But yes, it would be a nice solution (independent of chosen command_name) for the Debian packages. okay ... point taken. :) Maybe we could add another one with -l '$ARGV2' add... ;-) Hmm ... I personly prefer general solutions and the one just with $ARGV1 is one in my eyes ... beside the documentaion shipped with nagios (upstream and with our package), where they use also $ARGV2, we didn't reference anything about such a way in our package. Why should we use different checks, if we can do the same with one? For example check_command check_nt!'MEMUSE -w 80 -c 90' works like a charm. With kind regards, Jan. -- Never write mail to w...@spamfalle.info, you have been warned! -BEGIN GEEK CODE BLOCK- Version: 3.1 GIT d-- s+: a- C+++ UL P+ L+++ E- W+++ N+++ o++ K++ w--- O M V- PS PE Y++ PGP++ t-- 5 X R tv- b+ DI- D++ G++ e++ h-- r+++ y+++ --END GEEK CODE BLOCK-- signature.asc Description: This is a digitally signed message part.
Bug#528262: [Pkg-nagios-devel] Bug#528262: Bug#528262: nagios-plugins-standard: Error in command_line in nt.cfg causes errors
Hi Soren,
On Tuesday 12 May 2009, Soren Stoutner wrote:
The ' marks around the arguments also causes problems for me on some of
the commands. It occurred on all the commands that contained two -.
Specifically:
define service{
use generic-service
host_name winserver
service_description Memory Usage
check_command check_nt!MEMUSE!-w 80 -c 90
}
what is exactly your problem with it (beside the different port)?
check_command check_nt!'MEMUSE -w 80 -c 90' works very well here.
With kind regards, Jan.
--
Never write mail to w...@spamfalle.info, you have been warned!
-BEGIN GEEK CODE BLOCK-
Version: 3.1
GIT d-- s+: a- C+++ UL P+ L+++ E- W+++ N+++ o++ K++ w--- O M V- PS PE
Y++ PGP++ t-- 5 X R tv- b+ DI- D++ G++ e++ h-- r+++ y+++
--END GEEK CODE BLOCK--
signature.asc
Description: This is a digitally signed message part.
Bug#528262: [Pkg-nagios-devel] Bug#528262: Bug#528262: nagios-plugins-standard: Error in command_line in nt.cfg causes errors
Jan,
If we only use $ARG1$, we need to update all of the documentation that
ships with the Nagios packages. For example, the sample windows.cfg
file that ships with nagios3-common includes the following code:
define service{
use generic-service
host_name winserver
service_description Memory Usage
check_command check_nt!MEMUSE!-w 80 -c 90
}
This matches the documentation that ships with nagios3-doc as well as
the upstream documentation. We could, of course, change all our
internal documentation, but adding $ARG2$ makes the Debian packages
function more closely like the upstream and has no negative impact on
existing installations because $ARG2$ is ignored if empty.
Soren Stoutner
Jan Wagner wrote:
Hi Sven,
On Tuesday 12 May 2009, Sven Velt wrote:
I *would* prefer check_nscp as the author named the software. But yes,
it would be a nice solution (independent of chosen command_name) for the
Debian packages.
okay ... point taken. :)
Maybe we could add another one with -l '$ARGV2' add... ;-)
Hmm ... I personly prefer general solutions and the one just with $ARGV1 is
one in my eyes ... beside the documentaion shipped with nagios (upstream and
with our package), where they use also $ARGV2, we didn't reference anything
about such a way in our package. Why should we use different checks, if we
can do the same with one?
For example check_command check_nt!'MEMUSE -w 80 -c 90' works like a charm.
With kind regards, Jan.
Bug#528262: [Pkg-nagios-devel] Bug#528262: Bug#528262: nagios-plugins-standard: Error in command_line in nt.cfg causes errors
Jan,
The error message produced in Nagios is wrong -l argument. I don't
know why it doesn't work. It should work. But it doesn't. Through
experimentation I discovered that removing the ' marks fixed the problem.
The error occurs with the following configurations:
command_line/usr/lib/nagios/plugins/check_nt -H '$HOSTADDRESS$' -p 12489 -v
$ARG1$ $ARG2$
define service{
use generic-service
host_name winserver
service_description C:\ Drive Space
check_command check_nt!USEDDISKSPACE!-l c -w 80 -c 90
}
Soren Stoutner
Jan Wagner wrote:
Hi Soren,
On Tuesday 12 May 2009, Soren Stoutner wrote:
The ' marks around the arguments also causes problems for me on some of
the commands. It occurred on all the commands that contained two -.
Specifically:
define service{
use generic-service
host_name winserver
service_description Memory Usage
check_command check_nt!MEMUSE!-w 80 -c 90
}
what is exactly your problem with it (beside the different port)?
check_command check_nt!'MEMUSE -w 80 -c 90' works very well here.
With kind regards, Jan.
Bug#528262: [Pkg-nagios-devel] Bug#528262: Bug#528262: nagios-plugins-standard: Error in command_line in nt.cfg causes errors
**Update**
Correction to the below email. The error occurs with this command_line:
command_line/usr/lib/nagios/plugins/check_nt -H '$HOSTADDRESS$' -p 12489 -v
'$ARG1$' '$ARG2$'
Soren
The error message produced in Nagios is wrong -l argument. I don't
know why it doesn't work. It should work. But it doesn't. Through
experimentation I discovered that removing the ' marks fixed the problem.
The error occurs with the following configurations:
command_line/usr/lib/nagios/plugins/check_nt -H '$HOSTADDRESS$' -p 12489 -v
$ARG1$ $ARG2$
define service{
use generic-service
host_name winserver
service_description C:\ Drive Space
check_command check_nt!USEDDISKSPACE!-l c -w 80 -c 90
}
Soren Stoutner
