[jira] [Reopened] (ATLAS-3764) Set default value for "atlas.graph.index.search.max-result-set-size" in ApplicationProperties

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues reopened ATLAS-3764:


> Set default value for "atlas.graph.index.search.max-result-set-size" in 
> ApplicationProperties
> -
>
> Key: ATLAS-3764
> URL: https://issues.apache.org/jira/browse/ATLAS-3764
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-intg
>Affects Versions: 2.0.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3764.1.patch, ATLAS-3764.2.patch
>
>
> Set Default value "2147483647" for 
> "*atlas.graph.index.search.max-result-set-size*" property in Atlas 
> ApplicationProperties.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3764) Set default value for "atlas.graph.index.search.max-result-set-size" in ApplicationProperties

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3764:
---
Attachment: ATLAS-3764.2.patch

> Set default value for "atlas.graph.index.search.max-result-set-size" in 
> ApplicationProperties
> -
>
> Key: ATLAS-3764
> URL: https://issues.apache.org/jira/browse/ATLAS-3764
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-intg
>Affects Versions: 2.0.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3764.1.patch, ATLAS-3764.2.patch
>
>
> Set Default value "2147483647" for 
> "*atlas.graph.index.search.max-result-set-size*" property in Atlas 
> ApplicationProperties.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (ATLAS-3784) Issues with Import business metadata

[Mayank Jain (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mayank Jain reassigned ATLAS-3784:
--

Assignee: Mayank Jain

> Issues with Import business metadata
> 
>
> Key: ATLAS-3784
> URL: https://issues.apache.org/jira/browse/ATLAS-3784
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Mayank Jain
>Priority: Major
>
> 1. It is possible to to assign BM values to deleted entities by specifying 
> the qualified name of the deleted entity in the imported file
> 2. Import through xls/xlsx doesn't work, getting an 
> java.lang.IllegalStateException: Cannot get a STRING value from a NUMERIC 
> cell in application.log
> 3. If a multi-valued attribute is assigned the string '|', the attribute is 
> assigned a blank value (ideally in this scenario, Atlas should throw an error)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3784) Issues with Import business metadata

[Rahul Kurup (Jira)]

Rahul Kurup created ATLAS-3784:
--

 Summary: Issues with Import business metadata
 Key: ATLAS-3784
 URL: https://issues.apache.org/jira/browse/ATLAS-3784
 Project: Atlas
  Issue Type: Bug
Reporter: Rahul Kurup


1. It is possible to to assign BM values to deleted entities by specifying the 
qualified name of the deleted entity in the imported file

2. Import through xls/xlsx doesn't work, getting an 
java.lang.IllegalStateException: Cannot get a STRING value from a NUMERIC cell 
in application.log

3. If a multi-valued attribute is assigned the string '|', the attribute is 
assigned a blank value (ideally in this scenario, Atlas should throw an error)

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72440/#review220666
---




repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Lines 995 (patched)


entityType could be null when called from FreeTextSearchProcessor. Please 
review and update to handle this condition.


- Madhan Neethiraj


On April 29, 2020, 10:26 a.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72440/
> ---
> 
> (Updated April 29, 2020, 10:26 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> No way to sort results by specified attribute while freetext search is 
> enabled. In our case we would like to enforce ordering by introducing custom 
> attribute definition e.g. popularity score from 
> https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json
> 
> 
> Reference to jira https://issues.apache.org/jira/browse/ATLAS-3758
> Patched applied against master branch.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  1a7bf6b16 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  92b5eb4d2 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 11eb7ca49 
> 
> 
> Diff: https://reviews.apache.org/r/72440/diff/1/
> 
> 
> Testing
> ---
> 
> Patch was applied on our dev env with custom entity definitions and 
> successfully verified if order is applied as specified in the search query.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72459/#review220665
---




graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java
Line 215 (original), 215 (patched)


Why is it necessary to switch to LinkedHashSet here?



repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Line 203 (original), 204 (patched)


Instead of ., I suggest the following:

  AtlasAttribute sortByAttribute = 
context.getEntityType().getAttribute(sortBy);
  
  if (sortByAttribute != null) {
AtlasGraphQuery.SortOrder qrySortOrder = sortOrder == 
SortOrder.ASCENDING ? ASC : DESC;

graphQuery.orderBy(sortByAttribute.getVertexPropertyName(), 
qrySortOrder)
  }

This will ensure that sortBy will work for system-attributes as well - like 
__timestamp, __modificationTimestamp.



repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 367 (patched)


I suggest to replace use of guava library class with JDK equivalent: 
  StreamSupport.stream(graphQuery.vertexIds().iterator(), false).count()


- Madhan Neethiraj


On May 5, 2020, 10:11 p.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72459/
> ---
> 
> (Updated May 5, 2020, 10:11 p.m.)
> 
> 
> Review request for atlas, Bolke de Bruin, Madhan Neethiraj, and Nixon 
> Rodrigues.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> EntitySearchProcessor fails when doing search by classification and specify 
> orderBy attribute. The issue is that for graph query you cannot refer to 
> attribute by name but need to provide absolute path to entity attribute e.g. 
> 
>  
> 
> ```
> 
> { "attributes": [ "description", "comment", "popularityScore" ], 
> "classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
> "limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
> "DESCENDING", "typeName": "hive_table" }
> ```
> 
> this query fails with following exception:
> 
>  
> 
> ```
> 
> {"exception":{"message":"Provided key does not exist: 
> hive_table.popularityScore","class":"java.lang.IllegalArgumentException","stacktrace":"java.lang.IllegalArgumentException:
>  Provided key does not exist: hive_table.popularityScore\n\tat 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:163)\n\tat
>  org.janusgraph.graphdb.query.graph.GraphCentricQueryBuilder.
> orderBy(GraphCentricQueryBuilder.java:160)
> 
> ```
> 
>  
> 
> When specify full reference to attribute e.g. 
> 
>  
> 
> ```
> 
> { "attributes": [ "description", "comment", "popularityScore" ], 
> "classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
> "limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
> "DESCENDING", "typeName": "hive_table" }
> ```
> 
> it fails on validation stage
> 
>  
> 
> ```
> 
> {"exception":{"message":"Attribute Table.popularityScore not found for type 
> Table","class":"org.apache.atlas.exception.AtlasBaseException","stacktrace":"org.apache.atlas.exception.AtlasBaseException:
>  Attribute Table.popularityScore not found for type Table\n\tat 
> org.apache.atlas.discovery.SearchContext.validateAttributes(SearchContext.java:288)
> 
> ```
> 
> Reference to JIRA https://issues.apache.org/jira/browse/ATLAS-3776
> 
> 
> Diffs
> -
> 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java
>  c70e8bfe8 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  1a7bf6b16 
>   
> repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
>  PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 
> 9aa554ad5 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 0bbff2f46 
> 
> 
> Diff: https://reviews.apache.org/r/72459/diff/4/
> 
> 
> Testing
> ---
> 
> tested on our dev env.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

[Damian Warszawski]

> On May 6, 2020, 6:49 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
> > Lines 369 (patched)
> > 
> >
> > typo maybe? => 'return -1'

As the return type is long, I made it more explicit with `l` suffix. It 
compiles properly.


- Damian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72459/#review220660
---


On May 5, 2020, 10:11 p.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72459/
> ---
> 
> (Updated May 5, 2020, 10:11 p.m.)
> 
> 
> Review request for atlas, Bolke de Bruin, Madhan Neethiraj, and Nixon 
> Rodrigues.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> EntitySearchProcessor fails when doing search by classification and specify 
> orderBy attribute. The issue is that for graph query you cannot refer to 
> attribute by name but need to provide absolute path to entity attribute e.g. 
> 
>  
> 
> ```
> 
> { "attributes": [ "description", "comment", "popularityScore" ], 
> "classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
> "limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
> "DESCENDING", "typeName": "hive_table" }
> ```
> 
> this query fails with following exception:
> 
>  
> 
> ```
> 
> {"exception":{"message":"Provided key does not exist: 
> hive_table.popularityScore","class":"java.lang.IllegalArgumentException","stacktrace":"java.lang.IllegalArgumentException:
>  Provided key does not exist: hive_table.popularityScore\n\tat 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:163)\n\tat
>  org.janusgraph.graphdb.query.graph.GraphCentricQueryBuilder.
> orderBy(GraphCentricQueryBuilder.java:160)
> 
> ```
> 
>  
> 
> When specify full reference to attribute e.g. 
> 
>  
> 
> ```
> 
> { "attributes": [ "description", "comment", "popularityScore" ], 
> "classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
> "limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
> "DESCENDING", "typeName": "hive_table" }
> ```
> 
> it fails on validation stage
> 
>  
> 
> ```
> 
> {"exception":{"message":"Attribute Table.popularityScore not found for type 
> Table","class":"org.apache.atlas.exception.AtlasBaseException","stacktrace":"org.apache.atlas.exception.AtlasBaseException:
>  Attribute Table.popularityScore not found for type Table\n\tat 
> org.apache.atlas.discovery.SearchContext.validateAttributes(SearchContext.java:288)
> 
> ```
> 
> Reference to JIRA https://issues.apache.org/jira/browse/ATLAS-3776
> 
> 
> Diffs
> -
> 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java
>  c70e8bfe8 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  1a7bf6b16 
>   
> repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
>  PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 
> 9aa554ad5 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 0bbff2f46 
> 
> 
> Diff: https://reviews.apache.org/r/72459/diff/4/
> 
> 
> Testing
> ---
> 
> tested on our dev env.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>

Re: Review Request 72441: Support solr in standalone (http) mode

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72441/#review220661
---



can you add a small readme or doc on steps to start atlas with standalone solr 
(http) and attach it to JIRA.


graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
Lines 40 (patched)


nit: unused imports in line 40 and 41. consider removing it


- Sarath Subramanian


On April 29, 2020, 3:32 a.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72441/
> ---
> 
> (Updated April 29, 2020, 3:32 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath 
> Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas does not support running Solr in standalone(http) mode.
> 
> It is especially useful for testing purposes to make setup as simple as 
> possible without Zookeeper. It also enables full integration with JanusGraph 
> as it support both mode of running Solr `cloud` and `http` 
> https://docs.janusgraph.org/index-backend/solr/. Additional benefit is to 
> decouple hbase and solr while running embedded mode so that solr can be run 
> in embbeded mode with external hbase.
> 
> Proposed solution
> 
> call solr V1 API  while creating/updating request handlers in standalone solr
> update atlas start script to enable standalone embedded solr
> 
> Reference to jira https://issues.apache.org/jira/browse/ATLAS-3654
> Patch was applied against master branch
> 
> 
> Diffs
> -
> 
>   distro/src/bin/atlas_config.py f09026ff9 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
>  ba65f3d00 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> 484c161f0 
> 
> 
> Diff: https://reviews.apache.org/r/72441/diff/1/
> 
> 
> Testing
> ---
> 
> Patch was applied and verified on our dev env with embedded solr and external 
> hbase.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72459/#review220660
---




repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 369 (patched)


typo maybe? => 'return -1'


- Sarath Subramanian


On May 5, 2020, 3:11 p.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72459/
> ---
> 
> (Updated May 5, 2020, 3:11 p.m.)
> 
> 
> Review request for atlas, Bolke de Bruin, Madhan Neethiraj, and Nixon 
> Rodrigues.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> EntitySearchProcessor fails when doing search by classification and specify 
> orderBy attribute. The issue is that for graph query you cannot refer to 
> attribute by name but need to provide absolute path to entity attribute e.g. 
> 
>  
> 
> ```
> 
> { "attributes": [ "description", "comment", "popularityScore" ], 
> "classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
> "limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
> "DESCENDING", "typeName": "hive_table" }
> ```
> 
> this query fails with following exception:
> 
>  
> 
> ```
> 
> {"exception":{"message":"Provided key does not exist: 
> hive_table.popularityScore","class":"java.lang.IllegalArgumentException","stacktrace":"java.lang.IllegalArgumentException:
>  Provided key does not exist: hive_table.popularityScore\n\tat 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:163)\n\tat
>  org.janusgraph.graphdb.query.graph.GraphCentricQueryBuilder.
> orderBy(GraphCentricQueryBuilder.java:160)
> 
> ```
> 
>  
> 
> When specify full reference to attribute e.g. 
> 
>  
> 
> ```
> 
> { "attributes": [ "description", "comment", "popularityScore" ], 
> "classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
> "limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
> "DESCENDING", "typeName": "hive_table" }
> ```
> 
> it fails on validation stage
> 
>  
> 
> ```
> 
> {"exception":{"message":"Attribute Table.popularityScore not found for type 
> Table","class":"org.apache.atlas.exception.AtlasBaseException","stacktrace":"org.apache.atlas.exception.AtlasBaseException:
>  Attribute Table.popularityScore not found for type Table\n\tat 
> org.apache.atlas.discovery.SearchContext.validateAttributes(SearchContext.java:288)
> 
> ```
> 
> Reference to JIRA https://issues.apache.org/jira/browse/ATLAS-3776
> 
> 
> Diffs
> -
> 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java
>  c70e8bfe8 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  1a7bf6b16 
>   
> repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
>  PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 
> 9aa554ad5 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 0bbff2f46 
> 
> 
> Diff: https://reviews.apache.org/r/72459/diff/4/
> 
> 
> Testing
> ---
> 
> tested on our dev env.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>

Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs
-

  addons/models/-Area0/0010-base_model.json 9777b7a 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 


Diff: https://reviews.apache.org/r/72477/diff/1/


Testing
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console


Thanks,

Mandar Ambawane

[jira] [Updated] (ATLAS-3783) DSL query search should return results for both the relationship edge directions

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-3783:
---
Summary: DSL query search should return results for both the relationship 
edge directions   (was: DSL search should return results for both the 
relationship edge directions )

> DSL query search should return results for both the relationship edge 
> directions 
> -
>
> Key: ATLAS-3783
> URL: https://issues.apache.org/jira/browse/ATLAS-3783
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
>
> eg;hive_column where table.name="employee" doesn't give any results for 
> hive_column whereas 
> hive_table where columns.name="eid" gives results for hive_table.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3783) DSL search should return results for both the relationship edge directions

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-3783:
---
Description: 
eg;hive_column where table.name="employee" doesn't give any results for 
hive_column whereas 

hive_table where columns.name="eid" gives results for hive_table.

> DSL search should return results for both the relationship edge directions 
> ---
>
> Key: ATLAS-3783
> URL: https://issues.apache.org/jira/browse/ATLAS-3783
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
>
> eg;hive_column where table.name="employee" doesn't give any results for 
> hive_column whereas 
> hive_table where columns.name="eid" gives results for hive_table.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3783) DSL search should return results for both the relationship edge directions

[chaitali borole (Jira)]

chaitali borole created ATLAS-3783:
--

 Summary: DSL search should return results for both the 
relationship edge directions 
 Key: ATLAS-3783
 URL: https://issues.apache.org/jira/browse/ATLAS-3783
 Project: Atlas
  Issue Type: Bug
Affects Versions: 3.0.0
Reporter: chaitali borole
Assignee: chaitali borole






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3782) Support NOT_CONTAINS operator in basic search with search parameters

[Andreas Danckert (Jira)]

Andreas Danckert created ATLAS-3782:
---

 Summary: Support NOT_CONTAINS operator in basic search with search 
parameters
 Key: ATLAS-3782
 URL: https://issues.apache.org/jira/browse/ATLAS-3782
 Project: Atlas
  Issue Type: New Feature
  Components:  atlas-core
Affects Versions: 2.0.0
Reporter: Andreas Danckert


The operator 'SearchParameters.Operator.NOT_CONTAINS' is defined and 
implemented in SearchProcessors. It would allow a search of entities that do 
not contain in given string in a specified attribute (eg exclude entities from 
search that contain 'temp' in the qualified name). 

However, this operator is currently ignored when used in REST calls and thus 
not effective. Presumably the reason for this behaviour is that the operator is 
not listed as case value in any of the switch statements on the search operator 
in SearchProcessor.java.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Friendly request for review on Atlas patches

[Bolke de Bruin]

Hi Guys,

My team has been creating quite a few patches for Atlas that are pending in
the review board or have pending discussions in Jira. Would you mind
reviewing them or provide feedback? I do think they are relevant for the
larger community:

ATLAS-3776  -
EntitySearchProcessor fails on queries with a sort by attribute
https://reviews.apache.org/r/72459/ - patch available including unit tests

ATLAS-3654 - Allow Atlas to run in standalone http mode
https://reviews.apache.org/r/72441/ - patch available

ATLAS-3758  -
Support sort parameters for FreeTextSearchProcessor
https://reviews.apache.org/r/72440/ - patch available

ATLAS-3755  -
Support setting system attributes if policy allows it
https://reviews.apache.org/r/72438/ - under discussion, patch available

We observe that there is only a small number of committers active. Can
we do anything to help?

Kind regards

Bolke


--
Bolke de Bruin
bdbr...@gmail.com

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

[Bolke de Bruin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72440/#review220648
---



Can you please update the tests?

- Bolke de Bruin


On April 29, 2020, 10:26 a.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72440/
> ---
> 
> (Updated April 29, 2020, 10:26 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> No way to sort results by specified attribute while freetext search is 
> enabled. In our case we would like to enforce ordering by introducing custom 
> attribute definition e.g. popularity score from 
> https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json
> 
> 
> Reference to jira https://issues.apache.org/jira/browse/ATLAS-3758
> Patched applied against master branch.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  1a7bf6b16 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  92b5eb4d2 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 11eb7ca49 
> 
> 
> Diff: https://reviews.apache.org/r/72440/diff/1/
> 
> 
> Testing
> ---
> 
> Patch was applied on our dev env with custom entity definitions and 
> successfully verified if order is applied as specified in the search query.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>