----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72440/#review220666 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java Lines 995 (patched) <https://reviews.apache.org/r/72440/#comment309232> entityType could be null when called from FreeTextSearchProcessor. Please review and update to handle this condition. - Madhan Neethiraj On April 29, 2020, 10:26 a.m., Damian Warszawski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72440/ > ----------------------------------------------------------- > > (Updated April 29, 2020, 10:26 a.m.) > > > Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, > and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > No way to sort results by specified attribute while freetext search is > enabled. In our case we would like to enforce ordering by introducing custom > attribute definition e.g. popularity score from > https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json > > > Reference to jira https://issues.apache.org/jira/browse/ATLAS-3758 > Patched applied against master branch. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > 1a7bf6b16 > > repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java > 92b5eb4d2 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 11eb7ca49 > > > Diff: https://reviews.apache.org/r/72440/diff/1/ > > > Testing > ------- > > Patch was applied on our dev env with custom entity definitions and > successfully verified if order is applied as specified in the search query. > > > Thanks, > > Damian Warszawski > >
