[GitHub] [incubator-brpc] xiaosage079 opened a new pull request #1034: add support for rwlock, a classic approach
xiaosage079 opened a new pull request #1034: add support for rwlock, a classic approach URL: https://github.com/apache/incubator-brpc/pull/1034 #1031 got error when travis-ci do linking like bvar_percentile_unittest.cpp:(.text+0x35): undefined reference to `bvar::detail::Percentile::Percentile()', but we did not modifie bvar, so I rePR, to see if there are still errors. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] feifeiiong commented on issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth flag存在的意义？
feifeiiong commented on issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth flag存在的意义？ URL: https://github.com/apache/incubator-brpc/issues/1033#issuecomment-576132347 好的，我们尝试一下，谢谢！此外关于 **解析response时就知道哪个是auth的结果并跳过了。** 这里，因为我看到Parse相关的解析都是使用的pipline中的auth状态标志位，不知道还有哪里会使用到with_auth_flag呢？ 我提问的核心意思是，设置pipline的状态标志位是否可以不依赖controller，而只依赖socket是否需要auth，目前看设置pipline标志位的设置是依赖controller中的gflag。谢谢！ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on issue #1023: Please stop using include(FindXXX) in cmake
zyearn commented on issue #1023: Please stop using include(FindXXX) in cmake URL: https://github.com/apache/incubator-brpc/issues/1023#issuecomment-576129491 But `find_package` provides more options for user, so we may replace `include` with `find_package`. The pr is here https://github.com/apache/incubator-brpc/pull/1032 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on issue #1032: replace_include_with_find_package
zyearn commented on issue #1032: replace_include_with_find_package URL: https://github.com/apache/incubator-brpc/pull/1032#issuecomment-576128661 cmake/FindGFLAGS.cmake and cmake/FindGperftools.cmake can not be deleted because they are not builtin module of cmake, we still need it if user install them using other method, such as apt-get This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge edited a comment on issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth flag存在的意义？
jamesge edited a comment on issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth flag存在的意义？ URL: https://github.com/apache/incubator-brpc/issues/1033#issuecomment-576126900 如果发送时的socket需要auth，controller里的with_auth flag就会被设1，解析response时就知道哪个是auth的结果并跳过了。这里的问题应该是在[这里](https://github.com/apache/incubator-brpc/commit/2a8056e6a25486f31fb66978bb84dac286116ee6#diff-2b9be1bcc8c6fcd08928ef21172df470)被改错了。重试前或每次使用socket前应重置with_auth。麻烦尝试一下[master最新的](https://github.com/apache/incubator-brpc/commit/4e519089a4f009c6892409a1a70d76fdb07eb5d5)，看看是否修复了问题。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth flag存在的意义？
jamesge commented on issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth flag存在的意义？ URL: https://github.com/apache/incubator-brpc/issues/1033#issuecomment-576126900 如果发送时的socket需要auth，controller里的with_auth flag就会被设1，解析response时就知道哪个是auth的结果并跳过了。这里的问题应该是在[这里](https://github.com/apache/incubator-brpc/commit/2a8056e6a25486f31fb66978bb84dac286116ee6#diff-2b9be1bcc8c6fcd08928ef21172df470)里被改错了。重试前或每次使用socket前应重置with_auth。麻烦尝试一下[master最新的]([https://github.com/apache/incubator-brpc/commit/4e519089a4f009c6892409a1a70d76fdb07eb5d5)，看看是否修复了问题。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge edited a comment on issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth flag存在的意义？
jamesge edited a comment on issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth flag存在的意义？ URL: https://github.com/apache/incubator-brpc/issues/1033#issuecomment-576126900 如果发送时的socket需要auth，controller里的with_auth flag就会被设1，解析response时就知道哪个是auth的结果并跳过了。这里的问题应该是在[这里](https://github.com/apache/incubator-brpc/commit/2a8056e6a25486f31fb66978bb84dac286116ee6#diff-2b9be1bcc8c6fcd08928ef21172df470)里被改错了。重试前或每次使用socket前应重置with_auth。麻烦尝试一下[master最新的](https://github.com/apache/incubator-brpc/commit/4e519089a4f009c6892409a1a70d76fdb07eb5d5)，看看是否修复了问题。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] branch master updated: Reset with_auth in controller before each sending
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 4e51908 Reset with_auth in controller before each sending
4e51908 is described below
commit 4e519089a4f009c6892409a1a70d76fdb07eb5d5
Author: jamesge
AuthorDate: Mon Jan 20 14:29:24 2020 +0800
Reset with_auth in controller before each sending
---
src/brpc/details/controller_private_accessor.h | 4
src/brpc/policy/redis_protocol.cpp | 2 ++
2 files changed, 6 insertions(+)
diff --git a/src/brpc/details/controller_private_accessor.h
b/src/brpc/details/controller_private_accessor.h
index 1aa567e..362c8f0 100644
--- a/src/brpc/details/controller_private_accessor.h
+++ b/src/brpc/details/controller_private_accessor.h
@@ -128,6 +128,10 @@ public:
_cntl->add_flag(Controller::FLAGS_REQUEST_WITH_AUTH);
}
+void clear_with_auth() {
+_cntl->clear_flag(Controller::FLAGS_REQUEST_WITH_AUTH);
+}
+
std::string& protocol_param() { return _cntl->protocol_param(); }
const std::string& protocol_param() const { return
_cntl->protocol_param(); }
diff --git a/src/brpc/policy/redis_protocol.cpp
b/src/brpc/policy/redis_protocol.cpp
index 1e92bf5..4756e66 100644
--- a/src/brpc/policy/redis_protocol.cpp
+++ b/src/brpc/policy/redis_protocol.cpp
@@ -329,6 +329,8 @@ void PackRedisRequest(butil::IOBuf* buf,
}
buf->append(auth_str);
ControllerPrivateAccessor(cntl).add_with_auth();
+} else {
+ControllerPrivateAccessor(cntl).clear_with_auth();
}
buf->append(request);
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on issue #1023: Please stop using include(FindXXX) in cmake
zyearn commented on issue #1023: Please stop using include(FindXXX) in cmake URL: https://github.com/apache/incubator-brpc/issues/1023#issuecomment-576125295 `include(FindProtobuf)` will include the cmake/Modules/FindProtobuf.cmake file, which uses find_library to find protolib. While find_library does support CMAKE_PREFIX_PATH, it is enough to set CMAKE_PREFIX_PATH to your precompiled path. In fact, one of our project also uses precompiled protobuf and we set CMAKE_PREFIX_PATH. Under it there is an include/ and lib/ directory. So make sure your precompiled path has the same structure, more detail: https://cmake.org/cmake/help/latest/variable/CMAKE_PREFIX_PATH.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] feifeiiong opened a new issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth flag存在的意义？
feifeiiong opened a new issue #1033: redis 认证机制在重试策略下存在问题/controller中 auth flag存在的意义？ URL: https://github.com/apache/incubator-brpc/issues/1033 **Describe the bug (描述bug)** 发生rpc重试时，socket的auth状态与pipline的auth状态有可能不一致。 模式：连接池 **To Reproduce (复现方法)** 在连接池模式下，若发起redis请求后失败需要重试（如tcp 连接超时 connect time out），此时有可能出现controller已被置FLAGS_REQUEST_WITH_AUTH标志位（pip line依赖此标志位），而从池中拿出的socket已认证过无需auth的情况，从而导致解包失败，出现认证失败的错误（ "Redis Auth failed: " ）。 代码位置：  发生重试时，若此处auth为NULL（取出的socket已认证），controller的标志位未清除，从而导致pipline的标志位出错。  这里的疑问是，为什么需要一个这样的标志位？为什么redis的认证不能与socket保持一致？ 即： wopt.with_auth = _auth; 希望能够得到解答。 **Expected behavior (期望行为)** redis的pipline中的auth状态应与socket保持一致，而非controller。 **Versions (各种版本)** OS: Compiler: brpc: protobuf: **Additional context/screenshots (更多上下文/截图)** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on issue #1032: replace_include_with_find_package
zyearn commented on issue #1032: replace_include_with_find_package URL: https://github.com/apache/incubator-brpc/pull/1032#issuecomment-576091247 according to https://github.com/apache/incubator-brpc/issues/1023, find_package provide more options for user to set(such as CMAKE_PREFIX_PATH). The minimum cmake version that brpc use is [2.8.10](https://cmake.org/cmake/help/v2.8.10/cmake.html#command:find_package), and find_package is supported in this version. It is safe to replace include with find_package. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] htn4179 removed a comment on issue #1025: brpc lack of rwlock implementation
htn4179 removed a comment on issue #1025: brpc lack of rwlock implementation URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-576087063 #1031 is classic and less flag and status, #1026 has more flag and status, We maximize the read performance, So, I think it is your choice This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] htn4179 commented on issue #1025: brpc lack of rwlock implementation
htn4179 commented on issue #1025: brpc lack of rwlock implementation URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-576087186 > so which one is the latest? #1031 or #1026? #1031 is classic and less flag and status, #1026 has more flag and status, We maximize the read performance, So, I think it is your choice This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] htn4179 commented on issue #1025: brpc lack of rwlock implementation
htn4179 commented on issue #1025: brpc lack of rwlock implementation URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-576087063 #1031 is classic and less flag and status, #1026 has more flag and status, We maximize the read performance, So, I think it is your choice This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] hairet commented on issue #1025: brpc lack of rwlock implementation
hairet commented on issue #1025: brpc lack of rwlock implementation URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-576082950 > so which one is the latest? #1031 or #1026? the implementation in 1031 will be more clear,it should be the latest but in 1031 I got some error when travis-ci do linking like bvar_percentile_unittest.cpp:(.text+0x35): undefined reference to `bvar::detail::Percentile::Percentile()' this seems unreasonable as bavr test and bavr cc_library are not modified in my commit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on issue #1025: brpc lack of rwlock implementation
zyearn commented on issue #1025: brpc lack of rwlock implementation URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-576006843 so which one is the latest? https://github.com/apache/incubator-brpc/pull/1031 or https://github.com/apache/incubator-brpc/pull/1026? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn removed a comment on issue #1030: rw lock implementation
zyearn removed a comment on issue #1030: rw lock implementation URL: https://github.com/apache/incubator-brpc/issues/1030#issuecomment-576006645 what is the relationship with https://github.com/apache/incubator-brpc/issues/1025? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on issue #1030: rw lock implementation
zyearn commented on issue #1030: rw lock implementation URL: https://github.com/apache/incubator-brpc/issues/1030#issuecomment-576006645 what is the relationship with https://github.com/apache/incubator-brpc/issues/1025? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn opened a new pull request #1032: replace_include_with_find_package
zyearn opened a new pull request #1032: replace_include_with_find_package URL: https://github.com/apache/incubator-brpc/pull/1032 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [VOTE] Release Apache brpc(incubating) 0.9.7-rc03
+1 binding 在 2020/1/19 下午5:21，“James Ge” 写入: +1 binding Solved issues (many thanks to Justin) - Removed butil/memory/scoped_array.h which is replaceable by unique_ptr - Removed butil/md5.cc butil/md5.h test/md5_unittest.cc which is replaceable by openssl/md5.h - Removed authors from headers - Updated copyright years to this year - Added appendix in LICENSE - Added missing licenses in rapidjson/SVGPan/pprof_perl.cpp etc - Replaced crc32 code(category X) in src/brpc/ts.cpp - About the supporting function written by Dean Edwards in ./src/brpc/builtin/sorttable_js.cpp: apache TrafficControl and spark also include the same sortable.js and they only list the MIT licenses [1][2] Unsolved: - flamegraph_perl(category B), used for displaying CPU/heap/contention profiling results in framegraphs. [1] https://github.com/apache/trafficcontrol/blob/master/licenses/MIT-sorttable [2] https://github.com/apache/spark/blob/master/LICENSE#L241 On Thu, Jan 16, 2020 at 11:56 PM tan zhongyi wrote: > Hi, guys, > > > > 0.9.7-rc03 is ready for vote, here it is. > > I am pleased to be calling this vote for the release of apache > brpc(incubating) 0.9.7-rc03. > > Btw: there is still some IP issues left, so we add DISCLAIMER-WIP here. > > > The source code can be found at: > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.7-rc03/apache-brpc-0.9.7.rc03-incubating-src.tar.gz > > > The release candidate has been tagged in GitHub as 0.9.7-rc03, available > here: > https://github.com/apache/incubator-brpc/releases/tag/0.9.7-rc03 > > The SHA-512 checksum is: > > 3852185929f8b242aacef5601acb85ab4b397584c515813f740effb1a9eabdba43eaccbe4b5eb1e6763f672fbb4a7937fe71a0dc4a240ef8891d413f30e9b257 > > > which can be found via: > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.7-rc03/apache-brpc-0.9.7.rc03-incubating-src.tar.gz.sha512 > > > > The signature can be found via: > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.7-rc03/apache-brpc-0.9.7.rc03-incubating-src.tar.gz.asc > > > > KEYS file is available here: > > https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS > > > > > > [Release Note] > > > > * Add DISCLAIMER-WIP as license issues are not all cleaned > * Fix many license related issues > * Health (of a connection) can be checked at rpc-level > * Fix SSL-related compilation issues on Mac > * Support SSL-replacement lib MesaLink > * Support consistent hashing with ketama algo. > * bvar variables can be exported for prometheus services > * String[Multi]Splitter supports '\0' as separator > * Support for bilibili discovery service > * Improved CircuitBreaker > * grpc impl. supports timeout > > > > > > Please vote on releasing this package as: > > Apache brpc(incubating) 0.9.7-rc03 > > > > This vote will be open until “Jan 19 2020 24:00:00 GMT+0800 (CST)" and > > passes if a majority of at least three +1 Apache brpc IPMC votes are > > cast. > > > > [ ] +1 Release this package > > [ ] 0 I don't feel strongly about it, but don't object > > [ ] -1 Do not release this package because... > > > > Anyone can participate in testing and voting, not just committers, please > > feel free to try out the release candidate and provide your votes. > > Thanks > >
[GitHub] [incubator-brpc] hairet opened a new pull request #1031: add support for rwlock
hairet opened a new pull request #1031: add support for rwlock URL: https://github.com/apache/incubator-brpc/pull/1031 补充写优先读写锁实现，变量和状态应该算是比较简洁的了，参考了内核写优先设计。 UT里有性能相关测试 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [VOTE] Release Apache brpc(incubating) 0.9.7-rc03
+1 binding Solved issues (many thanks to Justin) - Removed butil/memory/scoped_array.h which is replaceable by unique_ptr - Removed butil/md5.cc butil/md5.h test/md5_unittest.cc which is replaceable by openssl/md5.h - Removed authors from headers - Updated copyright years to this year - Added appendix in LICENSE - Added missing licenses in rapidjson/SVGPan/pprof_perl.cpp etc - Replaced crc32 code(category X) in src/brpc/ts.cpp - About the supporting function written by Dean Edwards in ./src/brpc/builtin/sorttable_js.cpp: apache TrafficControl and spark also include the same sortable.js and they only list the MIT licenses [1][2] Unsolved: - flamegraph_perl(category B), used for displaying CPU/heap/contention profiling results in framegraphs. [1] https://github.com/apache/trafficcontrol/blob/master/licenses/MIT-sorttable [2] https://github.com/apache/spark/blob/master/LICENSE#L241 On Thu, Jan 16, 2020 at 11:56 PM tan zhongyi wrote: > Hi, guys, > > > > 0.9.7-rc03 is ready for vote, here it is. > > I am pleased to be calling this vote for the release of apache > brpc(incubating) 0.9.7-rc03. > > Btw: there is still some IP issues left, so we add DISCLAIMER-WIP here. > > > The source code can be found at: > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.7-rc03/apache-brpc-0.9.7.rc03-incubating-src.tar.gz > > > The release candidate has been tagged in GitHub as 0.9.7-rc03, available > here: > https://github.com/apache/incubator-brpc/releases/tag/0.9.7-rc03 > > The SHA-512 checksum is: > > 3852185929f8b242aacef5601acb85ab4b397584c515813f740effb1a9eabdba43eaccbe4b5eb1e6763f672fbb4a7937fe71a0dc4a240ef8891d413f30e9b257 > > > which can be found via: > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.7-rc03/apache-brpc-0.9.7.rc03-incubating-src.tar.gz.sha512 > > > > The signature can be found via: > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.7-rc03/apache-brpc-0.9.7.rc03-incubating-src.tar.gz.asc > > > > KEYS file is available here: > > https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS > > > > > > [Release Note] > > > > * Add DISCLAIMER-WIP as license issues are not all cleaned > * Fix many license related issues > * Health (of a connection) can be checked at rpc-level > * Fix SSL-related compilation issues on Mac > * Support SSL-replacement lib MesaLink > * Support consistent hashing with ketama algo. > * bvar variables can be exported for prometheus services > * String[Multi]Splitter supports '\0' as separator > * Support for bilibili discovery service > * Improved CircuitBreaker > * grpc impl. supports timeout > > > > > > Please vote on releasing this package as: > > Apache brpc(incubating) 0.9.7-rc03 > > > > This vote will be open until “Jan 19 2020 24:00:00 GMT+0800 (CST)" and > > passes if a majority of at least three +1 Apache brpc IPMC votes are > > cast. > > > > [ ] +1 Release this package > > [ ] 0 I don't feel strongly about it, but don't object > > [ ] -1 Do not release this package because... > > > > Anyone can participate in testing and voting, not just committers, please > > feel free to try out the release candidate and provide your votes. > > Thanks > >
[GitHub] [incubator-brpc] cloudhan commented on issue #1023: Please stop using include(FindXXX) in cmake
cloudhan commented on issue #1023: Please stop using include(FindXXX) in cmake
URL: https://github.com/apache/incubator-brpc/issues/1023#issuecomment-575980973
OK, to be more specific, what I have done is
```cmake
cmake_minimum_required(VERSION 3.5)
project(server CXX)
#...
# ${CMAKE_CURRENT_SOURCE_DIR}/cmake has a FindProtobuf.cmake copied from brpc
set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake ${CMAKE_MODULE_PATH})
# this is the precompiled protobuf library
set(CMAKE_PREFIX_PATH ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/protobuf
CMAKE_PREFIX_PATH)
# this will use the copied FindProtobuf.cmake
find_package(Protobuf REQUIRED)
# this is for brpc to correctly find
include_directories(${Protobuf_INCLUDE_DIR})
link_directories(${Protobuf_LIBRARY_DIR})
protobuf_generate_cpp(PROTO_SRC PROTO_HEADER proto/XXX.proto)
# brpc is added as a git submodule
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/brpc)
# ...
target_link_libraries(my_target PRIVATE brpc-shared)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Suse130224 closed pull request #1028: support unix socket
Suse130224 closed pull request #1028: support unix socket URL: https://github.com/apache/incubator-brpc/pull/1028 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] htn4179 commented on issue #1026: rwlock implementation based on atomic and butex #1025
htn4179 commented on issue #1026: rwlock implementation based on atomic and butex #1025 URL: https://github.com/apache/incubator-brpc/pull/1026#issuecomment-575978842 yes，I have fixed it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
