[GitHub] [incubator-brpc] thorneliu commented on issue #1940: Invalid host in HTTP header if setting host via service_name for channel inited by list or file
thorneliu commented on issue #1940: URL: https://github.com/apache/incubator-brpc/issues/1940#issuecomment-1279650446 > > We could > > > > * A: check if service name a valid host for HTTP > > * B: set host field by remote_side > > > > option B would revert some changes [dab62e4](https://github.com/apache/incubator-brpc/commit/dab62e476d7dae7edd43d2c9bfa16b76d3ac4879) by @guodongxiaren > > I think we can check if ns_url shceme is 'http' or 'https', if true, set host field by service_name hmm. looks good. I can provide a patch based on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [VOTE] Release Apache brpc (Incubating) 1.3.0
+1 binding On Fri, Oct 14, 2022 at 7:58 PM Jiashun Zhu wrote: > +1 binding > > On Fri, 14 Oct 2022 at 04:55, lhestz wrote: > > > > > +1 (binding), > > the previous voting mail ( > > https://lists.apache.org/thread/q4cj7xko85v62flbybvqqldm1d5424ks) > > from me incorrectly wrote '+1(non-binding)’, ignore it plz. > > > > I have checked: > > > > [x] Download links are valid. > > [x] Checksums and PGP signatures are valid. > > [x] Source code and distribution have correct names matching the current > > release. > > [x] No compiled archives bundled in source archive. > > > > Best regards, > > Lei He > > -- > > helei.si...@bytedance.com > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > >
Re: [VOTE] Release Apache brpc (Incubating) 1.3.0
+1 binding On Fri, 14 Oct 2022 at 04:55, lhestz wrote: > > +1 (binding), > the previous voting mail ( > https://lists.apache.org/thread/q4cj7xko85v62flbybvqqldm1d5424ks) > from me incorrectly wrote '+1(non-binding)’, ignore it plz. > > I have checked: > > [x] Download links are valid. > [x] Checksums and PGP signatures are valid. > [x] Source code and distribution have correct names matching the current > release. > [x] No compiled archives bundled in source archive. > > Best regards, > Lei He > -- > helei.si...@bytedance.com > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > >
[GitHub] [incubator-brpc] wwbmmm closed issue #1859: Why switch bthread cost so much time? (2us), both libgo and golang coroutine switch cost ~200ns?
wwbmmm closed issue #1859: Why switch bthread cost so much time? (2us), both libgo and golang coroutine switch cost ~200ns? URL: https://github.com/apache/incubator-brpc/issues/1859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1145: Bazel 编译潜在问题（zlib 版本冲突）
wwbmmm commented on issue #1145: URL: https://github.com/apache/incubator-brpc/issues/1145#issuecomment-1278770689 master have rework bazel support if still have this issue, please reopen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1145: Bazel 编译潜在问题（zlib 版本冲突）
wwbmmm closed issue #1145: Bazel 编译潜在问题（zlib 版本冲突） URL: https://github.com/apache/incubator-brpc/issues/1145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1268: 如果用bazel编译brpc的话，bazel需要到多少版本呢？
wwbmmm closed issue #1268: 如果用bazel编译brpc的话，bazel需要到多少版本呢？ URL: https://github.com/apache/incubator-brpc/issues/1268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1268: 如果用bazel编译brpc的话，bazel需要到多少版本呢？
wwbmmm commented on issue #1268: URL: https://github.com/apache/incubator-brpc/issues/1268#issuecomment-1278769177 master has support latest version of bazel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1287: Build break with Bazel
wwbmmm commented on issue #1287: URL: https://github.com/apache/incubator-brpc/issues/1287#issuecomment-1278768877 master has support latest version of bazel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1287: Build break with Bazel
wwbmmm closed issue #1287: Build break with Bazel URL: https://github.com/apache/incubator-brpc/issues/1287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1375: What is `external:ssl` in BUILD.bazel
wwbmmm closed issue #1375: What is `external:ssl` in BUILD.bazel URL: https://github.com/apache/incubator-brpc/issues/1375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1407: linux arm 64 环境下，sched_to itself!
wwbmmm closed issue #1407: linux arm 64 环境下，sched_to itself! URL: https://github.com/apache/incubator-brpc/issues/1407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1407: linux arm 64 环境下，sched_to itself!
wwbmmm commented on issue #1407: URL: https://github.com/apache/incubator-brpc/issues/1407#issuecomment-1278763825 master已修复 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1652: 1.0.0 庆祝发版并感谢贡献者活动
wwbmmm closed issue #1652: 1.0.0 庆祝发版并感谢贡献者活动 URL: https://github.com/apache/incubator-brpc/issues/1652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1675: 无法在Ubuntu 21.04 ARM64环境下编译通过
wwbmmm commented on issue #1675: URL: https://github.com/apache/incubator-brpc/issues/1675#issuecomment-1278755904 master已支持arm64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1675: 无法在Ubuntu 21.04 ARM64环境下编译通过
wwbmmm closed issue #1675: 无法在Ubuntu 21.04 ARM64环境下编译通过 URL: https://github.com/apache/incubator-brpc/issues/1675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1689: [Bazel Build Error] Fail to build with new bazel version 4.2
wwbmmm closed issue #1689: [Bazel Build Error] Fail to build with new bazel version 4.2 URL: https://github.com/apache/incubator-brpc/issues/1689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1705: gdb调试brpc服务出core
wwbmmm closed issue #1705: gdb调试brpc服务出core URL: https://github.com/apache/incubator-brpc/issues/1705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1756: 对端重启后，客户端报错Reached timeout
wwbmmm closed issue #1756: 对端重启后，客户端报错Reached timeout URL: https://github.com/apache/incubator-brpc/issues/1756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1841: protobuf 3.21.2 编译失败
wwbmmm closed issue #1841: protobuf 3.21.2 编译失败 URL: https://github.com/apache/incubator-brpc/issues/1841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1771: 构建失败
wwbmmm closed issue #1771: 构建失败 URL: https://github.com/apache/incubator-brpc/issues/1771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1827: wrr在上游节点很多同时频繁调权的情况下会出现QPS的抖动
wwbmmm closed issue #1827: wrr在上游节点很多同时频繁调权的情况下会出现QPS的抖动 URL: https://github.com/apache/incubator-brpc/issues/1827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1828: rr 模式下，qps 不变，rpc 下游节点增多时，平均耗时和99线耗时明显上升
wwbmmm closed issue #1828: rr 模式下，qps 不变，rpc 下游节点增多时，平均耗时和99线耗时明显上升 URL: https://github.com/apache/incubator-brpc/issues/1828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1861: Responses spent a lot of time（响应花费了很长时间）
wwbmmm closed issue #1861: Responses spent a lot of time（响应花费了很长时间） URL: https://github.com/apache/incubator-brpc/issues/1861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1906: 调整brpc worker线程数的接口
wwbmmm closed issue #1906: 调整brpc worker线程数的接口 URL: https://github.com/apache/incubator-brpc/issues/1906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1892: rpc_press.md文档描述上下矛盾, 最上说不支持grpc等, 下面的protocol选项提到支持
wwbmmm closed issue #1892: rpc_press.md文档描述上下矛盾, 最上说不支持grpc等, 下面的protocol选项提到支持 URL: https://github.com/apache/incubator-brpc/issues/1892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1932: MallocExtension declaration in tcmalloc_extension.h blocks UBSAN build
wwbmmm commented on issue #1932: URL: https://github.com/apache/incubator-brpc/issues/1932#issuecomment-1278731178 maybe we can provide a macro to disable tcmalloc related code in compile time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1940: Invalid host in HTTP header if setting host via service_name for channel inited by list or file
wwbmmm commented on issue #1940: URL: https://github.com/apache/incubator-brpc/issues/1940#issuecomment-1278690518 > We could > > * A: check if service name a valid host for HTTP > * B: set host field by remote_side > > option B would revert some changes [dab62e4](https://github.com/apache/incubator-brpc/commit/dab62e476d7dae7edd43d2c9bfa16b76d3ac4879) by @guodongxiaren I think we can check if ns_url shceme is 'http' or 'https', if true, set host field by service_name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1953: cmurmur负载均衡算法流量不均匀
wwbmmm commented on issue #1953: URL: https://github.com/apache/incubator-brpc/issues/1953#issuecomment-1278684086 是不是传入的request code本身不均匀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1945: rdma分支存在内存泄漏问题
wwbmmm commented on issue #1945: URL: https://github.com/apache/incubator-brpc/issues/1945#issuecomment-1278682266 请问使用的rdma分支是 https://github.com/apache/incubator-brpc/tree/rdma 还是 https://github.com/apache/incubator-brpc/pull/1836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] branch master updated: Fix "sched_to itself" error when buidling by Clang on Linux aarch64 (#1950)
This is an automated email from the ASF dual-hosted git repository.
wwbmmm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 11b2f52f Fix "sched_to itself" error when buidling by Clang on Linux
aarch64 (#1950)
11b2f52f is described below
commit 11b2f52fcb15b6847907dff5fdc9971c3d8417ff
Author: Adonis Ling
AuthorDate: Fri Oct 14 16:03:41 2022 +0800
Fix "sched_to itself" error when buidling by Clang on Linux aarch64 (#1950)
---
src/bthread/task_group.cpp | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/bthread/task_group.cpp b/src/bthread/task_group.cpp
index b8ead163..94ce5eb7 100644
--- a/src/bthread/task_group.cpp
+++ b/src/bthread/task_group.cpp
@@ -248,6 +248,9 @@ int TaskGroup::init(size_t runqueue_capacity) {
return 0;
}
+#if defined(__linux__) && defined(__aarch64__) && defined(__clang__)
+__attribute__((optnone))
+#endif
void TaskGroup::task_runner(intptr_t skip_remained) {
// NOTE: tls_task_group is volatile since tasks are moved around
// different groups.
@@ -567,6 +570,9 @@ void TaskGroup::sched(TaskGroup** pg) {
sched_to(pg, next_tid);
}
+#if defined(__linux__) && defined(__aarch64__) && defined(__clang__)
+__attribute__((optnone))
+#endif
void TaskGroup::sched_to(TaskGroup** pg, TaskMeta* next_meta) {
TaskGroup* g = *pg;
#ifndef NDEBUG
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm merged pull request #1950: Fix "sched_to itself" error when building by Clang on Linux aarch64
wwbmmm merged PR #1950: URL: https://github.com/apache/incubator-brpc/pull/1950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #1928: limiting max bytes in stream comsume queue with the same host socket
wwbmmm commented on code in PR #1928:
URL: https://github.com/apache/incubator-brpc/pull/1928#discussion_r995464880
##
src/brpc/stream.h:
##
@@ -49,12 +49,18 @@ class StreamInputHandler {
struct StreamOptions {
StreamOptions()
-: max_buf_size(2 * 1024 * 1024)
+: min_buf_size(1024 * 1024)
+, max_buf_size(2 * 1024 * 1024)
, idle_timeout_ms(-1)
, messages_in_batch(128)
, handler(NULL)
{}
+// The max size of unconsumed data allowed at remote side.
Review Comment:
the comment of min_buf_size is same as max_buf_size
##
src/brpc/stream.cpp:
##
@@ -287,18 +295,37 @@ int Stream::AppendIfNotFull(const butil::IOBuf ) {
return 0;
}
-void Stream::SetRemoteConsumed(size_t new_remote_consumed) {
-CHECK(_options.max_buf_size > 0);
+void Stream::SetRemoteConsumed(size_t new_remote_consumed, int64_t
remote_stream_buffer_remain) {
+CHECK(_cur_max_buf_size > 0);
bthread_id_list_t tmplist;
bthread_id_list_init(, 0, 0);
bthread_mutex_lock(&_congestion_control_mutex);
if (_remote_consumed >= new_remote_consumed) {
bthread_mutex_unlock(&_congestion_control_mutex);
return;
}
-const bool was_full = _produced >= _remote_consumed +
(size_t)_options.max_buf_size;
+const bool was_full = _produced >= _remote_consumed +
(size_t)_cur_max_buf_size;
+
+if (FLAGS_socket_max_streams_unconsumed_bytes > 0)
+{
Review Comment:
{ don't need a new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #1928: limiting max bytes in stream comsume queue with the same host socket
wwbmmm commented on PR #1928: URL: https://github.com/apache/incubator-brpc/pull/1928#issuecomment-1278630192 @chenbay Could you describe the use case of these new options? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] fansehep closed issue #1951: Should add a pull_request_template.md?
fansehep closed issue #1951: Should add a pull_request_template.md? URL: https://github.com/apache/incubator-brpc/issues/1951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1809: 用mold链接brpc报duplicate symbol
wwbmmm closed issue #1809: 用mold链接brpc报duplicate symbol URL: https://github.com/apache/incubator-brpc/issues/1809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1809: 用mold链接brpc报duplicate symbol
wwbmmm commented on issue #1809: URL: https://github.com/apache/incubator-brpc/issues/1809#issuecomment-1278612229 Fixed by https://github.com/apache/incubator-brpc/pull/1936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] branch master updated: Fix the linkage errors caused by duplicate symbols (#1936)
This is an automated email from the ASF dual-hosted git repository.
wwbmmm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 6fed7b23 Fix the linkage errors caused by duplicate symbols (#1936)
6fed7b23 is described below
commit 6fed7b2328a8ba324c5eaad6f3f5b39c213b3fe5
Author: Adonis Ling
AuthorDate: Fri Oct 14 15:39:47 2022 +0800
Fix the linkage errors caused by duplicate symbols (#1936)
---
src/butil/class_name.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/butil/class_name.h b/src/butil/class_name.h
index 48babf79..29c91a9c 100644
--- a/src/butil/class_name.h
+++ b/src/butil/class_name.h
@@ -30,7 +30,7 @@ namespace butil {
std::string demangle(const char* name);
-namespace detail {
+namespace {
template struct ClassNameHelper { static std::string name; };
template std::string ClassNameHelper::name =
demangle(typeid(T).name());
}
@@ -39,7 +39,7 @@ template std::string ClassNameHelper::name =
demangle(typeid(T).
template const std::string& class_name_str() {
// We don't use static-variable-inside-function because before C++11
// local static variable is not guaranteed to be thread-safe.
-return detail::ClassNameHelper::name;
+return ClassNameHelper::name;
}
// Get name of class |T|, in const char*.
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm merged pull request #1936: Fix the linkage errors caused by duplicate symbols
wwbmmm merged PR #1936: URL: https://github.com/apache/incubator-brpc/pull/1936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] branch master updated: add pull_request_template.md (#1952)
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 003b3a40 add pull_request_template.md (#1952) 003b3a40 is described below commit 003b3a4076370b5043e412527ba84167a431deb2 Author: fan <75058860+fanse...@users.noreply.github.com> AuthorDate: Fri Oct 14 15:31:22 2022 +0800 add pull_request_template.md (#1952) Signed-off-by: fan Signed-off-by: fan --- .github/pull_request_template.md | 20 1 file changed, 20 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index ..030d014b --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,20 @@ +### What problem does this PR solve? + +Issue Number: + +Problem Summary: + +### What is changed and the side effects? + +Changed: + +Side effects: +- Performance effects(性能影响): + +- Breaking backward compatibility(向后兼容性): + +--- +### Check List: +- Please make sure your changes are compilable(请确保你的更改可以通过编译). +- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). +- Please follow [Contributor Covenant Code of Conduct](../CODE_OF_CONDUCT.md).(请遵循贡献者准则). - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm merged pull request #1952: add pull_request_template.md
wwbmmm merged PR #1952: URL: https://github.com/apache/incubator-brpc/pull/1952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
