Re: Review Request: fix for cloudstack-2859 (incorrect secondary dns address)

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11657/#review21488
---

Ship it!


Ship It!

- Rajesh Battala


On June 5, 2013, 4:46 p.m., Shane Witbeck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11657/
> ---
> 
> (Updated June 5, 2013, 4:46 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> ---
> 
> This patch replaces the incorrect secondary DNS addresses (4.4.4.4 -> 
> 8.8.4.4).
> 
> There are several places where 4.4.4.4 is defined as secondary DNS. Should 
> this instead be 8.8.4.4 which is the Google [1] secondary DNS address? I also 
> brought this up on the dev mailing list [2] 
> 
> [1] https://developers.google.com/speed/public-dns/ 
> [2] 
> http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201306.mbox/%3C921C9A2F781547A08CEAC84589A84A60%40digitalsanctum.com%3E
>  
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-2859.
> 
> 
> Diffs
> -
> 
>   tools/appliance/definitions/systemvmtemplate/postinstall.sh 7c06796 
>   tools/appliance/definitions/systemvmtemplate64/postinstall.sh 35a4e4a 
>   tools/devcloud-kvm/devcloud-kvm.cfg b3f048a 
>   tools/devcloud/devcloud.cfg e6ab71b 
>   tools/devcloud/devcloud_internal-mgt.cfg fe3dd1b 
>   tools/devcloud/quickcloud.cfg a2613d2 
>   tools/marvin/marvin/configGenerator.py c970ada 
>   tools/marvin/marvin/jsonHelper.py 37363bc 
> 
> Diff: https://reviews.apache.org/r/11657/diff/
> 
> 
> Testing
> ---
> 
> I ran `mvn clean install -P developer,systemvm` with no issues.
> 
> 
> Thanks,
> 
> Shane Witbeck
> 
>

RE: ssvm-check.sh on xen

[Rajesh Battala]

Daan, 
I had already fixed the issue and committed to master. There is issue with 
packing so the new script is not getting packaged.

Thanks
Rajesh Battala

> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: Wednesday, June 12, 2013 7:36 PM
> To: dev@cloudstack.apache.org
> Subject: ssvm-check.sh on xen
> 
> H,
> 
> I worked through the ssvm troubleshoot page and ran the ssvm-check.sh on
> the s-1-vm on my dev environment. The script failed because it tries to write
> to a mount it identifies as an nfs mount falsely.
> 
> The mount
> rpc_pipefs on /var/lib/nfs/rpc_pipefs type rpc_pipefs (rw,relatime) is
> identified as a nfs-mount I changed some grep pipelines to make sure it is
> ignored. Should I commit this somewhere?
> 
> 
> # check to see if we have the NFS volume mounted echo
> 
> mount|grep -v sunrpc|grep -v /nfs/ |grep nfs 1> /dev/null 2>&1
> if [ $? -eq 0 ]
> then
> echo "NFS is currently mounted"
> # check for write access
> for MOUNTPT in `mount|grep -v sunrpc| grep -v /nfs/ |grep nfs| awk '{print
> $3}'` do if [ $MOUNTPT != "/proc/xen" ] # mounted by xen
> 
> kind regards,
> Daan Hoogland

Review Request: CLOUDSTACK-2340 [AWS Style Health Checks] Response of the API listLoadBalancerRuleInstances should show the service state of a VM if health check is configured for it

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11858/
---

Review request for cloudstack, Murali Reddy and Ram Ganesh.


Description
---

Issue: when healthcheck is created for LB rule then 
listLoadBalancerRuleInstance api should have the service state populated by 
LBHealthCheckManager. 
Fixed: Fixed the response of listLoadBalancerRuleInstance  to include a 
"servicestate":"UP" which tell the service state of the instance.
   if the healthcheck is not created on LB then api response then 
"servicestate" field won't be in the response.


This addresses bug CLOUDSTACK-2340.


Diffs
-

  api/src/com/cloud/network/lb/LoadBalancingRulesService.java 5fc41e3 
  api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c 
  
api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRuleInstancesCmd.java
 49ab42c 
  api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a 
  server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 67d31ab 

Diff: https://reviews.apache.org/r/11858/diff/


Testing
---

1. Created LB rule with healthcheck policy verified the 
listLoadBalancerRuleInstance  api response, it has the field servicestate for 
all the VM's assigned to the LB rule
2. Created LB rule without healthcheck policy, verified the 
listLoadBalancerRuleInstance api response wont have the servicestate field for 
all the VM's assigned to the LB rule


Thanks,

Rajesh Battala

Review Request: CLOUDSTACK-2398 , ssvm-check failed with permission error

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11862/
---

Review request for cloudstack.


Description
---

In the new system vm template, 

rpc_pipefs is getting mount on "/var/lib/nfs/rpc_pipefs type rpc_pipefs 
(rw,relatime)"

ssvm-healthcheck grep is including this mount point to verify the read/write 
access.
As this is virtual system filesystem, this should skip testing read/write 
access. 
Fixed the issue by excluding "/var/lib/nfs/rpc_pipefs" to validate for 
read/write access in ssvm-health


This addresses bug CLOUDSTACK-2398.


Diffs
-

  services/console-proxy/server/scripts/ssvm-check.sh a401164 

Diff: https://reviews.apache.org/r/11862/diff/


Testing
---

1.verified in the new system vm template, where rpc_pipefs is mount on 
/var/lib/nfs/rpc_pipefs is not testing for read/write acces.


O/P of modified ssvm-check script.

root@s-1-VM:/usr/local/cloud/systemvm# ./ssvm-check.sh 

First DNS server is  10.103.128.15
PING 10.103.128.15 (10.103.128.15): 56 data bytes
64 bytes from 10.103.128.15: icmp_seq=0 ttl=120 time=4.296 ms
64 bytes from 10.103.128.15: icmp_seq=1 ttl=120 time=1.483 ms
--- 10.103.128.15 ping statistics ---
2 packets transmitted, 2 packets received, 0% packet loss
round-trip min/avg/max/stddev = 1.483/2.889/4.296/1.407 ms
Good: Can ping DNS server

Good: DNS resolves download.cloud.com

NFS is currently mounted
Mount point is /mnt/SecStorage/25944601-ec85-3f19-b8ea-2fe0200c2eb0
Good: Can write to mount point

Management server is 10.102.192.136. Checking connectivity.
Good: Can connect to management server port 8250

Good: Java process is running

Tests Complete. Look for ERROR or WARNING above.


Thanks,

Rajesh Battala

Regarding ssvm-check script

[Rajesh Battala]

Hi All,
While fixing an issue ( https://reviews.apache.org/r/11862/ )in ssvm-check 
script I figured out some issues.

1.There are two ssvm_check scripts(duplicates).

./services/console-proxy/server/scripts/ssvm-check.sh
./services/secondary-storage/scripts/ssvm-check.sh

When building the code, these scripts will go to systemvm.zip, systemvm.zip 
will be packaged into systemvm.iso. 

systemvm-descriptor.xml will define what all the scripts should package.
As per the descriptor xml,  the ssvm-check script under console-proxy is 
getting into systemvm.zip.

I had verified the ssvm-check script with the fix under console-proxy. The 
systemvm.zip is getting update properly and making into systemvm.iso.
And ssvm is getting the right script now.

Changes made in script under ./services/secondary-storage/scripts/ssvm-check.sh 
is not getting into systemvm.iso

I feel the script is redundant and creating confusion. 
Can we remove the script in one location?

Thanks
Rajesh Battala

RE: Regarding ssvm-check script

[Rajesh Battala]

I had submitted the patch to the script which is making into systemvm.iso. 
If the other script is not used, we can delete it to avoid confusion in future. 

> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Thursday, June 13, 2013 11:16 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Regarding ssvm-check script
> 
> On Thu, Jun 13, 2013 at 05:10:06PM +, Rajesh Battala wrote:
> > Hi All,
> > While fixing an issue ( https://reviews.apache.org/r/11862/ )in ssvm-check
> script I figured out some issues.
> >
> > 1.There are two ssvm_check scripts(duplicates).
> >
> > ./services/console-proxy/server/scripts/ssvm-check.sh
> > ./services/secondary-storage/scripts/ssvm-check.sh
> >
> > When building the code, these scripts will go to systemvm.zip,
> systemvm.zip will be packaged into systemvm.iso.
> >
> > systemvm-descriptor.xml will define what all the scripts should package.
> > As per the descriptor xml,  the ssvm-check script under console-proxy is
> getting into systemvm.zip.
> >
> > I had verified the ssvm-check script with the fix under console-proxy. The
> systemvm.zip is getting update properly and making into systemvm.iso.
> > And ssvm is getting the right script now.
> >
> > Changes made in script under ./services/secondary-storage/scripts/ssvm-
> check.sh is not getting into systemvm.iso
> >
> > I feel the script is redundant and creating confusion.
> > Can we remove the script in one location?
> >
> > Thanks
> > Rajesh Battala
> 
> This seems quite logical.  Care to submit a patch that cleans this up?

RE: Regarding ssvm-check script

[Rajesh Battala]

Nitin, 
Yes, the ssvm under console proxy should be removed. It make more sense for the 
script to be coming from secondary-storage folder path. 
If you are removing the script under consoleproxy, make the change in the 
systemvm-description.xml to pick the ssvm script from the secondary storage 
scripts. 
If you don't make that change systemvm.iso might not have the ssvm script.

Thanks
Rajesh Battala

> -Original Message-
> From: Nitin Mehta [mailto:nitin.me...@citrix.com]
> Sent: Friday, June 14, 2013 12:09 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Regarding ssvm-check script
> 
> Hi Rajesh,
> Please find my comments inline
> 
> On 13/06/13 10:40 PM, "Rajesh Battala"  wrote:
> 
> >Hi All,
> >While fixing an issue ( https://reviews.apache.org/r/11862/ )in
> >ssvm-check script I figured out some issues.
> >
> >1.There are two ssvm_check scripts(duplicates).
> >
> >./services/console-proxy/server/scripts/ssvm-check.sh
> >./services/secondary-storage/scripts/ssvm-check.sh
> >
> >When building the code, these scripts will go to systemvm.zip,
> >systemvm.zip will be packaged into systemvm.iso.
> >
> >systemvm-descriptor.xml will define what all the scripts should package.
> >As per the descriptor xml,  the ssvm-check script under console-proxy
> >is getting into systemvm.zip.
> 
> Shouldn't it be the other way round ? I mean the ssvm script under
> secondary-storage should have come in ?
> 
> >
> >I had verified the ssvm-check script with the fix under console-proxy.
> >The systemvm.zip is getting update properly and making into systemvm.iso.
> >And ssvm is getting the right script now.
> >
> >Changes made in script under
> >./services/secondary-storage/scripts/ssvm-check.sh is not getting into
> >systemvm.iso
> >
> >I feel the script is redundant and creating confusion.
> >Can we remove the script in one location?
> 
> I would remove it from console-proxy for the sake of consistency and make
> sure the one under secondary-storage gets in. Also while doing so hopefully
> the final location (folder structure) of the script is not disturbed in the 
> ssvm
> 
> >
> >Thanks
> >Rajesh Battala

RE: Regarding ssvm-check script

[Rajesh Battala]

I had created a ticket for the issue 
https://issues.apache.org/jira/browse/CLOUDSTACK-3004 
Will work on it and send the patch for the review. 

Fix would be, remove the script from console proxy folder, modify the 
systemvm-description.xml  to include the ssvm_check file from the proper 
location. 

Thanks
Rajesh Battala

> -Original Message-
> From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> Sent: Friday, June 14, 2013 1:07 PM
> To: dev@cloudstack.apache.org
> Subject: RE: Regarding ssvm-check script
> 
> Nitin,
> Yes, the ssvm under console proxy should be removed. It make more sense
> for the script to be coming from secondary-storage folder path.
> If you are removing the script under consoleproxy, make the change in the
> systemvm-description.xml to pick the ssvm script from the secondary storage
> scripts.
> If you don't make that change systemvm.iso might not have the ssvm script.
> 
> Thanks
> Rajesh Battala
> 
> > -Original Message-
> > From: Nitin Mehta [mailto:nitin.me...@citrix.com]
> > Sent: Friday, June 14, 2013 12:09 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Regarding ssvm-check script
> >
> > Hi Rajesh,
> > Please find my comments inline
> >
> > On 13/06/13 10:40 PM, "Rajesh Battala" 
> wrote:
> >
> > >Hi All,
> > >While fixing an issue ( https://reviews.apache.org/r/11862/ )in
> > >ssvm-check script I figured out some issues.
> > >
> > >1.There are two ssvm_check scripts(duplicates).
> > >
> > >./services/console-proxy/server/scripts/ssvm-check.sh
> > >./services/secondary-storage/scripts/ssvm-check.sh
> > >
> > >When building the code, these scripts will go to systemvm.zip,
> > >systemvm.zip will be packaged into systemvm.iso.
> > >
> > >systemvm-descriptor.xml will define what all the scripts should package.
> > >As per the descriptor xml,  the ssvm-check script under console-proxy
> > >is getting into systemvm.zip.
> >
> > Shouldn't it be the other way round ? I mean the ssvm script under
> > secondary-storage should have come in ?
> >
> > >
> > >I had verified the ssvm-check script with the fix under console-proxy.
> > >The systemvm.zip is getting update properly and making into
> systemvm.iso.
> > >And ssvm is getting the right script now.
> > >
> > >Changes made in script under
> > >./services/secondary-storage/scripts/ssvm-check.sh is not getting
> > >into systemvm.iso
> > >
> > >I feel the script is redundant and creating confusion.
> > >Can we remove the script in one location?
> >
> > I would remove it from console-proxy for the sake of consistency and
> > make sure the one under secondary-storage gets in. Also while doing so
> > hopefully the final location (folder structure) of the script is not
> > disturbed in the ssvm
> >
> > >
> > >Thanks
> > >Rajesh Battala

Review Request: Fixed CLOUDSTACK-3004 [script] ssvm_check remove the duplicate file from consoleproxy and include the script from secondary storage folder while packing iso

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11874/
---

Review request for cloudstack and Chip Childers.


Description
---

Issue: .There are two ssvm_check scripts(duplicates).

./services/console-proxy/server/scripts/ssvm-check.sh
./services/secondary-storage/scripts/ssvm-check.sh

When building the code, these scripts will go to systemvm.zip, systemvm.zip 
will be packaged into systemvm.iso. 

systemvm-descriptor.xml will define what all the scripts should package.
As per the descriptor xml,  the ssvm-check script under console-proxy is 
getting into systemvm.zip.

I had verified the ssvm-check script with the fix under console-proxy. The 
systemvm.zip is getting update properly and making into systemvm.iso.
And ssvm is getting the right script now.

Changes made in script under ./services/secondary-storage/scripts/ssvm-check.sh 
is not getting into systemvm.iso

Fixed:
Modified systemvm-descriptor.xml to pick the ssvm-check.sh form 
./services/secondary-storage/scripts/ssvm-check.sh
removed the duplicate file which is creating confusion 
(./services/console-proxy/server/scripts/ssvm-check.sh)


This addresses bug CLOUDSTACK-3004.


Diffs
-

  services/console-proxy/server/scripts/ssvm-check.sh 7b83c98 
  services/console-proxy/server/systemvm-descriptor.xml e34026b 

Diff: https://reviews.apache.org/r/11874/diff/


Testing
---

Tested by generating the systemvm.zip , the ssvm-check file is getting copied 
into the zip from the ./services/secondary-storage/scripts/ssvm-check.sh


Thanks,

Rajesh Battala

RE: Regarding ssvm-check script

[Rajesh Battala]

I had fixed the issue and posted the patch for the  review 
@https://reviews.apache.org/r/11874/ 

Thanks
Rajesh Battala

> -Original Message-
> From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> Sent: Friday, June 14, 2013 1:38 PM
> To: dev@cloudstack.apache.org
> Subject: RE: Regarding ssvm-check script
> 
> I had created a ticket for the issue
> https://issues.apache.org/jira/browse/CLOUDSTACK-3004
> Will work on it and send the patch for the review.
> 
> Fix would be, remove the script from console proxy folder, modify the
> systemvm-description.xml  to include the ssvm_check file from the proper
> location.
> 
> Thanks
> Rajesh Battala
> 
> > -Original Message-
> > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> > Sent: Friday, June 14, 2013 1:07 PM
> > To: dev@cloudstack.apache.org
> > Subject: RE: Regarding ssvm-check script
> >
> > Nitin,
> > Yes, the ssvm under console proxy should be removed. It make more
> > sense for the script to be coming from secondary-storage folder path.
> > If you are removing the script under consoleproxy, make the change in
> > the systemvm-description.xml to pick the ssvm script from the
> > secondary storage scripts.
> > If you don't make that change systemvm.iso might not have the ssvm
> script.
> >
> > Thanks
> > Rajesh Battala
> >
> > > -Original Message-
> > > From: Nitin Mehta [mailto:nitin.me...@citrix.com]
> > > Sent: Friday, June 14, 2013 12:09 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: Regarding ssvm-check script
> > >
> > > Hi Rajesh,
> > > Please find my comments inline
> > >
> > > On 13/06/13 10:40 PM, "Rajesh Battala" 
> > wrote:
> > >
> > > >Hi All,
> > > >While fixing an issue ( https://reviews.apache.org/r/11862/ )in
> > > >ssvm-check script I figured out some issues.
> > > >
> > > >1.There are two ssvm_check scripts(duplicates).
> > > >
> > > >./services/console-proxy/server/scripts/ssvm-check.sh
> > > >./services/secondary-storage/scripts/ssvm-check.sh
> > > >
> > > >When building the code, these scripts will go to systemvm.zip,
> > > >systemvm.zip will be packaged into systemvm.iso.
> > > >
> > > >systemvm-descriptor.xml will define what all the scripts should package.
> > > >As per the descriptor xml,  the ssvm-check script under
> > > >console-proxy is getting into systemvm.zip.
> > >
> > > Shouldn't it be the other way round ? I mean the ssvm script under
> > > secondary-storage should have come in ?
> > >
> > > >
> > > >I had verified the ssvm-check script with the fix under console-proxy.
> > > >The systemvm.zip is getting update properly and making into
> > systemvm.iso.
> > > >And ssvm is getting the right script now.
> > > >
> > > >Changes made in script under
> > > >./services/secondary-storage/scripts/ssvm-check.sh is not getting
> > > >into systemvm.iso
> > > >
> > > >I feel the script is redundant and creating confusion.
> > > >Can we remove the script in one location?
> > >
> > > I would remove it from console-proxy for the sake of consistency and
> > > make sure the one under secondary-storage gets in. Also while doing
> > > so hopefully the final location (folder structure) of the script is
> > > not disturbed in the ssvm
> > >
> > > >
> > > >Thanks
> > > >Rajesh Battala

RE: instance is not coming on the vmware deployment

[Rajesh Battala]

The issue would be ssh keys or the VR is not up

> -Original Message-
> From: Srikanteswararao Talluri [mailto:srikanteswararao.tall...@citrix.com]
> Sent: Friday, June 14, 2013 6:55 PM
> To: dev@cloudstack.apache.org
> Subject: instance is not coming on the vmware deployment
> 
> I am encountering the following error while deploying VM . Has anyone
> observed this issue?
> 
>  (DirectAgent-207:10.147.40.24) Failed to authentication SSH user root on
> host 10.147.40.168
> 2013-06-14 21:27:01,711 ERROR [vmware.resource.VmwareResource]
> (DirectAgent-207:10.147.40.24) Unable to execute NetworkUsage command
> on DomR (10.147.40.168), domR may not be ready yet. failure due to
> Exception: java.lang.Exception
> Message: Failed to authentication SSH user root on host 10.147.40.168
> 
> java.lang.Exception: Failed to authentication SSH user root on host
> 10.147.40.168 at
> com.cloud.utils.ssh.SshHelper.sshExecute(SshHelper.java:144)
> at com.cloud.utils.ssh.SshHelper.sshExecute(SshHelper.java:37)
> at
> com.cloud.hypervisor.vmware.resource.VmwareResource.networkUsage(Vm
> wareResource.java:5451)
> at
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareRe
> source.java:2301)
> at
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(V
> mwareResource.java:480)
> at
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.j
> ava:186)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.acc
> ess$101(ScheduledThreadPoolExecutor.java:165)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run
> (ScheduledThreadPoolExecutor.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.jav
> a:1110)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.ja
> va:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 21:27:01,723 DEBUG [cloud.api.ApiServlet] (catalina-exec-25:null)
> ===START===  10.101.255.119 -- GET
> command=queryAsyncJobResult&jobId=028ed6bf-3155-497b-b680-
> f621e7267fbb&response=json&sessionkey=cA5artzeaAoXYJ8O5MNXTCjAdZU
> %3D&_=1371205895591
> 
> 
> Thanks,
> ~Talluri

RE: Review Request: Fixed CLOUDSTACK-3004 [script] ssvm_check remove the duplicate file from consoleproxy and include the script from secondary storage folder while packing iso

[Rajesh Battala]

Is it because the patch contains removing file ?

> -Original Message-
> From: Nitin Mehta [mailto:nore...@reviews.apache.org] On Behalf Of Nitin
> Mehta
> Sent: Friday, June 14, 2013 8:24 PM
> To: Chip Childers
> Cc: Rajesh Battala; cloudstack; Nitin Mehta
> Subject: Re: Review Request: Fixed CLOUDSTACK-3004 [script] ssvm_check
> remove the duplicate file from consoleproxy and include the script from
> secondary storage folder while packing iso
> 
> 
> 
> > On June 14, 2013, 2:44 p.m., Nitin Mehta wrote:
> > > Ship It!
> 
> Hi Rajesh - I get the error below while trying to apply your fix. Could you
> please correct and resubmit ?
> 
> Nitins-MacBook-Air:cloudstack nitinmehta$ git apply --whitespace=fix
> ../0001-CLOUDSTACK-3004-\[script\]-ssvm_check-remove-the-duplicate-file-
> from-consoleproxy-and-include-the-script-from-secondary-storage-folder-
> while-packing-iso.patch
> error: patch failed: services/console-proxy/server/scripts/ssvm-check.sh:1
> error: services/console-proxy/server/scripts/ssvm-check.sh: patch does not
> apply
> 
> 
> - Nitin
> 
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11874/#review21905
> ---
> 
> 
> On June 14, 2013, 10:09 a.m., Rajesh Battala wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/11874/
> > ---
> >
> > (Updated June 14, 2013, 10:09 a.m.)
> >
> >
> > Review request for cloudstack and Chip Childers.
> >
> >
> > Description
> > ---
> >
> > Issue: .There are two ssvm_check scripts(duplicates).
> >
> > ./services/console-proxy/server/scripts/ssvm-check.sh
> > ./services/secondary-storage/scripts/ssvm-check.sh
> >
> > When building the code, these scripts will go to systemvm.zip,
> systemvm.zip will be packaged into systemvm.iso.
> >
> > systemvm-descriptor.xml will define what all the scripts should package.
> > As per the descriptor xml,  the ssvm-check script under console-proxy is
> getting into systemvm.zip.
> >
> > I had verified the ssvm-check script with the fix under console-proxy. The
> systemvm.zip is getting update properly and making into systemvm.iso.
> > And ssvm is getting the right script now.
> >
> > Changes made in script under ./services/secondary-storage/scripts/ssvm-
> check.sh is not getting into systemvm.iso
> >
> > Fixed:
> > Modified systemvm-descriptor.xml to pick the ssvm-check.sh form
> ./services/secondary-storage/scripts/ssvm-check.sh
> > removed the duplicate file which is creating confusion
> (./services/console-proxy/server/scripts/ssvm-check.sh)
> >
> >
> > This addresses bug CLOUDSTACK-3004.
> >
> >
> > Diffs
> > -
> >
> >   services/console-proxy/server/scripts/ssvm-check.sh 7b83c98
> >   services/console-proxy/server/systemvm-descriptor.xml e34026b
> >
> > Diff: https://reviews.apache.org/r/11874/diff/
> >
> >
> > Testing
> > ---
> >
> > Tested by generating the systemvm.zip , the ssvm-check file is getting
> copied into the zip from the ./services/secondary-storage/scripts/ssvm-
> check.sh
> >
> >
> > Thanks,
> >
> > Rajesh Battala
> >
> >

Re: Review Request: Fixed CLOUDSTACK-3004 [script] ssvm_check remove the duplicate file from consoleproxy and include the script from secondary storage folder while packing iso

[Rajesh Battala]

> On June 15, 2013, 5:53 a.m., ASF Subversion and Git Services wrote:
> > Commit 6d140538c5efc394fda8a4ddc7cb72832470d0b3 in branch refs/heads/master 
> > from Rajesh Battala
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6d14053 ]
> > 
> > CLOUDSTACK-3004: remove duplicate ssvm-check.sh
> > 
> > ssvm_check.sh remove the duplicate file from consoleproxy and include the
> > script from secondary storage folder while packing iso
> > 
> > Signed-off-by: Prasanna Santhanam 
> >

Thanks


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11874/#review21936
-----------


On June 14, 2013, 10:09 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11874/
> ---
> 
> (Updated June 14, 2013, 10:09 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> Issue: .There are two ssvm_check scripts(duplicates).
> 
> ./services/console-proxy/server/scripts/ssvm-check.sh
> ./services/secondary-storage/scripts/ssvm-check.sh
> 
> When building the code, these scripts will go to systemvm.zip, systemvm.zip 
> will be packaged into systemvm.iso. 
> 
> systemvm-descriptor.xml will define what all the scripts should package.
> As per the descriptor xml,  the ssvm-check script under console-proxy is 
> getting into systemvm.zip.
> 
> I had verified the ssvm-check script with the fix under console-proxy. The 
> systemvm.zip is getting update properly and making into systemvm.iso.
> And ssvm is getting the right script now.
> 
> Changes made in script under 
> ./services/secondary-storage/scripts/ssvm-check.sh is not getting into 
> systemvm.iso
> 
> Fixed:
> Modified systemvm-descriptor.xml to pick the ssvm-check.sh form 
> ./services/secondary-storage/scripts/ssvm-check.sh
> removed the duplicate file which is creating confusion 
> (./services/console-proxy/server/scripts/ssvm-check.sh)
> 
> 
> This addresses bug CLOUDSTACK-3004.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/scripts/ssvm-check.sh 7b83c98 
>   services/console-proxy/server/systemvm-descriptor.xml e34026b 
> 
> Diff: https://reviews.apache.org/r/11874/diff/
> 
> 
> Testing
> ---
> 
> Tested by generating the systemvm.zip , the ssvm-check file is getting copied 
> into the zip from the ./services/secondary-storage/scripts/ssvm-check.sh
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

RE: [ANNOUNCE] New committer: Jayapal Reddy Uradi

[Rajesh Battala]

Hearty Congratulations Jayapal Reddy :) 

> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Monday, June 17, 2013 9:00 PM
> To: dev@cloudstack.apache.org
> Subject: [ANNOUNCE] New committer: Jayapal Reddy Uradi
> 
> The Project Management Committee (PMC) for Apache CloudStack has asked
> Jayapal Reddy Uradi to become a committer and we are pleased to
> announce that they have accepted.
> 
> Being a committer allows many contributors to contribute more
> autonomously. For developers, it makes it easier to submit changes and
> eliminates the need to have contributions reviewed via the patch
> submission process. Whether contributions are development-related or
> otherwise, it is a recognition of a contributor's participation in the project
> and commitment to the project and the Apache Way.
> 
> Please join me in congratulating Jayapal!
> 
> -chip
> on behalf of the CloudStack PMC

Review Request: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/
---

Review request for cloudstack, Sateesh Chodapuneedi, edison su, Alex Huang, and 
Ram Ganesh.


Description
---

Issue : NPE's are happening when ZWPS is put in maintenance, removed from 
maintenance.

Fixed:
1. Added ZONE scope storage handling in StorageManagerImpl and 
StoragePoolAutomationImpl 
2. Modified PrimaryDataStoreDao, listBy method to take poolid to Wrapper class 
of long instead of primitive. Modified associated DaoImpl.
3. StoragePoolAutomationImpl, when storage is setting to Maintenance mode, 
handled the case for ZONE wide scope of storage. 
   if the storage is zone wide, get all the hosts(kvm, vmware) in zone and send 
the ModifyStoragePool command (with false)
4. When users, cancels maintenance mode, the handled the ZONE wide scope of 
storage pool.
5. Once the Storage is in maintenance, Deletion of the Storage will remove the 
mount points from all the hosts.

This patch will solve all the issues pertaining to keeping/cancelling the ZONE 
wide primary storage.


This addresses bug CLOUDSTACK-2571.


Diffs
-

  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
 d436762 
  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
 d461d58 
  server/src/com/cloud/storage/StorageManagerImpl.java 20b435c 
  server/src/com/cloud/storage/StoragePoolAutomationImpl.java 9bba979 

Diff: https://reviews.apache.org/r/11992/diff/


Testing
---

Manual Testing
= 
1. Enable maintenance mode of Zone wide storage , There were no NPE's happening 
and successfully kept the storage in maintenance mode. Verified DB status.
2. Cancel maintenance mode of Zone wide storage, There were no NPE's happening 
and successfully kept the storage in UP state.
3. Enable maintenance mode of zone wide, once successful then Delete the 
storage, Storage got deleted successfuly. Verify the hosts,  Storage got 
unmounted and verified the DB status.
Addition Tests (As the common code path is modified):
1. Add the Cluster scope of primary storage (kvm , xenserver). Adding the 
storage in both clusters is successful.
kvm specific:

2. Enable Maintenance Mode of cluster scope kvm storage. Successfully enabled 
the storage in maintenance state. 
3. Cancel the Maintenance Mode of cluster scope kvm storage. Successfully 
enabled the storage in UP state.
4. Enable Maintenance Mode of cluster scope kvm storage. Delete the storage. 
Storage got successfully deleted, unmounted from hosts and from db.

Xenserver specific:
===
5. Enable Maintenance Mode of cluster scope Xenserver storage. Successfully 
enabled the storage in maintenance state. 
6. Cancel the Maintenance Mode of cluster scope Xenserver storage. Successfully 
enabled the storage in UP state.
7. Enable Maintenance Mode of cluster scope Xenserver storage. Delete the 
storage. Storage got successfully deleted, unmounted from hosts and from db.

ZWPS is supported in KVM and VMware, the common code is modified. It should 
work of VMWare as well without any issues


Thanks,

Rajesh Battala

Re: Review Request: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/
---

(Updated June 20, 2013, 11:53 a.m.)


Review request for cloudstack, Sateesh Chodapuneedi, edison su, Alex Huang, and 
Ram Ganesh.


Description
---

Issue : NPE's are happening when ZWPS is put in maintenance, removed from 
maintenance.

Fixed:
1. Added ZONE scope storage handling in StorageManagerImpl and 
StoragePoolAutomationImpl 
2. Modified PrimaryDataStoreDao, listBy method to take poolid to Wrapper class 
of long instead of primitive. Modified associated DaoImpl.
3. StoragePoolAutomationImpl, when storage is setting to Maintenance mode, 
handled the case for ZONE wide scope of storage. 
   if the storage is zone wide, get all the hosts(kvm, vmware) in zone and send 
the ModifyStoragePool command (with false)
4. When users, cancels maintenance mode, the handled the ZONE wide scope of 
storage pool.
5. Once the Storage is in maintenance, Deletion of the Storage will remove the 
mount points from all the hosts.

This patch will solve all the issues pertaining to keeping/cancelling the ZONE 
wide primary storage.


This addresses bug CLOUDSTACK-2571.


Diffs
-

  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
 d436762 
  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
 d461d58 
  server/src/com/cloud/storage/StorageManagerImpl.java 20b435c 
  server/src/com/cloud/storage/StoragePoolAutomationImpl.java 9bba979 

Diff: https://reviews.apache.org/r/11992/diff/


Testing
---

Manual Testing
= 
1. Enable maintenance mode of Zone wide storage , There were no NPE's happening 
and successfully kept the storage in maintenance mode. Verified DB status.
2. Cancel maintenance mode of Zone wide storage, There were no NPE's happening 
and successfully kept the storage in UP state.
3. Enable maintenance mode of zone wide, once successful then Delete the 
storage, Storage got deleted successfuly. Verify the hosts,  Storage got 
unmounted and verified the DB status.
Addition Tests (As the common code path is modified):
1. Add the Cluster scope of primary storage (kvm , xenserver). Adding the 
storage in both clusters is successful.
kvm specific:

2. Enable Maintenance Mode of cluster scope kvm storage. Successfully enabled 
the storage in maintenance state. 
3. Cancel the Maintenance Mode of cluster scope kvm storage. Successfully 
enabled the storage in UP state.
4. Enable Maintenance Mode of cluster scope kvm storage. Delete the storage. 
Storage got successfully deleted, unmounted from hosts and from db.

Xenserver specific:
===
5. Enable Maintenance Mode of cluster scope Xenserver storage. Successfully 
enabled the storage in maintenance state. 
6. Cancel the Maintenance Mode of cluster scope Xenserver storage. Successfully 
enabled the storage in UP state.
7. Enable Maintenance Mode of cluster scope Xenserver storage. Delete the 
storage. Storage got successfully deleted, unmounted from hosts and from db.

ZWPS is supported in KVM and VMware, the common code is modified. It should 
work of VMWare as well without any issues


Thanks,

Rajesh Battala

Re: Review Request: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

[Rajesh Battala]

> On June 20, 2013, 12:20 p.m., daan Hoogland wrote:
> > there is a lot of code cleaning in with the functional change. I'd submit 
> > two changes. No blocking remarks, though.

Thanks Daan for the review and comments. 
this patch can be submit in two parts.


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/#review22162
---


On June 20, 2013, 11:53 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11992/
> ---
> 
> (Updated June 20, 2013, 11:53 a.m.)
> 
> 
> Review request for cloudstack, Sateesh Chodapuneedi, edison su, Alex Huang, 
> and Ram Ganesh.
> 
> 
> Description
> ---
> 
> Issue : NPE's are happening when ZWPS is put in maintenance, removed from 
> maintenance.
> 
> Fixed:
> 1. Added ZONE scope storage handling in StorageManagerImpl and 
> StoragePoolAutomationImpl 
> 2. Modified PrimaryDataStoreDao, listBy method to take poolid to Wrapper 
> class of long instead of primitive. Modified associated DaoImpl.
> 3. StoragePoolAutomationImpl, when storage is setting to Maintenance mode, 
> handled the case for ZONE wide scope of storage. 
>if the storage is zone wide, get all the hosts(kvm, vmware) in zone and 
> send the ModifyStoragePool command (with false)
> 4. When users, cancels maintenance mode, the handled the ZONE wide scope of 
> storage pool.
> 5. Once the Storage is in maintenance, Deletion of the Storage will remove 
> the mount points from all the hosts.
> 
> This patch will solve all the issues pertaining to keeping/cancelling the 
> ZONE wide primary storage.
> 
> 
> This addresses bug CLOUDSTACK-2571.
> 
> 
> Diffs
> -
> 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
>  d436762 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
>  d461d58 
>   server/src/com/cloud/storage/StorageManagerImpl.java 20b435c 
>   server/src/com/cloud/storage/StoragePoolAutomationImpl.java 9bba979 
> 
> Diff: https://reviews.apache.org/r/11992/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> = 
> 1. Enable maintenance mode of Zone wide storage , There were no NPE's 
> happening and successfully kept the storage in maintenance mode. Verified DB 
> status.
> 2. Cancel maintenance mode of Zone wide storage, There were no NPE's 
> happening and successfully kept the storage in UP state.
> 3. Enable maintenance mode of zone wide, once successful then Delete the 
> storage, Storage got deleted successfuly. Verify the hosts,  Storage got 
> unmounted and verified the DB status.
> Addition Tests (As the common code path is modified):
> 1. Add the Cluster scope of primary storage (kvm , xenserver). Adding the 
> storage in both clusters is successful.
> kvm specific:
> 
> 2. Enable Maintenance Mode of cluster scope kvm storage. Successfully enabled 
> the storage in maintenance state. 
> 3. Cancel the Maintenance Mode of cluster scope kvm storage. Successfully 
> enabled the storage in UP state.
> 4. Enable Maintenance Mode of cluster scope kvm storage. Delete the storage. 
> Storage got successfully deleted, unmounted from hosts and from db.
> 
> Xenserver specific:
> ===
> 5. Enable Maintenance Mode of cluster scope Xenserver storage. Successfully 
> enabled the storage in maintenance state. 
> 6. Cancel the Maintenance Mode of cluster scope Xenserver storage. 
> Successfully enabled the storage in UP state.
> 7. Enable Maintenance Mode of cluster scope Xenserver storage. Delete the 
> storage. Storage got successfully deleted, unmounted from hosts and from db.
> 
> ZWPS is supported in KVM and VMware, the common code is modified. It should 
> work of VMWare as well without any issues
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Unable to add kvm host on latest master

[Rajesh Battala]

Hi All,
Am not able to add the kvm host in mgmt. server.
I suspect something related to deserialization of json .

Below is the exception log am getting. :

462-3878-9dfe-376b05a1bdfe-LibvirtComputingResource","name":"kvm56","id":5,"version":"4.2.0-SNAPSHOT","resourceName":"LibvirtComputingResource","contextMap":{},"wait":0}}]
 given the type class [Lcom.cloud.agent.api.Command;
at 
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeserializerExceptionWrapper.java:64)
at 
com.google.gson.JsonDeserializationVisitor.invokeCustomDeserializer(JsonDeserializationVisitor.java:92)
at 
com.google.gson.JsonDeserializationVisitor.visitUsingCustomHandler(JsonDeserializationVisitor.java:80)
at com.google.gson.ObjectNavigator.accept(ObjectNavigator.java:101)
at 
com.google.gson.JsonDeserializationContextDefault.fromJsonArray(JsonDeserializationContextDefault.java:67)
at 
com.google.gson.JsonDeserializationContextDefault.deserialize(JsonDeserializationContextDefault.java:52)
at com.google.gson.Gson.fromJson(Gson.java:551)
at com.google.gson.Gson.fromJson(Gson.java:498)
at com.cloud.agent.transport.Request.getCommands(Request.java:235)
at 
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.processRequest(AgentManagerImpl.java:1193)
at 
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.doTask(AgentManagerImpl.java:1346)
at 
com.cloud.agent.manager.ClusteredAgentManagerImpl$ClusteredAgentHandler.doTask(ClusteredAgentManagerImpl.java:659)
at com.cloud.utils.nio.Task.run(Task.java:83)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:722)
Caused by: com.cloud.utils.exception.CloudRuntimeException: can't find 
StartupRoutingCommand
at 
com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor.java:77)
at 
com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor.java:37)
at 
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeserializerExceptionWrapper.java:51)
... 15 more
2013-06-21 17:43:33,697 WARN  [utils.nio.Task] (AgentManager-Handler-12:null) 
Caught the following exception but pushing on
com.google.gson.JsonParseException: The JsonDeserializer 
com.cloud.agent.transport.ArrayTypeAdaptor@b71e3d failed to deserialize json 
object 
[{"StartupRoutingCommand":{"cpus":4,"speed":1799,"memory":16640241664,"dom0MinMemory":805306368,"poolSync":false,"vms":{},"caps":"hvm,snapshot","pool":"/root","hypervisorType":"KVM","hostDetails":{"com.cloud.network.Networks.RouterPrivateIpStrategy":"HostLocal","Host.OS":"Red","Host.OS.Kernel.Version":"2.6.32-279.el6.x86_64","Host.OS.Version":"Enterprise"},"type":"Routing","dataCenter":"1","pod":"1","cluster":"2","guid":"eb98ae45-6462-3878-9dfe-376b05a1bdfe-LibvirtComputingResource","name":"kvm56","id":5,"version":"4.2.0-SNAPSHOT","publicIpAddress":"10.102.192.56","publicNetmask":"255.255.252.0","publicMacAddress":"d4:ae:52:ad:fc:a5","privateIpAddress":"10.102.192.56","privateMacAddress":"d4:ae:52:ad:fc:a5","privateNetmask":"255.255.252.0","storageIpAddress":"10.102.192.56","storageNetmask":"255.255.252.0","storageMacAddress":"d4:ae:52:ad:fc:a5","resourceName":"LibvirtComputingResource","gatewayIpAddress":"10.102.192.1","contextMap":{},"wait":0}},{"StartupStorageCommand":{"totalSize":0,"poolInfo":{"uuid":"41edfd96-c5a5-429a-b192-06a41c2709cc","host":"10.102.192.56","localPath":"/var/lib/libvirt/images","hostPath":"/var/lib/libvirt/images","poolType":"Filesystem","capacityBytes":52844687360,"availableBytes":50144874496},"resourceType":"STORAGE_POOL","hostDetails":{},"type":"Storage","dataCenter":"1","pod":"1","guid":"eb98ae45-6462-3878-9dfe-376b05a1bdfe-LibvirtComputingResource","name":"kvm56","id":5,"version":"4.2.0-SNAPSHOT","resourceName":"LibvirtComputingResource","contextMap":{},"wait":0}}]
 given the type class [Lcom.cloud.agent.api.Command;
at 
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeserializerExceptionWrapper.java:64)
at 
com.google.gson.JsonDeserializationVisitor.invokeCustomDeserializer(JsonDeserializationVisitor.java:92)
at 
com.google.gson.JsonDeserializationVisitor.visitUsingCustomHandler(JsonDeserializationVisitor.java:80)
at com.google.gson.ObjectNavigator.accept(ObjectNavigator.java:101)
at 
com.google.gson.JsonDeserializationContextDefault.fromJsonArray(JsonDeserializationContextDefault.java:67)
at 
com.google.gson.JsonDeserializationContextDefault.deserialize(JsonDeserializationContextDefault.java:52)
at com.google.gson.Gson.fromJson(Gson.java:551)
at com.google.gson.Gson.fromJson(Gson.java:498)
at com.cloud.agent.transport.Request.getCommands(Request.java:235)
at 
com.cloud.agent.manager.AgentManag

Review Request: CLOUDSTACK-2304 [ZWPS]NPE while migrating volume from one zone wide primary to another

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12025/
---

Review request for cloudstack, Sateesh Chodapuneedi, edison su, Alex Huang, and 
Ram Ganesh.


Description
---

Issue : while migrating the volume from one ZWPS to another ZWPS then NPE is 
having which is failing the migration of volume
Fixed: The issue is, if the volume is in ZWPS then the volume object won't be 
having podid. 
   while volume migration, ZWPS specific volume cases are not handled.
Fixed the issues by adding a new constructor in VolumeVO and taken care 
in VolumeServiceImpl to handle ZWPS volume while migration.


This addresses bug CLOUDSTACK-2304.


Diffs
-

  engine/schema/src/com/cloud/storage/VolumeVO.java 02c09a2 
  
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
 1d36f93 

Diff: https://reviews.apache.org/r/12025/diff/


Testing
---

Setup:
Create a KVM cluster and add zwps to the primary storage. ZWPS got mounted on 
KVM. Created instances in KVM.
1. Create a Volume and attach the volume to the running VM. volume got 
successfully attached to the VM. 
2. Detach the Volume and then try to Migrate the Volume to another ZWPS added 
to the ZONE. volume got migrated successfully to another ZWPS.
   Observed Volume got copied to the new ZWPS and then the old volume is 
deleted.
   Verified db, the volume uuid got updated and necessary fields.

Addition Testing:
 
Created Xenserver cluster add cluster scope storage.
1. create a volume and attach the instance running in Xenserver. Success.
2. detach the volume and try to migrate the volume to another cluster scope 
storage. Volume got successfully migrate to another storage. 
   Observed Volume got copied to the new PS and then the old volume is deleted.
   Verified db, the volume uuid got updated and necessary fields.


Thanks,

Rajesh Battala

RE: Master broken on systemVM start

[Rajesh Battala]

I guess after object store merge there are changes with json library. The same 
json deserialization is happening with kvm agent.

> -Original Message-
> From: Nitin Mehta [mailto:nitin.me...@citrix.com]
> Sent: Tuesday, June 25, 2013 12:21 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Master broken on systemVM start
> 
> After object store merge did you guys built the systemvm to get the new
> systemvm iso ? I haven't tried it myself but contemplating that.
> 
> On 25/06/13 12:15 PM, "Pranav Saxena"  wrote:
> 
> >+1 , I am getting it too !
> >
> >-Original Message-
> >From: Sanjay Tripathi [mailto:sanjay.tripa...@citrix.com]
> >Sent: Tuesday, June 25, 2013 12:03 PM
> >To: dev@cloudstack.apache.org
> >Subject: RE: Master broken on systemVM start
> >
> >I am also getting this exception on latest master:
> >
> >WARN  [utils.nio.Task] (AgentManager-Handler-2:) Caught the following
> >exception but pushing on
> >com.google.gson.JsonParseException: The JsonDeserializer
> >com.cloud.agent.transport.ArrayTypeAdaptor@18e6ae2 failed to
> >deserialize json object
> >[{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCe
> nter"
> >:"1","pod":"1","guid":"s-3-VM-NfsSecondaryStorageResource","name":"s-3-
> VM"
> >,"version":"4.2.0-SNAPSHOT","iqn":"NoIqn","publicIpAddress":"10.102.196
> >.13
> >0","publicNetmask":"255.255.255.0","publicMacAddress":"06:a3:68:00:00:1
> >5",
> >"privateIpAddress":"10.102.192.91","privateMacAddress":"06:f5:18:00:00:02
> "
> >,"privateNetmask":"255.255.252.0","storageIpAddress":"10.102.192.91","s
> >tor
> >ageNetmask":"255.255.252.0","storageMacAddress":"06:f5:18:00:00:02","re
> >sou rceName":"NfsSecondaryStorageResource","contextMap":{},"wait":0}}]
> >given the type class [Lcom.cloud.agent.api.Command;
> > at
> >com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeseri
> >ali
> >zerExceptionWrapper.java:64)
> > at
> >com.google.gson.JsonDeserializationVisitor.invokeCustomDeserializer(Jso
> >nDe
> >serializationVisitor.java:92)
> > at
> >com.google.gson.JsonDeserializationVisitor.visitUsingCustomHandler(Json
> >Des
> >erializationVisitor.java:80)
> > at
> com.google.gson.ObjectNavigator.accept(ObjectNavigator.java:101)
> > at
> >com.google.gson.JsonDeserializationContextDefault.fromJsonArray(JsonDes
> >eri
> >alizationContextDefault.java:67)
> > at
> >com.google.gson.JsonDeserializationContextDefault.deserialize(JsonDeser
> >ial
> >izationContextDefault.java:52)
> > at com.google.gson.Gson.fromJson(Gson.java:551)
> > at com.google.gson.Gson.fromJson(Gson.java:498)
> > at
> com.cloud.agent.transport.Request.getCommands(Request.java:235)
> > at
> >com.cloud.agent.manager.AgentManagerImpl$AgentHandler.processReques
> t(Ag
> >ent
> >ManagerImpl.java:1193)
> > at
> >com.cloud.agent.manager.AgentManagerImpl$AgentHandler.doTask(Agent
> Manag
> >erI
> >mpl.java:1346)
> > at
> >com.cloud.agent.manager.ClusteredAgentManagerImpl$ClusteredAgentHan
> dler
> >.do
> >Task(ClusteredAgentManagerImpl.java:659)
> > at com.cloud.utils.nio.Task.run(Task.java:83)
> > at
> >java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.ja
> va:
> >1145)
> > at
> >java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.j
> >ava
> >:615)
> > at java.lang.Thread.run(Thread.java:722)
> >Caused by: com.cloud.utils.exception.CloudRuntimeException: can't find
> >StartupSecondaryStorageCommand
> > at
> >com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor
> >.ja
> >va:77)
> > at
> >com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor
> >.ja
> >va:37)
> > at
> >com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeseri
> >ali
> >zerExceptionWrapper.java:51)
> > ... 15 more
> >
> >--Sanjay
> >
> >> -Original Message-
> >> From: Prasanna Santhanam [mailto:t...@apache.org]
> >> Sent: Saturday, June 22, 2013 10:49 PM
> >> To: CloudStack Dev
> >> Subject: Master broken on systemVM start
> >>
> >> Unable to bring up the systemVMs on latest master. There is very
> >> little detail in the logs: posted CLOUDSTACK-3137
> >>
> >> Can someone please take a look? The regression tests running on the
> >> weekend were blocked because of this.
> >>
> >> --
> >> Prasanna.,
> >>
> >> 
> >> Powered by BigRock.com
> >

RE: Master broken on systemVM start

[Rajesh Battala]

Am facing the same issue while adding the kvm host. 

"localPath":"/var/lib/libvirt/images","hostPath":"/var/lib/libvirt/images","poolType":"Filesystem","capacityBytes":52844687360,"availableBytes":49413353472},"resourceType":"STORAGE_POOL","hostDetails":{},"type":"Storage","dataCenter":"1","pod":"1","guid":"eb98ae45-6462-3878-9dfe-376b05a1bdfe-LibvirtComputingResource","name":"kvm56","version":"4.2.0-SNAPSHOT","resourceName":"LibvirtComputingResource","contextMap":{},"wait":0}}]
 given the type class [Lcom.cloud.agent.api.Command;
at 
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeserializerExceptionWrapper.java:64)
at 
com.google.gson.JsonDeserializationVisitor.invokeCustomDeserializer(JsonDeserializationVisitor.java:92)
at 
com.google.gson.JsonDeserializationVisitor.visitUsingCustomHandler(JsonDeserializationVisitor.java:80)
at com.google.gson.ObjectNavigator.accept(ObjectNavigator.java:101)
at 
com.google.gson.JsonDeserializationContextDefault.fromJsonArray(JsonDeserializationContextDefault.java:67)
at 
com.google.gson.JsonDeserializationContextDefault.deserialize(JsonDeserializationContextDefault.java:52)
at com.google.gson.Gson.fromJson(Gson.java:551)
at com.google.gson.Gson.fromJson(Gson.java:498)
at com.cloud.agent.transport.Request.getCommands(Request.java:235)
at 
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.processRequest(AgentManagerImpl.java:1221)
at 
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.doTask(AgentManagerImpl.java:1374)
at 
com.cloud.agent.manager.ClusteredAgentManagerImpl$ClusteredAgentHandler.doTask(ClusteredAgentManagerImpl.java:659)
at com.cloud.utils.nio.Task.run(Task.java:83)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:722)
Caused by: com.cloud.utils.exception.CloudRuntimeException: can't find 
com.cloud.agent.api.com.cloud.agent.api.StartupRoutingCommand
at 
com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor.java:79)
    at 
com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor.java:37)
at 
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeserializerExceptionWrapper.java:51)
... 15 more

> -Original Message-
> From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> Sent: Tuesday, June 25, 2013 12:24 PM
> To: dev@cloudstack.apache.org
> Subject: RE: Master broken on systemVM start
> 
> I guess after object store merge there are changes with json library. The
> same json deserialization is happening with kvm agent.
> 
> > -Original Message-
> > From: Nitin Mehta [mailto:nitin.me...@citrix.com]
> > Sent: Tuesday, June 25, 2013 12:21 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Master broken on systemVM start
> >
> > After object store merge did you guys built the systemvm to get the
> > new systemvm iso ? I haven't tried it myself but contemplating that.
> >
> > On 25/06/13 12:15 PM, "Pranav Saxena" 
> wrote:
> >
> > >+1 , I am getting it too !
> > >
> > >-Original Message-
> > >From: Sanjay Tripathi [mailto:sanjay.tripa...@citrix.com]
> > >Sent: Tuesday, June 25, 2013 12:03 PM
> > >To: dev@cloudstack.apache.org
> > >Subject: RE: Master broken on systemVM start
> > >
> > >I am also getting this exception on latest master:
> > >
> > >WARN  [utils.nio.Task] (AgentManager-Handler-2:) Caught the following
> > >exception but pushing on
> > >com.google.gson.JsonParseException: The JsonDeserializer
> > >com.cloud.agent.transport.ArrayTypeAdaptor@18e6ae2 failed to
> > >deserialize json object
> >
> >[{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCe
> > nter"
> > >:"1","pod":"1","guid":"s-3-VM-NfsSecondaryStorageResource","name":"s-
> > >3-
> > VM"
> > >,"version":"4.2.0-SNAPSHOT","iqn":"NoIqn","publicIpAddress":"10.102.1
> > >96
> > >.13
> > >0","publicNetmask":"255.255.255.0","publicMacAddress":"06:a3:68:00:00
> > >:1
> 

Re: Review Request 12025: CLOUDSTACK-2304 [ZWPS]NPE while migrating volume from one zone wide primary to another

[Rajesh Battala]

> On June 21, 2013, 9:18 p.m., edison su wrote:
> > engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java,
> >  line 537
> > <https://reviews.apache.org/r/12025/diff/1/?file=310007#file310007line537>
> >
> > Again, if pool.getPodId() == null, then 
> > newVol.setPodId(pool.getPodId()) will work.

Fix provided when NPE is in VolumeVO after object store merge, NPE is 
generating from different path.

have to do re-work and will submit the patch


2013-06-27 14:24:51,007 DEBUG [agent.transport.Request] 
(Job-Executor-33:job-57) Seq 3-393160908: Received:  { Ans: , MgmtId: 
235715300172635, via: 3, Ver: v1, Flags: 110, { UnsupportedAnswer } }
2013-06-27 14:24:51,008 WARN  [agent.manager.AgentManagerImpl] 
(Job-Executor-33:job-57) Unsupported Command: Unsupported command 
issued:org.apache.cloudstack.storage.command.CopyCommand.  Are you sure you got 
the right type of server?
2013-06-27 14:24:51,009 DEBUG [storage.motion.AncientDataMotionStrategy] 
(Job-Executor-33:job-57) copy to image store failed: Unsupported command 
issued:org.apache.cloudstack.storage.command.CopyCommand.  Are you sure you got 
the right type of server?
2013-06-27 14:24:51,032 DEBUG [storage.motion.AncientDataMotionStrategy] 
(Job-Executor-33:job-57) copy failed
java.lang.NullPointerException
at 
org.apache.cloudstack.storage.volume.VolumeObject.getPath(VolumeObject.java:324)
at 
org.apache.cloudstack.storage.to.VolumeObjectTO.(VolumeObjectTO.java:51)
at 
org.apache.cloudstack.storage.volume.VolumeObject.getTO(VolumeObject.java:446)
at 
org.apache.cloudstack.storage.image.BaseImageStoreDriverImpl.deleteAsync(BaseImageStoreDriverImpl.java:188)
at 
org.apache.cloudstack.storage.image.store.ImageStoreImpl.delete(ImageStoreImpl.java:148)
at 
org.apache.cloudstack.storage.motion.AncientDataMotionStrategy.copyVolumeBetweenPools(AncientDataMotionStrategy.java:281)
at 
org.apache.cloudstack.storage.motion.AncientDataMotionStrategy.copyAsync(AncientDataMotionStrategy.java:330)
at 
org.apache.cloudstack.storage.motion.DataMotionServiceImpl.copyAsync(DataMotionServiceImpl.java:57)
at 
org.apache.cloudstack.storage.volume.VolumeServiceImpl.copyVolume(VolumeServiceImpl.java:703)
at 
com.cloud.storage.VolumeManagerImpl.migrateVolume(VolumeManagerImpl.java:2109)
at 
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at 
com.cloud.storage.VolumeManagerImpl.migrateVolume(VolumeManagerImpl.java:2101)
at 
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at 
org.apache.cloudstack.api.command.user.volume.MigrateVolumeCmd.execute(MigrateVolumeCmd.java:102)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:155)
at 
com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:437)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:722)


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12025/#review22276
-------


On June 21, 2013, 12:32 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12025/
> ---
> 
> (Updated June 21, 2013, 12:32 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, edison su, Ram Ganesh, and Sateesh 
> Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-2304
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue : while migrating the volume from one ZWPS to another ZWPS then NPE is 
> having which is failing the migration of volume
> Fixed: The issue is, if the volume is in ZWPS then the volume object won't be 
> having podid. 
>while volume migration, ZWPS specific volume cases are not handled.
> Fixed the issues by adding a new constructor in VolumeVO and taken 
> care in VolumeServiceImpl to handle ZWPS volume while migration.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/storage/VolumeVO.java 02c09a2 
>   
> engine/storage/volume/src

Re: Review Request 11992: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/
---

(Updated June 27, 2013, 12:39 p.m.)


Review request for cloudstack, Alex Huang, edison su, Ram Ganesh, and Sateesh 
Chodapuneedi.


Changes
---

Modified the code in StoragePoolAutomationImpl

As one ZWPS is attached to only one type of Hypervisor, no need to collect all 
the hosts of different hypervisors while putting/cancelling maintenace.


Bugs: CLOUDSTACK-2571


Repository: cloudstack-git


Description
---

Issue : NPE's are happening when ZWPS is put in maintenance, removed from 
maintenance.

Fixed:
1. Added ZONE scope storage handling in StorageManagerImpl and 
StoragePoolAutomationImpl 
2. Modified PrimaryDataStoreDao, listBy method to take poolid to Wrapper class 
of long instead of primitive. Modified associated DaoImpl.
3. StoragePoolAutomationImpl, when storage is setting to Maintenance mode, 
handled the case for ZONE wide scope of storage. 
   if the storage is zone wide, get all the hosts(kvm, vmware) in zone and send 
the ModifyStoragePool command (with false)
4. When users, cancels maintenance mode, the handled the ZONE wide scope of 
storage pool.
5. Once the Storage is in maintenance, Deletion of the Storage will remove the 
mount points from all the hosts.

This patch will solve all the issues pertaining to keeping/cancelling the ZONE 
wide primary storage.


Diffs (updated)
-

  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
 99b7b9c 
  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
 8f7826f 
  server/src/com/cloud/storage/StorageManagerImpl.java b3e8b96 
  server/src/com/cloud/storage/StoragePoolAutomationImpl.java 4001775 

Diff: https://reviews.apache.org/r/11992/diff/


Testing
---

Manual Testing
= 
1. Enable maintenance mode of Zone wide storage , There were no NPE's happening 
and successfully kept the storage in maintenance mode. Verified DB status.
2. Cancel maintenance mode of Zone wide storage, There were no NPE's happening 
and successfully kept the storage in UP state.
3. Enable maintenance mode of zone wide, once successful then Delete the 
storage, Storage got deleted successfuly. Verify the hosts,  Storage got 
unmounted and verified the DB status.
Addition Tests (As the common code path is modified):
1. Add the Cluster scope of primary storage (kvm , xenserver). Adding the 
storage in both clusters is successful.
kvm specific:

2. Enable Maintenance Mode of cluster scope kvm storage. Successfully enabled 
the storage in maintenance state. 
3. Cancel the Maintenance Mode of cluster scope kvm storage. Successfully 
enabled the storage in UP state.
4. Enable Maintenance Mode of cluster scope kvm storage. Delete the storage. 
Storage got successfully deleted, unmounted from hosts and from db.

Xenserver specific:
===
5. Enable Maintenance Mode of cluster scope Xenserver storage. Successfully 
enabled the storage in maintenance state. 
6. Cancel the Maintenance Mode of cluster scope Xenserver storage. Successfully 
enabled the storage in UP state.
7. Enable Maintenance Mode of cluster scope Xenserver storage. Delete the 
storage. Storage got successfully deleted, unmounted from hosts and from db.

ZWPS is supported in KVM and VMware, the common code is modified. It should 
work of VMWare as well without any issues


Thanks,

Rajesh Battala

Re: Review Request 11992: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

[Rajesh Battala]

> On June 27, 2013, 6:05 p.m., edison su wrote:
> > server/src/com/cloud/storage/StoragePoolAutomationImpl.java, line 355
> > <https://reviews.apache.org/r/11992/diff/2/?file=312675#file312675line355>
> >
> > What am trying to say is to move the following codee to 
> > storagepoolautomationimpl:
> > 
> > List spes = 
> > _storagePoolDao.listBy(primaryStorage.getDataCenterId(), 
> > primaryStorage.getPodId(), primaryStorage.getClusterId(),
> > ScopeType.CLUSTER);
> > for (StoragePoolVO sp : spes) {
> > if (sp.getStatus() == 
> > StoragePoolStatus.PrepareForMaintenance) {
> > throw new CloudRuntimeException("Only one storage pool 
> > in a cluster can be in PrepareForMaintenance mode, " + sp.getId()
> > + " is already in  PrepareForMaintenance mode 
> > ");
> > }
> > }
> > 
> >

moved the code to StoreagePoolAutomationImpl in the latest patch


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/#review22473
---


On June 27, 2013, 12:39 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11992/
> ---
> 
> (Updated June 27, 2013, 12:39 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, edison su, Ram Ganesh, and Sateesh 
> Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-2571
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue : NPE's are happening when ZWPS is put in maintenance, removed from 
> maintenance.
> 
> Fixed:
> 1. Added ZONE scope storage handling in StorageManagerImpl and 
> StoragePoolAutomationImpl 
> 2. Modified PrimaryDataStoreDao, listBy method to take poolid to Wrapper 
> class of long instead of primitive. Modified associated DaoImpl.
> 3. StoragePoolAutomationImpl, when storage is setting to Maintenance mode, 
> handled the case for ZONE wide scope of storage. 
>if the storage is zone wide, get all the hosts(kvm, vmware) in zone and 
> send the ModifyStoragePool command (with false)
> 4. When users, cancels maintenance mode, the handled the ZONE wide scope of 
> storage pool.
> 5. Once the Storage is in maintenance, Deletion of the Storage will remove 
> the mount points from all the hosts.
> 
> This patch will solve all the issues pertaining to keeping/cancelling the 
> ZONE wide primary storage.
> 
> 
> Diffs
> -
> 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
>  99b7b9c 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
>  8f7826f 
>   server/src/com/cloud/storage/StorageManagerImpl.java b3e8b96 
>   server/src/com/cloud/storage/StoragePoolAutomationImpl.java 4001775 
> 
> Diff: https://reviews.apache.org/r/11992/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> = 
> 1. Enable maintenance mode of Zone wide storage , There were no NPE's 
> happening and successfully kept the storage in maintenance mode. Verified DB 
> status.
> 2. Cancel maintenance mode of Zone wide storage, There were no NPE's 
> happening and successfully kept the storage in UP state.
> 3. Enable maintenance mode of zone wide, once successful then Delete the 
> storage, Storage got deleted successfuly. Verify the hosts,  Storage got 
> unmounted and verified the DB status.
> Addition Tests (As the common code path is modified):
> 1. Add the Cluster scope of primary storage (kvm , xenserver). Adding the 
> storage in both clusters is successful.
> kvm specific:
> 
> 2. Enable Maintenance Mode of cluster scope kvm storage. Successfully enabled 
> the storage in maintenance state. 
> 3. Cancel the Maintenance Mode of cluster scope kvm storage. Successfully 
> enabled the storage in UP state.
> 4. Enable Maintenance Mode of cluster scope kvm storage. Delete the storage. 
> Storage got successfully deleted, unmounted from hosts and from db.
> 
> Xenserver specific:
> ===
> 5. Enable Maintenance Mode of cluster scope Xenserver storage. Successfully 
> enabled the storage in maintenance state. 
> 6. Cancel the Maintenance Mode of cluster scope Xenserver storage. 
> Successfully enabled the storage in UP state.
> 7. Enable Maintenance Mode of cluster scope Xenserver storage. Delete the 
> storage. Storage got successfully deleted, unmounted from hosts and from db.
> 
> ZWPS is supported in KVM and VMware, the common code is modified. It should 
> work of VMWare as well without any issues
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request 11992: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/
---

(Updated June 28, 2013, 9:18 a.m.)


Review request for cloudstack, Alex Huang, edison su, Ram Ganesh, and Sateesh 
Chodapuneedi.


Changes
---

incorporated review comments.
This patch will resolve only issues with "Enable Maintenance" of ZWPS.
Regarding issues with cancelling maintenance, I had created one more review 
request.


Bugs: CLOUDSTACK-2571


Repository: cloudstack-git


Description
---

Issue : NPE's are happening when ZWPS is put in maintenance, removed from 
maintenance.

Fixed:
1. Added ZONE scope storage handling in StorageManagerImpl and 
StoragePoolAutomationImpl 
2. Modified PrimaryDataStoreDao, listBy method to take poolid to Wrapper class 
of long instead of primitive. Modified associated DaoImpl.
3. StoragePoolAutomationImpl, when storage is setting to Maintenance mode, 
handled the case for ZONE wide scope of storage. 
   if the storage is zone wide, get all the hosts(kvm, vmware) in zone and send 
the ModifyStoragePool command (with false)
4. When users, cancels maintenance mode, the handled the ZONE wide scope of 
storage pool.
5. Once the Storage is in maintenance, Deletion of the Storage will remove the 
mount points from all the hosts.

This patch will solve all the issues pertaining to keeping/cancelling the ZONE 
wide primary storage.


Diffs (updated)
-

  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
 99b7b9c 
  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
 8f7826f 
  server/src/com/cloud/storage/StorageManagerImpl.java b3e8b96 
  server/src/com/cloud/storage/StoragePoolAutomationImpl.java 4001775 

Diff: https://reviews.apache.org/r/11992/diff/


Testing
---

Manual Testing
= 
1. Enable maintenance mode of Zone wide storage , There were no NPE's happening 
and successfully kept the storage in maintenance mode. Verified DB status.
2. Cancel maintenance mode of Zone wide storage, There were no NPE's happening 
and successfully kept the storage in UP state.
3. Enable maintenance mode of zone wide, once successful then Delete the 
storage, Storage got deleted successfuly. Verify the hosts,  Storage got 
unmounted and verified the DB status.
Addition Tests (As the common code path is modified):
1. Add the Cluster scope of primary storage (kvm , xenserver). Adding the 
storage in both clusters is successful.
kvm specific:

2. Enable Maintenance Mode of cluster scope kvm storage. Successfully enabled 
the storage in maintenance state. 
3. Cancel the Maintenance Mode of cluster scope kvm storage. Successfully 
enabled the storage in UP state.
4. Enable Maintenance Mode of cluster scope kvm storage. Delete the storage. 
Storage got successfully deleted, unmounted from hosts and from db.

Xenserver specific:
===
5. Enable Maintenance Mode of cluster scope Xenserver storage. Successfully 
enabled the storage in maintenance state. 
6. Cancel the Maintenance Mode of cluster scope Xenserver storage. Successfully 
enabled the storage in UP state.
7. Enable Maintenance Mode of cluster scope Xenserver storage. Delete the 
storage. Storage got successfully deleted, unmounted from hosts and from db.

ZWPS is supported in KVM and VMware, the common code is modified. It should 
work of VMWare as well without any issues


Thanks,

Rajesh Battala

Re: Review Request 11992: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

[Rajesh Battala]

> On June 27, 2013, 6:05 p.m., edison su wrote:
> > server/src/com/cloud/storage/StoragePoolAutomationImpl.java, line 355
> > <https://reviews.apache.org/r/11992/diff/2/?file=312675#file312675line355>
> >
> > What am trying to say is to move the following codee to 
> > storagepoolautomationimpl:
> > 
> > List spes = 
> > _storagePoolDao.listBy(primaryStorage.getDataCenterId(), 
> > primaryStorage.getPodId(), primaryStorage.getClusterId(),
> > ScopeType.CLUSTER);
> > for (StoragePoolVO sp : spes) {
> > if (sp.getStatus() == 
> > StoragePoolStatus.PrepareForMaintenance) {
> > throw new CloudRuntimeException("Only one storage pool 
> > in a cluster can be in PrepareForMaintenance mode, " + sp.getId()
> >     + " is already in  PrepareForMaintenance mode 
> > ");
> > }
> > }
> > 
> >
> 
> Rajesh Battala wrote:
> moved the code to StoreagePoolAutomationImpl in the latest patch

Thank Edison for the review. I had incorporated the suggestions provided in the 
latest uploaded patch


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/#review22473
---


On June 28, 2013, 9:18 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11992/
> ---
> 
> (Updated June 28, 2013, 9:18 a.m.)
> 
> 
> Review request for cloudstack, Alex Huang, edison su, Ram Ganesh, and Sateesh 
> Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-2571
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue : NPE's are happening when ZWPS is put in maintenance, removed from 
> maintenance.
> 
> Fixed:
> 1. Added ZONE scope storage handling in StorageManagerImpl and 
> StoragePoolAutomationImpl 
> 2. Modified PrimaryDataStoreDao, listBy method to take poolid to Wrapper 
> class of long instead of primitive. Modified associated DaoImpl.
> 3. StoragePoolAutomationImpl, when storage is setting to Maintenance mode, 
> handled the case for ZONE wide scope of storage. 
>if the storage is zone wide, get all the hosts(kvm, vmware) in zone and 
> send the ModifyStoragePool command (with false)
> 4. When users, cancels maintenance mode, the handled the ZONE wide scope of 
> storage pool.
> 5. Once the Storage is in maintenance, Deletion of the Storage will remove 
> the mount points from all the hosts.
> 
> This patch will solve all the issues pertaining to keeping/cancelling the 
> ZONE wide primary storage.
> 
> 
> Diffs
> -
> 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
>  99b7b9c 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
>  8f7826f 
>   server/src/com/cloud/storage/StorageManagerImpl.java b3e8b96 
>   server/src/com/cloud/storage/StoragePoolAutomationImpl.java 4001775 
> 
> Diff: https://reviews.apache.org/r/11992/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> = 
> 1. Enable maintenance mode of Zone wide storage , There were no NPE's 
> happening and successfully kept the storage in maintenance mode. Verified DB 
> status.
> 2. Cancel maintenance mode of Zone wide storage, There were no NPE's 
> happening and successfully kept the storage in UP state.
> 3. Enable maintenance mode of zone wide, once successful then Delete the 
> storage, Storage got deleted successfuly. Verify the hosts,  Storage got 
> unmounted and verified the DB status.
> Addition Tests (As the common code path is modified):
> 1. Add the Cluster scope of primary storage (kvm , xenserver). Adding the 
> storage in both clusters is successful.
> kvm specific:
> 
> 2. Enable Maintenance Mode of cluster scope kvm storage. Successfully enabled 
> the storage in maintenance state. 
> 3. Cancel the Maintenance Mode of cluster scope kvm storage. Successfully 
> enabled the storage in UP state.
> 4. Enable Maintenance Mode of cluster scope kvm storage. Delete the storage. 
> Storage got successfully deleted, unmounted from hosts and from db.
> 
> Xenserver specific:
> ===
> 5. Enable Maintenance Mode of cluster scope Xenserver storage. Successfully 
> enabled the storage in maintenance state. 
> 6. Cancel the Maintenance Mode of cluster scope Xenserver storage. 
> Successfully enabled the storage in UP state.
> 7. Enable Maintenance Mode of cluster scope Xenserver storage. Delete the 
> storage. Storage got successfully deleted, unmounted from hosts and from db.
> 
> ZWPS is supported in KVM and VMware, the common code is modified. It should 
> work of VMWare as well without any issues
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Review Request 12158: CLOUDSTACK-3089-[ZWPS]-NPE-while-cancelling-the-Storage-Maintenance

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12158/
---

Review request for cloudstack and edison su.


Repository: cloudstack-git


Description
---

fixes the issues with ZWPS while cancelling maintenance state.


Diffs
-

  server/src/com/cloud/storage/StoragePoolAutomationImpl.java 4001775 

Diff: https://reviews.apache.org/r/12158/diff/


Testing
---

done the testing specified in https://reviews.apache.org/r/11992/


Thanks,

Rajesh Battala

bean exception while running cloudstack on Latest Master.

[Rajesh Battala]

Hi All,

Am on latest master, while launching the jetty server am hitting with below 
bean execption server is not getting loaded.
How to resolve this bean issue?
In nonComponent.xml I had modified 'CloudStackImageStoreProviderImpl to 
cloudStackImageStoreProviderImpl but still am facing this issue.


Exception in thread "Timer-2" 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'dataStoreProviderManager' defined in class path resource 
[nonossComponentContext.xml]: Cannot resolve reference to bean 
'CloudStackImageStoreProviderImpl' while setting bean property 'providers' with 
key [1]; nested exception is 
org.springframework.beans.factory.NoSuchBeanDefinitionException: No bean named 
'CloudStackImageStoreProviderImpl' is defined
at 
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveReference(BeanDefinitionValueResolver.java:328)
at 
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveValueIfNecessary(BeanDefinitionValueResolver.java:106)
at 
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveManagedList(BeanDefinitionValueResolver.java:353)
at 
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveValueIfNecessary(BeanDefinitionValueResolver.java:153)
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1360)
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1118)
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.configureBean(AbstractAutowireCapableBeanFactory.java:314)
at 
com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(ComponentContext.java:71)
at 
com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:50)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)
Caused by: org.springframework.beans.factory.NoSuchBeanDefinitionException: No 
bean named 'CloudStackImageStoreProviderImpl' is defined
at 
org.springframework.beans.factory.support.DefaultListableBeanFactory.getBeanDefinition(DefaultListableBeanFactory.java:553)
at 
org.springframework.beans.factory.support.AbstractBeanFactory.getMergedLocalBeanDefinition(AbstractBeanFactory.java:1095)
at 
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:277)
at 
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:193)
at 
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveReference(BeanDefinitionValueResolver.java:322)
... 10 more


Thanks
Rajesh Battala

RE: bean exception while running cloudstack on Latest Master.

[Rajesh Battala]

Thanks 

> -Original Message-
> From: Prasanna Santhanam [mailto:t...@apache.org]
> Sent: Monday, July 1, 2013 1:21 PM
> To: dev@cloudstack.apache.org
> Subject: Re: bean exception while running cloudstack on Latest Master.
> 
> Looking into it.
> 
> On Mon, Jul 01, 2013 at 07:25:22AM +, Rajesh Battala wrote:
> > Hi All,
> >
> > Am on latest master, while launching the jetty server am hitting with
> below bean execption server is not getting loaded.
> > How to resolve this bean issue?
> > In nonComponent.xml I had modified 'CloudStackImageStoreProviderImpl
> to cloudStackImageStoreProviderImpl but still am facing this issue.
> >
> >
> > Exception in thread "Timer-2"
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'dataStoreProviderManager' defined in class path resource
> [nonossComponentContext.xml]: Cannot resolve reference to bean
> 'CloudStackImageStoreProviderImpl' while setting bean property 'providers'
> with key [1]; nested exception is
> org.springframework.beans.factory.NoSuchBeanDefinitionException: No
> bean named 'CloudStackImageStoreProviderImpl' is defined
> > at
> org.springframework.beans.factory.support.BeanDefinitionValueResolver.res
> olveReference(BeanDefinitionValueResolver.java:328)
> > at
> org.springframework.beans.factory.support.BeanDefinitionValueResolver.res
> olveValueIfNecessary(BeanDefinitionValueResolver.java:106)
> > at
> org.springframework.beans.factory.support.BeanDefinitionValueResolver.res
> olveManagedList(BeanDefinitionValueResolver.java:353)
> > at
> org.springframework.beans.factory.support.BeanDefinitionValueResolver.res
> olveValueIfNecessary(BeanDefinitionValueResolver.java:153)
> > at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFa
> ctory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1360)
> > at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFa
> ctory.populateBean(AbstractAutowireCapableBeanFactory.java:1118)
> > at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFa
> ctory.configureBean(AbstractAutowireCapableBeanFactory.java:314)
> > at
> com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Co
> mponentContext.java:71)
> > at
> com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:50)
> > at java.util.TimerThread.mainLoop(Timer.java:555)
> > at java.util.TimerThread.run(Timer.java:505)
> > Caused by:
> org.springframework.beans.factory.NoSuchBeanDefinitionException: No
> bean named 'CloudStackImageStoreProviderImpl' is defined
> > at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.getB
> eanDefinition(DefaultListableBeanFactory.java:553)
> > at
> org.springframework.beans.factory.support.AbstractBeanFactory.getMergedL
> ocalBeanDefinition(AbstractBeanFactory.java:1095)
> > at
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(
> AbstractBeanFactory.java:277)
> > at
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(Ab
> stractBeanFactory.java:193)
> > at
> org.springframework.beans.factory.support.BeanDefinitionValueResolver.res
> olveReference(BeanDefinitionValueResolver.java:322)
> > ... 10 more
> >
> >
> > Thanks
> > Rajesh Battala
> 
> --
> Prasanna.,
> 
> 
> 
> Powered by BigRock.com

Re: Review Request 11992: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

[Rajesh Battala]

> On July 1, 2013, 5:18 p.m., edison su wrote:
> > Ship It!

Thanks Edison for the review and pushing to repo.


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/#review22613
---


On June 28, 2013, 9:18 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11992/
> ---
> 
> (Updated June 28, 2013, 9:18 a.m.)
> 
> 
> Review request for cloudstack, Alex Huang, edison su, Ram Ganesh, and Sateesh 
> Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-2571
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue : NPE's are happening when ZWPS is put in maintenance, removed from 
> maintenance.
> 
> Fixed:
> 1. Added ZONE scope storage handling in StorageManagerImpl and 
> StoragePoolAutomationImpl 
> 2. Modified PrimaryDataStoreDao, listBy method to take poolid to Wrapper 
> class of long instead of primitive. Modified associated DaoImpl.
> 3. StoragePoolAutomationImpl, when storage is setting to Maintenance mode, 
> handled the case for ZONE wide scope of storage. 
>if the storage is zone wide, get all the hosts(kvm, vmware) in zone and 
> send the ModifyStoragePool command (with false)
> 4. When users, cancels maintenance mode, the handled the ZONE wide scope of 
> storage pool.
> 5. Once the Storage is in maintenance, Deletion of the Storage will remove 
> the mount points from all the hosts.
> 
> This patch will solve all the issues pertaining to keeping/cancelling the 
> ZONE wide primary storage.
> 
> 
> Diffs
> -
> 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
>  99b7b9c 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
>  8f7826f 
>   server/src/com/cloud/storage/StorageManagerImpl.java b3e8b96 
>   server/src/com/cloud/storage/StoragePoolAutomationImpl.java 4001775 
> 
> Diff: https://reviews.apache.org/r/11992/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> = 
> 1. Enable maintenance mode of Zone wide storage , There were no NPE's 
> happening and successfully kept the storage in maintenance mode. Verified DB 
> status.
> 2. Cancel maintenance mode of Zone wide storage, There were no NPE's 
> happening and successfully kept the storage in UP state.
> 3. Enable maintenance mode of zone wide, once successful then Delete the 
> storage, Storage got deleted successfuly. Verify the hosts,  Storage got 
> unmounted and verified the DB status.
> Addition Tests (As the common code path is modified):
> 1. Add the Cluster scope of primary storage (kvm , xenserver). Adding the 
> storage in both clusters is successful.
> kvm specific:
> 
> 2. Enable Maintenance Mode of cluster scope kvm storage. Successfully enabled 
> the storage in maintenance state. 
> 3. Cancel the Maintenance Mode of cluster scope kvm storage. Successfully 
> enabled the storage in UP state.
> 4. Enable Maintenance Mode of cluster scope kvm storage. Delete the storage. 
> Storage got successfully deleted, unmounted from hosts and from db.
> 
> Xenserver specific:
> ===
> 5. Enable Maintenance Mode of cluster scope Xenserver storage. Successfully 
> enabled the storage in maintenance state. 
> 6. Cancel the Maintenance Mode of cluster scope Xenserver storage. 
> Successfully enabled the storage in UP state.
> 7. Enable Maintenance Mode of cluster scope Xenserver storage. Delete the 
> storage. Storage got successfully deleted, unmounted from hosts and from db.
> 
> ZWPS is supported in KVM and VMware, the common code is modified. It should 
> work of VMWare as well without any issues
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Review Request 12227: NPE wile deployVM in kvm due to capacityIops

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/
---

Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.


Bugs: 3301


Repository: cloudstack-git


Description
---

Issue: 
When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.

Fixed:
SolidFire storage had introduced iops, its setting capacityIops on the pool 
level. Only solidfire is setting and getting it which is causing NPE when 
checking this value for other type PS.
This fixed will resolve the issue for any storage provider which don't set 
capacityIops.


Diffs
-

  server/src/com/cloud/storage/StorageManagerImpl.java 8401b77 

Diff: https://reviews.apache.org/r/12227/diff/


Testing
---

1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.


Thanks,

Rajesh Battala

RE: Review Request 12227: NPE wile deployVM in kvm due to capacityIops

[Rajesh Battala]

The issue is that, this patch is dependent on the review 
https://reviews.apache.org/r/12158/ .
I had kept that dependency while creating the review request.
First this patch should be committed https://reviews.apache.org/r/12158/ and 
then the current patch.

Thanks
Rajesh Battala

From: Sateesh Chodapuneedi [mailto:nore...@reviews.apache.org] On Behalf Of 
Sateesh Chodapuneedi
Sent: Tuesday, July 2, 2013 8:49 PM
To: Ram Ganesh; Sateesh Chodapuneedi; Edison Su
Cc: Rajesh Battala; cloudstack
Subject: Re: Review Request 12227: NPE wile deployVM in kvm due to capacityIops

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/12227/




Rajesh,

Can you re-upload patch again.

Diff is showing following error.

-

Diff revision 1 (Latest)

Files Changed:

server/src/com/cloud/storage/StorageManagerImpl.java:Diff currently 
unavailable.




- Sateesh Chodapuneedi


On July 2nd, 2013, 6:48 a.m. UTC, Rajesh Battala wrote:
Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
By Rajesh Battala.

Updated July 2, 2013, 6:48 a.m.
Bugs: 3301
Repository: cloudstack-git
Description

Issue:

When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.



Fixed:

SolidFire storage had introduced iops, its setting capacityIops on the pool 
level. Only solidfire is setting and getting it which is causing NPE when 
checking this value for other type PS.

This fixed will resolve the issue for any storage provider which don't set 
capacityIops.


Testing

1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.

2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.


Diffs

  *   server/src/com/cloud/storage/StorageManagerImpl.java (8401b77)

View Diff<https://reviews.apache.org/r/12227/diff/>

RE: Review Request 12227: NPE wile deployVM in kvm due to capacityIops

[Rajesh Battala]

Hi Sateesh, 
For this patch https://reviews.apache.org/r/12158/ it is dependent on 
https://reviews.apache.org/r/11992/ . It is already committed by Edison in 4.2 
only.

Thanks
Rajesh Battala
> -Original Message-
> From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> Sent: Tuesday, July 2, 2013 8:55 PM
> To: Sateesh Chodapuneedi; Ram Ganesh; Edison Su
> Cc: cloudstack
> Subject: RE: Review Request 12227: NPE wile deployVM in kvm due to
> capacityIops
> 
> The issue is that, this patch is dependent on the review
> https://reviews.apache.org/r/12158/ .
> I had kept that dependency while creating the review request.
> First this patch should be committed https://reviews.apache.org/r/12158/
> and then the current patch.
> 
> Thanks
> Rajesh Battala
> 
> From: Sateesh Chodapuneedi [mailto:nore...@reviews.apache.org] On
> Behalf Of Sateesh Chodapuneedi
> Sent: Tuesday, July 2, 2013 8:49 PM
> To: Ram Ganesh; Sateesh Chodapuneedi; Edison Su
> Cc: Rajesh Battala; cloudstack
> Subject: Re: Review Request 12227: NPE wile deployVM in kvm due to
> capacityIops
> 
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> 
> 
> 
> 
> Rajesh,
> 
> Can you re-upload patch again.
> 
> Diff is showing following error.
> 
> -
> 
> Diff revision 1 (Latest)
> 
> Files Changed:
> 
> server/src/com/cloud/storage/StorageManagerImpl.java:Diff currently
> unavailable.
> 
> 
> 
> 
> - Sateesh Chodapuneedi
> 
> 
> On July 2nd, 2013, 6:48 a.m. UTC, Rajesh Battala wrote:
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh
> Chodapuneedi.
> By Rajesh Battala.
> 
> Updated July 2, 2013, 6:48 a.m.
> Bugs: 3301
> Repository: cloudstack-git
> Description
> 
> Issue:
> 
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
> 
> 
> 
> Fixed:
> 
> SolidFire storage had introduced iops, its setting capacityIops on the pool
> level. Only solidfire is setting and getting it which is causing NPE when
> checking this value for other type PS.
> 
> This fixed will resolve the issue for any storage provider which don't set
> capacityIops.
> 
> 
> Testing
> 
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
> 
> 
> Diffs
> 
>   *   server/src/com/cloud/storage/StorageManagerImpl.java (8401b77)
> 
> View Diff<https://reviews.apache.org/r/12227/diff/>
> 

RE: Coding Convention Reminder

[Rajesh Battala]

+1. Please check-in the preferences file.

> -Original Message-
> From: Vijayendra Bhamidipati [mailto:vijayendra.bhamidip...@citrix.com]
> Sent: Wednesday, July 3, 2013 5:58 AM
> To: dev@cloudstack.apache.org
> Subject: RE: Coding Convention Reminder
> 
> +1 to checking in the epf file to source, will be good to have it as a 
> reference
> for those using other IDEs as well.
> 
> Regards,
> Vijay
> 
> -Original Message-
> From: Min Chen [mailto:min.c...@citrix.com]
> Sent: Tuesday, July 02, 2013 5:21 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Coding Convention Reminder
> 
> +1. It is better to check in your eclipse.eps into git repo, so anybody
> who checked out the CloudStack can access the preference file.
> 
> -min
> 
> On 7/2/13 5:17 PM, "Prachi Damle"  wrote:
> 
> >+ 1
> >Please upload the code template for reference.
> >
> >-Original Message-
> >From: Edison Su [mailto:edison...@citrix.com]
> >Sent: Tuesday, July 02, 2013 5:08 PM
> >To: dev@cloudstack.apache.org
> >Subject: RE: Coding Convention Reminder
> >
> >We'd better export the code template from Eclipse, then everybody can
> >import the template into their IDE, then possible, everybody will have
> >the same configuration.
> >
> >> -Original Message-
> >> From: Alex Huang [mailto:alex.hu...@citrix.com]
> >> Sent: Tuesday, July 02, 2013 3:11 PM
> >> To: dev@cloudstack.apache.org
> >> Subject: Coding Convention Reminder
> >>
> >> I like to remind everyone to review our coding conventions.  Our
> >>coding conventions have been going all over the place recently.
> >>Please take a look.
> >>
> >>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+convent
> >> i
> >> ons
> >>
> >> I also like to propose that we extend the 120 column limit to 180
> >>columns.
> >>
> >> I recently was reading the following code.  If it followed even our
> >> current coding conventions, this would have been 11 lines but it ends
> >> up to be 23 lines, more than doubled.  The whole file was like this.
> >> Just thinking about all the extra scrolling I have to do makes my cts
> >> act up.  We are in the 21st century and using wide screen lcd
> >> monitors.  Let's not format our code to fit
> >> 80 column amber text screens please!
> >>
> >> What's worse is I've found that some people are actively breaking
> >>existing source code to 80 columns, causing a bunch of unnecessary
> >>merge activities.
> >> On Eclipse, you can actually set all types of formatting rules.  I
> >>can  send out my epf (eclipse preferences file) if you don't want to
> >>deal with the trouble.
> >> DiskOfferingVO diskOffering =
> >>_diskOfferingDao
> >> .findById(vol.getDiskOfferingId());
> >> if (diskOffering.getUseLocalStorage()) {
> >> if (s_logger.isDebugEnabled()) {
> >> s_logger.debug("Local volume "
> >> + vol
> >> + " will be recreated on
> >>storage pool "
> >> + assignedPool
> >> + " assigned by
> >>deploymentPlanner");
> >> }
> >> VolumeTask task = new
> >>VolumeTask(VolumeTaskType.RECREATE, vol, null);
> >> tasks.add(task);
> >> } else {
> >> if (s_logger.isDebugEnabled()) {
> >> s_logger.debug("Shared volume "
> >> + vol
> >> + " will be migrated on
> >>storage pool "
> >> + assignedPool
> >> + " assigned by
> >>deploymentPlanner");
> >> }
> >> VolumeTask task = new
> >>VolumeTask(VolumeTaskType.MIGRATE, vol, assignedPool);
> >> tasks.add(task);
> >> }
> >>
> >> Please be mindful of my cts.  Thanks for caring about my health!  :)
> >>
> >> --Alex

Review Request 12265: CLOUDSTACK-2571-Zone-Wide-Primary-Storage-blocker-issues-while-Enabling-in-Maintenance-State

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12265/
---

Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.


Bugs: 2571


Repository: cloudstack-git


Description
---

rebased the patch to master-6-17-stable branch.


Diffs
-

  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
 d436762 
  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
 d461d58 
  server/src/com/cloud/storage/StorageManagerImpl.java 1b5fcc5 
  server/src/com/cloud/storage/StoragePoolAutomationImpl.java 9bba979 

Diff: https://reviews.apache.org/r/12265/diff/


Testing
---


Thanks,

Rajesh Battala

Review Request 12267: CLOUDSTACK-3089-[ZWPS]-NPE-while-cancelling-the-Storage-Maintenance

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12267/
---

Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.


Bugs: 3089


Repository: cloudstack-git


Description
---

rebased the patch to master-6-17-stable branch.


Diffs
-

  server/src/com/cloud/storage/StoragePoolAutomationImpl.java 9bba979 

Diff: https://reviews.apache.org/r/12267/diff/


Testing
---


Thanks,

Rajesh Battala

Re: Review Request 12227: NPE while deploying any instances in kvm/vmware using ZWPS due to capacityIops

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/
---

(Updated July 4, 2013, 12:32 p.m.)


Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.


Changes
---

uploaded the patch rebasing with 4.2 branch.


Summary (updated)
-

NPE while deploying any instances in kvm/vmware using ZWPS due to capacityIops


Bugs: 3301


Repository: cloudstack-git


Description
---

Issue: 
When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.

Fixed:
SolidFire storage had introduced iops, its setting capacityIops on the pool 
level. Only solidfire is setting and getting it which is causing NPE when 
checking this value for other type PS.
This fixed will resolve the issue for any storage provider which don't set 
capacityIops.


Diffs (updated)
-

  server/src/com/cloud/storage/StorageManagerImpl.java bb21afb 

Diff: https://reviews.apache.org/r/12227/diff/


Testing
---

1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.


Thanks,

Rajesh Battala

RE: Re:RE: Re:RE: Re:RE: Where are the snapshots generated by schedules?

[Rajesh Battala]

Hi Enric,
This issue is resolved in the 4.1 build with this commit. 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=913e2b38bfe5b29c0c172171e83d4fb7f8a8e6d6
Please use the latest build to resolve the snapshot issue.

Thanks
Rajesh Battala

> -Original Message-
> From: Enric Muñoz [mailto:emu...@intecom.ad]
> Sent: Friday, July 5, 2013 12:32 PM
> To: us...@cloudstack.apache.org
> Subject: RE: Re:RE: Re:RE: Re:RE: Where are the snapshots generated by
> schedules?
> 
> It happens to me the same using XCP 1.6. I set up recurring snapshots but
> they are not created and no error appears. However, there's  a warning in
> the logs every 5 minutes:
> 
> 2013-07-05 08:56:43,599 DEBUG [storage.snapshot.SnapshotSchedulerImpl]
> (SnapshotPollTask:null) Snapshot scheduler.poll is being called at 2013-07-05
> 06:56:43 GMT
> 2013-07-05 08:56:43,601 DEBUG [storage.snapshot.SnapshotSchedulerImpl]
> (SnapshotPollTask:null) Got 1 snapshots to be executed at 2013-07-05
> 06:56:43 GMT
> 2013-07-05 08:56:43,604 DEBUG [storage.snapshot.SnapshotSchedulerImpl]
> (SnapshotPollTask:null) Scheduling 1 snapshot for volume 20 for schedule id:
> 4 at 2013-07-02 12$
> 2013-07-05 08:56:43,613 WARN  [storage.snapshot.SnapshotSchedulerImpl]
> (SnapshotPollTask:null) Scheduling snapshot failed due to
> java.lang.NullPointerException
> 
> Anyone knows how this can be solved?
> 
> Thanks
> 
> -Mensaje original-
> De: WXR [mailto:1485739...@qq.com]
> Enviado el: martes, 02 de julio de 2013 17:38
> Para: users
> Asunto: Re:RE: Re:RE: Re:RE: Where are the snapshots generated by
> schedules?
> 
> I think the schedule job is created successfully.I can see the text like this:
> 
> 
> 
> 
> Scheduled Snapshots
>Time: 
> 1 min past the hr
>      Timezone:
> [UTC-12:00] GMT-12:00 Keep: 3
> 
> 
> 
> 
> -- Original --
> From:  "Rajesh Battala";
> Date:  Tue, Jul 2, 2013 11:15 PM
> To:  "us...@cloudstack.apache.org";
> 
> Subject:  RE: Re:RE: Re:RE: Where are the snapshots generated by schedules?
> 
> 
> 
> NPE issue for recurring snapshot is fixed long back. This should not occur.
> Schedule snapshots works the same way we take manually snapshots.
> For schedule snapshot, CS will create the createsnapshot async job while the
> schedule occurs to take the snapshot for the volume.
> Is the schedule snapshot job is created successfully?
> 
> 
> > -Original Message-
> > From: WXR [mailto:1485739...@qq.com]
> > Sent: Tuesday, July 2, 2013 8:34 PM
> > To: users
> > Subject: Re:RE: Re:RE: Where are the snapshots generated by schedules?
> >
> > Yes I'm using kvm,but I'm using basic network,not advanced network.
> > The jira link give a solution but I don't know how to do it,I'm not
> > familiar with java and git.
> > What can I do to fix the bug,should I rebuild the project?
> >
> >
> > -- Original --
> > From:  "Geoff Higginbottom";
> > Date:  Tue, Jul 2, 2013 10:38 PM
> > To:  "us...@cloudstack.apache.org";
> >
> > Subject:  RE: Re:RE: Where are the snapshots generated by schedules?
> >
> >
> >
> > Are you using KVM by any chance, there is currently a ticket logged in
> > relation to Scheduled Snapshots failing on KVM.
> >
> > If so take a look at
> > https://issues.apache.org/jira/browse/CLOUDSTACK-1353
> > and see if it mirrors your symptoms
> >
> > Regards
> >
> > Geoff Higginbottom
> >
> > D: +44 20 3603 0542 | S: +44 20 3603 0540 | M: +447968161581
> >
> > geoff.higginbot...@shapeblue.com
> >
> >
> > -Original Message-
> > From: WXR [mailto:1485739...@qq.com]
> > Sent: 02 July 2013 15:36
> > To: users
> > Subject: Re:RE: Where are the snapshots generated by schedules?
> >
> > I'm sure I have added the schedule and I can see it at the bottom of
> > the schedule box.
> >
> >
> >
> >
> > -- Original --
> > From:  "Geoff Higginbottom";
> > Date:  Tue, Jul 2, 2013 10:27 PM
> > To:  "us...@cloudstack.apache.org";
> >
> > Subject:  RE: Where are the snapshots generated by schedules?
> >
> >
> >
> > When setting up the recurring snapshot, ensure that after entering the
> > times etc, you click the Add Button, then the Done Button.  Failing to
> > click the Add button will result

RE: master not perfect:(

[Rajesh Battala]

Hi Daan,
Please build the systemvm.iso and remove the tags on xenserver host which will 
copy the new generated systemvm.iso. 
Newly built systemvm.iso will resolve this issue.

Thanks
Rajesh Battala


> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: Friday, July 5, 2013 2:56 PM
> To: dev@cloudstack.apache.org
> Subject: master not perfect:(
> 
> H,
> 
> I get a repetition of the following sequence of logging when running master.
> Anybody knows what happened?
> 
> INFO  [agent.manager.AgentManagerImpl] (AgentManager-Handler-11:)
> Connection from /127.0.0.1 closed but no cleanup was done.
> WARN  [utils.nio.Link] (AgentManager-Selector:) SSL: Fail to find the
> generated keystore. Loading fail-safe one to continue.
> ERROR [agent.transport.Request] (AgentManager-Handler-13:) Caught
> problem with
> [{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCen
> ter":"1","pod":"1","guid":"s-1-VM-NfsSecondaryStorageResource","name":"s-
> 1-VM","version":"4.2.0-
> SNAPSHOT","iqn":"NoIqn","publicIpAddress":"195.66.90.212","publicNetmask
> ":"255.255.255.224","publicMacAddress":"06:fb:ca:00:00:01","privateIpAddres
> s":"10.200.23.62","privateMacAddress":"06:ad:58:00:00:08","privateNetmask"
> :"255.255.255.0","storageIpAddress":"10.200.23.62","storageNetmask":"255.2
> 55.255.0","storageMacAddress":"06:ad:58:00:00:08","resourceName":"NfsSec
> ondaryStorageResource","contextMap":{},"wait":0}}]
> com.google.gson.JsonParseException: The JsonDeserializer
> com.cloud.agent.transport.ArrayTypeAdaptor@7db106d failed to deserialize
> json object
> [{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCen
> ter":"1","pod":"1","guid":"s-1-VM-NfsSecondaryStorageResource","name":"s-
> 1-VM","version":"4.2.0-
> SNAPSHOT","iqn":"NoIqn","publicIpAddress":"195.66.90.212","publicNetmask
> ":"255.255.255.224","publicMacAddress":"06:fb:ca:00:00:01","privateIpAddres
> s":"10.200.23.62","privateMacAddress":"06:ad:58:00:00:08","privateNetmask"
> :"255.255.255.0","storageIpAddress":"10.200.23.62","storageNetmask":"255.2
> 55.255.0","storageMacAddress":"06:ad:58:00:00:08","resourceName":"NfsSec
> ondaryStorageResource","contextMap":{},"wait":0}}] given the type class
> [Lcom.cloud.agent.api.Command;
>at
> com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeseriali
> zerExceptionWrapper.java:64)
>at
> com.google.gson.JsonDeserializationVisitor.invokeCustomDeserializer(JsonDe
> serializationVisitor.java:92)
>at
> com.google.gson.JsonDeserializationVisitor.visitUsingCustomHandler(JsonDes
> erializationVisitor.java:80)
>at com.google.gson.ObjectNavigator.accept(ObjectNavigator.java:101)
>at
> com.google.gson.JsonDeserializationContextDefault.fromJsonArray(JsonDeser
> ializationContextDefault.java:67)
>at
> com.google.gson.JsonDeserializationContextDefault.deserialize(JsonDeseriali
> zationContextDefault.java:52)
>at com.google.gson.Gson.fromJson(Gson.java:551)
>at com.google.gson.Gson.fromJson(Gson.java:498)
>at com.cloud.agent.transport.Request.getCommands(Request.java:235)
>at
> com.cloud.agent.manager.AgentManagerImpl$AgentHandler.processRequest
> (AgentManagerImpl.java:1196)
>at
> com.cloud.agent.manager.AgentManagerImpl$AgentHandler.doTask(AgentM
> anagerImpl.java:1349)
>at
> com.cloud.agent.manager.ClusteredAgentManagerImpl$ClusteredAgentHand
> ler.doTask(ClusteredAgentManagerImpl.java:659)
>at com.cloud.utils.nio.Task.run(Task.java:83)
>at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
>at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown
> Source)
>at java.lang.Thread.run(Unknown Source) Caused by:
> com.cloud.utils.exception.CloudRuntimeException: can't find
> StartupSecondaryStorageCommand
>at
> com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor.j
> ava:77)
>at
> com.cloud.agent.transpo

RE: master not perfect:(

[Rajesh Battala]

After the new systemvm.iso is generated and tags/systemvm.iso are removed on 
xenserver host , when mgmt. server starts, it will copy the new systemvm.iso to 
the Host.
Then the issue will be resolved. 

> -Original Message-
> From: Likitha Shetty [mailto:likitha.she...@citrix.com]
> Sent: Friday, July 5, 2013 3:38 PM
> To: dev@cloudstack.apache.org
> Subject: RE: master not perfect:(
> 
> In my case the discussed steps didn't resolve the issue (removing all the tags
> from the host , cleaning up systemvm.iso from the codebase , ensuring the
> systemvm profile is enabled during maven build and also ensuring the host
> has the newly generated systemvm.iso).
> Only once I rebooted the host was the issue resolved.
> 
> Thanks,
> Likitha
> 
> >-Original Message-
> >From: Hugo Trippaers [mailto:htrippa...@schubergphilis.com]
> >Sent: Friday, July 05, 2013 3:23 PM
> >To: dev@cloudstack.apache.org
> >Subject: RE: master not perfect:(
> >
> >Hey guys,
> >
> >Did you use the latest systemvm.iso on the systemvm? This error might
> >occur when the classes on the secondary storage vm are out of sync with
> >the classes on the management server.
> >
> >If you are running from a maven build make sure that the systemvm
> >profile is enabled to generate the systemvm.iso and that the file is
> >properly uploaded/copied.
> >
> >Cheers,
> >
> >
> >Hugo
> >
> >> -Original Message-
> >> From: Abhinav Roy [mailto:abhinav@citrix.com]
> >> Sent: Friday, July 05, 2013 11:44 AM
> >> To: dev@cloudstack.apache.org
> >> Subject: RE: master not perfect:(
> >>
> >> I faced the same issue, then I logged on to the xenserver host and
> >> deleted the tags, restarted the MS but even after that i could see
> >> these errors. Finally I rebooted the Xen Host and after that the
> >> error was not seen. Filed a bug for the same,
> >> https://issues.apache.org/jira/browse/CLOUDSTACK-3377
> >>
> >> Thanks and regards,
> >> Abhinav
> >> -Original Message-
> >> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> >> Sent: Friday, July 05, 2013 2:56 PM
> >> To: dev@cloudstack.apache.org
> >> Subject: master not perfect:(
> >>
> >> H,
> >>
> >> I get a repetition of the following sequence of logging when running
> master.
> >> Anybody knows what happened?
> >>
> >> INFO  [agent.manager.AgentManagerImpl] (AgentManager-Handler-11:)
> >> Connection from /127.0.0.1 closed but no cleanup was done.
> >> WARN  [utils.nio.Link] (AgentManager-Selector:) SSL: Fail to find the
> >> generated keystore. Loading fail-safe one to continue.
> >> ERROR [agent.transport.Request] (AgentManager-Handler-13:) Caught
> >> problem with
> >>
> [{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCe
> >> nter":"1","pod":"1","guid":"s-1-VM-
> >> NfsSecondaryStorageResource","name":"s-1-VM","version":"4.2.0-
> >> SNAPSHOT","iqn":"NoIqn","publicIpAddress":"195.66.90.212","publicNetm
> >> a
> >> s
> >> k":"255.255.255.224","publicMacAddress":"06:fb:ca:00:00:01","privateI
> >> p
> >> Addr
> >> ess":"10.200.23.62","privateMacAddress":"06:ad:58:00:00:08","privateN
> >> e
> >> tma
> >> sk":"255.255.255.0","storageIpAddress":"10.200.23.62","storageNetmask"
> >> :"2
> >> 55.255.255.0","storageMacAddress":"06:ad:58:00:00:08","resourceName":"
> >> N fsSecondaryStorageResource","contextMap":{},"wait":0}}]
> >> com.google.gson.JsonParseException: The JsonDeserializer
> >> com.cloud.agent.transport.ArrayTypeAdaptor@7db106d failed to
> >> deserialize json object
> >>
> [{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCe
> >> nter":"1","pod":"1","guid":"s-1-VM-
> >> NfsSecondaryStorageResource","name":"s-1-VM","version":"4.2.0-
> >> SNAPSHOT","iqn":"NoIqn","publicIpAddress":"195.66.90.212","publicNetm
> >> a
> >> s
> >> k":"255.255.255.224","publicMacAddress":"06:fb:ca:00:00:01","privateI
> >> p
> >> Addr
> >> ess":"10.200.23.62","privateMacAddress":"06:ad:58:00:00:08","privateN
> >> e
> >> tma
> >> sk":"255.255.255.0","storageIpAddress":"10.200.23.62","storageNetmask"
> >> :"2
> >> 55.255.255.0","storageMacAddress":"06:ad:58:00:00:08","resourceName":"
> >> N fsSecondaryStorageResource","contextMap":{},"wait":0}}] given the
> >> type class [Lcom.cloud.agent.api.Command;
> >>at
> >> com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDese
> >> r
> >> ial
> >> izerExceptionWrapper.java:64)
> >>at
> >> com.google.gson.JsonDeserializationVisitor.invokeCustomDeserializer(J
> >> s
> >> onD
> >> eserializationVisitor.java:92)
> >>at
> >> com.google.gson.JsonDeserializationVisitor.visitUsingCustomHandler(Js
> >> o
> >> nDe
> >> serializationVisitor.java:80)
> >>at com.google.gson.ObjectNavigator.accept(ObjectNavigator.java:101)
> >>at
> >> com.google.gson.JsonDeserializationContextDefault.fromJsonArray(JsonD
> >> e
> >> s
> >> erializationContextDefault.java:67)
> >>at
> >> com.google.gson.JsonDeserializationContextDefault.deserialize(JsonDes
> >> e
> >> rial
> >> iza

Re: Review Request 12265: CLOUDSTACK-2571-Zone-Wide-Primary-Storage-blocker-issues-while-Enabling-in-Maintenance-State

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12265/
---

(Updated July 8, 2013, 11:06 a.m.)


Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.


Changes
---

Rebased with latest head


Bugs: 2571


Repository: cloudstack-git


Description
---

rebased the patch to master-6-17-stable branch.


Diffs (updated)
-

  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
 d436762 
  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
 d461d58 
  server/src/com/cloud/storage/StorageManagerImpl.java 1b5fcc5 
  server/src/com/cloud/storage/StoragePoolAutomationImpl.java 9bba979 

Diff: https://reviews.apache.org/r/12265/diff/


Testing
---


Thanks,

Rajesh Battala

Re: Review Request 12267: CLOUDSTACK-3089-[ZWPS]-NPE-while-cancelling-the-Storage-Maintenance

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12267/
---

(Updated July 8, 2013, 11:07 a.m.)


Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.


Changes
---

rebased with latest head


Bugs: 3089


Repository: cloudstack-git


Description
---

rebased the patch to master-6-17-stable branch.


Diffs (updated)
-

  server/src/com/cloud/storage/StorageManagerImpl.java 1b5fcc5 
  server/src/com/cloud/storage/StoragePoolAutomationImpl.java 9bba979 

Diff: https://reviews.apache.org/r/12267/diff/


Testing
---


Thanks,

Rajesh Battala

RE: Oracle VM is becoming one of the leaders on Magic Quadrant for x86 Virtualization

[Rajesh Battala]

CS supports 2.x OVM. Is there any great/good features added to ovm 3.x?


> -Original Message-
> From: Wido den Hollander [mailto:w...@widodh.nl]
> Sent: Monday, July 8, 2013 8:12 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Oracle VM is becoming one of the leaders on Magic Quadrant for
> x86 Virtualization
> 
> 
> 
> On 07/08/2013 03:14 PM, David Nalley wrote:
> > On Mon, Jul 8, 2013 at 8:33 AM, Alexandre Sousa
> >  wrote:
> >> Hi Guys,
> >>
> >> This is the last Gartner Report:
> >> http://www.gartner.com/technology/reprints.do?id=1-
> 1GJA88J&ct=130628&
> >> st=sb
> >>
> >> Oracle VM is getting better year after year, so I believe that this
> >> is a good reason to include support for Oracle VM 3.x on CloudStack.
> >>
> >> Cheers,
> >> Alexandre
> >
> >
> > We would welcome patches that add OVM 3.x support.
> >
> 
> My point exactly. If someone comes up with patches for OVM 3.x for
> CloudStack I'd happily accept them :)
> 
> Wido
> 
> > --David
> >

Re: Review Request 12267: CLOUDSTACK-3089-[ZWPS]-NPE-while-cancelling-the-Storage-Maintenance

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12267/
---

(Updated July 9, 2013, 6:04 a.m.)


Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.


Changes
---

rebased with latest head


Bugs: 3089


Repository: cloudstack-git


Description
---

rebased the patch to master-6-17-stable branch.


Diffs (updated)
-

  server/src/com/cloud/storage/StoragePoolAutomationImpl.java b656f30 

Diff: https://reviews.apache.org/r/12267/diff/


Testing
---


Thanks,

Rajesh Battala

Re: Review Request 12267: CLOUDSTACK-3089-[ZWPS]-NPE-while-cancelling-the-Storage-Maintenance

[Rajesh Battala]

> On July 9, 2013, 6:29 a.m., ASF Subversion and Git Services wrote:
> > Commit a54d2347fe8c798f4e3f658f683c548583d44485 in branch 
> > refs/heads/master-6-17-stable from Rajesh Battala
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a54d234 ]
> > 
> > CLOUDSTACK-3089 [ZWPS] NPE while cancelling the Storage Maintenance
> > 
> > Signed-off-by: Sateesh Chodapuneedi 
> >

Thanks Sateesh.


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12267/#review22887
-----------


On July 9, 2013, 6:04 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12267/
> ---
> 
> (Updated July 9, 2013, 6:04 a.m.)
> 
> 
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh 
> Chodapuneedi.
> 
> 
> Bugs: 3089
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> rebased the patch to master-6-17-stable branch.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/StoragePoolAutomationImpl.java b656f30 
> 
> Diff: https://reviews.apache.org/r/12267/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request 11858: CLOUDSTACK-2340 [AWS Style Health Checks] Response of the API listLoadBalancerRuleInstances should show the service state of a VM if health check is configured for it

[Rajesh Battala]

> On July 10, 2013, 7:28 a.m., Ram Ganesh wrote:
> > Ship It!

Thanks for the review.
I have to rebase with latest head and then post the patch again.


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11858/#review22950
---


On June 30, 2013, 6:08 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11858/
> ---
> 
> (Updated June 30, 2013, 6:08 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Murali Reddy, Ram Ganesh, 
> and Vijay Venkatachalam.
> 
> 
> Bugs: CLOUDSTACK-2340
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue: when healthcheck is created for LB rule then 
> listLoadBalancerRuleInstance api should have the service state populated by 
> LBHealthCheckManager. 
> Fixed: Fixed the response of listLoadBalancerRuleInstance  to include a 
> "servicestate":"UP" which tell the service state of the instance.
>if the healthcheck is not created on LB then api response then 
> "servicestate" field won't be in the response.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/lb/LoadBalancingRulesService.java 5fc41e3 
>   api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c 
>   
> api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRuleInstancesCmd.java
>  49ab42c 
>   api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a 
>   server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 67d31ab 
> 
> Diff: https://reviews.apache.org/r/11858/diff/
> 
> 
> Testing
> ---
> 
> 1. Created LB rule with healthcheck policy verified the 
> listLoadBalancerRuleInstance  api response, it has the field servicestate for 
> all the VM's assigned to the LB rule
> 2. Created LB rule without healthcheck policy, verified the 
> listLoadBalancerRuleInstance api response wont have the servicestate field 
> for all the VM's assigned to the LB rule
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request 11858: CLOUDSTACK-2340 [AWS Style Health Checks] Response of the API listLoadBalancerRuleInstances should show the service state of a VM if health check is configured for it

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11858/
---

(Updated July 10, 2013, 12:37 p.m.)


Review request for cloudstack, Alena Prokharchyk, Murali Reddy, Ram Ganesh, and 
Sateesh Chodapuneedi.


Changes
---

Rebased with latest head and tested the patch


Bugs: CLOUDSTACK-2340


Repository: cloudstack-git


Description
---

Issue: when healthcheck is created for LB rule then 
listLoadBalancerRuleInstance api should have the service state populated by 
LBHealthCheckManager. 
Fixed: Fixed the response of listLoadBalancerRuleInstance  to include a 
"servicestate":"UP" which tell the service state of the instance.
   if the healthcheck is not created on LB then api response then 
"servicestate" field won't be in the response.


Diffs (updated)
-

  api/src/com/cloud/network/lb/LoadBalancingRulesService.java 5fc41e3 
  api/src/org/apache/cloudstack/api/ApiConstants.java e2857b8 
  
api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRuleInstancesCmd.java
 49ab42c 
  api/src/org/apache/cloudstack/api/response/UserVmResponse.java 0df9413 
  server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 6e0d0d7 

Diff: https://reviews.apache.org/r/11858/diff/


Testing
---

1. Created LB rule with healthcheck policy verified the 
listLoadBalancerRuleInstance  api response, it has the field servicestate for 
all the VM's assigned to the LB rule
2. Created LB rule without healthcheck policy, verified the 
listLoadBalancerRuleInstance api response wont have the servicestate field for 
all the VM's assigned to the LB rule


Thanks,

Rajesh Battala

Re: Review Request 12445: Making sdn gre work with XCP 1.6

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12445/#review22959
---



plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
<https://reviews.apache.org/r/12445/#comment46745>

there are many white space/tabs in java and py files.

can you please post what kind of testing/test cases executed for this patch.


- Rajesh Battala


On July 10, 2013, 3:31 p.m., tuna wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12445/
> ---
> 
> (Updated July 10, 2013, 3:31 p.m.)
> 
> 
> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This patch makes sdn gre work with XCP 1.6. Users still can follow the old 
> strategy described in this post: 
> https://cwiki.apache.org/CLOUDSTACK/ovs-tunnel-manager-for-cloudstack.html. 
> 
> Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-1779
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  d6d0523 
>   scripts/vm/hypervisor/xenserver/ovstunnel ddcaa5b 
>   scripts/vm/hypervisor/xenserver/xcposs/patch 4d07c76 
>   scripts/vm/hypervisor/xenserver/xcpserver/patch 7e92d5a 
>   scripts/vm/hypervisor/xenserver/xenserver56/patch 8abd6b2 
>   scripts/vm/hypervisor/xenserver/xenserver56fp1/patch 901f6de 
> 
> Diff: https://reviews.apache.org/r/12445/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> tuna
> 
>

Re: Review Request 12227: NPE while deploying any instances in kvm/vmware using ZWPS due to capacityIops

[Rajesh Battala]

> On July 8, 2013, 7:16 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> > Fix looks good.

Thanks for the review comments


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22846
---


On July 4, 2013, 12:32 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> ---
> 
> (Updated July 4, 2013, 12:32 p.m.)
> 
> 
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh 
> Chodapuneedi.
> 
> 
> Bugs: 3301
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue: 
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
> 
> Fixed:
> SolidFire storage had introduced iops, its setting capacityIops on the pool 
> level. Only solidfire is setting and getting it which is causing NPE when 
> checking this value for other type PS.
> This fixed will resolve the issue for any storage provider which don't set 
> capacityIops.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/StorageManagerImpl.java bb21afb 
> 
> Diff: https://reviews.apache.org/r/12227/diff/
> 
> 
> Testing
> ---
> 
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request 12227: NPE while deploying any instances in kvm/vmware using ZWPS due to capacityIops

[Rajesh Battala]

> On July 10, 2013, 9:57 p.m., edison su wrote:
> > Ship It!

Thanks Edison for the review and pushing the patch


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22981
---


On July 4, 2013, 12:32 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> ---
> 
> (Updated July 4, 2013, 12:32 p.m.)
> 
> 
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh 
> Chodapuneedi.
> 
> 
> Bugs: 3301
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue: 
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
> 
> Fixed:
> SolidFire storage had introduced iops, its setting capacityIops on the pool 
> level. Only solidfire is setting and getting it which is causing NPE when 
> checking this value for other type PS.
> This fixed will resolve the issue for any storage provider which don't set 
> capacityIops.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/StorageManagerImpl.java bb21afb 
> 
> Diff: https://reviews.apache.org/r/12227/diff/
> 
> 
> Testing
> ---
> 
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

ip are not getting assigned to VM's created from accounts apart from admin

[Rajesh Battala]

Hi All,
Am on 4.2, when VM's are getting launched from admin account VM's are having 
IP's but when I had created accounts and tried to launch VM from the accounts, 
VM's are not getting ip.
I saw thread about VM's in VPC are not getting IP. But vm's created using 
isolated network are also not getting ip.

Any work around?

Thanks
Rajesh Battala

RE: ip are not getting assigned to VM's created from accounts apart from admin

[Rajesh Battala]

Rebasing to latest 4.2 head, this issue is resolved now. 
Am getting ip's for VM's created from accounts 

Thanks
Rajesh Battala

> -Original Message-
> From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> Sent: Monday, July 22, 2013 3:24 PM
> To: dev@cloudstack.apache.org
> Subject: ip are not getting assigned to VM's created from accounts apart
> from admin
> 
> Hi All,
> Am on 4.2, when VM's are getting launched from admin account VM's are
> having IP's but when I had created accounts and tried to launch VM from the
> accounts, VM's are not getting ip.
> I saw thread about VM's in VPC are not getting IP. But vm's created using
> isolated network are also not getting ip.
> 
> Any work around?
> 
> Thanks
> Rajesh Battala

Re: Review Request 12943: Replaced virsh() by python-libvirt functions

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12943/#review23848
---

Ship it!


Ship It!

- Rajesh Battala


On July 25, 2013, 2:01 p.m., Rene Diepstraten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12943/
> ---
> 
> (Updated July 25, 2013, 2:01 p.m.)
> 
> 
> Review request for cloudstack and Wido den Hollander.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> In scripts/vm/network/security_group.py, external calls to virsh are made.
> Python has a module python-libvirt which has native libvirt bindings.
> This patch replaces the external calls to the virsh command with functions 
> that use the native python implementation.
> 
> 
> Diffs
> -
> 
>   debian/control 46dd505 
>   packaging/centos63/cloud.spec 61e00bd 
>   scripts/vm/network/security_group.py 2ce558f 
> 
> Diff: https://reviews.apache.org/r/12943/diff/
> 
> 
> Testing
> ---
> 
> Tested the output of the new functions. This should be the same as the virsh 
> command.
> 
> 
> Thanks,
> 
> Rene Diepstraten
> 
>

RE: help submitting to review board.

[Rajesh Battala]

In the groups, use "cloudstack" 
This should be enough to create the request. 

Thanks
Rajesh Battala

> -Original Message-
> From: Thomas O'Dowd [mailto:tpod...@cloudian.com]
> Sent: Friday, July 26, 2013 2:34 PM
> To: Cloudstack DEV
> Subject: help submitting to review board.
> 
> I'm trying to submit my first patch to review board... however it says I need
> at least one reviewer or group. I can't seem to add anything under
> Reviewers. For Groups, what should I add? The patch is against the
> ConfigurationManager.
> 
> Thanks!
> 
> Tom.
> --
> Cloudian KK - http://www.cloudian.com/get-started.html
> Fancy 100TB of full featured S3 Storage?
> Checkout the Cloudian® Community Edition!

Re: Review Request 12963: Fix some simple typos in ConfigurationManager

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12963/#review23931
---

Ship it!


Ship It!

- Rajesh Battala


On July 26, 2013, 9:07 a.m., Thomas O'Dowd wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12963/
> ---
> 
> (Updated July 26, 2013, 9:07 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Simple text only fixes to update some typos I noticed in log messages when 
> testing 4.2.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 6c32c55 
> 
> Diff: https://reviews.apache.org/r/12963/diff/
> 
> 
> Testing
> ---
> 
> Although this patch is against master, I cherry picked it locally to test 
> against 4.2 and did a clean compile. I was able to see the updated message 
> for "in stead" but I didn't check the other messages.
> 
> 
> Thanks,
> 
> Thomas O'Dowd
> 
>

Re: Review Request 11858: CLOUDSTACK-2340 [AWS Style Health Checks] Response of the API listLoadBalancerRuleInstances should show the service state of a VM if health check is configured for it

[Rajesh Battala]

> On July 26, 2013, 11:31 a.m., Devdeep Singh wrote:
> > Changes had already been reviewed and comments incorporated. Applied the 
> > patch. Kindly close the request.

Thanks for pushing the patch


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11858/#review23943
---


On July 10, 2013, 12:37 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11858/
> ---
> 
> (Updated July 10, 2013, 12:37 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Murali Reddy, Ram Ganesh, 
> and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-2340
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue: when healthcheck is created for LB rule then 
> listLoadBalancerRuleInstance api should have the service state populated by 
> LBHealthCheckManager. 
> Fixed: Fixed the response of listLoadBalancerRuleInstance  to include a 
> "servicestate":"UP" which tell the service state of the instance.
>if the healthcheck is not created on LB then api response then 
> "servicestate" field won't be in the response.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/lb/LoadBalancingRulesService.java 5fc41e3 
>   api/src/org/apache/cloudstack/api/ApiConstants.java e2857b8 
>   
> api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRuleInstancesCmd.java
>  49ab42c 
>   api/src/org/apache/cloudstack/api/response/UserVmResponse.java 0df9413 
>   server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 6e0d0d7 
> 
> Diff: https://reviews.apache.org/r/11858/diff/
> 
> 
> Testing
> ---
> 
> 1. Created LB rule with healthcheck policy verified the 
> listLoadBalancerRuleInstance  api response, it has the field servicestate for 
> all the VM's assigned to the LB rule
> 2. Created LB rule without healthcheck policy, verified the 
> listLoadBalancerRuleInstance api response wont have the servicestate field 
> for all the VM's assigned to the LB rule
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Review Request 12994: CLOUDSTACK-3216 Logs in the Software router are not being rotated

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12994/
---

Review request for cloudstack, Alex Huang, Devdeep Singh, Ram Ganesh, and Hugo 
Trippaers.


Bugs: 3216


Repository: cloudstack-git


Description
---

Issue:
==
logrotate.conf and logrotate config files in logrotate.d folder are having "x" 
permission. 
hence logrotate daemon not able to use this config 
logrotate reports the error as 
/etc# /usr/sbin/logrotate -d -v /etc/logrotate.conf
reading config file /etc/logrotate.conf
including /etc/logrotate.d
Ignoring apache2 because of bad file mode.
reading config file apt
reading config file aptitude
reading config file conntrackd
Ignoring dnsmasq because of bad file mode.
reading config file dpkg
Ignoring haproxy because of bad file mode.
reading config file monit
Ignoring ppp because of bad file mode.
Ignoring rsyslog because of bad file mode.
==

Fix:
===
while generating the cloudscripts.tgz file, I had modified to include the 
logrotate.conf and logrotate config files under logrotate.d with 644 permission 
which will fix the issue. 
this is will fix the "bad file mode" error. 


Diffs
-

  patches/pom.xml 00eec02 

Diff: https://reviews.apache.org/r/12994/diff/


Testing
---

1. after generating new systemvm.iso tested the new router/ssvm/console proxy.

logrotate -d -v /etc/logrotate.conf
reading config file /etc/logrotate.conf
including /etc/logrotate.d
reading config file apache2
reading config file apt
reading config file aptitude
reading config file conntrackd
reading config file dnsmasq
reading config file dpkg
reading config file haproxy
reading config file monit
reading config file ppp
reading config file rsyslog


2. Verified after launching the VR, new instances are getting IP and hostname 
properly.


Thanks,

Rajesh Battala

Review Request 12996: Unable to Resize Volume (kvm, vmware)

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12996/
---

Review request for cloudstack, Devdeep Singh, edison su, Min Chen, and Ram 
Ganesh.


Bugs: 3877


Repository: cloudstack-git


Description
---

Issue:
=
this issue is with the way we extract the hypevisor type from the sql 


mysql> SELECT s.hypervisor, c.hypervisor_type from volumes v, storage_pool s, 
cluster c where v.pool_id = s.id and s.cluster_id = c.id and v.id = 21;
++-+
| hypervisor | hypervisor_type |
++-+
| NULL | KVM |
++-+


first column value will be not null if the storage pool is Zone wide else it 
will be NULL. 
but in the code always first column is considering to figure out the hypervisor 
type which causing the hpervisor type to be NONE and hence failing to resize 
the volume


this issue is happening while determining the hypervisor type for a volume. 
for ZWPS, it will return the hypervisor because, in storage pool we store the 
hypervisor type if the pool is added of scoe ZONE. 
if the pool is of scope Cluster hypervisor type will be NULL

we support volume resize when the volume is present on ZONE scope and Cluster 
scope. 
they way of hypervisor type extraction from the sql query result should be 
change which will resolve this blocker.


Fix:
=

depending on the scope type of storage pool, the sql result is passed to 
determined the hypervisor type.


Diffs
-

  engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java 7696bcc 

Diff: https://reviews.apache.org/r/12996/diff/


Testing
---

1. Able to resize the volume successfully


Thanks,

Rajesh Battala

Review Request 12997: usage event is not generated for volume resize

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12997/
---

Review request for cloudstack, Devdeep Singh, Kishan Kavala, and Ram Ganesh.


Repository: cloudstack-git


Description
---

issue:

when resize volume is requested and action is successfuly usage event is not 
recorded. Code is not present for recording the resize volume usage event.

fix:
Added the code to record the usage event when the resize volume is requested.


Diffs
-

  server/src/com/cloud/storage/VolumeManagerImpl.java a3802a9 

Diff: https://reviews.apache.org/r/12997/diff/


Testing
---

Environment:
kvm, with cluster scope storage pool.
default centos instance.

1. created a volume and tried to resize the volume.
volume resize is successful

usage event is registered in usage_event table now.

  | 0 | NULL |
| 27 | VOLUME.RESIZE   |  2 | 2013-07-27 14:54:51 |   1 |   
   21 | TestVol  |   6 |NULL |  
5368709120 | NULL   | 0 | NULL |
++-++-+-+-+--+-+-+-++---+--+


Thanks,

Rajesh Battala

Request to inform which DB command to run on existing setup if any db schema changes

[Rajesh Battala]

Hi All,
Please share sql statements to be inserted in the dev list, if any db schema 
changes are committed and require deploy db on existing setup .
This will save lots of development time.
More time is getting consumed in clearing the entire setup and set it again.

Thanks
Rajesh Battala

RE: Request to inform which DB command to run on existing setup if any db schema changes

[Rajesh Battala]

That's a default solution. But the rate at which commits are making to repo 
it's not easy to figure out which commits are causing db changes.
Hope you had already faced this situation 

Thanks
Rajesh Battala


> -Original Message-
> From: Koushik Das [mailto:koushik@citrix.com]
> Sent: Tuesday, July 30, 2013 5:14 PM
> To: dev@cloudstack.apache.org
> Subject: RE: Request to inform which DB command to run on existing setup if
> any db schema changes
> 
> Rajesh,
> You can look at the check-in history for schema-410to420.sql for the changes
> 
> > -Original Message-
> > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> > Sent: Tuesday, July 30, 2013 5:03 PM
> > To: dev@cloudstack.apache.org
> > Subject: Request to inform which DB command to run on existing setup
> > if any db schema changes
> >
> > Hi All,
> > Please share sql statements to be inserted in the dev list, if any db
> > schema changes are committed and require deploy db on existing setup .
> > This will save lots of development time.
> > More time is getting consumed in clearing the entire setup and set it again.
> >
> > Thanks
> > Rajesh Battala

Review Request 13061: Unable to create the Internal LB vm.

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13061/
---

Review request for cloudstack, Alena Prokharchyk, Devdeep Singh, and Ram Ganesh.


Bugs: 3924


Repository: cloudstack-git


Description
---

Issue:
==
Unable to created internalLB Vm. this is due while determining maxconn value 
from networkoffering.
to find the networking offering, networkid is passed instead of networkoffering 
id which is causing the issue.

fixed:
=
fixed the issue by passing the network offering id instead of network id.


Diffs
-

  
plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java
 76507e9 

Diff: https://reviews.apache.org/r/13061/diff/


Testing
---

1. was able to create the 'b' vm. internal LB VM.


Thanks,

Rajesh Battala

Regarding the hypervisor tools in new system vm templates

[Rajesh Battala]

Hi All,

For 4.2 we had started using new system vm template.
And the generated system vm template for each target hypervisor don't have 
hypervisor specific guest tools installed in it.
It has open-vm tools not hypervisor specific.
I think it would be good to have xentools installed in Xenserver specific 
system vm temapltes, vmware-tools in vmware specific system vm templates.

AFAIK Hypervisor specific tools installed in system vm will give good 
performance.

Thanks
Rajesh Battala

Re: Review Request 12958: Automation test failure: can't attach volume to a stopped created VM. Fix the null pointer

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12958/#review24442
---

Ship it!


Ship It!

- Rajesh Battala


On July 31, 2013, 10:10 p.m., Fang Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12958/
> ---
> 
> (Updated July 31, 2013, 10:10 p.m.)
> 
> 
> Review request for cloudstack, edison su and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3759
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When the new VM is created and put in stopped state, the volume and pool is 
> not allocated. Hence the NPE. 
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java d7d62b0 
> 
> Diff: https://reviews.apache.org/r/12958/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Fang Wang
> 
>

Review Request 13237: Unable to resize disk with Zone wide storage

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/
---

Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.


Bugs: 3781


Repository: cloudstack-git


Description
---

Issue:
== 
for Volume operations we are finding the hypervisor type. Volume can be in 
ZONE/Cluster scope storage pool. 
when volume is in ZONE scope, there is issue with they way we fetch the 
hypervisor type. It was written to handle Cluster scope only.

fixed:
==
Fixed with sql queries to fetch the Hypervisor type.
1. Fetch the hypervisor type for volume from storage pool table if the voluem 
is in ZONE scope storage pool.
2. Fetch the hypervisor type for volume from cluster table if the voluem is in 
CLUSTER scope storage pool.


Diffs
-

  engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
  engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 

Diff: https://reviews.apache.org/r/13237/diff/


Testing
---

Setup:
KVM and Xenserver with Adv Zone.
Added pool Zone scope on KVM and Cluster Scope on Xenserver 
1. created instances on KVM and xenserver.
2. Create two volumes attached to instances on KVM and Xenserver. 
3. vol1 is in Zone scope and vol2 is in cluster scope. 
4. Successfully performed resize opertions on vol1 and vol2.
5. Succssfully attached/detaches volumes


Thanks,

Rajesh Battala

Re: Review Request 13237: Unable to resize disk with Zone wide storage

[Rajesh Battala]

> On Aug. 2, 2013, 11:29 a.m., Jenkins Cloudstack.org wrote:
> > Review 13237 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #106 is : 
> > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/106/

patch is not generated on master branch hence this failure


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/#review24524
---


On Aug. 2, 2013, 10:07 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13237/
> ---
> 
> (Updated Aug. 2, 2013, 10:07 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
> 
> 
> Bugs: 3781
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue:
> == 
> for Volume operations we are finding the hypervisor type. Volume can be in 
> ZONE/Cluster scope storage pool. 
> when volume is in ZONE scope, there is issue with they way we fetch the 
> hypervisor type. It was written to handle Cluster scope only.
> 
> fixed:
> ==
> Fixed with sql queries to fetch the Hypervisor type.
> 1. Fetch the hypervisor type for volume from storage pool table if the voluem 
> is in ZONE scope storage pool.
> 2. Fetch the hypervisor type for volume from cluster table if the voluem is 
> in CLUSTER scope storage pool.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
>   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 
> 
> Diff: https://reviews.apache.org/r/13237/diff/
> 
> 
> Testing
> ---
> 
> Setup:
> KVM and Xenserver with Adv Zone.
> Added pool Zone scope on KVM and Cluster Scope on Xenserver 
> 1. created instances on KVM and xenserver.
> 2. Create two volumes attached to instances on KVM and Xenserver. 
> 3. vol1 is in Zone scope and vol2 is in cluster scope. 
> 4. Successfully performed resize opertions on vol1 and vol2.
> 5. Succssfully attached/detaches volumes
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

is jira down. ?

[Rajesh Battala]

RE: is jira down. ?

[Rajesh Battala]

Jira is up now. 
Looks like there was an issue with plugin and somebody Fixed it. 

Thanks
Rajesh  Battala

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] 
Sent: Monday, August 5, 2013 12:19 PM
To: dev@cloudstack.apache.org
Subject: is jira down. ?

unable to view content of cwiki

[Rajesh Battala]

Hi All,

Am not able to view any link of cwiki.
Am getting permission denied to view any content.
Please let me know how to resolve this issue.

Thanks
Rajesh Battala

RE: unable to view content of cwiki

[Rajesh Battala]

Am still not able to access any pages. 
Ex : https://cwiki.apache.org/confluence/users/viewmyprofile.action 
even a publicly accessable page, when I login am getting error 
Not Permitted
You are not permitted to perform this operation.

Please do the needful.

Thanks
Rajesh Battala

-Original Message-
From: Go Chiba [mailto:go.ch...@gmail.com] 
Sent: Monday, August 5, 2013 7:37 PM
To: dev@cloudstack.apache.org
Subject: Re: unable to view content of cwiki

Yes, I able to access them too.
Rajesh, are you still can't access cwiki page? if yes, please share some 
example link.


On Mon, Aug 5, 2013 at 10:47 PM, Daan Hoogland wrote:

> I've able to access the wiki all day so far.
>
> On Mon, Aug 5, 2013 at 12:43 PM, Rajesh Battala 
>  wrote:
> > Hi All,
> >
> > Am not able to view any link of cwiki.
> > Am getting permission denied to view any content.
> > Please let me know how to resolve this issue.
> >
> > Thanks
> > Rajesh Battala
>



--
千葉 豪  Go Chiba
E-mail:go.ch...@gmail.com

RE: Issue with deleting a volume that's never been attached to a VM

[Rajesh Battala]

I will try on my setup 

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Tuesday, August 6, 2013 4:48 AM
To: dev@cloudstack.apache.org
Subject: Issue with deleting a volume that's never been attached to a VM

Hi,

I've noticed in 4.2 when I try to delete a volume that's never been attached to 
a VM that CloudStack says the operation was successful and the GUI removes the 
volume from the table, but when I refresh the table, the volume comes back.

Has anyone else noticed this behavior as of late?

If I attach the volume, then detach it, then delete it, all behaves as expected.

Thanks!

--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*

RE: Issue with deleting a volume that's never been attached to a VM

[Rajesh Battala]

I able to reproduce it. 
Deleting unattached volume is coming back again. 
The removed column is not update in the db for this volume. 

Will create a major bug. 

*** 6. row ***
id: 6
account_id: 2
 domain_id: 1
   pool_id: NULL
  last_pool_id: NULL
   instance_id: NULL
 device_id: NULL
  name: testVol
  uuid: 3b008262-1c52-49a7-900d-b38fbf274e89
  size: 5368709120
folder: NULL
  path: NULL
pod_id: NULL
data_center_id: 1
iscsi_name: NULL
   host_ip: NULL
   volume_type: DATADISK
 pool_type: NULL
  disk_offering_id: 3
   template_id: NULL
first_snapshot_backup_uuid: NULL
   recreatable: 0
   created: 2013-08-06 04:47:07
  attached: NULL
   updated: 2013-08-06 04:47:07
   removed: NULL
 state: Allocated
chain_info: NULL
  update_count: 0
 disk_type: NULL
vm_snapshot_chain_size: NULL
iso_id: 0
display_volume: 1
format: NULL
  min_iops: NULL
  max_iops: NULL
6 rows in set (0.00 sec)



-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] 
Sent: Tuesday, August 6, 2013 10:15 AM
To: dev@cloudstack.apache.org
Subject: RE: Issue with deleting a volume that's never been attached to a VM

I will try on my setup 

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Tuesday, August 6, 2013 4:48 AM
To: dev@cloudstack.apache.org
Subject: Issue with deleting a volume that's never been attached to a VM

Hi,

I've noticed in 4.2 when I try to delete a volume that's never been attached to 
a VM that CloudStack says the operation was successful and the GUI removes the 
volume from the table, but when I refresh the table, the volume comes back.

Has anyone else noticed this behavior as of late?

If I attach the volume, then detach it, then delete it, all behaves as expected.

Thanks!

--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*(tm)*

Re: Review Request 13237: Unable to resize disk with Zone wide storage

[Rajesh Battala]

> On Aug. 5, 2013, 6:17 p.m., edison su wrote:
> > engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java, line 77
> > <https://reviews.apache.org/r/13237/diff/1/?file=334435#file334435line77>
> >
> > why not just use "select s.scope from storage_pool s, volumes v where 
> > s.id = v.pool_id"?

if we use the above query then we get list of scope values.
mysql> select s.scope from storage_pool s, volumes v where s.id = v.pool_id;
+-+
| scope   |
+-+
| CLUSTER |
| CLUSTER |
| CLUSTER |
| CLUSTER |
| ZONE|
+-+
5 rows in set (0.00 sec)

 So I had written the above query like SELECT_POOLSCOPE = "SELECT s.scope from 
storage_pool s, volumes v where s.id =(select pool_id from volumes where id 
=?)"; 
to fetch the scope of the storage pool where the volume is existing.


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/#review24653
-------


On Aug. 2, 2013, 10:07 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13237/
> ---
> 
> (Updated Aug. 2, 2013, 10:07 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
> 
> 
> Bugs: 3781
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue:
> == 
> for Volume operations we are finding the hypervisor type. Volume can be in 
> ZONE/Cluster scope storage pool. 
> when volume is in ZONE scope, there is issue with they way we fetch the 
> hypervisor type. It was written to handle Cluster scope only.
> 
> fixed:
> ==
> Fixed with sql queries to fetch the Hypervisor type.
> 1. Fetch the hypervisor type for volume from storage pool table if the voluem 
> is in ZONE scope storage pool.
> 2. Fetch the hypervisor type for volume from cluster table if the voluem is 
> in CLUSTER scope storage pool.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
>   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 
> 
> Diff: https://reviews.apache.org/r/13237/diff/
> 
> 
> Testing
> ---
> 
> Setup:
> KVM and Xenserver with Adv Zone.
> Added pool Zone scope on KVM and Cluster Scope on Xenserver 
> 1. created instances on KVM and xenserver.
> 2. Create two volumes attached to instances on KVM and Xenserver. 
> 3. vol1 is in Zone scope and vol2 is in cluster scope. 
> 4. Successfully performed resize opertions on vol1 and vol2.
> 5. Succssfully attached/detaches volumes
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

RE: unable to view content of cwiki

[Rajesh Battala]

Sorry the issue is not with the site. 
Issue is with my account. Can someone please provide permission to my account 
to access the content. 
My email rajesh.batt...@citrix.com

Thanks
Rajesh Battala


-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Tuesday, August 6, 2013 1:21 PM
To: dev
Subject: Re: unable to view content of cwiki

Rajesh,

You must reside behind a proxy or firwall that prohibits you from working. I 
can access the page you linked us to.

regards,
Daan

On Tue, Aug 6, 2013 at 5:24 AM, Rajesh Battala  
wrote:
> Am still not able to access any pages.
> Ex : https://cwiki.apache.org/confluence/users/viewmyprofile.action
> even a publicly accessable page, when I login am getting error Not 
> Permitted You are not permitted to perform this operation.
>
> Please do the needful.
>
> Thanks
> Rajesh Battala
>
> -Original Message-
> From: Go Chiba [mailto:go.ch...@gmail.com]
> Sent: Monday, August 5, 2013 7:37 PM
> To: dev@cloudstack.apache.org
> Subject: Re: unable to view content of cwiki
>
> Yes, I able to access them too.
> Rajesh, are you still can't access cwiki page? if yes, please share some 
> example link.
>
>
> On Mon, Aug 5, 2013 at 10:47 PM, Daan Hoogland wrote:
>
>> I've able to access the wiki all day so far.
>>
>> On Mon, Aug 5, 2013 at 12:43 PM, Rajesh Battala 
>>  wrote:
>> > Hi All,
>> >
>> > Am not able to view any link of cwiki.
>> > Am getting permission denied to view any content.
>> > Please let me know how to resolve this issue.
>> >
>> > Thanks
>> > Rajesh Battala
>>
>
>
>
> --
> 千葉 豪  Go Chiba
> E-mail:go.ch...@gmail.com

please provide access to cwiki for my account

[Rajesh Battala]

Hi ,

Am not able to view any page in cwiki after login-in.
Am getting permission denied for any page view.
Here is my account email 
rajesh.batt...@citrix.com<mailto:rajesh.batt...@citrix.com>
Please provide access to my a/c.


Thanks
Rajesh Battala

RE: please provide access to cwiki for my account

[Rajesh Battala]

After resetting the password also am still facing the issue. 
Please do the needful.

Thanks
Rajesh Battala

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] 
Sent: Tuesday, August 6, 2013 3:14 PM
To: dev@cloudstack.apache.org
Subject: please provide access to cwiki for my account

Hi ,

Am not able to view any page in cwiki after login-in.
Am getting permission denied for any page view.
Here is my account email 
rajesh.batt...@citrix.com<mailto:rajesh.batt...@citrix.com>
Please provide access to my a/c.


Thanks
Rajesh Battala

Review Request 13319: [KVM] [PrimaryStorage] deleteStoragePool is not removing the storage pool information from KVM agent/host.

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13319/
---

Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.


Bugs: 3887


Repository: cloudstack-git


Description
---

Issue:
==
[KVM] [PrimaryStorage] deleteStoragePool is not removing the storage pool 
information from KVM agent/host.

root cause:
== 
   In the CloudstackPrimaryDatastorelifecycleImpl class, deletedataStore method 
 when storage is getting deleted which is attached to kvm hosts, from the list 
of hosts only for first host Agentcmd is sent to remove the storage.
In case of xenserver this will work as the xapi will take care of removing the 
storagepool from its slaves. 

   In case of KVM we need to send to all hosts to remove the storage. 

Fixed:
==
Fixed by sending the agent command to all the hosts if the storage pool is 
attached to KVM type hypervisor.


Diffs
-

  
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
 2c8c871 

Diff: https://reviews.apache.org/r/13319/diff/


Testing
---

1. Created a zone with two kvm hosts and one xenserver host 
2. Created cluster scope primary storage for kvm cluster, storage got mounted 
on both kvm hosts.
3. Enabled maintenance on storage and removed the storage pool.
4. Storage got successfully umount from both the hosts. virsh-pool is not 
listing the removed storage pool.

5. Created ZONE scope PS, storage got mounted in both the KVM hosts. 
6  Storage got successfully umount from both the hosts. virsh-pool is not 
listing the removed storage pool.

7. created cluster scope for Xenserver Cluster. 
8. Enabled maintenance on storage and removed the storage pool.
9. Storage got successfully umount from both xenserver.


Thanks,

Rajesh Battala

Re: Review Request 13237: Unable to resize disk with Zone wide storage

[Rajesh Battala]

> On Aug. 5, 2013, 6:17 p.m., edison su wrote:
> > engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java, line 77
> > <https://reviews.apache.org/r/13237/diff/1/?file=334435#file334435line77>
> >
> > why not just use "select s.scope from storage_pool s, volumes v where 
> > s.id = v.pool_id"?
> 
> Rajesh Battala wrote:
> if we use the above query then we get list of scope values.
> mysql> select s.scope from storage_pool s, volumes v where s.id = 
> v.pool_id;
> +-+
> | scope   |
> +-+
> | CLUSTER |
> | CLUSTER |
> | CLUSTER |
> | CLUSTER |
> | ZONE|
> +-+
> 5 rows in set (0.00 sec)
> 
>  So I had written the above query like SELECT_POOLSCOPE = "SELECT s.scope 
> from storage_pool s, volumes v where s.id =(select pool_id from volumes where 
> id =?)"; 
> to fetch the scope of the storage pool where the volume is existing.
> 
> edison su wrote:
> If this is the case, you can use "select s.scope from storage_pool s, 
> volumes v where s.id = v.pool_id and v.id = your-volume-id"?

edison, the query "select s.scope from storage_pool s, volumes v where s.id = 
v.pool_id and v.id = your-volume-id" will also get me the scope without any 
issue. 

the query you had mentioned is proper one.

I will incorporate the change and rebase with 4.2 and submit the patch.


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/#review24653
---


On Aug. 2, 2013, 10:07 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13237/
> ---
> 
> (Updated Aug. 2, 2013, 10:07 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
> 
> 
> Bugs: 3781
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue:
> == 
> for Volume operations we are finding the hypervisor type. Volume can be in 
> ZONE/Cluster scope storage pool. 
> when volume is in ZONE scope, there is issue with they way we fetch the 
> hypervisor type. It was written to handle Cluster scope only.
> 
> fixed:
> ==
> Fixed with sql queries to fetch the Hypervisor type.
> 1. Fetch the hypervisor type for volume from storage pool table if the voluem 
> is in ZONE scope storage pool.
> 2. Fetch the hypervisor type for volume from cluster table if the voluem is 
> in CLUSTER scope storage pool.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
>   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 
> 
> Diff: https://reviews.apache.org/r/13237/diff/
> 
> 
> Testing
> ---
> 
> Setup:
> KVM and Xenserver with Adv Zone.
> Added pool Zone scope on KVM and Cluster Scope on Xenserver 
> 1. created instances on KVM and xenserver.
> 2. Create two volumes attached to instances on KVM and Xenserver. 
> 3. vol1 is in Zone scope and vol2 is in cluster scope. 
> 4. Successfully performed resize opertions on vol1 and vol2.
> 5. Succssfully attached/detaches volumes
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request 13237: Unable to resize disk with Zone wide storage

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/
---

(Updated Aug. 6, 2013, 7:13 p.m.)


Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.


Changes
---

Incorporated comments 
rebased with latest 4.2 and tested the patch.


Bugs: 3781


Repository: cloudstack-git


Description
---

Issue:
== 
for Volume operations we are finding the hypervisor type. Volume can be in 
ZONE/Cluster scope storage pool. 
when volume is in ZONE scope, there is issue with they way we fetch the 
hypervisor type. It was written to handle Cluster scope only.

fixed:
==
Fixed with sql queries to fetch the Hypervisor type.
1. Fetch the hypervisor type for volume from storage pool table if the voluem 
is in ZONE scope storage pool.
2. Fetch the hypervisor type for volume from cluster table if the voluem is in 
CLUSTER scope storage pool.


Diffs (updated)
-

  engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
  engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 

Diff: https://reviews.apache.org/r/13237/diff/


Testing
---

Setup:
KVM and Xenserver with Adv Zone.
Added pool Zone scope on KVM and Cluster Scope on Xenserver 
1. created instances on KVM and xenserver.
2. Create two volumes attached to instances on KVM and Xenserver. 
3. vol1 is in Zone scope and vol2 is in cluster scope. 
4. Successfully performed resize opertions on vol1 and vol2.
5. Succssfully attached/detaches volumes


Thanks,

Rajesh Battala

Re: Review Request 13365: fix local storage volume deployment

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13365/#review24773
---

Ship it!


Ship It!

- Rajesh Battala


On Aug. 6, 2013, 10:53 p.m., Marcus Sorensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13365/
> ---
> 
> (Updated Aug. 6, 2013, 10:53 p.m.)
> 
> 
> Review request for cloudstack and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-4121
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> See CLOUDSTACK-4121. This seems to allow the hypervisor type to be queried 
> for local volumes, by using the cluster level storage SQL query. I *think* 
> these three are the only storage-related scope types.
> 
> You may want to tweak this a bit more to not bother with the sql statement if 
> sql=null, but I think it provides a pretty obvious heads-up as to what's 
> wrong, aside from my little error message.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java 273f7f9 
> 
> Diff: https://reviews.apache.org/r/13365/diff/
> 
> 
> Testing
> ---
> 
> tested in KVM fresh 4.2 zone, VMs now starting rather than throwing SQL 
> errors.
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>

Re: Review Request 13237: Unable to resize disk with Zone wide storage

[Rajesh Battala]

> On Aug. 6, 2013, 7:57 p.m., edison su wrote:
> > Ship It!

thanks for committing the patch


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/#review24736
---


On Aug. 6, 2013, 7:13 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13237/
> ---
> 
> (Updated Aug. 6, 2013, 7:13 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
> 
> 
> Bugs: 3781
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue:
> == 
> for Volume operations we are finding the hypervisor type. Volume can be in 
> ZONE/Cluster scope storage pool. 
> when volume is in ZONE scope, there is issue with they way we fetch the 
> hypervisor type. It was written to handle Cluster scope only.
> 
> fixed:
> ==
> Fixed with sql queries to fetch the Hypervisor type.
> 1. Fetch the hypervisor type for volume from storage pool table if the voluem 
> is in ZONE scope storage pool.
> 2. Fetch the hypervisor type for volume from cluster table if the voluem is 
> in CLUSTER scope storage pool.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
>   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 
> 
> Diff: https://reviews.apache.org/r/13237/diff/
> 
> 
> Testing
> ---
> 
> Setup:
> KVM and Xenserver with Adv Zone.
> Added pool Zone scope on KVM and Cluster Scope on Xenserver 
> 1. created instances on KVM and xenserver.
> 2. Create two volumes attached to instances on KVM and Xenserver. 
> 3. vol1 is in Zone scope and vol2 is in cluster scope. 
> 4. Successfully performed resize opertions on vol1 and vol2.
> 5. Succssfully attached/detaches volumes
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

RE: Unable to view JIRA ticket CLOUDSTACK-967

[Rajesh Battala]

If it is a security issue I think we don't have permission to view them

-Original Message-
From: Sateesh Chodapuneedi [mailto:sateesh.chodapune...@citrix.com] 
Sent: Friday, July 11, 2014 7:11 AM
To: dev@cloudstack.apache.org
Subject: Unable to view JIRA ticket CLOUDSTACK-967

Hi,
In ACS JIRA unable to view the ticket CLOUDSTACK-967 
https://issues.apache.org/jira/browse/CLOUDSTACK-967
Error is,
---
Permission Violation

It seems that you have tried to perform an operation which you are not 
permitted to perform.

If you think this message is wrong, please contact your JIRA 
administrators.
---

This is not the case with any other tickets like CLOUDSTACK-966, CLOUDSTACK-968.

Regards,
Sateesh

Re: Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful timeout setting when login to NetScaler.

[Rajesh Battala]

> On July 9, 2014, 4:45 p.m., ASF Subversion and Git Services wrote:
> > Commit e07d0ddabfedad137856c3c9ae7de3a96fe25feb in cloudstack's branch 
> > refs/heads/master from Sujaya Maiyya
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e07d0dd ]
> > 
> > fixed CLOUDSTACK-6261: remove the forceful timeout setting when login to 
> > NetScaler.
> >

I have pushed to master branch. can you close this review request


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/#review47503
---


On July 8, 2014, 9:28 a.m., Sujaya Maiyya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22927/
> ---
> 
> (Updated July 8, 2014, 9:28 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6261
> https://issues.apache.org/jira/browse/CLOUDSTACK-6261
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The NetScaler Resource forces a idle timeout of 100,000 seconds during login. 
> It is best to leave it to the system default which is 30 mins. The timeout 
> has been removed from NetscalerResource in order to support login for 
> Netscaler 10.5 devices.
> 
> 
> Diffs
> -
> 
>   
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
>  ff51ef9 
> 
> Diff: https://reviews.apache.org/r/22927/diff/
> 
> 
> Testing
> ---
> 
> Timeout was removed and login to the Netscaler devices with the default 
> timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 
> and 10.5.
> 
> 
> Thanks,
> 
> Sujaya Maiyya
> 
>

RE: SSL keystore file name

[Rajesh Battala]

Thanks Kishan for the info.

-Original Message-
From: Kishan Kavala [mailto:kishan.kav...@citrix.com] 
Sent: Friday, July 25, 2014 4:41 PM
To: dev@cloudstack.apache.org
Cc: Wei Zhou; wilderrodrigues
Subject: SSL keystore file name

SSl keystore was changed from cloud.keystore to cloudmanagementserver.keystore 
with below commit [1]. Later, related code change were over-written in commit 
[2]. I made changes [3] to keep keystore filename as 
cloudmanagementserver.keystore in all references. 
Please let me know if you see any issues.

[1] 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=57ba367f3c985e80ea1b34267e298b481a353298
[2] 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=2774b62d64989bddc1e4664ef7a93dff11c77657
[3] 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=c61c636ce8a1d74fd22d89026d40ba904fff6cf8

RE: Load Balancer Crosszone

[Rajesh Battala]

If you use Netscaler as LB provider in your cloudstack, Netscaler has a 
supported feature called GSLB.
This feature is Load Balancer across zones. It's been in Cloudstack long back.

Thanks
Rajesh Battala

-Original Message-
From: Silvano Nogueira Buback [mailto:silv...@corp.globo.com] 
Sent: Tuesday, October 14, 2014 11:02 PM
To: dev@cloudstack.apache.org
Subject: Load Balancer Crosszone

Guys,

There is any way to create a load balancer between zones, using shared 
network and advanced zone? This is not the idea of Global Load Balancer, is the 
same idea of Amazon LB cross zone.

Att,

Silvano Buback

Re: Review Request: Summary: Fix for CLOUDSTACK-1537 - Restart network with clean up set to true causes Autoscaled LB rule to get mangled and unusable

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10058/#review18207
---

Ship it!


Ship It!

- Rajesh Battala


On March 21, 2013, 11:19 a.m., Vijay Venkatachalam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10058/
> ---
> 
> (Updated March 21, 2013, 11:19 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Description
> ---
> 
> 
> Tested Reviewed and Marked for Ship already in 4.1 branch. 
> https://reviews.apache.org/r/10017/
> 
> The patch wont apply to master branch so submitting a new patch for it.
> 
> Bug Title: Restart network with clean up set to true causes Autoscaled LB 
> rule to get mangled and unusable 
> 
> AutoScale LB information was not packaged for restart of network case to 
> Resource Layer. This caused the undesired outcome and it is fixed now. 
> NetWorkManagerImpl was doing the cleanup of the LBRules during restart, after 
> the fix; NetWorkManagerImpl  will only act as a trigger, the actual job 
> related to LB Rules (for ex. remove/revoke) will be handled by LBRules 
> Manager (which should have been the actual implementation, so moved code 
> around). 
> 
> Also, NetScaler resource is simplified to handle 
> create/enable/disable/restart in one code path. 
> 
> 
> This addresses bug CLOUDSTACK-1537.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/lb/LoadBalancingRule.java 84526c5 
>   
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
>  4eb0ce2 
>   server/src/com/cloud/network/NetworkManagerImpl.java 591910b 
>   server/src/com/cloud/network/lb/LoadBalancingRulesManager.java da19f86 
>   server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a06cbc5 
> 
> Diff: https://reviews.apache.org/r/10058/diff/
> 
> 
> Testing
> ---
> 
> Tested Reviewed and Marked for Ship already in 4.1 branch. 
> https://reviews.apache.org/r/10017/
> 
> 
> Thanks,
> 
> Vijay Venkatachalam
> 
>

RE: Configuring nonOSS CloudStack to support VMware vSphere

[Rajesh Battala]

Hi Chris, 
Are you trying on Master or any other branch?

Thanks
Rajesh Battala

> -Original Message-
> From: Chris Smith [mailto:christopher.sm...@infotechfl.com]
> Sent: Thursday, March 21, 2013 8:48 PM
> To: dev@cloudstack.apache.org
> Subject: Configuring nonOSS CloudStack to support VMware vSphere
> 
> Hello,
> 
> I am having a problem configuring CloudStack to work with VMware vSphere.
> 
> I have downloaded all the necessary SDK's and run through the mavin
> builds/installs.
> 
> All builds are successful, however I still receive:
> 
> "Could not find corresponding resource manager for VMware"
> 
> when I try to build a cluster.
> 
> Is there someone who could assist me in this endeavor?
> 
> Thank you!
> 
> --
> Chris
> Server Administrator I
> InfoTech, Inc.
> 5700 SW 34th Street, Suite 1235
> Gainesville, FL
> 352-381-4766

RE: Console Proxy VM no startup

[Rajesh Battala]

>From the log:
=
There is no enough capacity for the hosts in the zone for the console proxy to 
create and start so its failing. 

 "com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
deployment for VM[ConsoleProxy|v-2-VM]Scope=interface
com.cloud.dc.DataCenter; id=1 "


"(consoleproxy-1:null) CPUOverprovisioningFactor considered: 1.0
2013-03-22 14:52:47,352 DEBUG [cloud.deploy.FirstFitPlanner]
(consoleproxy-1:null) No clusters found having a host with enough capacity, 
returning.
2013-03-22 14:52:47,378 DEBUG [cloud.capacity.CapacityManagerImpl]
(consoleproxy-1:null) VM state transitted from :Starting to Stopped with
event: OperationFailedvm's original host id: null new host id: null host id 
before state transition: null  "

Thanks
Rajesh Battala





> -Original Message-
> From: ykruchko ykruchko [mailto:ykruc...@gmail.com]
> Sent: Friday, March 22, 2013 7:03 PM
> To: cloudstack-...@incubator.apache.org
> Subject: Console Proxy VM no startup
> 
> 1) in  apache cloud stack 4.0.1 (acs) don`t work russian language because 
> project
> have no
> /usr/share/cloud/management/webapps/client/css/cloudstack3.ru_RU.css
> 
> 2) installation guide have url to broken binary file  on vhd-util and in xen 
> cloud
> platform vhd-util is installed. Path to binary file /usr/sbin/vhd-util
> 
> 3) I have a problem with Console Proxy VM
> 
> It path  of /var/log/cloud/management/management-server.log. If you can you
> help me with this problem ?
> 
> 2013-03-22 14:52:33,856 DEBUG [cloud.server.StatsCollector]
> (StatsCollector-1:null) HostStatsCollector is running...
> 2013-03-22 14:52:33,864 DEBUG [agent.manager.DirectAgentAttache]
> (DirectAgent-158:null) Seq 1-1235353817: Executing request
> 2013-03-22 14:52:34,165 DEBUG [agent.manager.DirectAgentAttache]
> (DirectAgent-158:null) Seq 1-1235353817: Response Received:
> 2013-03-22 14:52:34,165 DEBUG [agent.transport.Request]
> (StatsCollector-1:null) Seq 1-1235353817: Received:  { Ans: , MgmtId:
> 8796763611955, via: 1, Ver: v1, Flags: 10, { GetHostStatsAnswer } }
> 2013-03-22 14:52:47,164 DEBUG
> [storage.secondary.SecondaryStorageManagerImpl] (secstorage-1:null) Zone 1
> is ready to launch secondary storage VM
> 2013-03-22 14:52:47,297 DEBUG
> [cloud.consoleproxy.ConsoleProxyManagerImpl]
> (consoleproxy-1:null) Zone 1 is ready to launch console proxy
> 2013-03-22 14:52:47,297 DEBUG
> [cloud.consoleproxy.ConsoleProxyManagerImpl]
> (consoleproxy-1:null) Expand console proxy standby capacity for zone zone1
> 2013-03-22 14:52:47,300 INFO
> [cloud.consoleproxy.ConsoleProxyManagerImpl]
> (consoleproxy-1:null) Found a stopped console proxy, bring it up to running 
> pool.
> proxy vm id : 2
> 2013-03-22 14:52:47,306 DEBUG [cloud.capacity.CapacityManagerImpl]
> (consoleproxy-1:null) VM state transitted from :Stopped to Starting with
> event: StartRequestedvm's original host id: null new host id: null host id 
> before
> state transition: null
> 2013-03-22 14:52:47,306 DEBUG [cloud.vm.VirtualMachineManagerImpl]
> (consoleproxy-1:null) Successfully transitioned to start state for
> VM[ConsoleProxy|v-2-VM] reservation id =
> 8283eee5-c124-4299-a8e9-33846db43253
> 2013-03-22 14:52:47,344 DEBUG [cloud.vm.VirtualMachineManagerImpl]
> (consoleproxy-1:null) Trying to deploy VM, vm has dcId: 1 and podId: null
> 2013-03-22 14:52:47,344 DEBUG [cloud.vm.VirtualMachineManagerImpl]
> (consoleproxy-1:null) Deploy avoids pods: null, clusters: null, hosts: null
> 2013-03-22 14:52:47,347 DEBUG [cloud.deploy.FirstFitPlanner]
> (consoleproxy-1:null) DeploymentPlanner allocation algorithm: random
> 2013-03-22 14:52:47,347 DEBUG [cloud.deploy.FirstFitPlanner]
> (consoleproxy-1:null) Trying to allocate a host and storage pools from dc:1,
> pod:null,cluster:null, requested cpu: 500, requested ram: 1073741824
> 2013-03-22 14:52:47,347 DEBUG [cloud.deploy.FirstFitPlanner]
> (consoleproxy-1:null) Is ROOT volume READY (pool already allocated)?: No
> 2013-03-22 14:52:47,348 DEBUG [cloud.deploy.FirstFitPlanner]
> (consoleproxy-1:null) Searching all possible resources under this Zone: 1
> 2013-03-22 14:52:47,349 DEBUG [cloud.deploy.FirstFitPlanner]
> (consoleproxy-1:null) Listing clusters in order of aggregate capacity, that 
> have
> (atleast one host with) enough CPU and RAM capacity under this Zone: 1
> 2013-03-22 14:52:47,350 DEBUG [cloud.deploy.FirstFitPlanner]
> (consoleproxy-1:null) CPUOverprovisioningFactor considered: 1.0
> 2013-03-22 14:52:47,352 DEBUG [cloud.deploy.FirstFitPlanner]
> (consoleproxy-1:null) No clusters found having a host with enough capacity,
> returning.
> 2013-03-22 14:52:47,378 DEBUG [cloud.capacity.CapacityManagerImpl]
> (consoleproxy-1:null) VM state transitted from :Starting t

RE: Problem adding Host inside a Cluster

[Rajesh Battala]

Can you please post the error log .

Thanks
Rajesh Battala

> -Original Message-
> From: Kausal Malladi [mailto:mkau...@gmail.com]
> Sent: Friday, March 22, 2013 7:59 PM
> To: cloudstack-...@incubator.apache.org
> Subject: Problem adding Host inside a Cluster
> 
> Hi,
> I am having problem adding host inside a cluster on CloudStack.
> Basically I am doing this:
> 
> DevCloud (IP: 172.16.0.1) on virtualbox adapter with IP 172.16.0.2 and netmask
> /16.
> I am able to ping my host machine from DevCloud. Connection between my host
> machine and DevCloud is fine
> 
> But while configuration, Host is not getting added. It says "Error adding 
> host"
> and I gave the following details:
> hostname: 172.16.0.1
> username: root
> password: password
> 
> Can anyone please help me on this?
> 
> 
> Thanks and Regards,
> 
> Kausal Malladi
> www.kausalmalladi.tk

RE: [PROPOSAL] "Internal Load Balancing between VPC tiers"

[Rajesh Battala]

Hi Alena,
Thanks for the FS.
I was going through the FS,  is InternalLBVM is  a new system VM?A new system 
VM template will be there of the same VPCVR/VR template is used.

Am making changes such that at Traffic to Web tier is balanced by NetScaler on 
the public side.

Thanks
Rajesh Battala

> -Original Message-
> From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com]
> Sent: Saturday, March 23, 2013 4:27 AM
> To: cloudstack-...@incubator.apache.org
> Cc: Alex Huang; Chiradeep Vittal
> Subject: [PROPOSAL] "Internal Load Balancing between VPC tiers"
> 
> I would like to propose a new feature - "Internal Load Balancing between VPC
> tiers".  With the feature support, you can set up the Load Balancer inside the
> VPC without facing the public network side. It will allow to balance internal
> traffic between tiers inside the VPC - for example, traffic coming from Web 
> Tier
> to the App tier.
> 
> 
> Please review the firs draft of FS and provide your comments and feedback.
> If you feel like some details are missing, let me know and I'll update it 
> promptly.
> 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Internal+Load+Bala
> nc
> ing+between+VPC+tiers
> 
> 
> Alex/Chiradeep, would appreciate your reviewal as you were the original
> contributors for the majority of cloudStack Networking code.
> 
> 
> Thank you,
> -Alena.

RE: Building nonoss

[Rajesh Battala]

Mike,

Have you got the jars for netscaler in deps folder and did install.sh? 
Can you run with -X and post the log.  Are you on Master/4.1?  my 4.1 /master 
both are building successfully.

Thanks
Rajesh Battala

> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Sunday, March 24, 2013 10:46 PM
> To: cloudstack-...@incubator.apache.org
> Subject: Building nonoss
> 
> Hi everyone,
> 
> I'm trying to create a VMware cluster in CS, but forgot that I needed to build
> specially to include the nonoss.
> 
> I tried this with the newest master (just updated a few minutes ago to the
> latest):
> 
> mvn clean install -Dnonoss
> 
> The build failed here:
> 
> [INFO] Apache CloudStack Plugin - Network Netscaler .. FAILURE [2.203s]
> 
> Am I supposed to use a different command to build with nonoss or is the build
> broken (it did build when I used mvn clean install -P developer,systemvm).
> 
> Thanks!
> 
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud<http://solidfire.com/solution/overview/?video=play>
> *(tm)*

RE: Building nonoss

[Rajesh Battala]

Mike, 
Looks like some problem with Library of NS.
will get back to you with solution. 

Thanks
Rajesh Battala

> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Monday, March 25, 2013 10:39 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Building nonoss
> 
> Hey Rajesh,
> 
> I ran the following:
> 
> mvn clean install -Dnonoss -X
> 
> here was the output (thanks!):
> 
> [INFO] Apache CloudStack Plugin - Dns Notifier Example ... SUCCESS [0.906s]
> [INFO] Apache CloudStack Plugin - Storage Image S3 ... SUCCESS [0.889s]
> [INFO] Apache CloudStack Plugin - Storage Volume solidfire  SUCCESS [0.631s]
> [INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS
> [0.601s] [INFO] Apache CloudStack Plugin - SNMP Alerts  SUCCESS
> [1.340s] [INFO] Apache CloudStack Plugin - NetApp File System . SUCCESS
> [0.915s] [INFO] Apache CloudStack Plugin - F5 . SUCCESS 
> [0.872s]
> [INFO] Apache CloudStack Plugin - Network Netscaler .. FAILURE [2.345s]
> [INFO] Apache CloudStack Plugin - Juniper SRX  SKIPPED [INFO] 
> Apache
> CloudStack VMware Base . SKIPPED [INFO] Apache CloudStack
> Plugin - Hypervisor VMware .. SKIPPED [INFO] Apache CloudStack SystemVM
> Patches  SKIPPED [INFO] Apache CloudStack Cloud Services
> .. SKIPPED [INFO] Apache CloudStack Console Proxy Service 
> ...
> SKIPPED [INFO] Apache CloudStack Console Proxy Plugin  SKIPPED
> [INFO] Apache CloudStack Console Proxy ... SKIPPED [INFO] 
> Apache
> CloudStack Test  SKIPPED [INFO] Apache CloudStack 
> Client UI
> ... SKIPPED [INFO]
> 
> [INFO] BUILD FAILURE
> [INFO]
> 
> [INFO] Total time: 1:36.937s
> [INFO] Finished at: Sun Mar 24 23:02:58 MDT 2013 [INFO] Final Memory:
> 35M/95M [INFO]
> 
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
> (default-compile) on project cloud-plugin-network-netscaler: Compilation
> failure: Compilation failure:
> [ERROR]
> /Users/mtutkowski/Documents/CloudStack/src/incubator-
> cloudstack/plugins/network-
> elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java:[
> 32,59]
> package com.citrix.netscaler.nitro.resource.config.autoscale does not exist
> [ERROR] /Users/mtutkowski/Documents/CloudStack/src/incubator-
> cloudstack/plugins/network-
> elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java:[
> 33,59]
> package com.citrix.netscaler.nitro.resource.config.autoscale does not exist
> [ERROR] /Users/mtutkowski/Documents/CloudStack/src/incubator-
> cloudstack/plugins/network-
> elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java:[
> 41,52]
> cannot find symbol
> [ERROR] symbol  : class lbmonitor_metric_binding [ERROR] location: package
> com.citrix.netscaler.nitro.resource.config.lb
> [ERROR]
> /Users/mtutkowski/Documents/CloudStack/src/incubator-
> cloudstack/plugins/network-
> elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java:[
> 53,52]
> cannot find symbol
> [ERROR] symbol  : class nstimer
> [ERROR] location: package com.citrix.netscaler.nitro.resource.config.ns
> [ERROR]
> /Users/mtutkowski/Documents/CloudStack/src/incubator-
> cloudstack/plugins/network-
> elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java:[
> 54,52]
> cannot find symbol
> [ERROR] symbol  : class nstimer_autoscalepolicy_binding [ERROR] location:
> package com.citrix.netscaler.nitro.resource.config.ns
> [ERROR]
> /Users/mtutkowski/Documents/CloudStack/src/incubator-
> cloudstack/plugins/network-
> elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java:[
> 1686,30]
> cannot find symbol
> [ERROR] symbol  : method set_monstate(java.lang.String) [ERROR] location:
> class 
> com.citrix.netscaler.nitro.resource.config.basic.service_lbmonitor_binding
> [ERROR]
> /Users/mtutkowski/Documents/CloudStack/src/incubator-
> cloudstack/plugins/network-
> elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java:[
> 1688,90]
> cannot find symbol
> [ERROR] symbol  : method
> add(com.citrix.netscaler.nitro.service.nitro_service,com.citrix.netscaler.nitro.re
> source.config.basic.service_lbmonitor_binding)
> [ERROR] location: class
> com.citrix.netscaler.nitro.resource.config.basic.service_lbmonitor_binding
> [ERRO

[Issue] can't find storage provider: null on latest master while adding nfs as primary storage

[Rajesh Battala]

Hi All,

On the latest master , while adding the nfs location as primary storage, am 
getting error and not able to add the primary storage.

Error is can't find storage provider: null
This is from the storageManagerImpl as it's not able to find the 
DatastoreProvider.

Others also getting the same error or it's me?

Thanks
Rajesh Battala

RE: [Issue] can't find storage provider: null on latest master while adding nfs as primary storage

[Rajesh Battala]

Bug is already raised for the issue 
https://issues.apache.org/jira/browse/CLOUDSTACK-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel#comment-13613548
 

> -Original Message-
> From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> Sent: Tuesday, March 26, 2013 11:22 AM
> To: dev@cloudstack.apache.org
> Subject: [Issue] can't find storage provider: null on latest master while 
> adding nfs
> as primary storage
> 
> Hi All,
> 
> On the latest master , while adding the nfs location as primary storage, am
> getting error and not able to add the primary storage.
> 
> Error is can't find storage provider: null This is from the 
> storageManagerImpl as
> it's not able to find the DatastoreProvider.
> 
> Others also getting the same error or it's me?
> 
> Thanks
> Rajesh Battala

Re: Review Request: Feature Syslog Enhancements

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9870/#review18417
---

Ship it!


Ship It!

- Rajesh Battala


On March 19, 2013, 10:52 a.m., Anshul Gangwar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9870/
> ---
> 
> (Updated March 19, 2013, 10:52 a.m.)
> 
> 
> Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh 
> Chodapuneedi.
> 
> 
> Description
> ---
> 
> This patch implements the Syslog Enhancements in CloudStack. With this 
> feature one can configure log4j-cloud.xml to get the Syslog messages for 
> alerts. This feature is implemented by extending log4j Appeneder. Multiple 
> Syslog Hosts can be specified. To configure multiple Syslog Hosts one needs 
> to modify following portion in log4j-cloud.xml 
> class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
>   
>   
>   
>   
>  
>   
>
> 
> To specify multiple  Syslog Hosts one has to give as follows in above code 
> fragment with each Syslog Hosts separated by ,
> 
> class="org.apache.cloudstack.syslog.AlertsSyslogAppender">
>   
>   
>   
>   
>  
>   
>
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-712.
> 
> 
> Diffs
> -
> 
>   client/pom.xml ecf232b 
>   client/tomcatconf/log4j-cloud.xml.in ce4079f 
>   plugins/alert-handlers/syslog-alerts/pom.xml PRE-CREATION 
>   
> plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java
>  PRE-CREATION 
>   
> plugins/alert-handlers/syslog-alerts/test/org/apache/cloudstack/syslog/AlertsSyslogAppenderTest.java
>  PRE-CREATION 
>   plugins/pom.xml 5d31a72 
> 
> Diff: https://reviews.apache.org/r/9870/diff/
> 
> 
> Testing
> ---
> 
> Units tests for functionality are written and manual testing for syslog 
> message generation for few alerts 
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

RE: Jetty Failing on latest master due to class UCS manager not Found

[Rajesh Battala]

Jetty is failing to start on latest master building oss. 
Am on the latest master, building oss and starting jetty is failing with below 
error. 

Error creating bean with name 'globalLoadBalancingRulesServiceImpl':
Injection of autowired dependencies failed; nested exception is 
org.springframewor  
k.beans.factory.BeanCreationException: Could not autowire field: protected 
org.apache.cloudstack.region.   
   gslb.GslbServiceProvider 
org.apache.cloudstack.region.gslb.GlobalLoadBalancingRulesServiceImpl._gslbProv 
 ider; nested exception 
is org.springframework.beans.factory.NoSuchBeanDefinitionException: No matching 
b  ean of type 
[org.apache.cloudstack.region.gslb.GslbServiceProvider] found for dependency: 
expected at le  ast 1 
bean which qualifies as autowire candidate for this dependency. Dependency 
annotations: {@javax.in 
 ject.Inject()}
at 
org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcess
  
PropertyValues(AutowiredAnnotationBeanPostProcessor.java:287)
at org.springframe



> -Original Message-
> From: Murali Reddy [mailto:murali.re...@citrix.com]
> Sent: Thursday, March 28, 2013 8:24 AM
> To: Chip Childers; Kelven Yang
> Cc: dev@cloudstack.apache.org; cloudstack-...@incubator.apache.org
> Subject: Re: Jetty Failing on latest master due to class UCS manager not Found
> 
> On 28/03/13 7:42 AM, "Chip Childers"  wrote:
> 
> >On Wed, Mar 27, 2013 at 04:31:05PM -0700, Kelven Yang wrote:
> >> For UCS issue, I've put a fix in.
> >>
> >> For GSLB, a work around is to run non-OSS build, hopefully this can
> >>unlock  developers temporarily on master branch
> >
> >Good work-around for now.
> >
> >Murali - This appears to be something that we *all* missed realizing
> >prior to the merge of the GSLB functionality.  Can you sort this out
> >during your day today?
> 
> I was running Non-oss builds, so could not hit this issue. My apologies for 
> the
> breaking OSS build.
> 
> Kelven,
> 
> I am not sure how to fix this issue. If there is no implementing class, why 
> should
> inject fail? I was under impression it will be set to null?
> 
> I have this code in one of the managers in server, but the implementing class 
> for
> GslbServiceProvider is only present in non-oss NetScaler plug-in. If you can
> suggest how to deal with this in Spring auto wiring that would be useful for 
> me
> to quickly fix this.
> 
> @Inject
> protected GslbServiceProvider _gslbProvider;

RE: Jetty Failing on latest master due to class UCS manager not Found

[Rajesh Battala]

Thanks a lot Murali 

> -Original Message-
> From: Murali Reddy [mailto:murali.re...@citrix.com]
> Sent: Thursday, March 28, 2013 9:07 AM
> To: dev@cloudstack.apache.org; Chip Childers; Kelven Yang
> Cc: cloudstack-...@incubator.apache.org
> Subject: Re: Jetty Failing on latest master due to class UCS manager not Found
> 
> On 28/03/13 9:00 AM, "Rajesh Battala"  wrote:
> 
> >Jetty is failing to start on latest master building oss.
> >Am on the latest master, building oss and starting jetty is failing
> >with below error.
> >
> >Error creating bean with name 'globalLoadBalancingRulesServiceImpl':
> >Injection of autowired dependencies failed; nested exception is
> >org.springframewor
> >  k.beans.factory.BeanCreationException: Could not autowire field:
> >protected org.apache.cloudstack.region.
> >   gslb.GslbServiceProvider
> >org.apache.cloudstack.region.gslb.GlobalLoadBalancingRulesServiceImpl._gsl
> >bProv  ider;
> >nested exception is
> >org.springframework.beans.factory.NoSuchBeanDefinitionException: No
> >matching b  ean
> >of type [org.apache.cloudstack.region.gslb.GslbServiceProvider] found
> >for
> >dependency: expected at le
> >  ast 1 bean which qualifies as autowire candidate for this
> >dependency. Dependency annotations: {@javax.in
> >  ject.Inject()}
> >at
> >org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPos
> >tPr
> >ocessor.postProcess
> >   PropertyValues(AutowiredAnnotationBeanPostProcessor.java:287)
> >at org.springframe
> 
> Please pull latest master, I pushed a fix.

Unable to start domR(VR) in devcloud using laster 4.1/master.

[Rajesh Battala]

Hi All,

VR is not getting started failing the instance creation. Anywork around for 
this issue?

[network.router.VirtualNetworkApplianceManagerImpl] (Job-Executor-1:job-8) 
Unable to get the template/scripts version of router r-4-VM due to: 
getDomRVersionCmd failed
INFO  [cloud.vm.VirtualMachineManagerImpl] (Job-Executor-1:job-8) The guru did 
not like the answers so stopping VM[DomainRouter|r-4-VM]
ERROR [cloud.vm.VirtualMachineManagerImpl] (Job-Executor-1:job-8) Failed to 
start instance VM[DomainRouter|r-4-VM]
com.cloud.utils.exception.ExecutionException: Unable to start 
VM[DomainRouter|r-4-VM] due to error in finalizeStart, not retrying
at 
com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:808)
at 
com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:471)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.start(VirtualNetworkApplianceManagerImpl.java:2606)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.startVirtualRouter(VirtualNetworkApplianceManagerImpl.java:1815)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.startRouters(VirtualNetworkApplianceManagerImpl.java:1915)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.deployVirtualRouterInGuestNetwork(VirtualNetworkApplianceManagerImpl.java:1893)
at 
com.cloud.network.element.VirtualRouterElement.prepare(VirtualRouterElement.java:208)
at 
com.cloud.network.NetworkManagerImpl.prepareElement(NetworkManagerImpl.java:1541)
at 
com.cloud.network.NetworkManagerImpl.prepareNic(NetworkManagerImpl.java:1658)
at 
com.cloud.network.NetworkManagerImpl.prepare(NetworkManagerImpl.java:1599)
at 
com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:746)
at 
com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:471)
at 
org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.deployVirtualMachine(VMEntityManagerImpl.java:212)
at 
org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.deploy(VirtualMachineEntityImpl.java:209)
at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3860)
at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3458)
at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3444)
at 
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at 
org.apache.cloudstack.api.command.user.vm.DeployVMCmd.execute(DeployVMCmd.java:379)


Thanks
Rajesh Battala

RE: Apache BarCamp Today at PESIT Bangalore

[Rajesh Battala]

On Twitter with  #ApacheBarCampBLR


> -Original Message-
> From: Radhika Puthiyetath [mailto:radhika.puthiyet...@citrix.com]
> Sent: Saturday, March 30, 2013 9:05 AM
> To: us...@cloudstack.apache.org; 
> Subject: Apache BarCamp Today at PESIT Bangalore
> 
> Gentle Reminder..
> -- Forwarded message --
> From: Nick Burch mailto:n...@apache.org>>
> Date: Wed, Mar 27, 2013 at 11:21 AM
> Subject: Upcoming BarCamps
> To: committ...@apache.org
> 
> 
> Hi All
> 
> Firstly, a couple of upcoming BarCamps for your diary:
> 
> Saturday 30th March (this Saturday!) - Bangalore  Our first event in India! A 
> one
> day Apache BarCamp and Hackathon  http://www.meetup.com/CloudStack-
> Bangalore-Group/events/104410272/
> 
> Saturday 19th May Boston
>  Planning is underway, more volunteers needed to help!
>  http://wiki.apache.org/concom-planning/BarCampBoston2013
> 
> There are also currently plans for another Washington DC event, and a New
> York event, both for the summer/autumn, more details expected in a few
> months.
> 
> We've also had interest in events in Lyon in France, Bucharest in Romania,
> Ljublana in Slovenia, Sydney in Australia, and LA. All of those need more
> volunteers before they can go ahead, so if you live/work in/near those places,
> pipe up on the small events list[1] so we can put you in touch with the 
> potential
> organisers!
> 
> Finally, if nothing near you is listed above, if you can rope in some other
> volunteers to help with an event, we can provide instructions / advice /
> mentoring / funding to help you make an event happen :) Just get in touch on
> small-events-discuss@ [1] and we'll help you get started!
> 
> Nick
> 
> [1] http://mail-archives.apache.org/mod_mbox/www-small-events-discuss/
> 
> 
> 
> --
> Genius is 99% Hardwork and 1% Luck

RE: Unable to start domR(VR) in devcloud using laster 4.1/master.

[Rajesh Battala]

: reserved 0
debug2: mac_setup: found hmac-md5
debug1: kex: server->client aes128-ctr hmac-md5 none
debug2: mac_setup: found hmac-md5
debug1: kex: client->server aes128-ctr hmac-md5 none
debug1: SSH2_MSG_KEX_DH_GEX_REQUEST(1024<1024<8192) sent
debug1: expecting SSH2_MSG_KEX_DH_GEX_GROUP
debug2: dh_gen_key: priv key bits set: 123/256
debug2: bits set: 512/1024
debug1: SSH2_MSG_KEX_DH_GEX_INIT sent
debug1: expecting SSH2_MSG_KEX_DH_GEX_REPLY
debug1: Server host key: RSA 58:de:8b:d7:2b:8e:01:2e:cd:f4:58:86:27:e4:94:39
debug3: put_host_port: [169.254.0.105]:3922
debug3: put_host_port: [169.254.0.105]:3922
debug3: load_hostkeys: loading entries for host "[169.254.0.105]:3922" from 
file "/root/.ssh/known_hosts
  "
debug3: load_hostkeys: found key type RSA in file /root/.ssh/known_hosts:1
debug3: load_hostkeys: loaded 1 keys
debug3: load_hostkeys: loading entries for host "[169.254.0.105]:3922" from 
file "/root/.ssh/known_hosts
  "
debug3: load_hostkeys: found key type RSA in file /root/.ssh/known_hosts:1
debug3: load_hostkeys: loaded 1 keys
debug1: Host '[169.254.0.105]:3922' is known and matches the RSA host key.
debug1: Found key in /root/.ssh/known_hosts:1
debug2: bits set: 510/1024
debug1: ssh_rsa_verify: signature correct
debug2: kex_derive_keys
debug2: set_newkeys: mode 1
debug1: SSH2_MSG_NEWKEYS sent
debug1: expecting SSH2_MSG_NEWKEYS
debug2: set_newkeys: mode 0
debug1: SSH2_MSG_NEWKEYS received
debug1: Roaming not allowed by server
debug1: SSH2_MSG_SERVICE_REQUEST sent
debug2: service_accept: ssh-userauth
debug1: SSH2_MSG_SERVICE_ACCEPT received
debug2: key: .ssh/id_rsa.cloud (0xb89fff78)
debug1: Authentications that can continue: publickey
debug3: start over, passed a different list publickey
debug3: preferred 
gssapi-keyex,gssapi-with-mic,publickey,keyboard-interactive,password
debug3: authmethod_lookup publickey
debug3: remaining preferred: keyboard-interactive,password
debug3: authmethod_is_enabled publickey
debug1: Next authentication method: publickey
debug1: Offering RSA public key: .ssh/id_rsa.cloud
debug3: send_pubkey_test
debug2: we sent a publickey packet, wait for reply
debug1: Authentications that can continue: publickey
debug2: we did not send a packet, disable method
debug1: No more authentication methods to try.
Permission denied (publickey).





> -Original Message-
> From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
> Sent: Saturday, March 30, 2013 2:07 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Unable to start domR(VR) in devcloud using laster 4.1/master.
> 
> You should roll back your devcloud VM to the original and try again.
> 
> On DevCloud2, I notice that sometimes the xapi0 bridge loses its ip address 
> and
> hence loses the 169.254.0.0/16 route.
> You can work around this by
> ifconfig xapi0 (check for ipv4 address)
> ip route show (check for 169.254 route)
> 
> If these are missing
> 
> ifconfig xapi0 169.254.169.254 netmask 255.255.0.0 ip route show
> 
> 
> On 3/29/13 1:06 PM, "Marcus Sorensen"  wrote:
> 
> >Xen? KVM?
> >
> >Generally GetDomRVersionCmd failing is only a symptom, it usually means
> >that cloudstack was never able to communicate with the system vm. You
> >would need to look at whether the VM actually started on the host, and
> >some of the text around when the VM was deployed to get any meaningful
> >errors.  Sometimes this happens when there are bugs around updating the
> >SSH keys, or if the filesystem is corrupt on the system vm.
> >
> >
> >On Fri, Mar 29, 2013 at 1:40 PM, Rajesh Battala
> > wrote:
> >> Hi All,
> >>
> >> VR is not getting started failing the instance creation. Anywork
> >>around for this issue?
> >>
> >> [network.router.VirtualNetworkApplianceManagerImpl]
> >>(Job-Executor-1:job-8) Unable to get the template/scripts version of
> >>router r-4-VM due to: getDomRVersionCmd failed  INFO
> >>[cloud.vm.VirtualMachineManagerImpl] (Job-Executor-1:job-8) The guru
> >>did not like the answers so stopping VM[DomainRouter|r-4-VM]  ERROR
> >>[cloud.vm.VirtualMachineManagerImpl] (Job-Executor-1:job-8) Failed to
> >>start instance VM[DomainRouter|r-4-VM]
> >> com.cloud.utils.exception.ExecutionException: Unable to start
> >>VM[DomainRouter|r-4-VM] due to error in finalizeStart, not retrying
> >> at
> >>com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineMan
> a
> >>ger
> >>Impl.java:808)
> >> at
> >>com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachin