Re: [iOS] Feature change - updates in config.xml
Found it: https://github.com/apache/cordova-lib/blob/3654a11abc51ab3aead47a9c02ebc135424777b1/cordova-lib/src/cordova/util.js#L43 On Tue, Aug 30, 2016 at 7:24 PM, Shazron wrote: > Filed https://github.com/apache/cordova-ios/pull/246 > > I'm not sure if I should be hardcoding `cordova` in there. How do we > dynamically get the CLI tool name? > > On Mon, Aug 29, 2016 at 1:57 AM, julio cesar sanchez < > jcesarmob...@gmail.com> wrote: > >> +1 >> >> 2016-08-29 10:51 GMT+02:00 Shazron : >> >> > Due to lazy consensus, I will proceed with this change. >> > >> > On Thu, Aug 25, 2016 at 12:26 PM, Kerri Shotts >> > wrote: >> > >> > > +1; totally fine with this. :-) >> > > >> > > ~ Kerri >> > > >> > > > On Aug 24, 2016, at 20:30, Shazron wrote: >> > > > >> > > > More details and discussion in: >> > > > https://issues.apache.org/jira/browse/CB-11712 >> > > > >> > > > In brief, the proposed change is: >> > > > changes in config.xml will not be allowed, and cordova will >> > print >> > > an >> > > > error, with instructions on what to do instead. The instructions >> will >> > > tell >> > > > the user to do a `cordova platform rm ios` then a `cordova platform >> add >> > > > ios`. This should be pretty quick since we cache platforms. >> > > > >> > > > Before hitting "Reply" to this email with your comment, check out >> the >> > > issue >> > > > where we discuss this in length. >> > > >> > > >> > >> > >
Re: [iOS] Feature change - updates in config.xml
Filed https://github.com/apache/cordova-ios/pull/246 I'm not sure if I should be hardcoding `cordova` in there. How do we dynamically get the CLI tool name? On Mon, Aug 29, 2016 at 1:57 AM, julio cesar sanchez wrote: > +1 > > 2016-08-29 10:51 GMT+02:00 Shazron : > > > Due to lazy consensus, I will proceed with this change. > > > > On Thu, Aug 25, 2016 at 12:26 PM, Kerri Shotts > > wrote: > > > > > +1; totally fine with this. :-) > > > > > > ~ Kerri > > > > > > > On Aug 24, 2016, at 20:30, Shazron wrote: > > > > > > > > More details and discussion in: > > > > https://issues.apache.org/jira/browse/CB-11712 > > > > > > > > In brief, the proposed change is: > > > > changes in config.xml will not be allowed, and cordova will > > print > > > an > > > > error, with instructions on what to do instead. The instructions will > > > tell > > > > the user to do a `cordova platform rm ios` then a `cordova platform > add > > > > ios`. This should be pretty quick since we cache platforms. > > > > > > > > Before hitting "Reply" to this email with your comment, check out the > > > issue > > > > where we discuss this in length. > > > > > > > > >
Re: [iOS] Feature change - updates in config.xml
+1 2016-08-29 10:51 GMT+02:00 Shazron : > Due to lazy consensus, I will proceed with this change. > > On Thu, Aug 25, 2016 at 12:26 PM, Kerri Shotts > wrote: > > > +1; totally fine with this. :-) > > > > ~ Kerri > > > > > On Aug 24, 2016, at 20:30, Shazron wrote: > > > > > > More details and discussion in: > > > https://issues.apache.org/jira/browse/CB-11712 > > > > > > In brief, the proposed change is: > > > changes in config.xml will not be allowed, and cordova will > print > > an > > > error, with instructions on what to do instead. The instructions will > > tell > > > the user to do a `cordova platform rm ios` then a `cordova platform add > > > ios`. This should be pretty quick since we cache platforms. > > > > > > Before hitting "Reply" to this email with your comment, check out the > > issue > > > where we discuss this in length. > > > > >
Re: [iOS] Feature change - updates in config.xml
Due to lazy consensus, I will proceed with this change. On Thu, Aug 25, 2016 at 12:26 PM, Kerri Shotts wrote: > +1; totally fine with this. :-) > > ~ Kerri > > > On Aug 24, 2016, at 20:30, Shazron wrote: > > > > More details and discussion in: > > https://issues.apache.org/jira/browse/CB-11712 > > > > In brief, the proposed change is: > > changes in config.xml will not be allowed, and cordova will print > an > > error, with instructions on what to do instead. The instructions will > tell > > the user to do a `cordova platform rm ios` then a `cordova platform add > > ios`. This should be pretty quick since we cache platforms. > > > > Before hitting "Reply" to this email with your comment, check out the > issue > > where we discuss this in length. > >
Re: [iOS] Feature change - updates in config.xml
+1; totally fine with this. :-) ~ Kerri > On Aug 24, 2016, at 20:30, Shazron wrote: > > More details and discussion in: > https://issues.apache.org/jira/browse/CB-11712 > > In brief, the proposed change is: > changes in config.xml will not be allowed, and cordova will print an > error, with instructions on what to do instead. The instructions will tell > the user to do a `cordova platform rm ios` then a `cordova platform add > ios`. This should be pretty quick since we cache platforms. > > Before hitting "Reply" to this email with your comment, check out the issue > where we discuss this in length.
[iOS] Feature change - updates in config.xml
More details and discussion in: https://issues.apache.org/jira/browse/CB-11712 In brief, the proposed change is: changes in config.xml will not be allowed, and cordova will print an error, with instructions on what to do instead. The instructions will tell the user to do a `cordova platform rm ios` then a `cordova platform add ios`. This should be pretty quick since we cache platforms. Before hitting "Reply" to this email with your comment, check out the issue where we discuss this in length.
