Re: [DISCUSS] Flink dist directory management

2017-03-26 Thread 伍翀(云邪)
Hi Jinkui,

Thanks for bringing up this discussion. I??m +1 to moving table-examples and 
belly-examples into "examples/?? to keep ??opt?? clean.

Best,
Jark Wu 

> ?? 2017??3??253:46??shijinkui  ??
> 
> Hi, all
> 
> The Flink distribution?0?1?0?4s directory have no very clear responsibility 
> about what type of files should be in which directory.
> 
> The "bin","conf","lib" directories are clear for their responsibility.
> 
> But the ?0?1??opt" directories are mixed with library jars and example jars.
> 
> I think we can discuss how is reasonable for the directory. Once we 
> determined, we should follow it.
> 
> IMO, directory style below is reasonable:
> 
> - "examples" directory only contain example jars
> - "opt" directory only contain optional library jars in runtime
> - "lib" directory only contain library jar that must be loaded at runtime
> - ?0?1??resources?0?1?0?2 directory only contain resource file used at 
> runtime, such as web file
> 
> Show your opinion please.
> 
> @wuchong, @fhueske @Fabian
> 
> Best regards,
> Jinkui Shi
> 
> 
> .
> ?0?7?0?8?0?7???0?7?? LICENSE
> ?0?7?0?8?0?7???0?7?? NOTICE
> ?0?7?0?8?0?7???0?7?? README.txt
> ?0?7?0?8?0?7???0?7?? bin
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? config.sh
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? ...
> ?0?7?0?8?0?7???0?7?? conf
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-conf.yaml
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? ...
> ?0?7?0?8?0?7???0?7?? examples
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? batch
> ?0?7?0?3   ?0?7?0?0?0?7???0?7?? streaming
> ?0?7?0?8?0?7???0?7?? lib
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-dist_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-python_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? ...
> ?0?7?0?8?0?7???0?7?? log
> ?0?7?0?8?0?7???0?7?? opt
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-cep-scala_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-cep_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-gelly-examples_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-gelly-scala_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-gelly_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-metrics-dropwizard-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-metrics-ganglia-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-metrics-graphite-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-metrics-statsd-1.3.0.jar
> ?0?7?0?3   ?0?7?0?0?0?7???0?7?? flink-ml_2.11-1.3.0.jar
> ?0?7?0?8?0?7???0?7?? resources
> ?0?7?0?3   ?0?7?0?0?0?7???0?7?? python
> ?0?7?0?0?0?7???0?7?? tools
>?0?7?0?0?0?7???0?7?? planVisualizer.html
> 
> 
> [1] https://github.com/apache/flink/pull/2460
> 



Re: [DISCUSS] TravisCI auto cancellation

2017-03-26 Thread Ted Yu
+1 to Greg's suggestion.

On Sun, Mar 26, 2017 at 2:22 PM, Greg Hogan  wrote:

> Hi,
>
> Just saw this TravisCI beta feature. I think this would be worthwhile to
> enable on pull request builds. We could leave branch builds unchanged since
> there are fewer builds of this type and skipping builds would make it
> harder to locate a broken build. It’s not uncommon to see three or more
> builds queued for the same PR and developers cannot cancel builds on the
> project account.
>   https://blog.travis-ci.com/2017-03-22-introducing-auto-cancellation
>
> I’ve enabled this against my personal repo but I believe Apache
> Infrastructure would need to make the change for the project repo. Flink
> has been the biggest user of Apache’s TravisCI build pool.
>
> Greg


[DISCUSS] TravisCI auto cancellation

2017-03-26 Thread Greg Hogan
Hi,

Just saw this TravisCI beta feature. I think this would be worthwhile to enable 
on pull request builds. We could leave branch builds unchanged since there are 
fewer builds of this type and skipping builds would make it harder to locate a 
broken build. It’s not uncommon to see three or more builds queued for the same 
PR and developers cannot cancel builds on the project account.
  https://blog.travis-ci.com/2017-03-22-introducing-auto-cancellation

I’ve enabled this against my personal repo but I believe Apache Infrastructure 
would need to make the change for the project repo. Flink has been the biggest 
user of Apache’s TravisCI build pool.

Greg

Re: [VOTE] Release Apache Flink 1.2.1 (RC1)

2017-03-26 Thread Aljoscha Krettek
I opened a PR for FLINK-6188: https://github.com/apache/flink/pull/3616 


This improves the previously very sparse test coverage for timestamp/watermark 
assigners and fixes the bug.

> On 25 Mar 2017, at 10:22, Ufuk Celebi  wrote:
> 
> I agree with Aljoscha.
> 
> -1 because of FLINK-6188
> 
> 
> On Sat, Mar 25, 2017 at 9:38 AM, Aljoscha Krettek  wrote:
>> I filed this issue, which was observed by a user: 
>> https://issues.apache.org/jira/browse/FLINK-6188
>> 
>> I think that’s blocking for 1.2.1.
>> 
>>> On 24 Mar 2017, at 18:57, Ufuk Celebi  wrote:
>>> 
>>> RC1 doesn't contain Stefan's backport for the Asynchronous snapshots
>>> for heap-based keyed state that has been merged. Should we create RC2
>>> with that fix since the voting period only starts on Monday? I think
>>> it would only mean rerunning the scripts on your side, right?
>>> 
>>> – Ufuk
>>> 
>>> 
>>> On Fri, Mar 24, 2017 at 3:05 PM, Robert Metzger  wrote:
 Dear Flink community,
 
 Please vote on releasing the following candidate as Apache Flink version 
 1.2
 .1.
 
 The commit to be voted on:
 *732e55bd* (*http://git-wip-us.apache.org/repos/asf/flink/commit/732e55bd
 *)
 
 Branch:
 release-1.2.1-rc1
 
 The release artifacts to be voted on can be found at:
 *http://people.apache.org/~rmetzger/flink-1.2.1-rc1/
 *
 
 The release artifacts are signed with the key with fingerprint D9839159:
 http://www.apache.org/dist/flink/KEYS
 
 The staging repository for this release can be found at:
 https://repository.apache.org/content/repositories/orgapacheflink-1116
 
 -
 
 
 The vote ends on Wednesday, March 29, 2017, 3pm CET.
 
 
 [ ] +1 Release this package as Apache Flink 1.2.1
 [ ] -1 Do not release this package, because ...
>>