mod_wombat and mod_lua
Brian, Bertrand, and others are using (variations on in many cases) mod_wombat right now, pulling it into trunk is good in the long term, but it leaves some folks hanging. I'm thinking we should maintain the mod_wombat tree as an external backport to 2.2. It can use Brian's thread scope approach (thugh I actually want to change it to add the pool still, and backport all the rest of the trunk changes), and keep the apreq2 dependency, for example. Thoughts?
Re: mod_wombat and mod_lua
Brian McCallister wrote: Brian, Bertrand, and others are using (variations on in many cases) mod_wombat right now, pulling it into trunk is good in the long term, but it leaves some folks hanging. I'm thinking we should maintain the mod_wombat tree as an external backport to 2.2. It can use Brian's thread scope approach (thugh I actually want to change it to add the pool still, and backport all the rest of the trunk changes), and keep the apreq2 dependency, for example. I guess if people are using it, but personally I'd rather sort out the lack of apreq in trunk (pulling in the parts that make sense to httpd trunk), an try to shape it up rather than spending time on two branches with diverging code If we really want an external usable version, what I would recommend is put a few ifdefs in, and try to make the version in httpd trunk buildable with 2.2.x rather than using the mod_wombat sources. -Paul
Re: mod_wombat and mod_lua
On Wed, Feb 25, 2009 at 9:37 AM, Paul Querna wrote: > I guess if people are using it, but personally I'd rather sort out the lack > of apreq in trunk (pulling in the parts that make sense to httpd trunk), an > try to shape it up rather than spending time on two branches with diverging > code > > If we really want an external usable version, what I would recommend is put > a few ifdefs in, and try to make the version in httpd trunk buildable with > 2.2.x rather than using the mod_wombat sources. That works for me as well, though building it is trickier then as all the autoconf-amarole has been moved out.
Re: mod_wombat and mod_lua
On Wed, Feb 25, 2009 at 6:37 PM, Paul Querna wrote: > Brian McCallister wrote: >> >> Brian, Bertrand, and others are using (variations on in many cases) >> mod_wombat right now, pulling it into trunk is good in the long term, >> but it leaves some folks hanging. >> >> I'm thinking we should maintain the mod_wombat tree as an external >> backport to 2.2. It can use Brian's thread scope approach (thugh I >> actually want to change it to add the pool still, and backport all the >> rest of the trunk changes), and keep the apreq2 dependency, for >> example. > > I guess if people are using it, but personally I'd rather sort out the lack > of apreq in trunk (pulling in the parts that make sense to httpd trunk), an > try to shape it up rather than spending time on two branches with diverging > code How would you do that ? I am a novice so I can only imagine, maybe a new module in APR-Util ? Will it have to handle file uploads and creation of temporary files, and is there already some functions in APR that can help ? Did you think of an API ? Apreq2 does a bit too much IMO. -- Bertrand Mansion Mamasam
Re: mod_wombat and mod_lua
On 2/25/09 11:23 AM, "Brian McCallister" wrote: >It can use Brian's thread scope approach (thugh I > actually want to change it to add the pool still, and backport all the > rest of the trunk changes), I was thinking about this, and I think having "direct" access to the theead from request_rec is not needed. If we manage the array of pools from within mod_lua, then you can just handle it there. This array only needs to get created if we have "thread/server" scoped vm's. My horrible patch I submitted a while back did it that way. Also, does the idea of a vm_spec still make sense? I'd really like a buildable version for 2.2. FWIW, we hacked up several modules to add Lua support to them and I'd like to port these to the "official" mod_lua if possible, as we are using our hacked (well, now completely rewritten) version of mod_wombat. We have memcache, geoip, and some of or internal modules all with lua support now. Usually the lua "glue" code is less than 100 lines of C. I wish we could have a hackathon. We could knock out a bunch of this things in one sitting, I think. -- Brian Akins
Re: mod_wombat and mod_lua
Brian Akins wrote: > On 2/25/09 11:23 AM, "Brian McCallister" wrote: >> It can use Brian's thread scope approach (thugh I >> actually want to change it to add the pool still, and backport all the >> rest of the trunk changes), > > I was thinking about this, and I think having "direct" access to the theead > from request_rec is not needed. If we manage the array of pools from within > mod_lua, then you can just handle it there. This array only needs to get > created if we have "thread/server" scoped vm's. My horrible patch I > submitted a while back did it that way. > > Also, does the idea of a vm_spec still make sense? > > I'd really like a buildable version for 2.2. > > FWIW, we hacked up several modules to add Lua support to them and I'd like > to port these to the "official" mod_lua if possible, as we are using our > hacked (well, now completely rewritten) version of mod_wombat. We have > memcache, geoip, and some of or internal modules all with lua support now. > Usually the lua "glue" code is less than 100 lines of C. > > I wish we could have a hackathon. We could knock out a bunch of this things > in one sitting, I think. 23-27 March 2009, Amsterdam: http://www.eu.apachecon.com/c/aceu2009/ I'll be there at least -Paul
Re: mod_wombat and mod_lua
On Wed, Feb 25, 2009 at 5:50 PM, Paul Querna wrote: > 23-27 March 2009, Amsterdam: > http://www.eu.apachecon.com/c/aceu2009/ > > I'll be there at least Ditto. -- justin
Re: mod_wombat and mod_lua
Justin Erenkrantz wrote: On Wed, Feb 25, 2009 at 5:50 PM, Paul Querna wrote: 23-27 March 2009, Amsterdam: http://www.eu.apachecon.com/c/aceu2009/ I'll be there at least Ditto. -- justin Same here. Except for a drop-in appearance at Jim and Rich's training, I even expect to be hacking on httpd for this time, maybe some apr.
Re: mod_wombat and mod_lua
On Fri, Feb 27, 2009 at 11:16 AM, Justin Erenkrantz wrote: > On Wed, Feb 25, 2009 at 5:50 PM, Paul Querna wrote: > > 23-27 March 2009, Amsterdam: > > http://www.eu.apachecon.com/c/aceu2009/ > > > > I'll be there at least > > Ditto. -- justin > Hoping to be...
Re: mod_wombat and mod_lua
Wish i could be, but urgent family business will keep me away :-( Maybe virtually joining :-) On Fri, Feb 27, 2009 at 11:50 AM, Jeff Trawick wrote: > On Fri, Feb 27, 2009 at 11:16 AM, Justin Erenkrantz > wrote: >> >> On Wed, Feb 25, 2009 at 5:50 PM, Paul Querna wrote: >> > 23-27 March 2009, Amsterdam: >> > http://www.eu.apachecon.com/c/aceu2009/ >> > >> > I'll be there at least >> >> Ditto. -- justin > > Hoping to be... > >
Re: mod_wombat and mod_lua
I will be there too, but I probably won't be able to help much because my knowledge of Apache is too limited at the moment. Still, it will be a pleasure to meet you. And maybe I can write the unit tests in Lua :) On Fri, Feb 27, 2009 at 8:56 PM, Brian McCallister wrote: > Wish i could be, but urgent family business will keep me away :-( > > Maybe virtually joining :-) > > On Fri, Feb 27, 2009 at 11:50 AM, Jeff Trawick wrote: >> On Fri, Feb 27, 2009 at 11:16 AM, Justin Erenkrantz >> wrote: >>> >>> On Wed, Feb 25, 2009 at 5:50 PM, Paul Querna wrote: >>> > 23-27 March 2009, Amsterdam: >>> > http://www.eu.apachecon.com/c/aceu2009/ >>> > >>> > I'll be there at least >>> >>> Ditto. -- justin >> >> Hoping to be... >> >> > -- Bertrand Mansion Mamasam
Re: mod_wombat and mod_lua
On Fri, Feb 27, 2009 at 2:11 PM, Bertrand Mansion wrote: > I will be there too, but I probably won't be able to help much because > my knowledge of Apache is too limited at the moment. Still, it will be > a pleasure to meet you. And maybe I can write the unit tests in Lua :) Don't underestimate yourself, mod_wombat got started because I pestered Paul to help me learn how to write apache modules at an apachecon! > > On Fri, Feb 27, 2009 at 8:56 PM, Brian McCallister wrote: >> Wish i could be, but urgent family business will keep me away :-( >> >> Maybe virtually joining :-) >> >> On Fri, Feb 27, 2009 at 11:50 AM, Jeff Trawick wrote: >>> On Fri, Feb 27, 2009 at 11:16 AM, Justin Erenkrantz >>> wrote: On Wed, Feb 25, 2009 at 5:50 PM, Paul Querna wrote: > 23-27 March 2009, Amsterdam: > http://www.eu.apachecon.com/c/aceu2009/ > > I'll be there at least Ditto. -- justin >>> >>> Hoping to be... >>> >>> >> > > > > -- > Bertrand Mansion > Mamasam >
Re: mod_wombat and mod_lua
On 2/27/09 2:56 PM, "Brian McCallister" wrote: > Maybe virtually joining :-) It maybe interesting to have a "virtual" extension to the hackathon. IRC is good, but misses a lot of "discussion" I think. Some actual voice interaction would be nice. I've see you all before, so I don't really want video :P Thoughts? I'd really like to get mod_lua "standardized," fast, and in 2.2, if possible (or get 2.4 out very soon). Willing to help, just let me know how. --Brian