[GitHub] kafka pull request #2449: KAFKA-4557: Handle Producer.send correctly in expi...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2449 KAFKA-4557: Handle Producer.send correctly in expiry callbacks When iterating deque for expiring record batches, delay the actual completion of the batch until iteration is complete since callbacks invoked during expiry may send more records, modifying the deque, resulting in ConcurrentModificationException in the iterator. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4557 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2449.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2449 commit dae191b0dc14bed39b8f77589c74a2394ed4ea48 Author: Rajini Sivaram Date: 2017-01-26T16:23:49Z KAFKA-4557: Handle Producer.send correctly in expiry callbacks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2546: KAFKA-4764: Improve diagnostics for SASL auth fail...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2546 KAFKA-4764: Improve diagnostics for SASL auth failures First step towards improving handling of client SASL authentication failures. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4764 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2546.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2546 commit 643384757ec3364f2f3f5efcd3520a9d1e6f91de Author: Rajini Sivaram Date: 2017-02-14T13:48:22Z KAFKA-4764: Improve diagnostics for SASL auth failures --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2586: KAFKA-4786: Wait for heartbeat thread to terminate...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2586 KAFKA-4786: Wait for heartbeat thread to terminate in consumer close You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4786 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2586.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2586 commit 01a9bc2819ea9f4949ea2baa7ab46b6c5708424f Author: Rajini Sivaram Date: 2017-02-22T15:40:19Z KAFKA-4786: Wait for heartbeat thread to terminate in consumer close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2589: KAFKA-4779: Fix security upgrade system test to be...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2589 KAFKA-4779: Fix security upgrade system test to be non-disruptive The phase_two security upgrade test verifies upgrading inter-broker and client protocols to the same value as well as different values. The second case currently changes inter-broker protocol without first enabling the protocol, disrupting produce/consume until the whole cluster is updated. This commit changes the test to be a non-disruptive upgrade test that enables protocols first (simulating phase one of upgrade). You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4779 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2589.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2589 commit 71aa4c4fa8035695ac460797b84a6754576dc99f Author: Rajini Sivaram Date: 2017-02-23T14:57:45Z KAFKA-4779: Fix security upgrade system test to be non-disruptive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2608: KAFKA-4779: Request metadata in consumer if partit...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2608 KAFKA-4779: Request metadata in consumer if partitions unavailable If leader node of one more more partitions in a consumer subscription are temporarily unavailable, request metadata refresh so that partitions skipped for assignment dont have to wait for metadata expiry before reassignment. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4779-consumer-metadata Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2608.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2608 commit af5ef2b98314653de5ae098e8c45eb84b81685e7 Author: Rajini Sivaram Date: 2017-02-28T12:09:44Z KAFKA-4779: Request metadata in consumer if partitions unavailable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2608: KAFKA-4779: Request metadata in consumer if partit...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/2608 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2622: KAFKA-4631: Request metadata in consumer if topic/...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2622 KAFKA-4631: Request metadata in consumer if topic/partitions unavailable If leader node of one more more partitions in a consumer subscription are temporarily unavailable, request metadata refresh so that partitions skipped for assignment dont have to wait for metadata expiry before reassignment. Metadata refresh is also requested if a subscribe topic or assigned partition doesn't exist. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4631 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2622.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2622 commit 406427953b2789e5a717136bac6b0b3ada5eb9eb Author: Rajini Sivaram Date: 2017-02-28T12:09:44Z KAFKA-4631: Request metadata in consumer if topic/partitions unavailable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3766: MINOR: Test SASL authorization id
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3766 MINOR: Test SASL authorization id You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-sasl Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3766.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3766 commit 3129af7ad9c4892934baee209bbf697eab69f030 Author: Rajini Sivaram Date: 2017-08-16T20:47:16Z MINOR: Test SASL authorization id --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3773: MINOR: Fix unit test failures from last commit, ch...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3773 MINOR: Fix unit test failures from last commit, cherry-pick fix for SASL principal You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-0.10.2-buildfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3773.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3773 commit 63ca7932727b704eb2f9f52fdc1241c8c7238aa2 Author: Rajini Sivaram Date: 2017-08-31T19:07:15Z MINOR: Fix unit test failures from last commit and checkstyle fixes commit c022fde8c37fcadcbc004f4618bfd61af3a87d4e Author: Rajini Sivaram Date: 2017-06-06T02:43:07Z KAFKA-5325; Avoid and handle exceptions for Kerberos re-login If producer creates a connection during Kerberos re-login (after logout, before login), there are no principals in the subject and `SaslClientAuthenticator.configure` may throw an exception while trying to determine the principal. A socket channel is created and its key registered with the selector, but the `RuntimeException` thrown leaves the key registered with the selector without adding the channel to the channel list. This results in an infinite loop of `NullPointerExceptions`. The PR applies two fixes: 1. Convert the `RuntimeException` to a meaningful `KafkaException` 2. Handle any exception in `buildChannel`, cleanup and throw `IOException`. Retries will take care of re-connections. Author: Rajini Sivaram Reviewers: Jun Rao , Ismael Juma Closes #3208 from rajinisivaram/KAFKA-5325 (cherry picked from commit 9934d28a34351a63738f8e9bac6b53fd699a4905) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3773: MINOR: Fix unit test failures from last commit, ch...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/3773 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3792: KAFKA-5837: Set defaults for ReassignPartitionsCom...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3792 KAFKA-5837: Set defaults for ReassignPartitionsCommand correctly You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5837 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3792.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3792 commit ea852fc052bcb1bcabde249a315c006e7ef16d27 Author: Rajini Sivaram Date: 2017-09-05T15:51:32Z KAFKA-5837: Set defaults for ReassignPartitionsCommand correctly ---
[GitHub] kafka pull request #3823: MINOR: Fix transient failure in SelectorTest.testC...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3823 MINOR: Fix transient failure in SelectorTest.testCloseConnectionInClosingState `SelectorTest.testCloseConnectionInClosingState` creates a channel with some staging receives and moves time forward to expire the channel. To ensure that the channel will be expired on the next poll, the channel must be muted to avoid expiry time being updated if more data is available for read. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-SelectorTest-closingChannel Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3823.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3823 commit 9f35f260f4fe12e0e9254363386732c19c06bb4c Author: Rajini Sivaram Date: 2017-09-10T17:27:32Z MINOR: Fix transient failure in SelectorTest ---
[GitHub] kafka pull request #3836: KAFKA-5872: Fix transient failure in SslSelectorTe...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3836 KAFKA-5872: Fix transient failure in SslSelectorTest.testMuteOnOOM You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5872-sslselectortest-failure Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3836.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3836 commit 68d0b6383782d79780e84d1806b1718d0f791f41 Author: Rajini Sivaram Date: 2017-09-12T09:09:20Z KAFKA-5872: Fix transient failure in SslSelectorTest.testMuteOnOOM ---
[GitHub] kafka pull request #2546: KAFKA-4764: Improve diagnostics for SASL auth fail...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/2546 ---
[GitHub] kafka pull request #3882: MINOR: Add metric templates for sender/fetcher rat...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3882 MINOR: Add metric templates for sender/fetcher rate totals You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-KAFKA-5738-metricstemplates Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3882.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3882 commit ac71252bf4a905df0a92e131eddca3024527ab9c Author: Rajini Sivaram Date: 2017-09-17T16:14:48Z MINOR: Add metric templates for sender/fetcher rate totals ---
[GitHub] kafka pull request #3918: KAFKA-5920: Handle SSL handshake failures as authe...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3918 KAFKA-5920: Handle SSL handshake failures as authentication exceptions You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5920-SSL-handshake-failure Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3918.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3918 commit baada6c9c7ddf85ec00bd5bf23b464ed79571283 Author: Rajini Sivaram Date: 2017-09-18T22:06:48Z KAFKA-5920: Handle SSL handshake failures as authentication exceptions ---
[GitHub] kafka pull request #3922: Kafka 5854: Handle authentication failures in Kafk...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3922 Kafka 5854: Handle authentication failures in KafkaAdminClient This is currently on top of the commits from #3832. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5854-adminclient Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3922.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3922 commit f5878201303f4bb43a5b20f7abdef6f5a9af8fc1 Author: Vahid Hashemian Date: 2017-09-15T17:50:41Z KAFKA-5854: Handle SASL authentication failures as non-retriable exceptions in clients This PR implements the client-side of KIP-152, by modifying `KafkaConsumer`, `KafkaProducer`, and `ConsumerGroupCommand` to throw a non-retriable exception when user authentication fails. This PR is co-authored with @rajinisivaram. commit a16a794f5ae06572d1434943f2765fa0f942bfa2 Author: Vahid Hashemian Date: 2017-09-18T20:57:33Z Addressed feedback on the initial commit. Thanks to @rajinisivaram for the review and sharing some of the code to speed things up. commit 5388b916fd94889ad0c8e7068bb61946e20ccd19 Author: Vahid Hashemian Date: 2017-09-19T19:00:47Z Addressed additional feedback received commit a6e67a7e89e1437cdf8d44b73e28ecb2cd959c1f Author: Vahid Hashemian Date: 2017-09-20T01:36:47Z Minor changes based on the feedback received commit d19874a06a98264f021d4af4a70326865657b8b3 Author: Vahid Hashemian Date: 2017-09-20T01:43:53Z Merge branch 'trunk' into KAFKA-5854 commit a89fe929776b39e4c27d8c8aee7c4630e115a398 Author: Rajini Sivaram Date: 2017-09-20T15:27:23Z KAFKA-5854: Handle authentication exceptions in KafkaAdminClient ---
[GitHub] kafka pull request #3922: Kafka 5854: Handle authentication failures in Kafk...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/3922 ---
[GitHub] kafka pull request #3928: KAFKA-5947: Handle authentication failure in admin...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3928 KAFKA-5947: Handle authentication failure in admin client, txn producer 1. Raise AuthenticationException for authentication failures in admin client 2. Handle AuthenticationException as a fatal error for transactional producer 3. Add comments to authentication exceptions You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5947-auth-failure Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3928.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3928 commit 764f38785f83a95f840c398c9ef2f557e67fe07a Author: Rajini Sivaram Date: 2017-09-20T15:27:23Z KAFKA-5947: Handle authentication exceptions in admin client and txn producer ---
[GitHub] kafka pull request #2165: KAFKA-4440: Make producer RecordMetadata non-final
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/2165 ---
[GitHub] kafka pull request #3956: KAFKA-5970: Avoid locking group in operations that...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3956 KAFKA-5970: Avoid locking group in operations that lock DelayedProduce You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5970-delayedproduce-deadlock Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3956.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3956 commit 27238fe16a31bad09cc82785a7bb62d347f2c7ac Author: Rajini Sivaram Date: 2017-09-25T11:40:28Z KAFKA-5970: Avoid locking group in operations that lock DelayedProduce ---
[GitHub] kafka pull request #3991: KAFKA-5968: Create/remove request metrics during b...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3991 KAFKA-5968: Create/remove request metrics during broker startup/shutdown Replaces the static `RequestMetrics` object with a class so that metrics are created and removed during broker startup and shutdown to avoid metrics tests being affected by metrics left behind by previous tests. Also reinstates `kafka.api.MetricsTest` which was failing frequently earlier due to tests removing the static request metrics. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5968 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3991.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3991 commit ee50940631bc387223045a21a1ded689e15852fb Author: Rajini Sivaram Date: 2017-09-29T10:27:22Z KAFKA-5968: Create/remove request metrics during broker startup/shutdown ---
[GitHub] kafka pull request #4013: KAFKA-4764: Upgrade notes for authentication failu...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4013 KAFKA-4764: Upgrade notes for authentication failure handling (KIP-152) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-upgrade-auth-failure Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4013.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4013 commit 6e4630515162aa058a2856f1efd4118a0f834c3f Author: Rajini Sivaram Date: 2017-10-04T11:51:25Z KAFKA-4764: Upgrade notes for authentication failure handling (KIP-152) ---
[GitHub] kafka pull request #4014: KAFKA-5738: Upgrade note for cumulative count metr...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4014 KAFKA-5738: Upgrade note for cumulative count metric (KIP-187) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-upgrade-KIP-187 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4014.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4014 commit 146a05fce547c559602799b81188793ed749d7a8 Author: Rajini Sivaram Date: 2017-10-04T12:54:46Z KAFKA-5738: Upgrade note for cumulative count metric (KIP-187) ---
[GitHub] kafka pull request #4015: KAFKA-6004: Allow authentication providers to over...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4015 KAFKA-6004: Allow authentication providers to override error message You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-6004-auth-exception Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4015.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4015 commit 8cbbbae3f3da625856db27b2fdf4004c9980931e Author: Rajini Sivaram Date: 2017-10-04T13:27:30Z KAFKA-6004: Allow authentication providers to override error message ---
[GitHub] kafka pull request #4018: KAFKA-6010: Relax record conversion time test to a...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4018 KAFKA-6010: Relax record conversion time test to avoid build failure For record conversion tests, check time >=0 since conversion times may be too small to be measured accurately. Since default value is -1, the test is still useful. Also increase message size in SslTransportLayerTest#testNetworkThreadTimeRecorded to avoid failures when processing time is too small. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-6010-MemoryRecordsBuilderTest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4018.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4018 commit de88403f7a77e67c77f7ad36dabcccdfff661fe4 Author: Rajini Sivaram Date: 2017-10-04T18:44:31Z KAFKA-6010: Relax record conversion time test to avoid build failure ---
[GitHub] kafka pull request #4024: KAFKA-6012: Close request metrics only after closi...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4024 KAFKA-6012: Close request metrics only after closing request handlers You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-6012-error-metric Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4024.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4024 commit 4a891452343d6176d48dcb7cab180ae2a650dc81 Author: Rajini Sivaram Date: 2017-10-05T14:19:10Z KAFKA-6012: Close request metrics only after closing request handlers ---
[GitHub] kafka pull request #4026: KAFKA-5746: Document new broker metrics added for ...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4026 KAFKA-5746: Document new broker metrics added for health checks You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-KIP-188-metrics-docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4026.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4026 commit 924e3d2f56a6c24a42018f396612c95f02cc5fe1 Author: Rajini Sivaram Date: 2017-10-05T19:12:15Z KAFKA-5746: Document new broker metrics added for health checks ---
[GitHub] kafka pull request #4099: MINOR: Use ObjectName.quote instead of URL-encodin...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4099 MINOR: Use ObjectName.quote instead of URL-encoding for JMX metric tags You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka 1.0 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4099.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4099 commit 58377d6d8828f652a6beda080ac76afaadabe134 Author: Rajini Sivaram Date: 2017-10-19T15:14:52Z MINOR: Use ObjectName.quote instead of URL-encoding for JMX metric tags ---
[GitHub] kafka pull request #4103: KAFKA-6042: Avoid deadlock between two groups with...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4103 KAFKA-6042: Avoid deadlock between two groups with delayed operations You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-6042-group-deadlock Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4103.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4103 commit 80039370b71bc0efd77d1f4cb46b855bfea45362 Author: Rajini Sivaram Date: 2017-10-20T12:21:46Z KAFKA-6042: Avoid deadlock between two groups with delayed operations ---
[GitHub] kafka pull request #4121: Kafka 6042: Use state write lock for delayed txn o...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4121 Kafka 6042: Use state write lock for delayed txn operations You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-6042-txn-delayedlock Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4121 commit 13b99144ffd1dbbe54105ec124f3b3e6d70d49a6 Author: Rajini Sivaram Date: 2017-10-23T21:37:22Z KAFKA-6042: Use state write lock for delayed txn operations ---
[GitHub] kafka pull request #4122: KAFKA-6096: Add multi-threaded tests for group coo...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4122 KAFKA-6096: Add multi-threaded tests for group coordinator, txn manager You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-6096-deadlock-test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4122.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4122 commit 5e39e73da84c0057ae4815b066cbc6e9113bc608 Author: Rajini Sivaram Date: 2017-10-23T20:59:04Z KAFKA-6096: Add multi-threaded tests for group coordinator, txn manager ---
[GitHub] kafka pull request #4121: Kafka 6042: Use state write lock for delayed txn o...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/4121 ---
[GitHub] kafka pull request #4140: KAFKA-6131: Use atomic putIfAbsent to create txn m...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4140 KAFKA-6131: Use atomic putIfAbsent to create txn marker queues You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-6131-txn-concurrentmap Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4140.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4140 commit b80fcb5bfc8cb70f270eb558ed6267dca99d1e08 Author: Rajini Sivaram Date: 2017-10-26T17:45:47Z KAFKA-6131: Use atomic putIfAbsent to create txn marker queues ---
[GitHub] kafka pull request #4181: KAFKA-6164: Shutdown quota managers if other compo...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4181 KAFKA-6164: Shutdown quota managers if other components fail to start You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-6164 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4181.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4181 commit 9c11aa563fe320c60aa3d75b34d5d368bf0bad0b Author: Rajini Sivaram Date: 2017-11-06T10:49:21Z KAFKA-6164: Shutdown quota managers if other components fail to start ---
[GitHub] kafka pull request #4187: MINOR: Handle error metrics removal during shutdow...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4187 MINOR: Handle error metrics removal during shutdown You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-metrics-cleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4187.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4187 commit 7c282414ae1b1edcd21edbcc3e310684ade034c4 Author: Rajini Sivaram Date: 2017-11-07T09:46:59Z MINOR: Handle error metrics removal during shutdown ---
[GitHub] kafka pull request #4193: KAFKA-6185: Remove channels from explictlyMutedCha...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4193 KAFKA-6185: Remove channels from explictlyMutedChannels set when closed You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-6185-oom Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4193 ---
[GitHub] kafka pull request #4199: KAFKA-6164; Shutdown quota managers if other compo...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4199 KAFKA-6164; Shutdown quota managers if other components fail to start You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-6164-1.0 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4199.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4199 commit 3a1c238165a0ec95bbfa6397dce5bd9776615c66 Author: Rajini Sivaram Date: 2017-11-09T15:17:52Z KAFKA-6164; Shutdown quota managers if other components fail to start ---
[GitHub] kafka-site pull request #108: Add Rajini's keys
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka-site/pull/108 Add Rajini's keys You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka-site add-key Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka-site/pull/108.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #108 commit 240ddda6e00b8c7a4c71a214b010330199c14651 Author: Rajini Sivaram Date: 2017-11-10T14:52:49Z Add Rajini's keys ---
[GitHub] kafka pull request #4203: MINOR: Update version in docs for 0.11.0.2 release
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4203 MINOR: Update version in docs for 0.11.0.2 release You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka version-update-01102 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4203.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4203 commit b6e467a2455d38c930bb167e227f626ab4506a2e Author: Rajini Sivaram Date: 2017-11-10T16:20:33Z MINOR: Update version in docs for 0.11.0.2 release ---
[GitHub] kafka pull request #4203: MINOR: Remove note in docs that is no longer requi...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/4203 ---
[GitHub] kafka pull request #4199: KAFKA-6164; Shutdown quota managers if other compo...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/4199 ---
[GitHub] kafka pull request #4263: KAFKA-6241: Enable dynamic updates of broker SSL k...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4263 KAFKA-6241: Enable dynamic updates of broker SSL keystore Enable dynamic broker configuration (see KIP-225 for details). Includes - Base implementation to allow specific broker configs and custom configs to be dynamically updated - Extend DescribeConfigsRequest/Response to return all synonym configs and their sources in the order of precedence - Extend AdminClient to alter dynamic broker configs - Dynamic update of SSL keystores ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-6241-dynamic-keystore Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4263.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4263 commit 48a12506384d753a1ece6a92fcc59c3f60a35a81 Author: Rajini Sivaram Date: 2017-11-20T17:06:31Z KAFKA-6241: Enable dynamic updates of broker SSL keystore ---
[GitHub] kafka pull request #4294: MINOR: Include client-id in client authentication ...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4294 MINOR: Include client-id in client authentication failure error messages ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-authfailure-log Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4294.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4294 commit 2c2acfd86e30a8ff3aa142369c017aabf543c721 Author: Rajini Sivaram Date: 2017-12-05T12:23:12Z MINOR: Include client-id in authentication failure error messages ---
[GitHub] kafka pull request #4294: MINOR: Include client-id in client authentication ...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/4294 ---
[GitHub] kafka pull request #4303: KAFKA-6319: Quote strings stored in JSON configs
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4303 KAFKA-6319: Quote strings stored in JSON configs This is required for ACLs where SSL principals contain special characters (e.g. comma) that are escaped using backslash. The strings need to be quoted for JSON to ensure that the JSON stored in ZK is valid. Also converted `SslEndToEndAuthorizationTest` to use a principal with special characters to ensure that this path is tested. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-6319 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4303.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4303 commit 9518f465a76b3431a36777d83d57bf1430eaa302 Author: Rajini Sivaram Date: 2017-12-07T20:00:03Z KAFKA-6319: Quote strings in JSON to enable ACLs for principals with special chars ---
[GitHub] kafka pull request #4312: MINOR: Increase number of messages in replica veri...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/4312 MINOR: Increase number of messages in replica verification tool test Increase the number of messages produced to make the test more reliable. The test failed in a recent build and also fails intermittently when run locally. Since the producer uses acks=0 and the test stops as soon as a lag is observed, the change shouldn't have a big impact on the time taken to run when lag is observed sooner. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-replicaverification-test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4312.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4312 commit 94ef402fceec0df1a10ddc8a0f435c8c68a8e6c3 Author: Rajini Sivaram Date: 2017-12-11T16:58:30Z MINOR: Increase number of messages in replica verification tool test ---
[GitHub] kafka pull request #2733: KAFKA-4943: Make /config/users with SCRAM credenti...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2733 KAFKA-4943: Make /config/users with SCRAM credentials not world-readable You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4943 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2733.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2733 commit 8ab3c5ab5787e795bff779354ad34ca1921107a1 Author: Rajini Sivaram Date: 2017-03-24T15:44:49Z KAFKA-4943: Make /config/users with SCRAM credentials not world-readable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2744: KAFKA-4954: Request handler utilization quotas
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2744 KAFKA-4954: Request handler utilization quotas See KIP-124 (https://cwiki.apache.org/confluence/display/KAFKA/KIP-124+-+Request+rate+quotas) for details You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4954 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2744.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2744 commit e3c104ecf5f9e312acd59a1521f5884b714e05b8 Author: Rajini Sivaram Date: 2017-02-21T20:51:08Z KAFKA-4954: Request handler utilization quotas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2792: MINOR: Fix potential deadlock in consumer close te...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2792 MINOR: Fix potential deadlock in consumer close test You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-closetest-deadlock Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2792.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2792 commit 37eb3d16f31edb2c47cb063cfc216e205075de0f Author: Rajini Sivaram Date: 2017-04-03T08:57:14Z MINOR: Fix potential deadlock in consumer close test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2835: KAFKA-5051: Avoid reverse DNS lookup to obtain hos...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2835 KAFKA-5051: Avoid reverse DNS lookup to obtain hostname for TLS You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5051 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2835.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2835 commit 5805bd5a2cf19a24e89534b10708c42e7b402a0b Author: Rajini Sivaram Date: 2017-04-04T19:21:45Z KAFKA-5051: Avoid reverse DNS lookup to obtain hostname for TLS --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2845: KAFKA-4814: Enable ZK ACLs only when zookeeper.set...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2845 KAFKA-4814: Enable ZK ACLs only when zookeeper.set.acl is set You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4814 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2845.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2845 commit b4c8614fa6faaba40ec878919bf2314a17736493 Author: Rajini Sivaram Date: 2017-04-12T12:28:06Z KAFKA-4814: Enable ZK ACLs only when zookeeper.set.acl is set --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2879: KAFKA-5094: Replace SCRAM credentials in broker lo...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2879 KAFKA-5094: Replace SCRAM credentials in broker logs with tag hidden You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5094 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2879.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2879 commit b5251fa1c07bce83b56e68063d4a3ef2cef20c2c Author: Rajini Sivaram Date: 2017-04-20T11:08:13Z KAFKA-5094: Replace SCRAM credentials in broker logs with tag hidden --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site pull request #55: Add Rajini to committers page
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka-site/pull/55 Add Rajini to committers page You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka-site add-rajini Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka-site/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit 6ccaae90a95ac4afedd304f7ce97291018f31915 Author: Rajini Sivaram Date: 2017-04-26T20:51:04Z Add Rajini to committers page --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2980: KAFKA-5179: Log connection termination during auth...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2980 KAFKA-5179: Log connection termination during authentication You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5179 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2980.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2980 commit 400e04bbe9f0968b8091b72baeefb08621fe1b34 Author: Rajini Sivaram Date: 2017-05-05T12:41:53Z KAFKA-5179: Log connection termination during authentication --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2985: KAFKA-5173: Log jaas.config if broker fails to sta...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2985 KAFKA-5173: Log jaas.config if broker fails to start You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5173-debug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2985.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2985 commit 2c2963fc4cbf74c1fd83f7b1daa50068cdb39361 Author: Rajini Sivaram Date: 2017-05-05T20:37:10Z KAFKA-5173: Log jaas.config if broker fails to start --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3011: KAFKA-5173: Close txn coordinator threads during b...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3011 KAFKA-5173: Close txn coordinator threads during broker shutdown Shutdown delayed delete purgatory thread, transaction marker purgatory thread and send thread in `TransactionMarkerChannelManager` during broker shutdown. Made `InterBrokerSendThread` interruptible so that it is shutdown. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5182 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3011.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3011 commit ead2bbc0618bc20421c693b6f96895780c75276b Author: Rajini Sivaram Date: 2017-05-10T15:22:22Z KAFKA-5173: Close txn coordinator threads during broker shutdown --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3011: KAFKA-5173: Close txn coordinator threads during b...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/3011 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3014: KAFKA-5182: Close txn coordinator threads during b...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3014 KAFKA-5182: Close txn coordinator threads during broker shutdown Shutdown delayed delete purgatory thread, transaction marker purgatory thread and send thread in `TransactionMarkerChannelManager` during broker shutdown. Made `InterBrokerSendThread` interruptible so that it is shutdown. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5182 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3014.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3014 commit 3f35cdfd42a927fe805d364ba35a996ca6cd487d Author: Rajini Sivaram Date: 2017-05-10T15:22:22Z KAFKA-5182: Close txn coordinator threads during broker shutdown --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3026: KAFKA-5713: Shutdown brokers in tests
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3026 KAFKA-5713: Shutdown brokers in tests Add broker shutdown for `LeaderEpochIntegrationTest`. Move broker shutdown in other tests to `tearDown` to ensure brokers are shutdown even if tests fail. Also added assertion to `ZooKeeperTestHarness` to verify that controller event thread is not running since this thread may load JAAS configuration if ZK ports are reused. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5173 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3026.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3026 commit 41bbe2c35f616e32c5eb0ae0ab5f8cb307db95b6 Author: Rajini Sivaram Date: 2017-05-11T15:31:59Z KAFKA-5713: Shutdown brokers in tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2985: KAFKA-5173: Log jaas.config if broker fails to sta...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/2985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3037: KAFKA-5227: Remove unsafe assertion, make jaas con...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3037 KAFKA-5227: Remove unsafe assertion, make jaas config safer You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5227 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3037.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3037 commit 054d9006b2fb0893c30ebdc21d36f934110cef91 Author: Rajini Sivaram Date: 2017-05-12T22:23:03Z KAFKA-5227: Remove unsafe assertion, make jaas config safer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3039: MINOR: Close ZooKeeper clients in tests
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3039 MINOR: Close ZooKeeper clients in tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-close-zkclient Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3039.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3039 commit e62cecfde31093a245ebcf30f1c1578f83925bfb Author: Rajini Sivaram Date: 2017-05-13T01:51:43Z MINOR: Close ZooKeeper clients in tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3057: KAFKA-5182: Reduce session timeout in request quot...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3057 KAFKA-5182: Reduce session timeout in request quota test Reduce session timeouts for join requests to trigger throttling in the request quota test. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5182-quotatest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3057.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3057 commit 7885027108e9841490181b58b759d5a61cba84fc Author: Rajini Sivaram Date: 2017-05-15T17:10:56Z KAFKA-5182: Reduce session timeout in request quota test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3068: KAFKA-5250: Do fetch down conversion after throttl...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3068 KAFKA-5250: Do fetch down conversion after throttling Perform down conversion after throttling to avoid retaining messages in memory during throttling since this could result in OOM. Also update bytesOut metrics after throttling when the response is about to be sent. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5250 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3068.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3068 commit a5d0df74214480929f800773dc2aee8d0a4b0bc6 Author: Rajini Sivaram Date: 2017-05-16T12:49:21Z KAFKA-5250: Do fetch down conversion after throttling --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3069: KAFKA-4957: Request rate quotas documentation
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3069 KAFKA-4957: Request rate quotas documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4957 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3069.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3069 commit d7a2991a424c595c3339ad0d67f91a034eaa6346 Author: Rajini Sivaram Date: 2017-05-16T18:24:51Z KAFKA-4957: Request rate quotas documentation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3124: KAFKA-5263: Avoid tight polling loop in consumer w...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3124 KAFKA-5263: Avoid tight polling loop in consumer with no ready nodes If all brokers are unavailable, consumers using manual assignment poll in a tight loop with no channels to poll from. Producers and consumers using group management avoid this since they wait for metadata which attempt to create new connections with any necessary backoff. This PR does a similar wait for consumers using manual assignment when no nodes are ready. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5263 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3124.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3124 commit e4cd05a61c3e5422b2a897004b41d523b5af8c16 Author: Rajini Sivaram Date: 2017-05-23T10:05:21Z KAFKA-5263: Avoid tight polling loop in consumer with no ready nodes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3137: KAFKA-5320: Include all request throttling in clie...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3137 KAFKA-5320: Include all request throttling in client throttle metrics You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5320 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3137 commit df83a196def521e50939f39d62bccd4e461a Author: Rajini Sivaram Date: 2017-05-24T11:06:05Z KAFKA-5320: Include all request throttling in client throttle metrics --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3146: MINOR: Cleanup in tests to avoid threads being lef...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3146 MINOR: Cleanup in tests to avoid threads being left behind You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-test-cleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3146.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3146 commit 2fb408fd46c0c090067268a6276aab4c44672e48 Author: Rajini Sivaram Date: 2017-05-25T18:34:20Z MINOR: Cleanup in tests to avoid threads being left behind --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3168: KAFKA-4956: System test for request quotas
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3168 KAFKA-4956: System test for request quotas You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4956 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3168.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3168 commit 2019ec7c48242d5dcd7bad0bba878603e61483f9 Author: Rajini Sivaram Date: 2017-05-30T13:57:16Z KAFKA-4956: System test for request quotas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3169: MINOR: Fix doc for producer throttle time metrics
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3169 MINOR: Fix doc for producer throttle time metrics You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-producer-metrics Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3169 commit cd458384e539f37d3c1c2fc946ba51e5f0de872d Author: Rajini Sivaram Date: 2017-05-30T14:30:57Z MINOR: Fix doc for producer throttle time metrics --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3190: KAFKA-4956: Verify client-side throttle time metri...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3190 KAFKA-4956: Verify client-side throttle time metrics in quota test You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4956-unittest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3190.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3190 commit c00187944d7942e58765d7bdb68912c9e041a636 Author: Rajini Sivaram Date: 2017-06-01T10:50:04Z KAFKA-4956: Verify client-side throttle time metrics in quota test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3168: KAFKA-4956: System test for request quotas
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/3168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3195: KAFKA-5345: Close KafkaClient when streams client ...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3195 KAFKA-5345: Close KafkaClient when streams client is closed You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5345 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3195 commit fbdc0d0774542664f5e1a49d92539f8c5a378028 Author: Rajini Sivaram Date: 2017-06-01T19:01:29Z KAFKA-5345: Close KafkaClient when streams client is closed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3208: KAFKA-5325: Avoid and handle exceptions for Kerber...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3208 KAFKA-5325: Avoid and handle exceptions for Kerberos re-login You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5325 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3208 commit ad8afca300bda010a4fdbd9bbdcdf80bfda17250 Author: Rajini Sivaram Date: 2017-06-02T11:31:48Z KAFKA-5325: Avoid and handle exceptions for Kerberos re-login --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3209: KAFKA-5345; Close KafkaClient when streams client ...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3209 KAFKA-5345; Close KafkaClient when streams client is closed Cherry-pick KAFKA-5345 to 0.10.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5345-0102 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3209.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3209 commit 67ca06ecd7fdecd929dae0b657c70b4be71f49ed Author: Rajini Sivaram Date: 2017-06-01T20:54:28Z KAFKA-5345; Close KafkaClient when streams client is closed Author: Rajini Sivaram Reviewers: Guozhang Wang , Ismael Juma Closes #3195 from rajinisivaram/KAFKA-5345 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3209: KAFKA-5345; Close KafkaClient when streams client ...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/3209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3238: KAFKA-5380: Fix transient failure in KafkaConsumer...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3238 KAFKA-5380: Fix transient failure in KafkaConsumerTest, close consumers In `KafkaConsumer#testChangingRegexSubscription`, keep metadata updated with both topics since heartbeat thread may remove unsubscribed topic during its metadata update, causing the assertion that matches join requests to fail. Also close consumer in all tests since they leave behind heartbeat threads. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5380 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3238.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3238 commit 0b2d19962a6ee6d295c8d5d088eb63e8857abb8d Author: Rajini Sivaram Date: 2017-06-05T17:14:01Z KAFKA-5380: Fix transient failure in KafkaConsumerTest, close consumers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3246: KAFKA-4948: Wait for offset commit in test to fix ...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3246 KAFKA-4948: Wait for offset commit in test to fix transient failure `DescribeConsumerGroupTest#testDescribeExistingGroupWithNoMembersWithNewConsumer` shuts down the consumer executor thread and then checks that the assignments returned by `describeGroup` contain the consume group with no members. But if the executor thread is shut down before any offsets are committed, the assignments returned by `describeGroup` doesn't contain the group at all. This PR waits for an offset commit by waiting for the group to appear in `describeGroup` assignments prior to shutting down the executor. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-4948 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3246.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3246 commit cda6b607e83078f5941731b73d7c38575606d473 Author: Rajini Sivaram Date: 2017-06-06T13:28:16Z KAFKA-4948: Wait for offset commit in test to fix transient failure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3253: MINOR: Fixed Non-Final Close Method + its Duplicat...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3253 MINOR: Fixed Non-Final Close Method + its Duplication Cherry-picked from trunk. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5395 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3253.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3253 commit fdab22665f9cc88382236a94a5388aa2b65b381e Author: Armin Braun Date: 2017-02-24T22:37:18Z MINOR: Fixed Non-Final Close Method + its Duplication Author: Armin Braun Reviewers: Ismael Juma , Jason Gustafson Closes #2582 from original-brownbear/cleanup-nonfinal-close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3253: KAFKA-5395: Remove synchronization from AbstractCo...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/3253 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3303: KAFKA-5402: Avoid creating quota related metrics i...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3303 KAFKA-5402: Avoid creating quota related metrics if quotas not enabled You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5402 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3303.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3303 commit f69011760d67a4b85d5049014e5929fbdc661858 Author: Rajini Sivaram Date: 2017-06-12T12:12:14Z KAFKA-5402: Avoid creating quota related metrics if quotas not enabled --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3304: KAFKA-5433: Close SimpleAclAuthorizer in test to c...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3304 KAFKA-5433: Close SimpleAclAuthorizer in test to close ZK client You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5433 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3304.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3304 commit 4c634f41d4ed63faea1227e8de226a6d5d510b80 Author: Rajini Sivaram Date: 2017-06-12T14:19:31Z KAFKA-5433: Close SimpleAclAuthorizer in test to close ZK client --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3314: KAFKA-5439: Verify that no unexpected threads are ...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3314 KAFKA-5439: Verify that no unexpected threads are left behind in tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5439 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3314.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3314 commit d76f37bfb46a72245b7e9305bebc1a4fd240b227 Author: Rajini Sivaram Date: 2017-06-13T07:33:43Z KAFKA-5439: Verify that no unexpected threads are left behind in tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3315: MINOR: Generate deprecated warning for static defa...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3315 MINOR: Generate deprecated warning for static default quota config The default client-id bandwidth quota config properties have been marked deprecated in the doc, but a warning may be useful before the property is removed in a future release. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-deprecate-staticquota Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3315.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3315 commit 6bdd4ace58e3318fa77e4b08b2fa69a5bfc003a8 Author: Rajini Sivaram Date: 2017-06-13T13:24:56Z MINOR: Generate deprecated warning for static default quota config --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3317: MINOR: Clean up in DeleteConsumerGroupTest even if...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3317 MINOR: Clean up in DeleteConsumerGroupTest even if test fails You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-deleteconsumergrouptest-cleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3317.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3317 commit 4d0ddc3b1902d9b2e521a803633b212cd95e14ac Author: Rajini Sivaram Date: 2017-06-13T16:48:42Z MINOR: Clean up in DeleteConsumerGroupTest even if test fails --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3334: MINOR: Fix ConsumerBounceTest to wait for consumer...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3334 MINOR: Fix ConsumerBounceTest to wait for consumer close You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-more-test-cleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3334.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3334 commit e2e1fb05efbbca491dc52407a5abcb2e13222bf9 Author: Rajini Sivaram Date: 2017-06-14T07:00:54Z MINOR: Fix ConsumerBounceTest to wait for consumer close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3303: KAFKA-5402: Avoid creating quota related metrics i...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/3303 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3303: KAFKA-5402: Avoid creating quota related metrics i...
GitHub user rajinisivaram reopened a pull request: https://github.com/apache/kafka/pull/3303 KAFKA-5402: Avoid creating quota related metrics if quotas not enabled You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5402 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3303.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3303 commit 5040ef11e46eabc390422783ef44972145ac85b2 Author: Rajini Sivaram Date: 2017-06-12T12:12:14Z KAFKA-5402: Avoid creating quota related metrics if quotas not enabled commit 2e25eac8a25adbe8c5a01c8b857cb5e1e879e5e5 Author: Rajini Sivaram Date: 2017-06-12T15:29:01Z KAFKA-5402: Address review comment commit f70e82622a06ede38e8f3d704ade6f3f4f27b2bd Author: Rajini Sivaram Date: 2017-06-12T20:11:09Z KAFKA-5402: Fix test failures, update method names commit e25d5b1d3b19af198f5dac070abc9495edc49364 Author: Rajini Sivaram Date: 2017-06-13T12:42:23Z KAFKA-5402: Address review comments commit 499ded48f04f6da193d8a3f04d9072983174069b Author: Rajini Sivaram Date: 2017-06-29T00:16:51Z KAFKA-5402: Address review comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3334: MINOR: Fix ConsumerBounceTest to wait for consumer...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/3334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3471: MINOR: Add test brokers to list as they are create...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3471 MINOR: Add test brokers to list as they are created to ensure cleanup You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-shutdown-brokers Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3471.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3471 commit 55359cddb9c0cc6de9b9cd6b185ac9caf642b012 Author: Rajini Sivaram Date: 2017-06-30T18:53:14Z MINOR: Add test brokers to list as they are created to ensure cleanup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3483: MINOR: Wait for tasks to terminate to avoid except...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3483 MINOR: Wait for tasks to terminate to avoid exception in test teardown You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-consumerbounce-test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3483.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3483 commit 1d89b48a61358954e161767894b129e4d11f2e37 Author: Rajini Sivaram Date: 2017-07-04T11:08:50Z MINOR: Wait for tasks to terminate to avoid exception in test teardown --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3526: KAFKA-5587: Remove channel only after staged recei...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3526 KAFKA-5587: Remove channel only after staged receives are delivered When idle connections are closed, ensure that channels with staged receives are retained in `closingChannels` until all staged receives are completed. Also ensure that only one staged receive is completed in each poll, even when channels are closed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5587 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3526.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3526 commit d6848a3b1dcf9cc73caf06b68bdc89570c396c81 Author: Rajini Sivaram Date: 2017-07-14T08:36:22Z KAFKA-5587: Remove channel only after staged receives are delivered --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3529: MINOR: Use correct connectionId in error message
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3529 MINOR: Use correct connectionId in error message You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka MINOR-log-connection-id Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3529.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3529 commit 14b4c7d25161097319926da17748dd09c4145624 Author: Rajini Sivaram Date: 2017-07-14T19:35:49Z MINOR: Use correct connectionId in error message --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3530: KAFKA-5595: Ensure client connection ids are not r...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3530 KAFKA-5595: Ensure client connection ids are not reused too quickly On the broker, if client ports are reused when response to a closed connection is outstanding, broker may send the outstanding response to a new connection with the reused port. The new connection will end up with correlation id mismatch, requiring process restart. This is also a security exposure since clients receive response intended for the wrong connection. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5595 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3530.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3530 commit f1f42bcb57e77cd0841b588ae91cee457ba07832 Author: Rajini Sivaram Date: 2017-07-15T13:01:47Z KAFKA-5595: Ensure client connection ids are not reused too quickly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3530: KAFKA-5595: Ensure client connection ids are not r...
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/3530 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3530: KAFKA-5595: Ensure client connection ids are not r...
GitHub user rajinisivaram reopened a pull request: https://github.com/apache/kafka/pull/3530 KAFKA-5595: Ensure client connection ids are not reused too quickly When there are broker delays that cause a response to take longer than `connections.max.idle.ms`, connections may be closed by the broker (as well as by the client) before the response is processed. If the port is reused, broker may send the outstanding response to a new connection with the reused port. The new connection will end up with correlation id mismatch, requiring process restart. This is also a security exposure since clients receive response intended for the wrong connection. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5595 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3530.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3530 commit 99f3374b5c3b0cb5efcdfe4c553aac943297b016 Author: Rajini Sivaram Date: 2017-07-15T13:01:47Z KAFKA-5595: Ensure client connection ids are not reused too quickly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3548: KAFKA-5607: Improve error handling in SocketServer...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3548 KAFKA-5607: Improve error handling in SocketServer to avoid issues later You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5607 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3548.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3548 commit 9d656f066dbdb86c78e150593c94cc118c843038 Author: Rajini Sivaram Date: 2017-07-19T09:42:43Z KAFKA-5607: Improve error handling in SocketServer to avoid issues later --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3668: KAFKA-5679: Add logging for broker termination due...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3668 KAFKA-5679: Add logging for broker termination due to SIGTERM or SIGINT You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5679 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3668.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3668 commit e6f02a6eb90c242d850d3aab2e59d74162d88626 Author: rajini Date: 2017-08-15T07:29:49Z KAFKA-5679: Add logging for broker termination due to SIGTERM or SIGINT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3686: [WIP] KAFKA-5738: Add cumulative count for rate me...
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3686 [WIP] KAFKA-5738: Add cumulative count for rate metrics Implementation of https://cwiki.apache.org/confluence/display/KAFKA/KIP-187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA-5738 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3686.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3686 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---