[GitHub] [kafka-site] scott-confluent opened a new pull request #269: Kafka nav and hompeage redesign

[GitBox]

scott-confluent opened a new pull request #269:
URL: https://github.com/apache/kafka-site/pull/269


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mjsax merged pull request #268: MINOR: Make contact.html more clear

[GitBox]

mjsax merged pull request #268:
URL: https://github.com/apache/kafka-site/pull/268


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mjsax commented on pull request #268: MINOR: Make contact.html more clear

[GitBox]

mjsax commented on pull request #268:
URL: https://github.com/apache/kafka-site/pull/268#issuecomment-640962104


   Thanks for the PR!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mjsax commented on pull request #267: Updating upgrade docs for KIP-535 and KIP-562

[GitBox]

mjsax commented on pull request #267:
URL: https://github.com/apache/kafka-site/pull/267#issuecomment-642270882


   Thanks @brary!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mjsax merged pull request #267: Updating upgrade docs for KIP-535 and KIP-562

[GitBox]

mjsax merged pull request #267:
URL: https://github.com/apache/kafka-site/pull/267


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] abbccdda opened a new pull request #270: Add Boyang as committer

[GitBox]

abbccdda opened a new pull request #270:
URL: https://github.com/apache/kafka-site/pull/270


   As title suggests.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] junrao merged pull request #270: Add Boyang as committer

[GitBox]

junrao merged pull request #270:
URL: https://github.com/apache/kafka-site/pull/270


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] wkodate opened a new pull request #271: MINOR: Fix table of contents in protocol page

[GitBox]

wkodate opened a new pull request #271:
URL: https://github.com/apache/kafka-site/pull/271


   I deleted a part of the table of contents in protocol.html because this page 
doesn't seem to contain "Evolving the Protocol" section.
   https://kafka.apache.org/protocol.html#protocol_evolution



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] pierDipi closed pull request #205: MINOR: fix 404 security features links

[GitBox]

pierDipi closed pull request #205:
URL: https://github.com/apache/kafka-site/pull/205


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] huxihx opened a new pull request #272: KAFKA-10222:Incorrect methods show up in 0.10 Kafka Streams docs

[GitBox]

huxihx opened a new pull request #272:
URL: https://github.com/apache/kafka-site/pull/272


   https://issues.apache.org/jira/browse/KAFKA-10222
   
   Non-existent methods show up in the doc:
   _builder.from("my-input-topic").mapValue(value -> 
value.length().toString()).to("my-output-topic");_
   
   There is no method named `from` or `mapValues`. They should be `stream` and 
`mapValues` respectively.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] huxihx commented on pull request #272: KAFKA-10222:Incorrect methods show up in 0.10 Kafka Streams docs

[GitBox]

huxihx commented on pull request #272:
URL: https://github.com/apache/kafka-site/pull/272#issuecomment-652295642


   @ijuma Please review this patch. Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] Wavez opened a new pull request #273: Update introduction.html - grammar

[GitBox]

Wavez opened a new pull request #273:
URL: https://github.com/apache/kafka-site/pull/273


   fixed grammar



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang commented on pull request #273: Update introduction.html - grammar

[GitBox]

guozhangwang commented on pull request #273:
URL: https://github.com/apache/kafka-site/pull/273#issuecomment-652574973


   @Wavez Could you also submit a fix in `https://github.com/apache/kafka` 
under `docs/introduction.html`?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang merged pull request #273: Update introduction.html - grammar

[GitBox]

guozhangwang merged pull request #273:
URL: https://github.com/apache/kafka-site/pull/273


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] Wavez commented on pull request #273: Update introduction.html - grammar

[GitBox]

Wavez commented on pull request #273:
URL: https://github.com/apache/kafka-site/pull/273#issuecomment-652595057


   > @Wavez Could you also submit a fix in `https://github.com/apache/kafka` 
under `docs/introduction.html`?
   
   Sure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] Wavez commented on pull request #273: Update introduction.html - grammar

[GitBox]

Wavez commented on pull request #273:
URL: https://github.com/apache/kafka-site/pull/273#issuecomment-652596979


   @guozhangwang 
   https://github.com/apache/kafka/pull/8969



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mjsax commented on pull request #272: KAFKA-10222:Incorrect methods show up in 0.10 Kafka Streams docs

[GitBox]

mjsax commented on pull request #272:
URL: https://github.com/apache/kafka-site/pull/272#issuecomment-653828716


   Thanks for the PR @huxihx -- note, that this pages are generated from the 
JavaDocs. Thus, if we fix it, we should fix it in the source code?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] huxihx commented on pull request #272: KAFKA-10222:Incorrect methods show up in 0.10 Kafka Streams docs

[GitBox]

huxihx commented on pull request #272:
URL: https://github.com/apache/kafka-site/pull/272#issuecomment-653833022


   @mjsax Thanks for reminding. Will close this PR and open a new PR to track 
this issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] huxihx closed pull request #272: KAFKA-10222:Incorrect methods show up in 0.10 Kafka Streams docs

[GitBox]

huxihx closed pull request #272:
URL: https://github.com/apache/kafka-site/pull/272


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] wkodate commented on pull request #271: MINOR: Fix table of contents in protocol page

[GitBox]

wkodate commented on pull request #271:
URL: https://github.com/apache/kafka-site/pull/271#issuecomment-653857296


   @mjsax Please review this PR, Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mjsax merged pull request #272: KAFKA-10222:Incorrect methods show up in 0.10 Kafka Streams docs

[GitBox]

mjsax merged pull request #272:
URL: https://github.com/apache/kafka-site/pull/272


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mjsax commented on pull request #272: KAFKA-10222:Incorrect methods show up in 0.10 Kafka Streams docs

[GitBox]

mjsax commented on pull request #272:
URL: https://github.com/apache/kafka-site/pull/272#issuecomment-655021969


   We can still merge this PR, because otherwise the web-page would not be 
updated.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mjsax commented on pull request #271: MINOR: Fix table of contents in protocol page

[GitBox]

mjsax commented on pull request #271:
URL: https://github.com/apache/kafka-site/pull/271#issuecomment-655024302


   Thanks @wkodate 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mjsax merged pull request #271: MINOR: Fix table of contents in protocol page

[GitBox]

mjsax merged pull request #271:
URL: https://github.com/apache/kafka-site/pull/271


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] vvcephei opened a new pull request #274: MINOR: Add vvcephei to KEYS

[GitBox]

vvcephei opened a new pull request #274:
URL: https://github.com/apache/kafka-site/pull/274


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] vvcephei merged pull request #274: MINOR: Add vvcephei to KEYS

[GitBox]

vvcephei merged pull request #274:
URL: https://github.com/apache/kafka-site/pull/274


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] ableegoldman opened a new pull request #275: MINOR: update Streams docs for 2.6 and fix configs

[GitBox]

ableegoldman opened a new pull request #275:
URL: https://github.com/apache/kafka-site/pull/275


   See https://github.com/apache/kafka/pull/9027



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] ableegoldman commented on a change in pull request #275: MINOR: update Streams docs for 2.6 and fix configs

[GitBox]

ableegoldman commented on a change in pull request #275:
URL: https://github.com/apache/kafka-site/pull/275#discussion_r457761691



##
File path: 26/streams/upgrade-guide.html
##
@@ -95,7 +95,19 @@ Streams API
 Note that you need brokers with version 2.5 or newer to use this 
feature.
 
 
-As of 2.6.0 Kafka Streams deprecates KStream.through() if 
favor of the new KStream.repartition() operator
+For more highly available stateful applications, we've modified the 
task assignment algorithm to delay the movement of stateful active tasks to 
instances
+that aren't yet caught up with that task's state. Instead, to migrate 
a task from one instance to another (eg when scaling out),
+Streams will assign a warmup replica to the target instance so it can 
begin restoring the state while the active task stays available on an instance
+that already had the task. The instances warming up tasks will 
communicate their progress to the group so that, once ready, Streams can move 
active
+tasks to their new owners in the background. Check out https://cwiki.apache.org/confluence/x/0i4lBg";>KIP-441
+for full details, including several new configs for control over this 
new feature.
+
+
+New end-to-end latency metrics have been added. These task-level 
metrics will be logged at the INFO level and report the min and max end-to-end 
latency of a record at the beginning/source node(s)
+and end/terminal node(s) of a task. See https://cwiki.apache.org/confluence/x/gBkRCQ";>KIP-613 for more 
information.
+
+
+As of 2.6.0 Kafka Streams deprecates KStream.through() if 
favor of the new KStream.repartition() operator

Review comment:
   I didn't notice this in time to fix in AK, but we're missing the closing 
tag here so the code formatting is running loose. I'll add this on to an AK PR 
or something so it gets fixed for real





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] vvcephei merged pull request #275: MINOR: update Streams docs for 2.6 and fix configs

[GitBox]

vvcephei merged pull request #275:
URL: https://github.com/apache/kafka-site/pull/275


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang commented on pull request #269: Kafka nav and hompeage redesign

[GitBox]

guozhangwang commented on pull request #269:
URL: https://github.com/apache/kafka-site/pull/269#issuecomment-663299804


   @scott-confluent if you could paste the outlooks as images when it's ready 
for final review and merge that would be greatly appreciated.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] scott-confluent commented on pull request #269: Kafka nav and hompeage redesign

[GitBox]

scott-confluent commented on pull request #269:
URL: https://github.com/apache/kafka-site/pull/269#issuecomment-663671641


   Here are some screenshots of our new layout including desktop and mobile 
views. We've made many improvements for mobile devices, too. There are several 
new pages included in these updates.
   
   Home page:
   
![screencapture-ec2-13-56-160-111-us-west-1-compute-amazonaws-2020-07-24-11_02_25](https://user-images.githubusercontent.com/66280178/88421824-0aec3300-cd9e-11ea-868a-b2ae8037d5d3.png)
   
![screencapture-ec2-13-56-160-111-us-west-1-compute-amazonaws-2020-07-24-11_06_47](https://user-images.githubusercontent.com/66280178/88421820-0889d900-cd9e-11ea-9895-e88274cb6370.png)
   
   Quickstart:
   
![screencapture-ec2-13-56-160-111-us-west-1-compute-amazonaws-quickstart-2020-07-24-11_07_32](https://user-images.githubusercontent.com/66280178/88421810-03c52500-cd9e-11ea-9cb1-14a737001206.png)
   
![screencapture-ec2-13-56-160-111-us-west-1-compute-amazonaws-quickstart-2020-07-24-11_07_09](https://user-images.githubusercontent.com/66280178/88421819-07f14280-cd9e-11ea-8329-a205f702a728.png)
   
   Docs:
   ![Screen Shot 2020-07-24 at 11 11 58 
AM](https://user-images.githubusercontent.com/66280178/88422116-8cdc5c00-cd9e-11ea-9415-f1cf44d46301.png)
   ![Screen Shot 2020-07-24 at 11 14 35 
AM](https://user-images.githubusercontent.com/66280178/88422296-e17fd700-cd9e-11ea-9589-b3024b4bdda4.png)
   
   New pages!
   
![screencapture-ec2-13-56-160-111-us-west-1-compute-amazonaws-books-and-papers-2020-07-24-11_04_29](https://user-images.githubusercontent.com/66280178/88422764-96b28f00-cd9f-11ea-915a-c86c5df8d030.png)
   
![screencapture-127-0-0-1-podcasts-html-2020-07-16-12_01_28](https://user-images.githubusercontent.com/66280178/88422771-9a461600-cd9f-11ea-8adb-b3f6df033cff.png)
   
![screencapture-ec2-13-56-160-111-us-west-1-compute-amazonaws-videos-2020-07-24-11_16_11](https://user-images.githubusercontent.com/66280178/88422883-c497d380-cd9f-11ea-84be-2433d06ebe35.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] scott-confluent commented on pull request #269: Kafka nav and hompeage redesign

[GitBox]

scott-confluent commented on pull request #269:
URL: https://github.com/apache/kafka-site/pull/269#issuecomment-663676137


   Side note: we need to update 1 video (can be seen on the quickstart 
screenshots above) before merging this PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] scott-confluent edited a comment on pull request #269: Kafka nav and hompeage redesign

[GitBox]

scott-confluent edited a comment on pull request #269:
URL: https://github.com/apache/kafka-site/pull/269#issuecomment-663676137







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mimaison opened a new pull request #276: Update Mickael's profile

[GitBox]

mimaison opened a new pull request #276:
URL: https://github.com/apache/kafka-site/pull/276


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mimaison merged pull request #276: Update Mickael's profile

[GitBox]

mimaison merged pull request #276:
URL: https://github.com/apache/kafka-site/pull/276


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch opened a new pull request #277: 2.6.0 release

[GitBox]

rhauch opened a new pull request #277:
URL: https://github.com/apache/kafka-site/pull/277


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch commented on a change in pull request #260: Add 2.5.0 release to website

[GitBox]

rhauch commented on a change in pull request #260:
URL: https://github.com/apache/kafka-site/pull/260#discussion_r464774655



##
File path: downloads.html
##
@@ -5,12 +5,52 @@

 Download
 
-2.4.1 is the latest release. The current stable version is 2.4.1.
+2.5.0 is the latest release. The current stable version is 2.5.0.
 
 
 You can verify your download by following these https://www.apache.org/info/verification.html";>procedures and using 
these https://www.apache.org/dist/kafka/KEYS";>KEYS.
 
 
+
+2.5.0
+
+
+Released April 15, 2020
+
+
+https://www.apache.org/dist/kafka/2.5.0/RELEASE_NOTES.html";>Release 
Notes
+
+
+Source download: https://www.apache.org/dyn/closer.cgi?path=/kafka/2.5.0/kafka-2.5.0-src.tgz";>kafka-2.5.0-src.tgz
 (https://www.apache.org/dist/kafka/2.5.0/kafka-2.5.0-src.tgz.asc";>asc, 
https://www.apache.org/dist/kafka/2.5.0/kafka-2.5.0-src.tgz.sha512";>sha512)
+
+
+Binary downloads:
+
+Scala 2.12  - https://www.apache.org/dyn/closer.cgi?path=/kafka/2.5.0/kafka_2.12-2.5.0.tgz";>kafka_2.12-2.5.0.tgz
 (https://www.apache.org/dist/kafka/2.5.0/kafka_2.12-2.5.0.tgz.asc";>asc,
 https://www.apache.org/dist/kafka/2.5.0/kafka_2.12-2.5.0.tgz.sha512";>sha512)
+Scala 2.13  - https://www.apache.org/dyn/closer.cgi?path=/kafka/2.5.0/kafka_2.13-2.5.0.tgz";>kafka_2.13-2.5.0.tgz
 (https://www.apache.org/dist/kafka/2.5.0/kafka_2.13-2.5.0.tgz.asc";>asc,
 https://www.apache.org/dist/kafka/2.5.0/kafka_2.13-2.5.0.tgz.sha512";>sha512)
+
+We build for multiple versions of Scala. This only matters if you 
are using Scala and you want a version
+built for the same Scala version you use. Otherwise any version 
should work (2.12 is recommended).
+
+
+
+
+Kafka 2.5.0 includes a number of significant new features. Here is a 
summary of some notable changes:
+
+
+
+TLS 1.3 support (1.2 is now the default)
+Co-groups for Kafka Streams
+Incremental rebalance for Kafka Consumer
+New metrics for better operational insight
+Upgrade Zookeeper to 3.5.7
+Deprecate support for Scala 2.11
+
+
+
+For more information, please read the detailed https://www.apache.org/dist/kafka/2.5.0/RELEASE_NOTES.html";>Release 
Notes.
+
+

Review comment:
   These should have been added to the kafka repository in the 
`documentation/upgrade.html` file. 
   
   See https://github.com/apache/kafka/pull/9118 that adds this section back 
into the correct location/repository, and see 
https://github.com/apache/kafka/pull/9117 for a similar fix for the 2.6.0 
release. See https://github.com/apache/kafka/pull/9119 for a fix for the 
`trunk` branch.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] ijuma commented on a change in pull request #277: 2.6.0 release

[GitBox]

ijuma commented on a change in pull request #277:
URL: https://github.com/apache/kafka-site/pull/277#discussion_r465133944



##
File path: 26/upgrade.html
##
@@ -19,6 +19,48 @@
 
 

[GitHub] [kafka-site] guozhangwang commented on pull request #277: 2.6.0 release

[GitBox]

guozhangwang commented on pull request #277:
URL: https://github.com/apache/kafka-site/pull/277#issuecomment-668706478


   LGTM modulo Ismael's comments.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang merged pull request #269: Kafka nav and hompeage redesign

[GitBox]

guozhangwang merged pull request #269:
URL: https://github.com/apache/kafka-site/pull/269


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

[GitBox]

rhauch commented on a change in pull request #277:
URL: https://github.com/apache/kafka-site/pull/277#discussion_r465425450



##
File path: 26/upgrade.html
##
@@ -19,6 +19,48 @@
 
 

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

[GitBox]

rhauch commented on a change in pull request #277:
URL: https://github.com/apache/kafka-site/pull/277#discussion_r465425702



##
File path: 26/upgrade.html
##
@@ -19,6 +19,48 @@
 
 

[GitHub] [kafka-site] mimaison opened a new pull request #278: Remove console.log()

[GitBox]

mimaison opened a new pull request #278:
URL: https://github.com/apache/kafka-site/pull/278


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] tom1299 opened a new pull request #279: Add missing "to" to contributing page

[GitBox]

tom1299 opened a new pull request #279:
URL: https://github.com/apache/kafka-site/pull/279


   Just added the missing word "to" the contribution guide



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] showuon commented on pull request #278: Remove console.log()

[GitBox]

showuon commented on pull request #278:
URL: https://github.com/apache/kafka-site/pull/278#issuecomment-669134108


   Nice catch! LGTM!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] ottomata opened a new pull request #280: Update Wikimedia powered-by text

[GitBox]

ottomata opened a new pull request #280:
URL: https://github.com/apache/kafka-site/pull/280


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] ottomata commented on pull request #280: Update Wikimedia powered-by text

[GitBox]

ottomata commented on pull request #280:
URL: https://github.com/apache/kafka-site/pull/280#issuecomment-669187906


   Let  me know if there is another process I don't know about other than PR to 
get this updated.  Thank you!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] ijuma opened a new pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

[GitBox]

ijuma opened a new pull request #281:
URL: https://github.com/apache/kafka-site/pull/281


   The mailing list seems more suitable.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] ijuma merged pull request #280: Update Wikimedia powered-by text

[GitBox]

ijuma merged pull request #280:
URL: https://github.com/apache/kafka-site/pull/280


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] ijuma commented on pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

[GitBox]

ijuma commented on pull request #281:
URL: https://github.com/apache/kafka-site/pull/281#issuecomment-669197495


   Maybe we should ask people to submit a PR to this repo directly instead of 
the mailing list. What do you think @guozhangwang?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] ottomata commented on pull request #280: Update Wikimedia powered-by text

[GitBox]

ottomata commented on pull request #280:
URL: https://github.com/apache/kafka-site/pull/280#issuecomment-669199664


   Thank you!
   
   On Wed, Aug 5, 2020 at 9:35 AM Ismael Juma  wrote:
   
   > Merged #280  into asf-site.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] scott-confluent opened a new pull request #282: bug fixes

[GitBox]

scott-confluent opened a new pull request #282:
URL: https://github.com/apache/kafka-site/pull/282


   ### home page
   -  spelling
   - re-introduce see full list tooltip
   
   ### docs
   -  remove version banner



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang commented on pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

[GitBox]

guozhangwang commented on pull request #281:
URL: https://github.com/apache/kafka-site/pull/281#issuecomment-669310491


   Yeah I think encouraging people to directly submit PRs is better.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang commented on pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

[GitBox]

guozhangwang commented on pull request #281:
URL: https://github.com/apache/kafka-site/pull/281#issuecomment-669310726


   Anyways, this change LGTM. Please feel free to merge afterwards



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang commented on pull request #278: Remove console.log()

[GitBox]

guozhangwang commented on pull request #278:
URL: https://github.com/apache/kafka-site/pull/278#issuecomment-669312037


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] scott-confluent commented on pull request #278: Remove console.log()

[GitBox]

scott-confluent commented on pull request #278:
URL: https://github.com/apache/kafka-site/pull/278#issuecomment-669326459


   Nice. Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch commented on pull request #277: 2.6.0 release

[GitBox]

rhauch commented on pull request #277:
URL: https://github.com/apache/kafka-site/pull/277#issuecomment-669332049


   @guozhangwang, @ijuma: I've updated the content to try to address your 
comments. Would you mind taking a look?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang commented on pull request #277: 2.6.0 release

[GitBox]

guozhangwang commented on pull request #277:
URL: https://github.com/apache/kafka-site/pull/277#issuecomment-669351468


   LGTM.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang commented on a change in pull request #282: bug fixes

[GitBox]

guozhangwang commented on a change in pull request #282:
URL: https://github.com/apache/kafka-site/pull/282#discussion_r465912196



##
File path: 25/documentation.html
##
@@ -31,7 +31,7 @@
 
   

-

Review comment:
   Ditto for other 25/xyx.html pages: does the same issue exist in older 
versions (24, 23...)?

##
File path: 25/streams/developer-guide/write-streams.html
##
@@ -90,22 +90,22 @@
   See the section Data Types and Serialization for more information about 
Serializers/Deserializers.
   
   Example pom.xml snippet when using Maven:
-  
-org.apache.kafka
-kafka-streams
-{{fullDotVersion}}
-
-
-org.apache.kafka
-kafka-clients
-{{fullDotVersion}}
-
+  
+org.apache.kafka

Review comment:
   Should the `>` be replaced too?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] scott-confluent commented on a change in pull request #282: bug fixes

[GitBox]

scott-confluent commented on a change in pull request #282:
URL: https://github.com/apache/kafka-site/pull/282#discussion_r465921715



##
File path: 25/streams/developer-guide/write-streams.html
##
@@ -90,22 +90,22 @@
   See the section Data Types and Serialization for more information about 
Serializers/Deserializers.
   
   Example pom.xml snippet when using Maven:
-  
-org.apache.kafka
-kafka-streams
-{{fullDotVersion}}
-
-
-org.apache.kafka
-kafka-clients
-{{fullDotVersion}}
-
+  
+org.apache.kafka

Review comment:
   theoretically it should be generated with html entities for both gt and 
lt, but the opening is the only one that matters for highlighting the syntax. 
it's not an easy thing to find/replace so we'd have to do an audit of all the 
docs.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] scott-confluent commented on a change in pull request #282: bug fixes

[GitBox]

scott-confluent commented on a change in pull request #282:
URL: https://github.com/apache/kafka-site/pull/282#discussion_r465924056



##
File path: 25/documentation.html
##
@@ -31,7 +31,7 @@
 
   

-

Review comment:
   I believe the older versions SHOULD have this banner.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] hachikuji merged pull request #279: Add missing "to" to contributing page

[GitBox]

hachikuji merged pull request #279:
URL: https://github.com/apache/kafka-site/pull/279


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

[GitBox]

rhauch commented on a change in pull request #277:
URL: https://github.com/apache/kafka-site/pull/277#discussion_r465956697



##
File path: 26/upgrade.html
##
@@ -19,6 +19,50 @@
 
 

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

[GitBox]

rhauch commented on a change in pull request #277:
URL: https://github.com/apache/kafka-site/pull/277#discussion_r465958151



##
File path: 26/upgrade.html
##
@@ -19,6 +19,50 @@
 
 

[GitHub] [kafka-site] mjsax opened a new pull request #283: MINOR: fix HTML

[GitBox]

mjsax opened a new pull request #283:
URL: https://github.com/apache/kafka-site/pull/283


   Follow up to https://github.com/apache/kafka/pull/9127
   
   \cc @guozhangwang 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang merged pull request #282: bug fixes

[GitBox]

guozhangwang merged pull request #282:
URL: https://github.com/apache/kafka-site/pull/282


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

[GitBox]

rhauch commented on a change in pull request #277:
URL: https://github.com/apache/kafka-site/pull/277#discussion_r466057579



##
File path: 26/upgrade.html
##
@@ -19,6 +19,50 @@
 
 

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

[GitBox]

rhauch commented on a change in pull request #277:
URL: https://github.com/apache/kafka-site/pull/277#discussion_r466057952



##
File path: 26/upgrade.html
##
@@ -19,6 +19,48 @@
 
 

[GitHub] [kafka-site] showuon opened a new pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not

[GitBox]

showuon opened a new pull request #284:
URL: https://github.com/apache/kafka-site/pull/284


   Change the arrow direction based on the view state is expanded or not. We 
can identify it's in expanded mode or not by checking the return value of 
toggle method. Reference: 
https://developer.mozilla.org/en-US/docs/Web/API/DOMTokenList/toggle
   
   
![image](https://user-images.githubusercontent.com/43372967/89490258-00d72500-d7df-11ea-8582-8bae5005a21e.png)
   
   
   
   
![image](https://user-images.githubusercontent.com/43372967/89490628-dcc81380-d7df-11ea-8335-8c4551253790.png)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] showuon commented on pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not

[GitBox]

showuon commented on pull request #284:
URL: https://github.com/apache/kafka-site/pull/284#issuecomment-669677637


   @scott-confluent @guozhangwang , could you help review this PR? Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] ijuma commented on pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

[GitBox]

ijuma commented on pull request #281:
URL: https://github.com/apache/kafka-site/pull/281#issuecomment-669756104


   @guozhangwang I updated the PR to mention pull request first.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mimaison merged pull request #278: Remove console.log()

[GitBox]

mimaison merged pull request #278:
URL: https://github.com/apache/kafka-site/pull/278


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch merged pull request #277: 2.6.0 release

[GitBox]

rhauch merged pull request #277:
URL: https://github.com/apache/kafka-site/pull/277


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang merged pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

[GitBox]

guozhangwang merged pull request #281:
URL: https://github.com/apache/kafka-site/pull/281


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] scott-confluent commented on a change in pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not

[GitBox]

scott-confluent commented on a change in pull request #284:
URL: https://github.com/apache/kafka-site/pull/284#discussion_r466554238



##
File path: includes/_footer.htm
##
@@ -329,7 +329,13 @@
var docsHandle = 
document.querySelector('.toc-handle');
 
function toggleDocsWidth() {
-   
docsContainer.classList.toggle('expanded');
+   let isExpanded = 
docsContainer.classList.toggle('expanded');
+   // change the arrow direction based on 
the view state is expanded or not
+   if (isExpanded) {

Review comment:
   This is technically only working because JavaScript is lax on types and 
the `DOMTokenList` returned by  `classList.toggle` is empty resulting in a 
falsy value. We should probably do `isExapnded.contains('expanded')` as the 
condition to be more explicit.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] mjsax merged pull request #283: MINOR: fix HTML

[GitBox]

mjsax merged pull request #283:
URL: https://github.com/apache/kafka-site/pull/283


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] showuon opened a new pull request #285: MINOR: Fix the wrong referenced document name in quickstart page

[GitBox]

showuon opened a new pull request #285:
URL: https://github.com/apache/kafka-site/pull/285


   In quickstart page, we'll see the following error message displayed. After 
investigation, I found it's because we point to the wrong document 
`26/quickstart-zookeeper.html`. Change to the correct name `26/quickstart.html` 
to fix it.
   
   https://user-images.githubusercontent.com/43372967/89632898-905eff80-d8d5-11ea-9849-e70095ad5d4b.png";>
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] showuon commented on pull request #285: MINOR: Fix the wrong referenced document in quickstart page

[GitBox]

showuon commented on pull request #285:
URL: https://github.com/apache/kafka-site/pull/285#issuecomment-67045


   @scott-confluent @rhauch , could you review this PR ? Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch opened a new pull request #286: Fix renamed and reformatted quickstart, broken since 2.6.0 release

[GitBox]

rhauch opened a new pull request #286:
URL: https://github.com/apache/kafka-site/pull/286


   The AK code contains a `quickstart.html` file, so that when 2.6.0 was 
released the newer `quickstart-docker.html` and `quickstart-zookeeper.html` 
were not included in the `26` directory, breaking the 
https://kafka.apache.org/quickstart page.
   
   This recovers those files into the `asf-site` branch's `26` directory.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch commented on pull request #285: MINOR: Fix the wrong doc path and missing zk/docker button in quickstart page

[GitBox]

rhauch commented on pull request #285:
URL: https://github.com/apache/kafka-site/pull/285#issuecomment-671426983


   Close without merging.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch commented on pull request #285: MINOR: Fix the wrong doc path and missing zk/docker button in quickstart page

[GitBox]

rhauch commented on pull request #285:
URL: https://github.com/apache/kafka-site/pull/285#issuecomment-671426816


   Thanks for identifying the problem and proposing a fix, @showuon. However, I 
don't think referencing the quickstarts in `25` directory is what we want -- 
instead, we want to add the quickstarts to the `26` directory.
   
   I've created #286 to address the issue more consistently with the existing 
patterns.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch closed pull request #285: MINOR: Fix the wrong doc path and missing zk/docker button in quickstart page

[GitBox]

rhauch closed pull request #285:
URL: https://github.com/apache/kafka-site/pull/285


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] scott-confluent opened a new pull request #287: fixes for intro page and various docs page headings

[GitBox]

scott-confluent opened a new pull request #287:
URL: https://github.com/apache/kafka-site/pull/287


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch merged pull request #286: MINOR: Fix renamed and reformatted quickstart, broken since 2.6.0 release

[GitBox]

rhauch merged pull request #286:
URL: https://github.com/apache/kafka-site/pull/286


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] rhauch commented on pull request #285: MINOR: Fix the wrong doc path and missing zk/docker button in quickstart page

[GitBox]

rhauch commented on pull request #285:
URL: https://github.com/apache/kafka-site/pull/285#issuecomment-671539747


   https://kafka.apache.org/quickstart appears to be working again after 
merging #286.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] vvcephei opened a new pull request #288: Update John's profile

[GitBox]

vvcephei opened a new pull request #288:
URL: https://github.com/apache/kafka-site/pull/288


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang commented on pull request #288: Update John's profile

[GitBox]

guozhangwang commented on pull request #288:
URL: https://github.com/apache/kafka-site/pull/288#issuecomment-671583692


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] vvcephei merged pull request #288: Update John's profile

[GitBox]

vvcephei merged pull request #288:
URL: https://github.com/apache/kafka-site/pull/288


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang commented on a change in pull request #287: fixes for intro page and various docs page headings

[GitBox]

guozhangwang commented on a change in pull request #287:
URL: https://github.com/apache/kafka-site/pull/287#discussion_r468191760



##
File path: intro.html
##
@@ -20,7 +20,203 @@ Introduction
   
 
 
-
+

Review comment:
   Why we have to copy-paste now? The old way is more convienent since we 
do not need to copy-paste everytime we update the newest released doc.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang merged pull request #287: fixes for intro page and various docs page headings

[GitBox]

guozhangwang merged pull request #287:
URL: https://github.com/apache/kafka-site/pull/287


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] showuon commented on pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not

[GitBox]

showuon commented on pull request #284:
URL: https://github.com/apache/kafka-site/pull/284#issuecomment-671740187


   @guozhangwang , I think this PR is good to merge except you have other 
opinions. Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] showuon opened a new pull request #289: MINOR: Fix the wrong past-events link

[GitBox]

showuon opened a new pull request #289:
URL: https://github.com/apache/kafka-site/pull/289


   Fix the wrong past-events link. It should be in the `kafka-summit.org` 
domain, not under `kafka.apache.org`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] showuon commented on pull request #289: MINOR: Fix the broken past-events link

[GitBox]

showuon commented on pull request #289:
URL: https://github.com/apache/kafka-site/pull/289#issuecomment-671857049


   @scott-confluent @mjsax , could you help review this PR? Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] tom1299 opened a new pull request #290: MINOR: Add missing to to testing

[GitBox]

tom1299 opened a new pull request #290:
URL: https://github.com/apache/kafka-site/pull/290


   Just added a missing "to" to testing.html



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang merged pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not

[GitBox]

guozhangwang merged pull request #284:
URL: https://github.com/apache/kafka-site/pull/284


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] vvcephei opened a new pull request #291: MINOR: add 2.5.1 release to Downloads

[GitBox]

vvcephei opened a new pull request #291:
URL: https://github.com/apache/kafka-site/pull/291


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] guozhangwang commented on pull request #291: MINOR: add 2.5.1 release to Downloads

[GitBox]

guozhangwang commented on pull request #291:
URL: https://github.com/apache/kafka-site/pull/291#issuecomment-672204528


   LGTM.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] vvcephei commented on pull request #291: MINOR: add 2.5.1 release to Downloads

[GitBox]

vvcephei commented on pull request #291:
URL: https://github.com/apache/kafka-site/pull/291#issuecomment-672256567


   Thanks, all!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] vvcephei merged pull request #291: MINOR: add 2.5.1 release to Downloads

[GitBox]

vvcephei merged pull request #291:
URL: https://github.com/apache/kafka-site/pull/291


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka-site] showuon commented on pull request #289: MINOR: Fix the broken past-events link

[GitBox]

showuon commented on pull request #289:
URL: https://github.com/apache/kafka-site/pull/289#issuecomment-672543644


   It's because the `quickstart.html` got removed in this PR: this PR: 
https://github.com/apache/kafka-site/pull/286. I think we should keep 
`quickstart.html`, `quickstart-zookeeper.html` and `quickstart-docker.html` 
files in the `25` and `26` folder. What do you think @scott-confluent ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org