[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862823#comment-16862823 ] Colvin Cowie commented on SOLR-12142: - [~noble.paul] I raised SOLR-13545 thanks > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch, SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862728#comment-16862728 ] Noble Paul commented on SOLR-12142: --- [~cjcowie] Yes, it is not closed . Please open a new ticket > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch, SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862511#comment-16862511 ] Mikhail Khludnev commented on SOLR-12142: - I agree with [~cjcowie]. WDYT, [~noble.paul], [~dsmiley]? > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch, SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861912#comment-16861912 ] Colvin Cowie commented on SOLR-12142: - Hi [~noble.paul] I suspect that the changes in this issue broke some functionality that previously worked for me on Solr 6. I sent a message to the user list (_ContentStreamUpdateRequest no longer closes stream_), can you take a look at that when you get a chance and see what you think? Thank you > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch, SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505611#comment-16505611 ] ASF subversion and git services commented on SOLR-12142: Commit fcb791fce1b47c5c806a5933f428e90ae9bfc1e2 in lucene-solr's branch refs/heads/branch_7_4 from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fcb791f ] SOLR-12142: EmbeddedSolrServer should use req.getContentWriter > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch, SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505293#comment-16505293 ] David Smiley commented on SOLR-12142: - needs to go to the branch_7_4 too. > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch, SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504912#comment-16504912 ] ASF subversion and git services commented on SOLR-12142: Commit 41d04e6e22e1841cb88ba9812d9826939a7c3d81 in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=41d04e6 ] SOLR-12142: EmbeddedSolrServer should use req.getContentWriter > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch, SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504894#comment-16504894 ] ASF subversion and git services commented on SOLR-12142: Commit 9b65d7e1a20c6f1cb4eeb298951e98bef6a6cf8a in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9b65d7e ] SOLR-12142: EmbeddedSolrServer should use req.getContentWriter > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch, SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504645#comment-16504645 ] David Smiley commented on SOLR-12142: - Looks like we've got some real test failures here in SolrExampleEmbeddedTest.testContentStreamRequest (nice that Yetus helped surface this) > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch, SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504629#comment-16504629 ] Noble Paul commented on SOLR-12142: --- bq. I assume the change to SolrQueryRequestBase was accidental/leftover? bq. Any reason why SolrTaggerRequest::new was replaced with (p, input) -> new SolrTaggerRequest(p, input) ? both are accidental > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch, SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[
https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504379#comment-16504379
]
Lucene/Solr QA commented on SOLR-12142:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 2m 32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 2m 25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 2m 25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 72m 32s{color}
| {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 53s{color}
| {color:red} solrj in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 89m 59s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.autoscaling.sim.TestTriggerIntegration |
| | solr.cloud.autoscaling.IndexSizeTriggerTest |
| | solr.cloud.cdcr.CdcrBidirectionalTest |
| | solr.client.solrj.embedded.SolrExampleEmbeddedTest |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12142 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12926692/SOLR-12142.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 3.13.0-88-generic #135-Ubuntu SMP Wed Jun 8
21:10:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / f8131e4 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on April 8 2014 |
| Default Java | 1.8.0_172 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/118/artifact/out/patch-unit-solr_core.txt
|
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/118/artifact/out/patch-unit-solr_solrj.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/118/testReport/ |
| modules | C: solr/core solr/solrj U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/118/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> EmbeddedSolrServer should use req.getContentWriter
> ---
>
> Key: SOLR-12142
> URL: https://issues.apache.org/jira/browse/SOLR-12142
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: David Smiley
>Assignee: Noble Paul
>Priority: Major
> Fix For: 7.4
>
> Attachments: SOLR-12142.patch, SOLR-12142.patch
>
>
> In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement
> for getContentStreams. However, EmbeddedSolrServer still calls
> getContentStreams, and so clients who need to send POST data to it cannot yet
> switch from the Deprecated API to the new API. The SolrTextTagger is an
> example of a project where one would want to do this.
> It seems EmbeddedSolrServer ought to check for getContentWriter and if
> present then convert it into a ContentStream somehow. For the time being,
> ESS needs to call both since both APIs exist.
> CC [~noble.paul]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[
https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503603#comment-16503603
]
David Smiley commented on SOLR-12142:
-
Thanks for the quick turnaround!
* I assume the change to SolrQueryRequestBase was accidental/leftover?
* Any reason why {{SolrTaggerRequest::new}} was replaced with {{(p, input) ->
new SolrTaggerRequest(p, input)}} ?
Looks good!
> EmbeddedSolrServer should use req.getContentWriter
> ---
>
> Key: SOLR-12142
> URL: https://issues.apache.org/jira/browse/SOLR-12142
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: David Smiley
>Assignee: Noble Paul
>Priority: Major
> Fix For: 7.4
>
> Attachments: SOLR-12142.patch, SOLR-12142.patch
>
>
> In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement
> for getContentStreams. However, EmbeddedSolrServer still calls
> getContentStreams, and so clients who need to send POST data to it cannot yet
> switch from the Deprecated API to the new API. The SolrTextTagger is an
> example of a project where one would want to do this.
> It seems EmbeddedSolrServer ought to check for getContentWriter and if
> present then convert it into a ContentStream somehow. For the time being,
> ESS needs to call both since both APIs exist.
> CC [~noble.paul]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503036#comment-16503036 ] Noble Paul commented on SOLR-12142: --- [~dsmiley] pls review the patch > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch, SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502777#comment-16502777 ] David Smiley commented on SOLR-12142: - Now that the SolrTextTagger is in Solr, it's test demonstrating the issue is now here too. See: https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/handler/tagger/EmbeddedSolrNoSerializeTest.java#L102 (the commented out part) If it can't be fixed for 7.4 then the commit ought to be reverted from 7x. > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445866#comment-16445866 ] David Smiley commented on SOLR-12142: - So this method, EmbeddedSolrServer.request(...) confusingly looks up the requestHandler twice – once on the coreContainer reference (I wish there was a comment explaining why), and failing that then more normally further below at line 190: [https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java#L190] You changed the first occurrence but not the second. Again; a test would have revealed this oversight I think. I'll cook up a patch. Maybe that would even happen indirectly if the SolrTextTagger were to be incorporated directly into Solr; a few people have asked me about this. > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443555#comment-16443555 ] Noble Paul commented on SOLR-12142: --- I'll reopen the ticket. You can post a patch with a testcase and I shall fix it > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443543#comment-16443543 ] David Smiley commented on SOLR-12142: - I wasn't expecting this is in committable shape yet... I'll find out if this actually works over in the SolrTextTagger tests which has a test that posts plain text (not XML or JavaBin) to a custom RequestHandler. That's what prompted this issue (and another). https://github.com/OpenSextant/SolrTextTagger/blob/ab6951a1f77218f2b27ff00e9a13970fd70fffb3/src/test/java/org/opensextant/solrtexttagger/EmbeddedSolrNoSerializeTest.java#L106 BTW when I said "assuming BinaryRequestWriter().write is used? Then I guess don't use it." I meant maybe then don't use this approach at all – no RequestWriter, no anonymous inner class of ContentStreamBase. > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443538#comment-16443538 ] ASF subversion and git services commented on SOLR-12142: Commit 9c8e527cd1b361e2f4ad8d4f71110142b411f0d8 in lucene-solr's branch refs/heads/branch_7x from noble [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9c8e527 ] SOLR-12142: EmbeddedSolrServer should use req.getContentWriter > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Attachments: SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443535#comment-16443535 ] ASF subversion and git services commented on SOLR-12142: Commit 1c8ab330d66557a289dd5398576726a43964c9e8 in lucene-solr's branch refs/heads/master from noble [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1c8ab33 ] SOLR-12142: EmbeddedSolrServer should use req.getContentWriter > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Attachments: SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421198#comment-16421198 ] Noble Paul commented on SOLR-12142: --- bq.– assuming BinaryRequestWriter().write is used? Then I guess don't use it. We don't have any other request writers other than xml and javabin > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Attachments: SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421175#comment-16421175 ] David Smiley commented on SOLR-12142: - bq. We cannot ... -- assuming BinaryRequestWriter().write is used? Then I guess don't use it. > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Attachments: SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421115#comment-16421115 ] Noble Paul commented on SOLR-12142: --- We cannot have any other content type handled other than xml/javabin because we don't have serializers for any other types. > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Attachments: SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[
https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420592#comment-16420592
]
David Smiley commented on SOLR-12142:
-
Oh clever; I didn't know {{new BinaryRequestWriter().write(request, baos);}}
will handle the details of this. I'm concerned that JAVA_BIN isn't
_necessarily_ the right content-type though. We ought to have a test here,
perhaps trivially sending a few lines of a CSV via EmbeddedSolrServer in this
way and see if the docs are added?
> EmbeddedSolrServer should use req.getContentWriter
> ---
>
> Key: SOLR-12142
> URL: https://issues.apache.org/jira/browse/SOLR-12142
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: David Smiley
>Assignee: Noble Paul
>Priority: Major
> Attachments: SOLR-12142.patch
>
>
> In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement
> for getContentStreams. However, EmbeddedSolrServer still calls
> getContentStreams, and so clients who need to send POST data to it cannot yet
> switch from the Deprecated API to the new API. The SolrTextTagger is an
> example of a project where one would want to do this.
> It seems EmbeddedSolrServer ought to check for getContentWriter and if
> present then convert it into a ContentStream somehow. For the time being,
> ESS needs to call both since both APIs exist.
> CC [~noble.paul]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12142) EmbeddedSolrServer should use req.getContentWriter
[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418508#comment-16418508 ] Mikhail Khludnev commented on SOLR-12142: - This patch uses java.io.BAOS with expensive resizing. In SOLR-9147 we approached BAOS from commons, which might suit here as well. > EmbeddedSolrServer should use req.getContentWriter > --- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Assignee: Noble Paul >Priority: Major > Attachments: SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
