Re: svn commit: r280860 - in /maven/maven-1/plugins/trunk: ./ abbot/src/plugin-test/ clover/src/plugin-test/ cruisecontrol/src/plugin-test/ dashboard/src/plugin-test/ eclipse/src/plugin-test/
The problem is that we added a lot of layers and I don't think it's a good idea for the tests. I agree to reuse as much as possible plugins feature between them (I'm adding reusable goals where possible), but in tests we should be very simple to avoid sideeffects (it's why m2 was done - less layers, a better control...). I spent a lot of time to find that it was because we have a bug in the maven (MAVEN-1691 <http://jira.codehaus.org/browse/MAVEN-1691>) which produced a problem in the multiproject plugin which drove to the failure of several tests in different plugins. I don't want to rewrite m1 (it's already - and well - done in m2) but I don't want also to spent hours and hours to find a little bug. Brett : why do you say we're breaking backwards compatibility ? Vincent : Yes it a bad idea to keep the properties names comming from the multiproject plugin. I should use the multiproject or remove it and rename properties. I'm doubtful I don't know what is the better Arnaud On 9/19/05, Brett Porter <[EMAIL PROTECTED]> wrote: > > I agree with Vincent. I don't think we should be working around bugs in > the beta by changing the plugins (esp in breaking backwards compat) > > Cheers, > Brett > > Vincent Massol wrote: > > >Hi Arnaud, > > > >A pity... It took me a while to move from the reactor to using the > >multiproject plugin and now we're back again to square one... :-) > > > >Not that I care that much but I'm curious to understand if we have > changed > >our m1 vision (which was to reuse existing plugins as much as possible). > >Here we are now duplicating code from the multiproject plugin. > > > >Also it's dangerous as before a user could use all the available > >multiproject properties to configure the plugins whereas now they are > >limited to the ones you've defined as attributes of the reactor tag. > > > >Thanks > >-Vincent > > > > > > > >>-Original Message----- > >>From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > >>Sent: mercredi 14 septembre 2005 16:07 > >>To: [EMAIL PROTECTED] > >>Subject: svn commit: r280860 - in /maven/maven-1/plugins/trunk: ./ > >>abbot/src/plugin-test/ clover/src/plugin-test/ cruisecontrol/src/plugin- > >>test/ dashboard/src/plugin-test/ eclipse/src/plugin-test/ > >> > >>Author: aheritier > >>Date: Wed Sep 14 07:06:20 2005 > >>New Revision: 280860 > >> > >>URL: http://svn.apache.org/viewcvs?rev=280860&view=rev > >>Log: > >>Replace the multiproject:goal by the reactor (workaround for > MAVEN-1691). > >>Fix all tests in all plugins. > >> > >>Removed: > >> maven/maven-1/plugins/trunk/abbot/src/plugin-test/project.properties > >> maven/maven-1/plugins/trunk/clover/src/plugin-test/project.properties > >> maven/maven-1/plugins/trunk/cruisecontrol/src/plugin- > >>test/project.properties > >> maven/maven-1/plugins/trunk/eclipse/src/plugin-test/project.properties > >>Modified: > >> maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml > >> maven/maven-1/plugins/trunk/clover/src/plugin-test/maven.xml > >> maven/maven-1/plugins/trunk/cruisecontrol/src/plugin-test/maven.xml > >> maven/maven-1/plugins/trunk/dashboard/src/plugin-test/maven.xml > >> maven/maven-1/plugins/trunk/dashboard/src/plugin- > >>test/project.properties > >> maven/maven-1/plugins/trunk/eclipse/src/plugin-test/maven.xml > >> maven/maven-1/plugins/trunk/maven.xml > >> > >>Modified: maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml > >>URL: http://svn.apache.org/viewcvs/maven/maven- > >>1/plugins/trunk/abbot/src/plugin- > >>test/maven.xml?rev=280860&r1=280859&r2=280860&view=diff > > >>== > >> > >>--- maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml > (original) > >>+++ maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml Wed Sep > 14 > >>07:06:20 2005 > >>@@ -1,6 +1,6 @@ > >> > >> > >>- > >>+ > >> > >> > >> This plugin must be tested manually (with the testPlugin-manual > >>goal) as it requires defining a build.properties containing environment- > >>dependent configuration. > >>@@ -13,8 +13,7 @@ > >> environment variable must be set. --> > >> > >> > >>- > >>- > >>+ >>goals="dist" banner="Test" ignoreFailures="false"/> > >> > >> > >> > > > >[snip] > > > > > >- > >To unsubscribe, e-mail: [EMAIL PROTECTED] > >For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
Re: svn commit: r280860 - in /maven/maven-1/plugins/trunk: ./ abbot/src/plugin-test/ clover/src/plugin-test/ cruisecontrol/src/plugin-test/ dashboard/src/plugin-test/ eclipse/src/plugin-test/
I agree with Vincent. I don't think we should be working around bugs in the beta by changing the plugins (esp in breaking backwards compat) Cheers, Brett Vincent Massol wrote: >Hi Arnaud, > >A pity... It took me a while to move from the reactor to using the >multiproject plugin and now we're back again to square one... :-) > >Not that I care that much but I'm curious to understand if we have changed >our m1 vision (which was to reuse existing plugins as much as possible). >Here we are now duplicating code from the multiproject plugin. > >Also it's dangerous as before a user could use all the available >multiproject properties to configure the plugins whereas now they are >limited to the ones you've defined as attributes of the reactor tag. > >Thanks >-Vincent > > > >>-Original Message- >>From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] >>Sent: mercredi 14 septembre 2005 16:07 >>To: [EMAIL PROTECTED] >>Subject: svn commit: r280860 - in /maven/maven-1/plugins/trunk: ./ >>abbot/src/plugin-test/ clover/src/plugin-test/ cruisecontrol/src/plugin- >>test/ dashboard/src/plugin-test/ eclipse/src/plugin-test/ >> >>Author: aheritier >>Date: Wed Sep 14 07:06:20 2005 >>New Revision: 280860 >> >>URL: http://svn.apache.org/viewcvs?rev=280860&view=rev >>Log: >>Replace the multiproject:goal by the reactor (workaround for MAVEN-1691). >>Fix all tests in all plugins. >> >>Removed: >>maven/maven-1/plugins/trunk/abbot/src/plugin-test/project.properties >>maven/maven-1/plugins/trunk/clover/src/plugin-test/project.properties >>maven/maven-1/plugins/trunk/cruisecontrol/src/plugin- >>test/project.properties >>maven/maven-1/plugins/trunk/eclipse/src/plugin-test/project.properties >>Modified: >>maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml >>maven/maven-1/plugins/trunk/clover/src/plugin-test/maven.xml >>maven/maven-1/plugins/trunk/cruisecontrol/src/plugin-test/maven.xml >>maven/maven-1/plugins/trunk/dashboard/src/plugin-test/maven.xml >>maven/maven-1/plugins/trunk/dashboard/src/plugin- >>test/project.properties >>maven/maven-1/plugins/trunk/eclipse/src/plugin-test/maven.xml >>maven/maven-1/plugins/trunk/maven.xml >> >>Modified: maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml >>URL: http://svn.apache.org/viewcvs/maven/maven- >>1/plugins/trunk/abbot/src/plugin- >>test/maven.xml?rev=280860&r1=280859&r2=280860&view=diff >>== >> >>--- maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml (original) >>+++ maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml Wed Sep 14 >>07:06:20 2005 >>@@ -1,6 +1,6 @@ >> >> >>- >>+ >> >> >> This plugin must be tested manually (with the testPlugin-manual >>goal) as it requires defining a build.properties containing environment- >>dependent configuration. >>@@ -13,8 +13,7 @@ >>environment variable must be set. --> >> >> >>- >>- >>+>goals="dist" banner="Test" ignoreFailures="false"/> >> >> >> > >[snip] > > >- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] > > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: svn commit: r280860 - in /maven/maven-1/plugins/trunk: ./ abbot/src/plugin-test/ clover/src/plugin-test/ cruisecontrol/src/plugin-test/ dashboard/src/plugin-test/ eclipse/src/plugin-test/
Hi Arnaud, A pity... It took me a while to move from the reactor to using the multiproject plugin and now we're back again to square one... :-) Not that I care that much but I'm curious to understand if we have changed our m1 vision (which was to reuse existing plugins as much as possible). Here we are now duplicating code from the multiproject plugin. Also it's dangerous as before a user could use all the available multiproject properties to configure the plugins whereas now they are limited to the ones you've defined as attributes of the reactor tag. Thanks -Vincent > -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: mercredi 14 septembre 2005 16:07 > To: [EMAIL PROTECTED] > Subject: svn commit: r280860 - in /maven/maven-1/plugins/trunk: ./ > abbot/src/plugin-test/ clover/src/plugin-test/ cruisecontrol/src/plugin- > test/ dashboard/src/plugin-test/ eclipse/src/plugin-test/ > > Author: aheritier > Date: Wed Sep 14 07:06:20 2005 > New Revision: 280860 > > URL: http://svn.apache.org/viewcvs?rev=280860&view=rev > Log: > Replace the multiproject:goal by the reactor (workaround for MAVEN-1691). > Fix all tests in all plugins. > > Removed: > maven/maven-1/plugins/trunk/abbot/src/plugin-test/project.properties > maven/maven-1/plugins/trunk/clover/src/plugin-test/project.properties > maven/maven-1/plugins/trunk/cruisecontrol/src/plugin- > test/project.properties > maven/maven-1/plugins/trunk/eclipse/src/plugin-test/project.properties > Modified: > maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml > maven/maven-1/plugins/trunk/clover/src/plugin-test/maven.xml > maven/maven-1/plugins/trunk/cruisecontrol/src/plugin-test/maven.xml > maven/maven-1/plugins/trunk/dashboard/src/plugin-test/maven.xml > maven/maven-1/plugins/trunk/dashboard/src/plugin- > test/project.properties > maven/maven-1/plugins/trunk/eclipse/src/plugin-test/maven.xml > maven/maven-1/plugins/trunk/maven.xml > > Modified: maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml > URL: http://svn.apache.org/viewcvs/maven/maven- > 1/plugins/trunk/abbot/src/plugin- > test/maven.xml?rev=280860&r1=280859&r2=280860&view=diff > == > > --- maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml (original) > +++ maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml Wed Sep 14 > 07:06:20 2005 > @@ -1,6 +1,6 @@ > > > - > + > > > This plugin must be tested manually (with the testPlugin-manual > goal) as it requires defining a build.properties containing environment- > dependent configuration. > @@ -13,8 +13,7 @@ > environment variable must be set. --> > > > - > - > + goals="dist" banner="Test" ignoreFailures="false"/> > [snip] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r280860 - in /maven/maven-1/plugins/trunk: ./ abbot/src/plugin-test/ clover/src/plugin-test/ cruisecontrol/src/plugin-test/ dashboard/src/plugin-test/ eclipse/src/plugin-test/
Author: aheritier
Date: Wed Sep 14 07:06:20 2005
New Revision: 280860
URL: http://svn.apache.org/viewcvs?rev=280860&view=rev
Log:
Replace the multiproject:goal by the reactor (workaround for MAVEN-1691).
Fix all tests in all plugins.
Removed:
maven/maven-1/plugins/trunk/abbot/src/plugin-test/project.properties
maven/maven-1/plugins/trunk/clover/src/plugin-test/project.properties
maven/maven-1/plugins/trunk/cruisecontrol/src/plugin-test/project.properties
maven/maven-1/plugins/trunk/eclipse/src/plugin-test/project.properties
Modified:
maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml
maven/maven-1/plugins/trunk/clover/src/plugin-test/maven.xml
maven/maven-1/plugins/trunk/cruisecontrol/src/plugin-test/maven.xml
maven/maven-1/plugins/trunk/dashboard/src/plugin-test/maven.xml
maven/maven-1/plugins/trunk/dashboard/src/plugin-test/project.properties
maven/maven-1/plugins/trunk/eclipse/src/plugin-test/maven.xml
maven/maven-1/plugins/trunk/maven.xml
Modified: maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml
URL:
http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml?rev=280860&r1=280859&r2=280860&view=diff
==
--- maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml (original)
+++ maven/maven-1/plugins/trunk/abbot/src/plugin-test/maven.xml Wed Sep 14
07:06:20 2005
@@ -1,6 +1,6 @@
-
+
This plugin must be tested manually (with the testPlugin-manual
goal) as it requires defining a build.properties containing
environment-dependent configuration.
@@ -13,8 +13,7 @@
environment variable must be set. -->
-
-
+
Modified: maven/maven-1/plugins/trunk/clover/src/plugin-test/maven.xml
URL:
http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/clover/src/plugin-test/maven.xml?rev=280860&r1=280859&r2=280860&view=diff
==
--- maven/maven-1/plugins/trunk/clover/src/plugin-test/maven.xml (original)
+++ maven/maven-1/plugins/trunk/clover/src/plugin-test/maven.xml Wed Sep 14
07:06:20 2005
@@ -15,11 +15,10 @@
* limitations under the License.
*/
-->
-
+
-
-
+
Modified: maven/maven-1/plugins/trunk/cruisecontrol/src/plugin-test/maven.xml
URL:
http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/cruisecontrol/src/plugin-test/maven.xml?rev=280860&r1=280859&r2=280860&view=diff
==
--- maven/maven-1/plugins/trunk/cruisecontrol/src/plugin-test/maven.xml
(original)
+++ maven/maven-1/plugins/trunk/cruisecontrol/src/plugin-test/maven.xml Wed Sep
14 07:06:20 2005
@@ -15,14 +15,10 @@
* limitations under the License.
*/
-->
-
+
-
-
-
-
-
+
Modified: maven/maven-1/plugins/trunk/dashboard/src/plugin-test/maven.xml
URL:
http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/dashboard/src/plugin-test/maven.xml?rev=280860&r1=280859&r2=280860&view=diff
==
--- maven/maven-1/plugins/trunk/dashboard/src/plugin-test/maven.xml (original)
+++ maven/maven-1/plugins/trunk/dashboard/src/plugin-test/maven.xml Wed Sep 14
07:06:20 2005
@@ -20,6 +20,7 @@
xmlns:j="jelly:core"
xmlns:ant="jelly:ant"
xmlns:x="jelly:xml"
+ xmlns:maven="jelly:maven"
xmlns:assert="assert">
@@ -30,8 +31,7 @@
-
-
+
Modified:
maven/maven-1/plugins/trunk/dashboard/src/plugin-test/project.properties
URL:
http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/dashboard/src/plugin-test/project.properties?rev=280860&r1=280859&r2=280860&view=diff
==
--- maven/maven-1/plugins/trunk/dashboard/src/plugin-test/project.properties
(original)
+++ maven/maven-1/plugins/trunk/dashboard/src/plugin-test/project.properties
Wed Sep 14 07:06:20 2005
@@ -18,5 +18,5 @@
maven.multiproject.basedir = ${basedir}
maven.multiproject.includes = */project.xml
maven.multiproject.excludes = common/project.xml
-
+maven.multiproject.navigation = aggregate
maven.multiproject.site.goals = site,dashboard:report-single
Modified: maven/maven-1/plugins/trunk/eclipse/src/plugin-test/maven.xml
URL:
http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/eclipse/src/plugin-test/maven.xml?rev=280860&r1=280859&r2=280860&view=diff
==
--- maven/maven-1/plugins/trunk/eclipse/src/plugin-test/maven.xml (original)
+++ maven/maven-1/plugins/trunk/eclipse/src/plugin-test/maven.xml Wed Sep 14
07:06:20 2005
@@ -15,14 +15,10 @@
* limitations under the License.
*/
-->
-
+
-
-
-
-
-
+
Modified: maven/maven-1/plug
