[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r125007939
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -61,6 +62,7 @@
   private static final int KAFKA_RETRY = 10;
   @Autowired
   private KafkaComponent kafkaWithZKComponent;
+  private ComponentRunner runner;
--- End diff --

no, I think we've done enough.  We, honestly, need a test guidance document 
similar to the parser testing document that I created as part of this ticket.  
It's become evident from this exercise that we can provide some over-arching 
guidance here to limit the probability of us arriving in this situation again.  
But that's a follow-on, IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r125007493
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -61,6 +62,7 @@
   private static final int KAFKA_RETRY = 10;
   @Autowired
   private KafkaComponent kafkaWithZKComponent;
+  private ComponentRunner runner;
--- End diff --

I'm going to add a comment specifically pointing to that ticket, and noting 
that this test is an outlier in terms of how we actually test.

@cestella Is there anything else in particular that you'd like to see in 
order to at least mitigate risk of propagating test issues like this until we 
upgrade spring?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

GitHub user justinleet reopened a pull request:

https://github.com/apache/metron/pull/624

[DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

## Contributor Comments
This PR cleans up and speeds up various issues we've seen on Travis.

- This should avoid the skadoo, by just outright stopping problematic 
threads.
- Allows for the reuse of some of the InMemoryComponents, to avoid a lot of 
the spinup time in tests
- Improvements to a variety of tests to make them faster
- Refactoring of some parser integration tests to be less integrationy and 
more unit test-ish.  Specifically because not every parser needs a full 
integration test and they take awhile.
- Moving to VM in Travis
- More details as provided in comments

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/metron METRON-1004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet 
Date:   2017-06-23T13:15:02Z

first pass. Still need to fix storm kafka interaction + possibly cleanup

commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet 
Date:   2017-06-23T16:04:53Z

fixes plus logging

commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet 
Date:   2017-06-23T19:01:27Z

more stuffs

commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet 
Date:   2017-06-24T17:49:52Z

more fixes and update

commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet 
Date:   2017-06-24T18:37:15Z

removing error code

commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet 
Date:   2017-06-24T18:47:58Z

maybe making it work for superclasses like the parser tests.  Unsure if 
it'll maven

commit 

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124998536
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -61,6 +62,7 @@
   private static final int KAFKA_RETRY = 10;
   @Autowired
   private KafkaComponent kafkaWithZKComponent;
+  private ComponentRunner runner;
--- End diff --

I looked at it a bit this morning and @justinleet is right, it's not easily 
done.  I'm not super happy about spinning up and down components per test-case 
considering the bulk of this PR has been around removing exactly that.  That 
being said, the test is ~20s, so I'm not going to lose any sleep over it on 
that regard.

I think the part that I don't like most is the mixture of semantics between 
Spring's wiring of components and JUnit's setting up of components that we 
can't mix and match.  It leaves a muddle, frankly:
* If someone needs more heavy-weight components in other tests in this 
project, they will be *forced* into spinning up and down infrastructure per 
test-case, which has proven costly and was a prominent thing that we targeted 
in this PR for removal.
* Our approach leaves us doing component reuse in a way that is neither 
standard based on the other components *nor* standard based on spring, which is 
confusing and will inevitably lead to inefficient and confusing tests.

There is evidently a fix from spring 
[here](https://github.com/spring-projects/spring-kafka/issues/194) and I'm 
creating [METRON-1009](https://issues.apache.org/jira/browse/METRON-1009) to 
capture the reversion of this unit test and uptaking the fix provided by spring.

@merrimanr is right, it's not a requirement to get this perfect as long as 
we've removed the intermittent nature of the test failure (and I feel we have). 
 It's not so bad that I am -1, but it's ugly, confusing and it will lead to 
errors in the future IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

GitHub user justinleet reopened a pull request:

https://github.com/apache/metron/pull/624

[DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

## Contributor Comments
This PR cleans up and speeds up various issues we've seen on Travis.

- This should avoid the skadoo, by just outright stopping problematic 
threads.
- Allows for the reuse of some of the InMemoryComponents, to avoid a lot of 
the spinup time in tests
- Improvements to a variety of tests to make them faster
- Refactoring of some parser integration tests to be less integrationy and 
more unit test-ish.  Specifically because not every parser needs a full 
integration test and they take awhile.
- Moving to VM in Travis
- More details as provided in comments

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/metron METRON-1004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet 
Date:   2017-06-23T13:15:02Z

first pass. Still need to fix storm kafka interaction + possibly cleanup

commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet 
Date:   2017-06-23T16:04:53Z

fixes plus logging

commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet 
Date:   2017-06-23T19:01:27Z

more stuffs

commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet 
Date:   2017-06-24T17:49:52Z

more fixes and update

commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet 
Date:   2017-06-24T18:37:15Z

removing error code

commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet 
Date:   2017-06-24T18:47:58Z

maybe making it work for superclasses like the parser tests.  Unsure if 
it'll maven

commit 

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

GitHub user justinleet reopened a pull request:

https://github.com/apache/metron/pull/624

[DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

## Contributor Comments
This PR cleans up and speeds up various issues we've seen on Travis.

- This should avoid the skadoo, by just outright stopping problematic 
threads.
- Allows for the reuse of some of the InMemoryComponents, to avoid a lot of 
the spinup time in tests
- Improvements to a variety of tests to make them faster
- Refactoring of some parser integration tests to be less integrationy and 
more unit test-ish.  Specifically because not every parser needs a full 
integration test and they take awhile.
- Moving to VM in Travis
- More details as provided in comments

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/metron METRON-1004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet 
Date:   2017-06-23T13:15:02Z

first pass. Still need to fix storm kafka interaction + possibly cleanup

commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet 
Date:   2017-06-23T16:04:53Z

fixes plus logging

commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet 
Date:   2017-06-23T19:01:27Z

more stuffs

commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet 
Date:   2017-06-24T17:49:52Z

more fixes and update

commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet 
Date:   2017-06-24T18:37:15Z

removing error code

commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet 
Date:   2017-06-24T18:47:58Z

maybe making it work for superclasses like the parser tests.  Unsure if 
it'll maven

commit 

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

GitHub user justinleet reopened a pull request:

https://github.com/apache/metron/pull/624

[DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

## Contributor Comments
This PR cleans up and speeds up various issues we've seen on Travis.

- This should avoid the skadoo, by just outright stopping problematic 
threads.
- Allows for the reuse of some of the InMemoryComponents, to avoid a lot of 
the spinup time in tests
- Improvements to a variety of tests to make them faster
- Refactoring of some parser integration tests to be less integrationy and 
more unit test-ish.  Specifically because not every parser needs a full 
integration test and they take awhile.
- Moving to VM in Travis
- More details as provided in comments

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/metron METRON-1004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet 
Date:   2017-06-23T13:15:02Z

first pass. Still need to fix storm kafka interaction + possibly cleanup

commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet 
Date:   2017-06-23T16:04:53Z

fixes plus logging

commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet 
Date:   2017-06-23T19:01:27Z

more stuffs

commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet 
Date:   2017-06-24T17:49:52Z

more fixes and update

commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet 
Date:   2017-06-24T18:37:15Z

removing error code

commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet 
Date:   2017-06-24T18:47:58Z

maybe making it work for superclasses like the parser tests.  Unsure if 
it'll maven

commit 

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[merrimanr]

Github user merrimanr commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124927666
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -61,6 +62,7 @@
   private static final int KAFKA_RETRY = 10;
   @Autowired
   private KafkaComponent kafkaWithZKComponent;
+  private ComponentRunner runner;
--- End diff --

I don't think this is that critical to getting us back to a working travis 
build.  Just my opinion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124922704
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -61,6 +62,7 @@
   private static final int KAFKA_RETRY = 10;
   @Autowired
   private KafkaComponent kafkaWithZKComponent;
+  private ComponentRunner runner;
--- End diff --

I don't think so.  `setup()` uses kafkaWithZKComponent, which is 
`@Autowired`.  I don't think that can be static, so there's probably more 
refactoring involved.  I can look at it, if it you want.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124922443
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -148,6 +150,15 @@ public void stop() {
 
   @Before
   public void setup() throws Exception {
+runner = new ComponentRunner.Builder()
+.withComponent("kafka", kafkaWithZKComponent)
+.withCustomShutdownOrder(new String[]{"kafka"})
+.build();
+try {
+  runner.start();
+} catch (UnableToStartException e) {
+  e.printStackTrace();
--- End diff --

I'd be ok with that.  This will just mask an error until it fails later 
less explicably.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124921605
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -148,6 +150,15 @@ public void stop() {
 
   @Before
   public void setup() throws Exception {
+runner = new ComponentRunner.Builder()
+.withComponent("kafka", kafkaWithZKComponent)
+.withCustomShutdownOrder(new String[]{"kafka"})
+.build();
+try {
+  runner.start();
+} catch (UnableToStartException e) {
+  e.printStackTrace();
--- End diff --

Also, we should throw a runtime exception here, probably.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124921122
  
--- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
 ---
@@ -61,6 +62,7 @@
   private static final int KAFKA_RETRY = 10;
   @Autowired
   private KafkaComponent kafkaWithZKComponent;
+  private ComponentRunner runner;
--- End diff --

Can we make this and `setup()` static and make the setup/teardown be 
@BeforeClass/@AfterClass?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124875780
  
--- Diff: 
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/components/ElasticSearchComponent.java
 ---
@@ -24,6 +24,8 @@
 import org.elasticsearch.action.admin.cluster.health.ClusterHealthAction;
 import org.elasticsearch.action.admin.cluster.health.ClusterHealthRequest;
 import org.elasticsearch.action.admin.cluster.health.ClusterHealthResponse;
+import org.elasticsearch.action.admin.indices.delete.DeleteIndexRequest;
--- End diff --

Because I tried something that didn't end up being useful, and didn't clean 
it up. I'll drop them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[merrimanr]

Github user merrimanr commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124869167
  
--- Diff: 
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/components/ElasticSearchComponent.java
 ---
@@ -24,6 +24,8 @@
 import org.elasticsearch.action.admin.cluster.health.ClusterHealthAction;
 import org.elasticsearch.action.admin.cluster.health.ClusterHealthRequest;
 import org.elasticsearch.action.admin.cluster.health.ClusterHealthResponse;
+import org.elasticsearch.action.admin.indices.delete.DeleteIndexRequest;
--- End diff --

why were the imports added?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

GitHub user justinleet reopened a pull request:

https://github.com/apache/metron/pull/624

[DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

## Contributor Comments
Given that Apache travis fails more often, I'm using this PR to hopefully 
hit the skidoo clause more.  First step is adding more logging to see what's 
even happening when we kill slots.  Also calls a Thread.interrupt on the slot 
out of morbid curiosity.


## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/metron METRON-1004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet 
Date:   2017-06-23T13:15:02Z

first pass. Still need to fix storm kafka interaction + possibly cleanup

commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet 
Date:   2017-06-23T16:04:53Z

fixes plus logging

commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet 
Date:   2017-06-23T19:01:27Z

more stuffs

commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet 
Date:   2017-06-24T17:49:52Z

more fixes and update

commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet 
Date:   2017-06-24T18:37:15Z

removing error code

commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet 
Date:   2017-06-24T18:47:58Z

maybe making it work for superclasses like the parser tests.  Unsure if 
it'll maven

commit fa5c05205e4d5bf17d5ea665fd98711085391403
Author: justinjleet 
Date:   2017-06-25T00:18:00Z

Removing approximately 1M log errors by actually cleaning up ZK

commit a5b152e0e300640364fc28a1ae1bc80d7be4f628
Author: justinjleet 
Date:   2017-06-25T02:04:44Z

empty

commit 

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124842566
  
--- Diff: 
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/integration/ParserDriver.java
 ---
@@ -0,0 +1,168 @@
+/**
--- End diff --

readme about parser committed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124821374
  
--- Diff: 
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/integration/ParserDriver.java
 ---
@@ -0,0 +1,168 @@
+/**
--- End diff --

I can provide a readme about parser testing, yep.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124821164
  
--- Diff: 
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/integration/ParserDriver.java
 ---
@@ -0,0 +1,168 @@
+/**
--- End diff --

As I see it, there are a couple of things we want to test for every parser:
* The parser works (i.e. the unit tests we currently have)
* The parser can be driven from within the `ParserBolt` (the current 
integration tests as of this PR)

Beyond that, I think it's reasonable to have a `ParserIntegrationTest` 
which just validates data flows through the parser topology assuming a 
correctly working parser and just validates that things work within Storm.  I 
would not expect every parser to require this kind of test.  We have something 
similar to that in `SimpleHbaseEnrichmentWriterIntegrationTest`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[ottobackwards]

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124811748
  
--- Diff: 
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/integration/ParserDriver.java
 ---
@@ -0,0 +1,168 @@
+/**
--- End diff --

How bad would it be to keep both types of tests?  If we actually wanted to 
do the old integration tests for certain types of build ( outside of travis )?  
Like validation of releases or pre-pr commit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

GitHub user justinleet reopened a pull request:

https://github.com/apache/metron/pull/624

[DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

## Contributor Comments
Given that Apache travis fails more often, I'm using this PR to hopefully 
hit the skidoo clause more.  First step is adding more logging to see what's 
even happening when we kill slots.  Also calls a Thread.interrupt on the slot 
out of morbid curiosity.


## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/metron METRON-1004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet 
Date:   2017-06-23T13:15:02Z

first pass. Still need to fix storm kafka interaction + possibly cleanup

commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet 
Date:   2017-06-23T16:04:53Z

fixes plus logging

commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet 
Date:   2017-06-23T19:01:27Z

more stuffs

commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet 
Date:   2017-06-24T17:49:52Z

more fixes and update

commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet 
Date:   2017-06-24T18:37:15Z

removing error code

commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet 
Date:   2017-06-24T18:47:58Z

maybe making it work for superclasses like the parser tests.  Unsure if 
it'll maven

commit fa5c05205e4d5bf17d5ea665fd98711085391403
Author: justinjleet 
Date:   2017-06-25T00:18:00Z

Removing approximately 1M log errors by actually cleaning up ZK

commit a5b152e0e300640364fc28a1ae1bc80d7be4f628
Author: justinjleet 
Date:   2017-06-25T02:04:44Z

empty

commit 

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124317746
  
--- Diff: .travis.yml ---
@@ -17,7 +17,7 @@ before_install:
   - export PATH=$M2_HOME/bin:$PATH
 script:
   - |
--- End diff --

Sorry, my bad.  Usually I tend to consider the commits less important 
because it's usually a full feature, and it's just minor changes / fixes 
afterwards.

I'll try to make sure the messages are easier to follow, since this is 
pretty ongoing until it's consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[ottobackwards]

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124314669
  
--- Diff: .travis.yml ---
@@ -17,7 +17,7 @@ before_install:
   - export PATH=$M2_HOME/bin:$PATH
 script:
   - |
--- End diff --

because it makes it slow right?  
Can we document with the commits, as you go, the rationale behind the 
changes, so we can look back and understand a little bit?  

"why did we get rid of FOO?"
Let me check the commit log
> " Remove foo.  It is seen to cause an increase of X in Y and do z.  it is 
also pretty snarky and fresh"
"Oh, that makes sense"



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[ottobackwards]

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/624#discussion_r124314003
  
--- Diff: 
metron-platform/metron-pcap-backend/src/test/java/org/apache/metron/pcap/integration/PcapTopologyIntegrationTest.java
 ---
@@ -90,23 +90,6 @@ public boolean accept(File dir, String name) {
   }
 
--- End diff --

I think until this is completely deprecated, we should keep the test, but 
disable it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

GitHub user justinleet reopened a pull request:

https://github.com/apache/metron/pull/624

[DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maximum Time Limit

## Contributor Comments
Given that Apache travis fails more often, I'm using this PR to hopefully 
hit the skidoo clause more.  First step is adding more logging to see what's 
even happening when we kill slots.  Also calls a Thread.interrupt on the slot 
out of morbid curiosity.


## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/metron METRON-1004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit bd484b5a0bede9214ec39a3c6f4192d9e948ed35
Author: justinjleet 
Date:   2017-06-23T13:15:02Z

first pass. Still need to fix storm kafka interaction + possibly cleanup

commit a470063422314711ec99a298d646202deda32fba
Author: justinjleet 
Date:   2017-06-23T16:04:53Z

fixes plus logging

commit 05e0a6468d283a2ee6a0ce4be8c551373be7f75b
Author: justinjleet 
Date:   2017-06-23T19:01:27Z

more stuffs

commit 05b9c1f0d04a76afb97c90c33d82268618129806
Author: justinjleet 
Date:   2017-06-24T17:49:52Z

more fixes and update

commit 912575eb92b2baf6f1334991372a883ad252d866
Author: justinjleet 
Date:   2017-06-24T18:37:15Z

removing error code

commit 11473f63841e18cef2fbb046c70c2e052b498b4f
Author: justinjleet 
Date:   2017-06-24T18:47:58Z

maybe making it work for superclasses like the parser tests.  Unsure if 
it'll maven

commit fa5c05205e4d5bf17d5ea665fd98711085391403
Author: justinjleet 
Date:   2017-06-25T00:18:00Z

Removing approximately 1M log errors by actually cleaning up ZK

commit a5b152e0e300640364fc28a1ae1bc80d7be4f628
Author: justinjleet 
Date:   2017-06-25T02:04:44Z

empty

commit 

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

[justinleet]

Github user justinleet closed the pull request at:

https://github.com/apache/metron/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---