Re: Review Request 46287: Add a double serde.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46287/#review139219 --- In addition to the documentation changes, there is also a need to update Util.scala class to add the support for "double" as a build-in serde factory name. - Yi Pan (Data Infrastructure) On April 15, 2016, 11:17 p.m., Jon Bringhurst wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46287/ > --- > > (Updated April 15, 2016, 11:17 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-936 > https://issues.apache.org/jira/browse/SAMZA-936 > > > Repository: samza > > > Description > --- > > Add a simple double serde. > > > Diffs > - > > samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/46287/diff/ > > > Testing > --- > > A simple unit test was added. > > > Thanks, > > Jon Bringhurst > >
Re: Review Request 46287: Add a double serde.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46287/#review132689 --- @Jon, forgot to mention: it would be good to add this new build-in serde class to the document. One example is in the configure table. - Yi Pan (Data Infrastructure) On April 15, 2016, 11:17 p.m., Jon Bringhurst wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46287/ > --- > > (Updated April 15, 2016, 11:17 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-936 > https://issues.apache.org/jira/browse/SAMZA-936 > > > Repository: samza > > > Description > --- > > Add a simple double serde. > > > Diffs > - > > samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/46287/diff/ > > > Testing > --- > > A simple unit test was added. > > > Thanks, > > Jon Bringhurst > >
Re: Review Request 46287: Add a double serde.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46287/#review132481 --- Ship it! +1. lgtm! - Yi Pan (Data Infrastructure) On April 15, 2016, 11:17 p.m., Jon Bringhurst wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46287/ > --- > > (Updated April 15, 2016, 11:17 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-936 > https://issues.apache.org/jira/browse/SAMZA-936 > > > Repository: samza > > > Description > --- > > Add a simple double serde. > > > Diffs > - > > samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/46287/diff/ > > > Testing > --- > > A simple unit test was added. > > > Thanks, > > Jon Bringhurst > >
Re: Review Request 46287: Add a double serde.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46287/#review129210 --- Ship it! Ship It! - Jake Maes On April 15, 2016, 11:17 p.m., Jon Bringhurst wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46287/ > --- > > (Updated April 15, 2016, 11:17 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-936 > https://issues.apache.org/jira/browse/SAMZA-936 > > > Repository: samza > > > Description > --- > > Add a simple double serde. > > > Diffs > - > > samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/46287/diff/ > > > Testing > --- > > A simple unit test was added. > > > Thanks, > > Jon Bringhurst > >
Review Request 46287: Add a double serde.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46287/ --- Review request for samza. Bugs: SAMZA-936 https://issues.apache.org/jira/browse/SAMZA-936 Repository: samza Description --- Add a simple double serde. Diffs - samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala PRE-CREATION samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala PRE-CREATION Diff: https://reviews.apache.org/r/46287/diff/ Testing --- A simple unit test was added. Thanks, Jon Bringhurst
