[jira] [Resolved] (SLING-6449) Remove unused Executor service reference

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6449.
-
Resolution: Fixed

Removed the reference

> Remove unused Executor service reference
> 
>
> Key: SLING-6449
> URL: https://issues.apache.org/jira/browse/SLING-6449
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR Resource 2.9.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: JCR Resource 2.9.4
>
>
> The JcrResourceProvider has an unused, optional service reference to an 
> executor service. This can be removed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-6449) Remove unused Executor service reference

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-6449:
---

 Summary: Remove unused Executor service reference
 Key: SLING-6449
 URL: https://issues.apache.org/jira/browse/SLING-6449
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Affects Versions: JCR Resource 2.9.2
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Resource 2.9.4


The JcrResourceProvider has an unused, optional service reference to an 
executor service. This can be removed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[RESULT] [VOTE] Release junit.core:1.0.23, junit.teleporter:1.0.10, testing.clients:1.0.1, testing.rules:1.0.1, testing.serversetup:1.0.1

[Andrei Dulvac]

Hi,

The vote has passed with 3 binding votes.
Can a PMC help copy these releases to the Sling dist directory and promote
the artifacts to maven central?

Thanks,
- Andrei

Re: [VOTE] Release junit.core:1.0.23, junit.teleporter:1.0.10, testing.clients:1.0.1, testing.rules:1.0.1, testing.serversetup:1.0.1

[Andrei Dulvac]

Thanks a lot for the review and votes and sorry for not using the odd/even
release policy, I'll make sure I pay attention to that next time.

Thanks,
- Andrei

On Mon, Jan 9, 2017 at 11:44 AM Robert Munteanu  wrote:

> On Fri, 2017-01-06 at 11:37 +, Andrei Dulvac wrote:
> > Please vote to approve this release:
>
> +1
>
> Robert

[jira] [Commented] (SLING-6448) Not able to upload file when sling running as war file using curl

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817489#comment-15817489
 ] 

Robert Munteanu commented on SLING-6448:


But how did you change the pom.xml file?

> Not able to upload file when sling running as war file using curl
> -
>
> Key: SLING-6448
> URL: https://issues.apache.org/jira/browse/SLING-6448
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Affects Versions: Launchpad Builder 9
> Environment: Windows, Apache 
>Reporter: Ravi Singareddy
>
> Here are steps followed
> 1) Checked out code from svn
> svn co http://svn.apache.org/repos/asf/sling/trunk sling
> 2) cd sling
> 3) cd launchpad/builder
> 4) mvn --update-snapshots clean install
> 5) mvn jetty:run-war
> (please note I have add jetty dependency in pom.xml to run above command)
> I have used curl to upload file
> >> curl -u admin:admin http://localhost:8080/content/test.html --upload-file 
> >> test.html
> is giving following error: PUT 405 Error
> d:\curl-7.52.1-win64-mingw\bin\curl.exe -u admin:admin 
> http://localhost:8080/content/test.html --upload-file test.html
> 
> 
> 
> 405 Method PUT not supported
> 
> 
> Method PUT not supported (405)
> The requested URL /content/test.html resulted in an error in Apache Sling
>  Core Default Servlet.
> Request Progress:
> 
>   0 TIMER_START{Request Processing}
>   2 COMMENT timer_end format is {elapsed microseconds,timer 
> name
> } optional message
>  10 LOG Method=PUT, PathInfo=null
>  21 TIMER_START{handleSecurity}
>2418 TIMER_END{2395,handleSecurity} authenticator 
> org.apache.sling.auth.core.
> impl.SlingAuthenticator@68556f8e returns true
>3517 TIMER_START{ResourceResolution}
>3925 TIMER_END{406,ResourceResolution} URI=/content/test.html resolves to
>  Resource=NonExistingResource, path=/content/test.html
>3936 LOG Resource Path Info: SlingRequestPathInfo: 
> path=/content/landin
> g.html, selectorString=null, extension=html, suf
> fix=null
>3936 TIMER_START{ServletResolution}
>3941 TIMER_START{resolveServlet(/content/test.html)}
>4367 TIMER_END{423,resolveServlet(/content/test.html)} Using servlet Apac
> he Sling Core Default Servlet
>4371 TIMER_END{434,ServletResolution} URI=/content/test.html handled by S
> ervlet=Apache Sling Core Default Servlet
>4378 LOG Applying Requestfilters
>4385 LOG Calling filter: org.apache.sling.i18n.impl.I18NFilter
>4392 LOG Calling filter: 
> org.apache.sling.engine.impl.debug.RequestProgressTr
> ackerLogFilter
>4397 LOG Applying Componentfilters
>4409 TIMER_START{Apache Sling Core Default Servlet#0}
>4425 LOG Applying Error filters
>4428 LOG Calling filter: org.apache.sling.i18n.impl.I18NFilter
>4433 TIMER_START{handleError:status=405}
>4577 TIMER_END{143,handleError:status=405} Using handler 
> org.apache.sling.ser
> vlets.resolver.internal.defaults.DefaultErrorHandlerServlet
>5111 TIMER_END{5109,Request Processing} Dumping 
> SlingRequestProgressTracker E
> ntries
> 
> 
> ApacheSling/2.6 (jetty/9.3.12.v20160915, Java HotSpot(TM) 64-Bit 
> Server
>  VM 1.8.0_102, Windows 8 6.2 amd64)
> 
> 
> ___
> But If start sling using executable jar able to upload the file using curl.
> java -Xmx4g -Xms4g -Dsling.home=\var\sling -Dsling.run.modes=oak -jar 
> target\org.apache.sling.launchpad-9-SNAPSHOT.jar start
> Thanks
> Ravi



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6448) Not able to upload file when sling running as war file using curl

[Ravi Singareddy (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816842#comment-15816842
 ] 

Ravi Singareddy commented on SLING-6448:


>> mvn clean install
>> mvn jetty:run-war

> Not able to upload file when sling running as war file using curl
> -
>
> Key: SLING-6448
> URL: https://issues.apache.org/jira/browse/SLING-6448
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Affects Versions: Launchpad Builder 9
> Environment: Windows, Apache 
>Reporter: Ravi Singareddy
>
> Here are steps followed
> 1) Checked out code from svn
> svn co http://svn.apache.org/repos/asf/sling/trunk sling
> 2) cd sling
> 3) cd launchpad/builder
> 4) mvn --update-snapshots clean install
> 5) mvn jetty:run-war
> (please note I have add jetty dependency in pom.xml to run above command)
> I have used curl to upload file
> >> curl -u admin:admin http://localhost:8080/content/test.html --upload-file 
> >> test.html
> is giving following error: PUT 405 Error
> d:\curl-7.52.1-win64-mingw\bin\curl.exe -u admin:admin 
> http://localhost:8080/content/test.html --upload-file test.html
> 
> 
> 
> 405 Method PUT not supported
> 
> 
> Method PUT not supported (405)
> The requested URL /content/test.html resulted in an error in Apache Sling
>  Core Default Servlet.
> Request Progress:
> 
>   0 TIMER_START{Request Processing}
>   2 COMMENT timer_end format is {elapsed microseconds,timer 
> name
> } optional message
>  10 LOG Method=PUT, PathInfo=null
>  21 TIMER_START{handleSecurity}
>2418 TIMER_END{2395,handleSecurity} authenticator 
> org.apache.sling.auth.core.
> impl.SlingAuthenticator@68556f8e returns true
>3517 TIMER_START{ResourceResolution}
>3925 TIMER_END{406,ResourceResolution} URI=/content/test.html resolves to
>  Resource=NonExistingResource, path=/content/test.html
>3936 LOG Resource Path Info: SlingRequestPathInfo: 
> path=/content/landin
> g.html, selectorString=null, extension=html, suf
> fix=null
>3936 TIMER_START{ServletResolution}
>3941 TIMER_START{resolveServlet(/content/test.html)}
>4367 TIMER_END{423,resolveServlet(/content/test.html)} Using servlet Apac
> he Sling Core Default Servlet
>4371 TIMER_END{434,ServletResolution} URI=/content/test.html handled by S
> ervlet=Apache Sling Core Default Servlet
>4378 LOG Applying Requestfilters
>4385 LOG Calling filter: org.apache.sling.i18n.impl.I18NFilter
>4392 LOG Calling filter: 
> org.apache.sling.engine.impl.debug.RequestProgressTr
> ackerLogFilter
>4397 LOG Applying Componentfilters
>4409 TIMER_START{Apache Sling Core Default Servlet#0}
>4425 LOG Applying Error filters
>4428 LOG Calling filter: org.apache.sling.i18n.impl.I18NFilter
>4433 TIMER_START{handleError:status=405}
>4577 TIMER_END{143,handleError:status=405} Using handler 
> org.apache.sling.ser
> vlets.resolver.internal.defaults.DefaultErrorHandlerServlet
>5111 TIMER_END{5109,Request Processing} Dumping 
> SlingRequestProgressTracker E
> ntries
> 
> 
> ApacheSling/2.6 (jetty/9.3.12.v20160915, Java HotSpot(TM) 64-Bit 
> Server
>  VM 1.8.0_102, Windows 8 6.2 amd64)
> 
> 
> ___
> But If start sling using executable jar able to upload the file using curl.
> java -Xmx4g -Xms4g -Dsling.home=\var\sling -Dsling.run.modes=oak -jar 
> target\org.apache.sling.launchpad-9-SNAPSHOT.jar start
> Thanks
> Ravi



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Jenkins build is still unstable: sling-ide #92

[Konrad Windszus]

I fixed the previous testing errors in for the sling-ide build 91, but build 92 
fails now in

org.eclipse.swtbot.swt.finder.widgets.TimeoutException: Timeout after: 5000 
ms.: Could not find auto complete proposal using matcher table with item ()
at 
org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:437)
at 
org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:411)
at 
org.eclipse.swtbot.eclipse.finder.widgets.SWTBotEclipseEditor.waitUntil(SWTBotEclipseEditor.java:784)
at 
org.eclipse.swtbot.eclipse.finder.widgets.SWTBotEclipseEditor.getAutoCompleteProposals(SWTBotEclipseEditor.java:245)
at 
org.apache.sling.ide.test.impl.ui.sightly.SightlyAutocompletionTest$AutocompletionCallable.call(SightlyAutocompletionTest.java:145)
at 
org.apache.sling.ide.test.impl.ui.sightly.SightlyAutocompletionTest.attributeAutocompletion(SightlyAutocompletionTest.java:84)

@Robert: Do you have any idea how we could make the SWTBot based tests more 
reliable. Should we increase the timeout like described in 
https://wiki.eclipse.org/SWTBot/FAQ#Can_I_change_the_timeout_for_execution_of_SWTBot_tests.3F?



> On 10 Jan 2017, at 19:08, Apache Jenkins Server  
> wrote:
> 
> See 
> 

[jira] [Resolved] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-6368.

Resolution: Fixed

> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR 
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6368-testv02.patch, SLING-6368-v01.patch, 
> content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{title: Resolved 
> Segments,icon: 
> coral-Icon--targeted,storeMapping: 
> {s: segmentation
> },template: p 
> class=\\contexthub-module-line1\\>Resolved Segments/p>p 
> class=\\contexthub-module-line2\\>{{s.summary}}/p>,
> clickable: true,listReference: 
> /store/segmentation/segments,listType: 
> custom,listItemTemplate: 
> span>{{label}}/span>,
> itemOnClickNoop: true}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as 
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved 
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same 
> attribute is being stored in the JCR with value 
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816460#comment-15816460
 ] 

Konrad Windszus commented on SLING-6368:


Fixed in [r1778218|https://svn.apache.org/r1778218] by applying the slightly 
modified patch (without stripping the version number from the generated 
filenames).

> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR 
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6368-testv02.patch, SLING-6368-v01.patch, 
> content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{title: Resolved 
> Segments,icon: 
> coral-Icon--targeted,storeMapping: 
> {s: segmentation
> },template: p 
> class=\\contexthub-module-line1\\>Resolved Segments/p>p 
> class=\\contexthub-module-line2\\>{{s.summary}}/p>,
> clickable: true,listReference: 
> /store/segmentation/segments,listType: 
> custom,listItemTemplate: 
> span>{{label}}/span>,
> itemOnClickNoop: true}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as 
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved 
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same 
> attribute is being stored in the JCR with value 
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6344) Support filter.xmls being generated by the content-package-maven-plugin

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815746#comment-15815746
 ] 

Robert Munteanu commented on SLING-6344:


Sounds like a good first step to me.

> Support filter.xmls being generated by the content-package-maven-plugin
> ---
>
> Key: SLING-6344
> URL: https://issues.apache.org/jira/browse/SLING-6344
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: SLING-6344-v01.patch, SLING-6344-v02.patch, 
> SLING-6344-v03.patch
>
>
> The content-package-maven plugin can not only consume a filter.xml from the 
> source directory, but also generate or merge filter.xmls. Therefore Sling IDE 
> should consider only the filter.xml in the generated artifacts (package). The 
> problem with that is, that content-package-maven-plugin does only generate 
> that filter.xml when it generates the real package.
> There is one other related issue: In case a filter file is not found, the 
> method {{ResourceChangeCommandFactory#getFilterResult}} returns {{ALLOW}} 
> while it should return {{DENY}} to not overwrite any nodes in case the filter 
> rules could not be determined.
> In my case those two problems lead to a modification of the jcr:primaryType 
> of the root node in the JCR from {{rep:root}} to {{nt:unstructured}} and the 
> resourceType from {{sling:redirect}} to just being removed which breaks the 
> redirect handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6344) Support filter.xmls being generated by the content-package-maven-plugin

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815644#comment-15815644
 ] 

Konrad Windszus commented on SLING-6344:


Yes, I agree. IMHO we should disable a) syncing b) explicit import and c) 
explicit export. At least a) causes right now problems by destroying content 
(see the original description of the issue). And since we want to handle all 
three use cases with the same underlying filter concept we just prevent all. 

So the first fix should would in case of a generated filter.xml prevent content 
from being destroyed (by disabling sync/import and export alltogether).

As a second step we could look into supporting generated filter.xmls better.

> Support filter.xmls being generated by the content-package-maven-plugin
> ---
>
> Key: SLING-6344
> URL: https://issues.apache.org/jira/browse/SLING-6344
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: SLING-6344-v01.patch, SLING-6344-v02.patch, 
> SLING-6344-v03.patch
>
>
> The content-package-maven plugin can not only consume a filter.xml from the 
> source directory, but also generate or merge filter.xmls. Therefore Sling IDE 
> should consider only the filter.xml in the generated artifacts (package). The 
> problem with that is, that content-package-maven-plugin does only generate 
> that filter.xml when it generates the real package.
> There is one other related issue: In case a filter file is not found, the 
> method {{ResourceChangeCommandFactory#getFilterResult}} returns {{ALLOW}} 
> while it should return {{DENY}} to not overwrite any nodes in case the filter 
> rules could not be determined.
> In my case those two problems lead to a modification of the jcr:primaryType 
> of the root node in the JCR from {{rep:root}} to {{nt:unstructured}} and the 
> resourceType from {{sling:redirect}} to just being removed which breaks the 
> redirect handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6344) Support filter.xmls being generated by the content-package-maven-plugin

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815374#comment-15815374
 ] 

Robert Munteanu commented on SLING-6344:


If we can't support generated filter.xml files, what would be the gain then? 
Export/Import would not work but syncing would which is incosistent IMO. I 
would prefer that we do this for all situations.

> Support filter.xmls being generated by the content-package-maven-plugin
> ---
>
> Key: SLING-6344
> URL: https://issues.apache.org/jira/browse/SLING-6344
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: SLING-6344-v01.patch, SLING-6344-v02.patch, 
> SLING-6344-v03.patch
>
>
> The content-package-maven plugin can not only consume a filter.xml from the 
> source directory, but also generate or merge filter.xmls. Therefore Sling IDE 
> should consider only the filter.xml in the generated artifacts (package). The 
> problem with that is, that content-package-maven-plugin does only generate 
> that filter.xml when it generates the real package.
> There is one other related issue: In case a filter file is not found, the 
> method {{ResourceChangeCommandFactory#getFilterResult}} returns {{ALLOW}} 
> while it should return {{DENY}} to not overwrite any nodes in case the filter 
> rules could not be determined.
> In my case those two problems lead to a modification of the jcr:primaryType 
> of the root node in the JCR from {{rep:root}} to {{nt:unstructured}} and the 
> resourceType from {{sling:redirect}} to just being removed which breaks the 
> redirect handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6344) Support filter.xmls being generated by the content-package-maven-plugin

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815331#comment-15815331
 ] 

Konrad Windszus commented on SLING-6344:


Ok, I just want to point out that I would need to change the import/export 
wizard to clarify that then. And in fact I know several projects leveraging the 
content-package-maven-plugin feature to generate the filter.xml which would 
then prevent to use syncing/import/export (unless we would be able to detect 
that as well). Since I don't have a proper solution for supporting the 
generated filter.xmls of that plugin, I would go forward with just proposing a 
patch which prevents any content without a proper filter.xml to be 
imported/exported.

> Support filter.xmls being generated by the content-package-maven-plugin
> ---
>
> Key: SLING-6344
> URL: https://issues.apache.org/jira/browse/SLING-6344
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: SLING-6344-v01.patch, SLING-6344-v02.patch, 
> SLING-6344-v03.patch
>
>
> The content-package-maven plugin can not only consume a filter.xml from the 
> source directory, but also generate or merge filter.xmls. Therefore Sling IDE 
> should consider only the filter.xml in the generated artifacts (package). The 
> problem with that is, that content-package-maven-plugin does only generate 
> that filter.xml when it generates the real package.
> There is one other related issue: In case a filter file is not found, the 
> method {{ResourceChangeCommandFactory#getFilterResult}} returns {{ALLOW}} 
> while it should return {{DENY}} to not overwrite any nodes in case the filter 
> rules could not be determined.
> In my case those two problems lead to a modification of the jcr:primaryType 
> of the root node in the JCR from {{rep:root}} to {{nt:unstructured}} and the 
> resourceType from {{sling:redirect}} to just being removed which breaks the 
> redirect handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6344) Support filter.xmls being generated by the content-package-maven-plugin

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815284#comment-15815284
 ] 

Robert Munteanu commented on SLING-6344:


I think it's fine to require a filter.xml at all times. There is no reason to 
support a missing filter.xml scenario except some developer convenience and I 
assume all real-world projects have a filter.xml defined anyway.

> Support filter.xmls being generated by the content-package-maven-plugin
> ---
>
> Key: SLING-6344
> URL: https://issues.apache.org/jira/browse/SLING-6344
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: SLING-6344-v01.patch, SLING-6344-v02.patch, 
> SLING-6344-v03.patch
>
>
> The content-package-maven plugin can not only consume a filter.xml from the 
> source directory, but also generate or merge filter.xmls. Therefore Sling IDE 
> should consider only the filter.xml in the generated artifacts (package). The 
> problem with that is, that content-package-maven-plugin does only generate 
> that filter.xml when it generates the real package.
> There is one other related issue: In case a filter file is not found, the 
> method {{ResourceChangeCommandFactory#getFilterResult}} returns {{ALLOW}} 
> while it should return {{DENY}} to not overwrite any nodes in case the filter 
> rules could not be determined.
> In my case those two problems lead to a modification of the jcr:primaryType 
> of the root node in the JCR from {{rep:root}} to {{nt:unstructured}} and the 
> resourceType from {{sling:redirect}} to just being removed which breaks the 
> redirect handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5014) Installer blacklist, to avoid reinstalling older bundles

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815010#comment-15815010
 ] 

Bertrand Delacretaz commented on SLING-5014:


Do we have any documentation on this?

I have a similar use case where I'd like to completely ignore some resources 
that are supplied to the installer, based on patterns in their URLs, when 
starting a fresh Sling instance.

Does this feature help for that?

> Installer blacklist, to avoid reinstalling older bundles
> 
>
> Key: SLING-5014
> URL: https://issues.apache.org/jira/browse/SLING-5014
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.6.6
>Reporter: Dominik Süß
>Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.7.0
>
> Attachments: SLING-5014-1.diff
>
>
> In case a bundle has mutliple install candiates only the highest version 
> (with the highest priorty for the same versions) wins. An uninstall directive 
> in the Sling bootstrap.txt file or provisioning model uninstalls this 
> version. The way the OSGi install behavior is defined this lets the next 
> artifact in the priority queue to get active and consequently only leads to 
> downgrade to the next in the queue.
> As the uninstall directive declares a range that should be uninstalled the 
> expectation is that after a startup with such an uninstall directive none of 
> the declared versions are in an installed state. In consequence the OSGi 
> installer must save this metainformation in the state that prevents a 
> downgrade to a version that is part of an active uninstall directive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6344) Support filter.xmls being generated by the content-package-maven-plugin

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814940#comment-15814940
 ] 

Konrad Windszus commented on SLING-6344:


[~rombert] Ok, I see. Since I reverted the patch anyhow for other issues that 
should currently be no longer an issue. Before I come up with a new patch I 
would like to get your opinion also on the general semantics that no 
import/export should take place for nodes in a project not having a filter.xml. 
Currently at least the {{o.a.s.ide.eclipse.ui.internal.ExportWizardPage}} and 
{{ImportWizardPage}} assume that in such a case everything is imported/exported 
(and some ITs also rely on that behaviour). If I change the semantics I would 
need to change those places as well. WDYT?

> Support filter.xmls being generated by the content-package-maven-plugin
> ---
>
> Key: SLING-6344
> URL: https://issues.apache.org/jira/browse/SLING-6344
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: SLING-6344-v01.patch, SLING-6344-v02.patch, 
> SLING-6344-v03.patch
>
>
> The content-package-maven plugin can not only consume a filter.xml from the 
> source directory, but also generate or merge filter.xmls. Therefore Sling IDE 
> should consider only the filter.xml in the generated artifacts (package). The 
> problem with that is, that content-package-maven-plugin does only generate 
> that filter.xml when it generates the real package.
> There is one other related issue: In case a filter file is not found, the 
> method {{ResourceChangeCommandFactory#getFilterResult}} returns {{ALLOW}} 
> while it should return {{DENY}} to not overwrite any nodes in case the filter 
> rules could not be determined.
> In my case those two problems lead to a modification of the jcr:primaryType 
> of the root node in the JCR from {{rep:root}} to {{nt:unstructured}} and the 
> resourceType from {{sling:redirect}} to just being removed which breaks the 
> redirect handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6344) Support filter.xmls being generated by the content-package-maven-plugin

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814804#comment-15814804
 ] 

Robert Munteanu commented on SLING-6344:


[~kwin] - your changes seem to add an import to 

{noformat}+ org.eclipse.core.resources,
+ org.eclipse.jdt.annotation{noformat}

to the API project, and that's not good for our goal of keeping some parts IDE 
independent.

> Support filter.xmls being generated by the content-package-maven-plugin
> ---
>
> Key: SLING-6344
> URL: https://issues.apache.org/jira/browse/SLING-6344
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: SLING-6344-v01.patch, SLING-6344-v02.patch, 
> SLING-6344-v03.patch
>
>
> The content-package-maven plugin can not only consume a filter.xml from the 
> source directory, but also generate or merge filter.xmls. Therefore Sling IDE 
> should consider only the filter.xml in the generated artifacts (package). The 
> problem with that is, that content-package-maven-plugin does only generate 
> that filter.xml when it generates the real package.
> There is one other related issue: In case a filter file is not found, the 
> method {{ResourceChangeCommandFactory#getFilterResult}} returns {{ALLOW}} 
> while it should return {{DENY}} to not overwrite any nodes in case the filter 
> rules could not be determined.
> In my case those two problems lead to a modification of the jcr:primaryType 
> of the root node in the JCR from {{rep:root}} to {{nt:unstructured}} and the 
> resourceType from {{sling:redirect}} to just being removed which breaks the 
> redirect handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6344) Support filter.xmls being generated by the content-package-maven-plugin

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814800#comment-15814800
 ] 

Robert Munteanu commented on SLING-6344:


{quote}Can someone help me to clarify the licensing issue we might run into 
here?
AFAIK we are not allowed to include any non-open source code in any Apache 
artifacts.
What about reverse engineering functionality being provided by external closed 
source tools?
In this case the functionality which generates/merges filter.xmls?{quote}

Is probably best discussed on the dev mailing list, I don't think all the devs 
are following this issue. TBH my hope would be towards creating our own open 
source content-package plugin, see SLING-6195

> Support filter.xmls being generated by the content-package-maven-plugin
> ---
>
> Key: SLING-6344
> URL: https://issues.apache.org/jira/browse/SLING-6344
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: SLING-6344-v01.patch, SLING-6344-v02.patch, 
> SLING-6344-v03.patch
>
>
> The content-package-maven plugin can not only consume a filter.xml from the 
> source directory, but also generate or merge filter.xmls. Therefore Sling IDE 
> should consider only the filter.xml in the generated artifacts (package). The 
> problem with that is, that content-package-maven-plugin does only generate 
> that filter.xml when it generates the real package.
> There is one other related issue: In case a filter file is not found, the 
> method {{ResourceChangeCommandFactory#getFilterResult}} returns {{ALLOW}} 
> while it should return {{DENY}} to not overwrite any nodes in case the filter 
> rules could not be determined.
> In my case those two problems lead to a modification of the jcr:primaryType 
> of the root node in the JCR from {{rep:root}} to {{nt:unstructured}} and the 
> resourceType from {{sling:redirect}} to just being removed which breaks the 
> redirect handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Apache Sling JSP 2.2.4

[Justin Edelson]

+1

On Tue, Jan 10, 2017 at 7:34 PM Carsten Ziegeler 
wrote:

> +1
>
>
>
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

[Robert Munteanu]

On Mon, 2017-01-09 at 09:24 -0500, Konrad Windszus wrote:
> > On 9 Jan 2017, at 06:00, Robert Munteanu 
> > wrote:
> > 
> > Hi Konrad,
> > 
> > On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote:
> > > This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=4340
> > > 33.
> > > Any suggestions which annotation types to use in the Eclipse IDE
> > > for
> > > null checks?
> > > Or would it be fine to build the Sling IDE with target 1.8?
> > 
> > I am not opposed to building the IDE tooling with target 1.8 .
> > First
> > though, there is a workaround noted in the Eclipse bug:
> > 
> >  please make sure that an in projects below 1.8 you reference
> > version
> > [1.1.0,2.0.0) of the annotation bundle (exluding 2.0.0!)
> > 
> > Would that work for our scenario?
> 
> I have not tested that, but I just checked that indeed at least
> Eclipse Neon ships with two different versions of that bundle 1.1.100
> and 2.1.0 but I am not sure about older and newer versions of
> Eclipse. I would rather instead upgrade to Java 8, since with Neon
> Java 8 is anyhow required (see https://wiki.eclipse.org/Eclipse/Insta
> llation).
> WDYT?

I for one would switch to Java 8 only if really needed, as I think we
need to make it as easy as possible to run the IDE tools.

Are there any developers out there using the IDE Tooling on Java 7? No
idea. If there's a way to get null checking with Java 7, let's do that.
Otherwise, feel free to raise a new SLING issue about moving to Java 8
to track the reasons behind the move and change the requirement to Java
8.

Robert

> 
> > 
> > Robert
> > 
> > > Konrad
> > > 
> > > > On 29 Dec 2016, at 18:01, Apache Jenkins Server  > > > .apa
> > > > che.org> wrote:
> > > > 
> > > > See 
> > > > 
> > > > Changes:
> > > > 
> > > > [kwin] SLING-6344 disable syncing if no filter.xml can be found
> > > > 
> > > > simplify FilterLocator service
> > > > 
> > > > --
> > > > [...truncated 899 lines...]
> > > > [INFO] --- maven-remote-resources-plugin:1.5:process (default)
> > > > @
> > > > reactor ---
> > > > [INFO] 
> > > > [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-
> > > > descriptor) @ reactor ---
> > > > [INFO] 
> > > > [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files
> > > > (default) @ reactor ---
> > > > [INFO] 
> > > > [INFO] --- apache-rat-plugin:0.10:check (default) @ reactor ---
> > > > [INFO] 72 implicit excludes (use -debug for more details).
> > > > [INFO] Exclude: derby.log
> > > > [INFO] Exclude: .gitignore
> > > > [INFO] Exclude: README.md
> > > > [INFO] Exclude: *.launch
> > > > [INFO] Exclude: build.properties
> > > > [INFO] Exclude: .options
> > > > [INFO] Exclude: META-INF/MANIFEST.MF
> > > > [INFO] Exclude: **/*.binary
> > > > [INFO] Exclude: eclipse-test/**
> > > > [INFO] Exclude: source-bundle/target/**
> > > > [INFO] Exclude: .Xauthority-*
> > > > [INFO] 6 resources included (use -debug for more details)
> > > > Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser:
> > > > Property 'http://www.oracle.com/xml/jaxp/properties/entityExpan
> > > > sion
> > > > Limit' is not recognized.
> > > > Compiler warnings:
> > > >  WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property
> > > > 'http://
> > > > javax.xml.XMLConstants/property/accessExternalDTD' is not
> > > > recognized.'
> > > > Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://
> > > > java
> > > > x.xml.XMLConstants/feature/secure-processing' is not
> > > > recognized.
> > > > Warning:  org.apache.xerces.parsers.SAXParser: Property 'http:/
> > > > /jav
> > > > ax.xml.XMLConstants/property/accessExternalDTD' is not
> > > > recognized.
> > > > Warning:  org.apache.xerces.parsers.SAXParser: Property 'http:/
> > > > /www
> > > > .oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> > > > recognized.
> > > > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0
> > > > generated: 0 approved: 5 licence.
> > > > [JENKINS] Archiving disabled
> > > > [INFO] 
> > > > 
> > > > 
> > > > [INFO] 
> > > > 
> > > > 
> > > > [INFO] Building Sling IDE Tools: Target definition 1.1.1-
> > > > SNAPSHOT
> > > > [INFO] 
> > > > 
> > > > 
> > > > [INFO] 
> > > > [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @
> > > > org.apache.sling.ide.target-definition ---
> > > > [INFO] 
> > > > [INFO] --- maven-remote-resources-plugin:1.5:process (default)
> > > > @
> > > > org.apache.sling.ide.target-definition ---
> > > > [INFO] 
> > > > [INFO] --- tycho-packaging-plugin:0.22.0:package-target-
> > > > definition
> > > > (default-package-target-definition) @
> > > > org.apache.sling.ide.target-
> > > > definition ---
> > > > [INFO] 
> > > 

[jira] [Resolved] (SLING-6428) DateFormat is printed when date-value is empty

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-6428.
-
Resolution: Fixed

Applied [~vladb]'s patch in [r1778098|https://svn.apache.org/r1778098].

> DateFormat is printed when date-value is empty
> --
>
> Key: SLING-6428
> URL: https://issues.apache.org/jira/browse/SLING-6428
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.0.28, Scripting HTL Java Compiler 
> 1.0.6
>Reporter: Feike Visser
>Assignee: Radu Cotescu
> Fix For: Scripting HTL Engine 1.0.30, Scripting HTL Java Compiler 
> 1.0.8
>
>
> When the format-value emtpy, the date-format is printed.
> Example
> {code}
> 
> ${'-MM-dd' @ format=date1}
> 
> {code}
> In my view the date-format should not be printed, never.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-6428) DateFormat is printed when date-value is empty

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-6428:

Fix Version/s: Scripting HTL Java Compiler 1.0.8
   Scripting HTL Engine 1.0.30

> DateFormat is printed when date-value is empty
> --
>
> Key: SLING-6428
> URL: https://issues.apache.org/jira/browse/SLING-6428
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.0.28, Scripting HTL Java Compiler 
> 1.0.6
>Reporter: Feike Visser
>Assignee: Radu Cotescu
> Fix For: Scripting HTL Engine 1.0.30, Scripting HTL Java Compiler 
> 1.0.8
>
>
> When the format-value emtpy, the date-format is printed.
> Example
> {code}
> 
> ${'-MM-dd' @ format=date1}
> 
> {code}
> In my view the date-format should not be printed, never.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-6428) DateFormat is printed when date-value is empty

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-6428:

Affects Version/s: Scripting HTL Engine 1.0.28
   Scripting HTL Java Compiler 1.0.6

> DateFormat is printed when date-value is empty
> --
>
> Key: SLING-6428
> URL: https://issues.apache.org/jira/browse/SLING-6428
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.0.28, Scripting HTL Java Compiler 
> 1.0.6
>Reporter: Feike Visser
>Assignee: Radu Cotescu
> Fix For: Scripting HTL Engine 1.0.30, Scripting HTL Java Compiler 
> 1.0.8
>
>
> When the format-value emtpy, the date-format is printed.
> Example
> {code}
> 
> ${'-MM-dd' @ format=date1}
> 
> {code}
> In my view the date-format should not be printed, never.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (SLING-6428) DateFormat is printed when date-value is empty

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-6428:
---

Assignee: Radu Cotescu

> DateFormat is printed when date-value is empty
> --
>
> Key: SLING-6428
> URL: https://issues.apache.org/jira/browse/SLING-6428
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>Assignee: Radu Cotescu
>
> When the format-value emtpy, the date-format is printed.
> Example
> {code}
> 
> ${'-MM-dd' @ format=date1}
> 
> {code}
> In my view the date-format should not be printed, never.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Apache Sling JSP 2.2.4

[Carsten Ziegeler]

+1


 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Updated] (SLING-6393) Sling installer can duplicate factory configurations on opposite node if configuration is changed on local cluster node

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-6393:
---
Assignee: (was: Robert Munteanu)

> Sling installer can duplicate factory configurations on opposite node if 
> configuration is changed on local cluster node
> ---
>
> Key: SLING-6393
> URL: https://issues.apache.org/jira/browse/SLING-6393
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Elemer Kisch
>
> Sling installer can duplicate factory configurations on opposite node if 
> configuration is changed on local cluster node:
> Reproducible on RDMBK-DB2 cluster environment.
> {noformat}
> 06.12.2016 16:38:35.021 *INFO* [OsgiInstallerImpl] 
> org.apache.sling.audit.osgi.installer Installed configuration 
> org.apache.sling.commons.log.LogManager.factory.config.8af9a8a1-a3ad-4699-980d-6494aad6314e
>  from resource 
> TaskResource(url=jcrinstall:/apps/system/config/org.apache.sling.commons.log.LogManager.factory.config-audit.log.config,
>  
> entity=config:org.apache.sling.commons.log.LogManager.factory.config.audit.log,
>  state=INSTALL, 
> attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:28:84:, 
> service.factoryPid=org.apache.sling.commons.log.LogManager.factory.config, 
> service.pid=audit.log], digest=562d244ccd03c4e8b208ec6e8488a131)
> 06.12.2016 16:46:56.140 *INFO* [JcrInstaller.1] 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller Registering 
> resource with OSGi installer: [InstallableResource, priority=200, 
> id=/apps/system/config/org.apache.sling.commons.log.LogManager.factory.config-audit.log.config]
> 06.12.2016 16:46:56.176 *INFO* [OsgiInstallerImpl] 
> org.apache.sling.audit.osgi.installer Installed configuration 
> org.apache.sling.commons.log.LogManager.factory.config.8af9a8a1-a3ad-4699-980d-6494aad6314e
>  from resource 
> TaskResource(url=jcrinstall:/apps/system/config/org.apache.sling.commons.log.LogManager.factory.config-audit.log.config,
>  
> entity=config:org.apache.sling.commons.log.LogManager.factory.config.audit.log,
>  state=INSTALL, 
> attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:28:84:, 
> service.factoryPid=org.apache.sling.commons.log.LogManager.factory.config, 
> service.pid=audit.log], digest=24ee5abae6a89146693d896e8376f046)
> 06.12.2016 16:48:55.674 *INFO* [JcrInstaller.1] 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller Registering 
> resource with OSGi installer: [InstallableResource, priority=200, 
> id=/apps/system/config/org.apache.sling.commons.log.LogManager.config]
> 06.12.2016 16:48:55.715 *INFO* [OsgiInstallerImpl] 
> org.apache.sling.audit.osgi.installer Installed configuration 
> org.apache.sling.commons.log.LogManager from resource 
> TaskResource(url=jcrinstall:/apps/system/config/org.apache.sling.commons.log.LogManager.config,
>  entity=config:org.apache.sling.commons.log.LogManager, state=INSTALL, 
> attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:28:84:, 
> service.pid=org.apache.sling.commons.log.LogManager], 
> digest=ab4ea1c2827b4a27163236320694c81d)
> 06.12.2016 17:00:30.004 *INFO* [pool-11-thread-3] 
> com.adobe.granite.taskmanagement.impl.jcr.TaskArchiveService archiving tasks 
> at: 'Tue Dec 06 17:00:30 CET 2016'
> {noformat}
> {noformat}
> Suse-001:/data/software/wlp/usr/servers/server1 # cd -
> /data/software/wlp/usr/servers/server1/crx-quickstart/launchpad/config/org/apache/sling/commons/log/LogManager/factory/config
> Suse-001:/data/software/wlp/usr/servers/server1/crx-quickstart/launchpad/config/org/apache/sling/commons/log/LogManager/factory/config
>  # ls -lart
> total 28
> -rw-r--r-- 1 root root 377 Jun 11 2015 
> 8ab79cc1-780e-4f4d-b967-c95774fb2bcb.config
> -rw-r--r-- 1 root root 375 Jun 11 2015 
> 31887166-1934-4f82-9420-0146bcb8d20c.config
> -rw-r--r-- 1 root root 413 Jun 11 2015 
> 40697bf8-0ffc-47e9-b8f3-08a0d3b36511.config
> -rw-r--r-- 1 root root 505 Jun 11 2015 
> 3ffce209-310b-448b-9d0b-b5d0ea33f1f2.config
> drwxr-xr-x 4 root root 96 Jun 11 2015 ..
> -rw-r--r-- 1 root root 435 Jun 11 2015 
> 36b4a289-61ee-4fc2-a71d-fa5445cb9b5d.config
> -rw-r- 1 root root 653 Nov 11 15:32 factory.config
> -rw-r- 1 root root 352 Dec 6 16:46 
> 8af9a8a1-a3ad-4699-980d-6494aad6314e.config
> drwxr-xr-x 2 root root 464 Dec 6 16:46 .
> {noformat}
> Please have a look at the 16:46 occurrence. Just changing on the secondary 
> cluster via OSGi Console, e.g. the audit.log log level from INFO to ERROR, 
> you should get the same duplication.
> For an environment to reproduce, please contact me.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6393) Sling installer can duplicate factory configurations on opposite node if configuration is changed on local cluster node

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814610#comment-15814610
 ] 

Robert Munteanu commented on SLING-6393:


Unassigning myself since we will probably have a single fix with  SLING-6313 
once we pick up the new R7 config admin implementation.

> Sling installer can duplicate factory configurations on opposite node if 
> configuration is changed on local cluster node
> ---
>
> Key: SLING-6393
> URL: https://issues.apache.org/jira/browse/SLING-6393
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Elemer Kisch
>
> Sling installer can duplicate factory configurations on opposite node if 
> configuration is changed on local cluster node:
> Reproducible on RDMBK-DB2 cluster environment.
> {noformat}
> 06.12.2016 16:38:35.021 *INFO* [OsgiInstallerImpl] 
> org.apache.sling.audit.osgi.installer Installed configuration 
> org.apache.sling.commons.log.LogManager.factory.config.8af9a8a1-a3ad-4699-980d-6494aad6314e
>  from resource 
> TaskResource(url=jcrinstall:/apps/system/config/org.apache.sling.commons.log.LogManager.factory.config-audit.log.config,
>  
> entity=config:org.apache.sling.commons.log.LogManager.factory.config.audit.log,
>  state=INSTALL, 
> attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:28:84:, 
> service.factoryPid=org.apache.sling.commons.log.LogManager.factory.config, 
> service.pid=audit.log], digest=562d244ccd03c4e8b208ec6e8488a131)
> 06.12.2016 16:46:56.140 *INFO* [JcrInstaller.1] 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller Registering 
> resource with OSGi installer: [InstallableResource, priority=200, 
> id=/apps/system/config/org.apache.sling.commons.log.LogManager.factory.config-audit.log.config]
> 06.12.2016 16:46:56.176 *INFO* [OsgiInstallerImpl] 
> org.apache.sling.audit.osgi.installer Installed configuration 
> org.apache.sling.commons.log.LogManager.factory.config.8af9a8a1-a3ad-4699-980d-6494aad6314e
>  from resource 
> TaskResource(url=jcrinstall:/apps/system/config/org.apache.sling.commons.log.LogManager.factory.config-audit.log.config,
>  
> entity=config:org.apache.sling.commons.log.LogManager.factory.config.audit.log,
>  state=INSTALL, 
> attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:28:84:, 
> service.factoryPid=org.apache.sling.commons.log.LogManager.factory.config, 
> service.pid=audit.log], digest=24ee5abae6a89146693d896e8376f046)
> 06.12.2016 16:48:55.674 *INFO* [JcrInstaller.1] 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller Registering 
> resource with OSGi installer: [InstallableResource, priority=200, 
> id=/apps/system/config/org.apache.sling.commons.log.LogManager.config]
> 06.12.2016 16:48:55.715 *INFO* [OsgiInstallerImpl] 
> org.apache.sling.audit.osgi.installer Installed configuration 
> org.apache.sling.commons.log.LogManager from resource 
> TaskResource(url=jcrinstall:/apps/system/config/org.apache.sling.commons.log.LogManager.config,
>  entity=config:org.apache.sling.commons.log.LogManager, state=INSTALL, 
> attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:28:84:, 
> service.pid=org.apache.sling.commons.log.LogManager], 
> digest=ab4ea1c2827b4a27163236320694c81d)
> 06.12.2016 17:00:30.004 *INFO* [pool-11-thread-3] 
> com.adobe.granite.taskmanagement.impl.jcr.TaskArchiveService archiving tasks 
> at: 'Tue Dec 06 17:00:30 CET 2016'
> {noformat}
> {noformat}
> Suse-001:/data/software/wlp/usr/servers/server1 # cd -
> /data/software/wlp/usr/servers/server1/crx-quickstart/launchpad/config/org/apache/sling/commons/log/LogManager/factory/config
> Suse-001:/data/software/wlp/usr/servers/server1/crx-quickstart/launchpad/config/org/apache/sling/commons/log/LogManager/factory/config
>  # ls -lart
> total 28
> -rw-r--r-- 1 root root 377 Jun 11 2015 
> 8ab79cc1-780e-4f4d-b967-c95774fb2bcb.config
> -rw-r--r-- 1 root root 375 Jun 11 2015 
> 31887166-1934-4f82-9420-0146bcb8d20c.config
> -rw-r--r-- 1 root root 413 Jun 11 2015 
> 40697bf8-0ffc-47e9-b8f3-08a0d3b36511.config
> -rw-r--r-- 1 root root 505 Jun 11 2015 
> 3ffce209-310b-448b-9d0b-b5d0ea33f1f2.config
> drwxr-xr-x 4 root root 96 Jun 11 2015 ..
> -rw-r--r-- 1 root root 435 Jun 11 2015 
> 36b4a289-61ee-4fc2-a71d-fa5445cb9b5d.config
> -rw-r- 1 root root 653 Nov 11 15:32 factory.config
> -rw-r- 1 root root 352 Dec 6 16:46 
> 8af9a8a1-a3ad-4699-980d-6494aad6314e.config
> drwxr-xr-x 2 root root 464 Dec 6 16:46 .
> {noformat}
> Please have a look at the 16:46 occurrence. Just changing on the secondary 
> cluster via OSGi Console, e.g. the audit.log log level from INFO to ERROR, 
> you should get the same duplication.
> For an environment to reproduce, please contact me.



--
This message 

Re: [VOTE] Release Apache Sling JSP 2.2.4

[Robert Munteanu]

On Tue, 2017-01-10 at 10:59 +0100, Julian Sedding wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part

[jira] [Commented] (SLING-6428) DateFormat is printed when date-value is empty

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814540#comment-15814540
 ] 

ASF GitHub Bot commented on SLING-6428:
---

Github user vladbailescu closed the pull request at:

https://github.com/apache/sling/pull/197


> DateFormat is printed when date-value is empty
> --
>
> Key: SLING-6428
> URL: https://issues.apache.org/jira/browse/SLING-6428
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>
> When the format-value emtpy, the date-format is printed.
> Example
> {code}
> 
> ${'-MM-dd' @ format=date1}
> 
> {code}
> In my view the date-format should not be printed, never.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] sling pull request #197: SLING-6428 - DateFormat is printed when date-value ...

[vladbailescu]

Github user vladbailescu closed the pull request at:

https://github.com/apache/sling/pull/197


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[VOTE] Release Apache Sling JSP 2.2.4

[Julian Sedding]

Hi,

We solved 1 issues in the Apache Sling JSP 2.2.4 release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12338860

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1619/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1619 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Julian

[jira] [Commented] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814366#comment-15814366
 ] 

Robert Munteanu commented on SLING-6368:


{quote}I have not tested that extensively yet. But I had a closer look at 
DocViewNode and DocViewProperty and both seem rather lean to me, so I don't 
expect any major differences here to the previous version from a performance 
point of view.{quote}

That's good enough for me, thanks.

{quote}I stripped the version numbers from the filename just to make upgrades 
in the future easier to handle (i.e. in the best case with only a change of the 
version in the pom.xml). If you are not fine with stripping the version, I can 
again revert that change (that way it may be more obvious what the actual 
vlt-wrapper bundle contains).{quote}

I would prefer it that way for the exact reason you mentioned - we know the 
versions without the need to look into the pom file.

> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR 
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6368-testv02.patch, SLING-6368-v01.patch, 
> content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{title: Resolved 
> Segments,icon: 
> coral-Icon--targeted,storeMapping: 
> {s: segmentation
> },template: p 
> class=\\contexthub-module-line1\\>Resolved Segments/p>p 
> class=\\contexthub-module-line2\\>{{s.summary}}/p>,
> clickable: true,listReference: 
> /store/segmentation/segments,listType: 
> custom,listItemTemplate: 
> span>{{label}}/span>,
> itemOnClickNoop: true}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as 
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved 
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same 
> attribute is being stored in the JCR with value 
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Apache Sling Resource Resolver 1.5.10

[Robert Munteanu]

On Mon, 2017-01-09 at 16:36 +0100, Carsten Ziegeler wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part

Re: Tooling does not handle jcr:content isolated by filter's include

[Robert Munteanu]

Hi Andy,

On Mon, 2017-01-09 at 13:08 -0800, Andreas Schaefer Sr. wrote:
> Hi
> 
> While testing the IntelliJ plugin I discovered that a .content.xml
> file is ignored and its parent becomes an “nt:folder” if the
> jcr:content is isolated by a filter’s include.
> 
> This is what i have:
> 
> 1) Node /etc/designs/base of type cq:Page
> 2) jcr:content of type cq:PageCongent
> 3) filter.xml with that entry:
> 
> 
> 
> 
> 
> If I remove the include everything works fine. Build that CRX Package
> and install it will yield the correct result even with the include.
> 
> I confirmed the bug in Eclipse Neon.2 with AEM Tooling 1.1.0 but I
> think it is also present in 1.1.1.
> 
> I think the reason is that the VltFilter is receiving the node path
> (/etc/designs/base) instead of the jcr:content
> (/etc/designs/base/jcr:content)
> and that is refused by Jackrabbits’ DefaultWorkspaceFilter.
> 
> Let me know if I should create a ticket for it.

If this works with the package manager or vlt but not with the IDE
tooling it's a bug so please report it.

Thanks!

Robert

[jira] [Commented] (SLING-6448) Not able to upload file when sling running as war file using curl

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814341#comment-15814341
 ] 

Robert Munteanu commented on SLING-6448:


How do you start Sling using the jetty-maven-plugin? I have added the following 
change to the pom file:

{noformat}diff --git a/launchpad/builder/pom.xml b/launchpad/builder/pom.xml
index c79fa65de..479437852 100644
--- a/launchpad/builder/pom.xml
+++ b/launchpad/builder/pom.xml
@@ -71,6 +71,11 @@
 
 
 
+  org.eclipse.jetty
+  jetty-maven-plugin
+  9.4.0.v20161208
+
+
 org.apache.sling
 slingstart-maven-plugin
 1.7.0{noformat}

But I get an error when starting up sling with {{mvn clean package 
jetty:run-war}}

{noformat}[WARNING] sling: Failed to start Apache Sling in 
/home/robert/Documents/sources/apache/sling/launchpad/builder/sling/_
java.lang.ClassCircularityError: java/lang/ThreadDeath
at 
org.apache.felix.framework.URLHandlers.createURLStreamHandler(URLHandlers.java:490)
at java.net.URL.getURLStreamHandler(URL.java:1142)
at java.net.URL.(URL.java:599)
at java.net.URL.(URL.java:490)
at java.net.URL.(URL.java:439)
at 
org.eclipse.jetty.util.resource.Resource.newResource(Resource.java:166)
at 
org.eclipse.jetty.util.resource.Resource.newResource(Resource.java:149)
at org.eclipse.jetty.util.TypeUtil.getLoadedFrom(TypeUtil.java:726)
at 
org.eclipse.jetty.webapp.ClasspathPattern.match(ClasspathPattern.java:519)
at 
org.eclipse.jetty.webapp.WebAppContext.isServerClass(WebAppContext.java:811)
at 
org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:563)
at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
at 
org.apache.sling.launchpad.base.shared.LauncherClassLoader.loadClass(LauncherClassLoader.java:160)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at 
org.apache.felix.framework.URLHandlers.createURLStreamHandler(URLHandlers.java:490)
at java.net.URL.getURLStreamHandler(URL.java:1142)
at java.net.URL.(URL.java:599)
at java.net.URL.(URL.java:490)
at java.net.URL.(URL.java:439)
at 
org.eclipse.jetty.util.resource.Resource.newResource(Resource.java:166)
at 
org.eclipse.jetty.util.resource.Resource.newResource(Resource.java:149)
at org.eclipse.jetty.util.TypeUtil.getLoadedFrom(TypeUtil.java:726)
at 
org.eclipse.jetty.webapp.ClasspathPattern.match(ClasspathPattern.java:519)
at 
org.eclipse.jetty.webapp.WebAppContext.isServerClass(WebAppContext.java:811)
at 
org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:563)
at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
at 
org.apache.sling.launchpad.base.shared.LauncherClassLoader.loadClass(LauncherClassLoader.java:160)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at org.apache.sling.launchpad.base.impl.Sling.startup(Sling.java:309)
at org.apache.sling.launchpad.base.impl.Sling.init(Sling.java:350)
at org.apache.sling.launchpad.base.impl.Sling.(Sling.java:212)
at 
org.apache.sling.launchpad.base.webapp.SlingBridge$1.(SlingBridge.java:44)
at 
org.apache.sling.launchpad.base.webapp.SlingBridge.getSlingBridge(SlingBridge.java:44)
at 
org.apache.sling.launchpad.base.webapp.SlingServletDelegate.init(SlingServletDelegate.java:211)
at javax.servlet.GenericServlet.init(GenericServlet.java:244)
at 
org.apache.sling.launchpad.webapp.SlingServlet.startSling(SlingServlet.java:382)
at 
org.apache.sling.launchpad.webapp.SlingServlet.startSling(SlingServlet.java:325)
at 
org.apache.sling.launchpad.webapp.SlingServlet.init(SlingServlet.java:119)
at javax.servlet.GenericServlet.init(GenericServlet.java:244)
at 
org.eclipse.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:634)
at 
org.eclipse.jetty.servlet.ServletHolder.initialize(ServletHolder.java:418)
at 
org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:744)
at 
org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:348)
at 
org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1480)
at 
org.eclipse.jetty.maven.plugin.JettyWebAppContext.startWebapp(JettyWebAppContext.java:357)
at 
org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1442)
at 
org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:788)
at 
org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:261)
at