Re: [VOTE] Release Apache Resource Resolver 1.11.6

[Eric Norman]

Julian,

FWIW: disagreeing is not the same thing as "ignoring".


Well, you did more than just disagree.   There was no followup to any of
the 3 replies to explain your position.

I'm not a mind reader.

On Mon, Jan 22, 2024 at 1:15 AM Julian Reschke
 wrote:

> On 20.01.2024 02:09, Eric Norman wrote:
> > +0 for me.
> >
> > Though, I am still a little annoyed that you just ignored my review
> > comments from
> >
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#pullrequestreview-1791514750
>
> Eric,
>
> FWIW: disagreeing is not the same thing as "ignoring". This change was
> urgent because it addresses a customer-visible defect (aliases broken
> when more than >100K). What you raised is a stylistic issue which is not
> specific to this PR, so it really ought to be addressed/discussed as
> separate issue.
>
> Best regards, Julian
>

Re: [RESULT] [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 23.01.2024 13:05, Konrad Windszus wrote:

Done, please update the site accordingly.
Thanks,
Konrad


Thanks Konrad,

-> 

Best regards, Julian

Re: [RESULT] [VOTE] Release Apache Resource Resolver 1.11.6

[Konrad Windszus]

Done, please update the site accordingly.
Thanks,
Konrad

> On 23. Jan 2024, at 11:23, Julian Reschke  wrote:
> 
> On 22.01.2024 17:25, Julian Reschke wrote:
>> On 22.01.2024 10:20, Julian Reschke wrote:
>>> On 17.01.2024 07:51, Julian Reschke wrote:
 ...
>>> 
>>> Hi,
>>> 
>>> The vote has passed with the following result :
>>> 
>>> +1 (binding): Bertrand Delacretaz , Julian
>>> Reschke , Konrad Windszus ,
>>> Robert Munteanu 
>>> 
>>> I will copy this release to the Sling dist directory and
>>> promote the artifacts to the central Maven repository.
>>> 
>>> Best regards, Julian
>> 
>> OK, I will need help with promoting the release (I'm committer but not
>> PMC member, thus have no write access to the SVN repo).
>> 
>> Best regards, Julian
> 
> Hi,
> 
> FYI: Konrad has volunteered to do the release promotion; thanks for that.
> 
> Best regards, Julian

Re: [RESULT] [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 22.01.2024 17:25, Julian Reschke wrote:

On 22.01.2024 10:20, Julian Reschke wrote:

On 17.01.2024 07:51, Julian Reschke wrote:

...


Hi,

The vote has passed with the following result :

+1 (binding): Bertrand Delacretaz , Julian
Reschke , Konrad Windszus ,
Robert Munteanu 

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Best regards, Julian


OK, I will need help with promoting the release (I'm committer but not
PMC member, thus have no write access to the SVN repo).

Best regards, Julian


Hi,

FYI: Konrad has volunteered to do the release promotion; thanks for that.

Best regards, Julian

Re: [RESULT] [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 22.01.2024 10:20, Julian Reschke wrote:

On 17.01.2024 07:51, Julian Reschke wrote:

...


Hi,

The vote has passed with the following result :

+1 (binding): Bertrand Delacretaz , Julian
Reschke , Konrad Windszus ,
Robert Munteanu 

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Best regards, Julian


OK, I will need help with promoting the release (I'm committer but not
PMC member, thus have no write access to the SVN repo).

Best regards, Julian

[RESULT] [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 17.01.2024 07:51, Julian Reschke wrote:

...


Hi,

The vote has passed with the following result :

+1 (binding): Bertrand Delacretaz , Julian 
Reschke , Konrad Windszus , 
Robert Munteanu 


I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Best regards, Julian

Re: [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 20.01.2024 02:09, Eric Norman wrote:

+0 for me.

Though, I am still a little annoyed that you just ignored my review
comments from
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#pullrequestreview-1791514750


Eric,

FWIW: disagreeing is not the same thing as "ignoring". This change was
urgent because it addresses a customer-visible defect (aliases broken
when more than >100K). What you raised is a stylistic issue which is not
specific to this PR, so it really ought to be addressed/discussed as
separate issue.

Best regards, Julian

Re: [VOTE] Release Apache Resource Resolver 1.11.6

[Eric Norman]

+0 for me.

Though, I am still a little annoyed that you just ignored my review
comments from
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#pullrequestreview-1791514750

On Tue, Jan 16, 2024 at 10:52 PM Julian Reschke
 wrote:

> Hi,
>
> We solved 6 issues in this release:
>
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353856=Text
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2830
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 2830 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ]  0 Don't care
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best regards, Julian
>

Re: [VOTE] Release Apache Resource Resolver 1.11.6

[Konrad Windszus]

+1

Konrad

> On 17. Jan 2024, at 07:51, Julian Reschke  
> wrote:
> 
> Hi,
> 
> We solved 6 issues in this release:
> 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353856=Text
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2830
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 2830 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Best regards, Julian

Re: [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 17.01.2024 13:44, Bertrand Delacretaz wrote:

[X ] +1 Approve the release

Julian's signature 44F4797A52C336FA666CD9271DE461528F1F1B2A was
missing from https://downloads.apache.org/sling/KEYS , I have added it
[1] from [0], it should appear in a few minutes.
:::


Ups. Thanks.

Best regards, Julian

Re: [VOTE] Release Apache Resource Resolver 1.11.6

[Robert Munteanu]

On Wed, 2024-01-17 at 07:51 +0100, Julian Reschke wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

Re: [VOTE] Release Apache Resource Resolver 1.11.6

[Bertrand Delacretaz]

   [X ] +1 Approve the release

Julian's signature 44F4797A52C336FA666CD9271DE461528F1F1B2A was
missing from https://downloads.apache.org/sling/KEYS , I have added it
[1] from [0], it should appear in a few minutes.

-Bertrand

[0] https://downloads.apache.org/jackrabbit/KEYS

[1] FWIW, here's how to add a key
svn co https://dist.apache.org/repos/dist/release/sling --depth empty
cd sling
svn up KEYS
# edit KEYS as needed
svn diff
svn commit -m ...

Re: [VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

On 17.01.2024 07:51, Julian Reschke wrote:

...


[X] +1 Approve the release


Best regards, Julian

[VOTE] Release Apache Resource Resolver 1.11.6

[Julian Reschke]

Hi,

We solved 6 issues in this release:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353856=Text

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2830

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2830 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Best regards, Julian