[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98003481 --- Diff: lib/c_glib/src/thrift/c_glib/transport/thrift_platform_socket.h --- @@ -0,0 +1,120 @@ +/* --- End diff -- This looks a lot like the platform socket code that already exists in the C++ library. Given their similarity should they be combined and moved into a common location? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98003205 --- Diff: lib/c_glib/Makefile.am --- @@ -45,6 +45,7 @@ libthrift_c_glib_la_SOURCES = src/thrift/c_glib/thrift.c \ src/thrift/c_glib/transport/thrift_buffered_transport_factory.c \ src/thrift/c_glib/transport/thrift_framed_transport_factory.c \ src/thrift/c_glib/transport/thrift_socket.c \ + src/thrift/c_glib/transport/thrift_ssl_socket.c \ --- End diff -- Does this need to be conditional on openssl being found? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98003634 --- Diff: lib/c_glib/test/CMakeLists.txt --- @@ -108,13 +108,6 @@ add_test(NAME testoptionalrequired COMMAND testoptionalrequired) include_directories("${PROJECT_SOURCE_DIR}/test/c_glib/src" "${CMAKE_CURRENT_BINARY_DIR}/gen-c_glib") -add_executable(testthrifttest testthrifttest.c --- End diff -- Why was the testthrifttest executable removed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98003689 --- Diff: lib/c_glib/test/Makefile.am --- @@ -37,16 +37,17 @@ BUILT_SOURCES = \ gen-c_glib/t_test_thrift_test_types.h AM_CPPFLAGS = -I../src -I./gen-c_glib -AM_CFLAGS = -g -Wall -Wextra -pedantic $(GLIB_CFLAGS) $(GOBJECT_CFLAGS) \ +AM_CFLAGS = -g -Wall -Wextra -pedantic $(GLIB_CFLAGS) $(GOBJECT_CFLAGS) $(OPENSSL_INCLUDES) \ @GCOV_CFLAGS@ AM_CXXFLAGS = $(AM_CFLAGS) -AM_LDFLAGS = $(GLIB_LIBS) $(GOBJECT_LIBS) @GCOV_LDFLAGS@ +AM_LDFLAGS = $(GLIB_LIBS) $(GOBJECT_LIBS) $(OPENSSL_LIBS) @GCOV_LDFLAGS@ check_PROGRAMS = \ testserialization \ testapplicationexception \ testcontainertest \ testtransportsocket \ + testtransportsslsocket \ --- End diff -- Does this need to be conditional on openssl being found? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98003039 --- Diff: configure.ac --- @@ -199,6 +196,12 @@ if test "$with_c_glib" = "yes"; then fi AM_CONDITIONAL(WITH_C_GLIB, [test "$have_glib2" = "yes" -a "$have_gobject2" = "yes"]) +echo "OpenSSL check" --- End diff -- There may be other libraries with native builds that need OpenSSL. Why are we making it conditional on cpp and c_glib library support? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98002795 --- Diff: lib/c_glib/test/owncloud.level2crm.pem --- @@ -0,0 +1,59 @@ +-BEGIN CERTIFICATE- +MIIFLDCCBBSgAwIBAgIBAzANBgkqhkiG9w0BAQsFADCBrTELMAkGA1UEBhMCRVMx +DzANBgNVBAgTBk1hZHJpZDEVMBMGA1UEBxMMVG9ycmVsb2RvbmVzMSswKQYDVQQK +EyJMZXZlbDIgU29sdWNpb25lcyBNYXJrZXRpbmcgMzYwIFNMMREwDwYDVQQLEwhT +aXN0ZW1hczEPMA0GA1UEAxMGTGV2ZWwyMSUwIwYJKoZIhvcNAQkBFhZnYWd1aWxh +ckBsZXZlbDJjcm0uY29tMB4XDTE1MDIxMzEyNDY0OVoXDTE3MDIwMjEyNDY0OVow +gaYxCzAJBgNVBAYTAkVTMQ8wDQYDVQQIEwZNYWRyaWQxKzApBgNVBAoTIkxldmVs +MiBTb2x1Y2lvbmVzIE1hcmtldGluZyAzNjAgU0wxETAPBgNVBAsTCFNpc3RlbWFz +MR8wHQYDVQQDExZvd25jbG91ZC5sZXZlbDJjcm0uY29tMSUwIwYJKoZIhvcNAQkB +FhZnYWd1aWxhckBsZXZlbDJjcm0uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8A +MIIBCgKCAQEA9BH6ZPghzZQaWKG5Y3o/V41UDzJfkghfxhOzqZehn3dtpylMcA7i +qUi1N3Gf5S53GCl3JOm0sfdMhJr8UYBL1PwRnAo8ZOU678fofU7/2GgqAN+dtOO8 +X8JTar9zbANnJIR89fSXp4wQUbTKt7xbBezv8c/Cel6dlTSC8Dvc50ptksh5yue2 +SEuglFDtf7ru8EidROMgvUw4VAjusZXVirPKjv2rqWamgRsWizq9nkqJ71HjFweo +FYQRIuZ6qSDl3x7ZDV22kZth2LxFHRnv1E/SHbsvs0iEoKr9hF6xkdxyfHmlyd02 +oJOdlxEfHSREtuFDbDP/CcQy5oVbdM2EfQIDAQABo4IBWjCCAVYwCQYDVR0TBAIw +ADARBglghkgBhvhCAQEEBAMCBPAwCwYDVR0PBAQDAgXgMCUGCWCGSAGG+EIBDQQY +FhZMZXZlbDIgQ1JNIENlcnRpZmljYXRlMB0GA1UdDgQWBBTa17QOLz4WqHv0J6LP +KVVPsX721TCB4gYDVR0jBIHaMIHXgBTRF2IG48O6cMjz44Pwk5GbhUWX3aGBs6SB +sDCBrTELMAkGA1UEBhMCRVMxDzANBgNVBAgTBk1hZHJpZDEVMBMGA1UEBxMMVG9y +cmVsb2RvbmVzMSswKQYDVQQKEyJMZXZlbDIgU29sdWNpb25lcyBNYXJrZXRpbmcg +MzYwIFNMMREwDwYDVQQLEwhTaXN0ZW1hczEPMA0GA1UEAxMGTGV2ZWwyMSUwIwYJ +KoZIhvcNAQkBFhZnYWd1aWxhckBsZXZlbDJjcm0uY29tggkAqMKCeCp/2+wwDQYJ +KoZIhvcNAQELBQADggEBACy1UZR674b3yxEYnFPorhbD4CS65AfgLEObpvwbGvF8 +gLxJkxGhcsKEoxiBynnazdPzub8I9e0ZHsPjAyPupLrBeuUIBthmzdW3gUN9zZp1 +mRIurbiT3wlYCxl/cOa7MV7bCZSSqsC0WF9CLicRPFgyc6MDdRjsMufx+JkIdJZa +31jBweG/JzYm9pxdJFfnFcBEM+Kv3BcozoAAHcLHvv4cI4j5SpdzdCEgpgd6/LtI +i/grRayPlbQnqUrEOHLAuhAH+RflRTIFBGRRukLa7yqdY9J+qHDPLkxnLEmtyu4u +6GoZTYFtKnVZfubr+gku9Z8r2gF375InjOAifZH3ITE= +-END CERTIFICATE- +-BEGIN CERTIFICATE- +MIIFBDCCA+ygAwIBAgIJAKjCgngqf9vsMA0GCSqGSIb3DQEBCwUAMIGtMQswCQYD +VQQGEwJFUzEPMA0GA1UECBMGTWFkcmlkMRUwEwYDVQQHEwxUb3JyZWxvZG9uZXMx +KzApBgNVBAoTIkxldmVsMiBTb2x1Y2lvbmVzIE1hcmtldGluZyAzNjAgU0wxETAP +BgNVBAsTCFNpc3RlbWFzMQ8wDQYDVQQDEwZMZXZlbDIxJTAjBgkqhkiG9w0BCQEW +FmdhZ3VpbGFyQGxldmVsMmNybS5jb20wHhcNMTUwMTAxMTQyMDQ1WhcNMjQxMjI5 +MTQyMDQ1WjCBrTELMAkGA1UEBhMCRVMxDzANBgNVBAgTBk1hZHJpZDEVMBMGA1UE +BxMMVG9ycmVsb2RvbmVzMSswKQYDVQQKEyJMZXZlbDIgU29sdWNpb25lcyBNYXJr +ZXRpbmcgMzYwIFNMMREwDwYDVQQLEwhTaXN0ZW1hczEPMA0GA1UEAxMGTGV2ZWwy +MSUwIwYJKoZIhvcNAQkBFhZnYWd1aWxhckBsZXZlbDJjcm0uY29tMIIBIjANBgkq +hkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA2RJKzAzO8P0GT3FcnFMK3X9t4JE+mHMP +aPX5miBLaKH6rXclrfjYfzK3OESY5DhgZJ+Qzx5GyNl+hsSXpiIlNbWAEeJCIELG +OEz51zR0M2rQTC06UrWTtn2COQo2m91lv+Mwum+LSgqUPJ18dyKsmOFSVCsLOK+s +xZY7F5AF2+99kr1EFv0dcxS1BTRKOAQiMkuZEnFU95zXmm+U+vzenwX2V8XtTLip +e6+MezZTehvSZhbafKwFnw+vc36VGwrfhc+lH/1pc5etp4qcD9L0WvOhTmBUwWl/ +2hOU0XF5UYOkfsS1saot/WIsH6731Q/slYFCLXSrl+8R4+RxR9fozwIDAQABo4IB +IzCCAR8wHQYDVR0OBBYEFNEXYgbjw7pwyPPjg/CTkZuFRZfdMIHiBgNVHSMEgdow +gdeAFNEXYgbjw7pwyPPjg/CTkZuFRZfdoYGzpIGwMIGtMQswCQYDVQQGEwJFUzEP +MA0GA1UECBMGTWFkcmlkMRUwEwYDVQQHEwxUb3JyZWxvZG9uZXMxKzApBgNVBAoT +IkxldmVsMiBTb2x1Y2lvbmVzIE1hcmtldGluZyAzNjAgU0wxETAPBgNVBAsTCFNp +c3RlbWFzMQ8wDQYDVQQDEwZMZXZlbDIxJTAjBgkqhkiG9w0BCQEWFmdhZ3VpbGFy +QGxldmVsMmNybS5jb22CCQCowoJ4Kn/b7DAMBgNVHRMEBTADAQH/MAsGA1UdDwQE +AwIBBjANBgkqhkiG9w0BAQsFAAOCAQEAh2kPzv8jFNQbCrAD770m8T4W/KMhxMOv +Uhm/wSv7/g3Ir1pZ9LgXAWJx1qLQdCcOikBparkUpHIrqDU+wBL6o+CFNWp7WR6g +bft627bL9R3z3fTQHIchjPHQ7S4ID/STWfTqWDJQESBnTp1KTuJ8sMlvACMWZSUc +jZOAQIodNiUUNPkfreurPb9KH/nArwV/yTDoZMhiqoqNwOIY/0sxUJaNUAX3pgDd +FsGMBn4MiyGAw4XaK9LJBh+6DLH5D2Y7h0hXv+AUP3SSC+w5XA/D+SHcAbjtPzMW +cdq9jr1Gu0KO3PSGIAUpI1o+XQeLqgyieFcVF/FlD31MDC152DifNA== +-END CERTIFICATE- --- End diff -- This needs to be removed in favor of existing test keys. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...
Github user gadLinux commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98027454 --- Diff: configure.ac --- @@ -199,6 +196,12 @@ if test "$with_c_glib" = "yes"; then fi AM_CONDITIONAL(WITH_C_GLIB, [test "$have_glib2" = "yes" -a "$have_gobject2" = "yes"]) +echo "OpenSSL check" --- End diff -- But this is the latest I fixed... Maybe I lost the changes when doing the rebase. OpenSSL was not used everyplace when I did the patch. In fact it was not even included for c_glib. C++ had this optionally included. I followed the C++ directions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...
Github user gadLinux commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98027723 --- Diff: lib/c_glib/src/thrift/c_glib/transport/thrift_platform_socket.h --- @@ -0,0 +1,120 @@ +/* --- End diff -- I tottally agree. It's a reimplementation of the library for c_glib to not mix things. But this can be seen as an upgrade. And start making room for an common library after merge. Don't you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...
Github user gadLinux commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98027875 --- Diff: lib/c_glib/test/CMakeLists.txt --- @@ -108,13 +108,6 @@ add_test(NAME testoptionalrequired COMMAND testoptionalrequired) include_directories("${PROJECT_SOURCE_DIR}/test/c_glib/src" "${CMAKE_CURRENT_BINARY_DIR}/gen-c_glib") -add_executable(testthrifttest testthrifttest.c --- End diff -- Thrift test should be there. Iif I removed it it was because error. I will readd it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...
Github user gadLinux commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98028242 --- Diff: lib/c_glib/test/Makefile.am --- @@ -37,16 +37,17 @@ BUILT_SOURCES = \ gen-c_glib/t_test_thrift_test_types.h AM_CPPFLAGS = -I../src -I./gen-c_glib -AM_CFLAGS = -g -Wall -Wextra -pedantic $(GLIB_CFLAGS) $(GOBJECT_CFLAGS) \ +AM_CFLAGS = -g -Wall -Wextra -pedantic $(GLIB_CFLAGS) $(GOBJECT_CFLAGS) $(OPENSSL_INCLUDES) \ @GCOV_CFLAGS@ AM_CXXFLAGS = $(AM_CFLAGS) -AM_LDFLAGS = $(GLIB_LIBS) $(GOBJECT_LIBS) @GCOV_LDFLAGS@ +AM_LDFLAGS = $(GLIB_LIBS) $(GOBJECT_LIBS) $(OPENSSL_LIBS) @GCOV_LDFLAGS@ check_PROGRAMS = \ testserialization \ testapplicationexception \ testcontainertest \ testtransportsocket \ + testtransportsslsocket \ --- End diff -- I think so. But since I don't have yet detection code for ssl there's no opt-out code. I think it will not work without the openssl library. So we have to choices. Require OpenSSL as you recommended above. Or make the code conditional, something is not ready yet. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...
Github user gadLinux closed the pull request at: https://github.com/apache/thrift/pull/930 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---