[GitHub] tinkerpop pull request #346: ResultSet.hasNext should be idempotent
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/346 ResultSet.hasNext should be idempotent Sorry I didn't create a ticket; JIRA is having problems. Calling hasNext() multiple times would dequeue items. You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #346 commit 0d5d81b4e8eff3211e5ef5e278e07233e0ead64a Author: Robert Dale <robert.d...@sensus.com> Date: 2016-06-24T20:13:33Z ResultSet.hasNext should be idempotent --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #365: Tp31: Minor word and link cleanup
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/365 Tp31: Minor word and link cleanup Related to #362 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop tp31-docs-edits Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/365.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #365 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #368: TINKERPOP-1394: fixed dev list and jira links
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/368 TINKERPOP-1394: fixed dev list and jira links You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1394 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/368.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #368 commit 8e716238a91aa424b0c04c081fc94cd37f3ea33b Author: Robert Dale <robd...@gmail.com> Date: 2016-08-03T04:15:03Z fixed dev list and jira links --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #362: Minor word and link cleanup
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/362 Minor word and link cleanup Fixed spelling and links. You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop docs-edits Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #362 commit deb99f6e5bb49d234f2d1c1a95ea1272e0ca6fbc Author: Robert Dale <robd...@gmail.com> Date: 2016-07-16T23:41:52Z minor word and link cleanup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #361: TINKERPOP-1360: compare vertex property ids as Long
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/361 Java is brain damaged when comparing numbers. Don't blame JSON. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/346 Yes, I ran 'mvn clean install -DskipIntegrationTests=false -DincludeNeo4j' and it passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #356: TINKERPOP-1338 Bumped groovy to 2.4.7
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/356 Fixed my Spark issue. Wanted to rebuild since giraph, hadoop, and spark have some dependency on groovy. Builds cleanly with mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/351
So I've caught up on the discussion and I'll offer some more food for
thought since I haven't seen any other ideas. Embedding metadata is neither
easy nor fun (not for me anyway). For any serious integration type work it's
always best to have a well-defined schema up-front.
On types:
> @spmallette
> In fact we don't always know the types ahead of time (like Titan's
GeoPoint), so using the java class name is pretty convenient
Convenience is not the same as using Java types. By "not using java types",
we mean:
- not using java package names
- not using types specific to Java
- using primitives and other common types that are concise and portable
- should include domain-specific types. e.g. Vertex, Edge, etc.
- may include other standards. e.g. GeoJSON
Defining primitives, common types:
- http://swagger.io/specification/#dataTypeFormat
- http://bsonspec.org/spec.html
- http://geojson.org/geojson-spec.html
- http://ubjson.org/type-reference/
So if your Java implementation conveniently shares the same name as the
type, then that's wonderful. But if you are to be truly language-agnostic, then
at some point the types must be known ahead of time in order to be consumed.
For instance, how can my X parser know how to handle a Titan GeoPoint if it's
all dynamic? It can't. It must be able to handle this type ahead of time. And
I can't imagine someone would want to manually read a graphson file to discover
all the types that must be handled. Maybe I'm getting out of scope as this goes
beyond language and steps into being database agnostic. @newkek, please correct
me if I'm wrong, but it doesn't look like the code does any dynamic
serializing. It looks like all types are registered anyway. So I'll argue again
if you know your types ahead of time, then you may as well have a schema.
But let's continue with embedded metadata...
In JSON, the only unambiguous types are
- array (unless you want to disambiguate from list which may be very valid)
- string
- boolean (true, false)
- null
To avoid confusion on all other types, including numbers, they should be
typed. Thus they are objects (and not lists of things). The metadata can be at
the same level as the object and alleviates these concerns: @newkek " a List in
which the first element is a Map in which the first entry's key" and
@PommeVerte "can be a pain in systems that do not necessarily order lists".
Metadata can be differentiated from member fields by a prefix (e.g. '@').
Primitive types (or objects) having only a single value would have a "value"
key which maps to the actual value.
```json
[
{
"@type":"Vertex",
"id":{
"@type":"int64",
"value":12345
},
"label":"person",
"properties":{
"@type":"VertexProperty",
"skill":{
"id":{ "@type":"int64",
"value":8723
},
"@type":"int32",
"value":5
},
"secrets":[
{ "id":{
"@type":"int64",
"value":8723
},
"@type":"uuid",
"value":"1de7bedf-f9ba-4e94-bde9-f1be28bef239"
},
{ "id":{
"@type":"int64",
"value":8724
},
"@type":"uuid",
"value":"34523adf-f9ba-4e94-bde9-f2345bcd3f45"
}
]
},
"inE":[
{ "@type":"Edge",
"label":"knows",
"id":{
"@type":"int64",
"value":987234
},
"properties":{ },
"outV":[ { } ]
}
]
}
]
```
I wouldn't concern myself with the additional payload size for metadata. I
wouldn't sacrifice conciseness for size. One could always compress the file if
size is a concern. Also, the reader/writer could be easily enhanced to support
zip. I would take the pragmatic approach and address it when it's no longer
working for people.
Anyway, maybe this is all GraphSON 3.0 stuffs. HTH.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #356: TINKERPOP-1338 Bumped groovy to 2.4.7
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/356 I rebased to include @okram 's fix in the jira ticket. 4.5 hours later, "docker/build.sh -t -i -n" passed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #356: TINKERPOP-1338 Bumped groovy to 2.4.7
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/356 This PR does include #353 but not #354 . In the meantime, I'm setting up docker. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #356: TINKERPOP-1338 Bumped groovy to 2.4.7
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/356 TINKERPOP-1338 Bumped groovy to 2.4.7 No new dependencies introduced. No other dependency versions changed. Successful build and verify with: mvn clean install -pl gremlin-shaded,gremlin-core,gremlin-test,gremlin-groovy,gremlin-groovy-test,tinkergraph-gremlin,neo4j-gremlin,gremlin-driver,gremlin-console,gremlin-server,gremlin-archetype && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j (excludes giraph-gremlin, hadoop-gremlin,spark-gremlin because I have separate issues building them) You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1338 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/356.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #356 commit fe37df2937a89c9f9d73bfbfc49f63c43a07986c Author: Robert Dale <robert.d...@sensus.com> Date: 2016-07-05T16:03:38Z Bumped groovy to 2.4.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/346 Normally that's what I would do but tried doing it the 'github way' - https://help.github.com/articles/syncing-a-fork/ So let me know what you want me to do now. I can start over, creating the JIRA ticket, branch, etc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/346 I merged your master into my fork. Commit 0787e46097cc09bb278ac1c787c4a50ece81cdb0 I didn't realize it would affect the pull request. Next time I'll create a branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/352 Using (have to ignore hadoop/spark) mvn clean install -pl gremlin-shaded,gremlin-core,gremlin-test,gremlin-groovy,gremlin-groovy-test,tinkergraph-gremlin,neo4j-gremlin,gremlin-driver,gremlin-console,gremlin-server,gremlin-archetype && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j GremlinServerSessionIntegrateTest.shouldEnsureSessionBindingsAreThreadSafe consistently fails for me. The tp31 tip does not fail. No such property: a for class: Script2 I added a get() where the vars are set to ensure it happens before the rest of the threads. Does not appear to be a race condition. [console.txt](https://github.com/apache/tinkerpop/files/341746/console.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #354: TINKERPOP-1354 Added more invalid binding keys to Grem...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/354 BUILD SUCCESS --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/352 Can you provide the stacktrace (from the surefire report)? What OS, java versions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/351 @newkek @spmallette Sorry, my context was only this thread. I agree with you on all accounts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #537: TINKERPOP-1605 gremlin-console 3.2.3 -e can no longer ...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/537 Isn't there a distribution verification that does tests? I know it's post-build, but that's better than nothing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #536: TINKERPOP-1602 Support SSL client certificate a...
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/536#discussion_r97582757
--- Diff:
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java
---
@@ -105,7 +106,13 @@
*/
public class GremlinServerIntegrateTest extends
AbstractGremlinServerIntegrationTest {
-private Log4jRecordingAppender recordingAppender = null;
+ private static final String SERVER_KEY =
"src/test/resources/server.key.pk8";
--- End diff --
I think I'm using tabs instead of spaces. I can reformat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #536: TINKERPOP-1602 Support SSL client certificate authenti...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/536 Tests added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #541: TINKERPOP-1560 Used ManagedConcurrentValueMap in Greml...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/541 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #534: TINKERPOP-1566 Kerberos authentication for grem...
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/534#discussion_r102062737
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpBasicAuthenticationHandler.java
---
@@ -92,6 +102,13 @@ public void channelRead(final ChannelHandlerContext
ctx, final Object msg) {
try {
authenticator.authenticate(credentials);
ctx.fireChannelRead(request);
+
+// User name logged with the remote socket address and
authenticator classname for audit logging
+if (authenticationSettings.enableAuditLog) {
+String[] authClassParts =
authenticator.getClass().toString().split("[.]");
+auditLogger.info("User {} with address {}
authenticated by {}", credentials.get(PROPERTY_USERNAME),
+
ctx.channel().remoteAddress().toString().substring(1),
authClassParts[authClassParts.length - 1]);
--- End diff --
substring(1) assumes that the remoteAddress always has an unresolved
(reverse lookup) hostname. I don't know if this is always the case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #534: TINKERPOP-1566 Kerberos authentication for grem...
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/534#discussion_r102062848
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/SaslAuthenticationHandler.java
---
@@ -94,13 +99,17 @@ public void channelRead(final ChannelHandlerContext
ctx, final Object msg) throw
ctx.writeAndFlush(error);
return;
}
-
+
try {
final byte[] saslMessage =
negotiator.get().evaluateResponse(saslResponse);
if (negotiator.get().isComplete()) {
-// todo: do something with this user
final AuthenticatedUser user =
negotiator.get().getAuthenticatedUser();
-
+// User name logged with the remote socket
address and authenticator classname for audit logging
+if (authenticationSettings.enableAuditLog) {
+String[] authClassParts =
authenticator.getClass().toString().split("[.]");
+auditLogger.info("User {} with address {}
authenticated by {}", user.getName(),
+
ctx.channel().remoteAddress().toString().substring(1),
authClassParts[authClassParts.length - 1]);
--- End diff --
substring(1) again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #534: TINKERPOP-1566 Kerberos authentication for grem...
Github user robertdale commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/534#discussion_r102058441 --- Diff: docs/src/reference/gremlin-applications.asciidoc --- @@ -1035,6 +1035,7 @@ The following table describes the various YAML configuration options that Gremli |= |Key |Description |Default |authentication.className |The fully qualified classname of an `Authenticator` implementation to use. If this setting is not present, then authentication is effectively disabled. |`AllowAllAuthenticator` +|authentication.enableAuditLog |The available authenticators can issue audit logging messages, binding the authenticated user to his remote socket address and binding requests with a gremlin query to the remote socket address. For privacy reasons, the default value of this setting is false. The audit logging messages are logged at the INFO level via the `audit.org.apache.tinkerpop.gremlin.server` logger, which can be configured using the log4j.properties file. |false --- End diff -- Should this be in alphabetical order? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #534: TINKERPOP-1566 Kerberos authentication for grem...
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/534#discussion_r102104360
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpBasicAuthenticationHandler.java
---
@@ -92,6 +102,13 @@ public void channelRead(final ChannelHandlerContext
ctx, final Object msg) {
try {
authenticator.authenticate(credentials);
ctx.fireChannelRead(request);
+
+// User name logged with the remote socket address and
authenticator classname for audit logging
+if (authenticationSettings.enableAuditLog) {
+String[] authClassParts =
authenticator.getClass().toString().split("[.]");
+auditLogger.info("User {} with address {}
authenticated by {}", credentials.get(PROPERTY_USERNAME),
+
ctx.channel().remoteAddress().toString().substring(1),
authClassParts[authClassParts.length - 1]);
--- End diff --
Let me elaborate. substring(1) assumes the toString() always starts with
'/'. However, if the hostname were resolved, then it would be in the format of
"hostname/IP address:port". substring(1) would result in "ostname/IP
address:port". It might not ever happen, but wanted to point it out for
awareness.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #534: TINKERPOP-1566 Kerberos authentication for grem...
Github user robertdale commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/534#discussion_r102104550 --- Diff: docs/src/reference/gremlin-applications.asciidoc --- @@ -1035,6 +1035,7 @@ The following table describes the various YAML configuration options that Gremli |= |Key |Description |Default |authentication.className |The fully qualified classname of an `Authenticator` implementation to use. If this setting is not present, then authentication is effectively disabled. |`AllowAllAuthenticator` +|authentication.enableAuditLog |The available authenticators can issue audit logging messages, binding the authenticated user to his remote socket address and binding requests with a gremlin query to the remote socket address. For privacy reasons, the default value of this setting is false. The audit logging messages are logged at the INFO level via the `audit.org.apache.tinkerpop.gremlin.server` logger, which can be configured using the log4j.properties file. |false --- End diff -- What I meant is that this one was not in alphabetical order and perhaps it should be. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #557: TINKERPOP-1633 use official jbcrypt 0.4 in maven centr...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/557 transferring my vote from #556 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #556: TINKERPOP-1633 use official jbcrypt 0.4 in maven centr...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/556 Verified that this matches the original code. Compared source files and decompiled class files. VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #536: Support SSL client certificate authentication
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/536 @spmallette before you say it, I know I have to update changelog and update docs. :boom: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #536: TINKERPOP-1602 Support SSL client certificate authenti...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/536 And it does. Yay. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #536: TINKERPOP-1602 Support SSL client certificate authenti...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/536 Just wondering if posting a comment after updating the title will trigger JIRA to connect (or however that works). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #536: TINKERPOP-1602 Support SSL client certificate authenti...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/536 Looks like I can copy GremlinServerIntegrateTest --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384  ## Color codes: -BLACK - RED - GREEN - YELLOW - BLUE - MAGENTA - CYAN - WHITE ### Background Colors - BG_BLACK - BG_RED - BG_GREEN - BG_YELLOW - BG_BLUE - BG_MAGENTA - BG_CYAN - BG_WHITE ### Attributes - RESET - INTENSITY_BOLD - INTENSITY_FAINT - ITALIC - UNDERLINE - BLINK_SLOW - BLINK_FAST - BLINK_OFF - NEGATIVE_ON - NEGATIVE_OFF - CONCEAL_ON - CONCEAL_OFF - UNDERLINE_DOUBLE - UNDERLINE_OFF - BOLD - FAINT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 I think a mockup of the desired coloring effect would be nice to have. Currently elements just have toString called on them. I added a vertex.color and edge.color for demonstration purposes. Here's what it would look like. Let me know if that's worth committing.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 Disco disco! ANSI is enabled by default. This is actually not a change. It was this way before this PR. No color scheme by default. If you want colors, you have to set them yourself. Added colorizing for String, Number, and values within Iterables. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 I'm definitely not the right person to pick a color scheme. Open for suggestions or we can figure it out later. Committed the vertex, edge, path coloring so you can see. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #385: TINKERPOP-1285 added multi-line line number support
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/385 This is failing due to some random error, not the code change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/384#discussion_r75560386
--- Diff:
gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/GremlinGroovysh.groovy
---
@@ -45,12 +46,13 @@ class GremlinGroovysh extends Groovysh {
Command findCommand(final String line, final List parsedArgs =
null) {
def l = line ?: ""
-final List args = parseLine(l)
-if (args.size() == 0) return null
+final List linetokens = parseLine(l)
+if (linetokens.size() == 0) return null
-def cmd = registry.find(args[0])
+def cmd = registry.find(linetokens[0])
-if (cmd != null && args.size() > 1 && parsedArgs != null) {
+if (cmd != null && linetokens.size() > 1 && parsedArgs != null) {
+List args = CommandArgumentParser.parseLine(line,
parsedArgs == null ? 1 : -1)
--- End diff --
groovysh added this line 1 month after this code was written.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 I think I'll leave templating for another jira ticket. :satisfied: Currently, themes (really any `:set` commands) can be saved into files and loaded with `:load my-gremlin.theme`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 I'm done with changes. Carry on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #384: TINKERPOP-1037 Made life more colorful
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/384 TINKERPOP-1037 Made life more colorful Stephen did all the hard work. - Added option -C to disable ANSI colors just in case. - Colorized the gremlin ascii art. - Added bold red to some, but probably not all, error messages - Snuck in the help text for TINKERPOP-1246 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1037 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #384 commit ef518fbfef1910a73183abeed0bee90ba38e9a1f Author: Robert Dale <robd...@gmail.com> Date: 2016-08-18T17:34:04Z made life more colorful --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #383: TINKERPOP-1246 Added help message to console
Github user robertdale closed the pull request at: https://github.com/apache/tinkerpop/pull/383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 Screenshot:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 @pluradj I noticed that too. I was thinking that metaclass could be used to intercept calls to groovy shell's Preferences class and gremlin console could have its own Java Preferences node. This would give it full separation from normal 'groovysh'. I believe that currently max-iteration is the only gremlin-specific pref. So if we do decide to use namespaces, then max-iteration should be deprecated but supported with and without namespace. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #401: fixed option step header
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/401 fixed option step header You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop ref-option-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/401.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #401 commit 7cae75a8af39fa583dbcc66382595de9427262c3 Author: Robert Dale <robd...@gmail.com> Date: 2016-09-06T20:54:13Z fixed option step header --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #400: Added JitPack Maven repository to Grape configuration
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/400 Ok. Didn't notice it mentioned docker and I can't speak to that. However, it is very repeatable on other systems. Given no other configuration... ``` rm -rf ~/.groovy rm -rf ~/.m2 $ ./bin/gremlin.sh \,,,/ (o o) -oOOo-(3)-oOOo- plugin activated: tinkerpop.server plugin activated: tinkerpop.utilities plugin activated: tinkerpop.tinkergraph gremlin> :install org.apache.tinkerpop neo4j-gremlin 3.2.1 ==>Error grabbing Grapes -- [unresolved dependency: com.github.jeremyh#jBCrypt;jbcrypt-0.4: not found] gremlin> ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #400: Added JitPack Maven repository to Grape configuration
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/400 Do you also clean your groovy/grapes dir? artifacts will be copied there from maven. afterwards, it won't reference the maven artifacts unless they are also missing from grapes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #402: fixed hardcoded link
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/402 fixed hardcoded link You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop fix-hardcoded-link Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/402.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #402 commit 505d42d52735070897aa48ce117465cd32b8293e Author: Robert Dale <robd...@gmail.com> Date: 2016-09-08T15:38:01Z fixed hardcoded link --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #399: TINKERPOP-1369 Renamed REST API to HTTP API
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/399 TINKERPOP-1369 Renamed REST API to HTTP API You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1369 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/399.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #399 commit bb0ea485e604bfda4dedd711961d7abb46f61780 Author: Robert Dale <robd...@gmail.com> Date: 2016-09-04T14:56:46Z TINKERPOP-1369 renamed REST to HTTP --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #395: TP31: Server missing scripts directory
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/395 OK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #394: Server missing scripts directory
Github user robertdale closed the pull request at: https://github.com/apache/tinkerpop/pull/394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #395: TP31: Server missing scripts directory
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/395 Hold on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #395: TP31: Server missing scripts directory
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/395 TP31: Server missing scripts directory Fixed distribution scripts target directory. You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop server-missing-scripts-dir-tp31 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/395.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #395 commit db8ee8a2c3c5472fec6f6560817548d3b015fc2e Author: Robert Dale <robd...@gmail.com> Date: 2016-08-30T10:50:28Z Fixed scripts target directory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #414: Release name generator
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/414 Release name generator $ groovy release-name-generator.groovy Twenty-Four Gremlin From Tulsa $ groovy release-name-generator.groovy (I'd) Wait a Million Gremlin $ groovy release-name-generator.groovy Two Gremlin $ groovy release-name-generator.groovy Twelve Gremlin of Christmas $ groovy release-name-generator.groovy 1, 2, 3, Red Gremlin $ groovy release-name-generator.groovy 1 Gremlin $ groovy release-name-generator.groovy Twelve Volt Gremlin You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop release-name-generator Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/414.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #414 commit bd96bb3bb1f65d7b72d25895e6a1864566b8e70f Author: Robert Dale <robd...@gmail.com> Date: 2016-09-14T12:18:51Z Added release name generator --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #414: Release name generator
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/414 That's ok. I don't actually expect this to get merged. Just for fun. This was a convenient way to share. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #414: Release name generator
Github user robertdale closed the pull request at: https://github.com/apache/tinkerpop/pull/414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 Upstart looks simple enough. I don't know if the one @dkuppitz created, referenced in TINKERPOP-980 , is still viable. But I can't test. Any volunteers? I would have to say that it's not customary for systemd/upstart templates to be in `bin/`. They're really not binaries, more like configuration for those apps. Maybe create an `extras/` dir? The initd script is a real, executable script with `start, stop, status`. I didn't want to modify `gremlin-server.sh` since it has some functionality over a pure init script like install deps, run in foreground, pass conf file. However, it also has its short-comings like it can only be run in the install dir. The initd script can be run from anywhere and also can be directly referenced from initd. That said, it's not unusual for the main server script to also be the initd script. My preference would be to merge the two. But there *should* be a breaking change in that executing `gremlin-server.sh` would show help instead of running in the foreground. Would probably add a new option to run in foreground, `start -f`. Passing a conf file can still work, with or without start. `-i` can still work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 Maybe if the script detects that it's called via link with no parameters, then it's in initd mode and displays help. If the script is called directly with no parameters, then it just runs in foreground. Then there's no breaking change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 - `gremlin-server.sh` _is_ the init script. This makes it more inline with other Apache servers like Tomcat, ActiveMQ, solr, etc. - Moved how to install "As A Service" from Upgrade to Gremlin Server Configuration per @PommeVerte - Also added parameters and environment config to Server Configuration section - Deprecated `-i` in favor of `install` - Starting `gremlin-server.sh` without parameters is a breaking change. Amazingly, it's not ever actually used anywhere without parameters. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 That should still work. What won't work is an invocation of just "gremlin-server.sh" without parameters. I didn't find any in the code base nor in the docs (which is highly convenient). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 I just tested with backgrounding the job and killing that. That also still works. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #452: TINKERPOP-1189 Increased performance of Credent...
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/452 TINKERPOP-1189 Increased performance of CredentialGraph authentication Using lowest complexity 4 (was 10). You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1189 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/452.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #452 commit 636fbc0d3718ff96d6d02e51cdcba0c1b4f11356 Author: Robert Dale <robd...@gmail.com> Date: 2016-10-10T12:40:40Z bcrypt: use lowest complexity for performance --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #430: Fix store step documentation
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/430 Fix store step documentation Query produces 2 results since 3.0.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop store-step-doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/430.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #430 commit bf88829bc5ac7b012269b4207533bc6a70cfd6fb Author: Robert Dale <robd...@gmail.com> Date: 2016-09-21T18:22:08Z Query produces 2 results since 3.0.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #413: TINKERPOP-1442 Improved session cleanup on client clos...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/413 I'm just going to throw my $0.02 out there. Maybe I don't understand the use case, but this seems strange and unexpected to me. I don't understand why or how a completely separate client would affect another. Isn't one of the reasons for using sessions is that a client can come in and out while retaining state? How would a client safely disconnect and reconnect later without killing the session and other clients? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #433: TINKERPOP-1249 Add keep-alive functionality to websock...
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/433
Tested a clean console build with 3.2.2 server. Pinging works as expected.
Closing each Client, a Cluster, and ':remote close' does stop pinging as
expected.
Not sure what the expected behavior is here but this does not stop pinging
after close. I had expected it to work like Client. Instead the Cluster must
be closed.
```
cluster = Cluster.open('conf/remote-objects.yaml')
rem = DriverRemoteConnection.using(cluster, 'g')
g = EmptyGraph.instance().traversal().withRemote(rem)
g.V()
rem.close()
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #433: TINKERPOP-1249 Add keep-alive functionality to websock...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/433 Yup, there it is right there in the javadoc: When close() is called, the Cluster is left open for the caller to close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #385: TINKERPOP-1285 added multi-line line number sup...
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/385 TINKERPOP-1285 added multi-line line number support Looks like: ``` gremlin> gremlin> 1 + 001 2 + 002 3 + 003 x No such property: x for class: groovysh_evaluate Display stack trace? [yN] 003 4 ==>10 ``` Note that the line number remained the same for the correction. Example from the jira ticket: ``` gremlin> script = """line1 001 line2 002 line3 003 ... 004 """ ==>line1 line2 line3 ... gremlin> ``` Multi-line query: ``` gremlin> gremlin> g.V().has( 001 'name', 002 'marko') ==>v[1] gremlin> ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1285 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/385.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #385 commit 96537e40844731ad7efd0e513fac15b13dae16d7 Author: Robert Dale <robd...@gmail.com> Date: 2016-08-18T19:18:31Z added multi-line line number support --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 There are some things that are out of our control because they are inherited from groovy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 Would you really want a separate preferences (properties) file or rather reuse the existing preferences mechanism (:set gremlin.console.errorMessage red) ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #385: TINKERPOP-1285 added multi-line line number support
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/385 This was rebased on master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #391: Fixed empty result
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/391 Fixed empty result Forgot to test this one. Fixed now. You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop emptyResult-bugfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/391.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #391 commit 629ad68865c16b3924e26dcfa940d38ccc6f04cb Author: Robert Dale <robd...@gmail.com> Date: 2016-08-27T11:43:10Z fixed empty result --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #385: TINKERPOP-1285 added multi-line line number support
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/385 @spmallette I can rebase on latest master. Just let me know. Do you think there is any point in keeping the leading zeroes? ``` gremlin> 1+ ..1> 2+ ..2> 3+ ..3> 4 ``` Alt prompt: ``` g> 1+ 1> 2+ 2> 3+ 3> 4 ==>10 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #385: TINKERPOP-1285 added multi-line line number support
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/385 I would only be against `===>` because that looks like the result prompt. I would probably lean towards `001>`. Maybe: ``` gremlin> 1 + 001> 1 + 002> 1 + 003> 1 ==>4 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #385: TINKERPOP-1285 added multi-line line number support
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/385 OK. And when this is merged with the color preferences PR, it will be adjusted and left-filled with `.` for the input.prompt length, but no less than `000>`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #438: Fix conf dir references
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/438 Rebased on tp31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #438: Fix conf dir references
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/438 Build is good with `mvn clean install` on my machine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #439: TINKERPOP-980: added sysv and systemd init scri...
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/439 TINKERPOP-980: added sysv and systemd init scripts I don't know if you want all of this in bin/. I could definitely see the systemd gremlin-server.service moving out since it's more of a template but I don't know where else to put it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertdale/tinkerpop TINKERPOP-980 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/439.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #439 commit 84ddacd6a88eb8291a3a5df1a7c5a0b225e1f5fd Author: Robert Dale <robd...@gmail.com> Date: 2016-09-28T00:27:47Z added sysv and systemd init scripts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 Cool. I was wondering how to link. Didn't think it was absolute. I hope it works. Tried testing with `./docker/build.sh -d` but it hangs at installing plugins `* hadoop-gremlin ...`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #399: TINKERPOP-1369 Renamed REST API to HTTP API
Github user robertdale closed the pull request at: https://github.com/apache/tinkerpop/pull/399 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #446: TINKERPOP-1483: valueMap should always return string k...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/446 Thanks for the clarification @dkuppitz `./docker/build.sh -t -i -n ` passes VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #446: TINKERPOP-1483: valueMap should always return string k...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/446 Can this PR be updated with Map<Object, Object> or should it be closed and open a new one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #446: TINKERPOP-1483: valueMap should always return string k...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/446 This is interesting. I was unaware of some or didn't understand some implementation details. Taking a step back and looking at this again, I wonder if the original intent is more correct. Sorry @JPMoresmau :smiley: We have to ask what is the purpose of `Hidden`? And what is the purpose of `T.*.getAccessor()`? Looks like `Has` step internally use `T.*.getAccessor()` for equality tests. Is this more of an internal method or should it be exposed? Ultimately, the question is with what or how do we expect to access `T` tokens in a value map? Given: `map = g.V().valueMap(true).next()` Access by: `map.get(T.id)` **or** `map.get(T.id.getAccessor())`? If the answer is `T.id` then the interface must be <Object,Object> If the answer is `T.id.getAccessor()` then the interface must be <String,Object> In either case, there is no conflict between system-level `T` tokens (e.g. `T.id`), as these are either Enum or `Hidden`, and user-level strings (e.g. `id`). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/457 I didn't consider that your remote branch was behind. Duh. What should have been done is a forced push `git push -f origin tp31` to replace your remote branch with your local branch. Instead git ended up doing a merge and the history here looks a little weird because it pulled in all the changes since your changes. But git does the right thing and it merges cleanly on tp31. Build passes on Linux. Can't test on windows. VOTE: +0.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/457 @pauljackson It's all good. It's only the history here in the PR that looks weird. Since it's just the one commit, it'll be right in git history when it's actually merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #:
Github user robertdale commented on the pull request: https://github.com/apache/tinkerpop/commit/4eba658bcb347679eda964c27595e5d3969a199a#commitcomment-19987601 In CHANGELOG.asciidoc: In CHANGELOG.asciidoc on line 49: 1. Isn't it Map<Object,Object>? 2. It should be T.id and T.label --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #494: TINKERPOP-1443 - Introduce API check into the build
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/494 I'm on Apache Maven 3.3.9 (latest). So I'm ok with downgrading :trollface: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #496: TINKERPOP-1556 allow developers to pass options...
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/496 TINKERPOP-1556 allow developers to pass options to docker This was a much smaller change than I expected. Originally I was adding some sysctl settings to the dockerfiles. In the end I discovered I could control that and much more from docker itself. So I'm going to go ahead and commit this small change. example: ``` export DOCKER_OPTS="--cpuset-cpus 0-3 --sysctl net.ipv6.conf.all.disable_ipv6=1 --sysctl net.ipv6.conf.default.disable_ipv6=1" ./docker/build.sh -t -n -i ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1556 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/496.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #496 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #496: TINKERPOP-1556 allow developers to pass options to doc...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/496 Technically, neither, not even for the daemon. It's specific to certain distribution startup scripts. So there should be no overlap here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #498: TINKERPOP-1557 Improve docker build time with this one...
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/498
There's probably over an hour that can be gained in giraph that's spent in
waiting for everything to shutdown in each test run (about 6s each). Looks like
it's zookeper. But I don't really know anything about giraph, zookeeper,
hadoop. If someone has a better idea, here's the shutdown sequence:
```
[INFO] org.apache.giraph.comm.netty.NettyClient - stop: Halting netty client
[INFO] org.apache.giraph.comm.netty.NettyClient$2 - stop: reached wait
threshold, 1 connections closed, releasing resources now.
[INFO] org.apache.giraph.worker.BspServiceWorker - processEvent: Job state
changed, checking to see if it needs to restart
[INFO] org.apache.giraph.master.BspServiceMaster - setJobState:
{"_applicationAttemptKey":-1,"_stateKey":"FINISHED","_superstepKey":-1}
[INFO] org.apache.giraph.bsp.BspService - getJobState: Job state already
exists (/_hadoopBsp/job_local2106675051_0003/_masterJobState)
[INFO] org.apache.giraph.master.BspServiceMaster - cleanup: Notifying
master its okay to cleanup with
/_hadoopBsp/job_local2106675051_0003/_cleanedUpDir/0_master
[INFO] org.apache.giraph.master.BspServiceMaster - cleanUpZooKeeper: Node
/_hadoopBsp/job_local2106675051_0003/_cleanedUpDir already exists, no need to
create.
[INFO] org.apache.giraph.master.BspServiceMaster - cleanUpZooKeeper: Got 1
of 2 desired children from /_hadoopBsp/job_local2106675051_0003/_cleanedUpDir
[INFO] org.apache.giraph.master.BspServiceMaster - cleanedUpZooKeeper:
Waiting for the children of /_hadoopBsp/job_local2106675051_0003/_cleanedUpDir
to change since only got 1 nodes.
[INFO] org.apache.giraph.comm.netty.NettyClient - stop: Netty client halted
[INFO] org.apache.giraph.utils.LoggerUtils - saveVertices: Starting to save
6 vertices using 1 threads
[INFO] org.apache.giraph.utils.LoggerUtils - saveVertices: Done saving
vertices.
[WARN] org.apache.giraph.worker.BspServiceWorker - saveEdges:
giraph.edgeOutputFormatClass => null [EdgeOutputFormat] (class)
Make sure that the EdgeOutputFormat is not required.
[INFO] org.apache.giraph.bsp.BspService - process: cleanedUpChildrenChanged
signaled
[INFO] org.apache.giraph.worker.BspServiceWorker - cleanup: Notifying
master its okay to cleanup with
/_hadoopBsp/job_local2106675051_0003/_cleanedUpDir/0_worker
[INFO] org.apache.giraph.master.BspServiceMaster - cleanUpZooKeeper: Got 2
of 2 desired children from /_hadoopBsp/job_local2106675051_0003/_cleanedUpDir
[INFO] org.apache.giraph.master.BspServiceMaster - cleanup: Removed HDFS
checkpoint directory (_bsp/_checkpoints//job_local2106675051_0003) with return
= false since the job HadoopGremlin(Giraph):
org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest$VertexProgramK@68c9bafc
succeeded
[INFO] org.apache.giraph.comm.netty.NettyClient - stop: Halting netty client
[INFO] org.apache.giraph.comm.netty.NettyClient$2 - stop: reached wait
threshold, 1 connections closed, releasing resources now.
[INFO] org.apache.zookeeper.ZooKeeper - Session: 0x15873a7d0540001 closed
[INFO] org.apache.zookeeper.ClientCnxn$EventThread - EventThread shut down
[INFO] org.apache.giraph.comm.netty.NettyServer - stop: Halting netty server
[INFO] org.apache.giraph.comm.netty.NettyServer - stop: Start releasing
resources
[INFO]
org.apache.giraph.job.HaltApplicationUtils$DefaultHaltInstructionsWriter -
writeHaltInstructions: To halt after next superstep execute:
'bin/halt-application --zkServer bccc11278890:22181 --zkNode
/_hadoopBsp/job_local2106675051_0003/_haltComputation'
[INFO] org.apache.giraph.comm.netty.NettyClient - stop: Netty client halted
[INFO] org.apache.giraph.comm.netty.NettyServer - stop: Netty server halted
[INFO] org.apache.giraph.comm.netty.NettyServer - stop: Halting netty server
[INFO] org.apache.giraph.comm.netty.NettyServer - stop: Start releasing
resources
[INFO] org.apache.giraph.comm.netty.NettyServer - stop: Netty server halted
[INFO] org.apache.giraph.bsp.BspService - process:
masterElectionChildrenChanged signaled
[INFO] org.apache.zookeeper.ClientCnxn$EventThread - EventThread shut down
[INFO] org.apache.zookeeper.ZooKeeper - Session: 0x15873a7d054 closed
[INFO] org.apache.giraph.master.MasterThread - setup: Took 0.006 seconds.
[INFO] org.apache.giraph.master.MasterThread - input superstep: Took 0.163
seconds.
[INFO] org.apache.giraph.master.MasterThread - superstep 0: Took 0.034
seconds.
[INFO] org.apache.giraph.master.MasterThread - shutdown: Took 6.632 seconds.
[INFO] org.apache.giraph.master.MasterThread - total: Took 6.836 seconds.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
[GitHub] tinkerpop issue #498: TINKERPOP-1557 Improve docker build time with this one...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/498 @okram The giraph improvement will help all builds inside or outside of docker. That should save you about 1 hour. I don't know what OS you're on, but in Linux you can get some speed improvement if your fs is mounted with noatime (and lazytime on newer kernels). For the ultimate speed improvement, you can make your changes on the regular fs then copy up to an in-memory fs (e.g. tmpfs) and then build there. That should save 20m just on neo4j and several more overall. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #498: TINKERPOP-1557 Improve docker build time with this one...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/498 @spmallette I concur with @dkuppitz that you don't appear to be using tmpfs. What OS, branches, etc, and how to reproduce the mkdirs issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #498: TINKERPOP-1557 Improve docker build time with this one...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/498 @spmallette looks like this: ``` Step 5 : CMD sh -c docker/scripts/build.sh -t -i -n ---> Running in 3ab3e0b10487 ---> 1baf7291ec3a Removing intermediate container 3ab3e0b10487 Successfully built 1baf7291ec3a Copying source to in-memory tmpfs ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #498: TINKERPOP-1557 Improve docker build time with this one...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/498 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #502: Tweaks for broad JDK8 support
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/502 I like the refactoring. But why go backwards in java version? Is this for source or target compatibility? If it's source, I can't imagine as a dev you don't have the ability to upgrade to something released in the past year. As for target, let alone that java 8 should work on java 8, the CVEs should scare anyone enough to not run anything less than the latest. @okram You commented for using Java 1.8.0_40. Can you recall what/why? > tinkerpop.xml master pom requires the build to be on Java 1.8.0_40+. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #498: TINKERPOP-1557 Improve docker build time with t...
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/498 TINKERPOP-1557 Improve docker build time with this one weird trick! Total time went from just over 4 hours to 2:20m. Get back 1:40m of your cycles! Giraph: startup would wait 3s to connect. solution: wait less. There's still about 7s for shutting down that can be gained back per test! Neo4j: very disk IO heavy. solution: work in memory. this benefits the entire build as well. This requires something special below. In order to build in-memory, you must configure tmpfs with the magical directory name `/usr/src/tinkermem`. example: ``` export DOCKER_OPTS="--tmpfs /usr/src/tinkermem:exec,mode=0755,rw,noatime,size=1000m" ``` You can use `1000m` for typical `-t -i -n` usage. Use `2000m` if building javadoc, asciidocs. I will add some of this to the docker contributing / development-environment docs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1557 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/498.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #498 commit a39c2fa23989bd9874205a4970c7647020eb0c7e Author: Robert Dale <robd...@gmail.com> Date: 2016-11-17T22:01:47Z build faster with in-memory fs make giraph wait less --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #504: TINKERPOP-1548: Traversals can complete before interru...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/504 I've seen this on master. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #504: TINKERPOP-1548: Traversals can complete before ...
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/504#discussion_r88893084
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionComputerTest.java
---
@@ -86,7 +97,7 @@ public void shouldRespectThreadInterruptionInVertexStep()
throws Exception {
// total time for test should not exceed 5 seconds - this prevents
the test from just hanging and allows
// it to finish with failure
-assertThat(startedIterating.await(5000, TimeUnit.MILLISECONDS),
CoreMatchers.is(true));
+assertThat(startedIterating.await(1000, TimeUnit.MILLISECONDS),
CoreMatchers.is(true));
--- End diff --
Why not just leave this as 5s? Seems to work against the fix. What is the
actual timeout time value?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #482: TINKERPOP-1541: Select should default to Pop.last sema...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/482 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 @spmallette I pushed the windows changes. can you review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 @PommeVerte do you mind if we move the ubuntu script to a separate pull request so this one can move forward? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
