Re: Early Access builds of JDK 8u112 b04, JDK 9 b130 are available on java.net

[Mark Thomas]

On 31/08/2016 08:59, Chris Hegarty wrote:
> On 08/08/16 11:20, Chris Hegarty wrote:
>>
>>> On 8 Aug 2016, at 08:51, Rory O'Donnell 
>>> wrote:
>>>
>>> Hi Mark,
>>>
>>> There are two fixes to bugs reported by you in b130, can you confirm
>>> fixes  ?
>>>
>>> Early Access b130  for JDK 9 is
>>> available on java.net, summary of  changes are listed here
>>> .
>>>
>>> 8156824 core-libs com.sun.jndi.ldap.pool.PoolCleaner should clear its
>>> context class loader
>>> 8157570 core-libs sun.rmi.transport.GC retains a strong reference to
>>> the context class loader
>>
>> With the two changes above, then several cleanups in
>> JreMemoryLeakPreventionListener::lifecycleEvent can be done in a JDK 9
>> specific Tomcat source trunk. Otherwise, if the code needs to run on
>> older
>> releases, it can be be made version specific, where it is not executed on
>> JDK 9 or greater.
>>
>> There is another of these unnecessary retention of the context class
>> loader
>> issues, 8156841 [1], that I hope to address in a near future build of
>> JDK 9.
> 
> 
> JDK bug 8156841 has been fixed in JDK 9 b133. The same
> isJre9Available() technique can be used to avoid
> tokenPollerProtection.

Fantastic. And just in time for the next round of releases.

Many thanks to everyone who helped get this fixed.

Mark


> 
> -Chris.
> 
>> -Chris.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8156841
>>
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Early Access builds of JDK 8u112 b04, JDK 9 b130 are available on java.net

[Chris Hegarty]

On 08/08/16 11:20, Chris Hegarty wrote:



On 8 Aug 2016, at 08:51, Rory O'Donnell  wrote:

Hi Mark,

There are two fixes to bugs reported by you in b130, can you confirm fixes  ?

Early Access b130  for JDK 9 is available on 
java.net, summary of  changes are listed here 
.

8156824 core-libs com.sun.jndi.ldap.pool.PoolCleaner should clear its context 
class loader
8157570 core-libs sun.rmi.transport.GC retains a strong reference to the 
context class loader


With the two changes above, then several cleanups in
JreMemoryLeakPreventionListener::lifecycleEvent can be done in a JDK 9
specific Tomcat source trunk. Otherwise, if the code needs to run on older
releases, it can be be made version specific, where it is not executed on
JDK 9 or greater.

There is another of these unnecessary retention of the context class loader
issues, 8156841 [1], that I hope to address in a near future build of JDK 9.



JDK bug 8156841 has been fixed in JDK 9 b133. The same
isJre9Available() technique can be used to avoid
tokenPollerProtection.

-Chris.


-Chris.

[1] https://bugs.openjdk.java.net/browse/JDK-8156841



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Early Access builds of JDK 8u112 b04, JDK 9 b130 are available on java.net

[Rory O'Donnell]

On 08/08/2016 21:04, Mark Thomas wrote:

On 08/08/2016 16:09, Mark Thomas wrote:

I need to review the remaining things in JreMemoryLeakPreventionListener
to see if any of them need to be raised as bugs.

I've now done this and I only found one issue that I think is reasonable
to raise as a JDK issue.

JarURLConnection needs to disable caching by default to avoid file
descriptor leaks / locked files.

I've opened a bug which is currently being tracked under JI-9042682

https://bugs.openjdk.java.net/browse/JDK-8163449

Rgds,Rory


Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Early Access builds of JDK 8u112 b04, JDK 9 b130 are available on java.net

[Mark Thomas]

On 08/08/2016 16:09, Mark Thomas wrote:
> I need to review the remaining things in JreMemoryLeakPreventionListener
> to see if any of them need to be raised as bugs.

I've now done this and I only found one issue that I think is reasonable
to raise as a JDK issue.

JarURLConnection needs to disable caching by default to avoid file
descriptor leaks / locked files.

I've opened a bug which is currently being tracked under JI-9042682

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Early Access builds of JDK 8u112 b04, JDK 9 b130 are available on java.net

[Mark Thomas]

On 08/08/2016 11:20, Chris Hegarty wrote:
> 
>> On 8 Aug 2016, at 08:51, Rory O'Donnell  wrote:
>>
>> Hi Mark,
>>
>> There are two fixes to bugs reported by you in b130, can you confirm fixes  ?
>>
>> Early Access b130  for JDK 9 is available 
>> on java.net, summary of  changes are listed here 
>> .
>>
>> 8156824 core-libs com.sun.jndi.ldap.pool.PoolCleaner should clear its 
>> context class loader
>> 8157570 core-libs sun.rmi.transport.GC retains a strong reference to the 
>> context class loader

I can confirm that both these issues are resolved in Java 9 b130.

For the benefit of those following the Tomcat dev list, the fix is not in:
- Java 9, b129 ()jigsaw)
- Java 8u112, b4

> With the two changes above, then several cleanups in
> JreMemoryLeakPreventionListener::lifecycleEvent can be done in a JDK 9
> specific Tomcat source trunk. Otherwise, if the code needs to run on older
> releases, it can be be made version specific, where it is not executed on
> JDK 9 or greater.

Tomcat 9 targets Java EE 8 which means it has to be able to run on Java
8. Therefore, given that the above issues will be fixed in the first
Java 9 release, I intend to disable the protection if Java 9 is detected.

> There is another of these unnecessary retention of the context class loader
> issues, 8156841 [1], that I hope to address in a near future build of JDK 9.

Excellent news.

The other open issue I'm aware of related to the
JreMemoryLeakPreventionListener is this one:

https://bugs.openjdk.java.net/browse/JDK-8146961

I need to review the remaining things in JreMemoryLeakPreventionListener
to see if any of them need to be raised as bugs.

Thanks to everyone who has helped progress the fixes for these issues.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Early Access builds of JDK 8u112 b04, JDK 9 b130 are available on java.net

[Chris Hegarty]

> On 8 Aug 2016, at 08:51, Rory O'Donnell  wrote:
> 
> Hi Mark,
> 
> There are two fixes to bugs reported by you in b130, can you confirm fixes  ?
> 
> Early Access b130  for JDK 9 is available on 
> java.net, summary of  changes are listed here 
> .
> 
> 8156824 core-libs com.sun.jndi.ldap.pool.PoolCleaner should clear its context 
> class loader
> 8157570 core-libs sun.rmi.transport.GC retains a strong reference to the 
> context class loader

With the two changes above, then several cleanups in
JreMemoryLeakPreventionListener::lifecycleEvent can be done in a JDK 9
specific Tomcat source trunk. Otherwise, if the code needs to run on older
releases, it can be be made version specific, where it is not executed on
JDK 9 or greater.

There is another of these unnecessary retention of the context class loader
issues, 8156841 [1], that I hope to address in a near future build of JDK 9.

-Chris.

[1] https://bugs.openjdk.java.net/browse/JDK-8156841
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Early Access builds of JDK 8u112 b04, JDK 9 b130 are available on java.net

[Rory O'Donnell]

Hi Mark,

There are two fixes to bugs reported by you in b130, can you confirm 
fixes  ?


Early Access b130  for JDK 9 is 
available on java.net, summary of  changes are listed here 
.


8156824 core-libs com.sun.jndi.ldap.pool.PoolCleaner should clear its 
context class loader
8157570 core-libs sun.rmi.transport.GC retains a strong reference to the 
context class loader



Early Access b129  (#5332) for JDK 9 with 
Project Jigsaw is available on java.net, summary of changes are listed 
here 



Early Access b04  for JDK 8u112 is 
available on java.net, summary of  changes are listed here 




Rgds,Rory

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland