Re: [edk2-devel] [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table
Good, Thank you Samer. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Samer El- > Haj-Mahmoud > Sent: Thursday, March 17, 2022 9:26 PM > To: Yao, Jiewen ; Sami Mujawar > ; Xu, Min M ; > devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Wang, > Jian J ; Lu, Ken ; Gerd Hoffmann > ; nd ; Thanu Rangarajan > ; Samer El-Haj-Mahmoud mahm...@arm.com> > Subject: Re: [edk2-devel] [PATCH 5/8] MdePkg: Define CC Measure EventLog > ACPI Table > > Thanks Sami and Jiewen. > > I will bring this to ASWG attention to confirm the change. > > > > > -Original Message- > > From: Yao, Jiewen > > Sent: Thursday, March 17, 2022 9:23 AM > > To: Sami Mujawar ; Xu, Min M > > ; devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming > > ; Liu, Zhiguang ; Wang, > > Jian J ; Lu, Ken ; Gerd Hoffmann > > ; nd ; Samer El-Haj-Mahmoud > > ; Thanu Rangarajan > > > > Subject: RE: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table > > > > Thanks to remind me. > > > > I uploaded version 2 in the same mantis. > > > > Thank you > > Yao Jiewen > > > > > -Original Message- > > > From: Sami Mujawar > > > Sent: Thursday, March 17, 2022 9:10 PM > > > To: Yao, Jiewen ; Xu, Min M > > ; > > > devel@edk2.groups.io > > > Cc: Kinney, Michael D ; Gao, Liming > > > ; Liu, Zhiguang ; > > Wang, > > > Jian J ; Lu, Ken ; Gerd Hoffmann > > > ; nd ; Samer El-Haj-Mahmoud > > > > haj-mahm...@arm.com>; Thanu Rangarajan > > > > > Subject: Re: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table > > > > > > Hi Jiewen, > > > > > > I was informed there is an ASWG ECR > > > https://mantis.uefi.org/mantis/view.php?id=2177 for TDEL. I can see the > > > content has been approved for ACPI 6.5. > > > > > > Do you plan to update this ECR to reflect the changes for CCEL or this > > > would > > be > > > a separate request? > > > > > > Regards, > > > > > > Sami Mujawar > > > > > > On 10/03/2022, 10:27, "Sami Mujawar" wrote: > > > > > > Hi Jiewen, > > > > > > Please find my response inline marked [SAMI]. > > > > > > Regards, > > > > > > Sami Mujawar > > > > > > On 10/03/2022, 05:49, "Yao, Jiewen" wrote: > > > > > > HI Sami > > > I think it is OK to update signature to `CCEL`. That means it > > > will be > > applicable > > > for other CC, right? > > > [SAMI] Yes, the same table can then be used by other CC. > > > > > > Then, I recommend we add CcType there. > > > > > > typedef struct { > > > EFI_ACPI_DESCRIPTION_HEADERHeader; > > > EFI_CC_TYPE CcType; <== new field. > > > UINT16 Rsvd; > > > UINT64 Laml; > > > UINT64 Lasa; > > > } EFI_CC_EVENTLOG_ACPI_TABLE; > > > > > > Do you agree? > > > [SAMI] Agree, the above suggestion looks good to me. > > > > > > Thank you > > > Yao Jiewen > > > > > > > -Original Message- > > > > From: Sami Mujawar > > > > Sent: Wednesday, March 9, 2022 11:35 PM > > > > To: Xu, Min M ; devel@edk2.groups.io > > > > Cc: Kinney, Michael D ; Gao, Liming > > > > ; Liu, Zhiguang > > ; > > > Yao, > > > > Jiewen ; Wang, Jian J > > ; > > > Lu, Ken > > > > ; Gerd Hoffmann ; nd > > > ; > > > > Samer El-Haj-Mahmoud ; > > > > thanu.rangara...@arm.com > > > > Subject: Re: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI > > > Table > > > > > > > > Hi Min, > > > > > > > > Thank you for this patch. > > > > > > > > Please find my response inline marked [SAMI]. > > > > > > > > Regards, > > > > > > > > Sami Mujawar > > > > > > > > > > > > On 02/03
Re: [edk2-devel] [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table
Thanks Sami and Jiewen. I will bring this to ASWG attention to confirm the change. > -Original Message- > From: Yao, Jiewen > Sent: Thursday, March 17, 2022 9:23 AM > To: Sami Mujawar ; Xu, Min M > ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Wang, > Jian J ; Lu, Ken ; Gerd Hoffmann > ; nd ; Samer El-Haj-Mahmoud > ; Thanu Rangarajan > > Subject: RE: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table > > Thanks to remind me. > > I uploaded version 2 in the same mantis. > > Thank you > Yao Jiewen > > > -Original Message- > > From: Sami Mujawar > > Sent: Thursday, March 17, 2022 9:10 PM > > To: Yao, Jiewen ; Xu, Min M > ; > > devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming > > ; Liu, Zhiguang ; > Wang, > > Jian J ; Lu, Ken ; Gerd Hoffmann > > ; nd ; Samer El-Haj-Mahmoud > > haj-mahm...@arm.com>; Thanu Rangarajan > > > Subject: Re: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table > > > > Hi Jiewen, > > > > I was informed there is an ASWG ECR > > https://mantis.uefi.org/mantis/view.php?id=2177 for TDEL. I can see the > > content has been approved for ACPI 6.5. > > > > Do you plan to update this ECR to reflect the changes for CCEL or this would > be > > a separate request? > > > > Regards, > > > > Sami Mujawar > > > > On 10/03/2022, 10:27, "Sami Mujawar" wrote: > > > > Hi Jiewen, > > > > Please find my response inline marked [SAMI]. > > > > Regards, > > > > Sami Mujawar > > > > On 10/03/2022, 05:49, "Yao, Jiewen" wrote: > > > > HI Sami > > I think it is OK to update signature to `CCEL`. That means it will > > be > applicable > > for other CC, right? > > [SAMI] Yes, the same table can then be used by other CC. > > > > Then, I recommend we add CcType there. > > > > typedef struct { > > EFI_ACPI_DESCRIPTION_HEADERHeader; > > EFI_CC_TYPE CcType; <== new field. > > UINT16 Rsvd; > > UINT64 Laml; > > UINT64 Lasa; > > } EFI_CC_EVENTLOG_ACPI_TABLE; > > > > Do you agree? > > [SAMI] Agree, the above suggestion looks good to me. > > > > Thank you > > Yao Jiewen > > > > > -Original Message- > > > From: Sami Mujawar > > > Sent: Wednesday, March 9, 2022 11:35 PM > > > To: Xu, Min M ; devel@edk2.groups.io > > > Cc: Kinney, Michael D ; Gao, Liming > > > ; Liu, Zhiguang > ; > > Yao, > > > Jiewen ; Wang, Jian J > ; > > Lu, Ken > > > ; Gerd Hoffmann ; nd > > ; > > > Samer El-Haj-Mahmoud ; > > > thanu.rangara...@arm.com > > > Subject: Re: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI > > Table > > > > > > Hi Min, > > > > > > Thank you for this patch. > > > > > > Please find my response inline marked [SAMI]. > > > > > > Regards, > > > > > > Sami Mujawar > > > > > > > > > On 02/03/2022 12:28 AM, Min Xu wrote: > > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 > > > > > > > > TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass > the > > > > event-log information. The event log created by the TD owner > contains > > > > the hashes to reconstruct the MRTD and RTMR registers. > > > > > > > > Please refer to Sec 4.3.3 in blow link: > > > > > > https://www.intel.com/content/dam/develop/external/us/en/documents/ > > > > intel-tdx-guest-hypervisor-communication-interface-1.0-344426- > > 002.pdf > > > > > > > > Cc: Michael D Kinney > > > > Cc: Liming Gao > > > > Cc: Zhiguang Liu > > > > Cc: Jiewen Yao > > > > Cc: Jian J Wang > > > > Cc: Ken Lu > > > > Cc: Sami Mujawar > > > > Cc: Gerd Hoffmann > > > > Signed-off-by: Min Xu > > > > --- > > > > MdePkg/Include/Protocol/CcMeasurement.h | 20 > > > > > > 1 file changed, 20 insertions(+) > > > > > > > > diff --git a/MdePkg/Include/Protocol/CcMeasurement.h > > > b/MdePkg/Include/Protocol/CcMeasurement.h > > > > index 83eaafaf10a6..86de226c1d82 100644 > > > > --- a/MdePkg/Include/Protocol/CcMeasurement.h > > > > +++ b/MdePkg/Include/Protocol/CcMeasurement.h > > > > @@ -307,4 +307,24 @@ extern EFI_GUID > gEfiCcFinalEventsTableGuid; > > > > > > > > extern EFI_GUID gCcEventEntryHobGuid; > > > > > > > > +// > > > > +// Define the CC Measure EventLog ACPI Table > > > > +// > > > > +#pragma pack(1) > > > > + > > > > +typedef struct { > > > > + EFI_ACPI_DESCRIPTION_HEADERHeader; > > > > + UINT32
Re: [edk2-devel] [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table
Thanks to remind me. I uploaded version 2 in the same mantis. Thank you Yao Jiewen > -Original Message- > From: Sami Mujawar > Sent: Thursday, March 17, 2022 9:10 PM > To: Yao, Jiewen ; Xu, Min M ; > devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Wang, > Jian J ; Lu, Ken ; Gerd Hoffmann > ; nd ; Samer El-Haj-Mahmoud haj-mahm...@arm.com>; Thanu Rangarajan > Subject: Re: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table > > Hi Jiewen, > > I was informed there is an ASWG ECR > https://mantis.uefi.org/mantis/view.php?id=2177 for TDEL. I can see the > content has been approved for ACPI 6.5. > > Do you plan to update this ECR to reflect the changes for CCEL or this would > be > a separate request? > > Regards, > > Sami Mujawar > > On 10/03/2022, 10:27, "Sami Mujawar" wrote: > > Hi Jiewen, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 10/03/2022, 05:49, "Yao, Jiewen" wrote: > > HI Sami > I think it is OK to update signature to `CCEL`. That means it will be > applicable > for other CC, right? > [SAMI] Yes, the same table can then be used by other CC. > > Then, I recommend we add CcType there. > > typedef struct { > EFI_ACPI_DESCRIPTION_HEADERHeader; > EFI_CC_TYPE CcType; <== new field. > UINT16 Rsvd; > UINT64 Laml; > UINT64 Lasa; > } EFI_CC_EVENTLOG_ACPI_TABLE; > > Do you agree? > [SAMI] Agree, the above suggestion looks good to me. > > Thank you > Yao Jiewen > > > -Original Message- > > From: Sami Mujawar > > Sent: Wednesday, March 9, 2022 11:35 PM > > To: Xu, Min M ; devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming > > ; Liu, Zhiguang ; > Yao, > > Jiewen ; Wang, Jian J ; > Lu, Ken > > ; Gerd Hoffmann ; nd > ; > > Samer El-Haj-Mahmoud ; > > thanu.rangara...@arm.com > > Subject: Re: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI > Table > > > > Hi Min, > > > > Thank you for this patch. > > > > Please find my response inline marked [SAMI]. > > > > Regards, > > > > Sami Mujawar > > > > > > On 02/03/2022 12:28 AM, Min Xu wrote: > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 > > > > > > TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the > > > event-log information. The event log created by the TD owner > contains > > > the hashes to reconstruct the MRTD and RTMR registers. > > > > > > Please refer to Sec 4.3.3 in blow link: > > > > https://www.intel.com/content/dam/develop/external/us/en/documents/ > > > intel-tdx-guest-hypervisor-communication-interface-1.0-344426- > 002.pdf > > > > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Cc: Zhiguang Liu > > > Cc: Jiewen Yao > > > Cc: Jian J Wang > > > Cc: Ken Lu > > > Cc: Sami Mujawar > > > Cc: Gerd Hoffmann > > > Signed-off-by: Min Xu > > > --- > > > MdePkg/Include/Protocol/CcMeasurement.h | 20 > > > > 1 file changed, 20 insertions(+) > > > > > > diff --git a/MdePkg/Include/Protocol/CcMeasurement.h > > b/MdePkg/Include/Protocol/CcMeasurement.h > > > index 83eaafaf10a6..86de226c1d82 100644 > > > --- a/MdePkg/Include/Protocol/CcMeasurement.h > > > +++ b/MdePkg/Include/Protocol/CcMeasurement.h > > > @@ -307,4 +307,24 @@ extern EFI_GUID gEfiCcFinalEventsTableGuid; > > > > > > extern EFI_GUID gCcEventEntryHobGuid; > > > > > > +// > > > +// Define the CC Measure EventLog ACPI Table > > > +// > > > +#pragma pack(1) > > > + > > > +typedef struct { > > > + EFI_ACPI_DESCRIPTION_HEADERHeader; > > > + UINT32 Rsvd; > > > + UINT64 Laml; > > > + UINT64 Lasa; > > > +} EFI_CC_EVENTLOG_ACPI_TABLE; > > > + > > > +#pragma pack() > > > + > > > +// > > > +// Define the signature and revision of CC Measurement EventLog > ACPI > Table > > for Td guest > > > +// > > > +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_SIGNATURE > SIGNATURE_32('T', > > 'D', 'E', 'L') > > > +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_REVISION 1 > > [SAMI] I can see that the above macros have the _TD_ infix. Is the > > intention here that each architecture shall define its own > signature
Re: [edk2-devel] [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table
Hi Jiewen, I was informed there is an ASWG ECR https://mantis.uefi.org/mantis/view.php?id=2177 for TDEL. I can see the content has been approved for ACPI 6.5. Do you plan to update this ECR to reflect the changes for CCEL or this would be a separate request? Regards, Sami Mujawar On 10/03/2022, 10:27, "Sami Mujawar" wrote: Hi Jiewen, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 10/03/2022, 05:49, "Yao, Jiewen" wrote: HI Sami I think it is OK to update signature to `CCEL`. That means it will be applicable for other CC, right? [SAMI] Yes, the same table can then be used by other CC. Then, I recommend we add CcType there. typedef struct { EFI_ACPI_DESCRIPTION_HEADERHeader; EFI_CC_TYPE CcType; <== new field. UINT16 Rsvd; UINT64 Laml; UINT64 Lasa; } EFI_CC_EVENTLOG_ACPI_TABLE; Do you agree? [SAMI] Agree, the above suggestion looks good to me. Thank you Yao Jiewen > -Original Message- > From: Sami Mujawar > Sent: Wednesday, March 9, 2022 11:35 PM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Yao, > Jiewen ; Wang, Jian J ; Lu, Ken > ; Gerd Hoffmann ; nd ; > Samer El-Haj-Mahmoud ; > thanu.rangara...@arm.com > Subject: Re: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table > > Hi Min, > > Thank you for this patch. > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > > On 02/03/2022 12:28 AM, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 > > > > TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the > > event-log information. The event log created by the TD owner contains > > the hashes to reconstruct the MRTD and RTMR registers. > > > > Please refer to Sec 4.3.3 in blow link: > > https://www.intel.com/content/dam/develop/external/us/en/documents/ > > intel-tdx-guest-hypervisor-communication-interface-1.0-344426-002.pdf > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Ken Lu > > Cc: Sami Mujawar > > Cc: Gerd Hoffmann > > Signed-off-by: Min Xu > > --- > > MdePkg/Include/Protocol/CcMeasurement.h | 20 > > 1 file changed, 20 insertions(+) > > > > diff --git a/MdePkg/Include/Protocol/CcMeasurement.h > b/MdePkg/Include/Protocol/CcMeasurement.h > > index 83eaafaf10a6..86de226c1d82 100644 > > --- a/MdePkg/Include/Protocol/CcMeasurement.h > > +++ b/MdePkg/Include/Protocol/CcMeasurement.h > > @@ -307,4 +307,24 @@ extern EFI_GUID gEfiCcFinalEventsTableGuid; > > > > extern EFI_GUID gCcEventEntryHobGuid; > > > > +// > > +// Define the CC Measure EventLog ACPI Table > > +// > > +#pragma pack(1) > > + > > +typedef struct { > > + EFI_ACPI_DESCRIPTION_HEADERHeader; > > + UINT32 Rsvd; > > + UINT64 Laml; > > + UINT64 Lasa; > > +} EFI_CC_EVENTLOG_ACPI_TABLE; > > + > > +#pragma pack() > > + > > +// > > +// Define the signature and revision of CC Measurement EventLog ACPI Table > for Td guest > > +// > > +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_SIGNATURE SIGNATURE_32('T', > 'D', 'E', 'L') > > +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_REVISION 1 > [SAMI] I can see that the above macros have the _TD_ infix. Is the > intention here that each architecture shall define its own signature and > revision? > Would it be possible to make the signature generic across architectures, > e.g. "SIGNATURE_32('C', 'C', 'E', 'L')" ? > [/SAMI] > > + > > #endif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87662): https://edk2.groups.io/g/devel/message/87662 Mute This Topic: https://groups.io/mt/89491522/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table
Hi Jiewen, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 10/03/2022, 05:49, "Yao, Jiewen" wrote: HI Sami I think it is OK to update signature to `CCEL`. That means it will be applicable for other CC, right? [SAMI] Yes, the same table can then be used by other CC. Then, I recommend we add CcType there. typedef struct { EFI_ACPI_DESCRIPTION_HEADERHeader; EFI_CC_TYPE CcType; <== new field. UINT16 Rsvd; UINT64 Laml; UINT64 Lasa; } EFI_CC_EVENTLOG_ACPI_TABLE; Do you agree? [SAMI] Agree, the above suggestion looks good to me. Thank you Yao Jiewen > -Original Message- > From: Sami Mujawar > Sent: Wednesday, March 9, 2022 11:35 PM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Yao, > Jiewen ; Wang, Jian J ; Lu, Ken > ; Gerd Hoffmann ; nd ; > Samer El-Haj-Mahmoud ; > thanu.rangara...@arm.com > Subject: Re: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table > > Hi Min, > > Thank you for this patch. > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > > On 02/03/2022 12:28 AM, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 > > > > TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the > > event-log information. The event log created by the TD owner contains > > the hashes to reconstruct the MRTD and RTMR registers. > > > > Please refer to Sec 4.3.3 in blow link: > > https://www.intel.com/content/dam/develop/external/us/en/documents/ > > intel-tdx-guest-hypervisor-communication-interface-1.0-344426-002.pdf > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Ken Lu > > Cc: Sami Mujawar > > Cc: Gerd Hoffmann > > Signed-off-by: Min Xu > > --- > > MdePkg/Include/Protocol/CcMeasurement.h | 20 > > 1 file changed, 20 insertions(+) > > > > diff --git a/MdePkg/Include/Protocol/CcMeasurement.h > b/MdePkg/Include/Protocol/CcMeasurement.h > > index 83eaafaf10a6..86de226c1d82 100644 > > --- a/MdePkg/Include/Protocol/CcMeasurement.h > > +++ b/MdePkg/Include/Protocol/CcMeasurement.h > > @@ -307,4 +307,24 @@ extern EFI_GUID gEfiCcFinalEventsTableGuid; > > > > extern EFI_GUID gCcEventEntryHobGuid; > > > > +// > > +// Define the CC Measure EventLog ACPI Table > > +// > > +#pragma pack(1) > > + > > +typedef struct { > > + EFI_ACPI_DESCRIPTION_HEADERHeader; > > + UINT32 Rsvd; > > + UINT64 Laml; > > + UINT64 Lasa; > > +} EFI_CC_EVENTLOG_ACPI_TABLE; > > + > > +#pragma pack() > > + > > +// > > +// Define the signature and revision of CC Measurement EventLog ACPI Table > for Td guest > > +// > > +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_SIGNATURE SIGNATURE_32('T', > 'D', 'E', 'L') > > +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_REVISION 1 > [SAMI] I can see that the above macros have the _TD_ infix. Is the > intention here that each architecture shall define its own signature and > revision? > Would it be possible to make the signature generic across architectures, > e.g. "SIGNATURE_32('C', 'C', 'E', 'L')" ? > [/SAMI] > > + > > #endif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87402): https://edk2.groups.io/g/devel/message/87402 Mute This Topic: https://groups.io/mt/89491522/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table
HI Sami I think it is OK to update signature to `CCEL`. That means it will be applicable for other CC, right? Then, I recommend we add CcType there. typedef struct { EFI_ACPI_DESCRIPTION_HEADERHeader; EFI_CC_TYPE CcType; <== new field. UINT16 Rsvd; UINT64 Laml; UINT64 Lasa; } EFI_CC_EVENTLOG_ACPI_TABLE; Do you agree? Thank you Yao Jiewen > -Original Message- > From: Sami Mujawar > Sent: Wednesday, March 9, 2022 11:35 PM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Yao, > Jiewen ; Wang, Jian J ; Lu, Ken > ; Gerd Hoffmann ; nd ; > Samer El-Haj-Mahmoud ; > thanu.rangara...@arm.com > Subject: Re: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table > > Hi Min, > > Thank you for this patch. > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > > On 02/03/2022 12:28 AM, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 > > > > TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the > > event-log information. The event log created by the TD owner contains > > the hashes to reconstruct the MRTD and RTMR registers. > > > > Please refer to Sec 4.3.3 in blow link: > > https://www.intel.com/content/dam/develop/external/us/en/documents/ > > intel-tdx-guest-hypervisor-communication-interface-1.0-344426-002.pdf > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Ken Lu > > Cc: Sami Mujawar > > Cc: Gerd Hoffmann > > Signed-off-by: Min Xu > > --- > > MdePkg/Include/Protocol/CcMeasurement.h | 20 > > 1 file changed, 20 insertions(+) > > > > diff --git a/MdePkg/Include/Protocol/CcMeasurement.h > b/MdePkg/Include/Protocol/CcMeasurement.h > > index 83eaafaf10a6..86de226c1d82 100644 > > --- a/MdePkg/Include/Protocol/CcMeasurement.h > > +++ b/MdePkg/Include/Protocol/CcMeasurement.h > > @@ -307,4 +307,24 @@ extern EFI_GUID gEfiCcFinalEventsTableGuid; > > > > extern EFI_GUID gCcEventEntryHobGuid; > > > > +// > > +// Define the CC Measure EventLog ACPI Table > > +// > > +#pragma pack(1) > > + > > +typedef struct { > > + EFI_ACPI_DESCRIPTION_HEADERHeader; > > + UINT32 Rsvd; > > + UINT64 Laml; > > + UINT64 Lasa; > > +} EFI_CC_EVENTLOG_ACPI_TABLE; > > + > > +#pragma pack() > > + > > +// > > +// Define the signature and revision of CC Measurement EventLog ACPI Table > for Td guest > > +// > > +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_SIGNATURE SIGNATURE_32('T', > 'D', 'E', 'L') > > +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_REVISION 1 > [SAMI] I can see that the above macros have the _TD_ infix. Is the > intention here that each architecture shall define its own signature and > revision? > Would it be possible to make the signature generic across architectures, > e.g. "SIGNATURE_32('C', 'C', 'E', 'L')" ? > [/SAMI] > > + > > #endif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87396): https://edk2.groups.io/g/devel/message/87396 Mute This Topic: https://groups.io/mt/89491522/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table
Hi Min, Thank you for this patch. Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 02/03/2022 12:28 AM, Min Xu wrote: RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the event-log information. The event log created by the TD owner contains the hashes to reconstruct the MRTD and RTMR registers. Please refer to Sec 4.3.3 in blow link: https://www.intel.com/content/dam/develop/external/us/en/documents/ intel-tdx-guest-hypervisor-communication-interface-1.0-344426-002.pdf Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Jiewen Yao Cc: Jian J Wang Cc: Ken Lu Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Min Xu --- MdePkg/Include/Protocol/CcMeasurement.h | 20 1 file changed, 20 insertions(+) diff --git a/MdePkg/Include/Protocol/CcMeasurement.h b/MdePkg/Include/Protocol/CcMeasurement.h index 83eaafaf10a6..86de226c1d82 100644 --- a/MdePkg/Include/Protocol/CcMeasurement.h +++ b/MdePkg/Include/Protocol/CcMeasurement.h @@ -307,4 +307,24 @@ extern EFI_GUID gEfiCcFinalEventsTableGuid; extern EFI_GUID gCcEventEntryHobGuid; +// +// Define the CC Measure EventLog ACPI Table +// +#pragma pack(1) + +typedef struct { + EFI_ACPI_DESCRIPTION_HEADERHeader; + UINT32 Rsvd; + UINT64 Laml; + UINT64 Lasa; +} EFI_CC_EVENTLOG_ACPI_TABLE; + +#pragma pack() + +// +// Define the signature and revision of CC Measurement EventLog ACPI Table for Td guest +// +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_SIGNATURE SIGNATURE_32('T', 'D', 'E', 'L') +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_REVISION 1 [SAMI] I can see that the above macros have the _TD_ infix. Is the intention here that each architecture shall define its own signature and revision? Would it be possible to make the signature generic across architectures, e.g. "SIGNATURE_32('C', 'C', 'E', 'L')" ? [/SAMI] + #endif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87391): https://edk2.groups.io/g/devel/message/87391 Mute This Topic: https://groups.io/mt/89491522/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the event-log information. The event log created by the TD owner contains the hashes to reconstruct the MRTD and RTMR registers. Please refer to Sec 4.3.3 in blow link: https://www.intel.com/content/dam/develop/external/us/en/documents/ intel-tdx-guest-hypervisor-communication-interface-1.0-344426-002.pdf Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Jiewen Yao Cc: Jian J Wang Cc: Ken Lu Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Min Xu --- MdePkg/Include/Protocol/CcMeasurement.h | 20 1 file changed, 20 insertions(+) diff --git a/MdePkg/Include/Protocol/CcMeasurement.h b/MdePkg/Include/Protocol/CcMeasurement.h index 83eaafaf10a6..86de226c1d82 100644 --- a/MdePkg/Include/Protocol/CcMeasurement.h +++ b/MdePkg/Include/Protocol/CcMeasurement.h @@ -307,4 +307,24 @@ extern EFI_GUID gEfiCcFinalEventsTableGuid; extern EFI_GUID gCcEventEntryHobGuid; +// +// Define the CC Measure EventLog ACPI Table +// +#pragma pack(1) + +typedef struct { + EFI_ACPI_DESCRIPTION_HEADERHeader; + UINT32 Rsvd; + UINT64 Laml; + UINT64 Lasa; +} EFI_CC_EVENTLOG_ACPI_TABLE; + +#pragma pack() + +// +// Define the signature and revision of CC Measurement EventLog ACPI Table for Td guest +// +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_SIGNATURE SIGNATURE_32('T', 'D', 'E', 'L') +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_REVISION 1 + #endif -- 2.29.2.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87173): https://edk2.groups.io/g/devel/message/87173 Mute This Topic: https://groups.io/mt/89491522/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-