Re: Build Error: Trigger fired by the same package is already fired???
On Nov 3, 2015 07:30, "Steve Dickson" wrote: > > > > On 11/03/2015 06:59 AM, Michael Schwendt wrote: > > On Tue, 3 Nov 2015 04:32:47 -0500, Steve Dickson wrote: > > > >>> %triggerun -- nfs-utils < 1:1.3.1-4.0 > >>> # reset configuration files and running daemons > >>> if [ $1 -eq 2 ] ; then > >>> /bin/systemctl enable nfs-client.target >/dev/null 2>&1 || : > >>> /bin/systemctl restart nfs-config >/dev/null 2>&1 || : > >>> /bin/systemctl restart nfs-client.target >/dev/null 2>&1 || : > >>> fi > >> So the answer is... I have to remove the above trigger to get > >> the build to work... > >> > >> What policy has changed that we now have to remove triggers > >> got get builds to work??? That is not a good direction... IMHO! > > > > AFAIK, overlapping triggers have never worked before, because RPM would > > only fire a single trigger. It's g > What I don't understand is there the overlap? I have the following triggers: > > %triggerun -- nfs-utils < 1:1.2.4-2 > %triggerun -- nfs-utils < 1:1.3.1-4.0 > > where is the overlap? > Trigger two is true over any release less than 1.2.4 so it over laps. To not overlap you need a > range > steved. > -- > devel mailing list > devel@lists.fedoraproject.org > https://admin.fedoraproject.org/mailman/listinfo/devel > Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: Build Error: Trigger fired by the same package is already fired???
On 11/03/2015 07:29 AM, Steve Dickson wrote: On 11/03/2015 06:59 AM, Michael Schwendt wrote: On Tue, 3 Nov 2015 04:32:47 -0500, Steve Dickson wrote: %triggerun -- nfs-utils < 1:1.3.1-4.0 # reset configuration files and running daemons if [ $1 -eq 2 ] ; then /bin/systemctl enable nfs-client.target >/dev/null 2>&1 || : /bin/systemctl restart nfs-config >/dev/null 2>&1 || : /bin/systemctl restart nfs-client.target >/dev/null 2>&1 || : fi So the answer is... I have to remove the above trigger to get the build to work... What policy has changed that we now have to remove triggers got get builds to work??? That is not a good direction... IMHO! AFAIK, overlapping triggers have never worked before, because RPM would only fire a single trigger. It's good that triggers with overlapping version ranges cause a build failure instead. What I don't understand is there the overlap? I have the following triggers: %triggerun -- nfs-utils < 1:1.2.4-2 %triggerun -- nfs-utils < 1:1.3.1-4.0 where is the overlap? steved. Um, overlaps for anything < 1:1.2.4-2 (both match). -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA DivisionFAX: 303-415-9702 3380 Mitchell Lane or...@cora.nwra.com Boulder, CO 80301 http://www.cora.nwra.com -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: Build Error: Trigger fired by the same package is already fired???
On 11/03/2015 06:59 AM, Michael Schwendt wrote: > On Tue, 3 Nov 2015 04:32:47 -0500, Steve Dickson wrote: > >>> %triggerun -- nfs-utils < 1:1.3.1-4.0 >>> # reset configuration files and running daemons >>> if [ $1 -eq 2 ] ; then >>> /bin/systemctl enable nfs-client.target >/dev/null 2>&1 || : >>> /bin/systemctl restart nfs-config >/dev/null 2>&1 || : >>> /bin/systemctl restart nfs-client.target >/dev/null 2>&1 || : >>> fi >> So the answer is... I have to remove the above trigger to get >> the build to work... >> >> What policy has changed that we now have to remove triggers >> got get builds to work??? That is not a good direction... IMHO! > > AFAIK, overlapping triggers have never worked before, because RPM would > only fire a single trigger. It's good that triggers with overlapping version > ranges cause a build failure instead. > What I don't understand is there the overlap? I have the following triggers: %triggerun -- nfs-utils < 1:1.2.4-2 %triggerun -- nfs-utils < 1:1.3.1-4.0 where is the overlap? steved. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: Build Error: Trigger fired by the same package is already fired???
Did some bugzilla searching and then also found this: RPM 4.13.0-alpha released http://lists.rpm.org/pipermail/rpm-maint/2015-August/003924.html | The problem is when you upgrade distro N to N+2 both triggers should | be run but only one was run, which was confusing so we disallowed | triggers fired by the same package with overlapping version intervals. | And initscripts <= 4.72 and initscripts <= 8.38-2 overlaps. | Have a look at bugs #585384, #702378 that initiate this change. | | Lubos -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: Build Error: Trigger fired by the same package is already fired???
On Tue, 3 Nov 2015 04:32:47 -0500, Steve Dickson wrote: > > %triggerun -- nfs-utils < 1:1.3.1-4.0 > > # reset configuration files and running daemons > > if [ $1 -eq 2 ] ; then > > /bin/systemctl enable nfs-client.target >/dev/null 2>&1 || : > > /bin/systemctl restart nfs-config >/dev/null 2>&1 || : > > /bin/systemctl restart nfs-client.target >/dev/null 2>&1 || : > > fi > So the answer is... I have to remove the above trigger to get > the build to work... > > What policy has changed that we now have to remove triggers > got get builds to work??? That is not a good direction... IMHO! AFAIK, overlapping triggers have never worked before, because RPM would only fire a single trigger. It's good that triggers with overlapping version ranges cause a build failure instead. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: Build Error: Trigger fired by the same package is already fired???
On 11/02/2015 03:06 PM, Steve Dickson wrote: > Hello, > > The following build > http://koji.fedoraproject.org/koji/taskinfo?taskID=11675563 > > is failing due to >error: line 256: Trigger fired by the same package is already defined in > spec file: %triggerun -- nfs-utils < 1:1.3.1-4.0 > > Here all the trigger (that have been around forever): > > triggerun -- nfs-utils < 1:1.2.4-2 > /bin/systemctl enable nfs-lock.service >/dev/null 2>&1 || : > if /sbin/chkconfig --level 3 nfs ; then > /bin/systemctl enable nfs-server.service >/dev/null 2>&1 || : > fi > > %triggerin -- nfs-utils < 1:1.3.0-0.2 > /bin/systemctl restart nfs-config >/dev/null 2>&1 || : > > %triggerin -- nfs-utils < 1:1.3.0-7.1 > /bin/systemctl stop rpc-svcgssd >/dev/null 2>&1 || : > > %triggerun -- nfs-utils < 1:1.3.1-4.0 > # reset configuration files and running daemons > if [ $1 -eq 2 ] ; then > /bin/systemctl enable nfs-client.target >/dev/null 2>&1 || : > /bin/systemctl restart nfs-config >/dev/null 2>&1 || : > /bin/systemctl restart nfs-client.target >/dev/null 2>&1 || : > fi So the answer is... I have to remove the above trigger to get the build to work... What policy has changed that we now have to remove triggers got get builds to work??? That is not a good direction... IMHO! steved -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct