Re: [FFmpeg-devel] [PATCH 3/3] avcodec/qpeg: mark the init function as thread-safe
On 4/20/2020 1:28 PM, Anton Khirnov wrote: > Quoting James Almer (2020-04-20 15:39:19) >> On 4/20/2020 10:30 AM, Anton Khirnov wrote: >>> Quoting James Almer (2020-04-17 05:10:08) Signed-off-by: James Almer --- libavcodec/qpeg.c | 1 + 1 file changed, 1 insertion(+) >>> >>> Looks good. >>> Could have INIT_CLEANUP too, it seems. >> >> No, since the only way for init() to fail now is if allocating a->ref >> fails, and if that happens then there's nothing to free. > > Which means it's trivially INIT_CLEANUP. > I believe the intent was to gradually mark all the codecs as > INIT_CLEANUP and then drop the flag so they all behave the same. Never interpreted it that way myself, since in decoders where it's not needed it results in a call to close() for no gain, but ok, added and pushed. Thanks. > > Anyway, that's just a nit, feel free to ignore. > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 3/3] avcodec/qpeg: mark the init function as thread-safe
Quoting James Almer (2020-04-20 15:39:19) > On 4/20/2020 10:30 AM, Anton Khirnov wrote: > > Quoting James Almer (2020-04-17 05:10:08) > >> Signed-off-by: James Almer > >> --- > >> libavcodec/qpeg.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > Looks good. > > Could have INIT_CLEANUP too, it seems. > > No, since the only way for init() to fail now is if allocating a->ref > fails, and if that happens then there's nothing to free. Which means it's trivially INIT_CLEANUP. I believe the intent was to gradually mark all the codecs as INIT_CLEANUP and then drop the flag so they all behave the same. Anyway, that's just a nit, feel free to ignore. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 3/3] avcodec/qpeg: mark the init function as thread-safe
On 4/20/2020 10:30 AM, Anton Khirnov wrote: > Quoting James Almer (2020-04-17 05:10:08) >> Signed-off-by: James Almer >> --- >> libavcodec/qpeg.c | 1 + >> 1 file changed, 1 insertion(+) > > Looks good. > Could have INIT_CLEANUP too, it seems. No, since the only way for init() to fail now is if allocating a->ref fails, and if that happens then there's nothing to free. Will apply, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 3/3] avcodec/qpeg: mark the init function as thread-safe
Quoting James Almer (2020-04-17 05:10:08) > Signed-off-by: James Almer > --- > libavcodec/qpeg.c | 1 + > 1 file changed, 1 insertion(+) Looks good. Could have INIT_CLEANUP too, it seems. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH 3/3] avcodec/qpeg: mark the init function as thread-safe
Signed-off-by: James Almer
---
libavcodec/qpeg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/qpeg.c b/libavcodec/qpeg.c
index 22afd9fa81..cc3bfda4aa 100644
--- a/libavcodec/qpeg.c
+++ b/libavcodec/qpeg.c
@@ -366,4 +366,5 @@ AVCodec ff_qpeg_decoder = {
.decode = decode_frame,
.flush = decode_flush,
.capabilities = AV_CODEC_CAP_DR1,
+.caps_internal = FF_CODEC_CAP_INIT_THREADSAFE,
};
--
2.26.0
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
