Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced
Jason Helfman ha scritto: I am working on the following pr, and would like to get others approval to the following patch: http://people.freebsd.org/~jgh/files/pre-patch.txt This patch is fixing several use cases of SRC_BASE before it is defined. I don't agree for the quantis-kmod patch. I think simply removing SRC_BASE?= line is the correct fix. -- Alex Dupre ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced
Unfortunately certain things need to be defined before bsd.port.pre.mk is included. So, pointy hat to me for giving bad advice. These show up immediately as bad distinfo problems: http://pointyhat-west.isc.freebsd.org/errorlogs/amd64-errorlogs/e.10-exp.20120522050031.pointyhat-west/lsof-4.86,7.log http://pointyhat-west.isc.freebsd.org/errorlogs/amd64-errorlogs/e.10-exp.20120522050031.pointyhat-west/cairo-reference-1.12.2,1.log I have already fixed lsof, but I don't understand cairo-reference. mcl ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced
On 05/21/12 15:04, Jason Helfman so wittily quipped: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I am working on the following pr, and would like to get others approval to the following patch: http://people.freebsd.org/~jgh/files/pre-patch.txt http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165994 This patch is fixing several use cases of SRC_BASE before it is defined. (re: comms/uarduno port) Now that I understand what the patch is for I totally agree, it should be applied to comms/uarduno as well. I believe I copied my port from one of the others that had the 'bad logic' in it, so thanks for catching it. Do I need to make the change or are you going to do it on your end? ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced
On Tue, May 22, 2012 at 07:04:29PM -0700, Bob Frazier thus spake: On 05/21/12 15:04, Jason Helfman so wittily quipped: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I am working on the following pr, and would like to get others approval to the following patch: http://people.freebsd.org/~jgh/files/pre-patch.txt http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165994 This patch is fixing several use cases of SRC_BASE before it is defined. (re: comms/uarduno port) Now that I understand what the patch is for I totally agree, it should be applied to comms/uarduno as well. I believe I copied my port from one of the others that had the 'bad logic' in it, so thanks for catching it. Do I need to make the change or are you going to do it on your end? Thanks so much! Committed. Still working through the list :) -jgh -- Jason Helfman FreeBSD Committer | http://people.freebsd.org/~jgh | The Power To Serve ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
[RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I am working on the following pr, and would like to get others approval to the following patch: http://people.freebsd.org/~jgh/files/pre-patch.txt http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165994 This patch is fixing several use cases of SRC_BASE before it is defined. Thanks! jgh - -- Jason Helfman FreeBSD Committer | http://people.freebsd.org/~jgh | The Power To Serve -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBAgAGBQJPurwBAAoJECBZmmNBUNPczjkIAKT44sL4HPvk93/AgB9LDhFc CE3PMQu9GpaW6+zPGivcm18REumapwyFeiuBAfE32CWBhPBB8h5WBNiqMDnIdSm0 i811jkCXgI00G5a8INi7xoOiTQD4w79m099C1DchfBnQNG6WZTYLQnxJQk0v1OuR 1DRgY/pDdvVJuuFXIcM6E1iiN6FLXCBvEfxznOkw+IbbZbofIiNDmKFFLfaLGKuF czEA+kg0rnJAyTQCuvh68T///ZoGOhdum2vZN3AEH3qJJSUJ+/hg04mOk+06AVjP o7MYI0B4Cyf+R0rUzxFHcTyL/Ui8Oryw+oVb19MLeV1abNwRQBieVbhDnWTDQs8= =lEOx -END PGP SIGNATURE- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced
Thanks for doing this work. A quick review looks to me to be TRT. I would suggest some minor fixes but only for style: for me, it makes it a bit clearer what's going on if the pre.mk include isn't among the various WITH_* definitions, e.g. net/skystar2. Or maybe just having a blank line before the inclusion would help. Also, for sysutils/fusefs-kmod, I would do the following: - move the MAKE_ENV= definition past the bsd.ports.pre.mk inclusion - throw the SRC_BASE?= line away. mcl ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
