Re: [Freeciv-Dev] (PR#40520) civserver hangs and more
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40520 On Tue, 7 Oct 2008 Christian Knoke wrote: SVN 07 OCT 2008 2.1.99 GTK [...] Examining the subsequent savegame, as well as several predecessors, in some of them the GUI gives some alerts: unknown ascii from num: '?' 63 detected fatal error in savegame.c line 303 2-0150.sav.gz. Trireme at [9,10]. Did you use goto on it (before) or smth else? This part of problem is the same as #40517. -- Thanks, evyscr ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40517) Can't load savegames in 2.2
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40517
On Tue, 7 Oct 2008 Joan Creus wrote:
2008/10/7 Egor Vyscrebentsov evyscr/gmail.com
base_list (and therefore base_buf) for archers at [39,40] (line 1278)
is ��x�ſ-�\017\b\214�ſ �\b��. Most of these symbols are illegal.
activity_list for same unit is . Wonder if this was one more
out-of-pointer'ing?
orders_list and dir_list also look strange.
orders_list and dir_list are ok.
It looks like the problem my be in the saving rather than in the loading?
Yes. The problem is in player_save_units() and player_load_units().
player_save_units() set target base char to '?', and this char isn't
changed in several cases. player_load_units() assumes that loaded
char is one of [0-9a-f].
Quickest (not the best) fix is
- } else if (base_buf) {
+ } else if (base_buf base_buf[j] != '?') {
at server/savegame.c:1862
This is the first part of problem. The second part is that in
savegame file base_list is longer than activity_list. Now I have
no idea why.
--
Thanks, evyscr
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40517) Can't load savegames in 2.2
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40517
On Thu, 9 Oct 2008 Egor Vyscrebentsov wrote:
On Tue, 7 Oct 2008 Joan Creus wrote:
2008/10/7 Egor Vyscrebentsov evyscr/gmail.com
base_list (and therefore base_buf) for archers at [39,40] (line 1278)
is ��x�ſ-�\017\b\214�ſ �\b��. Most of these symbols are illegal.
activity_list for same unit is . Wonder if this was one more
out-of-pointer'ing?
It looks like the problem my be in the saving rather than in the loading?
Yes. The problem is in player_save_units() and player_load_units().
player_save_units() set target base char to '?', and this char isn't
changed in several cases. player_load_units() assumes that loaded
char is one of [0-9a-f].
Quickest (not the best) fix is
- } else if (base_buf) {
+ } else if (base_buf base_buf[j] != '?') {
at server/savegame.c:1862
After some thoughts I've decided that this fix is proper.
This is the first part of problem. The second part is that in
savegame file base_list is longer than activity_list.
- orders_buf[len] = dir_buf[len] = act_buf[len] = '\0';
+ orders_buf[len] = dir_buf[len] = act_buf[len] = base_buf[len] = '\0';
at server/savegame.c:3473
--
Thanks, evyscr
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40520) civserver hangs and more
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40520 Du schriebst am 09. Oct um 01:49 Uhr: On Tue, 7 Oct 2008 Christian Knoke wrote: SVN 07 OCT 2008 2.1.99 GTK [...] Examining the subsequent savegame, as well as several predecessors, in some of them the GUI gives some alerts: unknown ascii from num: '?' 63 detected fatal error in savegame.c line 303 2-0150.sav.gz. Trireme at [9,10]. Did you use goto on it (before) or smth else? Triremes were somewhat strange in that test game. It wasn't possible to leave the coast (intended?), *and* it wasn't possible to move along an unknown coast at all, at times. The only possible move was backwards, then. So I tried goto, and sometimes moves became possible which weren't with cursor keys. Some gotos chose a way through the unknown, and these ended prematurely, then. This part of problem is the same as #40517. What is funny, some games load, others do not. So I was able to continue my game, and next day the actual (manual saved) save game bugged, but the (automatic saved) predecessor worked ok. Greetings, Christian -- Christian Knoke* * *http://cknoke.de * * * * * * * * * Ceterum censeo Microsoft esse dividendum. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40517) Can't load savegames in 2.2
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40517
I have applied the patch, and started a new game. It didn't make any
difference, and I still couldn't load any of the saved files.
Then I have started ./civ with the --log option, and the problem was in
fact:
3: Could not find readable file
/home/joanc/.freeciv/saves/anemdeconya.sav..sav in data path.
3: Could not find readable file
/home/joanc/.freeciv/saves/anemdeconya.sav..sav.gz in data path.
So most of the problem is really the way the filename to open gets
generated. Your patch may still fix the problem that generated all the
popups, I suppose.
Thanks,
Joan
2008/10/9 Egor Vyscrebentsov [EMAIL PROTECTED]
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40517
On Thu, 9 Oct 2008 Egor Vyscrebentsov wrote:
On Thu, 9 Oct 2008 Egor Vyscrebentsov wrote:
Quickest (not the best) fix is
- } else if (base_buf) {
+ } else if (base_buf base_buf[j] != '?') {
at server/savegame.c:1862
After some thoughts I've decided that this fix is proper.
And after some more thoughts I've decided opposite...
Patch with more or less accurate workaround is attached.
There should be some action after each of two added LOG_ERRORs.
One variant is to abort civserver. Opinions?
--
Thanks, evyscr
I have applied the patch, and started a new game. It didnt make any difference, and I still couldnt load any of the saved files.Then I have started ./civ with the --log option, and the problem was in fact:
3: Could not find readable file /home/joanc/.freeciv/saves/anemdeconya.sav..sav in data path.3: Could not find readable file /home/joanc/.freeciv/saves/anemdeconya.sav..sav.gz in data path.
So most of the problem is really the way the filename to open gets generated. Your patch may still fix the problem that generated all the popups, I suppose.Thanks,Joan
2008/10/9 Egor Vyscrebentsov [EMAIL PROTECTED]
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40517
On Thu, 9 Oct 2008 Egor Vyscrebentsov wrote:
On Thu, 9 Oct 2008 Egor Vyscrebentsov wrote:
Quickest (not the best) fix is
- } else if (base_buf) {
+ } else if (base_buf base_buf[j] != ?) {
at server/savegame.c:1862
After some thoughts Ive decided that this fix is proper.
And after some more thoughts Ive decided opposite...
Patch with more or less accurate workaround is attached.
There should be some action after each of two added LOG_ERRORs.
One variant is to abort civserver. Opinions?
--
Thanks, evyscr
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40517) Can't load savegames in 2.2
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40517 [EMAIL PROTECTED] - Do 09. Okt 2008, 22:54:30]: I have applied the patch, and started a new game. It didn't make any difference, and I still couldn't load any of the saved files. Then I have started ./civ with the --log option, and the problem was in fact: 3: Could not find readable file /home/joanc/.freeciv/saves/anemdeconya.sav..sav in data path. 3: Could not find readable file /home/joanc/.freeciv/saves/anemdeconya.sav..sav.gz in data path. So most of the problem is really the way the filename to open gets generated. This looks like PR#40515. The server command is /load /home/joanc/.freeciv/saves/anemdeconya.sav.gz that's 52 characters (including \0), but only 50 characters (including \0) are sent to the server: /load /home/joanc/.freeciv/saves/anemdeconya.sav. and then the server tries different file endings to find a matching file, which fails. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40522) 2.1.6 gtk client on windows XP sp 2
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40522 When I try to load 2.1.6, it will work, but windows will leave imprints on the screen (e.g. city popup dialogue will obscure the view window). And if I minimize, the client will resize and menus will overlap when I bring it back up. 2.1.5 works just fine. _ Get more out of the Web. Learn 10 hidden secrets of Windows Live. http://windowslive.com/connect/post/jamiethomson.spaces.live.com-Blog-cns!550F681DAD532637!5295.entry?ocid=TXT_TAGLM_WL_domore_092008 When I try to load 2.1.6, it will work, but windows will leave imprints on the screen (e.g. city popup dialogue will obscure the view window). And if I minimize, the client will resize and menus will overlap when I bring it back up.2.1.5 works just fine.Get more out of the Web. Learn 10 hidden secrets of Windows Live. Learn Now ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
