Re: [PATCH][AArch64] Vector shift by 64 fix

2014-01-23 Thread Marcus Shawcroft
On 6 January 2014 11:52, Alex Velenko alex.vele...@arm.com wrote:
 Hi,

 This patch fixes vector shift by 64 behavior to meet reference
 manual expectations. Testcase included to check that expectations
 are now met. No regressions found.

 Is patch OK?

OK
/Marcus


Re: [PATCH][AArch64] Vector shift by 64 fix

2014-01-23 Thread Alex Velenko

Hi,
Could someone, please, commit this patch, as I do not have permissions 
to do so.

Kind regards,
Alex

On 23/01/14 12:04, Marcus Shawcroft wrote:

On 6 January 2014 11:52, Alex Velenko alex.vele...@arm.com wrote:

Hi,

This patch fixes vector shift by 64 behavior to meet reference
manual expectations. Testcase included to check that expectations
are now met. No regressions found.

Is patch OK?


OK
/Marcus





Re: [PATCH][AArch64] Vector shift by 64 fix

2014-01-23 Thread James Greenhalgh
On Thu, Jan 23, 2014 at 03:57:33PM +, Alex Velenko wrote:
 Hi,
 Could someone, please, commit this patch, as I do not have permissions 
 to do so.

Please don't top-post on this list.

 On 23/01/14 12:04, Marcus Shawcroft wrote:
  On 6 January 2014 11:52, Alex Velenko alex.vele...@arm.com wrote:
  Hi,
 
  This patch fixes vector shift by 64 behavior to meet reference
  manual expectations. Testcase included to check that expectations
  are now met. No regressions found.
 
  Is patch OK?
 
  OK
  /Marcus

I've committed this on Alex' behalf as revision 206978.

Thanks,
James



Re: [PATCH][AArch64] Vector shift by 64 fix

2014-01-22 Thread Alex Velenko

On 06/01/14 11:52, Alex Velenko wrote:

Hi,

This patch fixes vector shift by 64 behavior to meet reference
manual expectations. Testcase included to check that expectations
are now met. No regressions found.

Is patch OK?

Thanks,
Alex

2014-01-06  Alex Velenko  alex.vele...@arm.com

gcc/

 * config/aarch64/aarch64-simd-builtins.def (ashr): DI mode removed.
 (ashr_simd): New builtin handling DI mode.
 * config/aarch64/aarch64-simd.md (aarch64_ashr_simddi): New pattern.
 (aarch64_sshr_simddi): New match pattern.
 * config/aarch64/arm_neon.h (vshr_n_s32): Builtin call modified.
 (vshrd_n_s64): Likewise.
 * config/aarch64/predicates.md (aarch64_shift_imm64_di): New
predicate.

gcc/testsuite/

 * gcc.target/aarch64/sshr64_1.c: New testcase.


Ping!

Hi,
Can someone, please, review the patch.
Kind regards,
Alex