[Geoserver-devel] [JIRA] (GEOS-9967) Add Module Status implementation for CSW Extension
Brad Hards ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A32a7094c-2716-498f-8290-e6e7cdd9ca74 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMWQyYTAyNTY2Y2JmNDFjMmJkYTVlYzM0NmU3NTE0NGEiLCJwIjoiaiJ9 ) / Improvement ( https://osgeo-org.atlassian.net/browse/GEOS-9967?atlOrigin=eyJpIjoiMWQyYTAyNTY2Y2JmNDFjMmJkYTVlYzM0NmU3NTE0NGEiLCJwIjoiaiJ9 ) GEOS-9967 ( https://osgeo-org.atlassian.net/browse/GEOS-9967?atlOrigin=eyJpIjoiMWQyYTAyNTY2Y2JmNDFjMmJkYTVlYzM0NmU3NTE0NGEiLCJwIjoiaiJ9 ) Add Module Status implementation for CSW Extension ( https://osgeo-org.atlassian.net/browse/GEOS-9967?atlOrigin=eyJpIjoiMWQyYTAyNTY2Y2JmNDFjMmJkYTVlYzM0NmU3NTE0NGEiLCJwIjoiaiJ9 ) Issue Type: Improvement Affects Versions: 2.20-RC Assignee: Brad Hards ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A32a7094c-2716-498f-8290-e6e7cdd9ca74 ) Components: CSW Created: 10/Mar/21 7:37 AM Priority: Medium Reporter: Brad Hards ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A32a7094c-2716-498f-8290-e6e7cdd9ca74 ) ( https://osgeo-org.atlassian.net/browse/GEOS-9967#add-comment?atlOrigin=eyJpIjoiMWQyYTAyNTY2Y2JmNDFjMmJkYTVlYzM0NmU3NTE0NGEiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-9967#add-comment?atlOrigin=eyJpIjoiMWQyYTAyNTY2Y2JmNDFjMmJkYTVlYzM0NmU3NTE0NGEiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495=EmailNotificationLink=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100154- sha1:7ef1d1d )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-9966) CSS and AppSchema release modules are missing LGPL licese
Brad Hards ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A32a7094c-2716-498f-8290-e6e7cdd9ca74 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNDAyMWVjYjBiY2VkNDI2MjljNGU4YmRhMTFmMDUzNDIiLCJwIjoiaiJ9 ) / Bug ( https://osgeo-org.atlassian.net/browse/GEOS-9966?atlOrigin=eyJpIjoiNDAyMWVjYjBiY2VkNDI2MjljNGU4YmRhMTFmMDUzNDIiLCJwIjoiaiJ9 ) GEOS-9966 ( https://osgeo-org.atlassian.net/browse/GEOS-9966?atlOrigin=eyJpIjoiNDAyMWVjYjBiY2VkNDI2MjljNGU4YmRhMTFmMDUzNDIiLCJwIjoiaiJ9 ) CSS and AppSchema release modules are missing LGPL licese ( https://osgeo-org.atlassian.net/browse/GEOS-9966?atlOrigin=eyJpIjoiNDAyMWVjYjBiY2VkNDI2MjljNGU4YmRhMTFmMDUzNDIiLCJwIjoiaiJ9 ) Issue Type: Bug Affects Versions: 2.19-RC Assignee: Brad Hards ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A32a7094c-2716-498f-8290-e6e7cdd9ca74 ) Components: release Created: 10/Mar/21 5:19 AM Priority: Medium Reporter: Brad Hards ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A32a7094c-2716-498f-8290-e6e7cdd9ca74 ) Those two modules have release configurations that `LGPL.txt`. However we don't have that file any more. Its now LGPL.md. As such the release zip files don't include a LGPL license file. ( https://osgeo-org.atlassian.net/browse/GEOS-9966#add-comment?atlOrigin=eyJpIjoiNDAyMWVjYjBiY2VkNDI2MjljNGU4YmRhMTFmMDUzNDIiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-9966#add-comment?atlOrigin=eyJpIjoiNDAyMWVjYjBiY2VkNDI2MjljNGU4YmRhMTFmMDUzNDIiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495=EmailNotificationLink=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100154- sha1:b8794f6 )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-9965) Add support for MapML CRS authority in GetFeature responses
Peter Rushforth ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A758f97c4-0255-444c-8e63-db502672e3f5 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZWRkMGE3MTMyYTM1NDkwMDgyOTkzNjI1NjhhYzFlNjYiLCJwIjoiaiJ9 ) / New Feature ( https://osgeo-org.atlassian.net/browse/GEOS-9965?atlOrigin=eyJpIjoiZWRkMGE3MTMyYTM1NDkwMDgyOTkzNjI1NjhhYzFlNjYiLCJwIjoiaiJ9 ) GEOS-9965 ( https://osgeo-org.atlassian.net/browse/GEOS-9965?atlOrigin=eyJpIjoiZWRkMGE3MTMyYTM1NDkwMDgyOTkzNjI1NjhhYzFlNjYiLCJwIjoiaiJ9 ) Add support for MapML CRS authority in GetFeature responses ( https://osgeo-org.atlassian.net/browse/GEOS-9965?atlOrigin=eyJpIjoiZWRkMGE3MTMyYTM1NDkwMDgyOTkzNjI1NjhhYzFlNjYiLCJwIjoiaiJ9 ) Issue Type: New Feature Affects Versions: 2.19-RC Assignee: Unassigned Components: MapML Created: 10/Mar/21 3:31 AM Priority: Medium Reporter: Peter Rushforth ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A758f97c4-0255-444c-8e63-db502672e3f5 ) The MapML viewer supports rendering vector information, but the MapML extension does not yet completely support the required markup to make viewing possible. While there are some limitations of doing all this code in the output format .write method, it would be ideal to actually be able to use the WFS-provided URLs in the MapML preview via, at a minimum, drag and drop. ( https://osgeo-org.atlassian.net/browse/GEOS-9965#add-comment?atlOrigin=eyJpIjoiZWRkMGE3MTMyYTM1NDkwMDgyOTkzNjI1NjhhYzFlNjYiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-9965#add-comment?atlOrigin=eyJpIjoiZWRkMGE3MTMyYTM1NDkwMDgyOTkzNjI1NjhhYzFlNjYiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495=EmailNotificationLink=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100154- sha1:b8794f6 )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] powermock for unit tests in app-schema
Another consideration... what is the "popularity" of the mocking libraries in the code? I made a very quick check (yes, debatable, I know): ~/devel/git-gt (main) $ git grep mockito | wc -l 114 ~/devel/git-gt (main) $ git grep easymock | wc -l 67 ~/devel/git-gt (main) $ git grep powermock | wc -l 23 Then I looked at Mockito, and it seems we're depending on a fairly recent version. And then stumbled into this: https://www.baeldung.com/mockito-final Hmm... so maybe Mockito too can handle final classes? Cheers Andrea On Tue, Mar 9, 2021 at 11:49 AM Andrea Aime wrote: > Hi all, > chiming in... indeed Nuno's comment was not against unit testing with > mocks (that's good per se), > but about the proliferation of mock testing libraries: > https://github.com/geotools/geotools/pull/3367#issuecomment-791476559 > > I also agree there are too many. > > By the way, just a note, wiremock solves a different problem than the > other mocking libraries, > it provides an actual HTTP server that can be used to test systems which > do not allow injection > of a local mock. > > Cheers > Andrea > > > > On Tue, Mar 9, 2021 at 11:42 AM Mark Prins wrote: > >> On 08-03-2021 13:01, Niels Charlier via Geoserver-devel wrote: >> > Hello, >> > >> > I fixed a bug in geoserver app-schema >> > (https://github.com/geotools/geotools/pull/3367 >> > https://osgeo-org.atlassian.net/browse/GEOT-6801). The change I made >> was >> > very small (one character actually) and in one specific class. To me it >> > seemed appropriate to write a unit test. Since it is JDBC an >> integration >> > test would only be run online with db, but still require a lot of >> amount >> > of work to create the right table, mapping etc... Mocking seems useful >> > to me. >> >> searching the code [1] shows we have many, many mocking frameworks >> already EasyMock, PowerMock, Mockito, WireMock, ... some of which are >> only used in one unsupported module. >> >> It seems powermock is only used in unsupported modules, so my preference >> would be to not add this to the core but use one of the other mocking >> frameworks already used in the core if possible. >> >> >> [1] https://github.com/geotools/geotools/search?q=mock >> >> Mark >> >> >> ___ >> Geoserver-devel mailing list >> Geoserver-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > > > -- > > Regards, Andrea Aime > > == GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf > Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa > (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 > http://www.geo-solutions.it http://twitter.com/geosolutions_it > --- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it --- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European
Re: [Geoserver-devel] powermock for unit tests in app-schema
Hi all, chiming in... indeed Nuno's comment was not against unit testing with mocks (that's good per se), but about the proliferation of mock testing libraries: https://github.com/geotools/geotools/pull/3367#issuecomment-791476559 I also agree there are too many. By the way, just a note, wiremock solves a different problem than the other mocking libraries, it provides an actual HTTP server that can be used to test systems which do not allow injection of a local mock. Cheers Andrea On Tue, Mar 9, 2021 at 11:42 AM Mark Prins wrote: > On 08-03-2021 13:01, Niels Charlier via Geoserver-devel wrote: > > Hello, > > > > I fixed a bug in geoserver app-schema > > (https://github.com/geotools/geotools/pull/3367 > > https://osgeo-org.atlassian.net/browse/GEOT-6801). The change I made > was > > very small (one character actually) and in one specific class. To me it > > seemed appropriate to write a unit test. Since it is JDBC an integration > > test would only be run online with db, but still require a lot of amount > > of work to create the right table, mapping etc... Mocking seems useful > > to me. > > searching the code [1] shows we have many, many mocking frameworks > already EasyMock, PowerMock, Mockito, WireMock, ... some of which are > only used in one unsupported module. > > It seems powermock is only used in unsupported modules, so my preference > would be to not add this to the core but use one of the other mocking > frameworks already used in the core if possible. > > > [1] https://github.com/geotools/geotools/search?q=mock > > Mark > > > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it --- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.* ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] powermock for unit tests in app-schema
PowerMock is the only mocking library that can bypass a class being final. It actually serves a different purpose to these other frameworks because you must still use the API of one of the other ones (easymock, mockito,..) of your choice, but you get additional 'power'. The alternative would be to avoid using 'final' on a class so that we can still mock those classes. Kind Regards Niels On 09/03/2021 11:40, Mark Prins wrote: On 08-03-2021 13:01, Niels Charlier via Geoserver-devel wrote: Hello, I fixed a bug in geoserver app-schema (https://github.com/geotools/geotools/pull/3367 https://osgeo-org.atlassian.net/browse/GEOT-6801). The change I made was very small (one character actually) and in one specific class. To me it seemed appropriate to write a unit test. Since it is JDBC an integration test would only be run online with db, but still require a lot of amount of work to create the right table, mapping etc... Mocking seems useful to me. searching the code [1] shows we have many, many mocking frameworks already EasyMock, PowerMock, Mockito, WireMock, ... some of which are only used in one unsupported module. It seems powermock is only used in unsupported modules, so my preference would be to not add this to the core but use one of the other mocking frameworks already used in the core if possible. [1] https://github.com/geotools/geotools/search?q=mock Mark ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] powermock for unit tests in app-schema
On 08-03-2021 13:01, Niels Charlier via Geoserver-devel wrote: Hello, I fixed a bug in geoserver app-schema (https://github.com/geotools/geotools/pull/3367 https://osgeo-org.atlassian.net/browse/GEOT-6801). The change I made was very small (one character actually) and in one specific class. To me it seemed appropriate to write a unit test. Since it is JDBC an integration test would only be run online with db, but still require a lot of amount of work to create the right table, mapping etc... Mocking seems useful to me. searching the code [1] shows we have many, many mocking frameworks already EasyMock, PowerMock, Mockito, WireMock, ... some of which are only used in one unsupported module. It seems powermock is only used in unsupported modules, so my preference would be to not add this to the core but use one of the other mocking frameworks already used in the core if possible. [1] https://github.com/geotools/geotools/search?q=mock Mark ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
