Change in ...osmo-trx[master]: radioInterfaceMulti: Check equals zero explicitly

2019-09-18 Thread pespin 
pespin has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15515 )

Change subject: radioInterfaceMulti: Check equals zero explicitly
..

radioInterfaceMulti: Check equals zero explicitly

It's not a pointer check or a boolean expression, in here we really
check chan index is 0, so it's more clear doing so this way like it's
done in all other places.

Change-Id: I83b14487d14ba8272f58796f640f58a88891e532
---
M Transceiver52M/radioInterfaceMulti.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/Transceiver52M/radioInterfaceMulti.cpp 
b/Transceiver52M/radioInterfaceMulti.cpp
index 7c1ee74..c41ec22 100644
--- a/Transceiver52M/radioInterfaceMulti.cpp
+++ b/Transceiver52M/radioInterfaceMulti.cpp
@@ -400,7 +400,7 @@

 double RadioInterfaceMulti::setRxGain(double db, size_t chan)
 {
-  if (!chan)
+  if (chan == 0)
 return mDevice->setRxGain(db);
   else
 return mDevice->getRxGain();

--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15515
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I83b14487d14ba8272f58796f640f58a88891e532
Gerrit-Change-Number: 15515
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-trx[master]: radioInterfaceMulti: Check equals zero explicitly

2019-09-14 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15515 )

Change subject: radioInterfaceMulti: Check equals zero explicitly
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15515
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I83b14487d14ba8272f58796f640f58a88891e532
Gerrit-Change-Number: 15515
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Sat, 14 Sep 2019 14:59:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-trx[master]: radioInterfaceMulti: Check equals zero explicitly

2019-09-13 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15515


Change subject: radioInterfaceMulti: Check equals zero explicitly
..

radioInterfaceMulti: Check equals zero explicitly

It's not a pointer check or a boolean expression, in here we really
check chan index is 0, so it's more clear doing so this way like it's
done in all other places.

Change-Id: I83b14487d14ba8272f58796f640f58a88891e532
---
M Transceiver52M/radioInterfaceMulti.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/15/15515/1

diff --git a/Transceiver52M/radioInterfaceMulti.cpp 
b/Transceiver52M/radioInterfaceMulti.cpp
index 7c1ee74..c41ec22 100644
--- a/Transceiver52M/radioInterfaceMulti.cpp
+++ b/Transceiver52M/radioInterfaceMulti.cpp
@@ -400,7 +400,7 @@

 double RadioInterfaceMulti::setRxGain(double db, size_t chan)
 {
-  if (!chan)
+  if (chan == 0)
 return mDevice->setRxGain(db);
   else
 return mDevice->getRxGain();

--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15515
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I83b14487d14ba8272f58796f640f58a88891e532
Gerrit-Change-Number: 15515
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange