Re: [PATCH v2 0/8] ref-in-want
On 06/15, Junio C Hamano wrote: > Brandon Williams writes: > > > Changes in v2: > > * issuing a want-ref line to a ref which doesn't exist is just ignored. > > * fixed some typos > > Do I lock some (logical) prerequisite changes? On 2.18-rc2 they > apply cleanly but the series fails its own test. No this is an error I made in this version of the series which another reviewer pointed out, I have a local v3 which addresses this (by removing the test since it isn't necessary anymore). Sorry for the mistake :) > > t5703-upload-pack-ref-in-want.sh > expecting success: > test-pkt-line pack >in <<-EOF && > command=fetch > 0001 > no-progress > want-ref refs/heads/non-existent > done > > EOF > > test_must_fail git serve --stateless-rpc 2>out grep "unknown ref" out > > test_must_fail: command succeeded: git serve --stateless-rpc > not ok 3 - invalid want-ref line -- Brandon Williams
Re: [PATCH v2 0/8] ref-in-want
Brandon Williams writes: > Changes in v2: > * issuing a want-ref line to a ref which doesn't exist is just ignored. > * fixed some typos Do I lock some (logical) prerequisite changes? On 2.18-rc2 they apply cleanly but the series fails its own test. t5703-upload-pack-ref-in-want.sh expecting success: test-pkt-line pack >in <<-EOF && command=fetch 0001 no-progress want-ref refs/heads/non-existent done EOF test_must_fail git serve --stateless-rpc 2>out
[PATCH v2 0/8] ref-in-want
Changes in v2: * issuing a want-ref line to a ref which doesn't exist is just ignored. * fixed some typos Brandon Williams (8): test-pkt-line: add unpack-sideband subcommand upload-pack: implement ref-in-want upload-pack: test negotiation with changing repository fetch: refactor the population of peer ref OIDs fetch: refactor fetch_refs into two functions fetch: refactor to make function args narrower fetch-pack: put shallow info in output parameter fetch-pack: implement ref-in-want Documentation/config.txt| 7 + Documentation/technical/protocol-v2.txt | 29 ++- builtin/clone.c | 4 +- builtin/fetch.c | 126 +++- fetch-object.c | 2 +- fetch-pack.c| 52 +++-- remote.c| 1 + remote.h| 1 + t/helper/test-pkt-line.c| 37 t/lib-httpd.sh | 1 + t/lib-httpd/apache.conf | 8 + t/lib-httpd/one-time-sed.sh | 16 ++ t/t5703-upload-pack-ref-in-want.sh | 245 transport-helper.c | 6 +- transport-internal.h| 9 +- transport.c | 34 +++- transport.h | 3 +- upload-pack.c | 64 +++ 18 files changed, 568 insertions(+), 77 deletions(-) create mode 100644 t/lib-httpd/one-time-sed.sh create mode 100755 t/t5703-upload-pack-ref-in-want.sh -- 2.18.0.rc1.242.g61856ae69a-goog
