[GitHub] [beam] lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload

[GitBox]

lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove 
TimerSpec from ParDoPayload
URL: https://github.com/apache/beam/pull/11216#discussion_r398691696
 
 

 ##
 File path: sdks/python/apache_beam/transforms/userstate.py
 ##
 @@ -141,6 +143,13 @@ def __init__(self, name, time_domain):
   def __repr__(self):
 return '%s(%s)' % (self.__class__.__name__, self.name)
 
+  def to_timer_family_runner_api(self, context):
 
 Review comment:
   +1 on TimerSpec removal


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload

[GitBox]

lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove 
TimerSpec from ParDoPayload
URL: https://github.com/apache/beam/pull/11216#discussion_r397942726
 
 

 ##
 File path: sdks/python/apache_beam/transforms/userstate.py
 ##
 @@ -141,6 +143,13 @@ def __init__(self, name, time_domain):
   def __repr__(self):
 return '%s(%s)' % (self.__class__.__name__, self.name)
 
+  def to_timer_family_runner_api(self, context):
 
 Review comment:
   shouldn't this method replace `to_runner_api`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload

[GitBox]

lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove 
TimerSpec from ParDoPayload
URL: https://github.com/apache/beam/pull/11216#discussion_r397943829
 
 

 ##
 File path: sdks/python/apache_beam/transforms/userstate.py
 ##
 @@ -149,6 +158,26 @@ def to_runner_api(self, context):
 coders._TimerCoder(coders.SingletonCoder(None
 
 
+# TODO(BEAM-9602): Provide support of dynamic timer
 
 Review comment:
   ```suggestion
   # TODO(BEAM-9602): Provide support for dynamic timer
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload

[GitBox]

lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove 
TimerSpec from ParDoPayload
URL: https://github.com/apache/beam/pull/11216#discussion_r397940099
 
 

 ##
 File path: model/pipeline/src/main/proto/beam_runner_api.proto
 ##
 @@ -442,35 +442,30 @@ message ParDoPayload {
   // be placed in the pipeline requirements.
   map state_specs = 4;
 
-  // (Optional) A mapping of local timer names to timer specifications.
-  // If this is set, the stateful processing requirement should also
-  // be placed in the pipeline requirements.
-  map timer_specs = 5;
-
-  // (Optional) A mapping of local timer family names to timer specifications.
-  // If this is set, the stateful processing requirement should also
-  // be placed in the pipeline requirements.
-  map timer_family_specs = 9;
+  // (Optional) A mapping of local timer family names to timer family
+  // specifications. If this is set, the stateful processing requirement should
+  // also be placed in the pipeline requirements.
+  map timer_family_specs = 8;
 
 Review comment:
   I would suggest not changing the proto tag numbers otherwise you'll have a 
more difficult import/update issue with Google.
   
   It will be much easier as a separate change to renumber them in increasing 
order, so timer_family_specs is 5, restriction_coder_id is 6, 
requests_finalization is 7, ... (making the import into Google much simpler to 
do).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services