Re: [PATCH] Retire ChangeLog-2015
On Fri, Feb 25, 2022 at 11:28:42AM -0500, Peter Jones wrote: > ChangeLog-2015 has been untouched for over 7 years now, and any > information in it is purely for historical purposes. At the same time, > grepping for code winds up matching this file quite a bit, almost never > accomplishing anything other than cluttering up your grep results. We > don't need this in the main repo, and "git show" will find it if you're > looking at the old history of commits on some file. > > This patch deletes it and the Makefile.am rule to distribute it. > > The following reviewed-by lines are all from before the Makefile.am > change, but I am sure the reviewers will still consider this valid. > > Signed-off-by: Peter Jones > Reviewed-by: Daniel Axtens > Reviewed-by: Robbie Harwood > Reviewed-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] Retire ChangeLog-2015
On Fri, Feb 25, 2022 at 01:03:48PM +0100, Daniel Kiper wrote: > On Fri, Feb 25, 2022 at 11:33:09AM +0100, Javier Martinez Canillas wrote: > > Hello Peter, > > > > Thanks a lot for your patch. > > > > On 2/24/22 22:55, Peter Jones wrote: > > > ChangeLog-2015 has been untouched for over 7 years now, and any > > > information in it is purely for historical purposes. At the same time, > > > grepping for code winds up matching this file quite a bit, almost never > > > accomplishing anything other than cluttering up your grep results. We > > > don't need this in the main repo, and "git show" will find it if you're > > > looking at the old history of commits on some file. > > > > > > This patch deletes it. > > > > Yes, let's *please* get rid of this ChangeLog. It doesn't add any > > value AFAICT and makes doing greps over the codebase much harder. > > > > > Signed-off-by: Peter Jones > > > Reviewed-by: Daniel Axtens > > > Reviewed-by: Robbie Harwood > > > > Reviewed-by: Javier Martinez Canillas > > I agree with above but it requires more than just ChangeLog-2015 file > removal. The file is referenced at least in Makefile.am. I've sent a follow-up that fixes this as well. > Additionally, may we consider addition of a script which generates > ChangeLog file from the git log? I think we could steal it from here > [1][2]. Feel free, but IMO that's unrelated to this patch, which just cleans up old goo in the repo. > And if we do that I think we could drop NEWS file too (it is > referenced in README; so, it should be dropped from there too). Again, fine with me, but unrelated to this. ChangeLog-2015 is /in everyone's way/. -- Peter ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] Retire ChangeLog-2015
Hello Daniel, On 2/25/22 13:03, Daniel Kiper wrote: > On Fri, Feb 25, 2022 at 11:33:09AM +0100, Javier Martinez Canillas wrote: >> Hello Peter, >> >> Thanks a lot for your patch. >> >> On 2/24/22 22:55, Peter Jones wrote: >>> ChangeLog-2015 has been untouched for over 7 years now, and any >>> information in it is purely for historical purposes. At the same time, >>> grepping for code winds up matching this file quite a bit, almost never >>> accomplishing anything other than cluttering up your grep results. We >>> don't need this in the main repo, and "git show" will find it if you're >>> looking at the old history of commits on some file. >>> >>> This patch deletes it. >> >> Yes, let's *please* get rid of this ChangeLog. It doesn't add any >> value AFAICT and makes doing greps over the codebase much harder. >> >>> Signed-off-by: Peter Jones >>> Reviewed-by: Daniel Axtens >>> Reviewed-by: Robbie Harwood >> >> Reviewed-by: Javier Martinez Canillas > > I agree with above but it requires more than just ChangeLog-2015 file > removal. The file is referenced at least in Makefile.am. Additionally, Can we do these as follow-ups ? Looking at my bash history most (if not all) of the grep commands I did on the GRUB codebase are like following: $ git grep grub_unixtime2datetime | grep -v ChangeLog > may we consider addition of a script which generates ChangeLog file > from the git log? I think we could steal it from here [1][2]. And if we > do that I think we could drop NEWS file too (it is referenced in README; > so, it should be dropped from there too). > Yes, these sounds good improvements too but out of scope for this patch in my opinion. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] Retire ChangeLog-2015
On Fri, Feb 25, 2022 at 11:33:09AM +0100, Javier Martinez Canillas wrote: > Hello Peter, > > Thanks a lot for your patch. > > On 2/24/22 22:55, Peter Jones wrote: > > ChangeLog-2015 has been untouched for over 7 years now, and any > > information in it is purely for historical purposes. At the same time, > > grepping for code winds up matching this file quite a bit, almost never > > accomplishing anything other than cluttering up your grep results. We > > don't need this in the main repo, and "git show" will find it if you're > > looking at the old history of commits on some file. > > > > This patch deletes it. > > Yes, let's *please* get rid of this ChangeLog. It doesn't add any > value AFAICT and makes doing greps over the codebase much harder. > > > Signed-off-by: Peter Jones > > Reviewed-by: Daniel Axtens > > Reviewed-by: Robbie Harwood > > Reviewed-by: Javier Martinez Canillas I agree with above but it requires more than just ChangeLog-2015 file removal. The file is referenced at least in Makefile.am. Additionally, may we consider addition of a script which generates ChangeLog file from the git log? I think we could steal it from here [1][2]. And if we do that I think we could drop NEWS file too (it is referenced in README; so, it should be dropped from there too). Daniel [1] https://sourceware.org/git/?p=glibc.git;a=commit;h=2e4e75727eb05eef4c10470d865bd42962d5fae7 [2] https://sourceware.org/git/?p=glibc.git;a=commit;h=f2144b7874b23be7c7eb184ec601633ec6fa8fac ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] Retire ChangeLog-2015
Hello Peter, Thanks a lot for your patch. On 2/24/22 22:55, Peter Jones wrote: > ChangeLog-2015 has been untouched for over 7 years now, and any > information in it is purely for historical purposes. At the same time, > grepping for code winds up matching this file quite a bit, almost never > accomplishing anything other than cluttering up your grep results. We > don't need this in the main repo, and "git show" will find it if you're > looking at the old history of commits on some file. > > This patch deletes it. > Yes, let's *please* get rid of this ChangeLog. It doesn't add any value AFAICT and makes doing greps over the codebase much harder. > Signed-off-by: Peter Jones > Reviewed-by: Daniel Axtens > Reviewed-by: Robbie Harwood Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] Retire ChangeLog-2015
Daniel Axtens writes: >> ChangeLog-2015 has been untouched for nearly 5 years now, and any >> information in it is purely for historical purposes. At the same time, >> grepping for code winds up matching this file quite a bit, almost never >> accomplishing anything other than cluttering up your grep results. We >> don't need this in the main repo, and "git show" will find it if you're >> looking at the old history of commits on some file. >> >> This patch deletes it. >> > > Oh goodness yes, what a great idea. Not having to skip past it in git > grep would be wonderful. > > Reviewed-by: Daniel Axtens Reviewed-by: Robbie Harwood Be well, --Robbie signature.asc Description: PGP signature ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
