Re: [ANNOUNCE] haproxy-1.6-dev5

[Baptiste]

On Mon, Sep 21, 2015 at 8:39 PM, Willy Tarreau  wrote:
> On Mon, Sep 21, 2015 at 08:37:36PM +0200, PiBa-NL wrote:
>> Op 14-9-2015 om 23:46 schreef Willy Tarreau:
>> >On Mon, Sep 14, 2015 at 10:46:00PM +0200, Baptiste wrote:
>> >>The issue is related to the connect() function to establish the UDP
>> >>connection.
>> >>Currently, I use a sizeof() to get the len of the address structure
>> >>and Remi suggested to use get_addr_len() instead.
>> >>
>> >>Pieter confirmed Remi's suggestion fixes the issue.
>> >>I can reproduce the issue in a FreeBSD VM I have on my computer. I'll
>> >>show you tomorrow at the office.
>> >OK fine.
>> >
>> >Willy
>> >
>> Hi Baptiste & Willy,
>>
>> Did you discuss the issue? I'm wondering what the conclusion was, if
>> any? As i see the source is still unchanged at this part.
>
> No we didn't have an opportunity. It's a good thing that you reheat that
> thread before it gets lors again.
>
> Baptiste, could you please send me your fix regarding this issue ?
>
> Thanks,
> Willy
>

Just to let PibaNL now, it's now applied.
Thanks PibaNL and Remi for catching and providing the patch.

Baptiste

Re: [ANNOUNCE] haproxy-1.6-dev5

[Willy Tarreau]

On Mon, Sep 21, 2015 at 08:37:36PM +0200, PiBa-NL wrote:
> Op 14-9-2015 om 23:46 schreef Willy Tarreau:
> >On Mon, Sep 14, 2015 at 10:46:00PM +0200, Baptiste wrote:
> >>The issue is related to the connect() function to establish the UDP 
> >>connection.
> >>Currently, I use a sizeof() to get the len of the address structure
> >>and Remi suggested to use get_addr_len() instead.
> >>
> >>Pieter confirmed Remi's suggestion fixes the issue.
> >>I can reproduce the issue in a FreeBSD VM I have on my computer. I'll
> >>show you tomorrow at the office.
> >OK fine.
> >
> >Willy
> >
> Hi Baptiste & Willy,
> 
> Did you discuss the issue? I'm wondering what the conclusion was, if 
> any? As i see the source is still unchanged at this part.

No we didn't have an opportunity. It's a good thing that you reheat that
thread before it gets lors again.

Baptiste, could you please send me your fix regarding this issue ?

Thanks,
Willy

Re: [ANNOUNCE] haproxy-1.6-dev5

[PiBa-NL]

Op 14-9-2015 om 23:46 schreef Willy Tarreau:

On Mon, Sep 14, 2015 at 10:46:00PM +0200, Baptiste wrote:

The issue is related to the connect() function to establish the UDP connection.
Currently, I use a sizeof() to get the len of the address structure
and Remi suggested to use get_addr_len() instead.

Pieter confirmed Remi's suggestion fixes the issue.
I can reproduce the issue in a FreeBSD VM I have on my computer. I'll
show you tomorrow at the office.

OK fine.

Willy


Hi Baptiste & Willy,

Did you discuss the issue? I'm wondering what the conclusion was, if 
any? As i see the source is still unchanged at this part.


Thanks,
PiBa-NL

Re: [ANNOUNCE] haproxy-1.6-dev5

[Pavlos Parissis]

On 14/09/2015 01:37 μμ, Willy Tarreau wrote:
> Hi all,
> 
> we've fixed several bugs since -dev4 so in order to encourage people to
> safely test the code, here comes -dev5.
> 
> 

This has been running few days now and I haven't noticed any problems.

I am going to push it *slowly( to other systems as well.

Thanks a lot,
Pavlos





signature.asc
Description: OpenPGP digital signature

Re: [ANNOUNCE] haproxy-1.6-dev5

[PiBa-NL]

Op 14-9-2015 om 13:37 schreef Willy Tarreau:

Hi all,

we've fixed several bugs since -dev4 so in order to encourage people to
safely test the code, here comes -dev5.


Hi Willy,

As always its nice to have a new -dev release when some fixes have been 
added.

Though i think a day or two heads-up would be nice before every dev release.

As this time a patch is missing which i was hoping to get with dev5.
'haproxy resolvers "nameserver: can't connect socket" (on FreeBSD)'

Should i re-send that patch by Remi with some commit comment and a PATCH 
subject? I thought Baptiste was going to do that.


Just let me know, thanks.

Thanks,
PiBa-NL

Re: [ANNOUNCE] haproxy-1.6-dev5

[Baptiste]

On Mon, Sep 14, 2015 at 9:12 PM, Willy Tarreau  wrote:
> On Mon, Sep 14, 2015 at 09:08:49PM +0200, PiBa-NL wrote:
>> Op 14-9-2015 om 18:48 schreef Willy Tarreau:
>> >BTW as a general rule, patches being merged are ACKed to their authors
>> >or rejected, so if you don't get a response, simply consider it lost.
>> I didn't sent a patch so to speak, Remi did send a 'diff --git' but
>> without the comment to put into the haproxy repository, after which
>> Baptiste then wrote he would submit it after confirmation that it did
>> solved the issue, which i gave.
>
> Thanks for the explanation, I indeed missed all this exchange I guess.
>
>> Anyway its not that important i suppose,
>> otherwise we / you could always issue another dev release..
>
> OK so Baptiste will catch it when he has time and forward it to me
> once he's OK with it.
>
>> Also the patch was added to FreeBSD ports repository, so should come
>> through with the binary repositories building from there. That will
>> solve my 'problem' for the moment.
>
> OK fine. Thanks!
> Willy
>


Willy,

The issue is related to the connect() function to establish the UDP connection.
Currently, I use a sizeof() to get the len of the address structure
and Remi suggested to use get_addr_len() instead.

Pieter confirmed Remi's suggestion fixes the issue.
I can reproduce the issue in a FreeBSD VM I have on my computer. I'll
show you tomorrow at the office.

Baptiste

Re: [ANNOUNCE] haproxy-1.6-dev5

[Willy Tarreau]

On Mon, Sep 14, 2015 at 10:46:00PM +0200, Baptiste wrote:
> The issue is related to the connect() function to establish the UDP 
> connection.
> Currently, I use a sizeof() to get the len of the address structure
> and Remi suggested to use get_addr_len() instead.
> 
> Pieter confirmed Remi's suggestion fixes the issue.
> I can reproduce the issue in a FreeBSD VM I have on my computer. I'll
> show you tomorrow at the office.

OK fine.

Willy

Re: [ANNOUNCE] haproxy-1.6-dev5

[PiBa-NL]

Op 14-9-2015 om 18:48 schreef Willy Tarreau:

BTW as a general rule, patches being merged are ACKed to their authors
or rejected, so if you don't get a response, simply consider it lost.
I didn't sent a patch so to speak, Remi did send a 'diff --git' but 
without the comment to put into the haproxy repository, after which 
Baptiste then wrote he would submit it after confirmation that it did 
solved the issue, which i gave. Anyway its not that important i suppose, 
otherwise we / you could always issue another dev release..


Also the patch was added to FreeBSD ports repository, so should come 
through with the binary repositories building from there. That will 
solve my 'problem' for the moment.


Thanks for your reply.
PiBa-NL

Re: [ANNOUNCE] haproxy-1.6-dev5

[Willy Tarreau]

On Mon, Sep 14, 2015 at 09:08:49PM +0200, PiBa-NL wrote:
> Op 14-9-2015 om 18:48 schreef Willy Tarreau:
> >BTW as a general rule, patches being merged are ACKed to their authors
> >or rejected, so if you don't get a response, simply consider it lost.
> I didn't sent a patch so to speak, Remi did send a 'diff --git' but 
> without the comment to put into the haproxy repository, after which 
> Baptiste then wrote he would submit it after confirmation that it did 
> solved the issue, which i gave.

Thanks for the explanation, I indeed missed all this exchange I guess.

> Anyway its not that important i suppose, 
> otherwise we / you could always issue another dev release..

OK so Baptiste will catch it when he has time and forward it to me
once he's OK with it.

> Also the patch was added to FreeBSD ports repository, so should come 
> through with the binary repositories building from there. That will 
> solve my 'problem' for the moment.

OK fine. Thanks!
Willy