Re: [hugin-ptx] Re: RE calibrate_lens_gui
On Sun 29-May-2011 at 12:32 -0700, Thomas Modes wrote: > Removing calibrate_lens would also allow to remove ANN from > src/foreign. > What's your opinion? Has somebody used calibrate_lens and vote > for keep it? Nobody votes for it? No more comments? Since it doesn't work in its current state and it would be good to get rid of the bundled ANN library I'd vote for removing it. It can always be revived if necessary. -- Bruno -- You received this message because you are subscribed to the Google Groups "Hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx
Re: [hugin-ptx] Re: RE calibrate_lens_gui
> > Removing the code from the current default branch will not be a complete loss > - those interested in this code can still find it by checking out older > revisions; and the code can be revived if necessary. IIRC Tom had plans for > the new lens model. I would suggest talking with him before removing. > > Yuv > Maybe the branch containing the code before removal should be made, so it doesn't get completely lost between thousands of commits. Otherwise only a few people knew there was such code. Lukas -- You received this message because you are subscribed to the Google Groups "Hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx
Re: [hugin-ptx] Re: RE calibrate_lens_gui
On May 29, 2011 03:32:24 pm T. Modes wrote: > > PS: What should be happen with the originalcalibrate_lens? > > I'm for removing it: First calibrate_lens is using it's own lens model > > which is not compatible with libpanos model. So the output does not > > help any user to correct an image (In several mails I asked for a > > explanation of the parameters but nobody could explain it.) Second the > > source code is ugly: mixing global variable with local variables. So > > it is complicate to reuse the code or fix bugs. The main parts I > > refactored into an own lib (huginlines) from where they can now easily > > used. Also it pulls in several dependencies which are not used in the > > current state (They are only used when activated some deactivated > > code). Removing calibrate_lens would also allow to remove ANN from src/ > > foreign. > > What's your opinion? Has somebody used calibrate_lens and vote for > > keep it? > > Nobody votes for it? No more comments? > When nobody objects, it will be removed. Sorry, I had not seen the original post. IIRC the new lens model used in calibrate_lens is an idea of Tom Sharpless. He and Tim worked on this during Tim's 2008 GSoC project. The model was meant to be superior to the libpano lens model. I have not seen any follow up on this, so for the time being it seem to be of limited practical use. Removing the code from the current default branch will not be a complete loss - those interested in this code can still find it by checking out older revisions; and the code can be revived if necessary. IIRC Tom had plans for the new lens model. I would suggest talking with him before removing. Yuv signature.asc Description: This is a digitally signed message part.
Re: [hugin-ptx] Re: RE calibrate_lens_gui
Am Donnerstag, 19. Mai 2011 schrieb kfj: > 10.10 should not be a problem; I've done all the development on > Kubuntu 10.10 and Python 2.6.6 and only recently upgraded to 11.4, > which comes with Python 2.7.1. What version of SWIG are you using? > I've used 2.0.1 built from source. Downloaded version 2.0.3. Hugin compiles with that version here, thanks. Kornel signature.asc Description: This is a digitally signed message part.
Re: [hugin-ptx] Re: RE calibrate_lens_gui
On May 19, 2011 07:32:24 AM kfj wrote: > What version of SWIG are you using? > I've used 2.0.1 built from source. `sudo apt-get install swig2.0` did *not* do the trick, but according to [0] it is v2.0.1-2 :( > I've also recently updated the > README, you may want to have a look at > > http://bazaar.launchpad.net/~kfj/+junk/script/view/head:/main/README.hsi will look at this tonight, or over the weekend. Time is running out. Yuv [0] https://launchpad.net/ubuntu/natty/+source/swig2.0 signature.asc Description: This is a digitally signed message part.
Re: [hugin-ptx] Re: RE calibrate_lens_gui
> Have tried it on Kubuntu 10.10, but I got compile errors. ... > Maybe too old python-version (Python 2.6.6) ? Kubuntu 11.4: https://bugs.launchpad.net/hugin/+bug/785148 Yuv signature.asc Description: This is a digitally signed message part.
Re: [hugin-ptx] Re: RE calibrate_lens_gui
On May 19, 2011 03:52:00 AM kfj wrote: > you need swig as well to build oups, i'm reading this only now. long live sequential processing (with a timer that is expring in half hour when i got to go). > Maybe we should discuss the topic on a different thread? make sense. sorry for the thread hijack. > README.hsi in the hugin_script_interface directory will look at that too. Yuv signature.asc Description: This is a digitally signed message part.
Re: [hugin-ptx] Re: RE calibrate_lens_gui
Am Donnerstag, 19. Mai 2011 schrieb kfj: > On 19 Mai, 11:49, Kornel Benko wrote: > > Have tried it on Kubuntu 10.10, but I got compile errors. > > 10.10 should not be a problem; I've done all the development on > Kubuntu 10.10 and Python 2.6.6 and only recently upgraded to 11.4, > which comes with Python 2.7.1. What version of SWIG are you using? > I've used 2.0.1 built from source. I've also recently updated the > README, you may want to have a look at That should be it. SWIG Version 1.3.40 Compiled with g++ [x86_64-unknown-linux-gnu] will try to compile it (later) > http://bazaar.launchpad.net/~kfj/+junk/script/view/head:/main/README.hsi > > You may also want to try a fresh clean checkout from the repo. Hope > you're up and running soon > > Kay ATM I am trying to learn python. Screaming all the time because it is so different to my belowed perl. Kornel signature.asc Description: This is a digitally signed message part.
Re: [hugin-ptx] Re: RE calibrate_lens_gui
On May 19, 2011 07:18:30 AM Yuval Levy wrote: > Danke Thomas! > > On May 19, 2011 02:11:13 AM T. Modes wrote: > > > can you or anybody close to the source recall what those extra > > > dependencies > > > > AFAIR python-dev (you will need the python headers and lib) > > updated http://wiki.panotools.org/Hugin_Compiling_Ubuntu > and forwarded information for the nightlies. and swig is a dependency too - found that out while running the build process. Updated. Yuv signature.asc Description: This is a digitally signed message part.
Re: [hugin-ptx] Re: RE calibrate_lens_gui
Danke Thomas! On May 19, 2011 02:11:13 AM T. Modes wrote: > > can you or anybody close to the source recall what those extra > > dependencies > > AFAIR python-dev (you will need the python headers and lib) > > > and what cmake flags are necessary to build the python version? > > Add -DBUILD_HSI:BOOL=ON to cmake command line (not sure if this is > correct, but it should give an impression, I'm using the GUI and there > it is only one click to mark that option) updated http://wiki.panotools.org/Hugin_Compiling_Ubuntu and forwarded information for the nightlies. Yuv signature.asc Description: This is a digitally signed message part.
Re: [hugin-ptx] Re: RE calibrate_lens_gui
Am Donnerstag, 19. Mai 2011 schrieb kfj: > On 19 Mai, 08:11, "T. Modes" wrote: > > > can you or anybody close to the source recall what those extra > > > dependencies > > > > AFAIR python-dev (you will need the python headers and lib) > > you need swig as well to build, since we've decided to make it > mandatory for building so the hsi module is forced in-sync with the > hugin C++ headers it processes and all changes are promptly reflected > or produce an error if they can't be integrated. > > > > and what cmake flags are necessary to build the python version? > > > > Add -DBUILD_HSI:BOOL=ON to cmake command line (not sure if this is > > correct, but it should give an impression, I'm using the GUI and there > > it is only one click to mark that option) > > here (Kubuntu 11.4) I merely add -DBUILD_HSI=ON Have tried it on Kubuntu 10.10, but I got compile errors. ... cd /usr/BUILD/BuildHugin_hg/src/hugin_script_interface && /usr/bin/c++ -D_hsi_EXPORTS -DHUGIN_HSI -O3 -DNDEBUG -fPIC -I/usr/BUILD/BuildHugin_hg/src -I/usr/src/hugin/hugin_hg/src/hugin_base - I/usr/src/hugin/hugin_hg/src/foreign -I/usr/src/hugin/hugin_hg/src/foreign/vigra -I/usr/src/hugin/hugin_hg/src/celeste -I/usr/BUILD/BuildHugin_hg/src/celeste -I/usr/src/hugin/hugin_hg/src - I/usr/include/OpenEXR -I/usr/local/include -I/usr/include/python2.6 -I/usr/src/hugin/hugin_hg/src/hugin_script_interface -I/usr/BUILD/BuildHugin_hg/src/hugin_script_interface -o CMakeFiles/_hsi.dir/hsiPYTHON_wrap.cxx.o -c /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx In file included from /usr/include/c++/4.4/backward/hash_set:60, from /usr/include/boost/pending/container_traits.hpp:23, from /usr/include/boost/graph/detail/adjacency_list.hpp:31, from /usr/include/boost/graph/adjacency_list.hpp:324, from /usr/src/hugin/hugin_hg/src/hugin_base/algorithms/optimizer/ImageGraph.h:36, from /usr/src/hugin/hugin_hg/src/hugin_base/algorithms/optimizer/PTOptimizer.h:216, from /usr/src/hugin/hugin_hg/src/hugin_base/algorithms/control_points/CleanCP.h:36, from /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx:3025: /usr/include/c++/4.4/backward/backward_warning.h:28: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno- deprecated. /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx: In function ‘PyObject* _wrap_new_AssistantMakefilelibExport(PyObject*, PyObject*)’: /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx:61257: error: ‘AssistantPrograms’ was not declared in this scope /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx:61257: error: ‘arg2’ was not declared in this scope /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx:61314: error: expected type-specifier before ‘AssistantPrograms’ /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx:61314: error: expected ‘>’ before ‘AssistantPrograms’ /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx:61314: error: expected ‘(’ before ‘AssistantPrograms’ /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx:61314: error: expected primary-expression before ‘>’ token /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx:61314: error: expected ‘)’ before ‘;’ token /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx:61364: error: expected ‘)’ before ‘const’ /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx:61364: error: expected ‘)’ before ‘;’ token /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx: In function ‘PyObject* _wrap_AssistantMakefilelibExport_createMakefile(PyObject*, PyObject*)’: /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx:61377: error: ‘AssistantPrograms’ was not declared in this scope /usr/BUILD/BuildHugin_hg/src/hugin_script_interface/hsiPYTHON_wrap.cxx:61377: error: ‘arg2’ was not declared in this scope ... There comes more. Maybe too old python-version (Python 2.6.6) ? Kornel signature.asc Description: This is a digitally signed message part.
Re: [hugin-ptx] Re: RE calibrate_lens_gui
Hi Terry, On May 18, 2011 08:23:05 PM Tduell wrote: > I probably got some things in the wrong sequence. no, you did not get anything wrong. I wrongly believed that the automated nightlies builder would take the last revision of the default branch, while it obviously takes the the latest revision no matter what branch. Thomas gave the correct explanation. > Again, sorry for causing the confusion if anybody has to apologize, that's me. Yuv signature.asc Description: This is a digitally signed message part.
Re: [hugin-ptx] Re: RE calibrate_lens_gui
Hi Thomas, On May 18, 2011 02:44:05 PM T. Modes wrote: > there were nothing wrong. It seems the nightlies build followed the > merge until there is a new changeset into the default branch. yes, you're right, thanks for figuring that out and for merging the python_scripting branch. > I think the nightlies needs changes to the dependcies and the build > options to build the python version. can you or anybody close to the source recall what those extra dependencies and what cmake flags are necessary to build the python version? at the moment I lack the time to research this myself but I would like the information forwarded to Philipp so that 'buntu nightlies users get the python version. Yuv signature.asc Description: This is a digitally signed message part.
Re: [hugin-ptx] Re: RE calibrate_lens_gui
Cool, I got to try that! These can be independant images, as long as there are straight lines at same focal length, or? The more the better? /O 2011/5/18 T. Modes > > > On 18 Mai, 04:18, Tduell wrote: > > Hullo All, > > I have just committed a patch to the default branch which installs > > calibrate_lens_gui.desktop on Linux. It works OK here on my Fedora > > build. > > Any Linux users who want to try/test the lens calibration tool might > > want to grab the tip. > > Some hints for calibrate_lens_gui: It is based on lens_calibrate (Tims > GSoC project from 2008) > You need images with straight lines. > Load them, check the focal length, crop factor and lens type. Then try > to detect lines. If lines were found the should be painted as green > lines in the preview (Black lines are invalid lines.) If no lines were > found try to change the parameters: In my test the most critical > parameters is minimum line length: this is the minimum length a line > must have to be detected as line. Is is given in the fraction to the > image width (So try with smaller values 0.1 or 0.05) > The edge detection scale and thresold influence how the edges are > detected. You can switch the preview to Edge detection to see the > direct influence (need to press find lines again). > If enough lines are found you can optimize the lens parameters. After > it switch the preview to corrected and check is the result is correct. > If so save the lens parameters to a file. > > Thomas > > PS: What should be happen with the original calibrate_lens? > I'm for removing it: First calibrate_lens is using it's own lens model > which is not compatible with libpanos model. So the output does not > help any user to correct an image (In several mails I asked for a > explanation of the parmeters but nobody could explain it.) Second the > source code is ugly: mixing global variable with local variables. So > it is complicate to reuse the code or fix bugs. The main parts I > refactored into an own lib (huginlines) from where they can now easily > used. Also it pulls in several dependcies which are not used in the > current state (They are only used when activated some deactivated > code). Removing calibrate_lens would also allow to remove ANN from src/ > foreign. > What's your opinion? Has somebody used calibrate_lens and vote for > keep it? > > -- > You received this message because you are subscribed to the Google Groups > "Hugin and other free panoramic software" group. > A list of frequently asked questions is available at: > http://wiki.panotools.org/Hugin_FAQ > To post to this group, send email to hugin-ptx@googlegroups.com > To unsubscribe from this group, send email to > hugin-ptx+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/hugin-ptx > -- /O -- You received this message because you are subscribed to the Google Groups "Hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx
