[jira] [Commented] (CALCITE-1192) Document protobuf and json REP types with examples
[ https://issues.apache.org/jira/browse/CALCITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246665#comment-15246665 ] Francis Chuang commented on CALCITE-1192: - Looks great! :) > Document protobuf and json REP types with examples > -- > > Key: CALCITE-1192 > URL: https://issues.apache.org/jira/browse/CALCITE-1192 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > It would be nice to have the documentation for the Rep types here > (https://calcite.apache.org/docs/avatica_protobuf_reference.html#rep) > documented with examples to show what the serialized representation looks > like. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1192) Document protobuf and json REP types with examples
[ https://issues.apache.org/jira/browse/CALCITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245857#comment-15245857 ] Josh Elser commented on CALCITE-1192: - CALCITE-1205 has the fix to the field name in TypedValue to correct that. I just pushed https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=commit;h=6ddd7821222f1a3e9480c205fdcfa8119b1277c3 which makes the json and protobuf docs consistent about how those date/type datatypes are serialized as numbers. Thanks for taking a look, Francis. > Document protobuf and json REP types with examples > -- > > Key: CALCITE-1192 > URL: https://issues.apache.org/jira/browse/CALCITE-1192 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > It would be nice to have the documentation for the Rep types here > (https://calcite.apache.org/docs/avatica_protobuf_reference.html#rep) > documented with examples to show what the serialized representation looks > like. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1192) Document protobuf and json REP types with examples
[ https://issues.apache.org/jira/browse/CALCITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245812#comment-15245812 ] Josh Elser commented on CALCITE-1192: - bq. For the bytes_value field, I believe it should be bytes_values as per Ugh, that is extremely unfortunate. That's a typo in the proto definition, rather than a documentation issue. I'm not sure if that's something we can change without breaking protobuf compat, but that's going to be how I'd like to fix it. bq. Also, I think it would be useful to have some notes regarding the time values, for example: Ahh, I had added this for the JSON docs, but forgot to do it for the Protobuf docs. I will amend that. > Document protobuf and json REP types with examples > -- > > Key: CALCITE-1192 > URL: https://issues.apache.org/jira/browse/CALCITE-1192 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > It would be nice to have the documentation for the Rep types here > (https://calcite.apache.org/docs/avatica_protobuf_reference.html#rep) > documented with examples to show what the serialized representation looks > like. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1192) Document protobuf and json REP types with examples
[ https://issues.apache.org/jira/browse/CALCITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244943#comment-15244943 ] Francis Chuang commented on CALCITE-1192: - That looks great! For the bytes_value field, I believe it should be bytes_values as per https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/common.proto#L199 Also, I think it would be useful to have some notes regarding the time values, for example: - Date is the number of days since 1/1/1970. - Time is the number of milliseconds since 00:00:00:000 - Timestamp is the number of milliseconds since 1/1/1970 00:00:00:000 > Document protobuf and json REP types with examples > -- > > Key: CALCITE-1192 > URL: https://issues.apache.org/jira/browse/CALCITE-1192 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > It would be nice to have the documentation for the Rep types here > (https://calcite.apache.org/docs/avatica_protobuf_reference.html#rep) > documented with examples to show what the serialized representation looks > like. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
