[GitHub] [commons-statistics] chtompki commented on issue #17: STATISTICS-7
chtompki commented on issue #17: STATISTICS-7 URL: https://github.com/apache/commons-statistics/pull/17#issuecomment-502323597 Figure'd that I'd start the conversation here. :-) Good work plugging along with all of this.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-statistics] chtompki opened a new pull request #17: STATISTICS-7
chtompki opened a new pull request #17: STATISTICS-7 URL: https://github.com/apache/commons-statistics/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (CSV-235) WRONG Implementation for RFC4180
[ https://issues.apache.org/jira/browse/CSV-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864480#comment-16864480 ] Sebb commented on CSV-235: -- RFC4180 only supports 'escaping' for the DQ character. The DQ cannot be used to escape anything else, so is not an escape character in the normal sense. > WRONG Implementation for RFC4180 > -- > > Key: CSV-235 > URL: https://issues.apache.org/jira/browse/CSV-235 > Project: Commons CSV > Issue Type: Bug > Components: Parser >Affects Versions: 1.6 >Reporter: Edward Xia >Priority: Major > > [https://tools.ietf.org/html/rfc4180#section-2] >7. If double-quotes are used to enclose fields, then a double-quote >appearing inside a field must be escaped by preceding it with >another double quote. For example: >"aaa","b""bb","ccc" > Apparently, base on a previous issue: > https://issues.apache.org/jira/browse/CSV-208, it turns out common-csv *does > not even support quote and escape to be the same character*. > RFC 4180 defines that quote and escape are both DQUOTE, however in common-csv > implementation, the default escape character is not DQUOTE, and it does not > work if changed to DQUOTE. > This means common csv is not rfc4180 compliant. > Also, I'm puzzled by the fact that someone marked CSV-208 as fixed when > nothing is fixed. Instead, it changed the behavior without documenting that > the POSTGRESQL_CSV format does not even work out of the box with the default > csv format that postgresql produces. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CSV-243) CSVFormat withTrim() and withIgnoreSurroundingSpaces() need better docs
[ https://issues.apache.org/jira/browse/CSV-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved CSV-243. -- Resolution: Fixed dd5de38 CSV-243 CSVFormat withTrim() and withIgnoreSurroundingSpaces() > CSVFormat withTrim() and withIgnoreSurroundingSpaces() need better docs > --- > > Key: CSV-243 > URL: https://issues.apache.org/jira/browse/CSV-243 > Project: Commons CSV > Issue Type: Bug >Reporter: Sebb >Priority: Major > > It looks like withIgnoreSurroundingSpaces() is a parser option and withTrim() > is a printer option. > These need better Javadoc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-statistics] aherbert opened a new pull request #16: Upgrade junit5
aherbert opened a new pull request #16: Upgrade junit5 URL: https://github.com/apache/commons-statistics/pull/16 This removes all JUnit 4. Migration was straight forward: - Add JUnit 5 Bill-of-materials (BOM) and dependencies to pom to support JUnit 4 - Updated all the test classes to use JUnit 5 annotations - Switch Assert to Assertions (the order for error messages have to be swapped) - Remove JUnit 4 support from pom This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (DAEMON-243) Support for Failure Recovery
[ https://issues.apache.org/jira/browse/DAEMON-243?focusedWorklogId=260680=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-260680 ] ASF GitHub Bot logged work on DAEMON-243: - Author: ASF GitHub Bot Created on: 14/Jun/19 19:40 Start Date: 14/Jun/19 19:40 Worklog Time Spent: 10m Work Description: markt-asf commented on pull request #6: DAEMON-243: Failure of Windows service when child process fails URL: https://github.com/apache/commons-daemon/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 260680) Time Spent: 0.5h (was: 20m) > Support for Failure Recovery > > > Key: DAEMON-243 > URL: https://issues.apache.org/jira/browse/DAEMON-243 > Project: Commons Daemon > Issue Type: New Feature > Components: Procrun >Affects Versions: 1.0.10 > Environment: MS Windows >Reporter: Peter Ehrbar >Priority: Minor > Attachments: fail_without_stopped_status.diff > > Time Spent: 0.5h > Remaining Estimate: 0h > > The MS Windows Service Controller provides functionality to perform some > basic failure recovery actions: Restart service or execute any command or > restart the machine. This can be configured using the Service Controller GUI > or in a shell with SC.EXE (commands FAILURE and FAILUREFLAG). > It would be convenient if this could be configured also using procrun. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-daemon] markt-asf closed pull request #6: DAEMON-243: Failure of Windows service when child process fails
markt-asf closed pull request #6: DAEMON-243: Failure of Windows service when child process fails URL: https://github.com/apache/commons-daemon/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-daemon] markt-asf commented on issue #6: DAEMON-243: Failure of Windows service when child process fails
markt-asf commented on issue #6: DAEMON-243: Failure of Windows service when child process fails URL: https://github.com/apache/commons-daemon/pull/6#issuecomment-502238431 This had already been resolved in DAEMON-302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (DAEMON-399) apxStrUnQuoteInplaceA removes needed quotes
[
https://issues.apache.org/jira/browse/DAEMON-399?focusedWorklogId=260678=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-260678
]
ASF GitHub Bot logged work on DAEMON-399:
-
Author: ASF GitHub Bot
Created on: 14/Jun/19 19:39
Start Date: 14/Jun/19 19:39
Worklog Time Spent: 10m
Work Description: markt-asf commented on pull request #9: DAEMON-399:
apxStrUnQuoteInplaceA removes needed quotes
URL: https://github.com/apache/commons-daemon/pull/9
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 260678)
Time Spent: 20m (was: 10m)
> apxStrUnQuoteInplaceA removes needed quotes
> ---
>
> Key: DAEMON-399
> URL: https://issues.apache.org/jira/browse/DAEMON-399
> Project: Commons Daemon
> Issue Type: Bug
> Components: Procrun
>Affects Versions: 1.1.0
>Reporter: Camillo Dell'mour
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When trying to pass the following argument to the jvm
> {code:java}
> -Xlog:gc:file="d:\logs\gc.log"::filecount=5,filesize=2
> {code}
> the method apxStrUnQuoteInplaceA removes " from it and the resulting command
> looks like this:
> {code:java}
> -Xlog:gc:file=d:\logs\gc.log::filecount=5,filesize=2000
> {code}
> Which is an invalid jvm argument.
> Workaround for version 1.1.0 is to add a space into the log filename.
> IMHO the proper fix would be not too use apxStrUnQuoteInplaceA at all.
> Another possible fix would be to replace utils.c:571 with
> {code}
> else if (*p == ' ' || *p == ':') {
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-daemon] markt-asf closed pull request #9: DAEMON-399: apxStrUnQuoteInplaceA removes needed quotes
markt-asf closed pull request #9: DAEMON-399: apxStrUnQuoteInplaceA removes needed quotes URL: https://github.com/apache/commons-daemon/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-daemon] markt-asf commented on issue #9: DAEMON-399: apxStrUnQuoteInplaceA removes needed quotes
markt-asf commented on issue #9: DAEMON-399: apxStrUnQuoteInplaceA removes needed quotes URL: https://github.com/apache/commons-daemon/pull/9#issuecomment-502237941 A variation (that also removed all the unused code) has been applied and will be in 1.1.1 onwards. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (CSV-242) CSVFormat equals() and hashCode() don't use all fields
[ https://issues.apache.org/jira/browse/CSV-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved CSV-242. -- Resolution: Fixed Fixed by: 605bc01 CSV-242 CSVFormat equals() and hash() don't use all fields c683594 CSV-242 CSVFormat equals() and hashCode() don't use all fields 7ddc71c Wrong method name > CSVFormat equals() and hashCode() don't use all fields > -- > > Key: CSV-242 > URL: https://issues.apache.org/jira/browse/CSV-242 > Project: Commons CSV > Issue Type: Bug >Reporter: Sebb >Priority: Major > > It looks like the equals() and hash() methods of CSVFormat were not updated > when some new fields were added, for example: trim > Need to add tests to ensure all fields contribute to equals(). > Best to ensure they all contribute to hash() as well, though that is not > essential. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CSV-242) CSVFormat equals() and hashCode() don't use all fields
[ https://issues.apache.org/jira/browse/CSV-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated CSV-242: - Summary: CSVFormat equals() and hashCode() don't use all fields (was: CSVFormat equals() and hash() don't use all fields) > CSVFormat equals() and hashCode() don't use all fields > -- > > Key: CSV-242 > URL: https://issues.apache.org/jira/browse/CSV-242 > Project: Commons CSV > Issue Type: Bug >Reporter: Sebb >Priority: Major > > It looks like the equals() and hash() methods of CSVFormat were not updated > when some new fields were added, for example: trim > Need to add tests to ensure all fields contribute to equals(). > Best to ensure they all contribute to hash() as well, though that is not > essential. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (DAEMON-397) jsvc on macOS cannot find libjli.dylib when home is OpenJDK 10 or 11
[
https://issues.apache.org/jira/browse/DAEMON-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Thomas resolved DAEMON-397.
Resolution: Fixed
Fix Version/s: 1.1.1
Thanks for the patch. Applied.
> jsvc on macOS cannot find libjli.dylib when home is OpenJDK 10 or 11
>
>
> Key: DAEMON-397
> URL: https://issues.apache.org/jira/browse/DAEMON-397
> Project: Commons Daemon
> Issue Type: Wish
> Components: Jsvc
>Affects Versions: 1.1.0
> Environment: Apple MacOS X 10.13.6
> Xcode 10.1 with Command Line tools installed
>Reporter: Petr Hadraba
>Priority: Minor
> Labels: patch
> Fix For: 1.1.1
>
> Attachments: jdk11-jli.patch
>
>
> When using {{jsvc}} on macOS with custom built OpenJDK 10 or 11 the launcher
> looks for {{libjli.dylib}} in {{../MacOS/}} directory which obviously does
> not exist. The library exists though but in {{lib/jli/}} directory. The
> attached patch adds additional search for this case.
> The patch is against official {{commons-daemon-1.1.0-src.tar.gz}} source
> distribution tar-ball.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-csv] coveralls edited a comment on issue #44: Post release fixes
coveralls edited a comment on issue #44: Post release fixes URL: https://github.com/apache/commons-csv/pull/44#issuecomment-501905854 [](https://coveralls.io/builds/24002845) Coverage increased (+1.7%) to 92.543% when pulling **6b314606b4e432d752b61002fbf3ba44c49cdbda on aherbert:post-release-fixes** into **3718ec3a8e551a08900b3abb5df06791fe2b4a38 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (DAEMON-297) Show jsvc path in debug output
[
https://issues.apache.org/jira/browse/DAEMON-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Thomas resolved DAEMON-297.
Resolution: Fixed
Fix Version/s: 1.1.1
The check for "/" is not validation. Logically, such a request makes no sense.
If the path to the executable is invalid, the executable won't run and the
debug logging will never be seen.
argv[0] has been added to the debug output.
> Show jsvc path in debug output
> --
>
> Key: DAEMON-297
> URL: https://issues.apache.org/jira/browse/DAEMON-297
> Project: Commons Daemon
> Issue Type: Improvement
>Reporter: Sebb
>Priority: Minor
> Fix For: 1.1.1
>
>
> From a question on the user list:
> {code}
> $ jsvc -jvm server -debug -home /usr/lib/jvm/java-6-openjdk -cp
> commons-daemon-1.0.15.jar:api-monitor.jar ApiMonitorDaemon
> +-- DUMPING PARSED COMMAND LINE ARGUMENTS --
> | Detach: True
> | Show Version:No
> | Show Help: No
> | Check Only: Disabled
> | Stop:False
> | Wait:0
> | Run as service: No
> | Install service: No
> | Remove service: No
> | JVM Name:"server"
> | Java Home: "/usr/lib/jvm/java-6-openjdk"
> | PID File:"/var/run/jsvc.pid"
> | User Name: "null"
> | Extra Options: 1
> | "-Djava.class.path=commons-daemon-1.0.15.jar:api-monitor.jar"
> | Class Invoked: "ApiMonitorDaemon"
> | Class Arguments: 0
> +---
> ...
> JSVC re-exec requires execution with an absolute or relative path
> {code}
> Note that the jsvc path is not part of the debug output; it should be, given
> that it is validated.
> The validation result could also be shown in the debug output, for example:
> {code}
> | JSVC path: "jsvc" : path error - must contain /
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-numbers] coveralls edited a comment on issue #48: [WIP] perform the actual migration to JUnit 5
coveralls edited a comment on issue #48: [WIP] perform the actual migration to JUnit 5 URL: https://github.com/apache/commons-numbers/pull/48#issuecomment-500176439 [](https://coveralls.io/builds/24001890) Coverage decreased (-0.03%) to 94.347% when pulling **4fd2f595dcfa188e23ea52cdcee3f8b44a181bc5 on grimreaper:eax/simple-migrate-map** into **934be57412ff6ab9fd67f0eeeddba49895afff06 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (JEXL-305) Script debugger produces incorrect syntax
[
https://issues.apache.org/jira/browse/JEXL-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro resolved JEXL-305.
Resolution: Fixed
Changeset: 4ffa7acc032f58cdf484f4ceae1283111cf1c3b5
Author:henrib
Date: 2019-06-14 17:00
Message: JEXL-305: TemplateDebugger must be able to behave as (script)
Debugger (its superclass) when there are no template expressions
> Script debugger produces incorrect syntax
> -
>
> Key: JEXL-305
> URL: https://issues.apache.org/jira/browse/JEXL-305
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Assignee: Henri Biestro
>Priority: Minor
>
> Consider the following script
> {code:java}
> {while(false) {}; var x = 1;}{code}
> The script parses correctly, but the script debugger produces the following
> code
> {code}
> {
> while (false) {
> } var x = 1;
> }
> {code}
> Because the semicolon after the {{while}} is removed, the block syntax
> becomes invalid
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-numbers] aherbert commented on issue #48: [WIP] perform the actual migration to JUnit 5
aherbert commented on issue #48: [WIP] perform the actual migration to JUnit 5 URL: https://github.com/apache/commons-numbers/pull/48#issuecomment-502141328 @Schamschi I would try locally just removing these lines: ``` org.junit.platform junit-platform-runner test org.junit.vintage junit-vintage-engine test ``` These are to support JUnit 4. If your branch has no JUnit 4 then it should be OK. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (JEXL-305) Script debugger produces incorrect syntax
[
https://issues.apache.org/jira/browse/JEXL-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864163#comment-16864163
]
Henri Biestro edited comment on JEXL-305 at 6/14/19 2:50 PM:
-
Found a regression case using TemplateDebugger.
was (Author: henrib):
Found a regression case.
> Script debugger produces incorrect syntax
> -
>
> Key: JEXL-305
> URL: https://issues.apache.org/jira/browse/JEXL-305
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Assignee: Henri Biestro
>Priority: Minor
>
> Consider the following script
> {code:java}
> {while(false) {}; var x = 1;}{code}
> The script parses correctly, but the script debugger produces the following
> code
> {code}
> {
> while (false) {
> } var x = 1;
> }
> {code}
> Because the semicolon after the {{while}} is removed, the block syntax
> becomes invalid
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (JEXL-305) Script debugger produces incorrect syntax
[
https://issues.apache.org/jira/browse/JEXL-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro reopened JEXL-305:
Found a regression case.
> Script debugger produces incorrect syntax
> -
>
> Key: JEXL-305
> URL: https://issues.apache.org/jira/browse/JEXL-305
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Assignee: Henri Biestro
>Priority: Minor
>
> Consider the following script
> {code:java}
> {while(false) {}; var x = 1;}{code}
> The script parses correctly, but the script debugger produces the following
> code
> {code}
> {
> while (false) {
> } var x = 1;
> }
> {code}
> Because the semicolon after the {{while}} is removed, the block syntax
> becomes invalid
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-csv] aherbert commented on a change in pull request #44: Post release fixes
aherbert commented on a change in pull request #44: Post release fixes
URL: https://github.com/apache/commons-csv/pull/44#discussion_r293838167
##
File path: src/main/java/org/apache/commons/csv/CSVParser.java
##
@@ -495,13 +495,14 @@ private Headers createHeaders() throws IOException {
if (headerRecord != null) {
for (int i = 0; i < headerRecord.length; i++) {
final String header = headerRecord[i];
-final boolean containsHeader = header == null ? false :
hdrMap.containsKey(header);
+final boolean containsHeader = header != null &&
hdrMap.containsKey(header);
final boolean emptyHeader = header == null ||
header.trim().isEmpty();
if (containsHeader) {
if (!emptyHeader &&
!this.format.getAllowDuplicateHeaderNames()) {
throw new IllegalArgumentException(
String.format(
-"The header contains a duplicate name:
\"%s\" in %s. If this is valid then use
CSVFormat.withAllowDuplicateHeaderNames().",
+"The header contains a duplicate name:
\"%s\" in %s. " +
+"If this is valid then use
CSVFormat.withAllowDuplicateHeaderNames().",
Review comment:
I've looked at this again and the logic is a bit convoluted:
The `containsHeader` flag is set when the header is already in the header
map.
The `emptyHeader flag is set when the header is null or only whitespace.
Then there is a check on the `containsHeader` flag. If true then this has
been seen before and some cases are tested.
An exception is thrown if the header is not empty and settings do not allow
duplicates. This means that empty is an allowed duplicate.
An exception is thrown if the header is empty and settings do not allow
missing column names. But this can only be thrown if the header has been seen
before (is in the header map).
This means that a single missing column name would be allowed if the
settings allowed duplicates but not missing column names. This does not seem
right. If missing column names are not allowed then this should always be
checked irrespective of what is in the header map. The unit tests only checks
for two missing column names:
```
// This passes as the exception is thrown
@Test(expected = IllegalArgumentException.class)
public void testHeadersMissingException() throws Exception {
final Reader in = new StringReader("a,,c,,d\n1,2,3,4\nx,y,z,zz");
CSVFormat.DEFAULT.withHeader().parse(in).iterator();
}
// This fails to throw an exception.
// Only 1 column name is missing and this is not recognised as a problem.
@Test(expected = IllegalArgumentException.class)
public void testHeadersMissing1ColumnException() throws Exception {
final Reader in = new StringReader("a,,c,d\n1,2,3,4\nx,y,z,zz");
CSVFormat.DEFAULT.withHeader().parse(in).iterator();
}
```
This seems to be a bug so should be under a Jira ticket.
You also only add to the header map when the header is not null. But if you
are allowing missing column names then a null is a valid header and your list
of header names does not match the order of the header record. Thus
getHeaderNames() will not return a list of the correct size (number of
columns). So perhaps `""` should be added to the list of header names. This is
a change outside the scope of this PR, and since I am not familiar with what
the header names are meant to achieve perhaps this is intended (i.e. only
return a list of header names that are not null).
A final issue is that the header map exists to convert a column header into
an index. If you are allowing duplicates then the mapping is one to many and
the map may not function as expected when trying to obtain the column index
using a column header. Perhaps this hole in functionality should be documented
in the `getHeaderMap` javadoc, i.e. the map of column name to column index
cannot represent a one to many relationship when duplicate column names are
present. This could be solved with user beware documentation that is this case
the map will contain the index of the last matching column with that header if
duplicates have been allowed. Or more drastically by controlling the Map with a
specialisation that does special behaviour when a request with a duplicate
column name occurs: throws an exception; returns as array of all matching
columns, etc. Again outside the scope of this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[jira] [Created] (CSV-243) CSVFormat withTrim() and withIgnoreSurroundingSpaces() need better docs
Sebb created CSV-243: Summary: CSVFormat withTrim() and withIgnoreSurroundingSpaces() need better docs Key: CSV-243 URL: https://issues.apache.org/jira/browse/CSV-243 Project: Commons CSV Issue Type: Bug Reporter: Sebb It looks like withIgnoreSurroundingSpaces() is a parser option and withTrim() is a printer option. These need better Javadoc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CSV-242) CSVFormat equals() and hash() don't use all fields
Sebb created CSV-242: Summary: CSVFormat equals() and hash() don't use all fields Key: CSV-242 URL: https://issues.apache.org/jira/browse/CSV-242 Project: Commons CSV Issue Type: Bug Reporter: Sebb It looks like the equals() and hash() methods of CSVFormat were not updated when some new fields were added, for example: trim Need to add tests to ensure all fields contribute to equals(). Best to ensure they all contribute to hash() as well, though that is not essential. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-numbers] Schamschi commented on issue #48: [WIP] perform the actual migration to JUnit 5
Schamschi commented on issue #48: [WIP] perform the actual migration to JUnit 5 URL: https://github.com/apache/commons-numbers/pull/48#issuecomment-502118743 @grimreaper PR [#36](https://github.com/apache/commons-numbers/pull/36) has been merged into master. Since you said it's OK if the pull request is merged, I completely overwrote the previous version of `FractionTest` from this branch with the new version from master when merging master into this branch, and restored the changes that had been made to `FractionTest` in this branch up to that point. From then on, I migrated the file from scratch, meaning I didn't include any of your later changes (this is exactly the scenario I wanted to avoid by agreeing on which pull request should be merged first before any major changes are performed in this branch that would conflict with the other pull request). I also removed the last unused imports, so the branch is now completely independent of JUnit 4. I, on my part, am finished with this branch. Do you intend to work any further on it? If not, what to do next? Write to the dev mailing list? I guess the pom.xml will have to be modified to remove any dependency related to JUnit 4, but I'm not sure how, since I didn't understand all of the changes made to it when adding JUnit 5 as a dependency alongside JUnit 4. In any case, thank you very much for your help. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (CSV-177) Support trimming leading and trailing blanks
[ https://issues.apache.org/jira/browse/CSV-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864091#comment-16864091 ] Sebb commented on CSV-177: -- AFAICT withTrim() only affects the printer, not the parser > Support trimming leading and trailing blanks > > > Key: CSV-177 > URL: https://issues.apache.org/jira/browse/CSV-177 > Project: Commons CSV > Issue Type: New Feature > Components: Parser, Printer >Affects Versions: 1.2 >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Fix For: 1.3 > > > Support trimming leading and trailing blanks in the printer and parser. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DAEMON-329) Can procrun detect the JVM without consulting the registry
[ https://issues.apache.org/jira/browse/DAEMON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864083#comment-16864083 ] Rod Widdowson commented on DAEMON-329: -- You knew this anyway, but this works like a dream. We'll bundle wirh procrun 1.1.1 as soon as its available. > Can procrun detect the JVM without consulting the registry > -- > > Key: DAEMON-329 > URL: https://issues.apache.org/jira/browse/DAEMON-329 > Project: Commons Daemon > Issue Type: Improvement > Components: Procrun >Affects Versions: 1.0.15 > Environment: Windows Server2012 R2 Java server installed from the > tarball >Reporter: Rod Widdowson >Priority: Minor > Fix For: 1.1.1 > > > For reasons I do not fully comprehend, Oracle distribute the Windows Server > JVM as a tarball. > This means that none of the "usual" registry setting are written. > Our (the Shibboleth protect's) latest IdP release ships with an MSI which > bundles Procrun to launch the J2EE container. We set up the > HKLM\Software\Wow6432Node\Apache Software Key\Procrun 2.0\ appropriately, > specifically setting 'Parameters\Java\JavaHome' appropriately and > 'Parameters\Java\jvm' to 'auto'. I can provide full details available if you > want. > We recently had a customer raise an issue that the autodetect of the jvm.dll > wasn't working. AFAICS this customer installed from the tarball. This is > easily fixed by setting 'jvm' appropriately, and I am modifying our > documentation to explain what to do.. > This RFE is to see if there is anyway that this can be automated inside > procun. It knows the home directory and so it should be able to locate the > jvm.dll. > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CSV-228) CSVParser extracts columns wrong in case of space before quoted col name with comma
[
https://issues.apache.org/jira/browse/CSV-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864038#comment-16864038
]
Gary Gregory commented on CSV-228:
--
We will need a reproducible test case, preferably in the form of a PR. See also
{{org.apache.commons.csv.CSVFormat.withIgnoreSurroundingSpaces(boolean)}}
> CSVParser extracts columns wrong in case of space before quoted col name with
> comma
> ---
>
> Key: CSV-228
> URL: https://issues.apache.org/jira/browse/CSV-228
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.4
>Reporter: Artemii Chugreev
>Priority: Minor
>
> CSV header is something like
> col name 1, "col name 2, with comma", col name 3
> CSVParser#getHeadersMap returns 4 columns, because of space before second
> column name which breaks quoting
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CSV-228) CSVParser extracts columns wrong in case of space before quoted col name with comma
[ https://issues.apache.org/jira/browse/CSV-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864034#comment-16864034 ] Sebb commented on CSV-228: -- According to my reading of RFC4180[1], the fields between delimiters are either either escaped or non-escaped. non-escaped fields can include spaces, but not comma escaped fields must start with the double-quote; leading spaces are not permitted. So I think the current behaviour is per specification, at least for the DEFAULT/RFC4180. [1] https://tools.ietf.org/html/rfc4180 > CSVParser extracts columns wrong in case of space before quoted col name with > comma > --- > > Key: CSV-228 > URL: https://issues.apache.org/jira/browse/CSV-228 > Project: Commons CSV > Issue Type: Bug > Components: Parser >Affects Versions: 1.4 >Reporter: Artemii Chugreev >Priority: Minor > > CSV header is something like > col name 1, "col name 2, with comma", col name 3 > CSVParser#getHeadersMap returns 4 columns, because of space before second > column name which breaks quoting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-csv] garydgregory commented on a change in pull request #44: Post release fixes
garydgregory commented on a change in pull request #44: Post release fixes
URL: https://github.com/apache/commons-csv/pull/44#discussion_r293795559
##
File path: pom.xml
##
@@ -153,8 +153,9 @@ CSV files of various types.
3.0.0
${basedir}/LICENSE-header.txt
-LICENSE.txt,
NOTICE.txt
+LICENSE.txt, NOTICE.txt,
**/maven-archiver/pom.properties
Review comment:
> outside the scope of this PR
Agreed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (CSV-228) CSVParser extracts columns wrong in case of space before quoted col name with comma
[ https://issues.apache.org/jira/browse/CSV-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated CSV-228: - Summary: CSVParser extracts columns wrong in case of space before quoted col name with comma (was: CSVParser exctracts columns wrong in case of space before quoted col name with comma) > CSVParser extracts columns wrong in case of space before quoted col name with > comma > --- > > Key: CSV-228 > URL: https://issues.apache.org/jira/browse/CSV-228 > Project: Commons CSV > Issue Type: Bug > Components: Parser >Affects Versions: 1.4 >Reporter: Artemii Chugreev >Priority: Minor > > CSV header is something like > col name 1, "col name 2, with comma", col name 3 > CSVParser#getHeadersMap returns 4 columns, because of space before second > column name which breaks quoting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-csv] aherbert commented on a change in pull request #44: Post release fixes
aherbert commented on a change in pull request #44: Post release fixes
URL: https://github.com/apache/commons-csv/pull/44#discussion_r293785511
##
File path: pom.xml
##
@@ -153,8 +153,9 @@ CSV files of various types.
3.0.0
${basedir}/LICENSE-header.txt
-LICENSE.txt,
NOTICE.txt
+LICENSE.txt, NOTICE.txt,
**/maven-archiver/pom.properties
Review comment:
AFAICS there is no checkstyle configuration in commons-parent, or PMD. I
thought it was just up to projects to configure as appropriate. Using the maven
plugin property `checkstyle.resourceExcludes` is not done on other commons
projects I know. These use a `` section and ``
tag. There is more than one way to skin a cat.
Are you suggesting to add profiles like those for other optional plugins
such as jacoco? Each project is of a different age and coding style. So a
standard checkstyle probably would not work as is and a transition period to a
common style would be needed. A common style would certainly make browsing
source from different projects easier. I'd say the discussion on this is
outside the scope of this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-csv] aherbert commented on a change in pull request #44: Post release fixes
aherbert commented on a change in pull request #44: Post release fixes
URL: https://github.com/apache/commons-csv/pull/44#discussion_r293781762
##
File path: src/main/java/org/apache/commons/csv/CSVParser.java
##
@@ -495,13 +495,14 @@ private Headers createHeaders() throws IOException {
if (headerRecord != null) {
for (int i = 0; i < headerRecord.length; i++) {
final String header = headerRecord[i];
-final boolean containsHeader = header == null ? false :
hdrMap.containsKey(header);
+final boolean containsHeader = header != null &&
hdrMap.containsKey(header);
final boolean emptyHeader = header == null ||
header.trim().isEmpty();
if (containsHeader) {
if (!emptyHeader &&
!this.format.getAllowDuplicateHeaderNames()) {
throw new IllegalArgumentException(
String.format(
-"The header contains a duplicate name:
\"%s\" in %s. If this is valid then use
CSVFormat.withAllowDuplicateHeaderNames().",
+"The header contains a duplicate name:
\"%s\" in %s. " +
+"If this is valid then use
CSVFormat.withAllowDuplicateHeaderNames().",
Review comment:
OK. This was just to fix checkstyle line length and allow checkstyle:check
to complete. I can put in a checkstyle exclusion instead. But if targeted to a
specific line it is a pain to maintain in-line with the code. Targeted to a
method then the scope of checking is often too wide. I could move these two
checks within the `if (containsHeader)` statement to methods:
```
allowDuplicateHeaderNameOrThrow(boolean emptyHeader)
allowMissingColumnNameOrThrow(boolean emptyHeader)
```
The line length violation will be in a single short method that can then be
allowed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-csv] aherbert commented on a change in pull request #44: Post release fixes
aherbert commented on a change in pull request #44: Post release fixes
URL: https://github.com/apache/commons-csv/pull/44#discussion_r29319
##
File path: src/test/java/org/apache/commons/csv/CSVPrinterTest.java
##
@@ -1471,4 +1471,31 @@ public void testTrimOnTwoColumns() throws IOException {
return CSVParser.parse(expected, format).getRecords().get(0).values();
}
+@Test
+public void testPrintReaderWithoutQuoteToWriter() throws IOException {
+// Test to target the use of IOUtils::copyLarge.
+// Requires the format to have no quote or escape character,
+// value to be a java.io.Reader and the output to be a java.io.Writer.
+final StringWriter sw = new StringWriter();
+final String content = "testValue";
+try (final CSVPrinter printer = new CSVPrinter(sw,
CSVFormat.DEFAULT.withQuote(null))) {
+final StringReader value = new StringReader(content);
+printer.print(value);
+}
+assertEquals(content, sw.toString());
+}
+
+@Test
+public void testPrintReaderWithoutQuoteToAppendable() throws IOException {
+// Test to target the use of IOUtils::copy.
Review comment:
Sure. None of the other methods had Javadoc and when I initially added it as
a Javadoc it was more lines than the 3 lines inside the method. It looked odd.
I'll change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-csv] garydgregory commented on a change in pull request #44: Post release fixes
garydgregory commented on a change in pull request #44: Post release fixes
URL: https://github.com/apache/commons-csv/pull/44#discussion_r293771920
##
File path: pom.xml
##
@@ -153,8 +153,9 @@ CSV files of various types.
3.0.0
${basedir}/LICENSE-header.txt
-LICENSE.txt,
NOTICE.txt
+LICENSE.txt, NOTICE.txt,
**/maven-archiver/pom.properties
Review comment:
Should this also be in commons-parent?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-csv] garydgregory commented on a change in pull request #44: Post release fixes
garydgregory commented on a change in pull request #44: Post release fixes
URL: https://github.com/apache/commons-csv/pull/44#discussion_r293772548
##
File path: src/main/java/org/apache/commons/csv/CSVParser.java
##
@@ -495,13 +495,14 @@ private Headers createHeaders() throws IOException {
if (headerRecord != null) {
for (int i = 0; i < headerRecord.length; i++) {
final String header = headerRecord[i];
-final boolean containsHeader = header == null ? false :
hdrMap.containsKey(header);
+final boolean containsHeader = header != null &&
hdrMap.containsKey(header);
final boolean emptyHeader = header == null ||
header.trim().isEmpty();
if (containsHeader) {
if (!emptyHeader &&
!this.format.getAllowDuplicateHeaderNames()) {
throw new IllegalArgumentException(
String.format(
-"The header contains a duplicate name:
\"%s\" in %s. If this is valid then use
CSVFormat.withAllowDuplicateHeaderNames().",
+"The header contains a duplicate name:
\"%s\" in %s. " +
+"If this is valid then use
CSVFormat.withAllowDuplicateHeaderNames().",
Review comment:
I am not a fan of programatically building strings this when the ONLY
purpose is line length. It can also give one the impression there is an EOL
when there is none.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-csv] garydgregory commented on a change in pull request #44: Post release fixes
garydgregory commented on a change in pull request #44: Post release fixes
URL: https://github.com/apache/commons-csv/pull/44#discussion_r293772905
##
File path: src/test/java/org/apache/commons/csv/CSVPrinterTest.java
##
@@ -1471,4 +1471,31 @@ public void testTrimOnTwoColumns() throws IOException {
return CSVParser.parse(expected, format).getRecords().get(0).values();
}
+@Test
+public void testPrintReaderWithoutQuoteToWriter() throws IOException {
+// Test to target the use of IOUtils::copyLarge.
Review comment:
Should this be a method comment (Javadoc or plain)?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-csv] garydgregory commented on a change in pull request #44: Post release fixes
garydgregory commented on a change in pull request #44: Post release fixes
URL: https://github.com/apache/commons-csv/pull/44#discussion_r293772934
##
File path: src/test/java/org/apache/commons/csv/CSVPrinterTest.java
##
@@ -1471,4 +1471,31 @@ public void testTrimOnTwoColumns() throws IOException {
return CSVParser.parse(expected, format).getRecords().get(0).values();
}
+@Test
+public void testPrintReaderWithoutQuoteToWriter() throws IOException {
+// Test to target the use of IOUtils::copyLarge.
+// Requires the format to have no quote or escape character,
+// value to be a java.io.Reader and the output to be a java.io.Writer.
+final StringWriter sw = new StringWriter();
+final String content = "testValue";
+try (final CSVPrinter printer = new CSVPrinter(sw,
CSVFormat.DEFAULT.withQuote(null))) {
+final StringReader value = new StringReader(content);
+printer.print(value);
+}
+assertEquals(content, sw.toString());
+}
+
+@Test
+public void testPrintReaderWithoutQuoteToAppendable() throws IOException {
+// Test to target the use of IOUtils::copy.
Review comment:
Should this be a method comment (Javadoc or plain)?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-csv] garydgregory commented on a change in pull request #44: Post release fixes
garydgregory commented on a change in pull request #44: Post release fixes
URL: https://github.com/apache/commons-csv/pull/44#discussion_r293772010
##
File path: pom.xml
##
@@ -202,6 +203,31 @@ CSV files of various types.
false
+
+
+org.codehaus.mojo
+findbugs-maven-plugin
+${commons.findbugs.version}
+
+ Normal
+ Default
+
${basedir}/src/main/resources/findbugs/findbugs-exclude-filter.xml
+
+
+
+
+org.apache.maven.plugins
+maven-pmd-plugin
+${pmd.version}
+
+ ${maven.compiler.target}
+ false
+ true
+
+
${basedir}/src/main/resources/pmd/pmd-ruleset.xml
+
+
+
Review comment:
Should this also be in commons-parent?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (DAEMON-329) Can procrun detect the JVM without consulting the registry
[ https://issues.apache.org/jira/browse/DAEMON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863859#comment-16863859 ] Rod Widdowson commented on DAEMON-329: -- Awesome mark. Thanks. > Can procrun detect the JVM without consulting the registry > -- > > Key: DAEMON-329 > URL: https://issues.apache.org/jira/browse/DAEMON-329 > Project: Commons Daemon > Issue Type: Improvement > Components: Procrun >Affects Versions: 1.0.15 > Environment: Windows Server2012 R2 Java server installed from the > tarball >Reporter: Rod Widdowson >Priority: Minor > Fix For: 1.1.1 > > > For reasons I do not fully comprehend, Oracle distribute the Windows Server > JVM as a tarball. > This means that none of the "usual" registry setting are written. > Our (the Shibboleth protect's) latest IdP release ships with an MSI which > bundles Procrun to launch the J2EE container. We set up the > HKLM\Software\Wow6432Node\Apache Software Key\Procrun 2.0\ appropriately, > specifically setting 'Parameters\Java\JavaHome' appropriately and > 'Parameters\Java\jvm' to 'auto'. I can provide full details available if you > want. > We recently had a customer raise an issue that the autodetect of the jvm.dll > wasn't working. AFAICS this customer installed from the tarball. This is > easily fixed by setting 'jvm' appropriately, and I am modifying our > documentation to explain what to do.. > This RFE is to see if there is anyway that this can be automated inside > procun. It knows the home directory and so it should be able to locate the > jvm.dll. > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DAEMON-329) Can procrun detect the JVM without consulting the registry
[ https://issues.apache.org/jira/browse/DAEMON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863833#comment-16863833 ] Mark Thomas commented on DAEMON-329: It should work for any value of JavaHome under the procrun registry key where the path to the dll is bin/server/jvm.dll whcih should work for both JREs and JDKs. Test build isn't that much work. Here you go: [http://people.apache.org/~markt/dev/apache-commons-daemon-1.1.1-dev/] Usual caveats apply. This isn't an official Apache release. It is for testing purposes only. If you use it and your server catches fire don't blame me etc. > Can procrun detect the JVM without consulting the registry > -- > > Key: DAEMON-329 > URL: https://issues.apache.org/jira/browse/DAEMON-329 > Project: Commons Daemon > Issue Type: Improvement > Components: Procrun >Affects Versions: 1.0.15 > Environment: Windows Server2012 R2 Java server installed from the > tarball >Reporter: Rod Widdowson >Priority: Minor > Fix For: 1.1.1 > > > For reasons I do not fully comprehend, Oracle distribute the Windows Server > JVM as a tarball. > This means that none of the "usual" registry setting are written. > Our (the Shibboleth protect's) latest IdP release ships with an MSI which > bundles Procrun to launch the J2EE container. We set up the > HKLM\Software\Wow6432Node\Apache Software Key\Procrun 2.0\ appropriately, > specifically setting 'Parameters\Java\JavaHome' appropriately and > 'Parameters\Java\jvm' to 'auto'. I can provide full details available if you > want. > We recently had a customer raise an issue that the autodetect of the jvm.dll > wasn't working. AFAICS this customer installed from the tarball. This is > easily fixed by setting 'jvm' appropriately, and I am modifying our > documentation to explain what to do.. > This RFE is to see if there is anyway that this can be automated inside > procun. It knows the home directory and so it should be able to locate the > jvm.dll. > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DAEMON-329) Can procrun detect the JVM without consulting the registry
[ https://issues.apache.org/jira/browse/DAEMON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863784#comment-16863784 ] Rod Widdowson commented on DAEMON-329: -- [~markt], can I ask a follow up question? Just this week [I got a report|https://issues.shibboleth.net/jira/browse/IDP-1466] that there are similar issues with JDKs. It feels like the JDK is going to be deployed by end users more and more these days, so I stopped ignoring this issue. Is there a chance that the fix for this also handles JDK distributions? And if so do you have a list somewhere of Distros that are known/assumed/tested to work? Finally, is it work catching an intermeidate build of this and testing it or should I just way for 1.1 to ship? Thanks > Can procrun detect the JVM without consulting the registry > -- > > Key: DAEMON-329 > URL: https://issues.apache.org/jira/browse/DAEMON-329 > Project: Commons Daemon > Issue Type: Improvement > Components: Procrun >Affects Versions: 1.0.15 > Environment: Windows Server2012 R2 Java server installed from the > tarball >Reporter: Rod Widdowson >Priority: Minor > Fix For: 1.1.1 > > > For reasons I do not fully comprehend, Oracle distribute the Windows Server > JVM as a tarball. > This means that none of the "usual" registry setting are written. > Our (the Shibboleth protect's) latest IdP release ships with an MSI which > bundles Procrun to launch the J2EE container. We set up the > HKLM\Software\Wow6432Node\Apache Software Key\Procrun 2.0\ appropriately, > specifically setting 'Parameters\Java\JavaHome' appropriately and > 'Parameters\Java\jvm' to 'auto'. I can provide full details available if you > want. > We recently had a customer raise an issue that the autodetect of the jvm.dll > wasn't working. AFAICS this customer installed from the tarball. This is > easily fixed by setting 'jvm' appropriately, and I am modifying our > documentation to explain what to do.. > This RFE is to see if there is anyway that this can be automated inside > procun. It knows the home directory and so it should be able to locate the > jvm.dll. > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
