[jira] [Comment Edited] (CB-8041) "org.apache.cordova.statusbar" plugin not work with Android greater or equal than 4.1
[ https://issues.apache.org/jira/browse/CB-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243658#comment-14243658 ] Colin Bau edited comment on CB-8041 at 12/12/14 3:23 AM: - hi Andrew well... I am using PGB 3.6.3 with this 3rd plugin https://build.phonegap.com/plugins/715 Android 4.0.X is work,show and hide function work perfect (it mean that really can show or hide the status bar when I use related method) https://github.com/apache/cordova-plugin-statusbar/blob/bdbaf129595c4a4e3d957a1bc218d05dc5f82a9e/README.md but... Android 4.1.X is not work (it mean that have no any response,therefore,not work at all) Android 4.2.X is not work (With the above...) Android 4.3.X have no device to test (With the above...) Android 4.4.X is not work (With the above...) was (Author: bau720123): hi Andrew well... I am using PGB 3.6.3 with this 3rd plugin https://build.phonegap.com/plugins/715 Android 4.0.X is work,show and hide function work perfect (it mean that really can show or hide the status bar) but... Android 4.1.X is not work (it mean that have no any response,therefore,not work at all) Android 4.2.X is not work (With the above...) Android 4.3.X have no device to test (With the above...) Android 4.4.X is not work (With the above...) > "org.apache.cordova.statusbar" plugin not work with Android greater or equal > than 4.1 > - > > Key: CB-8041 > URL: https://issues.apache.org/jira/browse/CB-8041 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 3.6.3 > Environment: Android 4.0 > Android 4.1 > Android 4.2 > Android 4.4 >Reporter: Colin Bau > Labels: statusbar-plugin > > I am using this plugin in PGB 3.6.3 with all latest core plugin > https://build.phonegap.com/plugins/715 > https://build.phonegap.com/plugins/core > according to this > https://github.com/apache/cordova-plugin-statusbar/blob/bdbaf129595c4a4e3d957a1bc218d05dc5f82a9e/README.md > "StatusBar.hide" and "StatusBar.show" are supported by Android > but I tried in different situation,Android have some problem (but ios and > winphone are totally work) > Android 4.0.X is work,show and hide function work perfect > but... > Android 4.1.X is not work > Android 4.2.X is not work > Android 4.3.X have no device to test > Android 4.4.X is not work -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8041) "org.apache.cordova.statusbar" plugin not work with Android greater or equal than 4.1
[ https://issues.apache.org/jira/browse/CB-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243658#comment-14243658 ] Colin Bau commented on CB-8041: --- hi Andrew well... I am using PGB 3.6.3 with this 3rd plugin https://build.phonegap.com/plugins/715 Android 4.0.X is work,show and hide function work perfect (it mean that really can show or hide the status bar) but... Android 4.1.X is not work (it mean that have no any response,therefore,not work at all) Android 4.2.X is not work (With the above...) Android 4.3.X have no device to test (With the above...) Android 4.4.X is not work (With the above...) > "org.apache.cordova.statusbar" plugin not work with Android greater or equal > than 4.1 > - > > Key: CB-8041 > URL: https://issues.apache.org/jira/browse/CB-8041 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 3.6.3 > Environment: Android 4.0 > Android 4.1 > Android 4.2 > Android 4.4 >Reporter: Colin Bau > Labels: statusbar-plugin > > I am using this plugin in PGB 3.6.3 with all latest core plugin > https://build.phonegap.com/plugins/715 > https://build.phonegap.com/plugins/core > according to this > https://github.com/apache/cordova-plugin-statusbar/blob/bdbaf129595c4a4e3d957a1bc218d05dc5f82a9e/README.md > "StatusBar.hide" and "StatusBar.show" are supported by Android > but I tried in different situation,Android have some problem (but ios and > winphone are totally work) > Android 4.0.X is work,show and hide function work perfect > but... > Android 4.1.X is not work > Android 4.2.X is not work > Android 4.3.X have no device to test > Android 4.4.X is not work -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8041) "org.apache.cordova.statusbar" plugin not work with Android greater or equal than 4.1
[ https://issues.apache.org/jira/browse/CB-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243654#comment-14243654 ] Andrey Kurdyumov commented on CB-8041: -- Could you explain how it is not working, does not hides when called 'hide()' method and not shown when called 'show()'. Also which other plugins you are using? > "org.apache.cordova.statusbar" plugin not work with Android greater or equal > than 4.1 > - > > Key: CB-8041 > URL: https://issues.apache.org/jira/browse/CB-8041 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 3.6.3 > Environment: Android 4.0 > Android 4.1 > Android 4.2 > Android 4.4 >Reporter: Colin Bau > Labels: statusbar-plugin > > I am using this plugin in PGB 3.6.3 with all latest core plugin > https://build.phonegap.com/plugins/715 > https://build.phonegap.com/plugins/core > according to this > https://github.com/apache/cordova-plugin-statusbar/blob/bdbaf129595c4a4e3d957a1bc218d05dc5f82a9e/README.md > "StatusBar.hide" and "StatusBar.show" are supported by Android > but I tried in different situation,Android have some problem (but ios and > winphone are totally work) > Android 4.0.X is work,show and hide function work perfect > but... > Android 4.1.X is not work > Android 4.2.X is not work > Android 4.3.X have no device to test > Android 4.4.X is not work -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7937) Re-factor iOS Camera plugin so that it is testable
[ https://issues.apache.org/jira/browse/CB-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243550#comment-14243550 ] ASF GitHub Bot commented on CB-7937: Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/52#issuecomment-66718848 Depends on the above issue PR before this can be pulled in. All tests must pass. > Re-factor iOS Camera plugin so that it is testable > -- > > Key: CB-7937 > URL: https://issues.apache.org/jira/browse/CB-7937 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Camera > Environment: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > > Right now the UIImagePickerController callback is a monolithic mess. > Re-factor so that it is testable using XCUnit tests. targetSize desperately > needs unit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8060) Unable to deploy to Windows Phone 8 device
[ https://issues.apache.org/jira/browse/CB-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243529#comment-14243529 ] Jesse MacFadyen commented on CB-8060: - Oliver, can you post the results of running {{cordova run wp8 -d --device}} There should be more verbose output in that case. > Unable to deploy to Windows Phone 8 device > -- > > Key: CB-8060 > URL: https://issues.apache.org/jira/browse/CB-8060 > Project: Apache Cordova > Issue Type: Bug > Components: WP8 >Affects Versions: 3.7.0 > Environment: Windows 8.1 Pro x64 >Reporter: Oliver Salzburg >Assignee: Jesse MacFadyen > > Running {{cordova run wp8}} will always start an emulator. > Running {{platforms/wp8/cordova/run --device}} will give the following output > {code} > $ platforms/wp8/cordova/run --device > Building project: d:/eu.fairmanager.mobile/platforms/wp8/FairManager.sln > Configuration : debug > Platform : any cpu > Building the projects in this solution one at a time. To enable parallel > build, please add the "/m" switch. > FairManager -> > d:\eu.fairmanager.mobile\platforms\wp8\Bin\Debug\eu.fairmanager.mobile.dll > Begin application manifest generation > No changes detected. Application manifest file is up to date > Begin Xap packaging > No changes detected. Xap package is up to date > Deploying package to device > Error: The parameter is incorrect. > XapDeployCmd - Help > Syntax: > XapDeployCmd.exe > >- Specifies the command to be executed (one of the following) > /installlaunch - installs and launches the application on the > device. >(requires Xap Filename) > /update- updates application already installed on device >(requires Xap Filename) > /launch- launches application installed on the device >(requires product-id) > /uninstall - uninstalls the application from the device >(requires product-id) > /EnumerateDevices - lists the valid device targets along with their >device indices. >- Specifies the GUID of the product. This is located in > WMAppManifest.xml file of the project >- Specifies the full path of Xap to be installed/updated. >- Specifies the target device (one of the following) > xd- default emulator > de- Windows Phone device connected to the desktop > n - device listed at index n. To get the list of devices > use the following command > "XapDeployCmd.exe /EnumerateDevices" > Examples: (assuming product id is f8ce6878-0aeb-497f-bcf4-65be961d4bba and > XapFilePath is D:\PhoneApp1.xap) > XapDeployCmd.exe /installlaunch D:\PhoneApp1.xap /targetdevice:xd > - installs PhoneApp1 on the default emulator and then launches it > XapDeployCmd.exe /launch f8ce6878-0aeb-497f-bcf4-65be961d4bba > /targetdevice:de > - launches the app with specified product id on the device > XapDeployCmd.exe /update D:\PhoneApp1.xap /targetdevice:2 > - updates PhoneApp1 already installed on the device > specified by device index 2. To get the list of valid indices use > the EnumerateDevices command > XapDeployCmd.exe /uninstall f8ce6878-0aeb-497f-bcf4-65be961d4bba > /targetdevice:xd > - uninstalls the app with specified product id from the default emulator > XapDeployCmd.exe /EnumerateDevices > - enumerates the list of valid device targets along with their > corresponding device index > ERROR: Error code -2147024809 for command: C:\Program Files (x86)\Microsoft > SDKs\Windows Phone\v8.0\Tools\Xap Deployment\XapDeployCmd.exe with args: > /installlau > nch,d:/eu.fairmanager.mobile/platforms/wp8/Bin/debug/CordovaAppProj_Debug_AnyCPU.xap,/targetdevice:de > {code} > The project deploys fine to the device when using Visual Studio. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-8032) Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory:
[ https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243450#comment-14243450 ] Shazron Abdullah edited comment on CB-8032 at 12/12/14 1:03 AM: Here's my research into the 6 plugins needing changes: h4. 1. cordova-plugin-camera *DONE* - in PR h4. 2. cordova-plugin-file *DONE* - in PR h4. 3. cordova-plugin-file-transfer *NO CHANGE* - connection:didFinishLoading:, handled by CDVFile h4. 4. cordova-plugin-media *NO CHANGE* - file urls are used internally only. h4. 5. cordova-plugin-media-capture *NO CHANGE* - full paths are sent back through the API, not urls. Users use the File API to get native urls? h4. 6. cordova-plugin-contacts *NO CHANGE* - the only paths returned are from extractPhotos, and even though the type is 'url' it's actually a file path. Users use the File API to get native urls? was (Author: shazron): Here's my research into the 6 plugins needing changes: h4. 1. cordova-plugin-camera *PENDING* - file URI returned needs to be transformed h4. 2. cordova-plugin-file *DONE* - in PR h4. 3. cordova-plugin-file-transfer *NO CHANGE* - connection:didFinishLoading:, handled by CDVFile h4. 4. cordova-plugin-media *NO CHANGE* - file urls are used internally only. h4. 5. cordova-plugin-media-capture *NO CHANGE* - full paths are sent back through the API, not urls. Users use the File API to get native urls? h4. 6. cordova-plugin-contacts *NO CHANGE* - the only paths returned are from extractPhotos, and even though the type is 'url' it's actually a file path. Users use the File API to get native urls? > Add nativeURL external method support for > CDVFileSystem->makeEntryForPath:isDirectory: > -- > > Key: CB-8032 > URL: https://issues.apache.org/jira/browse/CB-8032 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File > Transfer, Plugin Media, Plugin Media Capture > Environment: iOS >Reporter: Shazron Abdullah > > Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the > NSDictionary that is returned, for the key "nativeURL" the format is fixed > (file:// protocol for a local filesystem reference, and assets-library:/ for > a assets library filesystem reference.) > When calculating the nativeURL, allow this to be specified externally, check > for a selector "nativeURL" and call that if available. > This is for example declared in a Category in this plugin: > https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m > ... which when linked will have the selector available for the File plugin to > call. > This code is part of the local webserver plugin - and it needs the File > references to be proxied through a local webserver. > For example if the FileEntry is to: > > file://my/package/folder/Documents/foo.txt > .. the nativeURL would be, with this new category method, and the local > webserver listening to http://localhost:8080: > http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8032) Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory:
[ https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243493#comment-14243493 ] ASF GitHub Bot commented on CB-8032: GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/57 CB-8032 - Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory: Depends on CB-7937. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-plugin-camera CB-8032 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit dc2d7c580115df3ec2e5911924022b51e5e314ca Author: Shazron Abdullah Date: 2014-11-05T20:19:42Z CB-7937 - Re-factor iOS Camera plugin so that it is testable commit 66e5dd7aeb443e4c4160a32806339320a1e18d51 Author: Shazron Abdullah Date: 2014-12-12T00:42:02Z CB-8032 - Camera Plugin - Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory: > Add nativeURL external method support for > CDVFileSystem->makeEntryForPath:isDirectory: > -- > > Key: CB-8032 > URL: https://issues.apache.org/jira/browse/CB-8032 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File > Transfer, Plugin Media, Plugin Media Capture > Environment: iOS >Reporter: Shazron Abdullah > > Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the > NSDictionary that is returned, for the key "nativeURL" the format is fixed > (file:// protocol for a local filesystem reference, and assets-library:/ for > a assets library filesystem reference.) > When calculating the nativeURL, allow this to be specified externally, check > for a selector "nativeURL" and call that if available. > This is for example declared in a Category in this plugin: > https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m > ... which when linked will have the selector available for the File plugin to > call. > This code is part of the local webserver plugin - and it needs the File > references to be proxied through a local webserver. > For example if the FileEntry is to: > > file://my/package/folder/Documents/foo.txt > .. the nativeURL would be, with this new category method, and the local > webserver listening to http://localhost:8080: > http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8032) Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory:
[ https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243450#comment-14243450 ] Shazron Abdullah commented on CB-8032: -- Here's my research into the 6 plugins needing changes: h4. 1. cordova-plugin-camera *PENDING* - file URI returned needs to be transformed h4. 2. cordova-plugin-file *DONE* - in PR h4. 3. cordova-plugin-file-transfer *NO CHANGE* - connection:didFinishLoading:, handled by CDVFile h4. 4. cordova-plugin-media *NO CHANGE* - file urls are used internally only. h4. 5. cordova-plugin-media-capture *NO CHANGE* - full paths are sent back through the API, not urls. Users use the File API to get native urls? h4. 6. cordova-plugin-contacts *NO CHANGE* - the only paths returned are from extractPhotos, and even though the type is 'url' it's actually a file path. Users use the File API to get native urls? > Add nativeURL external method support for > CDVFileSystem->makeEntryForPath:isDirectory: > -- > > Key: CB-8032 > URL: https://issues.apache.org/jira/browse/CB-8032 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File > Transfer, Plugin Media, Plugin Media Capture > Environment: iOS >Reporter: Shazron Abdullah > > Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the > NSDictionary that is returned, for the key "nativeURL" the format is fixed > (file:// protocol for a local filesystem reference, and assets-library:/ for > a assets library filesystem reference.) > When calculating the nativeURL, allow this to be specified externally, check > for a selector "nativeURL" and call that if available. > This is for example declared in a Category in this plugin: > https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m > ... which when linked will have the selector available for the File plugin to > call. > This code is part of the local webserver plugin - and it needs the File > references to be proxied through a local webserver. > For example if the FileEntry is to: > > file://my/package/folder/Documents/foo.txt > .. the nativeURL would be, with this new category method, and the local > webserver listening to http://localhost:8080: > http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-8032) Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory:
[ https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220041#comment-14220041 ] Shazron Abdullah edited comment on CB-8032 at 12/12/14 12:21 AM: - Submitting a PR for review with a revised approach soon, for discussion. Also, from my research, there are additional core plugins that require URL transformations, for a total of 6: * -cordova-plugin-camera- PENDING - file URI returned needs to be transformed * -cordova-plugin-file- DONE in PR * -cordova-plugin-file-transfer- (connection:didFinishLoading:, handled by CDVFile) * -cordova-plugin-media- (file urls are used internally only) * -cordova-plugin-media-capture- (full paths are sent back through the API, not urls) * -cordova-plugin-contacts- (the only paths returned are from extractPhotos, and even though the type is 'url' it's actually a file path) There are also potentially third-party plugins that require those URL transformations as well, and we need to come up with a general purpose solution. There is no way the LocalWebServer can know about all plugins so it can set a delegate on each. So the alternative is that for each plugin that returns a file URL needs to call a delegate to transform their URLs. This delegate has to be in a common location, either in CDVViewController or the commandDelegate. I'm leaning towards the commandDelegate. This approach however requires all plugins to be updated to support this new approach. It can be non-intrusive -- the plugin will check for the selector being available, and if it is call it to transform their URL (demonstrated in the closed PR above). Ideally we could use NSURLProtocol to intercept any requests and transform them (as suggested by Tony Homer), but NSURLProtocol does not work with WKWebView. was (Author: shazron): Submitting a PR for review with a revised approach soon, for discussion. Also, from my research, there are additional core plugins that require URL transformations, for a total of 6: * cordova-plugin-camera * -cordova-plugin-file- * -cordova-plugin-file-transfer- (connection:didFinishLoading:, handled by CDVFile) * -cordova-plugin-media- (file urls are used internally only) * -cordova-plugin-media-capture- (full paths are sent back through the API, not urls) * -cordova-plugin-contacts- (the only paths returned are from extractPhotos, and even though the type is 'url' it's actually a file path) There are also potentially third-party plugins that require those URL transformations as well, and we need to come up with a general purpose solution. There is no way the LocalWebServer can know about all plugins so it can set a delegate on each. So the alternative is that for each plugin that returns a file URL needs to call a delegate to transform their URLs. This delegate has to be in a common location, either in CDVViewController or the commandDelegate. I'm leaning towards the commandDelegate. This approach however requires all plugins to be updated to support this new approach. It can be non-intrusive -- the plugin will check for the selector being available, and if it is call it to transform their URL (demonstrated in the closed PR above). Ideally we could use NSURLProtocol to intercept any requests and transform them (as suggested by Tony Homer), but NSURLProtocol does not work with WKWebView. > Add nativeURL external method support for > CDVFileSystem->makeEntryForPath:isDirectory: > -- > > Key: CB-8032 > URL: https://issues.apache.org/jira/browse/CB-8032 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File > Transfer, Plugin Media, Plugin Media Capture > Environment: iOS >Reporter: Shazron Abdullah > > Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the > NSDictionary that is returned, for the key "nativeURL" the format is fixed > (file:// protocol for a local filesystem reference, and assets-library:/ for > a assets library filesystem reference.) > When calculating the nativeURL, allow this to be specified externally, check > for a selector "nativeURL" and call that if available. > This is for example declared in a Category in this plugin: > https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m > ... which when linked will have the selector available for the File plugin to > call. > This code is part of the local webserver plugin - and it needs the File > references to be proxied through a local webserver. > For example if the FileEntry is to: > > file://my/package/folder/Documents/foo.txt > .. the nativeURL would be, with this new category metho
[jira] [Comment Edited] (CB-8032) Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory:
[ https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220041#comment-14220041 ] Shazron Abdullah edited comment on CB-8032 at 12/12/14 12:08 AM: - Submitting a PR for review with a revised approach soon, for discussion. Also, from my research, there are additional core plugins that require URL transformations, for a total of 6: * cordova-plugin-camera * -cordova-plugin-file- * -cordova-plugin-file-transfer- (connection:didFinishLoading:, handled by CDVFile) * -cordova-plugin-media- (file urls are used internally only) * -cordova-plugin-media-capture- (full paths are sent back through the API, not urls) * -cordova-plugin-contacts- (the only paths returned are from extractPhotos, and even though the type is 'url' it's actually a file path) There are also potentially third-party plugins that require those URL transformations as well, and we need to come up with a general purpose solution. There is no way the LocalWebServer can know about all plugins so it can set a delegate on each. So the alternative is that for each plugin that returns a file URL needs to call a delegate to transform their URLs. This delegate has to be in a common location, either in CDVViewController or the commandDelegate. I'm leaning towards the commandDelegate. This approach however requires all plugins to be updated to support this new approach. It can be non-intrusive -- the plugin will check for the selector being available, and if it is call it to transform their URL (demonstrated in the closed PR above). Ideally we could use NSURLProtocol to intercept any requests and transform them (as suggested by Tony Homer), but NSURLProtocol does not work with WKWebView. was (Author: shazron): Submitting a PR for review with a revised approach soon, for discussion. Also, from my research, there are additional core plugins that require URL transformations, for a total of 6: * cordova-plugin-camera * -cordova-plugin-file- * -cordova-plugin-file-transfer- (connection:didFinishLoading:, handled by CDVFile) * -cordova-plugin-media- (file urls are used internally only) * -cordova-plugin-media-capture- (full paths are sent back through the API, not urls) * cordova-plugin-contacts There are also potentially third-party plugins that require those URL transformations as well, and we need to come up with a general purpose solution. There is no way the LocalWebServer can know about all plugins so it can set a delegate on each. So the alternative is that for each plugin that returns a file URL needs to call a delegate to transform their URLs. This delegate has to be in a common location, either in CDVViewController or the commandDelegate. I'm leaning towards the commandDelegate. This approach however requires all plugins to be updated to support this new approach. It can be non-intrusive -- the plugin will check for the selector being available, and if it is call it to transform their URL (demonstrated in the closed PR above). Ideally we could use NSURLProtocol to intercept any requests and transform them (as suggested by Tony Homer), but NSURLProtocol does not work with WKWebView. > Add nativeURL external method support for > CDVFileSystem->makeEntryForPath:isDirectory: > -- > > Key: CB-8032 > URL: https://issues.apache.org/jira/browse/CB-8032 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File > Transfer, Plugin Media, Plugin Media Capture > Environment: iOS >Reporter: Shazron Abdullah > > Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the > NSDictionary that is returned, for the key "nativeURL" the format is fixed > (file:// protocol for a local filesystem reference, and assets-library:/ for > a assets library filesystem reference.) > When calculating the nativeURL, allow this to be specified externally, check > for a selector "nativeURL" and call that if available. > This is for example declared in a Category in this plugin: > https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m > ... which when linked will have the selector available for the File plugin to > call. > This code is part of the local webserver plugin - and it needs the File > references to be proxied through a local webserver. > For example if the FileEntry is to: > > file://my/package/folder/Documents/foo.txt > .. the nativeURL would be, with this new category method, and the local > webserver listening to http://localhost:8080: > http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt -- This message was sent by
[jira] [Comment Edited] (CB-8032) Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory:
[ https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220041#comment-14220041 ] Shazron Abdullah edited comment on CB-8032 at 12/11/14 11:53 PM: - Submitting a PR for review with a revised approach soon, for discussion. Also, from my research, there are additional core plugins that require URL transformations, for a total of 6: * cordova-plugin-camera * -cordova-plugin-file- * -cordova-plugin-file-transfer- (connection:didFinishLoading:, handled by CDVFile) * -cordova-plugin-media- (file urls are used internally only) * -cordova-plugin-media-capture- (full paths are sent back through the API, not urls) * cordova-plugin-contacts There are also potentially third-party plugins that require those URL transformations as well, and we need to come up with a general purpose solution. There is no way the LocalWebServer can know about all plugins so it can set a delegate on each. So the alternative is that for each plugin that returns a file URL needs to call a delegate to transform their URLs. This delegate has to be in a common location, either in CDVViewController or the commandDelegate. I'm leaning towards the commandDelegate. This approach however requires all plugins to be updated to support this new approach. It can be non-intrusive -- the plugin will check for the selector being available, and if it is call it to transform their URL (demonstrated in the closed PR above). Ideally we could use NSURLProtocol to intercept any requests and transform them (as suggested by Tony Homer), but NSURLProtocol does not work with WKWebView. was (Author: shazron): Submitting a PR for review with a revised approach soon, for discussion. Also, from my research, there are additional core plugins that require URL transformations, for a total of 6: * cordova-plugin-camera * -cordova-plugin-file- * -cordova-plugin-file-transfer- (connection:didFinishLoading:, handled by CDVFile) * -cordova-plugin-media- (file urls are used internally only) * cordova-plugin-media-capture * cordova-plugin-contacts There are also potentially third-party plugins that require those URL transformations as well, and we need to come up with a general purpose solution. There is no way the LocalWebServer can know about all plugins so it can set a delegate on each. So the alternative is that for each plugin that returns a file URL needs to call a delegate to transform their URLs. This delegate has to be in a common location, either in CDVViewController or the commandDelegate. I'm leaning towards the commandDelegate. This approach however requires all plugins to be updated to support this new approach. It can be non-intrusive -- the plugin will check for the selector being available, and if it is call it to transform their URL (demonstrated in the closed PR above). Ideally we could use NSURLProtocol to intercept any requests and transform them (as suggested by Tony Homer), but NSURLProtocol does not work with WKWebView. > Add nativeURL external method support for > CDVFileSystem->makeEntryForPath:isDirectory: > -- > > Key: CB-8032 > URL: https://issues.apache.org/jira/browse/CB-8032 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File > Transfer, Plugin Media, Plugin Media Capture > Environment: iOS >Reporter: Shazron Abdullah > > Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the > NSDictionary that is returned, for the key "nativeURL" the format is fixed > (file:// protocol for a local filesystem reference, and assets-library:/ for > a assets library filesystem reference.) > When calculating the nativeURL, allow this to be specified externally, check > for a selector "nativeURL" and call that if available. > This is for example declared in a Category in this plugin: > https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m > ... which when linked will have the selector available for the File plugin to > call. > This code is part of the local webserver plugin - and it needs the File > references to be proxied through a local webserver. > For example if the FileEntry is to: > > file://my/package/folder/Documents/foo.txt > .. the nativeURL would be, with this new category method, and the local > webserver listening to http://localhost:8080: > http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For add
[jira] [Comment Edited] (CB-8032) Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory:
[ https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220041#comment-14220041 ] Shazron Abdullah edited comment on CB-8032 at 12/11/14 11:27 PM: - Submitting a PR for review with a revised approach soon, for discussion. Also, from my research, there are additional core plugins that require URL transformations, for a total of 6: * cordova-plugin-camera * -cordova-plugin-file- * -cordova-plugin-file-transfer- (connection:didFinishLoading:, handled by CDVFile) * -cordova-plugin-media- (file urls are used internally only) * cordova-plugin-media-capture * cordova-plugin-contacts There are also potentially third-party plugins that require those URL transformations as well, and we need to come up with a general purpose solution. There is no way the LocalWebServer can know about all plugins so it can set a delegate on each. So the alternative is that for each plugin that returns a file URL needs to call a delegate to transform their URLs. This delegate has to be in a common location, either in CDVViewController or the commandDelegate. I'm leaning towards the commandDelegate. This approach however requires all plugins to be updated to support this new approach. It can be non-intrusive -- the plugin will check for the selector being available, and if it is call it to transform their URL (demonstrated in the closed PR above). Ideally we could use NSURLProtocol to intercept any requests and transform them (as suggested by Tony Homer), but NSURLProtocol does not work with WKWebView. was (Author: shazron): Submitting a PR for review with a revised approach soon, for discussion. Also, from my research, there are additional core plugins that require URL transformations, for a total of 6: * cordova-plugin-camera * -cordova-plugin-file- * -cordova-plugin-file-transfer- (connection:didFinishLoading:, handled by CDVFile) * cordova-plugin-media * cordova-plugin-media-capture * cordova-plugin-contacts There are also potentially third-party plugins that require those URL transformations as well, and we need to come up with a general purpose solution. There is no way the LocalWebServer can know about all plugins so it can set a delegate on each. So the alternative is that for each plugin that returns a file URL needs to call a delegate to transform their URLs. This delegate has to be in a common location, either in CDVViewController or the commandDelegate. I'm leaning towards the commandDelegate. This approach however requires all plugins to be updated to support this new approach. It can be non-intrusive -- the plugin will check for the selector being available, and if it is call it to transform their URL (demonstrated in the closed PR above). Ideally we could use NSURLProtocol to intercept any requests and transform them (as suggested by Tony Homer), but NSURLProtocol does not work with WKWebView. > Add nativeURL external method support for > CDVFileSystem->makeEntryForPath:isDirectory: > -- > > Key: CB-8032 > URL: https://issues.apache.org/jira/browse/CB-8032 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File > Transfer, Plugin Media, Plugin Media Capture > Environment: iOS >Reporter: Shazron Abdullah > > Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the > NSDictionary that is returned, for the key "nativeURL" the format is fixed > (file:// protocol for a local filesystem reference, and assets-library:/ for > a assets library filesystem reference.) > When calculating the nativeURL, allow this to be specified externally, check > for a selector "nativeURL" and call that if available. > This is for example declared in a Category in this plugin: > https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m > ... which when linked will have the selector available for the File plugin to > call. > This code is part of the local webserver plugin - and it needs the File > references to be proxied through a local webserver. > For example if the FileEntry is to: > > file://my/package/folder/Documents/foo.txt > .. the nativeURL would be, with this new category method, and the local > webserver listening to http://localhost:8080: > http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8001) StatusBar Plugin 0.1.8 crashes application on tap
[ https://issues.apache.org/jira/browse/CB-8001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Smith updated CB-8001: - Attachment: status-bar-test.zip Hi [~IvanKarpan], I have attached an example project which I could replicate this issue with. > StatusBar Plugin 0.1.8 crashes application on tap > - > > Key: CB-8001 > URL: https://issues.apache.org/jira/browse/CB-8001 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 3.7.0 > Environment: StatusBar Plugin 0.1.8 > Cordova iOS 3.7.0 > iPhone 6+ (8.0) > iPhone 5s (8.0) >Reporter: Nathan Smith >Priority: Critical > Attachments: status-bar-test.zip > > > StatusBar Plugin 0.1.8 > Cordova iOS 3.7.0 > iPhone 6+ (8.0) > iPhone 5s (8.0) > The StatusBar encounters an {{EXC_BAD_ACCESS}} exception when the user taps > on the StatusBar. > The call site affected is {{fireTappedEvent}} {{\[self.commandDelegate > sendPluginResult:result callbackId:_eventsCallbackId\];}} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8152) Remove deprecated methods in Media plugin (deprecated since 2.5)
[ https://issues.apache.org/jira/browse/CB-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243248#comment-14243248 ] ASF subversion and git services commented on CB-8152: - Commit ab6563aa2bc5b988fc0c3ff7f7c401c987a0d184 in cordova-plugin-media's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=ab6563a ] CB-8152 - Remove deprecated methods in Media plugin (deprecated since 2.5) > Remove deprecated methods in Media plugin (deprecated since 2.5) > > > Key: CB-8152 > URL: https://issues.apache.org/jira/browse/CB-8152 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media > Environment: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8152) Remove deprecated methods in Media plugin (deprecated since 2.5)
[ https://issues.apache.org/jira/browse/CB-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-8152. -- Resolution: Fixed > Remove deprecated methods in Media plugin (deprecated since 2.5) > > > Key: CB-8152 > URL: https://issues.apache.org/jira/browse/CB-8152 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media > Environment: iOS >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8152) Remove deprecated methods in Media plugin (deprecated since 2.5)
Shazron Abdullah created CB-8152: Summary: Remove deprecated methods in Media plugin (deprecated since 2.5) Key: CB-8152 URL: https://issues.apache.org/jira/browse/CB-8152 Project: Apache Cordova Issue Type: Bug Components: Plugin Media Environment: iOS Reporter: Shazron Abdullah Assignee: Shazron Abdullah -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-8037) Deprecation warning in Media plugin (CDVSound.m)
[ https://issues.apache.org/jira/browse/CB-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah reassigned CB-8037: Assignee: Shazron Abdullah > Deprecation warning in Media plugin (CDVSound.m) > > > Key: CB-8037 > URL: https://issues.apache.org/jira/browse/CB-8037 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 3.6.3 > Environment: iOS >Reporter: Matt Grande >Assignee: Shazron Abdullah > > Note: For version, I included my crrently installed version of Cordova. I'm > currently using the Media plugin 0.2.13, but the problem persists in 0.2.14. > XCode is giving me a deprecation warning in {{CDVSound.m}}. The message is: > bq. 'toSuccessCallbackString:' is deprecated: Deprecated in Cordova 3.6. Use > CDVCommandDelegate method sendPluginResult:callbackId instead. This will be > removed in 4.0.0 > And here is the offending line in {{getCurrentPositionAudio}}: > {{NSString* jsString = \[NSString > stringWithFormat:@"%@(\"%@\",%d,%.3f);\n%@", > @"cordova.require('org.apache.cordova.media.Media').onStatus", mediaId, > MEDIA_POSITION, position, \[result toSuccessCallbackString:callbackId\]\];}} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-8032) Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory:
[ https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220041#comment-14220041 ] Shazron Abdullah edited comment on CB-8032 at 12/11/14 9:55 PM: Submitting a PR for review with a revised approach soon, for discussion. Also, from my research, there are additional core plugins that require URL transformations, for a total of 6: * cordova-plugin-camera * -cordova-plugin-file- * -cordova-plugin-file-transfer- (connection:didFinishLoading:, handled by CDVFile) * cordova-plugin-media * cordova-plugin-media-capture * cordova-plugin-contacts There are also potentially third-party plugins that require those URL transformations as well, and we need to come up with a general purpose solution. There is no way the LocalWebServer can know about all plugins so it can set a delegate on each. So the alternative is that for each plugin that returns a file URL needs to call a delegate to transform their URLs. This delegate has to be in a common location, either in CDVViewController or the commandDelegate. I'm leaning towards the commandDelegate. This approach however requires all plugins to be updated to support this new approach. It can be non-intrusive -- the plugin will check for the selector being available, and if it is call it to transform their URL (demonstrated in the closed PR above). Ideally we could use NSURLProtocol to intercept any requests and transform them (as suggested by Tony Homer), but NSURLProtocol does not work with WKWebView. was (Author: shazron): Submitting a PR for review with a revised approach soon, for discussion. Also, from my research, there are additional core plugins that require URL transformations, for a total of 6: * cordova-plugin-camera * cordova-plugin-file * cordova-plugin-file-transfer * cordova-plugin-media * cordova-plugin-media-capture * cordova-plugin-contacts There are also potentially third-party plugins that require those URL transformations as well, and we need to come up with a general purpose solution. There is no way the LocalWebServer can know about all plugins so it can set a delegate on each. So the alternative is that for each plugin that returns a file URL needs to call a delegate to transform their URLs. This delegate has to be in a common location, either in CDVViewController or the commandDelegate. I'm leaning towards the commandDelegate. This approach however requires all plugins to be updated to support this new approach. It can be non-intrusive -- the plugin will check for the selector being available, and if it is call it to transform their URL (demonstrated in the closed PR above). Ideally we could use NSURLProtocol to intercept any requests and transform them (as suggested by Tony Homer), but NSURLProtocol does not work with WKWebView. > Add nativeURL external method support for > CDVFileSystem->makeEntryForPath:isDirectory: > -- > > Key: CB-8032 > URL: https://issues.apache.org/jira/browse/CB-8032 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File > Transfer, Plugin Media, Plugin Media Capture > Environment: iOS >Reporter: Shazron Abdullah > > Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the > NSDictionary that is returned, for the key "nativeURL" the format is fixed > (file:// protocol for a local filesystem reference, and assets-library:/ for > a assets library filesystem reference.) > When calculating the nativeURL, allow this to be specified externally, check > for a selector "nativeURL" and call that if available. > This is for example declared in a Category in this plugin: > https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m > ... which when linked will have the selector available for the File plugin to > call. > This code is part of the local webserver plugin - and it needs the File > references to be proxied through a local webserver. > For example if the FileEntry is to: > > file://my/package/folder/Documents/foo.txt > .. the nativeURL would be, with this new category method, and the local > webserver listening to http://localhost:8080: > http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8032) Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory:
[ https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243166#comment-14243166 ] Shazron Abdullah commented on CB-8032: -- File plugin pull request added above, tested. I'll use the same model for the other 5 plugins. > Add nativeURL external method support for > CDVFileSystem->makeEntryForPath:isDirectory: > -- > > Key: CB-8032 > URL: https://issues.apache.org/jira/browse/CB-8032 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File > Transfer, Plugin Media, Plugin Media Capture > Environment: iOS >Reporter: Shazron Abdullah > > Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the > NSDictionary that is returned, for the key "nativeURL" the format is fixed > (file:// protocol for a local filesystem reference, and assets-library:/ for > a assets library filesystem reference.) > When calculating the nativeURL, allow this to be specified externally, check > for a selector "nativeURL" and call that if available. > This is for example declared in a Category in this plugin: > https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m > ... which when linked will have the selector available for the File plugin to > call. > This code is part of the local webserver plugin - and it needs the File > references to be proxied through a local webserver. > For example if the FileEntry is to: > > file://my/package/folder/Documents/foo.txt > .. the nativeURL would be, with this new category method, and the local > webserver listening to http://localhost:8080: > http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8032) Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory:
[ https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243162#comment-14243162 ] ASF GitHub Bot commented on CB-8032: GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-file/pull/96 CB-8032 - File Plugin - Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory: - backwards compatible - if urlTransformer is not set, it will return the passed in NSURL You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-plugin-file CB-8032- Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/96.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #96 commit 93b17a4c7f674269922f5511104dd60cddcd1461 Author: Shazron Abdullah Date: 2014-12-11T21:03:34Z CB-8032 - File Plugin - Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory: > Add nativeURL external method support for > CDVFileSystem->makeEntryForPath:isDirectory: > -- > > Key: CB-8032 > URL: https://issues.apache.org/jira/browse/CB-8032 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File > Transfer, Plugin Media, Plugin Media Capture > Environment: iOS >Reporter: Shazron Abdullah > > Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the > NSDictionary that is returned, for the key "nativeURL" the format is fixed > (file:// protocol for a local filesystem reference, and assets-library:/ for > a assets library filesystem reference.) > When calculating the nativeURL, allow this to be specified externally, check > for a selector "nativeURL" and call that if available. > This is for example declared in a Category in this plugin: > https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m > ... which when linked will have the selector available for the File plugin to > call. > This code is part of the local webserver plugin - and it needs the File > references to be proxied through a local webserver. > For example if the FileEntry is to: > > file://my/package/folder/Documents/foo.txt > .. the nativeURL would be, with this new category method, and the local > webserver listening to http://localhost:8080: > http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8032) Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory:
[ https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243136#comment-14243136 ] ASF subversion and git services commented on CB-8032: - Commit 93b17a4c7f674269922f5511104dd60cddcd1461 in cordova-plugin-file's branch refs/heads/CB-8032 from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=93b17a4 ] CB-8032 - File Plugin - Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory: > Add nativeURL external method support for > CDVFileSystem->makeEntryForPath:isDirectory: > -- > > Key: CB-8032 > URL: https://issues.apache.org/jira/browse/CB-8032 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File > Transfer, Plugin Media, Plugin Media Capture > Environment: iOS >Reporter: Shazron Abdullah > > Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the > NSDictionary that is returned, for the key "nativeURL" the format is fixed > (file:// protocol for a local filesystem reference, and assets-library:/ for > a assets library filesystem reference.) > When calculating the nativeURL, allow this to be specified externally, check > for a selector "nativeURL" and call that if available. > This is for example declared in a Category in this plugin: > https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m > ... which when linked will have the selector available for the File plugin to > call. > This code is part of the local webserver plugin - and it needs the File > references to be proxied through a local webserver. > For example if the FileEntry is to: > > file://my/package/folder/Documents/foo.txt > .. the nativeURL would be, with this new category method, and the local > webserver listening to http://localhost:8080: > http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7955) Add cordova-plugin-dialogs support for browser platform
[ https://issues.apache.org/jira/browse/CB-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243119#comment-14243119 ] ASF GitHub Bot commented on CB-7955: Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66686970 Here is [the corresponding JIRA issue](https://issues.apache.org/jira/browse/CB-7955) > Add cordova-plugin-dialogs support for browser platform > --- > > Key: CB-7955 > URL: https://issues.apache.org/jira/browse/CB-7955 > Project: Apache Cordova > Issue Type: Sub-task > Components: Browser >Reporter: Sergey Shakhnazarov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8032) Add nativeURL external method support for CDVFileSystem->makeEntryForPath:isDirectory:
[ https://issues.apache.org/jira/browse/CB-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243118#comment-14243118 ] ASF subversion and git services commented on CB-8032: - Commit b52ca7396afc2b9e9c9245d1d5e36f169fd51658 in cordova-plugins's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugins.git;h=b52ca73 ] CB-8032 - assets-library url transform fix. > Add nativeURL external method support for > CDVFileSystem->makeEntryForPath:isDirectory: > -- > > Key: CB-8032 > URL: https://issues.apache.org/jira/browse/CB-8032 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Camera, Plugin Contacts, Plugin File, Plugin File > Transfer, Plugin Media, Plugin Media Capture > Environment: iOS >Reporter: Shazron Abdullah > > Right now in CDVFileSystem->makeEntryForPath:isDirectory:, in the > NSDictionary that is returned, for the key "nativeURL" the format is fixed > (file:// protocol for a local filesystem reference, and assets-library:/ for > a assets library filesystem reference.) > When calculating the nativeURL, allow this to be specified externally, check > for a selector "nativeURL" and call that if available. > This is for example declared in a Category in this plugin: > https://github.com/apache/cordova-plugins/blob/5d8ef21dcbde1f99d60e1b52ae3a3800e4c185d9/local-webserver/src/ios/CDVLocalFileSystem%2BNativeURL.m > ... which when linked will have the selector available for the File plugin to > call. > This code is part of the local webserver plugin - and it needs the File > references to be proxied through a local webserver. > For example if the FileEntry is to: > > file://my/package/folder/Documents/foo.txt > .. the nativeURL would be, with this new category method, and the local > webserver listening to http://localhost:8080: > http://localhost:8080/local-filesystem/my/package/folder/Documents/foo.txt -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8151) --copy-from cannot work w/ remote urls on the cli (but can programatically)
Brian LeRoux created CB-8151: Summary: --copy-from cannot work w/ remote urls on the cli (but can programatically) Key: CB-8151 URL: https://issues.apache.org/jira/browse/CB-8151 Project: Apache Cordova Issue Type: Bug Components: CordovaLib Reporter: Brian LeRoux It's this code in cli.js - ```var customWww = args['copy-from'] || args['link-to']; if (customWww) { if (customWww.indexOf('http') === 0) { throw new CordovaError( 'Only local paths for custom www assets are supported.' ); } ``` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8110) Plugins Release Dec 2, 2014
[ https://issues.apache.org/jira/browse/CB-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-8110. Resolution: Fixed > Plugins Release Dec 2, 2014 > --- > > Key: CB-8110 > URL: https://issues.apache.org/jira/browse/CB-8110 > Project: Apache Cordova > Issue Type: Task >Reporter: Steve Gill >Assignee: Steve Gill > > "Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md"; -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8080) After migrating to 3.6.3 from 3.4.0, Appium (Android) tests fail because of open dialog
[ https://issues.apache.org/jira/browse/CB-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243036#comment-14243036 ] Andrea Tino commented on CB-8080: - I am sorry, I thought the meaning was: "blocker to my activity". > After migrating to 3.6.3 from 3.4.0, Appium (Android) tests fail because of > open dialog > --- > > Key: CB-8080 > URL: https://issues.apache.org/jira/browse/CB-8080 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaJS >Affects Versions: 3.6.3 > Environment: Basic Appium test on Android webview based app. The test > on Appium works until the app issues a `window.location.reload()` or a > `window.location.href = 'something'`. >Reporter: Andrea Tino > Labels: javascript > Attachments: MyApp-debug.apk > > > After upgrading to Cordova 3.6.3 from Cordova 3.4.0; my Appium tests cannot > go on because of a strange error. The error can be reproed very easily by > creating a basic web-view based app on Android which issues a > {{window.location.reload()}} after a while that the test starts. > I could assess that the problem is one particular file: {{cordova.js}} which > becomes part of the js files in my app when I build it with Cordova. My app > loads only one javascript file: {{cordova.js}}, I removed all other > dependencies to other js files. When that file is in my app (even though > {{index.html}} does not use any function defined in there), my tests fails. > If I remove the dependencies to that file, tests go ok! > The problem is that when my app issues a {{window.location.reload()}}; my > test fail with this error message: > {code} > info: [debug] Responding to client with error: > {"status":26,"value":{"message":"A modal dialog was open, blocking this > operation","origValue":"unexpected alert open\n (Session info: webview=)\n > (Driver info: chromedriver=2.10.267521,platform=Windows NT 6.3 > x86_64)"},"sessionId":"965ba51e54f682559e5b8378095bc3d4"} > {code} > *Test* > The APK to repro this is in attachments. It is possible to run a simple > Appium test to repro the problem: > {code} > [Test] > public void SimpleTest() > { > this.appPackage = "com.myorg.myapp"; > this.appActivity = "myapp"; > BeforeAll(); > Thread.Sleep(3000); > var submitAddressButton = > driver.FindElementByClassName("testClass"); > submitAddressButton.Click(); > Thread.Sleep(3000); > submitAddressButton = driver.FindElementByClassName("testClass"); > Expect(submitAddressButton, Is.Not.Null); > } > {code} > *Important* > The fact that a dialog is reported is actually very strange. After inspecting > a lot I could verify that no native/webview dialog is being shown on my app. > In fact I cannot see any dialog and if I try to dismiss this ghost dialog > using Appium and WebDriver APIs, the command fail as no dialog can be found. > *Notes* > Consider that the problem is not in the APIs I use in my test (C# dotnet > driver for Appium). Everything happens on my Appium server running on a Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-6575) Completely re-write Whitelist Test
[ https://issues.apache.org/jira/browse/CB-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-6575: --- Assignee: Ian Clelland I think you did this already. > Completely re-write Whitelist Test > -- > > Key: CB-6575 > URL: https://issues.apache.org/jira/browse/CB-6575 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android >Reporter: Joe Bowser >Assignee: Ian Clelland > Fix For: 4.0.0 > > > The Whitelist Test is totally obsolete, due to the new webview setup. We > probably should re-think this test. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8026) Apps targeting LOLLIPOP or later default to disallowing third party cookies
[ https://issues.apache.org/jira/browse/CB-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-8026: --- Fix Version/s: 4.0.0 > Apps targeting LOLLIPOP or later default to disallowing third party cookies > --- > > Key: CB-8026 > URL: https://issues.apache.org/jira/browse/CB-8026 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 4.0.0 >Reporter: jan >Assignee: Joe Bowser > Fix For: 4.0.0 > > > Apps that target KITKAT or below default to allowing third party cookies. > Apps targeting LOLLIPOP or later default to disallowing third party cookies. > https://developer.android.com/reference/android/webkit/CookieManager.html > Android 5.0 changes the default behavior for your app. > If your app targets API level 21 or higher: > The system blocks mixed content and third party cookies by default. To allow > mixed content and third party cookies, use the setMixedContentMode() and > setAcceptThirdPartyCookies() methods respectively. > The system now intelligently chooses portions of the HTML document to draw. > This new default behavior helps to reduce memory footprint and increase > performance. If you want to render the whole document at once, disable this > optimization by calling enableSlowWholeDocumentDraw(). > If your app targets API levels lower than 21: The system allows mixed content > and third party cookies, and always renders the whole document at once. > https://developer.android.com/about/versions/android-5.0-changes.html#BehaviorWebView > Workaround in the "Comments" section... -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8080) After migrating to 3.6.3 from 3.4.0, Appium (Android) tests fail because of open dialog
[ https://issues.apache.org/jira/browse/CB-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243006#comment-14243006 ] Joe Bowser commented on CB-8080: This isn't a blocker. > After migrating to 3.6.3 from 3.4.0, Appium (Android) tests fail because of > open dialog > --- > > Key: CB-8080 > URL: https://issues.apache.org/jira/browse/CB-8080 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaJS >Affects Versions: 3.6.3 > Environment: Basic Appium test on Android webview based app. The test > on Appium works until the app issues a `window.location.reload()` or a > `window.location.href = 'something'`. >Reporter: Andrea Tino > Labels: javascript > Attachments: MyApp-debug.apk > > > After upgrading to Cordova 3.6.3 from Cordova 3.4.0; my Appium tests cannot > go on because of a strange error. The error can be reproed very easily by > creating a basic web-view based app on Android which issues a > {{window.location.reload()}} after a while that the test starts. > I could assess that the problem is one particular file: {{cordova.js}} which > becomes part of the js files in my app when I build it with Cordova. My app > loads only one javascript file: {{cordova.js}}, I removed all other > dependencies to other js files. When that file is in my app (even though > {{index.html}} does not use any function defined in there), my tests fails. > If I remove the dependencies to that file, tests go ok! > The problem is that when my app issues a {{window.location.reload()}}; my > test fail with this error message: > {code} > info: [debug] Responding to client with error: > {"status":26,"value":{"message":"A modal dialog was open, blocking this > operation","origValue":"unexpected alert open\n (Session info: webview=)\n > (Driver info: chromedriver=2.10.267521,platform=Windows NT 6.3 > x86_64)"},"sessionId":"965ba51e54f682559e5b8378095bc3d4"} > {code} > *Test* > The APK to repro this is in attachments. It is possible to run a simple > Appium test to repro the problem: > {code} > [Test] > public void SimpleTest() > { > this.appPackage = "com.myorg.myapp"; > this.appActivity = "myapp"; > BeforeAll(); > Thread.Sleep(3000); > var submitAddressButton = > driver.FindElementByClassName("testClass"); > submitAddressButton.Click(); > Thread.Sleep(3000); > submitAddressButton = driver.FindElementByClassName("testClass"); > Expect(submitAddressButton, Is.Not.Null); > } > {code} > *Important* > The fact that a dialog is reported is actually very strange. After inspecting > a lot I could verify that no native/webview dialog is being shown on my app. > In fact I cannot see any dialog and if I try to dismiss this ghost dialog > using Appium and WebDriver APIs, the command fail as no dialog can be found. > *Notes* > Consider that the problem is not in the APIs I use in my test (C# dotnet > driver for Appium). Everything happens on my Appium server running on a Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8080) After migrating to 3.6.3 from 3.4.0, Appium (Android) tests fail because of open dialog
[ https://issues.apache.org/jira/browse/CB-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-8080: --- Priority: Major (was: Blocker) > After migrating to 3.6.3 from 3.4.0, Appium (Android) tests fail because of > open dialog > --- > > Key: CB-8080 > URL: https://issues.apache.org/jira/browse/CB-8080 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaJS >Affects Versions: 3.6.3 > Environment: Basic Appium test on Android webview based app. The test > on Appium works until the app issues a `window.location.reload()` or a > `window.location.href = 'something'`. >Reporter: Andrea Tino > Labels: javascript > Attachments: MyApp-debug.apk > > > After upgrading to Cordova 3.6.3 from Cordova 3.4.0; my Appium tests cannot > go on because of a strange error. The error can be reproed very easily by > creating a basic web-view based app on Android which issues a > {{window.location.reload()}} after a while that the test starts. > I could assess that the problem is one particular file: {{cordova.js}} which > becomes part of the js files in my app when I build it with Cordova. My app > loads only one javascript file: {{cordova.js}}, I removed all other > dependencies to other js files. When that file is in my app (even though > {{index.html}} does not use any function defined in there), my tests fails. > If I remove the dependencies to that file, tests go ok! > The problem is that when my app issues a {{window.location.reload()}}; my > test fail with this error message: > {code} > info: [debug] Responding to client with error: > {"status":26,"value":{"message":"A modal dialog was open, blocking this > operation","origValue":"unexpected alert open\n (Session info: webview=)\n > (Driver info: chromedriver=2.10.267521,platform=Windows NT 6.3 > x86_64)"},"sessionId":"965ba51e54f682559e5b8378095bc3d4"} > {code} > *Test* > The APK to repro this is in attachments. It is possible to run a simple > Appium test to repro the problem: > {code} > [Test] > public void SimpleTest() > { > this.appPackage = "com.myorg.myapp"; > this.appActivity = "myapp"; > BeforeAll(); > Thread.Sleep(3000); > var submitAddressButton = > driver.FindElementByClassName("testClass"); > submitAddressButton.Click(); > Thread.Sleep(3000); > submitAddressButton = driver.FindElementByClassName("testClass"); > Expect(submitAddressButton, Is.Not.Null); > } > {code} > *Important* > The fact that a dialog is reported is actually very strange. After inspecting > a lot I could verify that no native/webview dialog is being shown on my app. > In fact I cannot see any dialog and if I try to dismiss this ghost dialog > using Appium and WebDriver APIs, the command fail as no dialog can be found. > *Notes* > Consider that the problem is not in the APIs I use in my test (C# dotnet > driver for Appium). Everything happens on my Appium server running on a Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8150) Add a `--noprepare` flag to `cordova run`
sandstrom created CB-8150: - Summary: Add a `--noprepare` flag to `cordova run` Key: CB-8150 URL: https://issues.apache.org/jira/browse/CB-8150 Project: Apache Cordova Issue Type: Improvement Components: CLI Affects Versions: 4.0.0 Reporter: sandstrom Priority: Minor `cordova run` has the excellent `--nobuild` flag, which makes it possible to skip building (if cordova build was called manually). Similarly, it would be neat if a `--noprepare` flag was available. This allows for more fine-grained control over run. In our case, we want to do adjustments to files after calling `cordova prepare` (similar to the hooks, but we've implemented it a bit differently), and this is impossible since `cordova run` will call `prepare`, undoing our changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8147) build script should not fail for unrecognized parameters
[ https://issues.apache.org/jira/browse/CB-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242944#comment-14242944 ] ASF subversion and git services commented on CB-8147: - Commit 3aca14d5306811985354486a434d7819ea2357cc in cordova-android's branch refs/heads/4.0.x from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=3aca14d ] CB-8147 Have corodva/build warn about unrecognized flags rather than fail Close #127 > build script should not fail for unrecognized parameters > > > Key: CB-8147 > URL: https://issues.apache.org/jira/browse/CB-8147 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > As reported in https://github.com/apache/cordova-android/pull/127. > Specifically: --device and --emulator exist for ios but not android. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8079) Load splashscreen resource dependend on app package name not activity class package name
[ https://issues.apache.org/jira/browse/CB-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242945#comment-14242945 ] ASF subversion and git services commented on CB-8079: - Commit 56a3ee5fe66c4eb0ac67b2f258d4f1f9a0536ff8 in cordova-android's branch refs/heads/4.0.x from [~cnsdato] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=56a3ee5 ] CB-8079 Use activity class package name, but fallback to application package name when looking for splash screen drawable Close #136 > Load splashscreen resource dependend on app package name not activity class > package name > > > Key: CB-8079 > URL: https://issues.apache.org/jira/browse/CB-8079 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Daniel Toplak >Assignee: Andrew Grieve > > The splashscreen resource images are loaded by the package name of the > activity class. This works as long as the app package name is the same which > is the default. > But when someone is building several apps out of the the same activity class > package, then the resources are no longer found. They should be loaded via > the app package name, which should also work in the default scenario. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7734) "navigator.notification.alert" or "navigator.notification.confirm" seem have a "many words" issue
[ https://issues.apache.org/jira/browse/CB-7734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242881#comment-14242881 ] Colin Bau commented on CB-7734: --- hi jcesarmobile thanks for your reply...I will try so... is there any specific time that merged with the official repository ? > "navigator.notification.alert" or "navigator.notification.confirm" seem have > a "many words" issue > - > > Key: CB-7734 > URL: https://issues.apache.org/jira/browse/CB-7734 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Dialogs >Affects Versions: 3.6.3 > Environment: PGB 3.6.3 with the all latest core plugin > https://build.phonegap.com/plugins > ios 8.02 environment >Reporter: Colin Bau >Assignee: jcesarmobile > Labels: notification > Original Estimate: 12h > Remaining Estimate: 12h > > Improvement 1 > according to this > https://issues.apache.org/jira/browse/CB-6528 > a same problem just like the WP,ios have this problem too > when the words is greater than one page > it can't slide up and down > Improvement 2 > all words "center" problem,I think maybe "Left-aligned" is more Beautiful > (because when in Android,all words "Left-aligned") > http://www.littlebau.com/ios_1.png > Improvement 3 > all words looks like small and Vague (maybe in Chinese),is there any way > (maybe future) can let become more Clear ? > http://www.littlebau.com/ios_1.png -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6637) Remove deprecated method in CDVWebViewDelegate
[ https://issues.apache.org/jira/browse/CB-6637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242833#comment-14242833 ] ASF GitHub Bot commented on CB-6637: Github user IvanKarpan commented on the pull request: https://github.com/apache/cordova-ios/pull/121#issuecomment-66657870 Just FYI I received the acknowledgment regarding my ICLA. So my contribution can be officially reviewed and accepted (or rejected but let me know what I should fix). > Remove deprecated method in CDVWebViewDelegate > -- > > Key: CB-6637 > URL: https://issues.apache.org/jira/browse/CB-6637 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Shazron Abdullah > Fix For: 3.8.0 > > > - (BOOL)request:(NSURLRequest*)newRequest > isFragmentIdentifierToRequest:(NSURLRequest*)originalRequest > Deprecated in 3.5.0 -- 3 release policy, means in 3.8.0 it will be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-7968) ConcurrentModificationException in postMessage
[ https://issues.apache.org/jira/browse/CB-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242765#comment-14242765 ] Lyubomir Gospodinov edited comment on CB-7968 at 12/11/14 4:44 PM: --- In my case, this happens when I call appView.loadUrl from inside a plugin's initialize method. Workaround is calling loadUrlIntoView(url, false) in order NOT to recreate plugins. was (Author: lubogospod): In my case, this happens when I call appView.loadUrl from inside a plugin. Workaround is calling loadUrlIntoView(url, false) in order NOT to recreate plugins. > ConcurrentModificationException in postMessage > -- > > Key: CB-7968 > URL: https://issues.apache.org/jira/browse/CB-7968 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.5.0 > Environment: Nexus 7 (2G) razorg >Reporter: Clayton Grassick > > Crash observed in Cordova messaging code: > java.util.ConcurrentModificationException > at java.util.HashMap$HashIterator.nextEntry(HashMap.java:806) > at java.util.HashMap$ValueIterator.next(HashMap.java:838) > at org.apache.cordova.PluginManager.postMessage(PluginManager.java:271) > at org.apache.cordova.CordovaWebView.postMessage(CordovaWebView.java:528) > at org.apache.cordova.App$1.run(App.java:78) > at android.os.Handler.handleCallback(Handler.java:733) > at android.os.Handler.dispatchMessage(Handler.java:95) > at android.os.Looper.loop(Looper.java:136) > at android.app.ActivityThread.main(ActivityThread.java:5017) > at java.lang.reflect.Method.invokeNative(Native Method) > at java.lang.reflect.Method.invoke(Method.java:515) > at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) > at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) > at dalvik.system.NativeStart.main(Native Method) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7968) ConcurrentModificationException in postMessage
[ https://issues.apache.org/jira/browse/CB-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242765#comment-14242765 ] Lyubomir Gospodinov commented on CB-7968: - In my case, this happens when I call appView.loadUrl from inside a plugin. Workaround is calling loadUrlIntoView(url, false) in order NOT to recreate plugins. > ConcurrentModificationException in postMessage > -- > > Key: CB-7968 > URL: https://issues.apache.org/jira/browse/CB-7968 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.5.0 > Environment: Nexus 7 (2G) razorg >Reporter: Clayton Grassick > > Crash observed in Cordova messaging code: > java.util.ConcurrentModificationException > at java.util.HashMap$HashIterator.nextEntry(HashMap.java:806) > at java.util.HashMap$ValueIterator.next(HashMap.java:838) > at org.apache.cordova.PluginManager.postMessage(PluginManager.java:271) > at org.apache.cordova.CordovaWebView.postMessage(CordovaWebView.java:528) > at org.apache.cordova.App$1.run(App.java:78) > at android.os.Handler.handleCallback(Handler.java:733) > at android.os.Handler.dispatchMessage(Handler.java:95) > at android.os.Looper.loop(Looper.java:136) > at android.app.ActivityThread.main(ActivityThread.java:5017) > at java.lang.reflect.Method.invokeNative(Native Method) > at java.lang.reflect.Method.invoke(Method.java:515) > at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) > at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) > at dalvik.system.NativeStart.main(Native Method) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8096) Under Windows device motion auto tests failed if accelerometer doesn't exist on this device
[ https://issues.apache.org/jira/browse/CB-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242760#comment-14242760 ] ASF GitHub Bot commented on CB-8096: Github user dmitriy-barkalov commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/22#issuecomment-66645522 Could anybody please review this. > Under Windows device motion auto tests failed if accelerometer doesn't exist > on this device > > > Key: CB-8096 > URL: https://issues.apache.org/jira/browse/CB-8096 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec, Plugin Device Motion >Reporter: Maria Bukharina > > Proposed to pend that tests if accelerometer doesn't exist on the device -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-7968) ConcurrentModificationException in postMessage
[ https://issues.apache.org/jira/browse/CB-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-7968. --- Resolution: Duplicate Didn't realize this had already been filed as an issue. Ran into it myself as well and committed a fix (for 3.7.0-dev). Scarily, looks like the issue has been around pretty much forever! > ConcurrentModificationException in postMessage > -- > > Key: CB-7968 > URL: https://issues.apache.org/jira/browse/CB-7968 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.5.0 > Environment: Nexus 7 (2G) razorg >Reporter: Clayton Grassick > > Crash observed in Cordova messaging code: > java.util.ConcurrentModificationException > at java.util.HashMap$HashIterator.nextEntry(HashMap.java:806) > at java.util.HashMap$ValueIterator.next(HashMap.java:838) > at org.apache.cordova.PluginManager.postMessage(PluginManager.java:271) > at org.apache.cordova.CordovaWebView.postMessage(CordovaWebView.java:528) > at org.apache.cordova.App$1.run(App.java:78) > at android.os.Handler.handleCallback(Handler.java:733) > at android.os.Handler.dispatchMessage(Handler.java:95) > at android.os.Looper.loop(Looper.java:136) > at android.app.ActivityThread.main(ActivityThread.java:5017) > at java.lang.reflect.Method.invokeNative(Native Method) > at java.lang.reflect.Method.invoke(Method.java:515) > at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) > at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) > at dalvik.system.NativeStart.main(Native Method) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242749#comment-14242749 ] ASF subversion and git services commented on CB-3679: - Commit ddec7008cbab13865ff1321696bfeacd577e7169 in cordova-plugin-splashscreen's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=ddec700 ] CB-3679 Add engine tag for Android >= 3.6.0 due to use of `preferences` > Breakout SplashScreen Plugin for Android > > > Key: CB-3679 > URL: https://issues.apache.org/jira/browse/CB-3679 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, Plugin SplashScreen >Reporter: Steve Gill >Assignee: Andrew Grieve > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8149) Camera plugin windows (phone) cant take photo
Shane Vickers created CB-8149: - Summary: Camera plugin windows (phone) cant take photo Key: CB-8149 URL: https://issues.apache.org/jira/browse/CB-8149 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera, Windows Environment: Windows phone 8+ Reporter: Shane Vickers The Camera plugin for the windows platform dose not work on the windows phone project the plugin calls - Windows.Media.Capture.CameraCaptureUI() This function is not currently available on windows phone os -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7968) ConcurrentModificationException in postMessage
[ https://issues.apache.org/jira/browse/CB-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242582#comment-14242582 ] Lyubomir Gospodinov commented on CB-7968: - Hi, I am seeing this error with Cordova 3.6.4 for Android. Any ideas what is causing this? > ConcurrentModificationException in postMessage > -- > > Key: CB-7968 > URL: https://issues.apache.org/jira/browse/CB-7968 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.5.0 > Environment: Nexus 7 (2G) razorg >Reporter: Clayton Grassick > > Crash observed in Cordova messaging code: > java.util.ConcurrentModificationException > at java.util.HashMap$HashIterator.nextEntry(HashMap.java:806) > at java.util.HashMap$ValueIterator.next(HashMap.java:838) > at org.apache.cordova.PluginManager.postMessage(PluginManager.java:271) > at org.apache.cordova.CordovaWebView.postMessage(CordovaWebView.java:528) > at org.apache.cordova.App$1.run(App.java:78) > at android.os.Handler.handleCallback(Handler.java:733) > at android.os.Handler.dispatchMessage(Handler.java:95) > at android.os.Looper.loop(Looper.java:136) > at android.app.ActivityThread.main(ActivityThread.java:5017) > at java.lang.reflect.Method.invokeNative(Native Method) > at java.lang.reflect.Method.invoke(Method.java:515) > at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) > at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) > at dalvik.system.NativeStart.main(Native Method) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7517) [Media][iOS 8] returns an error and app becomes unresponsive when playing some mp3 fiiles
[ https://issues.apache.org/jira/browse/CB-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242565#comment-14242565 ] Damjan Dvorsek commented on CB-7517: It seems that iOS update 8.1.2 resolved this problem. Please test and confirm. > [Media][iOS 8] returns an error and app becomes unresponsive when playing > some mp3 fiiles > - > > Key: CB-7517 > URL: https://issues.apache.org/jira/browse/CB-7517 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Media >Affects Versions: 3.5.0 > Environment: iOS 8 GM >Reporter: Tom Krones > Attachments: chart-1-6-1-bad.mp3, chart-1-6-1-good.mp3 > > > You can read more about the issue here: > https://groups.google.com/forum/?hl=en?hl%3Den#!topic/phonegap/Zb7NQsr6wCQ > I just upgraded my device to iOS 8 and started getting a decode error with > some of my mp3 files that are being played using the media plugin. They > played fine with iOS 6 and iOS 7. Here are the two files one plays fine the > other gives the MediaError.MEDIA_ERR_DECODE = 3 error. > Anyone know why this is happening and if there is any software I can use to > re-encode the files and to see if it fixes them? > attached files. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7734) "navigator.notification.alert" or "navigator.notification.confirm" seem have a "many words" issue
[ https://issues.apache.org/jira/browse/CB-7734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242490#comment-14242490 ] jcesarmobile commented on CB-7734: -- it's fixed on my repository, but not merged with the official repository yet you can install it from my github repository: cordova plugin add https://github.com/jcesarmobile/cordova-plugin-dialogs > "navigator.notification.alert" or "navigator.notification.confirm" seem have > a "many words" issue > - > > Key: CB-7734 > URL: https://issues.apache.org/jira/browse/CB-7734 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Dialogs >Affects Versions: 3.6.3 > Environment: PGB 3.6.3 with the all latest core plugin > https://build.phonegap.com/plugins > ios 8.02 environment >Reporter: Colin Bau >Assignee: jcesarmobile > Labels: notification > Original Estimate: 12h > Remaining Estimate: 12h > > Improvement 1 > according to this > https://issues.apache.org/jira/browse/CB-6528 > a same problem just like the WP,ios have this problem too > when the words is greater than one page > it can't slide up and down > Improvement 2 > all words "center" problem,I think maybe "Left-aligned" is more Beautiful > (because when in Android,all words "Left-aligned") > http://www.littlebau.com/ios_1.png > Improvement 3 > all words looks like small and Vague (maybe in Chinese),is there any way > (maybe future) can let become more Clear ? > http://www.littlebau.com/ios_1.png -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8148) No deviceReady on WP8 in Emulator because of IsolatedStorageException
Eser Esen created CB-8148: - Summary: No deviceReady on WP8 in Emulator because of IsolatedStorageException Key: CB-8148 URL: https://issues.apache.org/jira/browse/CB-8148 Project: Apache Cordova Issue Type: Bug Components: WP8 Affects Versions: 4.0.0 Environment: VisualStudioExpress2013, Windows 8.1 Enterprise Reporter: Eser Esen Assignee: Jesse MacFadyen I successfully created and added wp8 project using cordova CLI. Running the app also works, it shows the HTML from my index.html file but then ends up with following below in console. On my index.html im trying to setup filesystem opening the cordova.file.dataDirectory using resolveLocalFileSystemURL. But this happens only within deviceReady function, which is never called, because i put a console.log there and i dont see any of my logs in the output window in Visual Studio Express 2013. Whats wrong here? --- Adding feature.value=Device Adding feature.value=DebugConsole Adding feature.value=File Adding feature.value=FileTransfer Adding feature.value=Globalization Adding feature.value=InAppBrowser 'TaskHost.exe' (CoreCLR: Silverlight AppDomain): Loaded 'C:\windows\system32\en-US\mscorlib.debug.resources.dll'. Module was built without symbols. A first chance exception of type 'System.IO.IsolatedStorage.IsolatedStorageException' occurred in mscorlib.ni.dll Updating IsolatedStorage for APP:DeviceID :: 6eb37ee1-d188-40ff-afb0-78504f5158b4 CordovaBrowser_LoadCompleted Apache Cordova native platform version 3.7.0 is starting A first chance exception of type 'System.SystemException' occurred in Microsoft.Phone.Interop.ni.dll Error calling js to fire nativeReady event. Did you include cordova.js in your html script tag? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8001) StatusBar Plugin 0.1.8 crashes application on tap
[ https://issues.apache.org/jira/browse/CB-8001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242438#comment-14242438 ] Ivan Karpan commented on CB-8001: - OK, so I will be needing an example project... It is not like there is an easy way to create a Cordova project without ARC these days. :( > StatusBar Plugin 0.1.8 crashes application on tap > - > > Key: CB-8001 > URL: https://issues.apache.org/jira/browse/CB-8001 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 3.7.0 > Environment: StatusBar Plugin 0.1.8 > Cordova iOS 3.7.0 > iPhone 6+ (8.0) > iPhone 5s (8.0) >Reporter: Nathan Smith >Priority: Critical > > StatusBar Plugin 0.1.8 > Cordova iOS 3.7.0 > iPhone 6+ (8.0) > iPhone 5s (8.0) > The StatusBar encounters an {{EXC_BAD_ACCESS}} exception when the user taps > on the StatusBar. > The call site affected is {{fireTappedEvent}} {{\[self.commandDelegate > sendPluginResult:result callbackId:_eventsCallbackId\];}} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org