[jira] [Commented] (CB-12551) File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2
[
https://issues.apache.org/jira/browse/CB-12551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606716#comment-16606716
]
ASF GitHub Bot commented on CB-12551:
-
schotime commented on issue #197: CB-12551: (android) Patch Security Provider
to support TLS 1.2
URL:
https://github.com/apache/cordova-plugin-file-transfer/pull/197#issuecomment-419328353
Is this going to get merged? We need it too. Thx.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2
> -
>
> Key: CB-12551
> URL: https://issues.apache.org/jira/browse/CB-12551
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file-transfer (DEPRECATED)
>Reporter: Dani Palou
>Priority: Major
>
> FileTransfer's download function fails when trying to download a file from a
> site using TLS 1.2. This works fine in Android 5 or higher, but it fails in
> Android 4.x.
> I searched a bit and I found that Android 4.4 should support TLS1.2 but it is
> disabled by default. I applied the solution proposed in this post and it
> worked for me:
> http://stackoverflow.com/a/33567745
> That is, I created the _MySSLSocketFactory_ class in the FileTransfer
> project, and I used it in the _trustAllHosts_ function (line 636 of
> _FileTransfer.java_):
> {noformat}
> SSLSocketFactory newFactory = new MySSLSocketFactory(sc.getSocketFactory());
> {noformat}
> I'm not sure if this can cause problems with other certificates, I don't know
> much about this. It would be nice if the Cordova team could take a look at
> this and check if it can be solved.
> This is the stacktrace:
> {noformat}
> Error getting HTTP status code from connection.
> javax.net.ssl.SSLException: Connection closed by peer
> at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
> at
> com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:405)
> at com.android.okhttp.Connection.upgradeToTls(Connection.java:146)
> at com.android.okhttp.Connection.connect(Connection.java:107)
> at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
> at
> com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
> at
> com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
> at
> com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
> at
> com.android.okhttp.internal.http.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:89)
> at
> com.android.okhttp.internal.http.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:161)
> at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:869)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
> at java.lang.Thread.run(Thread.java:841)
> {noformat}
> It can be tested with this code:
> {noformat}
> var ft = new FileTransfer(),
> path = 'squirrel.jpg',
> uri =
> 'https://prototype.moodle.net/mobile/moodle32/webservice/pluginfile.php/314/mod_resource/content/3/squirrel.jpg?forcedownload=1=616455be9f363cc9631cab89cfcfa1cd';
> ft.download(uri, path, success, error, true);
> function success() {
> console.log('Success');
> }
> function error(data) {
> console.log('Error', data);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606516#comment-16606516 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-419270559 No idea about that AppVeyor failure right now. I'll head to bed soon and then to Amsterdam over the weekend. I can look into it next week hopefully. I'm open for ideas of course :D This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606451#comment-16606451 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-419257942 I think I had that timeout-related failure locally as well. I'll look into it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606349#comment-16606349 ] ASF GitHub Bot commented on CB-12774: - raphinesse commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-419226485 I'd say leave it here until we're certain we have what we want. Then move it to common This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606336#comment-16606336 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-419222510 @raphinesse I think you're right. I'm debugging the failing tests right now and it appears the `getAllHelper` is broken. What would you suggest? Bringing the change back or putting the change into common? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606314#comment-16606314 ] ASF GitHub Bot commented on CB-12774: - raphinesse commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-419217533 @oliversalzburg To me 6acff93 looked like some change to a class from `cordova-common` that was needed for this change and that should have been ported to common once this was finished. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606307#comment-16606307 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-419216613 I also dropped 6acff9309641c080dfd9227161384f027a013496 as I think it should have been removed. Not so sure about the 3 failures. I didn't see those earlier. I'll look into them. If someone has any ideas beforehand, that'd be great. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[
https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606283#comment-16606283
]
ASF GitHub Bot commented on CB-12774:
-
raphinesse commented on a change in pull request #680: CB-12774: Support scoped
packages
URL: https://github.com/apache/cordova-lib/pull/680#discussion_r215744083
##
File path: tsconfig.json
##
@@ -0,0 +1,55 @@
+{
Review comment:
It's from a commit labeled TEMP. I guess the original author used it to aid
the refactoring.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova plugin add doesn't support scoped packages from private registries
> --
>
> Key: CB-12774
> URL: https://issues.apache.org/jira/browse/CB-12774
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: 1.1.0
>Reporter: Enrico Mazzucchelli
>Assignee: Raphael
>Priority: Major
> Labels: cordova-8.0.0
> Fix For: 1.1.1
>
>
> STEP TO REPRODUCE:
> 1) setup a private repo (for example sinopia with docker:
> https://github.com/kfatehi/docker-sinopia)
> 2) add scope in your npm config: npm config set @myco:registry
> http://0.0.0.0:4873/
> 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in
> plugin.xml set plugin id: @myco/my.co.plugin.demo.
> 3) publish plugin in your private repo:
> - npm set registry http://0.0.0.0:4873
> - npm publish
>- npm set registry https://registry.npmjs.org/
> 4) in your cordova project dir, exec:
> cordova plugin add @myco/my.co.plugin.demo
> EXPECTED BEHAVIOR:
> cordova plugin are installed
> ACTUAL BEHAVIOR:
> cordova installation failed:
> Error: Failed to fetch plugin my.co.plugin.demo via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 1 Error output:
> npm ERR! code E404
> npm ERR! 404 Registry returned 404 for GET on
> https://registry.npmjs.org/my.co.plugin.demo
> npm ERR! 404
> npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry.
> npm ERR! 404 You should bug the author to publish it (or use the name
> yourself!)
> npm ERR! 404
> npm ERR! 404 Note that you can also install from a
> npm ERR! 404 tarball, folder, http url, or git url.
> However node module are correctly installed (verified with npm ls) and
> fetch.json have a new entry with key
> @my.co.plugin.demo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[
https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606275#comment-16606275
]
ASF GitHub Bot commented on CB-12774:
-
dpogue commented on a change in pull request #680: CB-12774: Support scoped
packages
URL: https://github.com/apache/cordova-lib/pull/680#discussion_r215742882
##
File path: tsconfig.json
##
@@ -0,0 +1,55 @@
+{
Review comment:
We probably don't want to add a tsconfig to the repo without further
discussion?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova plugin add doesn't support scoped packages from private registries
> --
>
> Key: CB-12774
> URL: https://issues.apache.org/jira/browse/CB-12774
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: 1.1.0
>Reporter: Enrico Mazzucchelli
>Assignee: Raphael
>Priority: Major
> Labels: cordova-8.0.0
> Fix For: 1.1.1
>
>
> STEP TO REPRODUCE:
> 1) setup a private repo (for example sinopia with docker:
> https://github.com/kfatehi/docker-sinopia)
> 2) add scope in your npm config: npm config set @myco:registry
> http://0.0.0.0:4873/
> 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in
> plugin.xml set plugin id: @myco/my.co.plugin.demo.
> 3) publish plugin in your private repo:
> - npm set registry http://0.0.0.0:4873
> - npm publish
>- npm set registry https://registry.npmjs.org/
> 4) in your cordova project dir, exec:
> cordova plugin add @myco/my.co.plugin.demo
> EXPECTED BEHAVIOR:
> cordova plugin are installed
> ACTUAL BEHAVIOR:
> cordova installation failed:
> Error: Failed to fetch plugin my.co.plugin.demo via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 1 Error output:
> npm ERR! code E404
> npm ERR! 404 Registry returned 404 for GET on
> https://registry.npmjs.org/my.co.plugin.demo
> npm ERR! 404
> npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry.
> npm ERR! 404 You should bug the author to publish it (or use the name
> yourself!)
> npm ERR! 404
> npm ERR! 404 Note that you can also install from a
> npm ERR! 404 tarball, folder, http url, or git url.
> However node module are correctly installed (verified with npm ls) and
> fetch.json have a new entry with key
> @my.co.plugin.demo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[
https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606268#comment-16606268
]
ASF GitHub Bot commented on CB-12774:
-
raphinesse closed pull request #602: CB-12774 : Don't munge scoped plugin IDs
anymore. Comment requested.
URL: https://github.com/apache/cordova-lib/pull/602
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/integration-tests/plugin.spec.js b/integration-tests/plugin.spec.js
index 815d4182b..f03f2e9f1 100644
--- a/integration-tests/plugin.spec.js
+++ b/integration-tests/plugin.spec.js
@@ -46,6 +46,9 @@ var org_test_defaultvariables = 'org.test.defaultvariables';
var npmInfoTestPlugin = 'cordova-lib-test-plugin';
var npmInfoTestPluginVersion = '1.1.2';
+var npmScopedTestPlugin = '@testscope/cordova-lib-test-plugin-scoped';
+var npmScopedTestPluginDir = 'cordova-lib-test-plugin-scoped';
+
var testGitPluginRepository =
'https://github.com/apache/cordova-plugin-device.git';
var testGitPluginId = 'cordova-plugin-device';
@@ -95,8 +98,7 @@ function mockPluginFetch (id, dir) {
spyOn(plugman, 'fetch').and.callFake(function (target, pluginPath,
fetchOptions) {
var dest = path.join(project, 'plugins', id);
var src = path.join(dir, 'plugin.xml');
-
-shell.mkdir(dest);
+shell.mkdir('-p', dest);
shell.cp(src, dest);
return Q(dest);
});
@@ -259,19 +261,18 @@ describe('plugin end-to-end', function () {
}, 3);
it('Test 011 : should handle scoped npm packages', function (done) {
-var scopedPackage = '@testscope/' + npmInfoTestPlugin;
-mockPluginFetch(npmInfoTestPlugin, path.join(pluginsDir,
npmInfoTestPlugin));
+mockPluginFetch(npmScopedTestPlugin, path.join(pluginsDir,
npmScopedTestPluginDir));
spyOn(registry, 'info').and.returnValue(Q({}));
-addPlugin(scopedPackage, npmInfoTestPlugin, {}, done)
+addPlugin(npmScopedTestPlugin, npmScopedTestPlugin, {})
.then(function () {
// Check to make sure that we are at least trying to get the
correct package.
// This package is not published to npm, so we can't truly do
end-to-end tests
-expect(registry.info).toHaveBeenCalledWith([scopedPackage]);
+
expect(registry.info).toHaveBeenCalledWith([npmScopedTestPlugin]);
var fetchTarget = plugman.fetch.calls.mostRecent().args[0];
-expect(fetchTarget).toEqual(scopedPackage);
+expect(fetchTarget).toEqual(npmScopedTestPlugin);
})
.fail(function (err) {
expect(err).toBeUndefined();
@@ -280,11 +281,11 @@ describe('plugin end-to-end', function () {
}, 3);
it('Test 012 : should handle scoped npm packages with given version tags',
function (done) {
-var scopedPackage = '@testscope/' + npmInfoTestPlugin + '@latest';
-mockPluginFetch(npmInfoTestPlugin, path.join(pluginsDir,
npmInfoTestPlugin));
+var scopedPackage = npmScopedTestPlugin + '@latest';
+mockPluginFetch(npmScopedTestPlugin, path.join(pluginsDir,
npmScopedTestPluginDir));
spyOn(registry, 'info');
-addPlugin(scopedPackage, npmInfoTestPlugin, {}, done)
+addPlugin(scopedPackage, npmScopedTestPlugin, {})
.then(function () {
expect(registry.info).not.toHaveBeenCalled();
@@ -296,4 +297,37 @@ describe('plugin end-to-end', function () {
})
.fin(done);
}, 3);
+
+it('Test 013 : should be able to add and remove scoped npm packages
without screwing up everything', function (done) {
+mockPluginFetch(npmScopedTestPlugin, path.join(pluginsDir,
npmScopedTestPluginDir));
+
+spyOn(registry, 'info').and.returnValue(Q({}));
+addPlugin(npmScopedTestPlugin, npmScopedTestPlugin, {})
+.then(function () {
+
expect(registry.info).toHaveBeenCalledWith([npmScopedTestPlugin]);
+
+var fetchTarget = plugman.fetch.calls.mostRecent().args[0];
+expect(fetchTarget).toEqual(npmScopedTestPlugin);
+})
+.then(function () {
+return cordova.plugin('ls');
+})
+.then(function (list) {
+console.dir(list);
+})
+.then(function () {
+return removePlugin(npmScopedTestPlugin);
+})
+.then(function () {
+return cordova.plugin('ls');
+})
+.then(function (list) {
+console.dir(list);
+})
+.fail(function (err) {
+
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606267#comment-16606267 ] ASF GitHub Bot commented on CB-12774: - raphinesse commented on issue #602: CB-12774 : Don't munge scoped plugin IDs anymore. Comment requested. URL: https://github.com/apache/cordova-lib/pull/602#issuecomment-419205940 Closing in favor of rebased #680. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606262#comment-16606262 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg opened a new pull request #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680 ### Platforms affected All ### What does this PR do? See #602 for details. ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14194) Prepare fails when using scoped packages
[
https://issues.apache.org/jira/browse/CB-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606266#comment-16606266
]
ASF GitHub Bot commented on CB-14194:
-
oliversalzburg closed pull request #625: CB-14194: Don't cut off scope from
package identifier
URL: https://github.com/apache/cordova-lib/pull/625
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/cordova/plugin/add.js b/src/cordova/plugin/add.js
index 8aea7f0a7..cfae7c824 100644
--- a/src/cordova/plugin/add.js
+++ b/src/cordova/plugin/add.js
@@ -129,7 +129,7 @@ function add (projectRoot, hooksRunner, opts) {
};
events.emit('verbose', 'Calling plugman.install on
plugin "' + pluginInfo.dir + '" for platform "' + platform);
-return plugman.install(platform, platformRoot,
path.basename(pluginInfo.dir), pluginPath, options)
+return plugman.install(platform, platformRoot,
pluginInfo.id, pluginPath, options)
.then(function (didPrepare) {
// If platform does not returned anything
we'll need
// to trigger a prepare after all plugins
installed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Prepare fails when using scoped packages
>
>
> Key: CB-14194
> URL: https://issues.apache.org/jira/browse/CB-14194
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: Master
>Reporter: Oliver Salzburg
>Priority: Major
>
> When adding a plugin to a project, cordova will fail if the plugin is hosted
> under an npm scope.
> The scope is cut off when searching for the installation folder on disk:
> {code}
> Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it
> to the project
> Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml.
> You might need to try adding it again. Error: Cannot find plugin.xml for
> plugin "cordova-plugin-push". Please try adding it again.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14194) Prepare fails when using scoped packages
[
https://issues.apache.org/jira/browse/CB-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606265#comment-16606265
]
ASF GitHub Bot commented on CB-14194:
-
oliversalzburg commented on issue #625: CB-14194: Don't cut off scope from
package identifier
URL: https://github.com/apache/cordova-lib/pull/625#issuecomment-419204668
Closing in favor of #680
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Prepare fails when using scoped packages
>
>
> Key: CB-14194
> URL: https://issues.apache.org/jira/browse/CB-14194
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: Master
>Reporter: Oliver Salzburg
>Priority: Major
>
> When adding a plugin to a project, cordova will fail if the plugin is hosted
> under an npm scope.
> The scope is cut off when searching for the installation folder on disk:
> {code}
> Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it
> to the project
> Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml.
> You might need to try adding it again. Error: Cannot find plugin.xml for
> plugin "cordova-plugin-push". Please try adding it again.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606220#comment-16606220 ] ASF GitHub Bot commented on CB-12774: - raphinesse commented on issue #602: CB-12774 : Don't munge scoped plugin IDs anymore. Comment requested. URL: https://github.com/apache/cordova-lib/pull/602#issuecomment-419195367 @oliversalzburg Great to hear! OP hasn't reacted to previous mentions, so I'd suggest you open a PR with the rebased changes that references this one. Then we can have another look at it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606200#comment-16606200 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg commented on issue #602: CB-12774 : Don't munge scoped plugin IDs anymore. Comment requested. URL: https://github.com/apache/cordova-lib/pull/602#issuecomment-419192500 I rebased this locally and did not see the same failure. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606177#comment-16606177 ] ASF GitHub Bot commented on CB-14089: - dpogue commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r215720701 ## File path: test/gradle/wrapper/gradle-wrapper.properties ## @@ -1,6 +1,5 @@ -#Wed Oct 25 11:17:25 PDT 2017 distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-bin.zip Review comment: Yeah... I think this might already have been updated on master (and maybe the source of a conflict now) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11605) platform update should be non-destructive
[ https://issues.apache.org/jira/browse/CB-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606088#comment-16606088 ] ASF GitHub Bot commented on CB-11605: - raphinesse commented on issue #465: CB-11605 Non-destructive platform update URL: https://github.com/apache/cordova-lib/pull/465#issuecomment-419171204 @dpogue Thanks for the feedback. I understood what the proposal was about, I just wanted to assert that this is still something we want. I would rather kick out update for good. I never had to manually change stuff in `platforms` (at least not after the arrival of ``). So I usually do a `git clean` followed by installing newer stuff. But I can understand that it's desirable to provide an escape hatch for when things go south. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > platform update should be non-destructive > - > > Key: CB-11605 > URL: https://issues.apache.org/jira/browse/CB-11605 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > Labels: cordova-7.0.0 > Fix For: cordova@7.0.0 > > > More details here: > https://github.com/cordova/cordova-discuss/issues/50 > and here: > http://markmail.org/message/nrabt2f4kcbp6vkh -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11605) platform update should be non-destructive
[ https://issues.apache.org/jira/browse/CB-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606086#comment-16606086 ] ASF GitHub Bot commented on CB-11605: - dpogue removed a comment on issue #465: CB-11605 Non-destructive platform update URL: https://github.com/apache/cordova-lib/pull/465#issuecomment-419167538 @raphinesse Once upon a time, we tried to actually "update" the platform files. It was a disaster, as you can probably imagine. Jesse's proposal here was to allow `cordova platform update ios` to make a backup of the existing `platforms/ios` folder, and then essentially run a platform add for the latest version. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > platform update should be non-destructive > - > > Key: CB-11605 > URL: https://issues.apache.org/jira/browse/CB-11605 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > Labels: cordova-7.0.0 > Fix For: cordova@7.0.0 > > > More details here: > https://github.com/cordova/cordova-discuss/issues/50 > and here: > http://markmail.org/message/nrabt2f4kcbp6vkh -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11605) platform update should be non-destructive
[ https://issues.apache.org/jira/browse/CB-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606087#comment-16606087 ] ASF GitHub Bot commented on CB-11605: - dpogue commented on issue #465: CB-11605 Non-destructive platform update URL: https://github.com/apache/cordova-lib/pull/465#issuecomment-419169159 @raphinesse Once upon a time I think we did try to actually update platform files. That failed spectacularly, as you can probably imagine. What Jesse is proposing here is to make `cordova platform update ios` do two things: 1. Make a backup of the existing `platforms/ios` folder. 2. Run a platform add with the latest version of the platform. This is slightly better than our current instructions of telling users to do a `platform rm`/`platform add` which might cause them to lose any changes they've made to the platform native files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > platform update should be non-destructive > - > > Key: CB-11605 > URL: https://issues.apache.org/jira/browse/CB-11605 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > Labels: cordova-7.0.0 > Fix For: cordova@7.0.0 > > > More details here: > https://github.com/cordova/cordova-discuss/issues/50 > and here: > http://markmail.org/message/nrabt2f4kcbp6vkh -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11605) platform update should be non-destructive
[ https://issues.apache.org/jira/browse/CB-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606080#comment-16606080 ] ASF GitHub Bot commented on CB-11605: - dpogue commented on issue #465: CB-11605 Non-destructive platform update URL: https://github.com/apache/cordova-lib/pull/465#issuecomment-419167538 @raphinesse Once upon a time, we tried to actually "update" the platform files. It was a disaster, as you can probably imagine. Jesse's proposal here was to allow `cordova platform update ios` to make a backup of the existing `platforms/ios` folder, and then essentially run a platform add for the latest version. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > platform update should be non-destructive > - > > Key: CB-11605 > URL: https://issues.apache.org/jira/browse/CB-11605 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > Labels: cordova-7.0.0 > Fix For: cordova@7.0.0 > > > More details here: > https://github.com/cordova/cordova-discuss/issues/50 > and here: > http://markmail.org/message/nrabt2f4kcbp6vkh -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11605) platform update should be non-destructive
[ https://issues.apache.org/jira/browse/CB-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606078#comment-16606078 ] ASF GitHub Bot commented on CB-11605: - raphinesse commented on issue #465: CB-11605 Non-destructive platform update URL: https://github.com/apache/cordova-lib/pull/465#issuecomment-419166514 @purplecabbage Is updating a platform something that we actually need? If so why? Neither `ios` nor `android` support it at the moment: https://github.com/apache/cordova-ios/blob/46da4bc34495ec7bfe13c1ec1b4074dd2e82641a/bin/lib/create.js#L241-L253 https://github.com/apache/cordova-android/blob/46a036ef265951d5371936b37d7296fa47fb28ce/bin/lib/create.js#L347-L360 I guess this boils down to the question if we want to continue supporting the platform-centric workflow, or whatever it's called, where platforms are not pure build-artifacts. Or am I mistaken? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > platform update should be non-destructive > - > > Key: CB-11605 > URL: https://issues.apache.org/jira/browse/CB-11605 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > Labels: cordova-7.0.0 > Fix For: cordova@7.0.0 > > > More details here: > https://github.com/cordova/cordova-discuss/issues/50 > and here: > http://markmail.org/message/nrabt2f4kcbp6vkh -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8098) Media plugin change plackback rate
[ https://issues.apache.org/jira/browse/CB-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606056#comment-16606056 ] ASF GitHub Bot commented on CB-8098: Elijax commented on issue #130: CB-8098 & CB-7810:(android) Added media rate for android URL: https://github.com/apache/cordova-plugin-media/pull/130#issuecomment-419161553 @AmroAlJundi I've added code manually and reinstalled android platform, it works perfect. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Media plugin change plackback rate > -- > > Key: CB-8098 > URL: https://issues.apache.org/jira/browse/CB-8098 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-media >Affects Versions: 3.5.0 >Reporter: Alex >Priority: Major > > Doesn't Media plugin support chanding playback rate? I dind't find any > mention in docs. I think this fis must even flaw HTML5 audio has it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14045) iOS 11.3 - app freeze/sleep
[ https://issues.apache.org/jira/browse/CB-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605979#comment-16605979 ] ASF GitHub Bot commented on CB-14045: - GulinSS edited a comment on issue #363: CB-14045 - reinit url after app freezes URL: https://github.com/apache/cordova-ios/pull/363#issuecomment-419149235 Did it been added for current `4.5.5` public release? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS 11.3 - app freeze/sleep > --- > > Key: CB-14045 > URL: https://issues.apache.org/jira/browse/CB-14045 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova@7.1.0, cordova-ios@4.5.4 >Reporter: Robert >Priority: Blocker > Labels: ios, ios11, lock, performance, sleep > > Users with iOS 11.3 can’t use the app when device is locked for more than 10 > minutes. > Event onResume not firing. > Steps to Reproduce: > Install Fitatu app. > Open app on any view. > Lock the device for more than 10 minutes. > After 10 minutes, unlock device. > Expected Results: > App wakes up and the UI is responding (e.g. user is able to click buttons) > Actual Results: > App wakes up and the UI is blocked (user is not able to click buttons) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14045) iOS 11.3 - app freeze/sleep
[ https://issues.apache.org/jira/browse/CB-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605976#comment-16605976 ] ASF GitHub Bot commented on CB-14045: - GulinSS commented on issue #363: CB-14045 - reinit url after app freezes URL: https://github.com/apache/cordova-ios/pull/363#issuecomment-419149235 Did it was added for current `4.5.5` public release? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS 11.3 - app freeze/sleep > --- > > Key: CB-14045 > URL: https://issues.apache.org/jira/browse/CB-14045 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova@7.1.0, cordova-ios@4.5.4 >Reporter: Robert >Priority: Blocker > Labels: ios, ios11, lock, performance, sleep > > Users with iOS 11.3 can’t use the app when device is locked for more than 10 > minutes. > Event onResume not firing. > Steps to Reproduce: > Install Fitatu app. > Open app on any view. > Lock the device for more than 10 minutes. > After 10 minutes, unlock device. > Expected Results: > App wakes up and the UI is responding (e.g. user is able to click buttons) > Actual Results: > App wakes up and the UI is blocked (user is not able to click buttons) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10
[ https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605872#comment-16605872 ] ASF GitHub Bot commented on CB-14192: - sgoldberg-sfdc commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s… URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-419123199 @dpogue I find if I restructure the project for the framework target such that its not wrapping the static lib, but instead compiling the source directly as part of the target, I do not see the failures with the new build system. In addition, it is also odd that the failure occurs while building the static lib as a dependency of the framework target, yet if we build the static lib directly , it has no issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova iOS doesn't build with Xcode 10 > --- > > Key: CB-14192 > URL: https://issues.apache.org/jira/browse/CB-14192 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Sebastian Grail >Priority: Minor > > Xcode 10 uses the new build system by default. Any project not explicitly > choosing the legacy build system will build with new system. Currently, > Cordova iOS fails to build with the new system. The simplest solution is to > explicitly use the legacy build system. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605747#comment-16605747
]
ASF GitHub Bot commented on CB-14166:
-
janpio closed pull request #622: CB-14166: (cli) Fixed issue when installing
plugins on windows
URL: https://github.com/apache/cordova-lib/pull/622
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/plugman/fetch.js b/src/plugman/fetch.js
index d52bae7aa..2ae1b7916 100644
--- a/src/plugman/fetch.js
+++ b/src/plugman/fetch.js
@@ -120,7 +120,6 @@ function fetchPlugin (plugin_src, plugins_dir, options) {
var parsedSpec = pluginSpec.parse(plugin_src);
var P;
var skipCopyingPlugin;
-var specContainsSpecialCharacters = false;
plugin_dir = path.join(plugins_dir, parsedSpec.id);
// if the plugin has already been fetched, use it.
if (fs.existsSync(plugin_dir)) {
@@ -135,16 +134,7 @@ function fetchPlugin (plugin_src, plugins_dir, options) {
projectRoot = options.projectRoot;
}
-if (process.platform === 'win32' && parsedSpec.version) {
-var windowsShellSpecialCharacters = ['&', '\\', '<', '>',
'^', '|'];
-specContainsSpecialCharacters =
windowsShellSpecialCharacters.some(function (character) {
-return parsedSpec.version.indexOf(character);
-});
-}
-
-var fetchPluginSrc = specContainsSpecialCharacters ?
-parsedSpec.package + '@"' + parsedSpec.version + '"' :
plugin_src;
-P = fetch(fetchPluginSrc, projectRoot, options);
+P = fetch(plugin_src, projectRoot, options);
skipCopyingPlugin = false;
}
return P
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605746#comment-16605746 ] ASF GitHub Bot commented on CB-14166: - janpio commented on issue #622: CB-14166: (cli) Fixed issue when installing plugins on windows URL: https://github.com/apache/cordova-lib/pull/622#issuecomment-419086421 So we finally figured out what was going on, please read in the JIRA issue: https://issues.apache.org/jira/browse/CB-14166?focusedCommentId=16605718=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16605718 Short version: Nodist, which the issue reported and creator of this PR are using to manage their local node/npm installations, installs a `npm.exe` next to `npm.cmd` which is then used to execute the command because `which npm` returns its path. It behaves differently, which causes the command to fail for them. Thanks @AlmirKadric for creating this PR anyway, it helped to understand the problem better. Another PR seems to be incoming that will solve this problem in another way. PS: `nvm-windows` doesn't have this problem: https://github.com/coreybutler/nvm-windows This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605744#comment-16605744 ] Jan Piotrowski (Sujan) commented on CB-14166: - That special handling the existing PR removes sure is there for a reason - a long time ago something was broken and this was the fix. So removing it might this one current use case (using Nodist) work, but break other, unknown things at the same time. The real solution for this is of course to properly fix _all_ of this by making sure that Cordova has a way to just tell _someone_ to run a specific command, and it is run on all platforms. But someone has to create that PR first for this to be an option ;) Until then, maybe some special handling for Nodist (e.g. path includes "Nodist")? Super dirty, but quick and works and will be removed when the real rewrite comes in. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605736#comment-16605736 ] Oliver Salzburg commented on CB-14166: -- That change is not valid. When you run `npm` on the CLI, you would get the .exe. By introducing this change, you're introducing behavior that is unexpected, because a different npm entry point is used. This is making things worse. Especially when you're forcing the system to try to find a .cmd. It may very well be a .bat for some reason. The solution is still to properly escape when running commands on the shell, and to not escape when not running on the shell. Proper abstractions will take care of that for you. In this scenario, the only problem is that part of the code (fetch.js) decides that it already knows how the command is executed in the end, which it does not. The additional escaping introduced in this place is a mistake. It needs to be removed and superspawn needs to be taught how to properly escape, or, as I have been saying continuously, it should be replaced with something that works (cross-spawn, execa). > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605730#comment-16605730 ] Ken Naito edited comment on CB-14166 at 9/6/18 12:47 PM: - [~Sujan12] I think that PR fixes this issue, but not enough to work in other cases. The behavior of 'npm.cmd' is different from that of 'npm.exe' as [~OliverSalzburg] pointed out. The cordova should call 'npm.cmd' in win32, I believe. was (Author: knaito): [~Sujan12] I think that PR is not enough to fix the issue. That PR seems to work only for nodist where both npm.cmd and npm.exe are installed. The behavior of 'npm.cmd' is different from that of 'npm.exe' as [~OliverSalzburg] pointed out. The cordova should call 'npm.cmd' in win32, I believe. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605730#comment-16605730 ] Ken Naito edited comment on CB-14166 at 9/6/18 12:45 PM: - [~Sujan12] I think that PR is not enough to fix the issue. That PR seems to work only for nodist where both npm.cmd and npm.exe are installed. The behavior of 'npm.cmd' is different from that of 'npm.exe' as [~OliverSalzburg] pointed out. The cordova should call 'npm.cmd' in win32, I believe. was (Author: knaito): [~purplecabbage] I think that PR is not enough to fix the issue. That PR seems to work only for nodist where both npm.cmd and npm.exe are installed. The behavior of 'npm.cmd' is different from that of 'npm.exe' as [~OliverSalzburg] pointed out. The cordova should call 'npm.cmd' in win32, I believe. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605730#comment-16605730 ] Ken Naito commented on CB-14166: [~purplecabbage] I think that PR is not enough to fix the issue. That PR seems to work only for nodist where both npm.cmd and npm.exe are installed. The behavior of 'npm.cmd' is different from that of 'npm.exe' as [~OliverSalzburg] pointed out. The cordova should call 'npm.cmd' in win32, I believe. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605722#comment-16605722 ] Ken Naito commented on CB-14166: Yes it is! I am really grateful for you, [~Sujan12] and [~OliverSalzburg] . I will send PR. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605719#comment-16605719 ] Jan Piotrowski (Sujan) commented on CB-14166: - And the creator of the PR that should fix this also uses Nodist: > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with > exit code 1 Error output: https://github.com/apache/cordova-lib/pull/622#issuecomment-405315198 Now the question becomes: Is this something Cordova should actually work around? > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605718#comment-16605718 ] Jan Piotrowski (Sujan) commented on CB-14166: - The initial reporter was also using Nodist. I think we found the culprit! > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605717#comment-16605717
]
Ken Naito edited comment on CB-14166 at 9/6/18 12:33 PM:
-
If I add following code in superspawn.js
{code}
if (cmd === 'npm' && iswin32) {
cmd = "npm.cmd";
}
{code}
before
{code}
cmd = shell.which(cmd) || cmd;
{code}
The issue has gone.
was (Author: knaito):
If I add following code in superspawn.js
{code}
if (cmd === 'npm' && iswin32) {
cmd = "npm.cmd";
}
{code}
before
{code}
cmd = shell.which(cmd) || cmd;
{code}
The issue is gone.
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605717#comment-16605717
]
Ken Naito edited comment on CB-14166 at 9/6/18 12:32 PM:
-
If I add following code in superspawn.js
{code}
if (cmd === 'npm' && iswin32) {
cmd = "npm.cmd";
}
{code}
before
{code}
cmd = shell.which(cmd) || cmd;
{code}
The issue is gone.
was (Author: knaito):
If I adding following code in superspawn.js
{code}
if (cmd === 'npm' && iswin32) {
cmd = "npm.cmd";
}
{code}
before
{code}
cmd = shell.which(cmd) || cmd;
{code}
The issue is gone.
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605711#comment-16605711
]
Ken Naito edited comment on CB-14166 at 9/6/18 12:32 PM:
-
Thanks [~OliverSalzburg].
I carefully check the superspawn.js in cordova-common.
There is a following code
{code}
cmd = shell.which(cmd) || cmd;
{code}
Before this code, cmd is 'npm'.
After this code, cmd is 'C:\Program Files (x86)\Nodist\bin\npm.exe'
As I mentioned, there are npm.cmd and npm.exe in my environment. This may be a
Nodist feature.
Cordova found npm.exe first and used it instead of npm.cmd.
was (Author: knaito):
Thanks [~OliverSalzburg].
I carefully check the superspawn.js in cordova-common.
There is a following code
{code}
cmd = shell.which(cmd) || cmd;
{code}
Before this code, cmd is 'npm'.
After this code, cmd is 'C:\Program Files (x86)\Nodist\bin\npm.exe'
As you mentioned, there are npm.cmd and npm.exe in my environment. This may be
a Nodist feature.
Cordova found npm.exe first and used it instead of npm.cmd.
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605717#comment-16605717
]
Ken Naito commented on CB-14166:
If I adding following code in superspawn.js
{code}
if (cmd === 'npm' && iswin32) {
cmd = "npm.cmd";
}
{code}
before
{code}
cmd = shell.which(cmd) || cmd;
{code}
The issue is gone.
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605711#comment-16605711
]
Ken Naito commented on CB-14166:
Thanks [~OliverSalzburg].
I carefully check the superspawn.js in cordova-common.
There is a following code
{code}
cmd = shell.which(cmd) || cmd;
{code}
Before this code, cmd is 'npm'.
After this code, cmd is 'C:\Program Files (x86)\Nodist\bin\npm.exe'
As you mentioned, there are npm.cmd and npm.exe in my environment. This may be
a Nodist feature.
Cordova found npm.exe first and used it instead of npm.cmd.
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605692#comment-16605692 ] Oliver Salzburg commented on CB-14166: -- Windows will pick the default and .exe overrules .cmd. *Everything* in this stack expects that the shell script is invoked, which would be the cmd. If the cmd is invoked, it is invoked through the shell, where the escaping works. When the .exe is invoked, then no shell escaping is necessary and we get the error you reported. By default, node and npm do not ship a .exe. I have no idea what that is. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605688#comment-16605688
]
Ken Naito edited comment on CB-14166 at 9/6/18 12:01 PM:
-
Thanks you very much! [~OliverSalzburg]
I don't know why npm.exe is used by cordova.
Both npm.cmd and npm.exe are installed.
{code}
C:\Users\knaito\Documents\work\cordova\CB-14166-2 (helloworld@1.0.0)
λ where npm
C:\Program Files (x86)\Nodist\bin\npm.cmd
C:\Program Files (x86)\Nodist\bin\npm.exe
{code}
was (Author: knaito):
Thanks [~OliverSalzburg]
I don't know why npm.exe is used by cordova.
Both npm.cmd and npm.exe are installed.
{code}
C:\Users\knaito\Documents\work\cordova\CB-14166-2 (helloworld@1.0.0)
λ where npm
C:\Program Files (x86)\Nodist\bin\npm.cmd
C:\Program Files (x86)\Nodist\bin\npm.exe
{code}
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605688#comment-16605688
]
Ken Naito commented on CB-14166:
Thanks [~OliverSalzburg]
I don't know why npm.exe is used by cordova.
Both npm.cmd and npm.exe are installed.
{code}
C:\Users\knaito\Documents\work\cordova\CB-14166-2 (helloworld@1.0.0)
λ where npm
C:\Program Files (x86)\Nodist\bin\npm.cmd
C:\Program Files (x86)\Nodist\bin\npm.exe
{code}
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605667#comment-16605667
]
Jan Piotrowski (Sujan) commented on CB-14166:
-
For your `main.js` I get this:
{code}
C:\Projects\experiments\foo
λ node main.js
events.js:167
throw er; // Unhandled 'error' event
^
Error: spawn npm ENOENT
at Process.ChildProcess._handle.onexit (internal/child_process.js:229:19)
at onErrorNT (internal/child_process.js:406:16)
at process._tickCallback (internal/process/next_tick.js:63:19)
at Function.Module.runMain (internal/modules/cjs/loader.js:746:11)
at startup (internal/bootstrap/node.js:240:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:564:3)
Emitted 'error' event at:
at Process.ChildProcess._handle.onexit (internal/child_process.js:235:12)
at onErrorNT (internal/child_process.js:406:16)
[... lines matching original stack trace ...]
at bootstrapNodeJSCore (internal/bootstrap/node.js:564:3)
C:\Projects\experiments\foo
λ npm -v
6.1.0
{code}
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605686#comment-16605686 ] Ken Naito commented on CB-14166: Thanks a lot! [~Sujan12] . Now I install cordova@8.0.0 globally. The result is same. The log is ``` C:\Users\knaito\Documents\work\cordova λ node -v v10.7.0 C:\Users\knaito\Documents\work\cordova λ npm -v 6.1.0 C:\Users\knaito\Documents\work\cordova λ cordova -v 8.0.0 C:\Users\knaito\Documents\work\cordova λ cordova create CB-14166-2 Creating a new cordova project. C:\Users\knaito\Documents\work\cordova λ cd CB-14166-2 C:\Users\knaito\Documents\work\cordova\CB-14166-2 (helloworld@1.0.0) λ cordova platform add windows@5.0.0 -d No scripts found for hook "before_platform_add". Using cordova-fetch for cordova-windows@5.0.0 saving Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install cordova-windows@5.0.0 --production --save Command finished with error code 0: C:\Program Files (x86)\Nodist\bin\npm.exe install,cordova-windows@5.0.0,--production,--save Removing "cordova-" prefix from cordova-windows Adding windows project... PlatformApi successfully found for platform windows Creating Cordova Windows Project: Path: platforms\windows Namespace: io.cordova.hellocordova Name: HelloCordova Copying windows template project to C:\Users\knaito\Documents\work\cordova\CB-14166-2\platforms\windows Copying cordova-js sources to platform_www Copying node_modules to C:\Users\knaito\Documents\work\cordova\CB-14166-2\platforms\windows Updating manifest files with project configuration. Windows project created with cordova-windows@5.0.0 Checking for any plugins added to the project that have not been installed in windows platform No differences found between plugins added to project and installed in windows platform. Continuing... PlatformApi successfully found for platform windows Merging project's config.xml into platform-specific windows config.xml Merging and updating files from [www, platforms\windows\platform_www] to platforms\windows\www mkdir platforms\windows\www\cordova-js-src copy platforms\windows\platform_www\cordova-js-src\confighelper.js platforms\windows\www\cordova-js-src\confighelper.js (new file) copy platforms\windows\platform_www\cordova-js-src\exec.js platforms\windows\www\cordova-js-src\exec.js (new file) copy platforms\windows\platform_www\cordova-js-src\platform.js platforms\windows\www\cordova-js-src\platform.js (new file) copy platforms\windows\platform_www\cordova-js-src\splashscreen.js platforms\windows\www\cordova-js-src\splashscreen.js (new file) copy platforms\windows\platform_www\cordova.js platforms\windows\www\cordova.js (updated file) copy platforms\windows\platform_www\css\splashscreen.css platforms\windows\www\css\splashscreen.css (updated file) delete platforms\windows\www\img\smalllogo.png (no source) delete platforms\windows\www\img\splashscreen.png (no source) delete platforms\windows\www\img\storelogo.png (no source) copy www\index.html platforms\windows\www\index.html (updated file) copy www\js\index.js platforms\windows\www\js\index.js (updated file) This app does not have any icons or splash screens defined Prepared windows project successfully No scripts found for hook "pre_package". No scripts found for hook "before_prepare". Checking config.xml and package.json for saved platforms that haven't been added to the project Checking config.xml for saved plugins that haven't been added to the project Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project No scripts found for hook "before_plugin_add". Calling plugman.fetch on plugin "cordova-plugin-whitelist@1" saving Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install cordova-plugin-whitelist@"1" --production --save Command finished with error code 1: C:\Program Files (x86)\Nodist\bin\npm.exe install,cordova-plugin-whitelist@"1",--production,--save Failed to restore plugin "cordova-plugin-whitelist" from config.xml. You might need to try adding it again. Error: Failed to fetch plugin cordova-plugin-whitelist@1 via registry. Probably this is either a connection problem, or plugin spec is incorrect. Check your connection and plugin name/version/URL. Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit code 1 Error output: npm ERR! code EINVALIDTAGNAME npm ERR! Invalid tag name ""1"": Tags may not have any characters that encodeURIComponent encodes. npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\knaito\AppData\Roaming\npm-cache\_logs\2018-09-06T11_53_53_697Z-debug.log Checking for any plugins added to the project that have not been installed in windows platform No differences found between plugins added to project and installed in windows platform. Continuing... Generating platform-specific config.xml from defaults for
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605669#comment-16605669
]
Jan Piotrowski (Sujan) commented on CB-14166:
-
And here is my verbose output with `-d`:
{code}
C:\Projects\experiments\foo
λ cordova create CB14166
Creating a new cordova project.
C:\Projects\experiments\foo
λ cd CB14166\
C:\Projects\experiments\foo\CB14166 (helloworld@1.0.0)
λ cordova platform add windows@5.0.0 -d
No scripts found for hook "before_platform_add".
Using cordova-fetch for cordova-windows@5.0.0
saving
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-windows@5.0.0 --production --save""
Command finished with error code 0: cmd /s /c ""C:\Program
Files\nodejs\npm.cmd" install cordova-windows@5.0.0 --production --save"
Removing "cordova-" prefix from cordova-windows
Adding windows project...
PlatformApi successfully found for platform windows
Creating Cordova Windows Project:
Path: platforms\windows
Namespace: io.cordova.hellocordova
Name: HelloCordova
Copying windows template project to
C:\Projects\experiments\foo\CB14166\platforms\windows
Copying cordova-js sources to platform_www
Copying node_modules to C:\Projects\experiments\foo\CB14166\platforms\windows
Updating manifest files with project configuration.
Windows project created with cordova-windows@5.0.0
Checking for any plugins added to the project that have not been installed in
windows platform
No differences found between plugins added to project and installed in windows
platform. Continuing...
PlatformApi successfully found for platform windows
Merging project's config.xml into platform-specific windows config.xml
Merging and updating files from [www, platforms\windows\platform_www] to
platforms\windows\www
mkdir platforms\windows\www\cordova-js-src
copy platforms\windows\platform_www\cordova-js-src\confighelper.js
platforms\windows\www\cordova-js-src\confighelper.js (new file)
copy platforms\windows\platform_www\cordova-js-src\exec.js
platforms\windows\www\cordova-js-src\exec.js (new file)
copy platforms\windows\platform_www\cordova-js-src\platform.js
platforms\windows\www\cordova-js-src\platform.js (new file)
copy platforms\windows\platform_www\cordova-js-src\splashscreen.js
platforms\windows\www\cordova-js-src\splashscreen.js (new file)
copy platforms\windows\platform_www\cordova.js
platforms\windows\www\cordova.js (updated file)
copy platforms\windows\platform_www\css\splashscreen.css
platforms\windows\www\css\splashscreen.css (updated file)
delete platforms\windows\www\img\smalllogo.png (no source)
delete platforms\windows\www\img\splashscreen.png (no source)
delete platforms\windows\www\img\storelogo.png (no source)
copy www\index.html platforms\windows\www\index.html (updated file)
copy www\js\index.js platforms\windows\www\js\index.js (updated file)
This app does not have any icons or splash screens defined
Prepared windows project successfully
No scripts found for hook "pre_package".
No scripts found for hook "before_prepare".
Checking config.xml and package.json for saved platforms that haven't been
added to the project
Checking config.xml for saved plugins that haven't been added to the project
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
No scripts found for hook "before_plugin_add".
Calling plugman.fetch on plugin "cordova-plugin-whitelist@1"
saving
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-plugin-whitelist@"1" --production --save""
Command finished with error code 0: cmd /s /c ""C:\Program
Files\nodejs\npm.cmd" install cordova-plugin-whitelist@"1" --production --save"
Copying plugin
"C:\Projects\experiments\foo\CB14166\node_modules\cordova-plugin-whitelist" =>
"C:\Projects\experiments\foo\CB14166\plugins\cordova-plugin-whitelist" Calling
plugman.install on plugin
"C:\Projects\experiments\foo\CB14166\plugins\cordova-plugin-whitelist" for
platform "windows
Installing "cordova-plugin-whitelist" for windows
Running command: cmd "/s /c
"C:\Projects\experiments\foo\CB14166\platforms\windows\cordova\version.bat""
Command finished with error code 0: cmd /s /c
"C:\Projects\experiments\foo\CB14166\platforms\windows\cordova\version.bat"
Finding scripts for "before_plugin_install" hook from plugin
cordova-plugin-whitelist on windows platform only.
No scripts found for hook "before_plugin_install".
Install start for "cordova-plugin-whitelist" on windows.
Beginning processing of action stack for windows project...
Action stack processing complete.
Install complete for cordova-plugin-whitelist on windows.
Finding scripts for "after_plugin_install" hook from plugin
cordova-plugin-whitelist on windows platform only.
No scripts found for hook "after_plugin_install".
Adding cordova-plugin-whitelist to package.json
Saved plugin info for
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605682#comment-16605682 ] Oliver Salzburg commented on CB-14166: -- Why do you have a npm.exe and not a npm.cmd? If it's not a .cmd, the whole shell aspect of it is different. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605679#comment-16605679 ] Jan Piotrowski (Sujan) commented on CB-14166: - Is the problem maybe caused by Nodist? I am using nvm-windows: https://github.com/coreybutler/nvm-windows > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605674#comment-16605674
]
Jan Piotrowski (Sujan) edited comment on CB-14166 at 9/6/18 11:39 AM:
--
Here is your install command:
{code}
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-plugin-whitelist@"1" --production --save
{code}
And here is min:
{code}
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-plugin-whitelist@"1" --production --save""
{code}
Is it posisble that your `cordova80` wrapper doesn't use the `cmd "/s /c " ...
""` and breaks the command while doing so? Or why the difference?
Also mine is run via npm.cmd, yours via npm.exe :/
was (Author: sujan12):
Here is my install command:
{code}
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-plugin-whitelist@"1" --production --save
{code}
And here is yours
{code}
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-plugin-whitelist@"1" --production --save""
{code}
Is it posisble that your `cordova80` wrapper doesn't use the `cmd "/s /c " ...
""` and breaks the command while doing so? Or why the difference?
Also mine is run via npm.cmd, yours via npm.exe :/
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605674#comment-16605674
]
Jan Piotrowski (Sujan) edited comment on CB-14166 at 9/6/18 11:39 AM:
--
Here is your install command:
{code}
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-plugin-whitelist@"1" --production --save
{code}
And here is mine:
{code}
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-plugin-whitelist@"1" --production --save""
{code}
Is it posisble that your `cordova80` wrapper doesn't use the `cmd "/s /c " ...
""` and breaks the command while doing so? Or why the difference?
Also mine is run via npm.cmd, yours via npm.exe :/
was (Author: sujan12):
Here is your install command:
{code}
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-plugin-whitelist@"1" --production --save
{code}
And here is min:
{code}
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-plugin-whitelist@"1" --production --save""
{code}
Is it posisble that your `cordova80` wrapper doesn't use the `cmd "/s /c " ...
""` and breaks the command while doing so? Or why the difference?
Also mine is run via npm.cmd, yours via npm.exe :/
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605674#comment-16605674
]
Jan Piotrowski (Sujan) edited comment on CB-14166 at 9/6/18 11:38 AM:
--
Here is my install command:
{code}
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-plugin-whitelist@"1" --production --save
{code}
And here is yours
{code}
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-plugin-whitelist@"1" --production --save""
{code}
Is it posisble that your `cordova80` wrapper doesn't use the `cmd "/s /c " ...
""` and breaks the command while doing so? Or why the difference?
was (Author: sujan12):
Here is my install command:
{code}
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-plugin-whitelist@"1" --production --save
{code}
And here is yours
{code}
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-plugin-whitelist@"1" --production --save""
{code}
Is it posisble that your `cordova80` wrapper thingie you are using adds the
`cmd "/s /c " ... ""` and breaks the command while doing so?
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605674#comment-16605674
]
Jan Piotrowski (Sujan) edited comment on CB-14166 at 9/6/18 11:41 AM:
--
Here is your install command:
{code}
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-plugin-whitelist@"1" --production --save
{code}
And here is mine:
{code}
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-plugin-whitelist@"1" --production --save""
{code}
Is it posisble that your `cordova80` wrapper doesn't use the `cmd "/s /c " ...
""` and breaks the command while doing so? Or why the difference?
Also mine is run via npm.cmd, yours via npm.exe :/
Update: Nope, I can also run
{code}
"C:\Program Files\nodejs\npm.cmd" install cordova-plugin-whitelist@"1"
--production --save
{code}
locally just fine.
was (Author: sujan12):
Here is your install command:
{code}
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-plugin-whitelist@"1" --production --save
{code}
And here is mine:
{code}
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-plugin-whitelist@"1" --production --save""
{code}
Is it posisble that your `cordova80` wrapper doesn't use the `cmd "/s /c " ...
""` and breaks the command while doing so? Or why the difference?
Also mine is run via npm.cmd, yours via npm.exe :/
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605674#comment-16605674
]
Jan Piotrowski (Sujan) edited comment on CB-14166 at 9/6/18 11:39 AM:
--
Here is my install command:
{code}
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-plugin-whitelist@"1" --production --save
{code}
And here is yours
{code}
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-plugin-whitelist@"1" --production --save""
{code}
Is it posisble that your `cordova80` wrapper doesn't use the `cmd "/s /c " ...
""` and breaks the command while doing so? Or why the difference?
Also mine is run via npm.cmd, yours via npm.exe :/
was (Author: sujan12):
Here is my install command:
{code}
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-plugin-whitelist@"1" --production --save
{code}
And here is yours
{code}
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-plugin-whitelist@"1" --production --save""
{code}
Is it posisble that your `cordova80` wrapper doesn't use the `cmd "/s /c " ...
""` and breaks the command while doing so? Or why the difference?
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605674#comment-16605674
]
Jan Piotrowski (Sujan) commented on CB-14166:
-
Here is my install command:
{code}
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-plugin-whitelist@"1" --production --save
{code}
And here is yours
{code}
Running command: cmd "/s /c ""C:\Program Files\nodejs\npm.cmd" install
cordova-plugin-whitelist@"1" --production --save""
{code}
Is it posisble that your `cordova80` wrapper thingie you are using adds the
`cmd "/s /c " ... ""` and breaks the command while doing so?
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605626#comment-16605626
]
Ken Naito commented on CB-14166:
I tried again with verbose option.
{code}
C:\Users\knaito\Documents\work\cordova
λ cordova80 create CB-14166
node
"C:\Users\knaito\Documents\App\cordova\cordova80\node_modules\cordova\bin\cordova"
create CB-14166
Creating a new cordova project.
C:\Users\knaito\Documents\work\cordova
λ cd CB-14166
C:\Users\knaito\Documents\work\cordova\CB-14166 (helloworld@1.0.0)
λ cordova80 platform add windows@5.0.0 -d
node
"C:\Users\knaito\Documents\App\cordova\cordova80\node_modules\cordova\bin\cordova"
platform add windows@5.0.0 -d
No scripts found for hook "before_platform_add".
Using cordova-fetch for cordova-windows@5.0.0
saving
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-windows@5.0.0 --production --save
Command finished with error code 0: C:\Program Files (x86)\Nodist\bin\npm.exe
install,cordova-windows@5.0.0,--production,--save
Removing "cordova-" prefix from cordova-windows
Adding windows project...
PlatformApi successfully found for platform windows
Creating Cordova Windows Project:
Path: platforms\windows
Namespace: io.cordova.hellocordova
Name: HelloCordova
Copying windows template project to
C:\Users\knaito\Documents\work\cordova\CB-14166\platforms\windows
Copying cordova-js sources to platform_www
Copying node_modules to
C:\Users\knaito\Documents\work\cordova\CB-14166\platforms\windows
Updating manifest files with project configuration.
Windows project created with cordova-windows@5.0.0
Checking for any plugins added to the project that have not been installed in
windows platform
No differences found between plugins added to project and installed in windows
platform. Continuing...
PlatformApi successfully found for platform windows
Merging project's config.xml into platform-specific windows config.xml
Merging and updating files from [www, platforms\windows\platform_www] to
platforms\windows\www
mkdir platforms\windows\www\cordova-js-src
copy platforms\windows\platform_www\cordova-js-src\confighelper.js
platforms\windows\www\cordova-js-src\confighelper.js (new file)
copy platforms\windows\platform_www\cordova-js-src\exec.js
platforms\windows\www\cordova-js-src\exec.js (new file)
copy platforms\windows\platform_www\cordova-js-src\platform.js
platforms\windows\www\cordova-js-src\platform.js (new file)
copy platforms\windows\platform_www\cordova-js-src\splashscreen.js
platforms\windows\www\cordova-js-src\splashscreen.js (new file)
copy platforms\windows\platform_www\cordova.js
platforms\windows\www\cordova.js (updated file)
copy platforms\windows\platform_www\css\splashscreen.css
platforms\windows\www\css\splashscreen.css (updated file)
delete platforms\windows\www\img\smalllogo.png (no source)
delete platforms\windows\www\img\splashscreen.png (no source)
delete platforms\windows\www\img\storelogo.png (no source)
copy www\index.html platforms\windows\www\index.html (updated file)
copy www\js\index.js platforms\windows\www\js\index.js (updated file)
This app does not have any icons or splash screens defined
Prepared windows project successfully
No scripts found for hook "pre_package".
No scripts found for hook "before_prepare".
Checking config.xml and package.json for saved platforms that haven't been
added to the project
Checking config.xml for saved plugins that haven't been added to the project
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
No scripts found for hook "before_plugin_add".
Calling plugman.fetch on plugin "cordova-plugin-whitelist@1"
saving
Running command: "C:\Program Files (x86)\Nodist\bin\npm.exe" install
cordova-plugin-whitelist@"1" --production --save
Command finished with error code 1: C:\Program Files (x86)\Nodist\bin\npm.exe
install,cordova-plugin-whitelist@"1",--production,--save
Failed to restore plugin "cordova-plugin-whitelist" from config.xml. You might
need to try adding it again. Error: Failed to fetch plugin
cordova-plugin-whitelist@1 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit code
1 Error output:
npm ERR! code EINVALIDTAGNAME
npm ERR! Invalid tag name ""1"": Tags may not have any characters that
encodeURIComponent encodes.
npm ERR! A complete log of this run can be found in:
npm ERR!
C:\Users\knaito\AppData\Roaming\npm-cache\_logs\2018-09-06T10_50_02_190Z-debug.log
Checking for any plugins added to the project that have not been installed in
windows platform
No differences found between plugins added to project and installed in windows
platform. Continuing...
Generating platform-specific config.xml from defaults for windows at
[jira] [Comment Edited] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605606#comment-16605606
]
Ken Naito edited comment on CB-14166 at 9/6/18 10:24 AM:
-
Thanks [~Sujan12] for the report.
Thanks [~OliverSalzburg].
I can see the same error by the following code. (which install
cordova-white-plugin at current directory).
main.js
{code}
var cp = require('child_process');
var cmd = 'npm';
var args = [ 'install',
'cordova-plugin-whitelist@"1"',
'--production',
'--save' ];
var child = cp.spawn(cmd, args, {});
child.stdout.setEncoding('utf-8');
child.stdout.on('data', (data) => {
console.log(data.toString());
});
child.stderr.setEncoding('utf-8');
child.stderr.on('data', (data) => {
console.log(data);
});
{code}
The result is
{code}
λ node main.js
npm ERR! code EINVALIDTAGNAME
npm ERR! Invalid tag name ""1"": Tags may not have any characters that
encodeURIComponent encodes.
npm ERR! A complete log of this run can be found in:
npm ERR!
C:\Users\knaito\AppData\Roaming\npm-cache\_logs\2018-09-06T10_21_10_015Z-debug.log
{code}
Does this work in your windows?
was (Author: knaito):
Thanks [~Sujan12] for the report.
I can see the same error by the following code. (which install
cordova-white-plugin at current directory).
main.js
{code}
var cp = require('child_process');
var cmd = 'npm';
var args = [ 'install',
'cordova-plugin-whitelist@"1"',
'--production',
'--save' ];
var child = cp.spawn(cmd, args, {});
child.stdout.setEncoding('utf-8');
child.stdout.on('data', (data) => {
console.log(data.toString());
});
child.stderr.setEncoding('utf-8');
child.stderr.on('data', (data) => {
console.log(data);
});
{code}
The result is
{code}
λ node main.js
npm ERR! code EINVALIDTAGNAME
npm ERR! Invalid tag name ""1"": Tags may not have any characters that
encodeURIComponent encodes.
npm ERR! A complete log of this run can be found in:
npm ERR!
C:\Users\knaito\AppData\Roaming\npm-cache\_logs\2018-09-06T10_21_10_015Z-debug.log
{code}
Does this work in your windows?
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605606#comment-16605606
]
Ken Naito commented on CB-14166:
Thanks [~Sujan12] for the report.
I can see the same error by the following code. (which install
cordova-white-plugin at current directory).
main.js
{code}
var cp = require('child_process');
var cmd = 'npm';
var args = [ 'install',
'cordova-plugin-whitelist@"1"',
'--production',
'--save' ];
var child = cp.spawn(cmd, args, {});
child.stdout.setEncoding('utf-8');
child.stdout.on('data', (data) => {
console.log(data.toString());
});
child.stderr.setEncoding('utf-8');
child.stderr.on('data', (data) => {
console.log(data);
});
{code}
The result is
{code}
λ node main.js
npm ERR! code EINVALIDTAGNAME
npm ERR! Invalid tag name ""1"": Tags may not have any characters that
encodeURIComponent encodes.
npm ERR! A complete log of this run can be found in:
npm ERR!
C:\Users\knaito\AppData\Roaming\npm-cache\_logs\2018-09-06T10_21_10_015Z-debug.log
{code}
Does this work in your windows?
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605559#comment-16605559
]
Oliver Salzburg commented on CB-14166:
--
This is what I have:
{code}
OliverSalzburg@oliver-pc MINGW64 ~
$ cd /tmp
OliverSalzburg@oliver-pc MINGW64 /tmp
$ node -v
v8.11.1
OliverSalzburg@oliver-pc MINGW64 /tmp
$ npm -v
5.6.0
OliverSalzburg@oliver-pc MINGW64 /tmp
$ cordova create CB-14166_5
Creating a new cordova project.
OliverSalzburg@oliver-pc MINGW64 /tmp
$ cd CB-14166_5/
OliverSalzburg@oliver-pc MINGW64 /tmp/CB-14166_5
$ cordova platform add windows@5.0.0
Using cordova-fetch for cordova-windows@5.0.0
Adding windows project...
Creating Cordova Windows Project:
Path: platforms\windows
Namespace: io.cordova.hellocordova
Name: HelloCordova
Windows project created with cordova-windows@5.0.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for windows
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving windows@~5.0.0 into config.xml file ...
{code}
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605540#comment-16605540
]
Jan Piotrowski (Sujan) commented on CB-14166:
-
I installed the same node/npm combination you are using [~knaito] and tried
again:
{code}
C:\Projects\Cordova Projects\CB-14166_4 (helloworld@1.0.0)
λ node -v
v10.5.0
C:\Projects\Cordova Projects\CB-14166_4 (helloworld@1.0.0)
λ npm -v
6.1.0
C:\Projects\Cordova Projects\CB-14166_4 (helloworld@1.0.0)
λ cordova create CB-14166_5
'cordova' is not recognized as an internal or external command,
operable program or batch file.
C:\Projects\Cordova Projects\CB-14166_4 (helloworld@1.0.0)
λ npm install -g cordova
C:\Program Files\nodejs\cordova -> C:\Program
Files\nodejs\node_modules\cordova\bin\cordova
+ cordova@8.0.0
added 415 packages from 394 contributors in 37.757s
C:\Projects\Cordova Projects\CB-14166_4 (helloworld@1.0.0)
λ cordova -v
8.0.0
C:\Projects\Cordova Projects\CB-14166_4 (helloworld@1.0.0)
λ cordova create CB-14166_5
Creating a new cordova project.
C:\Projects\Cordova Projects\CB-14166_4 (helloworld@1.0.0)
λ cd CB-14166_5\
C:\Projects\Cordova Projects\CB-14166_4\CB-14166_5 (helloworld@1.0.0)
λ cordova platform add windows@5.0.0
Using cordova-fetch for cordova-windows@5.0.0
Adding windows project...
Creating Cordova Windows Project:
Path: platforms\windows
Namespace: io.cordova.hellocordova
Name: HelloCordova
Windows project created with cordova-windows@5.0.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for windows
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving windows@~5.0.0 into config.xml file ...
C:\Projects\Cordova Projects\CB-14166_4\CB-14166_5 (helloworld@1.0.0)
λ
{code}
Still works.
Could someone else please try as well? This is strange!
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605537#comment-16605537
]
Jan Piotrowski (Sujan) commented on CB-14166:
-
That is strange. The exact same command work just fine for me:
{code}
C:\Projects\Cordova Projects
λ node -v
v10.7.0
C:\Projects\Cordova Projects
λ npm -v
6.1.0
C:\Projects\Cordova Projects
λ cordova create CB-14166_4
Creating a new cordova project.
C:\Projects\Cordova Projects
λ cd CB-14166_4
C:\Projects\Cordova Projects\CB-14166_4 (helloworld@1.0.0)
λ cordova platform add windows@5.0.0
Using cordova-fetch for cordova-windows@5.0.0
Adding windows project...
Creating Cordova Windows Project:
Path: platforms\windows
Namespace: io.cordova.hellocordova
Name: HelloCordova
Windows project created with cordova-windows@5.0.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for windows
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving windows@~5.0.0 into config.xml file ...
C:\Projects\Cordova Projects\CB-14166_4 (helloworld@1.0.0)
λ cordova -v
8.0.0
C:\Projects\Cordova Projects\CB-14166_4 (helloworld@1.0.0)
λ
{code}
!screenshot-1.png!
Any idea what could be causing this?
> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
[jira] [Updated] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-14166: Attachment: screenshot-1.png > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605350#comment-16605350
]
ASF GitHub Bot commented on CB-13496:
-
dpogue edited a comment on issue #45: CB-13496: Fix greedy regex in
plist-helpers
URL: https://github.com/apache/cordova-common/pull/45#issuecomment-418984480
#44 says that their problem is related to the same JIRA ticket
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Ken Naito
>Priority: Trivial
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605346#comment-16605346
]
ASF GitHub Bot commented on CB-13496:
-
dpogue commented on issue #45: CB-13496: Fix greedy regex in plist-helpers
URL: https://github.com/apache/cordova-common/pull/45#issuecomment-418984480
Yes (or at least, #44 says that their problem is related to the same JIRA
ticket)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Ken Naito
>Priority: Trivial
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605343#comment-16605343
]
ASF GitHub Bot commented on CB-13496:
-
codecov-io edited a comment on issue #45: CB-13496: Fix greedy regex in
plist-helpers
URL: https://github.com/apache/cordova-common/pull/45#issuecomment-418984278
#
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=h1)
Report
> Merging
[#45](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=desc) into
[master](https://codecov.io/gh/apache/cordova-common/commit/446adc1536ea8e9ac44dca8a3554b452d07aad64?src=pr=desc)
will **not change** coverage.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=tree)
```diff
@@ Coverage Diff @@
## master #45 +/- ##
===
Coverage 86.24% 86.24%
===
Files 19 19
Lines1730 1730
Branches 360 360
===
Hits 1492 1492
Misses238 238
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[src/util/plist-helpers.js](https://codecov.io/gh/apache/cordova-common/pull/45/diff?src=pr=tree#diff-c3JjL3V0aWwvcGxpc3QtaGVscGVycy5qcw==)
| `81.39% <100%> (ø)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=footer).
Last update
[446adc1...22e79cc](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Ken Naito
>Priority: Trivial
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605342#comment-16605342
]
ASF GitHub Bot commented on CB-13496:
-
codecov-io commented on issue #45: CB-13496: Fix greedy regex in plist-helpers
URL: https://github.com/apache/cordova-common/pull/45#issuecomment-418984278
#
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=h1)
Report
> Merging
[#45](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=desc) into
[master](https://codecov.io/gh/apache/cordova-common/commit/446adc1536ea8e9ac44dca8a3554b452d07aad64?src=pr=desc)
will **not change** coverage.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=tree)
```diff
@@ Coverage Diff @@
## master #45 +/- ##
===
Coverage 86.24% 86.24%
===
Files 19 19
Lines1730 1730
Branches 360 360
===
Hits 1492 1492
Misses238 238
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[src/util/plist-helpers.js](https://codecov.io/gh/apache/cordova-common/pull/45/diff?src=pr=tree#diff-c3JjL3V0aWwvcGxpc3QtaGVscGVycy5qcw==)
| `81.39% <100%> (ø)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=footer).
Last update
[446adc1...22e79cc](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Ken Naito
>Priority: Trivial
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605344#comment-16605344
]
ASF GitHub Bot commented on CB-13496:
-
erisu commented on issue #45: CB-13496: Fix greedy regex in plist-helpers
URL: https://github.com/apache/cordova-common/pull/45#issuecomment-418984322
@dpogue Is this related to
https://github.com/apache/cordova-common/issues/44?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Ken Naito
>Priority: Trivial
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605345#comment-16605345
]
ASF GitHub Bot commented on CB-13496:
-
erisu removed a comment on issue #45: CB-13496: Fix greedy regex in
plist-helpers
URL: https://github.com/apache/cordova-common/pull/45#issuecomment-418984322
@dpogue Is this related to
https://github.com/apache/cordova-common/issues/44?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Ken Naito
>Priority: Trivial
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605339#comment-16605339
]
ASF GitHub Bot commented on CB-13496:
-
dpogue opened a new pull request #45: CB-13496: Fix greedy regex in
plist-helpers
URL: https://github.com/apache/cordova-common/pull/45
### Platforms affected
iOS
### What does this PR do?
Resolves an issue where a regex was overly greedy when comparing plist
entries for merging and could result in collapsing several of them into a
single entry.
### What testing has been done on this change?
Added a test that fails with current master and passes with this change,
based on the details provided by @knight in the JIRA bug. It sounds like
this might be the cause of GH-44 as well (/fyi @donnie-jp).
Now, my fix assumes that we're always looking for `$(something)` and not
just `$something`, which *might* not be a safe assumption. Unfortunately I'm
not well-versed enough in iOS stuff to know :(
### Checklist
- [x] Reported an issue in the JIRA database
- [x] Commit message follows the format
- [x] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Ken Naito
>Priority: Trivial
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
