[GitHub] [maven-clean-plugin] dependabot[bot] opened a new pull request #13: Bump maven-site-plugin from 3.10.0 to 3.11.0
dependabot[bot] opened a new pull request #13: URL: https://github.com/apache/maven-clean-plugin/pull/13 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.10.0 to 3.11.0. Release notes Sourced from https://github.com/apache/maven-site-plugin/releases;>maven-site-plugin's releases. 3.11.0 What's Changed [MSITE-812] Missing '/' in log when deploying documentation by site:stage by https://github.com/aajisaka;>@aajisaka in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/1;>apache/maven-site-plugin#1 [MSITE-828] Upgrade jetty to recent version. Update to java 1.8 (required for jetty) by https://github.com/oflebbe;>@oflebbe in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/3;>apache/maven-site-plugin#3 MSITE-848 Update sitedescriptor.apt by https://github.com/ctubbsii;>@ctubbsii in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/13;>apache/maven-site-plugin#13 MSITE-847: Corrected link to prerequisite maven version. by https://github.com/KathrynN;>@KathrynN in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/14;>apache/maven-site-plugin#14 remove info about old version by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/19;>apache/maven-site-plugin#19 update test dependencies by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/17;>apache/maven-site-plugin#17 Only reference current version: created on website by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/18;>apache/maven-site-plugin#18 [MNGSITE-393] assume Maven 3 as default by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/20;>apache/maven-site-plugin#20 add .checkstyle to .gitignore by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/22;>apache/maven-site-plugin#22 remove unused code by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/23;>apache/maven-site-plugin#23 [MSITE-859] update apache commons lang and IO by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/25;>apache/maven-site-plugin#25 [MSITE-757] remove Maven 2 support by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/24;>apache/maven-site-plugin#24 [MSITE-757] drop Maven 2 mention by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/26;>apache/maven-site-plugin#26 docs: use https by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/28;>apache/maven-site-plugin#28 [MSITE-861] remove obsolete dependency by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/29;>apache/maven-site-plugin#29 [MNGSITE-393] remove Maven 1 and 2 info by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/30;>apache/maven-site-plugin#30 Fix script injection example in docs by https://github.com/strkkk;>@strkkk in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/35;>apache/maven-site-plugin#35 trivial change by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/38;>apache/maven-site-plugin#38 [MSITE-871] Upgrade Maven Javadoc Plugin in integration tests by https://github.com/mthmulders;>@mthmulders in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/39;>apache/maven-site-plugin#39 Bump plexus-archiver from 4.2.4 to 4.2.5 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/47;>apache/maven-site-plugin#47 Bump maven-shared-utils from 3.3.3 to 3.3.4 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/50;>apache/maven-site-plugin#50 Bump slf4jVersion from 1.7.29 to 1.7.31 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/54;>apache/maven-site-plugin#54 Bump slf4jVersion from 1.7.31 to 1.7.32 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/58;>apache/maven-site-plugin#58 Add PR template by https://github.com/slawekjaranowski;>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/63;>apache/maven-site-plugin#63 [MSITE-877] Shared GitHub Actions by https://github.com/slawekjaranowski;>@slawekjaranowski in
[GitHub] [maven-gh-actions-shared] dependabot[bot] opened a new pull request #32: Bump actions/setup-java from 2.5.0 to 3.0.0
dependabot[bot] opened a new pull request #32: URL: https://github.com/apache/maven-gh-actions-shared/pull/32 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2.5.0 to 3.0.0. Release notes Sourced from https://github.com/actions/setup-java/releases;>actions/setup-java's releases. v3.0.0 In scope of this release we changed version of the runtime Node.js for the setup-java action and updated package-lock.json file to v2. Breaking Changes With the update to Node 16 in https://github-redirect.dependabot.com/actions/setup-java/pull/290;>#290, all scripts will now be run with Node 16 rather than Node 12. Commits https://github.com/actions/setup-java/commit/f69f00b5e5324696b07f6b1c92f0470a6df00780;>f69f00b Update lockfileVersion (https://github-redirect.dependabot.com/actions/setup-java/issues/293;>#293) https://github.com/actions/setup-java/commit/2e1dfa1fb43424fa6465aaeacd047e9ef2f69961;>2e1dfa1 Update Default runtime to node16 (https://github-redirect.dependabot.com/actions/setup-java/issues/290;>#290) https://github.com/actions/setup-java/commit/a12e082d834968c1847f782019214fadd20719f6;>a12e082 Merge pull request https://github-redirect.dependabot.com/actions/setup-java/issues/224;>#224 from KengoTODA/remove-husky https://github.com/actions/setup-java/commit/04d53533c260c5d4b63a5c354d85d12ee217ebd6;>04d5353 Merge pull request https://github-redirect.dependabot.com/actions/setup-java/issues/215;>#215 from beatngu13/update-readme-cache-key https://github.com/actions/setup-java/commit/d8da887cad432a14fdb5025b0f7ebde23972b258;>d8da887 Merge pull request https://github-redirect.dependabot.com/actions/setup-java/issues/196;>#196 from oscard0m/add-cache-to-node-workflows https://github.com/actions/setup-java/commit/6df0b04fb5c90dd0ed00af7b32d9fc2c23fa11ba;>6df0b04 build: remove the config for husky https://github.com/actions/setup-java/commit/a1ad2000b3447224fd80533038cfa7091999edb9;>a1ad200 Describe cache key format in readme https://github.com/actions/setup-java/commit/faa22ddfbcd95ff97a0ad066bc5527e007c510bb;>faa22dd style(workflows): restore single quote strings See full diff in https://github.com/actions/setup-java/compare/v2.5.0...v3.0.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-gh-actions-shared] dependabot[bot] opened a new pull request #31: Bump actions/setup-java from 2.5.0 to 3.0.0
dependabot[bot] opened a new pull request #31: URL: https://github.com/apache/maven-gh-actions-shared/pull/31 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2.5.0 to 3.0.0. Release notes Sourced from https://github.com/actions/setup-java/releases;>actions/setup-java's releases. v3.0.0 In scope of this release we changed version of the runtime Node.js for the setup-java action and updated package-lock.json file to v2. Breaking Changes With the update to Node 16 in https://github-redirect.dependabot.com/actions/setup-java/pull/290;>#290, all scripts will now be run with Node 16 rather than Node 12. Commits https://github.com/actions/setup-java/commit/f69f00b5e5324696b07f6b1c92f0470a6df00780;>f69f00b Update lockfileVersion (https://github-redirect.dependabot.com/actions/setup-java/issues/293;>#293) https://github.com/actions/setup-java/commit/2e1dfa1fb43424fa6465aaeacd047e9ef2f69961;>2e1dfa1 Update Default runtime to node16 (https://github-redirect.dependabot.com/actions/setup-java/issues/290;>#290) https://github.com/actions/setup-java/commit/a12e082d834968c1847f782019214fadd20719f6;>a12e082 Merge pull request https://github-redirect.dependabot.com/actions/setup-java/issues/224;>#224 from KengoTODA/remove-husky https://github.com/actions/setup-java/commit/04d53533c260c5d4b63a5c354d85d12ee217ebd6;>04d5353 Merge pull request https://github-redirect.dependabot.com/actions/setup-java/issues/215;>#215 from beatngu13/update-readme-cache-key https://github.com/actions/setup-java/commit/d8da887cad432a14fdb5025b0f7ebde23972b258;>d8da887 Merge pull request https://github-redirect.dependabot.com/actions/setup-java/issues/196;>#196 from oscard0m/add-cache-to-node-workflows https://github.com/actions/setup-java/commit/6df0b04fb5c90dd0ed00af7b32d9fc2c23fa11ba;>6df0b04 build: remove the config for husky https://github.com/actions/setup-java/commit/a1ad2000b3447224fd80533038cfa7091999edb9;>a1ad200 Describe cache key format in readme https://github.com/actions/setup-java/commit/faa22ddfbcd95ff97a0ad066bc5527e007c510bb;>faa22dd style(workflows): restore single quote strings See full diff in https://github.com/actions/setup-java/compare/v2.5.0...v3.0.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6058) Test dependencies should override application dependencies only during testing
[
https://issues.apache.org/jira/browse/MNG-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497807#comment-17497807
]
Thorsten Glaser commented on MNG-6058:
--
You don’t see me disagreeing there. However:
* that should probably be done in Maven 4 as it’s a backwards-incompatible
change
* independent of where it’s done, we *really* _need_ a fixed current version
of {{maven-dependency-plugin}} now, for compatibility with contemporary
versions of the JDK
* newer versions of the {{maven-dependency-plugin}} can and will be run on
current-and-older versions of Maven for a *long* time, so independent of when
and where the change is introduced, {{maven-dependency-plugin}} *must* stay
aware of Maven versions not having this change being in productive use and work
well with them
> Test dependencies should override application dependencies only during testing
> --
>
> Key: MNG-6058
> URL: https://issues.apache.org/jira/browse/MNG-6058
> Project: Maven
> Issue Type: Bug
>Reporter: Christian Schulte
>Priority: Critical
> Attachments: MNG-6058.zip
>
>
> The following graph
> {code}
> POM
> |->a 2.0 compile
> |-->b 2.0 compile
> |->b 1.0 test
> {code}
> will be mediated to
> {code}
> POM
> |->a 2.0 compile
> |->b 1.0 test
> {code}
> The test dependency on b will make the transitive application dependency on b
> disappear. Maven should understand that the application dependency on b in
> version 2.0 is part of the application classpath and that the test
> dependency on b in version 1.0 is part of the test classpath only (overriding
> the application classpath). If someone adds a dependency on a project like
> that, the test dependency will disappear because the test scope is not
> transitive so that a "consuming" project gets a different application
> classpath than the project itself.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475: URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814332010 ## File path: surefire-api/src/main/java/org/apache/maven/surefire/api/booter/MasterProcessChannelEncoder.java ## @@ -37,7 +38,7 @@ void onJvmExit(); -void systemProperties( Map sysProps ); +void systemProperties( Map sysProps, RunMode runMode, Long testRunId ); Review comment: The testRunId says - this is the test set. The runMode says - normal mode, or re-run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475: URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814330891 ## File path: surefire-api/src/main/java/org/apache/maven/surefire/api/booter/MasterProcessChannelEncoder.java ## @@ -37,7 +38,7 @@ void onJvmExit(); -void systemProperties( Map sysProps ); +void systemProperties( Map sysProps, RunMode runMode, Long testRunId ); Review comment: I agree and so I have added the Javadoc, pls see the commit [2840bfa](https://github.com/apache/maven-surefire/pull/475/commits/2840bfaf14abd4574620ce6825047230636d928c). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1963) Detecting multiple test-frameworks
[
https://issues.apache.org/jira/browse/SUREFIRE-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497779#comment-17497779
]
Robert James Oxspring commented on SUREFIRE-1963:
-
Is it really healthy that the default behaviour will be to continue to silently
skip some tests? That way the problem of "silently skipping" tests by default
is entirely unresolved by this issue.
Many people won't know of the {{multipleFrameworks}} option, and with this
default behaviour won't even know if they're suffering from it. I can
understand that failing their build might be considered harsh and surprising,
but I'd have thought it should be a warning at a minimum.
> Detecting multiple test-frameworks
> --
>
> Key: SUREFIRE-1963
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1963
> Project: Maven Surefire
> Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> When multiple test frameworks are present on project classpath surefire
> chooses one framework for running test.
> During automatically provider discover some of type test can be *skipped*
> without any knowledge and information for developer.
> It is danger situation than developer can add *second* test framework to
> project and in the result some of test will be *skipped silently.*
> We can force usage one or more needed providers by adding those to plugin
> dependency and we can have control on executing test.
> h3. Proposition
> - add options {{multipleFrameworks}} *empty* (not set) by default, with
> possible value *warn* or *fail*
> h3. Scenario 1 - default
> h4. when
> - {{multipleFrameworks = *empty* - not set}}
> - many tests framework on classpath
> - no providers on plugin dependency
> h4. then
> - current behavior - choose first provider without warning about skipped test
> h3. Scenario 2
> h4. when
> - {{multipleFrameworks = *warn*}}
> - many tests framework on classpath
> - no providers on plugin dependency
> h4. then
> - print warn about multiple providers
> h3. Scenario 3
> h4. when
> - {{multipleFrameworks = *fail*}}
> - many tests framework on classpath
> - no providers on plugin dependency
> h4. then
> - print error about multiple providers and break build
> h3. Scenario 4
> h4. when
> - many tests framework on classpath
> - selected providers on plugin dependency
> h4. then
> - ignore {{multipleFrameworks}}
> - use providers from dependency list, no warning
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on pull request #477: Fix documentation: integration tests are in surefire-its now
Tibor17 commented on pull request #477: URL: https://github.com/apache/maven-surefire/pull/477#issuecomment-1050277817 Thx for contributing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 merged pull request #477: Fix documentation: integration tests are in surefire-its now
Tibor17 merged pull request #477: URL: https://github.com/apache/maven-surefire/pull/477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6058) Test dependencies should override application dependencies only during testing
[
https://issues.apache.org/jira/browse/MNG-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497730#comment-17497730
]
Elliotte Rusty Harold commented on MNG-6058:
The table on
https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html
suggests this is working as intended. If so, I think the intention should be
revisited. test scope should not override compile scope like this.
> Test dependencies should override application dependencies only during testing
> --
>
> Key: MNG-6058
> URL: https://issues.apache.org/jira/browse/MNG-6058
> Project: Maven
> Issue Type: Bug
>Reporter: Christian Schulte
>Priority: Critical
> Attachments: MNG-6058.zip
>
>
> The following graph
> {code}
> POM
> |->a 2.0 compile
> |-->b 2.0 compile
> |->b 1.0 test
> {code}
> will be mediated to
> {code}
> POM
> |->a 2.0 compile
> |->b 1.0 test
> {code}
> The test dependency on b will make the transitive application dependency on b
> disappear. Maven should understand that the application dependency on b in
> version 2.0 is part of the application classpath and that the test
> dependency on b in version 1.0 is part of the test classpath only (overriding
> the application classpath). If someone adds a dependency on a project like
> that, the test dependency will disappear because the test scope is not
> transitive so that a "consuming" project gets a different application
> classpath than the project itself.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-6058) Test dependencies should override application dependencies only during testing
[
https://issues.apache.org/jira/browse/MNG-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497728#comment-17497728
]
Elliotte Rusty Harold commented on MNG-6058:
There are two things going on here that might be independent questions:
1. Which version of b should Maven add to the compile time classpath?
2. Which scope should it have?
One could perhaps make a case that 1.0 is the correct version to select, but
there's no world I can imagine in which dropping the dependency from the
compile time classpath makes any sense at all.
> Test dependencies should override application dependencies only during testing
> --
>
> Key: MNG-6058
> URL: https://issues.apache.org/jira/browse/MNG-6058
> Project: Maven
> Issue Type: Bug
>Reporter: Christian Schulte
>Priority: Critical
> Attachments: MNG-6058.zip
>
>
> The following graph
> {code}
> POM
> |->a 2.0 compile
> |-->b 2.0 compile
> |->b 1.0 test
> {code}
> will be mediated to
> {code}
> POM
> |->a 2.0 compile
> |->b 1.0 test
> {code}
> The test dependency on b will make the transitive application dependency on b
> disappear. Maven should understand that the application dependency on b in
> version 2.0 is part of the application classpath and that the test
> dependency on b in version 1.0 is part of the test classpath only (overriding
> the application classpath). If someone adds a dependency on a project like
> that, the test dependency will disappear because the test scope is not
> transitive so that a "consuming" project gets a different application
> classpath than the project itself.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MDEP-791) Non-test scoped and transitive dependencies in compile scope
[
https://issues.apache.org/jira/browse/MDEP-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497722#comment-17497722
]
Elliotte Rusty Harold commented on MDEP-791:
Good discovery. I agree that's probably what's happening here and something we
need to fix in core.
> Non-test scoped and transitive dependencies in compile scope
>
>
> Key: MDEP-791
> URL: https://issues.apache.org/jira/browse/MDEP-791
> Project: Maven Dependency Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0, 3.3.0
>Reporter: Slawomir Jaranowski
>Priority: Critical
> Attachments: MDEP-791.zip
>
>
> When we use some dependency in test classes which is not used in production
> code but is required as transitive dependency for other used in production
> code - such dependency should not be included in {*}{{Non-test scoped}}{*}.
> Example:
> * test code use {{ObjectCodec}} from {{jackson-core}}
> * production code use only {{ObjectMapper}} from {{jackson-databind}}
> * production code don't use any classes from {{jackson-core}}
> {{jackson-core}} is needed by {{jackson-databind}} and must by in compile
> scope so should not be reported as {{Non-test scoped}}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-6058) Test dependencies should override application dependencies only during testing
[
https://issues.apache.org/jira/browse/MNG-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated MNG-6058:
---
Priority: Critical (was: Major)
> Test dependencies should override application dependencies only during testing
> --
>
> Key: MNG-6058
> URL: https://issues.apache.org/jira/browse/MNG-6058
> Project: Maven
> Issue Type: Bug
>Reporter: Christian Schulte
>Priority: Critical
> Attachments: MNG-6058.zip
>
>
> The following graph
> {code}
> POM
> |->a 2.0 compile
> |-->b 2.0 compile
> |->b 1.0 test
> {code}
> will be mediated to
> {code}
> POM
> |->a 2.0 compile
> |->b 1.0 test
> {code}
> The test dependency on b will make the transitive application dependency on b
> disappear. Maven should understand that the application dependency on b in
> version 2.0 is part of the application classpath and that the test
> dependency on b in version 1.0 is part of the test classpath only (overriding
> the application classpath). If someone adds a dependency on a project like
> that, the test dependency will disappear because the test scope is not
> transitive so that a "consuming" project gets a different application
> classpath than the project itself.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497700#comment-17497700
]
ASF GitHub Bot commented on MPLUGIN-394:
SebastianKuehn commented on pull request #73:
URL:
https://github.com/apache/maven-plugin-tools/pull/73#issuecomment-1050214668
@hboutemy, @slawekjaranowski I added an commit to use `XMLStreamReader` to
detect the encoding from the input xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-plugin-tools] SebastianKuehn commented on pull request #73: [MPLUGIN-394] Respect input encoding
SebastianKuehn commented on pull request #73: URL: https://github.com/apache/maven-plugin-tools/pull/73#issuecomment-1050214668 @hboutemy, @slawekjaranowski I added an commit to use `XMLStreamReader` to detect the encoding from the input xml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497694#comment-17497694
]
Sebastian Kühn commented on MPLUGIN-394:
Ok, I'm preparing a new commit. The tests are already running...
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497691#comment-17497691
]
Herve Boutemy commented on MPLUGIN-394:
---
just add a commit to your current one
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497690#comment-17497690
]
ASF GitHub Bot commented on MPLUGIN-394:
slawekjaranowski commented on pull request #73:
URL:
https://github.com/apache/maven-plugin-tools/pull/73#issuecomment-1050197402
@SebastianKuehn please also look at #72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497685#comment-17497685
]
Herve Boutemy edited comment on MPLUGIN-394 at 2/24/22, 7:38 PM:
-
[~SebastianKuehn] if you can amend your PR with the XmlStreamReader, it would
be nice
I'll drop my PR
I worked on encoding for years, I'm surprised that this one was missed , thanks
for the feedback and PR :)
was (Author: hboutemy):
[~SebastianKuehn] if you can amed your PR with the XmlStreamReader, it would be
nice
I'll drop my PR
I worked on encoding for years, I'm surprised that this one was missed , thanks
for the feedback and PR :)
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #73: [MPLUGIN-394] Respect input encoding
slawekjaranowski commented on pull request #73: URL: https://github.com/apache/maven-plugin-tools/pull/73#issuecomment-1050197402 @SebastianKuehn please also look at #72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497688#comment-17497688
]
ASF GitHub Bot commented on MPLUGIN-394:
hboutemy commented on pull request #72:
URL:
https://github.com/apache/maven-plugin-tools/pull/72#issuecomment-1050196304
interesting bits with XmlStreamReader to be merged to #73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497689#comment-17497689
]
Sebastian Kühn commented on MPLUGIN-394:
How do we go forward. Shall I remove my fix from the PR and rebase only the
integration test on top of PR 72? What is your suggestion?
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497687#comment-17497687
]
ASF GitHub Bot commented on MPLUGIN-394:
hboutemy closed pull request #72:
URL: https://github.com/apache/maven-plugin-tools/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-plugin-tools] hboutemy commented on pull request #72: [MPLUGIN-394] use XmlStreamReader to detect encoding instead of platform
hboutemy commented on pull request #72: URL: https://github.com/apache/maven-plugin-tools/pull/72#issuecomment-1050196304 interesting bits with XmlStreamReader to be merged to #73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] hboutemy closed pull request #72: [MPLUGIN-394] use XmlStreamReader to detect encoding instead of platform
hboutemy closed pull request #72: URL: https://github.com/apache/maven-plugin-tools/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497685#comment-17497685
]
Herve Boutemy commented on MPLUGIN-394:
---
[~SebastianKuehn] if you can amed your PR with the XmlStreamReader, it would be
nice
I'll drop my PR
I worked on encoding for years, I'm surprised that this one was missed , thanks
for the feedback and PR :)
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497683#comment-17497683
]
Herve Boutemy commented on MPLUGIN-394:
---
in fact, we need a mix between PR 72 and 73: IT from 72 (if you really doubt),
code from 73 (because detecting XML encoding is better than using a predefined
value)
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497684#comment-17497684
]
ASF GitHub Bot commented on MPLUGIN-394:
slawekjaranowski commented on pull request #72:
URL:
https://github.com/apache/maven-plugin-tools/pull/72#issuecomment-1050194371
#73 - next with tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #72: [MPLUGIN-394] use XmlStreamReader to detect encoding instead of platform
slawekjaranowski commented on pull request #72: URL: https://github.com/apache/maven-plugin-tools/pull/72#issuecomment-1050194371 #73 - next with tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497681#comment-17497681
]
Sebastian Kühn commented on MPLUGIN-394:
Sorry, I was to slow. I prepared a PR. It includes an integration test together
with my solution.
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-shade-plugin] gzsombor opened a new pull request #122: MSHADE-147: Add flag to disable jar signing verification
gzsombor opened a new pull request #122: URL: https://github.com/apache/maven-shade-plugin/pull/122 This is the rebased fix for https://issues.apache.org/jira/browse/MSHADE-147. The problem is, that certain jar files has an incorrect signature, so the shade plugin couldn't even open it. The solution for this, is a flag, which can disable this jar verification optionally. Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHADE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MSHADE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497680#comment-17497680
]
ASF GitHub Bot commented on MPLUGIN-394:
slawekjaranowski commented on pull request #72:
URL:
https://github.com/apache/maven-plugin-tools/pull/72#issuecomment-1050191618
please also rebase with current master base code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #72: [MPLUGIN-394] use XmlStreamReader to detect encoding instead of platform
slawekjaranowski commented on pull request #72: URL: https://github.com/apache/maven-plugin-tools/pull/72#issuecomment-1050191618 please also rebase with current master base code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497679#comment-17497679
]
ASF GitHub Bot commented on MPLUGIN-394:
slawekjaranowski commented on pull request #72:
URL:
https://github.com/apache/maven-plugin-tools/pull/72#issuecomment-1050190019
Is it possible to prepare a test which can confirm that works as expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #72: [MPLUGIN-394] use XmlStreamReader to detect encoding instead of platform
slawekjaranowski commented on pull request #72: URL: https://github.com/apache/maven-plugin-tools/pull/72#issuecomment-1050190019 Is it possible to prepare a test which can confirm that works as expected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497678#comment-17497678
]
ASF GitHub Bot commented on MPLUGIN-394:
SebastianKuehn opened a new pull request #73:
URL: https://github.com/apache/maven-plugin-tools/pull/73
PluginReport didn't specify an encoding while reading the
Plugin-Descriptor. This causes the fallback to the plattform encoding
and ignores the (user specified) input encoding.
This commits adds an integration test to reproduce the error and fixes
it by using the input encoding for the creation of the used Reader.
The integration tests forces the plattform encoding to CP1252 (Western
European charset used in Windows) while the source (input) and output
encoding is UTF-8.
The source file contains non-ASCII characters which have a different
representation in both encodings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-plugin-tools] SebastianKuehn opened a new pull request #73: [MPLUGIN-394] Respect input encoding
SebastianKuehn opened a new pull request #73: URL: https://github.com/apache/maven-plugin-tools/pull/73 PluginReport didn't specify an encoding while reading the Plugin-Descriptor. This causes the fallback to the plattform encoding and ignores the (user specified) input encoding. This commits adds an integration test to reproduce the error and fixes it by using the input encoding for the creation of the used Reader. The integration tests forces the plattform encoding to CP1252 (Western European charset used in Windows) while the source (input) and output encoding is UTF-8. The source file contains non-ASCII characters which have a different representation in both encodings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497627#comment-17497627
]
Slawomir Jaranowski commented on MPLUGIN-394:
-
PR with fix are welcome.
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Priority: Major
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
Sebastian Kühn created MPLUGIN-394:
--
Summary: Report-Mojo doesn't respect input encoding
Key: MPLUGIN-394
URL: https://issues.apache.org/jira/browse/MPLUGIN-394
Project: Maven Plugin Tools
Issue Type: Bug
Components: Plugin Plugin
Affects Versions: 3.6.4
Reporter: Sebastian Kühn
{{plugin:report}} reads the Plugin-XML-File with with the platform encoding
instead of the specified input encoding. This results in an broken generated
XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on pull request #474: [SUREFIRE-2026] Improve assertions in Surefire1787JUnit5IT
Tibor17 commented on pull request #474: URL: https://github.com/apache/maven-surefire/pull/474#issuecomment-1050118230 @slawekjaranowski Good job! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #474: [SUREFIRE-2026] Improve assertions in Surefire1787JUnit5IT
slawekjaranowski commented on pull request #474: URL: https://github.com/apache/maven-surefire/pull/474#issuecomment-1050103776 new issue was created, and PR updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-2026) Improve assertions in Surefire1787JUnit5IT
Slawomir Jaranowski created SUREFIRE-2026: - Summary: Improve assertions in Surefire1787JUnit5IT Key: SUREFIRE-2026 URL: https://issues.apache.org/jira/browse/SUREFIRE-2026 Project: Maven Surefire Issue Type: Improvement Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
slawekjaranowski commented on a change in pull request #475: URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814117393 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java ## @@ -128,7 +128,7 @@ public void onJvmExit() } @Override -public void systemProperties( Map sysProps ) +public void systemProperties( Map sysProps, RunMode rm, Long testRunId ) Review comment: ok, so it is next issue to clean up it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
slawekjaranowski commented on a change in pull request #475: URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814116847 ## File path: surefire-api/src/main/java/org/apache/maven/surefire/api/booter/MasterProcessChannelEncoder.java ## @@ -37,7 +38,7 @@ void onJvmExit(); -void systemProperties( Map sysProps ); +void systemProperties( Map sysProps, RunMode runMode, Long testRunId ); Review comment: @Tibor17 can you add some documentation for this method ... or you have such plan? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475: URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814101709 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java ## @@ -128,7 +128,7 @@ public void onJvmExit() } @Override -public void systemProperties( Map sysProps ) +public void systemProperties( Map sysProps, RunMode rm, Long testRunId ) Review comment: You'r right, the `runMode` as a test status should not be in 3 classes. It should be only in one, e.g. in the: `JUnit4RunListener` which implements framework's listener `org.junit.runner.notification.RunListener`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475: URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814101709 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java ## @@ -128,7 +128,7 @@ public void onJvmExit() } @Override -public void systemProperties( Map sysProps ) +public void systemProperties( Map sysProps, RunMode rm, Long testRunId ) Review comment: Your right, the `runMode` as a test status should not be in 3 classes. It should be only in one, e.g. in the: `JUnit4RunListener` which implements framework's listener `org.junit.runner.notification.RunListener`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475: URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814101709 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java ## @@ -128,7 +128,7 @@ public void onJvmExit() } @Override -public void systemProperties( Map sysProps ) +public void systemProperties( Map sysProps, RunMode rm, Long testRunId ) Review comment: Your right, the `runMode` as a status should not be in 3 classes. It should be only in one, e.g. in the: `JUnit4RunListener` which implements framework's listener `org.junit.runner.notification.RunListener`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475: URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814101709 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java ## @@ -128,7 +128,7 @@ public void onJvmExit() } @Override -public void systemProperties( Map sysProps ) +public void systemProperties( Map sysProps, RunMode rm, Long testRunId ) Review comment: Your right, the `runMode` as a status should not be in 3 classes. It should be only in one, e.g. in the: `JUnit4RunListener` which implements framework's listene `org.junit.runner.notification.RunListener`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475: URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814097522 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java ## @@ -128,7 +128,7 @@ public void onJvmExit() } @Override -public void systemProperties( Map sysProps ) +public void systemProperties( Map sysProps, RunMode rm, Long testRunId ) Review comment: The fields `runMode` will be deleted in `ForkinRunListener` and `EventChannelEncoder`. This PR has only prepared changes in one method signature. The implementation of this abstract method comes right after. This PR is only an intermediate step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475: URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814097522 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java ## @@ -128,7 +128,7 @@ public void onJvmExit() } @Override -public void systemProperties( Map sysProps ) +public void systemProperties( Map sysProps, RunMode rm, Long testRunId ) Review comment: The fields `runMode` will be deleted in `ForkinRunListener` and `EventChannelEncoder`. This PR has only prepared changes in one method signature. The implementation of this abstract method comes right after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
slawekjaranowski commented on a change in pull request #475:
URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814091511
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/booter/ForkingRunListener.java
##
@@ -68,7 +68,7 @@ public void testSetStarting( TestSetReportEntry report )
@Override
public void testSetCompleted( TestSetReportEntry report )
{
-target.systemProperties( report.getSystemProperties() );
+target.systemProperties( report.getSystemProperties(), null, null );
Review comment:
So what for `EventChannelEncoder` has `runMode` field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7049) Version range resolution downloads all poms, not just the highest version
[ https://issues.apache.org/jira/browse/MNG-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497565#comment-17497565 ] Jim Hughes commented on MNG-7049: - [~michael-o] others, I looked at this briefly and tried to write an integration test. It seems like most IT check only the output of Maven rather than checking on internal work that is done. Is there something I'm missing that would help write an IT for this behavior? Otherwise, it may need to be checked in a unit test. > Version range resolution downloads all poms, not just the highest version > - > > Key: MNG-7049 > URL: https://issues.apache.org/jira/browse/MNG-7049 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Moti Nisenson-Ken >Priority: Major > > When specifying a version range for a dependency, maven will download and try > to resolve all poms in that range which satisfy the range. The usage however > is only to use the highestVersion. This causes two issues: > # Performance - it's downloading numerous poms that aren't needed. > # Fragility - if the version range covers any "bad" poms, then the build > will fail. For example, consider that for a specific version, the parent of a > pom is not present in the repository. This is enough to fail any build with a > version range covering that specific version, as the range resolution stage > will not complete. This is particularly harmful when that version would not > be selected as the highest, anyway. > Recommend to have a system property to control the desired behavior - it > should be possible to short-circuit loading all the versions and to just to > load the highest version. > For another user report of this see: > [https://stackoverflow.com/questions/25047859/restrict-maven-to-not-download-all-poms] > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #476: [SUREFIRE-2010] Parameterized Selection Does not Work
Tibor17 edited a comment on pull request #476: URL: https://github.com/apache/maven-surefire/pull/476#issuecomment-1050062272 Hi @DaGeRe , The JIRA is not well suited to read code patches. We can discuss the code even if the CI would fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #476: [SUREFIRE-2010] Parameterized Selection Does not Work
Tibor17 edited a comment on pull request #476: URL: https://github.com/apache/maven-surefire/pull/476#issuecomment-1050062272 Hi @DaGeRe , The JIRA is not well suited to read code patches. So even if the test fails, we can discuss the code even if the CI would fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #476: [SUREFIRE-2010] Parameterized Selection Does not Work
Tibor17 commented on pull request #476: URL: https://github.com/apache/maven-surefire/pull/476#issuecomment-1050062272 Hi @DaGeRe , The JIRA is not well suite to read code patches. So even if the test fails, we can discuss the code even if the CI would fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475:
URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814074238
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/booter/ForkingRunListener.java
##
@@ -68,7 +68,7 @@ public void testSetStarting( TestSetReportEntry report )
@Override
public void testSetCompleted( TestSetReportEntry report )
{
-target.systemProperties( report.getSystemProperties() );
+target.systemProperties( report.getSystemProperties(), null, null );
Review comment:
The `target` is not JUnit's RunListener implementation.
Only the framework's listener may have this data `runMode` and be "stateful".
The `target` is a pure encoder, and so it should not have any notion about
stateful data regarding test status. It should only receive data, encode it,
and send it to a channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475:
URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814074238
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/booter/ForkingRunListener.java
##
@@ -68,7 +68,7 @@ public void testSetStarting( TestSetReportEntry report )
@Override
public void testSetCompleted( TestSetReportEntry report )
{
-target.systemProperties( report.getSystemProperties() );
+target.systemProperties( report.getSystemProperties(), null, null );
Review comment:
The `target` is not JUnit's RunListener implementation.
Only the framework's listener may have this data `runMode` and be "stateful".
The `target` is a pure encoder, and so it should not have any notion about
stateful data regarding test status. It should only receive data, encode it,
and send to a channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475:
URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814074238
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/booter/ForkingRunListener.java
##
@@ -68,7 +68,7 @@ public void testSetStarting( TestSetReportEntry report )
@Override
public void testSetCompleted( TestSetReportEntry report )
{
-target.systemProperties( report.getSystemProperties() );
+target.systemProperties( report.getSystemProperties(), null, null );
Review comment:
The `target` is not JUnit's RunListener implementation.
Only the framework's listener may have this data and be "stateful".
The `target` is a pure encoder, and so it should not have any notion about
stateful data regarding test status. It should only receive data, encode it,
and send to a channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475:
URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814068564
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/booter/ForkingRunListener.java
##
@@ -68,7 +68,7 @@ public void testSetStarting( TestSetReportEntry report )
@Override
public void testSetCompleted( TestSetReportEntry report )
{
-target.systemProperties( report.getSystemProperties() );
+target.systemProperties( report.getSystemProperties(), null, null );
Review comment:
I did split the entire work of
[SUREFIRE-1860](https://issues.apache.org/jira/browse/SUREFIRE-1860) into 5
pieces.
The line you are asking for is in my IDEA:
`target.systemProperties( report.getSystemProperties(), report.getRunMode(),
report.getTestRunId() );`
Both getters will come in the next PR right after, see
[SUREFIRE-2015](https://issues.apache.org/jira/browse/SUREFIRE-2015)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 commented on a change in pull request #475:
URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814068564
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/booter/ForkingRunListener.java
##
@@ -68,7 +68,7 @@ public void testSetStarting( TestSetReportEntry report )
@Override
public void testSetCompleted( TestSetReportEntry report )
{
-target.systemProperties( report.getSystemProperties() );
+target.systemProperties( report.getSystemProperties(), null, null );
Review comment:
I did split the entire work of
[SUREFIRE-1860](https://issues.apache.org/jira/browse/SUREFIRE-1860) into 5
pieces.
The line you are asking for is in my IDEA:
`target.systemProperties( report.getSystemProperties(), report.getRunMode(),
report.getTestRunId() );`
Both getters will come in the next PR right after -
[SUREFIRE-2015](https://issues.apache.org/jira/browse/SUREFIRE-2015)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-deploy-plugin] micheljung commented on pull request #3: Skip specified attached artifacts from deploy
micheljung commented on pull request #3: URL: https://github.com/apache/maven-deploy-plugin/pull/3#issuecomment-1050031590 In my case, I produce an `-executable` JAR with the `spring-boot-maven-plugin` which is a JAR prefixed with a shell script or so. Our artifact repository, however, doesn't allow uploading such invalid JARs (and the artifact of interest is the resulting RPM anyways). Therefore, I'd like to exclude it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] DaGeRe opened a new pull request #477: Fix documentation: integration tests are in surefire-its now
DaGeRe opened a new pull request #477: URL: https://github.com/apache/maven-surefire/pull/477 The folder `surefire-integration-tests` has been renamed to `surefire-its`. This should corrected in the documentation. Since this is like a typo, I did not create a ticket. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean install`). To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2010) Parameterized Selection Does not Work
[
https://issues.apache.org/jira/browse/SUREFIRE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497432#comment-17497432
]
David Georg Reichelt commented on SUREFIRE-2010:
[~tibordigana]
Thanks for the quick reply.
I was a little surprised that I can post my pullrequest on GH now, since the
test currently doesn't really work (it only calls test, without a selector, and
it does not check whether certain tests are selected). Nevertheless, I created
the pullrequest: [https://github.com/apache/maven-surefire/pull/476]
Hope this helps. If you need further input from me, tell me.
> Parameterized Selection Does not Work
> -
>
> Key: SUREFIRE-2010
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2010
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, JUnit 5.x support
>Affects Versions: 3.0.0-M5
> Environment: Maven 3.6.3 and Ubuntu 20.04, but I suppose it happens
> everywhere
>Reporter: David Georg Reichelt
>Priority: Major
>
> In the current version (and also M6-SNAPSHOT), maven surefire is not capable
> of selecting parameterized tests based on the index. In
> [https://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html,]
> it is described that this should work by providing the index, e.g. using
> {code:java}
> -Dtest=MyTest#method[$INDEX]{code}
> or
> {code:java}
> -Dtest=MyTest#method[*]{code}
> for all.
>
> This happens both for JUnit 4 and JUnit 5.
> I created a mwe demonstrating this problem:
> [https://github.com/DaGeRe/parameterized-selection-demo]
> As far as I see it, the TestMethodFilter in
> [https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/TestMethodFilter.java#L45]
> does the filtering, but has only a descriptor in the form:
>
> {code:java}
> [engine:junit-jupiter]/[class:de.dagere.peass.ExampleTest]/[test-template:test(int)]{code}
>
> So there is not the concrete value, but only the information that an int
> should be provided. Therefore, I currently see not any option to fix this
> easily or get this running using a regex pattern.
> Do I oversee something, or is it planned to fix this? If not, it would be
> better to update the documentation site accordingly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] DaGeRe opened a new pull request #476: [SUREFIRE-2010] Parameterized Selection Does not Work
DaGeRe opened a new pull request #476: URL: https://github.com/apache/maven-surefire/pull/476 This pull request provides the example project for an integration test, that checks whether selectors are able to select parameterized tests, e.g. `package.TestClazz#method[1]`, where 1 is the index of the test. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
slawekjaranowski commented on a change in pull request #475:
URL: https://github.com/apache/maven-surefire/pull/475#discussion_r813866710
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/booter/MasterProcessChannelEncoder.java
##
@@ -37,7 +38,7 @@
void onJvmExit();
-void systemProperties( Map sysProps );
+void systemProperties( Map sysProps, RunMode runMode, Long
testRunId );
Review comment:
method name is not descriptive what does do .. read/write/verify
properties?
Now new params - what for?
documentation is needed
##
File path:
surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java
##
@@ -128,7 +128,7 @@ public void onJvmExit()
}
@Override
-public void systemProperties( Map sysProps )
+public void systemProperties( Map sysProps, RunMode rm,
Long testRunId )
Review comment:
we already have field with the same name and type `runMode`
why not use filed from instance?
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/booter/ForkingRunListener.java
##
@@ -68,7 +68,7 @@ public void testSetStarting( TestSetReportEntry report )
@Override
public void testSetCompleted( TestSetReportEntry report )
{
-target.systemProperties( report.getSystemProperties() );
+target.systemProperties( report.getSystemProperties(), null, null );
Review comment:
In this class we have filed `runMode`
- why not used here?
- why is not propagated to `target`?
##
File path:
surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/EventChannelEncoder.java
##
@@ -128,7 +128,7 @@ public void onJvmExit()
}
@Override
-public void systemProperties( Map sysProps )
+public void systemProperties( Map sysProps, RunMode rm,
Long testRunId )
Review comment:
field `runMode` sometime is used ... sometime is overridden by method
params in this class
line: 389, 419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2010) Parameterized Selection Does not Work
[
https://issues.apache.org/jira/browse/SUREFIRE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497363#comment-17497363
]
Tibor Digana commented on SUREFIRE-2010:
[~DaGeRe1989]
Excellent!
So you have coped with all these troubles and you wrote the test.
Now you can post the pullrequest on GH.
Acctually, I have expect a test error. This would drive us to:
* write the test
* fail the test as expected
* understand the problem
* and finally fix the problem
We are in 50% of the entire work, but that's pretty normal.
> Parameterized Selection Does not Work
> -
>
> Key: SUREFIRE-2010
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2010
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, JUnit 5.x support
>Affects Versions: 3.0.0-M5
> Environment: Maven 3.6.3 and Ubuntu 20.04, but I suppose it happens
> everywhere
>Reporter: David Georg Reichelt
>Priority: Major
>
> In the current version (and also M6-SNAPSHOT), maven surefire is not capable
> of selecting parameterized tests based on the index. In
> [https://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html,]
> it is described that this should work by providing the index, e.g. using
> {code:java}
> -Dtest=MyTest#method[$INDEX]{code}
> or
> {code:java}
> -Dtest=MyTest#method[*]{code}
> for all.
>
> This happens both for JUnit 4 and JUnit 5.
> I created a mwe demonstrating this problem:
> [https://github.com/DaGeRe/parameterized-selection-demo]
> As far as I see it, the TestMethodFilter in
> [https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/TestMethodFilter.java#L45]
> does the filtering, but has only a descriptor in the form:
>
> {code:java}
> [engine:junit-jupiter]/[class:de.dagere.peass.ExampleTest]/[test-template:test(int)]{code}
>
> So there is not the concrete value, but only the information that an int
> should be provided. Therefore, I currently see not any option to fix this
> easily or get this running using a regex pattern.
> Do I oversee something, or is it planned to fix this? If not, it would be
> better to update the documentation site accordingly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SUREFIRE-2010) Parameterized Selection Does not Work
[
https://issues.apache.org/jira/browse/SUREFIRE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497354#comment-17497354
]
David Georg Reichelt commented on SUREFIRE-2010:
Unfortunately, I did not succeed to write a working integration test.
I looked at
[https://maven.apache.org/surefire/maven-surefire-plugin/developing.html,]
which stated that I should to
{code:java}
cd surefire-integration-tests/src/test/resources/failsafe-buildfail
mvn -Dsurefire.version=2.12 verify {code}
This did not work (and the link provided there is also not working), since the
folder now seems to be named
{code:java}
surefire-its
{code}
Could you fix this, or should I just change
[https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/developing.apt.vm]
and create a PR?
Doing
{code:java}
surefire-its/src/test/resources/surefire-1146-rerunFailingTests-with-Parameterized
mvn -Dsurefire.version=3.0.0-M6-SNAPSHOT verify
{code}
works fine for me and yields the output I would expect.
Now I would like to write the integration test itself. After some fiddeling, I
got the old test running by
{code:java}
mvn verify -Dsurefire.version=3.0.0-M6-SNAPSHOT
-Dtest=Surefire1146RerunFailedAndParameterizedIT
{code}
Unfortunately, for my new test
[https://github.com/DaGeRe/maven-surefire/blob/surefire-2010/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire2010ParameterizedSelectionDoesNotWorkIT.java]
(that currently does not select anything and should just execute the tests),
the output of
{code:java}
mvn verify -Dsurefire.version=3.0.0-M6-SNAPSHOT
-Dtest=Surefire2010ParameterizedSelectionDoesNotWorkIT
{code}
is
{code:java}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile
(default-testCompile) on project jiras-surefire-2010: Compilation failure
[ERROR]
/tmp/Surefire2010ParameterizedSelectionDoesNotWorkIT_testJUnit4/src/test/java/junitplatform/ParametersTest.java:[37,22]
static interface method invocations are not supported in
-source 7
[ERROR] (use -source 8 or higher to enable static interface method
invocations)
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile
(default-testCompile) on project jiras-sure
fire-2010: Compilation failure
/tmp/Surefire2010ParameterizedSelectionDoesNotWorkIT_testJUnit4/src/test/java/junitplatform/ParametersTest.java:[37,22]
static interface method invocations are not supported in -source 7
{code}
I tried to fix this by adding
{code:java}
1.8
1.8
{code}
to the
{code:java}
surefire-its/src/test/resources/surefire-2010-parameterized-selection-does-not-work/pom.xml
{code}
but then I got the following output:
{code:java}
[ERROR]
junitplatform.ParametersTest.testOneFailingPassingTest(ConnectionPoolFactory)[2]
Time elapsed: 0.005 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
at
junitplatform.ParametersTest.testOneFailingPassingTest(ParametersTest.java:57)
[INFO] Running junitplatform.FlakyFirstTimeTest
Failing test
Error test
Passing test
[ERROR] Tests run: 3, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 0.004 s
<<< FAILURE! - in junitplatform.FlakyFirstTimeTest
[ERROR]
[GitHub] [maven-surefire] Tibor17 opened a new pull request #475: [SUREFIRE-2025] Updated abstractions which helps associating systemProperties() with a test
Tibor17 opened a new pull request #475: URL: https://github.com/apache/maven-surefire/pull/475 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-2025) Updated abstractions which helps associating systemProperties() with a test
Tibor Digana created SUREFIRE-2025: -- Summary: Updated abstractions which helps associating systemProperties() with a test Key: SUREFIRE-2025 URL: https://issues.apache.org/jira/browse/SUREFIRE-2025 Project: Maven Surefire Issue Type: Improvement Components: Maven Failsafe Plugin, Maven Surefire Plugin, process forking Reporter: Tibor Digana Assignee: Tibor Digana Fix For: 3.0.0-M6 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SUREFIRE-2022) MAVEN - PluginExecutionException
[
https://issues.apache.org/jira/browse/SUREFIRE-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497315#comment-17497315
]
Tibor Digana commented on SUREFIRE-2022:
[~jojaafar]
You mean that the build has finished with the error in the #comment-17496782 ?
Can you attach the dump file from surefire-reports?
See this in the log {{[ERROR] Please refer to
/azp/agent/_work/1/s/target/surefire-reports for the individual test results.}}
> MAVEN - PluginExecutionException
>
>
> Key: SUREFIRE-2022
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2022
> Project: Maven Surefire
> Issue Type: Bug
> Environment: SNAPSHOT : 0.1
> Maven: 3.8.4
> Maven-Surefire : 2.19
>Reporter: Jo Jaafar
>Assignee: Tibor Digana
>Priority: Blocker
> Labels: newbie
> Fix For: waiting-for-feedback
>
> Attachments: directory-list.PNG, screenshot-1.png
>
> Original Estimate: 68h
> Remaining Estimate: 68h
>
> The issue started whereby the maven surefire plugin is turn up failed. even
> before this theres issue with maven 2.4.1 but i have upgraded to maven 3.8.4.
> As whole and by right it should solve the mentioned issues. But still
> appeared.
>
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] Failed to
> execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test
> (default-test) on project ABCApplications _Automation: Execution default-test
> of goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test failed:
> testSuiteXmlFiles0 has null value -> [Help 1]{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] {color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] To see the
> full stack trace of the errors, re-run Maven with the -e switch.{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] Re-run
> Maven using the -X switch to enable full debug logging.{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] {color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] For more
> information about the errors and possible solutions, please read the
> following articles:{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException{color}
> {color:#11}The process
> 'C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.4\bin\mvn.cmd' failed
> with exit code 1{color}
> {color:#11}Could not retrieve code analysis results - Maven run
> failed.{color}
> {color:#11}No test result files matching
> D:\a\1\s{color}{color:#aa0982}\*{color}{color:#994cc3}*{color}{color:#994cc3}\surefire-reports\TEST-{color}{color:#994cc3}*{color}{color:#11}.xml
> were found, so publishing JUnit test results is being skipped.{color}
> {color:#11}##[{color}{color:#403f53}error{color}{color:#11}]Build
> failed.{color}
> {color:#11}Finishing: Maven pom.xml{color}
>
> Since im new to JAVA (recently change). Theres alot of gray area on this.
> Hope everyone who see this can help me on this. its already prolong for quite
> sometime.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (SUREFIRE-2022) MAVEN - PluginExecutionException
[
https://issues.apache.org/jira/browse/SUREFIRE-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497315#comment-17497315
]
Tibor Digana edited comment on SUREFIRE-2022 at 2/24/22, 10:21 AM:
---
[~jojaafar]
You mean that the build has finished with the error in the #comment-17496782 ?
Can you attach all dump files from surefire-reports?
See this in the log {{[ERROR] Please refer to
/azp/agent/_work/1/s/target/surefire-reports for the individual test results.}}
was (Author: tibor17):
[~jojaafar]
You mean that the build has finished with the error in the #comment-17496782 ?
Can you attach the dump file from surefire-reports?
See this in the log {{[ERROR] Please refer to
/azp/agent/_work/1/s/target/surefire-reports for the individual test results.}}
> MAVEN - PluginExecutionException
>
>
> Key: SUREFIRE-2022
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2022
> Project: Maven Surefire
> Issue Type: Bug
> Environment: SNAPSHOT : 0.1
> Maven: 3.8.4
> Maven-Surefire : 2.19
>Reporter: Jo Jaafar
>Assignee: Tibor Digana
>Priority: Blocker
> Labels: newbie
> Fix For: waiting-for-feedback
>
> Attachments: directory-list.PNG, screenshot-1.png
>
> Original Estimate: 68h
> Remaining Estimate: 68h
>
> The issue started whereby the maven surefire plugin is turn up failed. even
> before this theres issue with maven 2.4.1 but i have upgraded to maven 3.8.4.
> As whole and by right it should solve the mentioned issues. But still
> appeared.
>
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] Failed to
> execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test
> (default-test) on project ABCApplications _Automation: Execution default-test
> of goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test failed:
> testSuiteXmlFiles0 has null value -> [Help 1]{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] {color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] To see the
> full stack trace of the errors, re-run Maven with the -e switch.{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] Re-run
> Maven using the -X switch to enable full debug logging.{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] {color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] For more
> information about the errors and possible solutions, please read the
> following articles:{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException{color}
> {color:#11}The process
> 'C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.4\bin\mvn.cmd' failed
> with exit code 1{color}
> {color:#11}Could not retrieve code analysis results - Maven run
> failed.{color}
> {color:#11}No test result files matching
> D:\a\1\s{color}{color:#aa0982}\*{color}{color:#994cc3}*{color}{color:#994cc3}\surefire-reports\TEST-{color}{color:#994cc3}*{color}{color:#11}.xml
> were found, so publishing JUnit test results is being skipped.{color}
> {color:#11}##[{color}{color:#403f53}error{color}{color:#11}]Build
> failed.{color}
> {color:#11}Finishing: Maven pom.xml{color}
>
> Since im new to JAVA (recently change). Theres alot of gray area on this.
> Hope everyone who see this can help me on this. its already prolong for quite
> sometime.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SUREFIRE-2022) MAVEN - PluginExecutionException
[
https://issues.apache.org/jira/browse/SUREFIRE-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497303#comment-17497303
]
Jo Jaafar commented on SUREFIRE-2022:
-
It does work in some ways but it still unable to complete the entire test.
Which when i implemented this on azure pipeline. It takes longer time to
process. But the process mentioned here never complete.
So i was under a impression. Do i need to do, to change the way it is or what?
I do know that the processin local does process longer time, but it should not
be a matter as the resources are not sharing..
> MAVEN - PluginExecutionException
>
>
> Key: SUREFIRE-2022
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2022
> Project: Maven Surefire
> Issue Type: Bug
> Environment: SNAPSHOT : 0.1
> Maven: 3.8.4
> Maven-Surefire : 2.19
>Reporter: Jo Jaafar
>Assignee: Tibor Digana
>Priority: Blocker
> Labels: newbie
> Fix For: waiting-for-feedback
>
> Attachments: directory-list.PNG, screenshot-1.png
>
> Original Estimate: 68h
> Remaining Estimate: 68h
>
> The issue started whereby the maven surefire plugin is turn up failed. even
> before this theres issue with maven 2.4.1 but i have upgraded to maven 3.8.4.
> As whole and by right it should solve the mentioned issues. But still
> appeared.
>
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] Failed to
> execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test
> (default-test) on project ABCApplications _Automation: Execution default-test
> of goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test failed:
> testSuiteXmlFiles0 has null value -> [Help 1]{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] {color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] To see the
> full stack trace of the errors, re-run Maven with the -e switch.{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] Re-run
> Maven using the -X switch to enable full debug logging.{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] {color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] For more
> information about the errors and possible solutions, please read the
> following articles:{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException{color}
> {color:#11}The process
> 'C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.4\bin\mvn.cmd' failed
> with exit code 1{color}
> {color:#11}Could not retrieve code analysis results - Maven run
> failed.{color}
> {color:#11}No test result files matching
> D:\a\1\s{color}{color:#aa0982}\*{color}{color:#994cc3}*{color}{color:#994cc3}\surefire-reports\TEST-{color}{color:#994cc3}*{color}{color:#11}.xml
> were found, so publishing JUnit test results is being skipped.{color}
> {color:#11}##[{color}{color:#403f53}error{color}{color:#11}]Build
> failed.{color}
> {color:#11}Finishing: Maven pom.xml{color}
>
> Since im new to JAVA (recently change). Theres alot of gray area on this.
> Hope everyone who see this can help me on this. its already prolong for quite
> sometime.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (SUREFIRE-2022) MAVEN - PluginExecutionException
[
https://issues.apache.org/jira/browse/SUREFIRE-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497293#comment-17497293
]
Tibor Digana edited comment on SUREFIRE-2022 at 2/24/22, 9:46 AM:
--
[~jojaafar]
Any build results regarding this configuration?
{code:xml}
testng.xml
${url}
{code}
We use very similar config in our ITs and it works fine!
was (Author: tibor17):
[~jojaafar]
Any build results regarding this configuration?
{code:xml}
testng.xml
${url}
{code}
We use veri similar config in our ITs and it works fine!
> MAVEN - PluginExecutionException
>
>
> Key: SUREFIRE-2022
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2022
> Project: Maven Surefire
> Issue Type: Bug
> Environment: SNAPSHOT : 0.1
> Maven: 3.8.4
> Maven-Surefire : 2.19
>Reporter: Jo Jaafar
>Assignee: Tibor Digana
>Priority: Blocker
> Labels: newbie
> Fix For: waiting-for-feedback
>
> Attachments: directory-list.PNG, screenshot-1.png
>
> Original Estimate: 68h
> Remaining Estimate: 68h
>
> The issue started whereby the maven surefire plugin is turn up failed. even
> before this theres issue with maven 2.4.1 but i have upgraded to maven 3.8.4.
> As whole and by right it should solve the mentioned issues. But still
> appeared.
>
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] Failed to
> execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test
> (default-test) on project ABCApplications _Automation: Execution default-test
> of goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test failed:
> testSuiteXmlFiles0 has null value -> [Help 1]{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] {color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] To see the
> full stack trace of the errors, re-run Maven with the -e switch.{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] Re-run
> Maven using the -X switch to enable full debug logging.{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] {color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] For more
> information about the errors and possible solutions, please read the
> following articles:{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException{color}
> {color:#11}The process
> 'C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.4\bin\mvn.cmd' failed
> with exit code 1{color}
> {color:#11}Could not retrieve code analysis results - Maven run
> failed.{color}
> {color:#11}No test result files matching
> D:\a\1\s{color}{color:#aa0982}\*{color}{color:#994cc3}*{color}{color:#994cc3}\surefire-reports\TEST-{color}{color:#994cc3}*{color}{color:#11}.xml
> were found, so publishing JUnit test results is being skipped.{color}
> {color:#11}##[{color}{color:#403f53}error{color}{color:#11}]Build
> failed.{color}
> {color:#11}Finishing: Maven pom.xml{color}
>
> Since im new to JAVA (recently change). Theres alot of gray area on this.
> Hope everyone who see this can help me on this. its already prolong for quite
> sometime.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SUREFIRE-2022) MAVEN - PluginExecutionException
[
https://issues.apache.org/jira/browse/SUREFIRE-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497293#comment-17497293
]
Tibor Digana commented on SUREFIRE-2022:
[~jojaafar]
Any build results regarding this configuration?
{code:xml}
testng.xml
${url}
{code}
We use veri similar config in our ITs and it works fine!
> MAVEN - PluginExecutionException
>
>
> Key: SUREFIRE-2022
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2022
> Project: Maven Surefire
> Issue Type: Bug
> Environment: SNAPSHOT : 0.1
> Maven: 3.8.4
> Maven-Surefire : 2.19
>Reporter: Jo Jaafar
>Assignee: Tibor Digana
>Priority: Blocker
> Labels: newbie
> Fix For: waiting-for-feedback
>
> Attachments: directory-list.PNG, screenshot-1.png
>
> Original Estimate: 68h
> Remaining Estimate: 68h
>
> The issue started whereby the maven surefire plugin is turn up failed. even
> before this theres issue with maven 2.4.1 but i have upgraded to maven 3.8.4.
> As whole and by right it should solve the mentioned issues. But still
> appeared.
>
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] Failed to
> execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test
> (default-test) on project ABCApplications _Automation: Execution default-test
> of goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test failed:
> testSuiteXmlFiles0 has null value -> [Help 1]{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] {color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] To see the
> full stack trace of the errors, re-run Maven with the -e switch.{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] Re-run
> Maven using the -X switch to enable full debug logging.{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] {color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] For more
> information about the errors and possible solutions, please read the
> following articles:{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException{color}
> {color:#11}The process
> 'C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.4\bin\mvn.cmd' failed
> with exit code 1{color}
> {color:#11}Could not retrieve code analysis results - Maven run
> failed.{color}
> {color:#11}No test result files matching
> D:\a\1\s{color}{color:#aa0982}\*{color}{color:#994cc3}*{color}{color:#994cc3}\surefire-reports\TEST-{color}{color:#994cc3}*{color}{color:#11}.xml
> were found, so publishing JUnit test results is being skipped.{color}
> {color:#11}##[{color}{color:#403f53}error{color}{color:#11}]Build
> failed.{color}
> {color:#11}Finishing: Maven pom.xml{color}
>
> Since im new to JAVA (recently change). Theres alot of gray area on this.
> Hope everyone who see this can help me on this. its already prolong for quite
> sometime.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MCOMPILER-415) NullPointerException from javac when compiling AntlrWorks-Jank
[
https://issues.apache.org/jira/browse/MCOMPILER-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497269#comment-17497269
]
Vincent Latombe commented on MCOMPILER-415:
---
I'm commenting here in the hope that someone from the JDK sees this
I think the problem was introduced in openjdk due to this commit
[https://github.com/openjdk/jdk/commit/e5c81018946876d91f89a10999d3582eb592c340#diff-e4e91210b5366d98b565bcb74c4e7d1ed85adaa5045541822c3bb10589dcR906-R908]
It is closing the JavaCompiler object implicitly once the compilation is done.
However the resulting Diagnostic objects (obtained by
[plexus-compiler-api|https://github.com/codehaus-plexus/plexus-compiler/blob/4291bb706b9e3e27eb0c24cc547f248073e8819a/plexus-compilers/plexus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavaxToolsCompiler.java#L116-L138]
legally using what is documented in
[https://docs.oracle.com/javase/8/docs/api/javax/tools/JavaCompiler.html)]
still holds references that can be resolved only once the compilation task is
done.
> NullPointerException from javac when compiling AntlrWorks-Jank
> --
>
> Key: MCOMPILER-415
> URL: https://issues.apache.org/jira/browse/MCOMPILER-415
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.1
> Environment: macOS 10.14.6, iMac Pro, AdoptOpenJDK 9, OpenJDK 11.0.2,
> AdoptOpenJDK 13.0.2
>Reporter: Andrew Janke
>Assignee: Robert Scholte
>Priority: Minor
> Attachments: antlrworks-jank-mvn-compile-NPE-02-debug.log,
> antlrworks-jank-mvn-compile-NPE-02.log,
> antlrworks-jank-mvn-compile-NPE-debug.log, antlrworks-jank-mvn-compile-NPE.log
>
>
> I'm working on a project called AntlrWorks-Jank, an attempt to revive the
> defunct ANTLRWorks application. https://github.com/apjanke/antlrworks2-jank
> When compiling the latest work-in-progress version of my code, I'm getting a
> NullPointerException apparently raised inside the javac code when it's called
> by the Maven Compiler Plugin.
> {code:java}
> [antlrworks-jank] $ mvn -e compile
> [INFO] Error stacktraces are turned on.
> [...]
> [INFO] works-editor-antlr4 FAILURE [ 1.026
> s]
> [INFO] antlr-works-editor . SKIPPED
> [INFO] tvl-editor-whitespace .. SKIPPED
> [INFO] works-editor-antlr3 SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 2.028 s
> [INFO] Finished at: 2020-05-08T03:01:54-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile)
> on project works-editor-antlr4: Fatal error compiling: CompilerException:
> NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile
> (default-compile) on project works-editor-antlr4: Fatal error compiling
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> [...]
> Caused by: java.lang.NullPointerException
> at com.sun.tools.javac.main.JavaCompiler.readSourceFile
> (JavaCompiler.java:825)
> at
> com.sun.tools.javac.processing.JavacProcessingEnvironment$ImplicitCompleter.complete
> (JavacProcessingEnvironment.java:1510)
> at com.sun.tools.javac.code.Symbol.complete (Symbol.java:633)
> at com.sun.tools.javac.code.Symbol$ClassSymbol.complete (Symbol.java:1314)
> at com.sun.tools.javac.code.Type$ClassType.complete (Type.java:1139)
> at com.sun.tools.javac.code.Type$ClassType.getTypeArguments
> (Type.java:1065)
> at com.sun.tools.javac.code.Printer.visitClassType (Printer.java:237)
> at com.sun.tools.javac.code.Printer.visitClassType (Printer.java:52)
> at com.sun.tools.javac.code.Type$ClassType.accept (Type.java:992)
> at com.sun.tools.javac.code.Printer.visit (Printer.java:136)
> at com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArgument
> (AbstractDiagnosticFormatter.java:197)
> at com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArguments
> (AbstractDiagnosticFormatter.java:165)
> at com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage
> (BasicDiagnosticFormatter.java:111)
> at com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage
> (BasicDiagnosticFormatter.java:67)
> at com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArgument
> (AbstractDiagnosticFormatter.java:183)
> at
[jira] [Comment Edited] (SUREFIRE-2022) MAVEN - PluginExecutionException
[
https://issues.apache.org/jira/browse/SUREFIRE-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497258#comment-17497258
]
Jo Jaafar edited comment on SUREFIRE-2022 at 2/24/22, 8:47 AM:
---
Here you go [~tibordigana],
{code:java}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
com.abc.gtm.abcApplication_Automation
abcApplication_Automation
0.0.1-SNAPSHOT
UTF-8
UTF-8
src
src
**/*.java
maven-compiler-plugin
3.5.1
1.8
1.8
ISO-8859-1
org.apache.maven.plugins
maven-surefire-plugin
3.0.0-M5
testng.xml
${url}
org.apache.maven.plugins
maven-site-plugin
3.7.1
io.rest-assured
rest-assured
4.3.2
org.codehaus.groovy
groovy-all
2.4.5
org.seleniumhq.selenium
selenium-java
3.141.0
org.testng
testng
6.9.9
log4j
log4j
1.2.17
commons-io
commons-io
2.6
org.apache.poi
poi
4.1.2
org.apache.poi
poi-ooxml
4.1.2
http://abc-selenium.abc.net:8080/labvabc/logon.jsp
abc
For complete Information :
https://confluence.abc.net/display/abc/Test+Automation+abc
{code}
was (Author: JIRAUSER285649):
Here you [~tibordigana],
{code:java}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
com.abc.gtm.abcApplication_Automation
abcApplication_Automation
0.0.1-SNAPSHOT
UTF-8
UTF-8
src
src
**/*.java
maven-compiler-plugin
3.5.1
1.8
1.8
ISO-8859-1
org.apache.maven.plugins
maven-surefire-plugin
3.0.0-M5
testng.xml
[jira] [Commented] (SUREFIRE-2022) MAVEN - PluginExecutionException
[
https://issues.apache.org/jira/browse/SUREFIRE-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497258#comment-17497258
]
Jo Jaafar commented on SUREFIRE-2022:
-
Here you [~tibordigana],
{code:java}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
com.abc.gtm.abcApplication_Automation
abcApplication_Automation
0.0.1-SNAPSHOT
UTF-8
UTF-8
src
src
**/*.java
maven-compiler-plugin
3.5.1
1.8
1.8
ISO-8859-1
org.apache.maven.plugins
maven-surefire-plugin
3.0.0-M5
testng.xml
${url}
org.apache.maven.plugins
maven-site-plugin
3.7.1
io.rest-assured
rest-assured
4.3.2
org.codehaus.groovy
groovy-all
2.4.5
org.seleniumhq.selenium
selenium-java
3.141.0
org.testng
testng
6.9.9
log4j
log4j
1.2.17
commons-io
commons-io
2.6
org.apache.poi
poi
4.1.2
org.apache.poi
poi-ooxml
4.1.2
http://abc-selenium.abc.net:8080/labvabc/logon.jsp
abc
For complete Information :
https://confluence.abc.net/display/abc/Test+Automation+abc
{code}
> MAVEN - PluginExecutionException
>
>
> Key: SUREFIRE-2022
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2022
> Project: Maven Surefire
> Issue Type: Bug
> Environment: SNAPSHOT : 0.1
> Maven: 3.8.4
> Maven-Surefire : 2.19
>Reporter: Jo Jaafar
>Assignee: Tibor Digana
>Priority: Blocker
> Labels: newbie
> Fix For: waiting-for-feedback
>
> Attachments: directory-list.PNG, screenshot-1.png
>
> Original Estimate: 68h
> Remaining Estimate: 68h
>
> The issue started whereby the maven surefire plugin is turn up failed. even
> before this theres issue with maven 2.4.1 but i have upgraded to maven 3.8.4.
> As whole and by right it should solve the mentioned issues. But still
> appeared.
>
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] Failed to
> execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test
> (default-test) on project ABCApplications _Automation: Execution default-test
> of goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test failed:
> testSuiteXmlFiles0 has null value -> [Help 1]{color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] {color}
> {color:#11}[{color}{color:#403f53}ERROR{color}{color:#11}] To see the
> full stack
