[GitHub] [maven-parent] olamy commented on pull request #115: [MPOM-346] Do not run ITs in release
olamy commented on PR #115: URL: https://github.com/apache/maven-parent/pull/115#issuecomment-1478787413 even tests could be skipped as long as the build is green... and using localCheckout as well will make it faster I usually do this: ```mvn release:prepare release:perform -DskipTests -Darguments="-DskipTests" -DlocalCheckout=true -B``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-project-info-reports-plugin] SimonDever commented on pull request #44: Bump bcel from 6.5.0 to 6.6.0
SimonDever commented on PR #44: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/44#issuecomment-1478681275 How long before we can have this merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MENFORCER-426) DependencyConvergence in 3.1.0 fails when using version ranges
[
https://issues.apache.org/jira/browse/MENFORCER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MENFORCER-426:
--
Affects Version/s: 3.0.0
> DependencyConvergence in 3.1.0 fails when using version ranges
> --
>
> Key: MENFORCER-426
> URL: https://issues.apache.org/jira/browse/MENFORCER-426
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: dependencyConvergence, Standard Rules
>Affects Versions: 3.0.0, 3.1.0
>Reporter: Joe Barnett
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> In our project, using version 3.0.0-M3 of the maven-enforcer-plugin's
> DependencyConvergence rule passes. Using version 3.1.0 starts to show
> convergence errors that I believe may be related to using version ranges to
> declare dependencies:
> {code:java}
> [WARNING]
> Dependency convergence error for com.trib3:graphql:jar:1.32.3279:compile
> paths to dependency are:
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
> +-com.joe.quizzy:graphql:jar:1.0-SNAPSHOT:compile
> +-com.trib3:graphql:jar:1.32.3279:compile
> and
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
> +-com.trib3:graphql:jar:1.32.3324:compile
> {code}
> both {{com.joe.quizzy:server}} and {{com.joe.quizzy:graphql}} declare a
> dependency on {{com.trib3:graphql}}, with a version of
> {{[1.32.1,1.33-SNAPSHOT)}}. that version range should (currently) resolve to
> 1.32.3324 in both usages, but in enforcer 3.1.0's DependencyConvergence check
> does not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MENFORCER-426) DependencyConvergence in 3.1.0 fails when using version ranges
[
https://issues.apache.org/jira/browse/MENFORCER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703388#comment-17703388
]
Slawomir Jaranowski commented on MENFORCER-426:
---
You need Maven 3.9.x BF is new implementation not present in older version.
> DependencyConvergence in 3.1.0 fails when using version ranges
> --
>
> Key: MENFORCER-426
> URL: https://issues.apache.org/jira/browse/MENFORCER-426
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: dependencyConvergence, Standard Rules
>Affects Versions: 3.1.0
>Reporter: Joe Barnett
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> In our project, using version 3.0.0-M3 of the maven-enforcer-plugin's
> DependencyConvergence rule passes. Using version 3.1.0 starts to show
> convergence errors that I believe may be related to using version ranges to
> declare dependencies:
> {code:java}
> [WARNING]
> Dependency convergence error for com.trib3:graphql:jar:1.32.3279:compile
> paths to dependency are:
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
> +-com.joe.quizzy:graphql:jar:1.0-SNAPSHOT:compile
> +-com.trib3:graphql:jar:1.32.3279:compile
> and
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
> +-com.trib3:graphql:jar:1.32.3324:compile
> {code}
> both {{com.joe.quizzy:server}} and {{com.joe.quizzy:graphql}} declare a
> dependency on {{com.trib3:graphql}}, with a version of
> {{[1.32.1,1.33-SNAPSHOT)}}. that version range should (currently) resolve to
> 1.32.3324 in both usages, but in enforcer 3.1.0's DependencyConvergence check
> does not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MENFORCER-426) DependencyConvergence in 3.1.0 fails when using version ranges
[
https://issues.apache.org/jira/browse/MENFORCER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703384#comment-17703384
]
Joe Barnett commented on MENFORCER-426:
---
I still see a convergence error when running `mvn verify
-Daether.dependencyCollector.impl=bf` in the linked reproducer projects
> DependencyConvergence in 3.1.0 fails when using version ranges
> --
>
> Key: MENFORCER-426
> URL: https://issues.apache.org/jira/browse/MENFORCER-426
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: dependencyConvergence, Standard Rules
>Affects Versions: 3.1.0
>Reporter: Joe Barnett
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> In our project, using version 3.0.0-M3 of the maven-enforcer-plugin's
> DependencyConvergence rule passes. Using version 3.1.0 starts to show
> convergence errors that I believe may be related to using version ranges to
> declare dependencies:
> {code:java}
> [WARNING]
> Dependency convergence error for com.trib3:graphql:jar:1.32.3279:compile
> paths to dependency are:
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
> +-com.joe.quizzy:graphql:jar:1.0-SNAPSHOT:compile
> +-com.trib3:graphql:jar:1.32.3279:compile
> and
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
> +-com.trib3:graphql:jar:1.32.3324:compile
> {code}
> both {{com.joe.quizzy:server}} and {{com.joe.quizzy:graphql}} declare a
> dependency on {{com.trib3:graphql}}, with a version of
> {{[1.32.1,1.33-SNAPSHOT)}}. that version range should (currently) resolve to
> 1.32.3324 in both usages, but in enforcer 3.1.0's DependencyConvergence check
> does not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MENFORCER-426) DependencyConvergence in 3.1.0 fails when using version ranges
[
https://issues.apache.org/jira/browse/MENFORCER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703383#comment-17703383
]
Slawomir Jaranowski commented on MENFORCER-426:
---
When we switch dependency collector implementation to {{breadth-first}} - test
will pass.
[~jbarnett] you can test your case with:
{code}
mvn -Daether.dependencyCollector.impl=bf
{code}
With {{BF}} dependency tree looks like:
{code}
[INFO] test:menforcer426:jar:1.0
[INFO] \- org.apache.maven.plugins.enforcer.its:menforcer426-a:jar:1.0:compile
[INFO]+-
org.apache.maven.plugins.enforcer.its:menforcer426-b:jar:1.0:compile
[INFO]| \-
(org.apache.maven.plugins.enforcer.its:menforcer128_api:jar:1.6.0:compile -
omitted for duplicate)
[INFO]\-
org.apache.maven.plugins.enforcer.its:menforcer128_api:jar:1.6.0:compile
{code}
> DependencyConvergence in 3.1.0 fails when using version ranges
> --
>
> Key: MENFORCER-426
> URL: https://issues.apache.org/jira/browse/MENFORCER-426
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: dependencyConvergence, Standard Rules
>Affects Versions: 3.1.0
>Reporter: Joe Barnett
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> In our project, using version 3.0.0-M3 of the maven-enforcer-plugin's
> DependencyConvergence rule passes. Using version 3.1.0 starts to show
> convergence errors that I believe may be related to using version ranges to
> declare dependencies:
> {code:java}
> [WARNING]
> Dependency convergence error for com.trib3:graphql:jar:1.32.3279:compile
> paths to dependency are:
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
> +-com.joe.quizzy:graphql:jar:1.0-SNAPSHOT:compile
> +-com.trib3:graphql:jar:1.32.3279:compile
> and
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
> +-com.trib3:graphql:jar:1.32.3324:compile
> {code}
> both {{com.joe.quizzy:server}} and {{com.joe.quizzy:graphql}} declare a
> dependency on {{com.trib3:graphql}}, with a version of
> {{[1.32.1,1.33-SNAPSHOT)}}. that version range should (currently) resolve to
> 1.32.3324 in both usages, but in enforcer 3.1.0's DependencyConvergence check
> does not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MENFORCER-426) DependencyConvergence in 3.1.0 fails when using version ranges
[
https://issues.apache.org/jira/browse/MENFORCER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MENFORCER-426:
--
Fix Version/s: (was: 3.3.0)
> DependencyConvergence in 3.1.0 fails when using version ranges
> --
>
> Key: MENFORCER-426
> URL: https://issues.apache.org/jira/browse/MENFORCER-426
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: dependencyConvergence, Standard Rules
>Affects Versions: 3.1.0
>Reporter: Joe Barnett
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> In our project, using version 3.0.0-M3 of the maven-enforcer-plugin's
> DependencyConvergence rule passes. Using version 3.1.0 starts to show
> convergence errors that I believe may be related to using version ranges to
> declare dependencies:
> {code:java}
> [WARNING]
> Dependency convergence error for com.trib3:graphql:jar:1.32.3279:compile
> paths to dependency are:
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
> +-com.joe.quizzy:graphql:jar:1.0-SNAPSHOT:compile
> +-com.trib3:graphql:jar:1.32.3279:compile
> and
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
> +-com.trib3:graphql:jar:1.32.3324:compile
> {code}
> both {{com.joe.quizzy:server}} and {{com.joe.quizzy:graphql}} declare a
> dependency on {{com.trib3:graphql}}, with a version of
> {{[1.32.1,1.33-SNAPSHOT)}}. that version range should (currently) resolve to
> 1.32.3324 in both usages, but in enforcer 3.1.0's DependencyConvergence check
> does not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-enforcer] dependabot[bot] commented on pull request #258: Bump slf4j-api from 1.7.36 to 2.0.7
dependabot[bot] commented on PR #258: URL: https://github.com/apache/maven-enforcer/pull/258#issuecomment-1478573179 OK, I won't notify you about version 2.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] dependabot[bot] closed pull request #258: Bump slf4j-api from 1.7.36 to 2.0.7
dependabot[bot] closed pull request #258: Bump slf4j-api from 1.7.36 to 2.0.7 URL: https://github.com/apache/maven-enforcer/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #258: Bump slf4j-api from 1.7.36 to 2.0.7
slawekjaranowski commented on PR #258: URL: https://github.com/apache/maven-enforcer/pull/258#issuecomment-1478573124 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MENFORCER-426) DependencyConvergence in 3.1.0 fails when using version ranges
[
https://issues.apache.org/jira/browse/MENFORCER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703340#comment-17703340
]
Slawomir Jaranowski commented on MENFORCER-426:
---
Also {{dependency:tree}} show:
{code}
[INFO] test:menforcer426:jar:1.0
[INFO] \- org.apache.maven.plugins.enforcer.its:menforcer426-a:jar:1.0:compile
[INFO]+-
org.apache.maven.plugins.enforcer.its:menforcer426-b:jar:1.0:compile
[INFO]| \-
(org.apache.maven.plugins.enforcer.its:menforcer128_api:jar:1.4.0:compile -
omitted for conflict with 1.6.0)
[INFO]\-
org.apache.maven.plugins.enforcer.its:menforcer128_api:jar:1.6.0:compile
{code}
> DependencyConvergence in 3.1.0 fails when using version ranges
> --
>
> Key: MENFORCER-426
> URL: https://issues.apache.org/jira/browse/MENFORCER-426
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: dependencyConvergence, Standard Rules
>Affects Versions: 3.1.0
>Reporter: Joe Barnett
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> In our project, using version 3.0.0-M3 of the maven-enforcer-plugin's
> DependencyConvergence rule passes. Using version 3.1.0 starts to show
> convergence errors that I believe may be related to using version ranges to
> declare dependencies:
> {code:java}
> [WARNING]
> Dependency convergence error for com.trib3:graphql:jar:1.32.3279:compile
> paths to dependency are:
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
> +-com.joe.quizzy:graphql:jar:1.0-SNAPSHOT:compile
> +-com.trib3:graphql:jar:1.32.3279:compile
> and
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
> +-com.trib3:graphql:jar:1.32.3324:compile
> {code}
> both {{com.joe.quizzy:server}} and {{com.joe.quizzy:graphql}} declare a
> dependency on {{com.trib3:graphql}}, with a version of
> {{[1.32.1,1.33-SNAPSHOT)}}. that version range should (currently) resolve to
> 1.32.3324 in both usages, but in enforcer 3.1.0's DependencyConvergence check
> does not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-shade-plugin] slawekjaranowski commented on a diff in pull request #179: [MSHADE-420] create IT: 2 runs with different TZ give different jars
slawekjaranowski commented on code in PR #179: URL: https://github.com/apache/maven-shade-plugin/pull/179#discussion_r1143829528 ## src/it/projects/MSHADE-420/invoker.properties: ## @@ -0,0 +1,19 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +invoker.goals.1 = clean package -Duser.timezone=UTC -DfinalName=UTC +invoker.goals.2 = package -Duser.timezone=Japan/Tokyo -DfinalName=Tokyo Review Comment: timezone should be in `invoker.mavenOpts.2=-Duser.timezone=Japan/Tokyo` we still have mixed user and system properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-44) Running duplicate maven phase leads to IllegalStateException and cache miss
[
https://issues.apache.org/jira/browse/MBUILDCACHE-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703313#comment-17703313
]
Alexander Eltsov commented on MBUILDCACHE-44:
-
Also confirming I was able to reproduce the issue via an integration test that
perfroms exactly the above-mentioned scenario ({*}compile+test{*} -> {*}test{*})
> Running duplicate maven phase leads to IllegalStateException and cache miss
> ---
>
> Key: MBUILDCACHE-44
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-44
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Miguel Ortega
>Priority: Minor
> Attachments: maven-cache.zip
>
>
> When running maven with a duplicate maven goal like below (i'm aware that
> compile phase here is not necessary)
> {code:java}
> mvn compile test
> {code}
> the plugin seems to create a cache key that cause an error if i call.
> {code:java}
> mvn test
> {code}
> This will cause the following error:
> {code:java}
> [ERROR] Failed to restore project
> java.lang.IllegalStateException: Duplicate key
> default-resources:resources:process-resources:maven-resources-plugin:org.apache.maven.plugins
> (attempted merging values
> org.apache.maven.buildcache.xml.build.CompletedExecution@1e1b061 and
> org.apache.maven.buildcache.xml.build.CompletedExecution@38f77cd9)
> at java.util.stream.Collectors.duplicateKeyException (Collectors.java:135)
> at java.util.stream.Collectors.lambda$uniqKeysMapAccumulator$1
> (Collectors.java:182)
> at java.util.stream.ReduceOps$3ReducingSink.accept (ReduceOps.java:169)
> at java.util.ArrayList$ArrayListSpliterator.forEachRemaining
> (ArrayList.java:1625)
> at java.util.stream.AbstractPipeline.copyInto (AbstractPipeline.java:509)
> at java.util.stream.AbstractPipeline.wrapAndCopyInto
> (AbstractPipeline.java:499)
> at java.util.stream.ReduceOps$ReduceOp.evaluateSequential
> (ReduceOps.java:921)
> at java.util.stream.AbstractPipeline.evaluate (AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect (ReferencePipeline.java:682)
> at org.apache.maven.buildcache.xml.Build.getExecutionMap (Build.java:198)
> at org.apache.maven.buildcache.xml.Build.hasCompletedExecution
> (Build.java:116)
> at org.apache.maven.buildcache.xml.Build.lambda$getMissingExecutions$0
> (Build.java:110)
> at java.util.stream.ReferencePipeline$2$1.accept
> (ReferencePipeline.java:178)
> at java.util.ArrayList$ArrayListSpliterator.forEachRemaining
> (ArrayList.java:1625)
> at java.util.stream.AbstractPipeline.copyInto (AbstractPipeline.java:509)
> at java.util.stream.AbstractPipeline.wrapAndCopyInto
> (AbstractPipeline.java:499)
> at java.util.stream.ReduceOps$ReduceOp.evaluateSequential
> (ReduceOps.java:921)
> at java.util.stream.AbstractPipeline.evaluate (AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect (ReferencePipeline.java:682)
> at org.apache.maven.buildcache.xml.Build.getMissingExecutions
> (Build.java:111)
> at org.apache.maven.buildcache.CacheControllerImpl.analyzeResult
> (CacheControllerImpl.java:267)
> at org.apache.maven.buildcache.CacheControllerImpl.findLocalBuild
> (CacheControllerImpl.java:234)
> at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
> (CacheControllerImpl.java:185)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:114)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
>
[GitHub] [maven-javadoc-plugin] ParkerM opened a new pull request, #198: Fix UmlGraph link in site example
ParkerM opened a new pull request, #198: URL: https://github.com/apache/maven-javadoc-plugin/pull/198 This fixes a link to umlgraph dot org in the site examples that now leads to an SEO farm. See here for reference: https://urlscan.io/result/08d37cce-364f-4bc7-a09f-e1afd7175c09/ Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MJAVADOC-748) detectOfflineLinks URL generation for modules is not helpful
[
https://issues.apache.org/jira/browse/MJAVADOC-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Gent updated MJAVADOC-748:
---
Description:
EDIT:
OK there is an easy workaround. After looking at the code I just didn't know
that project.url gets automagically appended with the artifact path for
submodules that inherit from a parent.
The workaround is to just set {{project.url}} for each module to the base url.
So I suppose project.url is useful as the offlineLink URL.
For a multi module modular project (e.g. a project with multiple module-info
submodules)
I have yet to see a correct usage of {{detectOfflineLinks}}.
Here is the use case I expect most people including myself is when performing
the following
1. Generate non-aggregated javadoc jars for each module for maven central
2. Generate an aggregated exploded javadoc and host it
The hope is in step 1 the cross module links will use step 2 aggregated html.
The idea is someone clicks on a javadoc.io hosted javadoc and then clicks on a
class that is in a separate module the link will not break but takes us to the
aggregate hosted doc.
Here is the problem the detectOfflineLinks does a whole bunch incorrect
heuristics to guess the online URL that do not map at all to the aggregate
javadoc.
In an aggregate javadoc you get a directory of all the module-info modules. I
stress module-info and not maven artifact names.
You can see an example of that here:
https://github.com/jstachio/jstachio.github.io/tree/d036294/p/jstachio/v0.11.0
Now if we go to javadoc.io :
https://javadoc.io/doc/io.jstach/jstachio/0.11.0/io.jstach.jstachio/module-summary.html
And look at JStache link (search in page) it has the following URL:
https://github.com/jstachio/jstachio/jstachio-api-parent/jstachio-annotation/apidocs/io.jstach.jstache/io/jstach/jstache/JStache.html
Now ignoring the whole {{project.url}} (which btw ... why is this is not a
property? Like it really doesn't make since because a project.url is going to
have multiple versions on its page.)
The project.url is: https://github.com/jstachio/jstachio but it should be
https://jstach.io/p/jstachio/v0.11.0 (so for now mentally replace that).
For the JStache link we have
{{jstachio-api-parent/jstachio-annotation/apidocs/io.jstach.jstache/io/jstach/jstache/JStache.html}}.
(BTW the directory {{jstachio-api-parent}} is actually just {{api}} so even if
I just host the built project it still would not work).
The above should be (ignoring project.url prefix):
{{io.jstach.jstache/io/jstach/jstache/JStache.html}}
As the module name is {{io.jstach.jstache}}.
I set this issue as minor because I assume the work around is it manually put
in all the offlineLinks. I haven't tried that but I assume it will work albeit
laborious.
I have serious doubts anyone uses detectOfflineLinks with success. Please show
me an example if I'm wrong. For one it requires doing something like this with
project.url:
{{https://mysite.com/project/${project.version}}}
I have looked around and I don't see the above much.
With project.url of https://jstach.io/p/jstachio/v1.0.0-SNAPSHOT:
{{code}}
[DEBUG] Added Javadoc offline link:
https://jstach.io/p/jstachio/v1.0.0-SNAPSHOT/jstachio-api-parent/jstachio-annotation/apidocs
for the module: io.jstach:jstachio-annotation:jar:1.0.0-SNAPSHOT
{{code}}
it should be:
{{code}}
[DEBUG] Added Javadoc offline link:
https://jstach.io/p/jstachio/v1.0.0-SNAPSHOT for the module:
io.jstach:jstachio-annotation:jar:1.0.0-SNAPSHOT
{{code}}
That is the offline link should just be the {{project.url}} and should not have
the module artifact names anywhere in the URL.
I assume this is a happening because the submodules project.url
(project.getUrl()) uses the artifact name including the parent.
https://github.com/apache/maven-javadoc-plugin/blob/931164d0c5d11b4ac4559ada68ee5fba1d0df4f6/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L5853
was:
For a multi module modular project (e.g. a project with multiple module-info
submodules)
I have yet to see a correct usage of {{detectOfflineLinks}}.
Here is the use case I expect most people including myself is when performing
the following
1. Generate non-aggregated javadoc jars for each module for maven central
2. Generate an aggregated exploded javadoc and host it
The hope is in step 1 the cross module links will use step 2 aggregated html.
The idea is someone clicks on a javadoc.io hosted javadoc and then clicks on a
class that is in a separate module the link will not break but takes us to the
aggregate hosted doc.
Here is the problem the detectOfflineLinks does a whole bunch incorrect
heuristics to guess the online URL that do not map at all to the aggregate
javadoc.
In an aggregate javadoc you get a directory of all the module-info modules. I
stress module-info and not maven artifact names.
You can see an
[jira] [Updated] (MJAVADOC-748) detectOfflineLinks URL generation for modules is not helpful
[
https://issues.apache.org/jira/browse/MJAVADOC-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Gent updated MJAVADOC-748:
---
Description:
For a multi module modular project (e.g. a project with multiple module-info
submodules)
I have yet to see a correct usage of {{detectOfflineLinks}}.
Here is the use case I expect most people including myself is when performing
the following
1. Generate non-aggregated javadoc jars for each module for maven central
2. Generate an aggregated exploded javadoc and host it
The hope is in step 1 the cross module links will use step 2 aggregated html.
The idea is someone clicks on a javadoc.io hosted javadoc and then clicks on a
class that is in a separate module the link will not break but takes us to the
aggregate hosted doc.
Here is the problem the detectOfflineLinks does a whole bunch incorrect
heuristics to guess the online URL that do not map at all to the aggregate
javadoc.
In an aggregate javadoc you get a directory of all the module-info modules. I
stress module-info and not maven artifact names.
You can see an example of that here:
https://github.com/jstachio/jstachio.github.io/tree/d036294/p/jstachio/v0.11.0
Now if we go to javadoc.io :
https://javadoc.io/doc/io.jstach/jstachio/0.11.0/io.jstach.jstachio/module-summary.html
And look at JStache link (search in page) it has the following URL:
https://github.com/jstachio/jstachio/jstachio-api-parent/jstachio-annotation/apidocs/io.jstach.jstache/io/jstach/jstache/JStache.html
Now ignoring the whole {{project.url}} (which btw ... why is this is not a
property? Like it really doesn't make since because a project.url is going to
have multiple versions on its page.)
The project.url is: https://github.com/jstachio/jstachio but it should be
https://jstach.io/p/jstachio/v0.11.0 (so for now mentally replace that).
For the JStache link we have
{{jstachio-api-parent/jstachio-annotation/apidocs/io.jstach.jstache/io/jstach/jstache/JStache.html}}.
(BTW the directory {{jstachio-api-parent}} is actually just {{api}} so even if
I just host the built project it still would not work).
The above should be (ignoring project.url prefix):
{{io.jstach.jstache/io/jstach/jstache/JStache.html}}
As the module name is {{io.jstach.jstache}}.
I set this issue as minor because I assume the work around is it manually put
in all the offlineLinks. I haven't tried that but I assume it will work albeit
laborious.
I have serious doubts anyone uses detectOfflineLinks with success. Please show
me an example if I'm wrong. For one it requires doing something like this with
project.url:
{{https://mysite.com/project/${project.version}}}
I have looked around and I don't see the above much.
With project.url of https://jstach.io/p/jstachio/v1.0.0-SNAPSHOT:
{{code}}
[DEBUG] Added Javadoc offline link:
https://jstach.io/p/jstachio/v1.0.0-SNAPSHOT/jstachio-api-parent/jstachio-annotation/apidocs
for the module: io.jstach:jstachio-annotation:jar:1.0.0-SNAPSHOT
{{code}}
it should be:
{{code}}
[DEBUG] Added Javadoc offline link:
https://jstach.io/p/jstachio/v1.0.0-SNAPSHOT for the module:
io.jstach:jstachio-annotation:jar:1.0.0-SNAPSHOT
{{code}}
That is the offline link should just be the {{project.url}} and should not have
the module artifact names anywhere in the URL.
I assume this is a happening because the submodules project.url
(project.getUrl()) uses the artifact name including the parent.
https://github.com/apache/maven-javadoc-plugin/blob/931164d0c5d11b4ac4559ada68ee5fba1d0df4f6/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L5853
was:
For a multi module modular project (e.g. a project with multiple module-info
submodules)
I have yet to see a correct usage of {{detectOfflineLinks}}.
Here is the use case I expect most people including myself is when performing
the following
1. Generate non-aggregated javadoc jars for each module for maven central
2. Generate an aggregated exploded javadoc and host it
The hope is in step 1 the cross module links will use step 2 aggregated html.
The idea is someone clicks on a javadoc.io hosted javadoc and then clicks on a
class that is in a separate module the link will not break but takes us to the
aggregate hosted doc.
Here is the problem the detectOfflineLinks does a whole bunch incorrect
heuristics to guess the online URL that do not map at all to the aggregate
javadoc.
In an aggregate javadoc you get a directory of all the module-info modules. I
stress module-info and not maven artifact names.
You can see an example of that here:
https://github.com/jstachio/jstachio.github.io/tree/d036294/p/jstachio/v0.11.0
Now if we go to javadoc.io :
https://javadoc.io/doc/io.jstach/jstachio/0.11.0/io.jstach.jstachio/module-summary.html
And look at JStache link (search in page) it has the following URL:
[jira] [Created] (MJAVADOC-748) detectOfflineLinks URL generation for modules is not helpful
Adam Gent created MJAVADOC-748:
--
Summary: detectOfflineLinks URL generation for modules is not
helpful
Key: MJAVADOC-748
URL: https://issues.apache.org/jira/browse/MJAVADOC-748
Project: Maven Javadoc Plugin
Issue Type: Improvement
Affects Versions: 3.5.0
Reporter: Adam Gent
For a multi module modular project (e.g. a project with multiple module-info
submodules)
I have yet to see a correct usage of {{detectOfflineLinks}}.
Here is the use case I expect most people including myself is when performing
the following
1. Generate non-aggregated javadoc jars for each module for maven central
2. Generate an aggregated exploded javadoc and host it
The hope is in step 1 the cross module links will use step 2 aggregated html.
The idea is someone clicks on a javadoc.io hosted javadoc and then clicks on a
class that is in a separate module the link will not break but takes us to the
aggregate hosted doc.
Here is the problem the detectOfflineLinks does a whole bunch incorrect
heuristics to guess the online URL that do not map at all to the aggregate
javadoc.
In an aggregate javadoc you get a directory of all the module-info modules. I
stress module-info and not maven artifact names.
You can see an example of that here:
https://github.com/jstachio/jstachio.github.io/tree/d036294/p/jstachio/v0.11.0
Now if we go to javadoc.io :
https://javadoc.io/doc/io.jstach/jstachio/0.11.0/io.jstach.jstachio/module-summary.html
And look at JStache link (search in page) it has the following URL:
https://github.com/jstachio/jstachio/jstachio-api-parent/jstachio-annotation/apidocs/io.jstach.jstache/io/jstach/jstache/JStache.html
Now ignoring the whole {{project.url}} (which btw ... why is this is not a
property? Like it really doesn't make since because a project.url is going to
have multiple versions on its page.)
The project.url is: https://github.com/jstachio/jstachio
We have
{{jstachio-api-parent/jstachio-annotation/apidocs/io.jstach.jstache/io/jstach/jstache/JStache.html}}.
(BTW the directory {{jstachio-api-parent}} is actually just {{api}} so even if
I just host the built project it still would not work).
The above should be (ignoring project.url prefix):
{{io.jstach.jstache/io/jstach/jstache/JStache.html}}
I set this issue as minor because I assume the work around is it manually put
in all the offlineLinks. I haven't tried that but I assume it will work albeit
laborious.
I have serious doubts anyone uses detectOfflineLinks with success. Please show
me an example if I'm wrong. For one it requires doing something like this with
project.url:
{{https://mysite.com/project/${project.version}}}
I have looked around and I don't see the above much.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-48) Add ability to disable caching on a per-module level
[ https://issues.apache.org/jira/browse/MBUILDCACHE-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated MBUILDCACHE-48: -- Labels: pull-request-available (was: ) > Add ability to disable caching on a per-module level > > > Key: MBUILDCACHE-48 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-48 > Project: Maven Build Cache Extension > Issue Type: New Feature > Components: remote build cache >Affects Versions: 1.0.0 >Reporter: Alexander Eltsov >Priority: Major > Labels: pull-request-available > > Add ability to do the caching on a per-module level. > This may be required in a case when a module is a final leaf of a reactor > tree, and its artefacts are not required by other modules as cached > dependencies. Hence eliminating some modules from caching will speed up build > and also lower the footprint size of a cached build. > > E.g. in my project (where we have huge deployment artifacts in some of > modules) we reduced the cache footprint from 1.5G to 100M by introducing such > a capability -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-48) Add ability to disable caching on a per-module level
[ https://issues.apache.org/jira/browse/MBUILDCACHE-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703287#comment-17703287 ] ASF GitHub Bot commented on MBUILDCACHE-48: --- eltsovalex opened a new pull request, #51: URL: https://github.com/apache/maven-build-cache-extension/pull/51 Added a new flag that allows disabling cache (not just looking up build artifacts, but all the build cache completely). This may be required in a case when a module is a final leaf of a reactor tree, and its artefacts are not required by other modules as cached dependencies. Hence eliminating some modules from caching will speed up build and also lower the footprint size of a cached build. Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Add ability to disable caching on a per-module level > > > Key: MBUILDCACHE-48 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-48 > Project: Maven Build Cache Extension > Issue Type: New Feature > Components: remote build cache >Affects Versions: 1.0.0 >Reporter: Alexander Eltsov >Priority: Major > > Add ability to do the caching on a per-module level. > This may be required in a case when a module is a final leaf of a reactor > tree, and its artefacts are not required by other modules as cached > dependencies. Hence eliminating some modules from caching will speed up build > and also lower the footprint size of a cached build. > > E.g. in my project (where we have huge deployment artifacts in some of > modules) we reduced the cache footprint from 1.5G to 100M by introducing such > a capability -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-build-cache-extension] eltsovalex opened a new pull request, #51: [MBUILDCACHE-48] - Add possibility to disable caching per module in a multi-module project
eltsovalex opened a new pull request, #51: URL: https://github.com/apache/maven-build-cache-extension/pull/51 Added a new flag that allows disabling cache (not just looking up build artifacts, but all the build cache completely). This may be required in a case when a module is a final leaf of a reactor tree, and its artefacts are not required by other modules as cached dependencies. Hence eliminating some modules from caching will speed up build and also lower the footprint size of a cached build. Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEPLOY-307) [REGRESSION] Longer deploy times
[ https://issues.apache.org/jira/browse/MDEPLOY-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703285#comment-17703285 ] Tamas Cservenak commented on MDEPLOY-307: - Hm, that us strange. What transport you use (ie. Do you force wagon or just leave to Maven to sort it out)? Can you show me some concrete numbers? (Times with 3.8 maven vs 3.9.1?) > [REGRESSION] Longer deploy times > > > Key: MDEPLOY-307 > URL: https://issues.apache.org/jira/browse/MDEPLOY-307 > Project: Maven Deploy Plugin > Issue Type: Bug > Components: deploy:deploy >Affects Versions: 3.1.0 >Reporter: Delany >Priority: Major > > On Windows OS, a 500 module build takes half an hour to deploy when using > deployAtEnd. > I was expecting an improvement in build time with this version of the plugin. > Maven 3.9.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MDEPLOY-307) [REGRESSION] Longer deploy times
[ https://issues.apache.org/jira/browse/MDEPLOY-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703285#comment-17703285 ] Tamas Cservenak edited comment on MDEPLOY-307 at 3/21/23 4:29 PM: -- Hm, that is strange. What transport you use (ie. Do you force wagon or just leave to Maven to sort it out)? Can you show me some concrete numbers? (Times with 3.8 maven vs 3.9.1?) was (Author: cstamas): Hm, that us strange. What transport you use (ie. Do you force wagon or just leave to Maven to sort it out)? Can you show me some concrete numbers? (Times with 3.8 maven vs 3.9.1?) > [REGRESSION] Longer deploy times > > > Key: MDEPLOY-307 > URL: https://issues.apache.org/jira/browse/MDEPLOY-307 > Project: Maven Deploy Plugin > Issue Type: Bug > Components: deploy:deploy >Affects Versions: 3.1.0 >Reporter: Delany >Priority: Major > > On Windows OS, a 500 module build takes half an hour to deploy when using > deployAtEnd. > I was expecting an improvement in build time with this version of the plugin. > Maven 3.9.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEPLOY-307) [REGRESSION] Longer deploy times
[ https://issues.apache.org/jira/browse/MDEPLOY-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703281#comment-17703281 ] Delany commented on MDEPLOY-307: That's fixed it. Back to normal with Maven 3.9.1 and maven-deploy-plugin 3.1.0 > [REGRESSION] Longer deploy times > > > Key: MDEPLOY-307 > URL: https://issues.apache.org/jira/browse/MDEPLOY-307 > Project: Maven Deploy Plugin > Issue Type: Bug > Components: deploy:deploy >Affects Versions: 3.1.0 >Reporter: Delany >Priority: Major > > On Windows OS, a 500 module build takes half an hour to deploy when using > deployAtEnd. > I was expecting an improvement in build time with this version of the plugin. > Maven 3.9.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPOM-397) Don not run ITs during release
[
https://issues.apache.org/jira/browse/MPOM-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703254#comment-17703254
]
Tamas Cservenak commented on MPOM-397:
--
IF we would do automated "push a button" releases, that's COMPLETELY different
thing, but we are not.
> Don not run ITs during release
> --
>
> Key: MPOM-397
> URL: https://issues.apache.org/jira/browse/MPOM-397
> Project: Maven POMs
> Issue Type: Improvement
>Reporter: Tamas Cservenak
>Priority: Major
>
> As it makes no sense. As I did release m-install-p and m-deploy-p, at my
> amazement the {{release:prepare}} did end quickly (OK), while
> {{release:perform}} started to run ITs? What is the rationale here, *after*
> things were tagged? It really does not gives anything, but takes precious
> time. If relMgr is not cautious enough to ensure ITs are OK beforehand doing
> the release, that's it, a new release will happen.
> But running ITs in ANY of the release mojo makes no sense.
> Personally, I'd simply not run any kind of tests in any of two release Mojos,
> as it makes no sense, but in turn, makes release that is already too fragile,
> even more problematic and time consuming.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPOM-397) Don not run ITs during release
[
https://issues.apache.org/jira/browse/MPOM-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703252#comment-17703252
]
Tamas Cservenak commented on MPOM-397:
--
They should never run in release process (would say even UTs), as it is relMgr
job to ensure all is green on CI and locally as well.
> Don not run ITs during release
> --
>
> Key: MPOM-397
> URL: https://issues.apache.org/jira/browse/MPOM-397
> Project: Maven POMs
> Issue Type: Improvement
>Reporter: Tamas Cservenak
>Priority: Major
>
> As it makes no sense. As I did release m-install-p and m-deploy-p, at my
> amazement the {{release:prepare}} did end quickly (OK), while
> {{release:perform}} started to run ITs? What is the rationale here, *after*
> things were tagged? It really does not gives anything, but takes precious
> time. If relMgr is not cautious enough to ensure ITs are OK beforehand doing
> the release, that's it, a new release will happen.
> But running ITs in ANY of the release mojo makes no sense.
> Personally, I'd simply not run any kind of tests in any of two release Mojos,
> as it makes no sense, but in turn, makes release that is already too fragile,
> even more problematic and time consuming.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-parent] cstamas opened a new pull request, #115: [MPOM-346] Do not run ITs in release
cstamas opened a new pull request, #115: URL: https://github.com/apache/maven-parent/pull/115 As it makes no sense, but in turn just worsens the already fragile release process. As preparation to release relMgr hopefully ensures that ITs are OK on CI and locally. If not, doh, new version will happen, so what? --- https://issues.apache.org/jira/browse/MPOM-397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPOM-397) Don not run ITs during release
[
https://issues.apache.org/jira/browse/MPOM-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703251#comment-17703251
]
Michael Osipov commented on MPOM-397:
-
They should be run at prepare, to make sure that nothing is broken.
> Don not run ITs during release
> --
>
> Key: MPOM-397
> URL: https://issues.apache.org/jira/browse/MPOM-397
> Project: Maven POMs
> Issue Type: Improvement
>Reporter: Tamas Cservenak
>Priority: Major
>
> As it makes no sense. As I did release m-install-p and m-deploy-p, at my
> amazement the {{release:prepare}} did end quickly (OK), while
> {{release:perform}} started to run ITs? What is the rationale here, *after*
> things were tagged? It really does not gives anything, but takes precious
> time. If relMgr is not cautious enough to ensure ITs are OK beforehand doing
> the release, that's it, a new release will happen.
> But running ITs in ANY of the release mojo makes no sense.
> Personally, I'd simply not run any kind of tests in any of two release Mojos,
> as it makes no sense, but in turn, makes release that is already too fragile,
> even more problematic and time consuming.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MPOM-397) Don not run ITs during release
Tamas Cservenak created MPOM-397:
Summary: Don not run ITs during release
Key: MPOM-397
URL: https://issues.apache.org/jira/browse/MPOM-397
Project: Maven POMs
Issue Type: Improvement
Reporter: Tamas Cservenak
As it makes no sense. As I did release m-install-p and m-deploy-p, at my
amazement the {{release:prepare}} did end quickly (OK), while
{{release:perform}} started to run ITs? What is the rationale here, *after*
things were tagged? It really does not gives anything, but takes precious time.
If relMgr is not cautious enough to ensure ITs are OK beforehand doing the
release, that's it, a new release will happen.
But running ITs in ANY of the release mojo makes no sense.
Personally, I'd simply not run any kind of tests in any of two release Mojos,
as it makes no sense, but in turn, makes release that is already too fragile,
even more problematic and time consuming.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MDEPLOY-308) Add parameter to lax project validation
[ https://issues.apache.org/jira/browse/MDEPLOY-308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MDEPLOY-308. --- Resolution: Fixed > Add parameter to lax project validation > --- > > Key: MDEPLOY-308 > URL: https://issues.apache.org/jira/browse/MDEPLOY-308 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.1.1 > > > Affects all releases of m-deploy-p of 3.x line. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-deploy-plugin] cstamas merged pull request #39: [MDEPLOY-308] Add parameter to lax project validation
cstamas merged PR #39: URL: https://github.com/apache/maven-deploy-plugin/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MINSTALL-189) Add parameter to lax project validation
[ https://issues.apache.org/jira/browse/MINSTALL-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINSTALL-189. Resolution: Fixed > Add parameter to lax project validation > --- > > Key: MINSTALL-189 > URL: https://issues.apache.org/jira/browse/MINSTALL-189 > Project: Maven Install Plugin > Issue Type: Improvement > Components: install:install >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.1.1 > > > Affects all releases of m-install-p of 3.x line. > h4. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-install-plugin] cstamas merged pull request #57: [MINSTALL-189] Add parameter to lax project validation
cstamas merged PR #57: URL: https://github.com/apache/maven-install-plugin/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-7746) Update maven-help-plugin to 3.4.0 or later
[ https://issues.apache.org/jira/browse/MNG-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-7746. Resolution: Fixed > Update maven-help-plugin to 3.4.0 or later > -- > > Key: MNG-7746 > URL: https://issues.apache.org/jira/browse/MNG-7746 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-5 >Reporter: Lenny Primak >Priority: Trivial > > When executing maven help:all-profiles (possibly outside any project), the > default is too old and is incompatible with current 4.x maven builds. Please > upgrade maven to refer to the latest help plugin -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-deploy-plugin] slawekjaranowski commented on a diff in pull request #39: [MDEPLOY-308] Add parameter to lax project validation
slawekjaranowski commented on code in PR #39:
URL:
https://github.com/apache/maven-deploy-plugin/pull/39#discussion_r1143445694
##
src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java:
##
@@ -126,6 +126,18 @@ public class DeployMojo extends AbstractDeployMojo {
@Parameter(property = "maven.deploy.skip", defaultValue = "false")
private String skip = Boolean.FALSE.toString();
+/**
+ * Set this to true to allow incomplete project processing.
By default, such projects are forbidden
+ * and Mojo will fail to process them. Incomplete project is a Maven
Project that has any other packaging than
+ * "pom" and has no main artifact packaged. In the majority of cases, what
user really wants here is a project
+ * with "pom" packaging and some classified artifact attached (typical
example is some assembly being packaged
+ * and attached with classifier).
+ *
+ * @since 3.1.1
Review Comment:
3.2.0 - new feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7746) Update maven-help-plugin to 3.4.0 or later
[ https://issues.apache.org/jira/browse/MNG-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703222#comment-17703222 ] Lenny Primak commented on MNG-7746: --- I don't seem to have access to close this issue. Please close it. > Update maven-help-plugin to 3.4.0 or later > -- > > Key: MNG-7746 > URL: https://issues.apache.org/jira/browse/MNG-7746 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-5 >Reporter: Lenny Primak >Priority: Trivial > > When executing maven help:all-profiles (possibly outside any project), the > default is too old and is incompatible with current 4.x maven builds. Please > upgrade maven to refer to the latest help plugin -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-install-plugin] slawekjaranowski commented on a diff in pull request #57: [MINSTALL-189] Add parameter to lax project validation
slawekjaranowski commented on code in PR #57:
URL:
https://github.com/apache/maven-install-plugin/pull/57#discussion_r1143444062
##
src/main/java/org/apache/maven/plugins/install/InstallMojo.java:
##
@@ -82,6 +82,18 @@ public class InstallMojo extends AbstractMojo {
@Parameter(property = "maven.install.skip", defaultValue = "false")
private boolean skip;
+/**
+ * Set this to true to allow incomplete project processing.
By default, such projects are forbidden
+ * and Mojo will fail to process them. Incomplete project is a Maven
Project that has any other packaging than
+ * "pom" and has no main artifact packaged. In the majority of cases, what
user really wants here is a project
+ * with "pom" packaging and some classified artifact attached (typical
example is some assembly being packaged
+ * and attached with classifier).
+ *
+ * @since 3.1.1
Review Comment:
3.2.0 - as we add new feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MNG-7746) Update maven-help-plugin to 3.4.0 or later
[ https://issues.apache.org/jira/browse/MNG-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lenny Primak updated MNG-7746: -- Priority: Trivial (was: Major) > Update maven-help-plugin to 3.4.0 or later > -- > > Key: MNG-7746 > URL: https://issues.apache.org/jira/browse/MNG-7746 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-5 >Reporter: Lenny Primak >Priority: Trivial > > When executing maven help:all-profiles (possibly outside any project), the > default is too old and is incompatible with current 4.x maven builds. Please > upgrade maven to refer to the latest help plugin -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7746) Update maven-help-plugin to 3.4.0 or later
[ https://issues.apache.org/jira/browse/MNG-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703221#comment-17703221 ] Lenny Primak commented on MNG-7746: --- ha! Learn something new every day! Thank you > Update maven-help-plugin to 3.4.0 or later > -- > > Key: MNG-7746 > URL: https://issues.apache.org/jira/browse/MNG-7746 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Affects Versions: 4.0.0-alpha-4, 4.0.0-alpha-5 >Reporter: Lenny Primak >Priority: Major > > When executing maven help:all-profiles (possibly outside any project), the > default is too old and is incompatible with current 4.x maven builds. Please > upgrade maven to refer to the latest help plugin -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINSTALL-188) Upgrade Parent to 39
[ https://issues.apache.org/jira/browse/MINSTALL-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MINSTALL-188: - Fix Version/s: 3.1.1 (was: next-release) > Upgrade Parent to 39 > > > Key: MINSTALL-188 > URL: https://issues.apache.org/jira/browse/MINSTALL-188 > Project: Maven Install Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.1.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINSTALL-186) install-file fails when the file belongs to the local repository and using a localRepositoryPath
[
https://issues.apache.org/jira/browse/MINSTALL-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MINSTALL-186:
-
Fix Version/s: 3.1.1
(was: next-release)
> install-file fails when the file belongs to the local repository and using a
> localRepositoryPath
>
>
> Key: MINSTALL-186
> URL: https://issues.apache.org/jira/browse/MINSTALL-186
> Project: Maven Install Plugin
> Issue Type: Bug
> Components: install:install-file
>Affects Versions: 3.0.1, 3.1.0
>Reporter: Romain Bioteau
>Assignee: Slawomir Jaranowski
>Priority: Trivial
> Fix For: 3.1.1
>
>
> To reproduce:
> Assuming maven-deploy-plugin 3.0.0 EXISTS in your local repository:
> {code:bash}
> ❯ mvn org.apache.maven.plugins:maven-install-plugin:3.1.0:install-file
> -Dfile=$HOME/.m2/repository/org/apache/maven/plugins/maven-deploy-plugin/3.0.0/maven-deploy-plugin-3.0.0.jar
> -DlocalRepositoryPath=/tmp/repo -Dversion=3.0.0
> -DartifactId=maven-deploy-plugin -DgroupId=org.apache.maven.plugins -Dtype=jar
> [INFO] Scanning for projects...
> [INFO]
> [INFO] --< org.apache.maven:standalone-pom
> >---
> [INFO] Building Maven Stub Project (No POM) 1
> [INFO] [ pom
> ]-
> [INFO]
> [INFO] --- maven-install-plugin:3.1.0:install-file (default-cli) @
> standalone-pom ---
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.164 s
> [INFO] Finished at: 2022-11-25T19:12:32+01:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-install-plugin:3.1.0:install-file
> (default-cli) on project standalone-pom: Cannot install artifact. Artifact is
> already in the local repository.
> [ERROR]
> [ERROR] File in question is:
> /home/romain/.m2/repository/org/apache/maven/plugins/maven-deploy-plugin/3.0.0/maven-deploy-plugin-3.0.0.jar
> [ERROR]
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-mvnd] gnodet closed issue #822: mvnd 0.9.0 use stderr instead of stdout
gnodet closed issue #822: mvnd 0.9.0 use stderr instead of stdout URL: https://github.com/apache/maven-mvnd/issues/822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet merged pull request #824: Use system out for build log and sys err for in progress display, fixes #822
gnodet merged PR #824: URL: https://github.com/apache/maven-mvnd/pull/824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-deploy-plugin] cstamas opened a new pull request, #39: [MDEPLOY-308] Add parameter to lax project validation
cstamas opened a new pull request, #39: URL: https://github.com/apache/maven-deploy-plugin/pull/39 --- https://issues.apache.org/jira/browse/MDEPLOY-308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas opened a new pull request, #57: [MINSTALL-189] Add parameter to lax project validation
cstamas opened a new pull request, #57: URL: https://github.com/apache/maven-install-plugin/pull/57 --- https://issues.apache.org/jira/browse/MINSTALL-189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINSTALL-189) Add parameter to lax project validation
Tamas Cservenak created MINSTALL-189: Summary: Add parameter to lax project validation Key: MINSTALL-189 URL: https://issues.apache.org/jira/browse/MINSTALL-189 Project: Maven Install Plugin Issue Type: Improvement Components: install:install Reporter: Tamas Cservenak Fix For: 3.1.1 Affects all releases of m-install-p of 3.x line. h4. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MDEPLOY-308) Add parameter to lax project validation
Tamas Cservenak created MDEPLOY-308: --- Summary: Add parameter to lax project validation Key: MDEPLOY-308 URL: https://issues.apache.org/jira/browse/MDEPLOY-308 Project: Maven Deploy Plugin Issue Type: Improvement Components: deploy:deploy Reporter: Tamas Cservenak Fix For: 3.1.1 Affects all releases of m-deploy-p of 3.x line. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEPLOY-307) [REGRESSION] Longer deploy times
[ https://issues.apache.org/jira/browse/MDEPLOY-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703193#comment-17703193 ] Tamas Cservenak commented on MDEPLOY-307: - Use Maven 3.9.1 pls, as several factors were fixed (in Maven and in Resolver transports) > [REGRESSION] Longer deploy times > > > Key: MDEPLOY-307 > URL: https://issues.apache.org/jira/browse/MDEPLOY-307 > Project: Maven Deploy Plugin > Issue Type: Bug > Components: deploy:deploy >Affects Versions: 3.1.0 >Reporter: Delany >Priority: Major > > On Windows OS, a 500 module build takes half an hour to deploy when using > deployAtEnd. > I was expecting an improvement in build time with this version of the plugin. > Maven 3.9.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-shade-plugin] mavaddat opened a new pull request, #182: Small grammatical corrections and remove IRC
mavaddat opened a new pull request, #182: URL: https://github.com/apache/maven-shade-plugin/pull/182 Remove IRC and small grammatical corrections. Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHADE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MSHADE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MASSEMBLY-977) Warning if using Maven 3.9.1
Stefan Mueller created MASSEMBLY-977:
Summary: Warning if using Maven 3.9.1
Key: MASSEMBLY-977
URL: https://issues.apache.org/jira/browse/MASSEMBLY-977
Project: Maven Assembly Plugin
Issue Type: Bug
Affects Versions: 3.5.0
Reporter: Stefan Mueller
If using the latest Maven Version 3.9.1 the assembly-plugin produces this
warning:
{noformat}
[WARNING] Parameter 'localRepository' is deprecated core expression; Avoid use
of ArtifactRepository type. If you need access to local repository, switch to
'${repositorySystemSession}' expression and get LRM from it instead.{noformat}
Probably to be fixed in
[AbstractAssemblyMojo|https://github.com/apache/maven-assembly-plugin/blob/master/src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java],
Property localRepository.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRELEASE-1119) release plugin ignores developmentVersion
[
https://issues.apache.org/jira/browse/MRELEASE-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Patrick updated MRELEASE-1119:
-
Summary: release plugin ignores developmentVersion (was: release plugin
ignore developmentVersion)
> release plugin ignores developmentVersion
> -
>
> Key: MRELEASE-1119
> URL: https://issues.apache.org/jira/browse/MRELEASE-1119
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Robert Patrick
>Priority: Major
>
> I just ran a release process using the 3.0.0 version of the
> maven-release-plugin with a release.properties file like this:
> {{tag=release-3.0.4}}
> {{releaseVersion=3.0.4}}
> {{developmentVersion=3.1.0-SNAPSHOT}}
> After running {{mvn -B release:prepare release:perform}}, the pom.xml version
> is 3.0.5-SNAPSHOT.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MRESOURCES-289) FileUtils.copyFile() fails with source file having lastModified = 0
[
https://issues.apache.org/jira/browse/MRESOURCES-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MRESOURCES-289.
--
Resolution: Fixed
> FileUtils.copyFile() fails with source file having lastModified = 0
> ---
>
> Key: MRESOURCES-289
> URL: https://issues.apache.org/jira/browse/MRESOURCES-289
> Project: Maven Resources Plugin
> Issue Type: Bug
> Components: copy
>Affects Versions: 3.2.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.3.1
>
>
> The condition in
> https://github.com/apache/maven-shared-utils/blob/2bf1e034b06557830b9e2bfe0689f1b93ea5fbd0/src/main/java/org/apache/maven/shared/utils/io/FileUtils.java#L1904
> returns false in case the source file returns {{File.lastModified() = 0}} as
> {{File.lastModified()}} also returns 0 for non-existing files
> (https://docs.oracle.com/javase/7/docs/api/java/io/File.html#lastModified()).
> This leads to the following exception in case the destination does not yet
> exist.
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-resources-plugin:3.2.0:testResources
> (default-testResources) on project filevault-package-maven-plugin:
> -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-resources-plugin:3.2.0:testResources
> (default-testResources) on project filevault-package-maven-plugin:
>
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:375)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:351)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:171)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:163)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException:
>
> at org.apache.maven.plugins.resources.ResourcesMojo.execute
> (ResourcesMojo.java:362)
> at org.apache.maven.plugins.resources.TestResourcesMojo.execute
> (TestResourcesMojo.java:75)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:370)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:351)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:171)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:163)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at
[jira] [Closed] (MRESOURCES-269) Symlinks cause copying resources to fail
[ https://issues.apache.org/jira/browse/MRESOURCES-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOURCES-269. -- Resolution: Fixed > Symlinks cause copying resources to fail > > > Key: MRESOURCES-269 > URL: https://issues.apache.org/jira/browse/MRESOURCES-269 > Project: Maven Resources Plugin > Issue Type: Bug >Affects Versions: 3.2.0 >Reporter: jks >Priority: Major > Fix For: 3.3.1 > > Attachments: MRESOURCES-269.tar.gz, log.txt > > > Copying a symlink fails if the target does not exist. If the symlink is > relative the order that the resources are copied matter. If A points to B > but A is copied before B the copying of A will fail with a non-helpful > message "Failed to execute goal ... on project xxx: ". > > This started failing for me on 3.2.0 (and works on 3.1.0) but that might be > because somewhere in the dependencies the traversal order changed somehow. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MRESOURCES-296) Upgrade to maven-filtering 3.3.1
[ https://issues.apache.org/jira/browse/MRESOURCES-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOURCES-296. -- Resolution: Fixed Fixed in b7cd080d7ba98e5cefe58b1ef78c209cad8ae0fe > Upgrade to maven-filtering 3.3.1 > > > Key: MRESOURCES-296 > URL: https://issues.apache.org/jira/browse/MRESOURCES-296 > Project: Maven Resources Plugin > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.3.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MRESOURCES-292) describe from and to in "Copying x resources" info message
[ https://issues.apache.org/jira/browse/MRESOURCES-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOURCES-292. -- Resolution: Fixed > describe from and to in "Copying x resources" info message > -- > > Key: MRESOURCES-292 > URL: https://issues.apache.org/jira/browse/MRESOURCES-292 > Project: Maven Resources Plugin > Issue Type: Improvement > Components: copy >Affects Versions: 3.3.0 >Reporter: Herve Boutemy >Assignee: Herve Boutemy >Priority: Major > Fix For: 3.3.1 > > > Currently, default destination directory is either implicit or shown with > full path, and from is hidden: > [INFO] — maven-resources-plugin:3.3.0:resources (default-resources) @ demo — > [INFO] Copying 3 resources > [INFO] Copying 70 resources to /noisy/path/to/project/target/site-src > [INFO] — maven-resources-plugin:3.3.0:testResources (default-testResources) @ > demo — > [INFO] Copying 39 resources > It would be much clearer to always see info as relative: > [INFO] — maven-resources-plugin:3.3.1-SNAPSHOT:resources (default-resources) > @ demo — > [INFO] Copying 3 resources from src/main/resources to target/classes > [INFO] Copying 70 resources from src/site to target/site-src > [INFO] — maven-resources-plugin:3.3.1-SNAPSHOT:testResources > (default-testResources) @ demo — > [INFO] Copying 39 resources from src/test/resources to target/test-classes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7741) Add more information when using -Dmaven.repo.local.recordReverseTree=true
[
https://issues.apache.org/jira/browse/MNG-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703173#comment-17703173
]
ASF GitHub Bot commented on MNG-7741:
-
michael-o commented on code in PR #1058:
URL: https://github.com/apache/maven/pull/1058#discussion_r1143278882
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -49,45 +56,128 @@ class ReverseTreeRepositoryListener extends
AbstractRepositoryListener {
public void artifactResolved(RepositoryEvent event) {
requireNonNull(event, "event cannot be null");
-if (!isLocalRepositoryArtifact(event.getSession(),
event.getArtifact())) {
+if (!isLocalRepositoryArtifactOrMissing(event.getSession(),
event.getArtifact())) {
return;
}
-CollectStepData collectStepTrace =
lookupCollectStepData(event.getTrace());
-if (collectStepTrace == null) {
-return;
+RequestTrace trace = event.getTrace();
+
+CollectStepData collectStepTrace = null;
+ArtifactRequest artifactRequest = null;
+ArtifactDescriptorRequest artifactDescriptorRequest = null;
+Plugin plugin = null;
+
+while (trace != null) {
+Object data = trace.getData();
+if (data instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) data;
+} else if (data instanceof ArtifactDescriptorRequest) {
+artifactDescriptorRequest = (ArtifactDescriptorRequest) data;
+} else if (data instanceof ArtifactRequest) {
+artifactRequest = (ArtifactRequest) data;
+} else if (data instanceof Plugin) {
+plugin = (Plugin) data;
+}
+trace = trace.getParent();
}
-Artifact resolvedArtifact = event.getArtifact();
-Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
-
-if (isInScope(resolvedArtifact, nodeArtifact)) {
-Dependency node = collectStepTrace.getNode();
-ArrayList trackingData = new ArrayList<>();
-trackingData.add(node + " (" + collectStepTrace.getContext() +
")");
-String indent = "";
-ListIterator iter = collectStepTrace
-.getPath()
-.listIterator(collectStepTrace.getPath().size());
-while (iter.hasPrevious()) {
-DependencyNode curr = iter.previous();
+Path trackingDir;
+boolean missing = event.getFile() == null;
+if (missing) {
+// missing artifact - let's track the path anyway
+File dir = event.getSession().getLocalRepository().getBasedir();
+dir = new File(
+dir,
event.getSession().getLocalRepositoryManager().getPathForLocalArtifact(event.getArtifact()));
+trackingDir = dir.getParentFile().toPath().resolve(".tracking");
+} else {
+trackingDir =
event.getFile().getParentFile().toPath().resolve(".tracking");
+}
+
+String baseName;
+String ext = missing ? ".miss" : ".dep";
+Path trackingFile = null;
+
+String indent = "";
+ArrayList trackingData = new ArrayList<>();
+
+if (collectStepTrace == null && plugin != null) {
+ext = ".plugin";
+baseName = plugin.getGroupId() + "_" + plugin.getArtifactId() +
"_" + plugin.getVersion();
+trackingFile = trackingDir.resolve(baseName + ext);
+if (Files.exists(trackingFile)) {
+return;
+}
+
+if (event.getArtifact() != null) {
+trackingData.add(indent + event.getArtifact());
+indent += " ";
+}
+trackingData.add(indent + plugin.getGroupId() + ":" +
plugin.getArtifactId() + ":" + plugin.getVersion());
+indent += " ";
+
+InputLocation location = plugin.getLocation("");
+if (location != null && location.getSource() != null) {
+trackingData.add(indent + location.getSource().getModelId() +
" (implicit)");
indent += " ";
-trackingData.add(indent + curr + " (" +
collectStepTrace.getContext() + ")");
}
-try {
-Path trackingDir =
-
resolvedArtifact.getFile().getParentFile().toPath().resolve(".tracking");
-Files.createDirectories(trackingDir);
-Path trackingFile = trackingDir.resolve(collectStepTrace
+} else if (collectStepTrace != null) {
+baseName =
+
collectStepTrace.getPath().get(0).getArtifact().toString().replace(":", "_");
Review Comment:
@grgrzybek, please file an issue regarding the separator.
> Add more information when using
[jira] [Commented] (MNG-7741) Add more information when using -Dmaven.repo.local.recordReverseTree=true
[
https://issues.apache.org/jira/browse/MNG-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703172#comment-17703172
]
ASF GitHub Bot commented on MNG-7741:
-
michael-o commented on code in PR #1058:
URL: https://github.com/apache/maven/pull/1058#discussion_r1143278548
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -49,45 +56,128 @@ class ReverseTreeRepositoryListener extends
AbstractRepositoryListener {
public void artifactResolved(RepositoryEvent event) {
requireNonNull(event, "event cannot be null");
-if (!isLocalRepositoryArtifact(event.getSession(),
event.getArtifact())) {
+if (!isLocalRepositoryArtifactOrMissing(event.getSession(),
event.getArtifact())) {
return;
}
-CollectStepData collectStepTrace =
lookupCollectStepData(event.getTrace());
-if (collectStepTrace == null) {
-return;
+RequestTrace trace = event.getTrace();
+
+CollectStepData collectStepTrace = null;
+ArtifactRequest artifactRequest = null;
+ArtifactDescriptorRequest artifactDescriptorRequest = null;
+Plugin plugin = null;
+
+while (trace != null) {
+Object data = trace.getData();
+if (data instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) data;
+} else if (data instanceof ArtifactDescriptorRequest) {
+artifactDescriptorRequest = (ArtifactDescriptorRequest) data;
+} else if (data instanceof ArtifactRequest) {
+artifactRequest = (ArtifactRequest) data;
+} else if (data instanceof Plugin) {
+plugin = (Plugin) data;
+}
+trace = trace.getParent();
}
-Artifact resolvedArtifact = event.getArtifact();
-Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
-
-if (isInScope(resolvedArtifact, nodeArtifact)) {
-Dependency node = collectStepTrace.getNode();
-ArrayList trackingData = new ArrayList<>();
-trackingData.add(node + " (" + collectStepTrace.getContext() +
")");
-String indent = "";
-ListIterator iter = collectStepTrace
-.getPath()
-.listIterator(collectStepTrace.getPath().size());
-while (iter.hasPrevious()) {
-DependencyNode curr = iter.previous();
+Path trackingDir;
+boolean missing = event.getFile() == null;
+if (missing) {
+// missing artifact - let's track the path anyway
+File dir = event.getSession().getLocalRepository().getBasedir();
+dir = new File(
+dir,
event.getSession().getLocalRepositoryManager().getPathForLocalArtifact(event.getArtifact()));
+trackingDir = dir.getParentFile().toPath().resolve(".tracking");
+} else {
+trackingDir =
event.getFile().getParentFile().toPath().resolve(".tracking");
+}
+
+String baseName;
+String ext = missing ? ".miss" : ".dep";
+Path trackingFile = null;
+
+String indent = "";
+ArrayList trackingData = new ArrayList<>();
+
+if (collectStepTrace == null && plugin != null) {
+ext = ".plugin";
+baseName = plugin.getGroupId() + "_" + plugin.getArtifactId() +
"_" + plugin.getVersion();
+trackingFile = trackingDir.resolve(baseName + ext);
+if (Files.exists(trackingFile)) {
+return;
+}
+
+if (event.getArtifact() != null) {
+trackingData.add(indent + event.getArtifact());
+indent += " ";
+}
+trackingData.add(indent + plugin.getGroupId() + ":" +
plugin.getArtifactId() + ":" + plugin.getVersion());
+indent += " ";
+
+InputLocation location = plugin.getLocation("");
+if (location != null && location.getSource() != null) {
+trackingData.add(indent + location.getSource().getModelId() +
" (implicit)");
indent += " ";
-trackingData.add(indent + curr + " (" +
collectStepTrace.getContext() + ")");
}
-try {
-Path trackingDir =
-
resolvedArtifact.getFile().getParentFile().toPath().resolve(".tracking");
-Files.createDirectories(trackingDir);
-Path trackingFile = trackingDir.resolve(collectStepTrace
+} else if (collectStepTrace != null) {
+baseName =
+
collectStepTrace.getPath().get(0).getArtifact().toString().replace(":", "_");
Review Comment:
Yes, that is not (yet) flexible, use a `replace()` for now.
> Add more information when using
[GitHub] [maven] michael-o commented on a diff in pull request #1058: [MNG-7741] Track missing files, plugin and parent pom dependencies
michael-o commented on code in PR #1058:
URL: https://github.com/apache/maven/pull/1058#discussion_r1143278882
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -49,45 +56,128 @@ class ReverseTreeRepositoryListener extends
AbstractRepositoryListener {
public void artifactResolved(RepositoryEvent event) {
requireNonNull(event, "event cannot be null");
-if (!isLocalRepositoryArtifact(event.getSession(),
event.getArtifact())) {
+if (!isLocalRepositoryArtifactOrMissing(event.getSession(),
event.getArtifact())) {
return;
}
-CollectStepData collectStepTrace =
lookupCollectStepData(event.getTrace());
-if (collectStepTrace == null) {
-return;
+RequestTrace trace = event.getTrace();
+
+CollectStepData collectStepTrace = null;
+ArtifactRequest artifactRequest = null;
+ArtifactDescriptorRequest artifactDescriptorRequest = null;
+Plugin plugin = null;
+
+while (trace != null) {
+Object data = trace.getData();
+if (data instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) data;
+} else if (data instanceof ArtifactDescriptorRequest) {
+artifactDescriptorRequest = (ArtifactDescriptorRequest) data;
+} else if (data instanceof ArtifactRequest) {
+artifactRequest = (ArtifactRequest) data;
+} else if (data instanceof Plugin) {
+plugin = (Plugin) data;
+}
+trace = trace.getParent();
}
-Artifact resolvedArtifact = event.getArtifact();
-Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
-
-if (isInScope(resolvedArtifact, nodeArtifact)) {
-Dependency node = collectStepTrace.getNode();
-ArrayList trackingData = new ArrayList<>();
-trackingData.add(node + " (" + collectStepTrace.getContext() +
")");
-String indent = "";
-ListIterator iter = collectStepTrace
-.getPath()
-.listIterator(collectStepTrace.getPath().size());
-while (iter.hasPrevious()) {
-DependencyNode curr = iter.previous();
+Path trackingDir;
+boolean missing = event.getFile() == null;
+if (missing) {
+// missing artifact - let's track the path anyway
+File dir = event.getSession().getLocalRepository().getBasedir();
+dir = new File(
+dir,
event.getSession().getLocalRepositoryManager().getPathForLocalArtifact(event.getArtifact()));
+trackingDir = dir.getParentFile().toPath().resolve(".tracking");
+} else {
+trackingDir =
event.getFile().getParentFile().toPath().resolve(".tracking");
+}
+
+String baseName;
+String ext = missing ? ".miss" : ".dep";
+Path trackingFile = null;
+
+String indent = "";
+ArrayList trackingData = new ArrayList<>();
+
+if (collectStepTrace == null && plugin != null) {
+ext = ".plugin";
+baseName = plugin.getGroupId() + "_" + plugin.getArtifactId() +
"_" + plugin.getVersion();
+trackingFile = trackingDir.resolve(baseName + ext);
+if (Files.exists(trackingFile)) {
+return;
+}
+
+if (event.getArtifact() != null) {
+trackingData.add(indent + event.getArtifact());
+indent += " ";
+}
+trackingData.add(indent + plugin.getGroupId() + ":" +
plugin.getArtifactId() + ":" + plugin.getVersion());
+indent += " ";
+
+InputLocation location = plugin.getLocation("");
+if (location != null && location.getSource() != null) {
+trackingData.add(indent + location.getSource().getModelId() +
" (implicit)");
indent += " ";
-trackingData.add(indent + curr + " (" +
collectStepTrace.getContext() + ")");
}
-try {
-Path trackingDir =
-
resolvedArtifact.getFile().getParentFile().toPath().resolve(".tracking");
-Files.createDirectories(trackingDir);
-Path trackingFile = trackingDir.resolve(collectStepTrace
+} else if (collectStepTrace != null) {
+baseName =
+
collectStepTrace.getPath().get(0).getArtifact().toString().replace(":", "_");
Review Comment:
@grgrzybek, please file an issue regarding the separator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
[GitHub] [maven] michael-o commented on a diff in pull request #1058: [MNG-7741] Track missing files, plugin and parent pom dependencies
michael-o commented on code in PR #1058:
URL: https://github.com/apache/maven/pull/1058#discussion_r1143278548
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -49,45 +56,128 @@ class ReverseTreeRepositoryListener extends
AbstractRepositoryListener {
public void artifactResolved(RepositoryEvent event) {
requireNonNull(event, "event cannot be null");
-if (!isLocalRepositoryArtifact(event.getSession(),
event.getArtifact())) {
+if (!isLocalRepositoryArtifactOrMissing(event.getSession(),
event.getArtifact())) {
return;
}
-CollectStepData collectStepTrace =
lookupCollectStepData(event.getTrace());
-if (collectStepTrace == null) {
-return;
+RequestTrace trace = event.getTrace();
+
+CollectStepData collectStepTrace = null;
+ArtifactRequest artifactRequest = null;
+ArtifactDescriptorRequest artifactDescriptorRequest = null;
+Plugin plugin = null;
+
+while (trace != null) {
+Object data = trace.getData();
+if (data instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) data;
+} else if (data instanceof ArtifactDescriptorRequest) {
+artifactDescriptorRequest = (ArtifactDescriptorRequest) data;
+} else if (data instanceof ArtifactRequest) {
+artifactRequest = (ArtifactRequest) data;
+} else if (data instanceof Plugin) {
+plugin = (Plugin) data;
+}
+trace = trace.getParent();
}
-Artifact resolvedArtifact = event.getArtifact();
-Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
-
-if (isInScope(resolvedArtifact, nodeArtifact)) {
-Dependency node = collectStepTrace.getNode();
-ArrayList trackingData = new ArrayList<>();
-trackingData.add(node + " (" + collectStepTrace.getContext() +
")");
-String indent = "";
-ListIterator iter = collectStepTrace
-.getPath()
-.listIterator(collectStepTrace.getPath().size());
-while (iter.hasPrevious()) {
-DependencyNode curr = iter.previous();
+Path trackingDir;
+boolean missing = event.getFile() == null;
+if (missing) {
+// missing artifact - let's track the path anyway
+File dir = event.getSession().getLocalRepository().getBasedir();
+dir = new File(
+dir,
event.getSession().getLocalRepositoryManager().getPathForLocalArtifact(event.getArtifact()));
+trackingDir = dir.getParentFile().toPath().resolve(".tracking");
+} else {
+trackingDir =
event.getFile().getParentFile().toPath().resolve(".tracking");
+}
+
+String baseName;
+String ext = missing ? ".miss" : ".dep";
+Path trackingFile = null;
+
+String indent = "";
+ArrayList trackingData = new ArrayList<>();
+
+if (collectStepTrace == null && plugin != null) {
+ext = ".plugin";
+baseName = plugin.getGroupId() + "_" + plugin.getArtifactId() +
"_" + plugin.getVersion();
+trackingFile = trackingDir.resolve(baseName + ext);
+if (Files.exists(trackingFile)) {
+return;
+}
+
+if (event.getArtifact() != null) {
+trackingData.add(indent + event.getArtifact());
+indent += " ";
+}
+trackingData.add(indent + plugin.getGroupId() + ":" +
plugin.getArtifactId() + ":" + plugin.getVersion());
+indent += " ";
+
+InputLocation location = plugin.getLocation("");
+if (location != null && location.getSource() != null) {
+trackingData.add(indent + location.getSource().getModelId() +
" (implicit)");
indent += " ";
-trackingData.add(indent + curr + " (" +
collectStepTrace.getContext() + ")");
}
-try {
-Path trackingDir =
-
resolvedArtifact.getFile().getParentFile().toPath().resolve(".tracking");
-Files.createDirectories(trackingDir);
-Path trackingFile = trackingDir.resolve(collectStepTrace
+} else if (collectStepTrace != null) {
+baseName =
+
collectStepTrace.getPath().get(0).getArtifact().toString().replace(":", "_");
Review Comment:
Yes, that is not (yet) flexible, use a `replace()` for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure
[jira] [Commented] (MNG-7741) Add more information when using -Dmaven.repo.local.recordReverseTree=true
[
https://issues.apache.org/jira/browse/MNG-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703169#comment-17703169
]
ASF GitHub Bot commented on MNG-7741:
-
grgrzybek commented on code in PR #1058:
URL: https://github.com/apache/maven/pull/1058#discussion_r1143267697
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -49,45 +56,128 @@ class ReverseTreeRepositoryListener extends
AbstractRepositoryListener {
public void artifactResolved(RepositoryEvent event) {
requireNonNull(event, "event cannot be null");
-if (!isLocalRepositoryArtifact(event.getSession(),
event.getArtifact())) {
+if (!isLocalRepositoryArtifactOrMissing(event.getSession(),
event.getArtifact())) {
return;
}
-CollectStepData collectStepTrace =
lookupCollectStepData(event.getTrace());
-if (collectStepTrace == null) {
-return;
+RequestTrace trace = event.getTrace();
+
+CollectStepData collectStepTrace = null;
+ArtifactRequest artifactRequest = null;
+ArtifactDescriptorRequest artifactDescriptorRequest = null;
+Plugin plugin = null;
+
+while (trace != null) {
+Object data = trace.getData();
+if (data instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) data;
+} else if (data instanceof ArtifactDescriptorRequest) {
+artifactDescriptorRequest = (ArtifactDescriptorRequest) data;
+} else if (data instanceof ArtifactRequest) {
+artifactRequest = (ArtifactRequest) data;
+} else if (data instanceof Plugin) {
+plugin = (Plugin) data;
+}
+trace = trace.getParent();
}
-Artifact resolvedArtifact = event.getArtifact();
-Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
-
-if (isInScope(resolvedArtifact, nodeArtifact)) {
-Dependency node = collectStepTrace.getNode();
-ArrayList trackingData = new ArrayList<>();
-trackingData.add(node + " (" + collectStepTrace.getContext() +
")");
-String indent = "";
-ListIterator iter = collectStepTrace
-.getPath()
-.listIterator(collectStepTrace.getPath().size());
-while (iter.hasPrevious()) {
-DependencyNode curr = iter.previous();
+Path trackingDir;
+boolean missing = event.getFile() == null;
+if (missing) {
+// missing artifact - let's track the path anyway
+File dir = event.getSession().getLocalRepository().getBasedir();
+dir = new File(
+dir,
event.getSession().getLocalRepositoryManager().getPathForLocalArtifact(event.getArtifact()));
+trackingDir = dir.getParentFile().toPath().resolve(".tracking");
+} else {
+trackingDir =
event.getFile().getParentFile().toPath().resolve(".tracking");
+}
+
+String baseName;
+String ext = missing ? ".miss" : ".dep";
+Path trackingFile = null;
+
+String indent = "";
+ArrayList trackingData = new ArrayList<>();
+
+if (collectStepTrace == null && plugin != null) {
+ext = ".plugin";
+baseName = plugin.getGroupId() + "_" + plugin.getArtifactId() +
"_" + plugin.getVersion();
+trackingFile = trackingDir.resolve(baseName + ext);
+if (Files.exists(trackingFile)) {
+return;
+}
+
+if (event.getArtifact() != null) {
+trackingData.add(indent + event.getArtifact());
+indent += " ";
+}
+trackingData.add(indent + plugin.getGroupId() + ":" +
plugin.getArtifactId() + ":" + plugin.getVersion());
+indent += " ";
+
+InputLocation location = plugin.getLocation("");
+if (location != null && location.getSource() != null) {
+trackingData.add(indent + location.getSource().getModelId() +
" (implicit)");
indent += " ";
-trackingData.add(indent + curr + " (" +
collectStepTrace.getContext() + ")");
}
-try {
-Path trackingDir =
-
resolvedArtifact.getFile().getParentFile().toPath().resolve(".tracking");
-Files.createDirectories(trackingDir);
-Path trackingFile = trackingDir.resolve(collectStepTrace
+} else if (collectStepTrace != null) {
+baseName =
+
collectStepTrace.getPath().get(0).getArtifact().toString().replace(":", "_");
Review Comment:
And `ArtifactIdUtils` uses `SEP = ':'` anyway... I want `_`.
> Add more information when using
[GitHub] [maven] grgrzybek commented on a diff in pull request #1058: [MNG-7741] Track missing files, plugin and parent pom dependencies
grgrzybek commented on code in PR #1058:
URL: https://github.com/apache/maven/pull/1058#discussion_r1143267697
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -49,45 +56,128 @@ class ReverseTreeRepositoryListener extends
AbstractRepositoryListener {
public void artifactResolved(RepositoryEvent event) {
requireNonNull(event, "event cannot be null");
-if (!isLocalRepositoryArtifact(event.getSession(),
event.getArtifact())) {
+if (!isLocalRepositoryArtifactOrMissing(event.getSession(),
event.getArtifact())) {
return;
}
-CollectStepData collectStepTrace =
lookupCollectStepData(event.getTrace());
-if (collectStepTrace == null) {
-return;
+RequestTrace trace = event.getTrace();
+
+CollectStepData collectStepTrace = null;
+ArtifactRequest artifactRequest = null;
+ArtifactDescriptorRequest artifactDescriptorRequest = null;
+Plugin plugin = null;
+
+while (trace != null) {
+Object data = trace.getData();
+if (data instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) data;
+} else if (data instanceof ArtifactDescriptorRequest) {
+artifactDescriptorRequest = (ArtifactDescriptorRequest) data;
+} else if (data instanceof ArtifactRequest) {
+artifactRequest = (ArtifactRequest) data;
+} else if (data instanceof Plugin) {
+plugin = (Plugin) data;
+}
+trace = trace.getParent();
}
-Artifact resolvedArtifact = event.getArtifact();
-Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
-
-if (isInScope(resolvedArtifact, nodeArtifact)) {
-Dependency node = collectStepTrace.getNode();
-ArrayList trackingData = new ArrayList<>();
-trackingData.add(node + " (" + collectStepTrace.getContext() +
")");
-String indent = "";
-ListIterator iter = collectStepTrace
-.getPath()
-.listIterator(collectStepTrace.getPath().size());
-while (iter.hasPrevious()) {
-DependencyNode curr = iter.previous();
+Path trackingDir;
+boolean missing = event.getFile() == null;
+if (missing) {
+// missing artifact - let's track the path anyway
+File dir = event.getSession().getLocalRepository().getBasedir();
+dir = new File(
+dir,
event.getSession().getLocalRepositoryManager().getPathForLocalArtifact(event.getArtifact()));
+trackingDir = dir.getParentFile().toPath().resolve(".tracking");
+} else {
+trackingDir =
event.getFile().getParentFile().toPath().resolve(".tracking");
+}
+
+String baseName;
+String ext = missing ? ".miss" : ".dep";
+Path trackingFile = null;
+
+String indent = "";
+ArrayList trackingData = new ArrayList<>();
+
+if (collectStepTrace == null && plugin != null) {
+ext = ".plugin";
+baseName = plugin.getGroupId() + "_" + plugin.getArtifactId() +
"_" + plugin.getVersion();
+trackingFile = trackingDir.resolve(baseName + ext);
+if (Files.exists(trackingFile)) {
+return;
+}
+
+if (event.getArtifact() != null) {
+trackingData.add(indent + event.getArtifact());
+indent += " ";
+}
+trackingData.add(indent + plugin.getGroupId() + ":" +
plugin.getArtifactId() + ":" + plugin.getVersion());
+indent += " ";
+
+InputLocation location = plugin.getLocation("");
+if (location != null && location.getSource() != null) {
+trackingData.add(indent + location.getSource().getModelId() +
" (implicit)");
indent += " ";
-trackingData.add(indent + curr + " (" +
collectStepTrace.getContext() + ")");
}
-try {
-Path trackingDir =
-
resolvedArtifact.getFile().getParentFile().toPath().resolve(".tracking");
-Files.createDirectories(trackingDir);
-Path trackingFile = trackingDir.resolve(collectStepTrace
+} else if (collectStepTrace != null) {
+baseName =
+
collectStepTrace.getPath().get(0).getArtifact().toString().replace(":", "_");
Review Comment:
And `ArtifactIdUtils` uses `SEP = ':'` anyway... I want `_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure
[jira] [Commented] (MNG-7741) Add more information when using -Dmaven.repo.local.recordReverseTree=true
[
https://issues.apache.org/jira/browse/MNG-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703167#comment-17703167
]
ASF GitHub Bot commented on MNG-7741:
-
grgrzybek commented on code in PR #1058:
URL: https://github.com/apache/maven/pull/1058#discussion_r1143265861
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -49,45 +56,128 @@ class ReverseTreeRepositoryListener extends
AbstractRepositoryListener {
public void artifactResolved(RepositoryEvent event) {
requireNonNull(event, "event cannot be null");
-if (!isLocalRepositoryArtifact(event.getSession(),
event.getArtifact())) {
+if (!isLocalRepositoryArtifactOrMissing(event.getSession(),
event.getArtifact())) {
return;
}
-CollectStepData collectStepTrace =
lookupCollectStepData(event.getTrace());
-if (collectStepTrace == null) {
-return;
+RequestTrace trace = event.getTrace();
+
+CollectStepData collectStepTrace = null;
+ArtifactRequest artifactRequest = null;
+ArtifactDescriptorRequest artifactDescriptorRequest = null;
+Plugin plugin = null;
+
+while (trace != null) {
+Object data = trace.getData();
+if (data instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) data;
+} else if (data instanceof ArtifactDescriptorRequest) {
+artifactDescriptorRequest = (ArtifactDescriptorRequest) data;
+} else if (data instanceof ArtifactRequest) {
+artifactRequest = (ArtifactRequest) data;
+} else if (data instanceof Plugin) {
+plugin = (Plugin) data;
+}
+trace = trace.getParent();
}
-Artifact resolvedArtifact = event.getArtifact();
-Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
-
-if (isInScope(resolvedArtifact, nodeArtifact)) {
-Dependency node = collectStepTrace.getNode();
-ArrayList trackingData = new ArrayList<>();
-trackingData.add(node + " (" + collectStepTrace.getContext() +
")");
-String indent = "";
-ListIterator iter = collectStepTrace
-.getPath()
-.listIterator(collectStepTrace.getPath().size());
-while (iter.hasPrevious()) {
-DependencyNode curr = iter.previous();
+Path trackingDir;
+boolean missing = event.getFile() == null;
+if (missing) {
+// missing artifact - let's track the path anyway
+File dir = event.getSession().getLocalRepository().getBasedir();
+dir = new File(
+dir,
event.getSession().getLocalRepositoryManager().getPathForLocalArtifact(event.getArtifact()));
+trackingDir = dir.getParentFile().toPath().resolve(".tracking");
+} else {
+trackingDir =
event.getFile().getParentFile().toPath().resolve(".tracking");
+}
+
+String baseName;
+String ext = missing ? ".miss" : ".dep";
+Path trackingFile = null;
+
+String indent = "";
+ArrayList trackingData = new ArrayList<>();
+
+if (collectStepTrace == null && plugin != null) {
+ext = ".plugin";
+baseName = plugin.getGroupId() + "_" + plugin.getArtifactId() +
"_" + plugin.getVersion();
+trackingFile = trackingDir.resolve(baseName + ext);
+if (Files.exists(trackingFile)) {
+return;
+}
+
+if (event.getArtifact() != null) {
+trackingData.add(indent + event.getArtifact());
+indent += " ";
+}
+trackingData.add(indent + plugin.getGroupId() + ":" +
plugin.getArtifactId() + ":" + plugin.getVersion());
+indent += " ";
+
+InputLocation location = plugin.getLocation("");
+if (location != null && location.getSource() != null) {
+trackingData.add(indent + location.getSource().getModelId() +
" (implicit)");
indent += " ";
-trackingData.add(indent + curr + " (" +
collectStepTrace.getContext() + ")");
}
-try {
-Path trackingDir =
-
resolvedArtifact.getFile().getParentFile().toPath().resolve(".tracking");
-Files.createDirectories(trackingDir);
-Path trackingFile = trackingDir.resolve(collectStepTrace
+} else if (collectStepTrace != null) {
+baseName =
+
collectStepTrace.getPath().get(0).getArtifact().toString().replace(":", "_");
Review Comment:
Thanks, checking.
However current it's just toString + replace:
[GitHub] [maven] grgrzybek commented on a diff in pull request #1058: [MNG-7741] Track missing files, plugin and parent pom dependencies
grgrzybek commented on code in PR #1058:
URL: https://github.com/apache/maven/pull/1058#discussion_r1143265861
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -49,45 +56,128 @@ class ReverseTreeRepositoryListener extends
AbstractRepositoryListener {
public void artifactResolved(RepositoryEvent event) {
requireNonNull(event, "event cannot be null");
-if (!isLocalRepositoryArtifact(event.getSession(),
event.getArtifact())) {
+if (!isLocalRepositoryArtifactOrMissing(event.getSession(),
event.getArtifact())) {
return;
}
-CollectStepData collectStepTrace =
lookupCollectStepData(event.getTrace());
-if (collectStepTrace == null) {
-return;
+RequestTrace trace = event.getTrace();
+
+CollectStepData collectStepTrace = null;
+ArtifactRequest artifactRequest = null;
+ArtifactDescriptorRequest artifactDescriptorRequest = null;
+Plugin plugin = null;
+
+while (trace != null) {
+Object data = trace.getData();
+if (data instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) data;
+} else if (data instanceof ArtifactDescriptorRequest) {
+artifactDescriptorRequest = (ArtifactDescriptorRequest) data;
+} else if (data instanceof ArtifactRequest) {
+artifactRequest = (ArtifactRequest) data;
+} else if (data instanceof Plugin) {
+plugin = (Plugin) data;
+}
+trace = trace.getParent();
}
-Artifact resolvedArtifact = event.getArtifact();
-Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
-
-if (isInScope(resolvedArtifact, nodeArtifact)) {
-Dependency node = collectStepTrace.getNode();
-ArrayList trackingData = new ArrayList<>();
-trackingData.add(node + " (" + collectStepTrace.getContext() +
")");
-String indent = "";
-ListIterator iter = collectStepTrace
-.getPath()
-.listIterator(collectStepTrace.getPath().size());
-while (iter.hasPrevious()) {
-DependencyNode curr = iter.previous();
+Path trackingDir;
+boolean missing = event.getFile() == null;
+if (missing) {
+// missing artifact - let's track the path anyway
+File dir = event.getSession().getLocalRepository().getBasedir();
+dir = new File(
+dir,
event.getSession().getLocalRepositoryManager().getPathForLocalArtifact(event.getArtifact()));
+trackingDir = dir.getParentFile().toPath().resolve(".tracking");
+} else {
+trackingDir =
event.getFile().getParentFile().toPath().resolve(".tracking");
+}
+
+String baseName;
+String ext = missing ? ".miss" : ".dep";
+Path trackingFile = null;
+
+String indent = "";
+ArrayList trackingData = new ArrayList<>();
+
+if (collectStepTrace == null && plugin != null) {
+ext = ".plugin";
+baseName = plugin.getGroupId() + "_" + plugin.getArtifactId() +
"_" + plugin.getVersion();
+trackingFile = trackingDir.resolve(baseName + ext);
+if (Files.exists(trackingFile)) {
+return;
+}
+
+if (event.getArtifact() != null) {
+trackingData.add(indent + event.getArtifact());
+indent += " ";
+}
+trackingData.add(indent + plugin.getGroupId() + ":" +
plugin.getArtifactId() + ":" + plugin.getVersion());
+indent += " ";
+
+InputLocation location = plugin.getLocation("");
+if (location != null && location.getSource() != null) {
+trackingData.add(indent + location.getSource().getModelId() +
" (implicit)");
indent += " ";
-trackingData.add(indent + curr + " (" +
collectStepTrace.getContext() + ")");
}
-try {
-Path trackingDir =
-
resolvedArtifact.getFile().getParentFile().toPath().resolve(".tracking");
-Files.createDirectories(trackingDir);
-Path trackingFile = trackingDir.resolve(collectStepTrace
+} else if (collectStepTrace != null) {
+baseName =
+
collectStepTrace.getPath().get(0).getArtifact().toString().replace(":", "_");
Review Comment:
Thanks, checking.
However current it's just toString + replace:
https://github.com/apache/maven/blob/maven-3.9.1/maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java#L81-L86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[jira] [Commented] (MNG-7741) Add more information when using -Dmaven.repo.local.recordReverseTree=true
[
https://issues.apache.org/jira/browse/MNG-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703166#comment-17703166
]
ASF GitHub Bot commented on MNG-7741:
-
michael-o commented on code in PR #1058:
URL: https://github.com/apache/maven/pull/1058#discussion_r1143265427
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -49,45 +56,128 @@ class ReverseTreeRepositoryListener extends
AbstractRepositoryListener {
public void artifactResolved(RepositoryEvent event) {
requireNonNull(event, "event cannot be null");
-if (!isLocalRepositoryArtifact(event.getSession(),
event.getArtifact())) {
+if (!isLocalRepositoryArtifactOrMissing(event.getSession(),
event.getArtifact())) {
return;
}
-CollectStepData collectStepTrace =
lookupCollectStepData(event.getTrace());
-if (collectStepTrace == null) {
-return;
+RequestTrace trace = event.getTrace();
+
+CollectStepData collectStepTrace = null;
+ArtifactRequest artifactRequest = null;
+ArtifactDescriptorRequest artifactDescriptorRequest = null;
+Plugin plugin = null;
+
+while (trace != null) {
+Object data = trace.getData();
+if (data instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) data;
+} else if (data instanceof ArtifactDescriptorRequest) {
+artifactDescriptorRequest = (ArtifactDescriptorRequest) data;
+} else if (data instanceof ArtifactRequest) {
+artifactRequest = (ArtifactRequest) data;
+} else if (data instanceof Plugin) {
+plugin = (Plugin) data;
+}
+trace = trace.getParent();
}
-Artifact resolvedArtifact = event.getArtifact();
-Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
-
-if (isInScope(resolvedArtifact, nodeArtifact)) {
-Dependency node = collectStepTrace.getNode();
-ArrayList trackingData = new ArrayList<>();
-trackingData.add(node + " (" + collectStepTrace.getContext() +
")");
-String indent = "";
-ListIterator iter = collectStepTrace
-.getPath()
-.listIterator(collectStepTrace.getPath().size());
-while (iter.hasPrevious()) {
-DependencyNode curr = iter.previous();
+Path trackingDir;
+boolean missing = event.getFile() == null;
+if (missing) {
+// missing artifact - let's track the path anyway
+File dir = event.getSession().getLocalRepository().getBasedir();
+dir = new File(
+dir,
event.getSession().getLocalRepositoryManager().getPathForLocalArtifact(event.getArtifact()));
+trackingDir = dir.getParentFile().toPath().resolve(".tracking");
+} else {
+trackingDir =
event.getFile().getParentFile().toPath().resolve(".tracking");
+}
+
+String baseName;
+String ext = missing ? ".miss" : ".dep";
+Path trackingFile = null;
+
+String indent = "";
+ArrayList trackingData = new ArrayList<>();
+
+if (collectStepTrace == null && plugin != null) {
+ext = ".plugin";
+baseName = plugin.getGroupId() + "_" + plugin.getArtifactId() +
"_" + plugin.getVersion();
+trackingFile = trackingDir.resolve(baseName + ext);
+if (Files.exists(trackingFile)) {
+return;
+}
+
+if (event.getArtifact() != null) {
+trackingData.add(indent + event.getArtifact());
+indent += " ";
+}
+trackingData.add(indent + plugin.getGroupId() + ":" +
plugin.getArtifactId() + ":" + plugin.getVersion());
+indent += " ";
+
+InputLocation location = plugin.getLocation("");
+if (location != null && location.getSource() != null) {
+trackingData.add(indent + location.getSource().getModelId() +
" (implicit)");
indent += " ";
-trackingData.add(indent + curr + " (" +
collectStepTrace.getContext() + ")");
}
-try {
-Path trackingDir =
-
resolvedArtifact.getFile().getParentFile().toPath().resolve(".tracking");
-Files.createDirectories(trackingDir);
-Path trackingFile = trackingDir.resolve(collectStepTrace
+} else if (collectStepTrace != null) {
+baseName =
+
collectStepTrace.getPath().get(0).getArtifact().toString().replace(":", "_");
Review Comment:
Correct, meant this one and wasn't able to register. Then the colon can be
exchanges for a tilde.
> Add more
[GitHub] [maven] michael-o commented on a diff in pull request #1058: [MNG-7741] Track missing files, plugin and parent pom dependencies
michael-o commented on code in PR #1058:
URL: https://github.com/apache/maven/pull/1058#discussion_r1143265427
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -49,45 +56,128 @@ class ReverseTreeRepositoryListener extends
AbstractRepositoryListener {
public void artifactResolved(RepositoryEvent event) {
requireNonNull(event, "event cannot be null");
-if (!isLocalRepositoryArtifact(event.getSession(),
event.getArtifact())) {
+if (!isLocalRepositoryArtifactOrMissing(event.getSession(),
event.getArtifact())) {
return;
}
-CollectStepData collectStepTrace =
lookupCollectStepData(event.getTrace());
-if (collectStepTrace == null) {
-return;
+RequestTrace trace = event.getTrace();
+
+CollectStepData collectStepTrace = null;
+ArtifactRequest artifactRequest = null;
+ArtifactDescriptorRequest artifactDescriptorRequest = null;
+Plugin plugin = null;
+
+while (trace != null) {
+Object data = trace.getData();
+if (data instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) data;
+} else if (data instanceof ArtifactDescriptorRequest) {
+artifactDescriptorRequest = (ArtifactDescriptorRequest) data;
+} else if (data instanceof ArtifactRequest) {
+artifactRequest = (ArtifactRequest) data;
+} else if (data instanceof Plugin) {
+plugin = (Plugin) data;
+}
+trace = trace.getParent();
}
-Artifact resolvedArtifact = event.getArtifact();
-Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
-
-if (isInScope(resolvedArtifact, nodeArtifact)) {
-Dependency node = collectStepTrace.getNode();
-ArrayList trackingData = new ArrayList<>();
-trackingData.add(node + " (" + collectStepTrace.getContext() +
")");
-String indent = "";
-ListIterator iter = collectStepTrace
-.getPath()
-.listIterator(collectStepTrace.getPath().size());
-while (iter.hasPrevious()) {
-DependencyNode curr = iter.previous();
+Path trackingDir;
+boolean missing = event.getFile() == null;
+if (missing) {
+// missing artifact - let's track the path anyway
+File dir = event.getSession().getLocalRepository().getBasedir();
+dir = new File(
+dir,
event.getSession().getLocalRepositoryManager().getPathForLocalArtifact(event.getArtifact()));
+trackingDir = dir.getParentFile().toPath().resolve(".tracking");
+} else {
+trackingDir =
event.getFile().getParentFile().toPath().resolve(".tracking");
+}
+
+String baseName;
+String ext = missing ? ".miss" : ".dep";
+Path trackingFile = null;
+
+String indent = "";
+ArrayList trackingData = new ArrayList<>();
+
+if (collectStepTrace == null && plugin != null) {
+ext = ".plugin";
+baseName = plugin.getGroupId() + "_" + plugin.getArtifactId() +
"_" + plugin.getVersion();
+trackingFile = trackingDir.resolve(baseName + ext);
+if (Files.exists(trackingFile)) {
+return;
+}
+
+if (event.getArtifact() != null) {
+trackingData.add(indent + event.getArtifact());
+indent += " ";
+}
+trackingData.add(indent + plugin.getGroupId() + ":" +
plugin.getArtifactId() + ":" + plugin.getVersion());
+indent += " ";
+
+InputLocation location = plugin.getLocation("");
+if (location != null && location.getSource() != null) {
+trackingData.add(indent + location.getSource().getModelId() +
" (implicit)");
indent += " ";
-trackingData.add(indent + curr + " (" +
collectStepTrace.getContext() + ")");
}
-try {
-Path trackingDir =
-
resolvedArtifact.getFile().getParentFile().toPath().resolve(".tracking");
-Files.createDirectories(trackingDir);
-Path trackingFile = trackingDir.resolve(collectStepTrace
+} else if (collectStepTrace != null) {
+baseName =
+
collectStepTrace.getPath().get(0).getArtifact().toString().replace(":", "_");
Review Comment:
Correct, meant this one and wasn't able to register. Then the colon can be
exchanges for a tilde.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this
[jira] [Commented] (MNG-7738) Remove printStackTrace
[
https://issues.apache.org/jira/browse/MNG-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703163#comment-17703163
]
ASF GitHub Bot commented on MNG-7738:
-
michael-o commented on code in PR #1064:
URL: https://github.com/apache/maven/pull/1064#discussion_r1143261715
##
maven-core/src/main/java/org/apache/maven/toolchain/RequirementMatcherFactory.java:
##
@@ -73,8 +73,6 @@ public boolean matches(String requirement) {
return range.getRecommendedVersion().compareTo(version) ==
0;
}
} catch (InvalidVersionSpecificationException ex) {
-// TODO error reporting
-ex.printStackTrace();
return false;
Review Comment:
If this information is required, it should be ad debug log level
##
maven-core/src/test/java/org/apache/maven/repository/TestRepositorySystem.java:
##
@@ -229,7 +229,7 @@ public ArtifactResolutionResult
resolve(ArtifactResolutionRequest request) {
.map(Dependency::new)
.collect(Collectors.toList());
} catch (IOException e) {
-e.printStackTrace();
Review Comment:
Same here
> Remove printStackTrace
> --
>
> Key: MNG-7738
> URL: https://issues.apache.org/jira/browse/MNG-7738
> Project: Maven
> Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Minor
>
> There are multiple places in core where the code simply calls
> ex.printStackTrace() or equivalent, usually in a catch block, instead of
> going through the logging framework. This produces ugly, uncontrollable,
> often duplicate output. Remove or replace these.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] michael-o commented on a diff in pull request #1064: [MNG-7738] don't dump raw stack traces to System.err
michael-o commented on code in PR #1064:
URL: https://github.com/apache/maven/pull/1064#discussion_r1143261715
##
maven-core/src/main/java/org/apache/maven/toolchain/RequirementMatcherFactory.java:
##
@@ -73,8 +73,6 @@ public boolean matches(String requirement) {
return range.getRecommendedVersion().compareTo(version) ==
0;
}
} catch (InvalidVersionSpecificationException ex) {
-// TODO error reporting
-ex.printStackTrace();
return false;
Review Comment:
If this information is required, it should be ad debug log level
##
maven-core/src/test/java/org/apache/maven/repository/TestRepositorySystem.java:
##
@@ -229,7 +229,7 @@ public ArtifactResolutionResult
resolve(ArtifactResolutionRequest request) {
.map(Dependency::new)
.collect(Collectors.toList());
} catch (IOException e) {
-e.printStackTrace();
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (MRESOURCES-288) make tests jar reproducible
[
https://issues.apache.org/jira/browse/MRESOURCES-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MRESOURCES-288.
--
Resolution: Fixed
> make tests jar reproducible
> ---
>
> Key: MRESOURCES-288
> URL: https://issues.apache.org/jira/browse/MRESOURCES-288
> Project: Maven Resources Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.3.1
>
>
> found when rebuilding release 3.3.0:
> {noformat}
> $ diffoscope target/reference/maven-resources-plugin-3.3.0-tests.jar
> target/maven-resources-plugin-3.3.0-tests.jar
> --- target/reference/maven-resources-plugin-3.3.0-tests.jar
> +++ target/maven-resources-plugin-3.3.0-tests.jar
> ├── zipinfo {}
> │ @@ -404,15 +404,15 @@
> │ -rw-r--r-- 2.0 unx 39 b- defN 22-Jul-23 17:48
> unit/test-dir/resourceSystemProperties_Filtering/src/test/resources/file4.txt
> │ --rw-r--r-- 2.0 unx 95 b- defN 22-Jul-23 17:48
> unit/test-dir/resourceSystemProperties_Filtering/target/classes/file4.txt
> │ +-rw-r--r-- 2.0 unx 80 b- defN 22-Jul-23 17:48
> unit/test-dir/resourceSystemProperties_Filtering/target/classes/file4.txt
> │ -rw-r--r-- 2.0 unx 0 b- defN 22-Jul-23 17:48
> unit/test-dir/resourceTargetPath/src/main/resources/file4.txt
> ├── unit/test-dir/resourceSystemProperties_Filtering/target/classes/file4.txt
> │ @@ -1 +1 @@
> │ -current-working-directory =
> D:\\Entwicklung\\Projekte\\maven-resources-plugin\\target\\checkout
> │ +current-working-directory =
> /Users/hboutemy/dev/tmp/maven-resources-plugin-3.3.0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resources-plugin] cstamas merged pull request #56: [MRESOURCES-288] Make tests-jar reproducible
cstamas merged PR #56: URL: https://github.com/apache/maven-resources-plugin/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7741) Add more information when using -Dmaven.repo.local.recordReverseTree=true
[
https://issues.apache.org/jira/browse/MNG-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703161#comment-17703161
]
ASF GitHub Bot commented on MNG-7741:
-
cstamas commented on code in PR #1058:
URL: https://github.com/apache/maven/pull/1058#discussion_r1143248770
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -49,45 +56,128 @@ class ReverseTreeRepositoryListener extends
AbstractRepositoryListener {
public void artifactResolved(RepositoryEvent event) {
requireNonNull(event, "event cannot be null");
-if (!isLocalRepositoryArtifact(event.getSession(),
event.getArtifact())) {
+if (!isLocalRepositoryArtifactOrMissing(event.getSession(),
event.getArtifact())) {
return;
}
-CollectStepData collectStepTrace =
lookupCollectStepData(event.getTrace());
-if (collectStepTrace == null) {
-return;
+RequestTrace trace = event.getTrace();
+
+CollectStepData collectStepTrace = null;
+ArtifactRequest artifactRequest = null;
+ArtifactDescriptorRequest artifactDescriptorRequest = null;
+Plugin plugin = null;
+
+while (trace != null) {
+Object data = trace.getData();
+if (data instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) data;
+} else if (data instanceof ArtifactDescriptorRequest) {
+artifactDescriptorRequest = (ArtifactDescriptorRequest) data;
+} else if (data instanceof ArtifactRequest) {
+artifactRequest = (ArtifactRequest) data;
+} else if (data instanceof Plugin) {
+plugin = (Plugin) data;
+}
+trace = trace.getParent();
}
-Artifact resolvedArtifact = event.getArtifact();
-Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
-
-if (isInScope(resolvedArtifact, nodeArtifact)) {
-Dependency node = collectStepTrace.getNode();
-ArrayList trackingData = new ArrayList<>();
-trackingData.add(node + " (" + collectStepTrace.getContext() +
")");
-String indent = "";
-ListIterator iter = collectStepTrace
-.getPath()
-.listIterator(collectStepTrace.getPath().size());
-while (iter.hasPrevious()) {
-DependencyNode curr = iter.previous();
+Path trackingDir;
+boolean missing = event.getFile() == null;
+if (missing) {
+// missing artifact - let's track the path anyway
+File dir = event.getSession().getLocalRepository().getBasedir();
+dir = new File(
+dir,
event.getSession().getLocalRepositoryManager().getPathForLocalArtifact(event.getArtifact()));
+trackingDir = dir.getParentFile().toPath().resolve(".tracking");
+} else {
+trackingDir =
event.getFile().getParentFile().toPath().resolve(".tracking");
+}
+
+String baseName;
+String ext = missing ? ".miss" : ".dep";
+Path trackingFile = null;
+
+String indent = "";
+ArrayList trackingData = new ArrayList<>();
+
+if (collectStepTrace == null && plugin != null) {
+ext = ".plugin";
+baseName = plugin.getGroupId() + "_" + plugin.getArtifactId() +
"_" + plugin.getVersion();
+trackingFile = trackingDir.resolve(baseName + ext);
+if (Files.exists(trackingFile)) {
+return;
+}
+
+if (event.getArtifact() != null) {
+trackingData.add(indent + event.getArtifact());
+indent += " ";
+}
+trackingData.add(indent + plugin.getGroupId() + ":" +
plugin.getArtifactId() + ":" + plugin.getVersion());
+indent += " ";
+
+InputLocation location = plugin.getLocation("");
+if (location != null && location.getSource() != null) {
+trackingData.add(indent + location.getSource().getModelId() +
" (implicit)");
indent += " ";
-trackingData.add(indent + curr + " (" +
collectStepTrace.getContext() + ")");
}
-try {
-Path trackingDir =
-
resolvedArtifact.getFile().getParentFile().toPath().resolve(".tracking");
-Files.createDirectories(trackingDir);
-Path trackingFile = trackingDir.resolve(collectStepTrace
+} else if (collectStepTrace != null) {
+baseName =
+
collectStepTrace.getPath().get(0).getArtifact().toString().replace(":", "_");
Review Comment:
[GitHub] [maven] cstamas commented on a diff in pull request #1058: [MNG-7741] Track missing files, plugin and parent pom dependencies
cstamas commented on code in PR #1058:
URL: https://github.com/apache/maven/pull/1058#discussion_r1143248770
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -49,45 +56,128 @@ class ReverseTreeRepositoryListener extends
AbstractRepositoryListener {
public void artifactResolved(RepositoryEvent event) {
requireNonNull(event, "event cannot be null");
-if (!isLocalRepositoryArtifact(event.getSession(),
event.getArtifact())) {
+if (!isLocalRepositoryArtifactOrMissing(event.getSession(),
event.getArtifact())) {
return;
}
-CollectStepData collectStepTrace =
lookupCollectStepData(event.getTrace());
-if (collectStepTrace == null) {
-return;
+RequestTrace trace = event.getTrace();
+
+CollectStepData collectStepTrace = null;
+ArtifactRequest artifactRequest = null;
+ArtifactDescriptorRequest artifactDescriptorRequest = null;
+Plugin plugin = null;
+
+while (trace != null) {
+Object data = trace.getData();
+if (data instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) data;
+} else if (data instanceof ArtifactDescriptorRequest) {
+artifactDescriptorRequest = (ArtifactDescriptorRequest) data;
+} else if (data instanceof ArtifactRequest) {
+artifactRequest = (ArtifactRequest) data;
+} else if (data instanceof Plugin) {
+plugin = (Plugin) data;
+}
+trace = trace.getParent();
}
-Artifact resolvedArtifact = event.getArtifact();
-Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
-
-if (isInScope(resolvedArtifact, nodeArtifact)) {
-Dependency node = collectStepTrace.getNode();
-ArrayList trackingData = new ArrayList<>();
-trackingData.add(node + " (" + collectStepTrace.getContext() +
")");
-String indent = "";
-ListIterator iter = collectStepTrace
-.getPath()
-.listIterator(collectStepTrace.getPath().size());
-while (iter.hasPrevious()) {
-DependencyNode curr = iter.previous();
+Path trackingDir;
+boolean missing = event.getFile() == null;
+if (missing) {
+// missing artifact - let's track the path anyway
+File dir = event.getSession().getLocalRepository().getBasedir();
+dir = new File(
+dir,
event.getSession().getLocalRepositoryManager().getPathForLocalArtifact(event.getArtifact()));
+trackingDir = dir.getParentFile().toPath().resolve(".tracking");
+} else {
+trackingDir =
event.getFile().getParentFile().toPath().resolve(".tracking");
+}
+
+String baseName;
+String ext = missing ? ".miss" : ".dep";
+Path trackingFile = null;
+
+String indent = "";
+ArrayList trackingData = new ArrayList<>();
+
+if (collectStepTrace == null && plugin != null) {
+ext = ".plugin";
+baseName = plugin.getGroupId() + "_" + plugin.getArtifactId() +
"_" + plugin.getVersion();
+trackingFile = trackingDir.resolve(baseName + ext);
+if (Files.exists(trackingFile)) {
+return;
+}
+
+if (event.getArtifact() != null) {
+trackingData.add(indent + event.getArtifact());
+indent += " ";
+}
+trackingData.add(indent + plugin.getGroupId() + ":" +
plugin.getArtifactId() + ":" + plugin.getVersion());
+indent += " ";
+
+InputLocation location = plugin.getLocation("");
+if (location != null && location.getSource() != null) {
+trackingData.add(indent + location.getSource().getModelId() +
" (implicit)");
indent += " ";
-trackingData.add(indent + curr + " (" +
collectStepTrace.getContext() + ")");
}
-try {
-Path trackingDir =
-
resolvedArtifact.getFile().getParentFile().toPath().resolve(".tracking");
-Files.createDirectories(trackingDir);
-Path trackingFile = trackingDir.resolve(collectStepTrace
+} else if (collectStepTrace != null) {
+baseName =
+
collectStepTrace.getPath().get(0).getArtifact().toString().replace(":", "_");
Review Comment:
https://github.com/apache/maven-resolver/blob/master/maven-resolver-util/src/main/java/org/eclipse/aether/util/artifact/ArtifactIdUtils.java#L28
maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[jira] [Commented] (MRESOURCES-288) make tests jar reproducible
[
https://issues.apache.org/jira/browse/MRESOURCES-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703155#comment-17703155
]
Tamas Cservenak commented on MRESOURCES-288:
PR moves out of tests-jar the UT outputs, hence tests-jar contains only the
component for IT and resources from under src/test/resources, no more target in
there. IMHO this should make it work.
> make tests jar reproducible
> ---
>
> Key: MRESOURCES-288
> URL: https://issues.apache.org/jira/browse/MRESOURCES-288
> Project: Maven Resources Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.3.1
>
>
> found when rebuilding release 3.3.0:
> {noformat}
> $ diffoscope target/reference/maven-resources-plugin-3.3.0-tests.jar
> target/maven-resources-plugin-3.3.0-tests.jar
> --- target/reference/maven-resources-plugin-3.3.0-tests.jar
> +++ target/maven-resources-plugin-3.3.0-tests.jar
> ├── zipinfo {}
> │ @@ -404,15 +404,15 @@
> │ -rw-r--r-- 2.0 unx 39 b- defN 22-Jul-23 17:48
> unit/test-dir/resourceSystemProperties_Filtering/src/test/resources/file4.txt
> │ --rw-r--r-- 2.0 unx 95 b- defN 22-Jul-23 17:48
> unit/test-dir/resourceSystemProperties_Filtering/target/classes/file4.txt
> │ +-rw-r--r-- 2.0 unx 80 b- defN 22-Jul-23 17:48
> unit/test-dir/resourceSystemProperties_Filtering/target/classes/file4.txt
> │ -rw-r--r-- 2.0 unx 0 b- defN 22-Jul-23 17:48
> unit/test-dir/resourceTargetPath/src/main/resources/file4.txt
> ├── unit/test-dir/resourceSystemProperties_Filtering/target/classes/file4.txt
> │ @@ -1 +1 @@
> │ -current-working-directory =
> D:\\Entwicklung\\Projekte\\maven-resources-plugin\\target\\checkout
> │ +current-working-directory =
> /Users/hboutemy/dev/tmp/maven-resources-plugin-3.3.0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] elharo closed pull request #268: remove unused deps
elharo closed pull request #268: remove unused deps URL: https://github.com/apache/maven-resolver/pull/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] cstamas opened a new pull request, #56: [MRESOURCES-288] Make tests-jar reproducible
cstamas opened a new pull request, #56: URL: https://github.com/apache/maven-resources-plugin/pull/56 By moving out UT outputs into separate place, to not have them packed up into it. Also removing superfluous dependency in user filters IT, as plugin already uses commons-io that is even newer. --- https://issues.apache.org/jira/browse/MRESOURCES-288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1119) release plugin ignore developmentVersion
[
https://issues.apache.org/jira/browse/MRELEASE-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703153#comment-17703153
]
Robert Patrick commented on MRELEASE-1119:
--
No
On Tue, Mar 21, 2023 at 2:29 AM Michael Osipov (Jira)
> release plugin ignore developmentVersion
>
>
> Key: MRELEASE-1119
> URL: https://issues.apache.org/jira/browse/MRELEASE-1119
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Robert Patrick
>Priority: Major
>
> I just ran a release process using the 3.0.0 version of the
> maven-release-plugin with a release.properties file like this:
> {{tag=release-3.0.4}}
> {{releaseVersion=3.0.4}}
> {{developmentVersion=3.1.0-SNAPSHOT}}
> After running {{mvn -B release:prepare release:perform}}, the pom.xml version
> is 3.0.5-SNAPSHOT.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-48) Add ability to disable caching on a per-module level
[ https://issues.apache.org/jira/browse/MBUILDCACHE-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Eltsov updated MBUILDCACHE-48: Description: Add ability to do the caching on a per-module level. This may be required in a case when a module is a final leaf of a reactor tree, and its artefacts are not required by other modules as cached dependencies. Hence eliminating some modules from caching will speed up build and also lower the footprint size of a cached build. E.g. in my project (where we have huge deployment artifacts in some of modules) we reduced the cache footprint from 1.5G to 100M by introducing such a capability was:Add ability to disable generated source restoration on a per-module level. This is required to overcome issues with some weird Maven plugins which go nuts when cached generated sources are present and produce incorrect build result > Add ability to disable caching on a per-module level > > > Key: MBUILDCACHE-48 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-48 > Project: Maven Build Cache Extension > Issue Type: New Feature > Components: remote build cache >Affects Versions: 1.0.0 >Reporter: Alexander Eltsov >Priority: Major > > Add ability to do the caching on a per-module level. > This may be required in a case when a module is a final leaf of a reactor > tree, and its artefacts are not required by other modules as cached > dependencies. Hence eliminating some modules from caching will speed up build > and also lower the footprint size of a cached build. > > E.g. in my project (where we have huge deployment artifacts in some of > modules) we reduced the cache footprint from 1.5G to 100M by introducing such > a capability -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MBUILDCACHE-48) Add ability to disable caching on a per-module level
Alexander Eltsov created MBUILDCACHE-48: --- Summary: Add ability to disable caching on a per-module level Key: MBUILDCACHE-48 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-48 Project: Maven Build Cache Extension Issue Type: New Feature Components: remote build cache Affects Versions: 1.0.0 Reporter: Alexander Eltsov Add ability to disable generated source restoration on a per-module level. This is required to overcome issues with some weird Maven plugins which go nuts when cached generated sources are present and produce incorrect build result -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-44) Running duplicate maven phase leads to IllegalStateException and cache miss
[
https://issues.apache.org/jira/browse/MBUILDCACHE-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703139#comment-17703139
]
Alexander Eltsov commented on MBUILDCACHE-44:
-
Confirming - same behavior is observed for me
To simplify fix I would propose to just change the getExecutionMap() method of
Build class so that it will effectively do a dedup keeping the key unchanged.
Just adding Collectors.toMap(,, (old,new)-> old) did the trick for me
> Running duplicate maven phase leads to IllegalStateException and cache miss
> ---
>
> Key: MBUILDCACHE-44
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-44
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Miguel Ortega
>Priority: Minor
> Attachments: maven-cache.zip
>
>
> When running maven with a duplicate maven goal like below (i'm aware that
> compile phase here is not necessary)
> {code:java}
> mvn compile test
> {code}
> the plugin seems to create a cache key that cause an error if i call.
> {code:java}
> mvn test
> {code}
> This will cause the following error:
> {code:java}
> [ERROR] Failed to restore project
> java.lang.IllegalStateException: Duplicate key
> default-resources:resources:process-resources:maven-resources-plugin:org.apache.maven.plugins
> (attempted merging values
> org.apache.maven.buildcache.xml.build.CompletedExecution@1e1b061 and
> org.apache.maven.buildcache.xml.build.CompletedExecution@38f77cd9)
> at java.util.stream.Collectors.duplicateKeyException (Collectors.java:135)
> at java.util.stream.Collectors.lambda$uniqKeysMapAccumulator$1
> (Collectors.java:182)
> at java.util.stream.ReduceOps$3ReducingSink.accept (ReduceOps.java:169)
> at java.util.ArrayList$ArrayListSpliterator.forEachRemaining
> (ArrayList.java:1625)
> at java.util.stream.AbstractPipeline.copyInto (AbstractPipeline.java:509)
> at java.util.stream.AbstractPipeline.wrapAndCopyInto
> (AbstractPipeline.java:499)
> at java.util.stream.ReduceOps$ReduceOp.evaluateSequential
> (ReduceOps.java:921)
> at java.util.stream.AbstractPipeline.evaluate (AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect (ReferencePipeline.java:682)
> at org.apache.maven.buildcache.xml.Build.getExecutionMap (Build.java:198)
> at org.apache.maven.buildcache.xml.Build.hasCompletedExecution
> (Build.java:116)
> at org.apache.maven.buildcache.xml.Build.lambda$getMissingExecutions$0
> (Build.java:110)
> at java.util.stream.ReferencePipeline$2$1.accept
> (ReferencePipeline.java:178)
> at java.util.ArrayList$ArrayListSpliterator.forEachRemaining
> (ArrayList.java:1625)
> at java.util.stream.AbstractPipeline.copyInto (AbstractPipeline.java:509)
> at java.util.stream.AbstractPipeline.wrapAndCopyInto
> (AbstractPipeline.java:499)
> at java.util.stream.ReduceOps$ReduceOp.evaluateSequential
> (ReduceOps.java:921)
> at java.util.stream.AbstractPipeline.evaluate (AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect (ReferencePipeline.java:682)
> at org.apache.maven.buildcache.xml.Build.getMissingExecutions
> (Build.java:111)
> at org.apache.maven.buildcache.CacheControllerImpl.analyzeResult
> (CacheControllerImpl.java:267)
> at org.apache.maven.buildcache.CacheControllerImpl.findLocalBuild
> (CacheControllerImpl.java:234)
> at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
> (CacheControllerImpl.java:185)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:114)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
>
[jira] [Closed] (MRESOURCES-297) Update to parent POM 39, reformat sources
[ https://issues.apache.org/jira/browse/MRESOURCES-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOURCES-297. -- Resolution: Fixed > Update to parent POM 39, reformat sources > - > > Key: MRESOURCES-297 > URL: https://issues.apache.org/jira/browse/MRESOURCES-297 > Project: Maven Resources Plugin > Issue Type: Task >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.3.1 > > > Apply latest parent, reformat sources, ignore reformat in blame. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MRESOURCES-293) Resources should not be read-only
[
https://issues.apache.org/jira/browse/MRESOURCES-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703138#comment-17703138
]
Tamas Cservenak edited comment on MRESOURCES-293 at 3/21/23 10:34 AM:
--
Agreement this is doco issue, no code change needed. The already merged PR
rolled back in 1946127aac4acb752fd3018dff8c7751434d6ca7.
was (Author: cstamas):
Agreement this is doco issue, no code change needed. The already merged PR
rolled back.
> Resources should not be read-only
> -
>
> Key: MRESOURCES-293
> URL: https://issues.apache.org/jira/browse/MRESOURCES-293
> Project: Maven Resources Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Delany
>Assignee: Tamas Cservenak
>Priority: Major
>
> With Maven 3.9.0 I'm getting lots of these warnings
> {noformat}
> [WARNING] Parameter 'resources' is read-only, must not be used in
> configuration{noformat}
> Clearly it shouldn't be marked read-only
> https://maven.apache.org/plugins/maven-resources-plugin/examples/resource-directory.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MRESOURCES-293) Resources should not be read-only
[
https://issues.apache.org/jira/browse/MRESOURCES-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MRESOURCES-293.
--
Resolution: Won't Fix
Agreement this is doco issue, no code change needed. The already merged PR
rolled back.
> Resources should not be read-only
> -
>
> Key: MRESOURCES-293
> URL: https://issues.apache.org/jira/browse/MRESOURCES-293
> Project: Maven Resources Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Delany
>Assignee: Tamas Cservenak
>Priority: Major
>
> With Maven 3.9.0 I'm getting lots of these warnings
> {noformat}
> [WARNING] Parameter 'resources' is read-only, must not be used in
> configuration{noformat}
> Clearly it shouldn't be marked read-only
> https://maven.apache.org/plugins/maven-resources-plugin/examples/resource-directory.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRESOURCES-293) Resources should not be read-only
[
https://issues.apache.org/jira/browse/MRESOURCES-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MRESOURCES-293:
---
Fix Version/s: (was: 3.3.1)
> Resources should not be read-only
> -
>
> Key: MRESOURCES-293
> URL: https://issues.apache.org/jira/browse/MRESOURCES-293
> Project: Maven Resources Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Delany
>Assignee: Tamas Cservenak
>Priority: Major
>
> With Maven 3.9.0 I'm getting lots of these warnings
> {noformat}
> [WARNING] Parameter 'resources' is read-only, must not be used in
> configuration{noformat}
> Clearly it shouldn't be marked read-only
> https://maven.apache.org/plugins/maven-resources-plugin/examples/resource-directory.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (MRESOURCES-293) Resources should not be read-only
[
https://issues.apache.org/jira/browse/MRESOURCES-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reopened MRESOURCES-293:
> Resources should not be read-only
> -
>
> Key: MRESOURCES-293
> URL: https://issues.apache.org/jira/browse/MRESOURCES-293
> Project: Maven Resources Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Delany
>Assignee: Tamas Cservenak
>Priority: Major
>
> With Maven 3.9.0 I'm getting lots of these warnings
> {noformat}
> [WARNING] Parameter 'resources' is read-only, must not be used in
> configuration{noformat}
> Clearly it shouldn't be marked read-only
> https://maven.apache.org/plugins/maven-resources-plugin/examples/resource-directory.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-7717) Maven warns wrongly about ${localRepository} expression
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703134#comment-17703134
]
Tamas Cservenak edited comment on MNG-7717 at 3/21/23 10:28 AM:
This is fixed but not in a way you think: there was a problem how deprecated
expression was identified.
OTOH, this warning is not about your POM, but about Mojos/Plugins used in your
POM: and in this case surefire 2.22.2 (Maven2 compatibie!) does suffer from
this issue, it does use deprecated expression. Upgrade to 3.0.0 surefire and
warning is gone.
was (Author: cstamas):
This is fixed but not in a way you think: there was a problem how deprecated
expression was identified.
OTOH, this warning is not about your POM, but about Mojos/Plugins used in your
POM: and in this case surefire 2.22.2 (Maven2 compatibie!) does suffer from
this issue, it does use deprecated expression.
> Maven warns wrongly about ${localRepository} expression
> ---
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
> In short: it checks for parameter {*}name{*}, where instead it should check
> for *type* and *defaultValue* expression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-747) jar goal fails with automatic module (Regression from 3.2.0)
[
https://issues.apache.org/jira/browse/MJAVADOC-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703135#comment-17703135
]
Geoffrey De Smet commented on MJAVADOC-747:
---
Workaround 1: don't use "Automatic Module Name".
Workaround 2: bind the javadoc plugin to the "process-classes" phase instead of
the "package" phase.
> jar goal fails with automatic module (Regression from 3.2.0)
> -
>
> Key: MJAVADOC-747
> URL: https://issues.apache.org/jira/browse/MJAVADOC-747
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.3.0, 3.3.1, 3.3.2, 3.4.0, 3.4.1, 3.5.0
>Reporter: Geoffrey De Smet
>Priority: Blocker
>
> In optaplanner, we provide automatic module names for all our modules.
> But some modules have a dependency with classes in the no-name package.
> That was not a problem for the maven-javadoc-plugin, except since
> maven-javadoc-plugin 3.3.0 (including 3.5.0) it crashes the entire build.
> This happens with dependencies on quarkus and on rewrite.
> For example, for optaplanner-migrator that depends on rewrite-maven and
> rewrite-gradle:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.5.0:jar (default) on project
> reproducer:
> Execution default of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.5.0:jar failed:
> Unable to derive module descriptor for
> /.../.m2/repository/org/openrewrite/rewrite-gradle/7.38.0/rewrite-gradle-7.38.0.jar:
> PluginSpec.class found in top-level directory (unnamed package not allowed in
> module) -> [Help 1]{code}
> Isolated reproducer:
> [https://github.com/ge0ffrey/maven-javadoc-plugin-3.5.0-reproducer]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7717) Maven warns wrongly about ${localRepository} expression
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703134#comment-17703134
]
Tamas Cservenak commented on MNG-7717:
--
This is fixed but not in a way you think: there was a problem how deprecated
expression was identified.
OTOH, this warning is not about your POM, but about Mojos/Plugins used in your
POM: and in this case surefire 2.22.2 (Maven2 compatibie!) does suffer from
this issue, it does use deprecated expression.
> Maven warns wrongly about ${localRepository} expression
> ---
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
> In short: it checks for parameter {*}name{*}, where instead it should check
> for *type* and *defaultValue* expression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resources-plugin] dependabot[bot] commented on pull request #43: Bump maven-plugins from 36 to 39
dependabot[bot] commented on PR #43: URL: https://github.com/apache/maven-resources-plugin/pull/43#issuecomment-1477590583 Looks like org.apache.maven.plugins:maven-plugins is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] dependabot[bot] closed pull request #43: Bump maven-plugins from 36 to 39
dependabot[bot] closed pull request #43: Bump maven-plugins from 36 to 39 URL: https://github.com/apache/maven-resources-plugin/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-747) jar goal fails with automatic module (Regression from 3.2.0)
[
https://issues.apache.org/jira/browse/MJAVADOC-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703133#comment-17703133
]
Geoffrey De Smet commented on MJAVADOC-747:
---
The stacktrace seems to indicate this is a user's problem - after all, there is
an "Automatic Module Name" defined on the project and one of its dependencies
is not module friendly (it uses the no-name package), so the javadoc plugin
rightly fails. Right?
However, I'd argue it's not a user's problem:
- Using "Automatic Module Name" is a way for open source projects that don't
want to go through the JPMS hassle today, to prepare themselves if they do want
to go through it some day - with minimal impact to their JPMS users.
- This issue effectively blocks the use of "Automatic Module Name" if quarkus,
openrewrite or other dependencies that don't care about JPMS are in the
dependencies.
- The compiler plugin etc all don't fail on this, only the new javadoc plugin
version (3.3.0+) does (=> regression).
> jar goal fails with automatic module (Regression from 3.2.0)
> -
>
> Key: MJAVADOC-747
> URL: https://issues.apache.org/jira/browse/MJAVADOC-747
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.3.0, 3.3.1, 3.3.2, 3.4.0, 3.4.1, 3.5.0
>Reporter: Geoffrey De Smet
>Priority: Blocker
>
> In optaplanner, we provide automatic module names for all our modules.
> But some modules have a dependency with classes in the no-name package.
> That was not a problem for the maven-javadoc-plugin, except since
> maven-javadoc-plugin 3.3.0 (including 3.5.0) it crashes the entire build.
> This happens with dependencies on quarkus and on rewrite.
> For example, for optaplanner-migrator that depends on rewrite-maven and
> rewrite-gradle:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.5.0:jar (default) on project
> reproducer:
> Execution default of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.5.0:jar failed:
> Unable to derive module descriptor for
> /.../.m2/repository/org/openrewrite/rewrite-gradle/7.38.0/rewrite-gradle-7.38.0.jar:
> PluginSpec.class found in top-level directory (unnamed package not allowed in
> module) -> [Help 1]{code}
> Isolated reproducer:
> [https://github.com/ge0ffrey/maven-javadoc-plugin-3.5.0-reproducer]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resources-plugin] cstamas merged pull request #55: [MRESOURCES-297] Update to parent POM 39, reformat
cstamas merged PR #55: URL: https://github.com/apache/maven-resources-plugin/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7717) Maven warns wrongly about ${localRepository} expression
[
https://issues.apache.org/jira/browse/MNG-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703131#comment-17703131
]
James Howe commented on MNG-7717:
-
This seems to have been introduced in 3.9.1, not fixed?
{quote}
[INFO] — surefire:2.22.2:test (default-test) @ my-project —
[WARNING] Parameter 'localRepository' is deprecated core expression; Avoid use
of ArtifactRepository type. If you need access to local repository, switch to
'${repositorySystemSession}' expression and get LRM from it instead.
{quote}
The parameter is not mentioned anywhere in my POM.
> Maven warns wrongly about ${localRepository} expression
> ---
>
> Key: MNG-7717
> URL: https://issues.apache.org/jira/browse/MNG-7717
> Project: Maven
> Issue Type: Bug
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.9.1
>
>
> With MNG-7706 the {{localRepository}} Mojo parameter was deprecated as it is
> represented by {{ArtifactRepository}} legacy type. But the code is too eager,
> it warns about {{settings.localRepository}} expression as well, while it does
> NOT use this legacy type.
> In short: it checks for parameter {*}name{*}, where instead it should check
> for *type* and *defaultValue* expression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resources-plugin] cstamas merged pull request #40: remove specific IDE m2e files
cstamas merged PR #40: URL: https://github.com/apache/maven-resources-plugin/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MRESOURCES-294) Upgrade plexus-utils to 3.5.1
[ https://issues.apache.org/jira/browse/MRESOURCES-294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOURCES-294: -- Assignee: Sylwester Lachiewicz (was: Tamas Cservenak) > Upgrade plexus-utils to 3.5.1 > - > > Key: MRESOURCES-294 > URL: https://issues.apache.org/jira/browse/MRESOURCES-294 > Project: Maven Resources Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.3.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOURCES-294) Upgrade plexus-utils to 3.5.1
[ https://issues.apache.org/jira/browse/MRESOURCES-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703130#comment-17703130 ] Tamas Cservenak commented on MRESOURCES-294: Note: this change incorporated plexus-utils change [https://github.com/codehaus-plexus/plexus-utils/commit/e8a8433894eae9e8f82cbba4b903508362e9322a] where "default excludes" were changed, notable gitattributes and gitignore were removed. > Upgrade plexus-utils to 3.5.1 > - > > Key: MRESOURCES-294 > URL: https://issues.apache.org/jira/browse/MRESOURCES-294 > Project: Maven Resources Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.3.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MRESOURCES-294) Upgrade plexus-utils to 3.5.1
[ https://issues.apache.org/jira/browse/MRESOURCES-294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOURCES-294: -- Assignee: Tamas Cservenak > Upgrade plexus-utils to 3.5.1 > - > > Key: MRESOURCES-294 > URL: https://issues.apache.org/jira/browse/MRESOURCES-294 > Project: Maven Resources Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Trivial > Fix For: 3.3.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-ear-plugin] dependabot[bot] closed pull request #87: Bump plexus-archiver from 4.5.0 to 4.6.2
dependabot[bot] closed pull request #87: Bump plexus-archiver from 4.5.0 to 4.6.2 URL: https://github.com/apache/maven-ear-plugin/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] dependabot[bot] commented on pull request #87: Bump plexus-archiver from 4.5.0 to 4.6.2
dependabot[bot] commented on PR #87: URL: https://github.com/apache/maven-ear-plugin/pull/87#issuecomment-1477552925 Superseded by #89. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] dependabot[bot] opened a new pull request, #89: Bump plexus-archiver from 4.5.0 to 4.6.3
dependabot[bot] opened a new pull request, #89: URL: https://github.com/apache/maven-ear-plugin/pull/89 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.5.0 to 4.6.3. Release notes Sourced from https://github.com/codehaus-plexus/plexus-archiver/releases;>plexus-archiver's releases. Plexus Archiver 4.6.3 New features and improvements Fix path traversal vulnerability (https://redirect.github.com/codehaus-plexus/plexus-archiver/pull/261;>#261) https://github.com/plamentotev;>@plamentotev Thanks to https://github.com/Fewword;>@Fewword for reporting the vulnerability and suggesting a fix. The vulnerability affects only directories whose name begins with the same prefix as the destination directory. For example malicious archive may extract file in /opt/directory instead of /opt/dir. Dependency updates Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/codehaus-plexus/plexus-archiver/pull/257;>#257) https://github.com/dependabot;>@dependabot Plexus Archiver 4.6.2 Bug Fixes Fix regression in handling symbolic links. See https://redirect.github.com/codehaus-plexus/plexus-io/issues/89;>codehaus-plexus/plexus-io#89 Dependency updates Bump plexus-io from 3.4.0 to 3.4.1 (https://redirect.github.com/codehaus-plexus/plexus-archiver/pull/256;>#256) https://github.com/dependabot;>@dependabot Bump zstd-jni from 1.5.2-5 to 1.5.4-2 (https://redirect.github.com/codehaus-plexus/plexus-archiver/pull/254;>#254) https://github.com/dependabot;>@dependabot, (https://redirect.github.com/codehaus-plexus/plexus-archiver/pull/255;>#255) https://github.com/dependabot;>@dependabot Plexus Archiver 4.6.1 Bug Fixes Normalize file separators before warning about equal archive entries (https://redirect.github.com/codehaus-plexus/plexus-archiver/pull/249;>#249) https://github.com/Bananeweizen;>@Bananeweizen Dependency updates Bump commons-compress from 1.21 to 1.22 (https://redirect.github.com/codehaus-plexus/plexus-archiver/pull/243;>#243) https://github.com/dependabot;>@dependabot Plexus Archiver 4.6.0 New features and improvements keep file/directory permissions in Reproducible Builds mode (https://redirect.github.com/codehaus-plexus/plexus-archiver/pull/241;>#241) https://github.com/hboutemy;>@hboutemy Dependency updates Bump junitVersion from 5.9.0 to 5.9.1 (https://redirect.github.com/codehaus-plexus/plexus-archiver/pull/236;>#236) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.4.2 to 3.5.0 (https://redirect.github.com/codehaus-plexus/plexus-archiver/pull/242;>#242) https://github.com/dependabot;>@dependabot Bump zstd-jni from 1.5.2-4 to 1.5.2-5 (https://redirect.github.com/codehaus-plexus/plexus-archiver/pull/240;>#240) https://github.com/dependabot;>@dependabot Commits https://github.com/codehaus-plexus/plexus-archiver/commit/5cc65942802cf50e023e6f0a1dbc8eb54a38064f;>5cc6594 [maven-release-plugin] prepare release plexus-archiver-4.6.3 https://github.com/codehaus-plexus/plexus-archiver/commit/8a37b7e478d2973b43746db2d6e97b7e26e693d0;>8a37b7e Fix path traversal vulnerability https://github.com/codehaus-plexus/plexus-archiver/commit/68d6825b8709c38e8eaf51873539ab4788a8849d;>68d6825 Bump plexus-utils from 3.5.0 to 3.5.1 https://github.com/codehaus-plexus/plexus-archiver/commit/00d02f8cb15b11d9ff4d36b88fb8e849a797f558;>00d02f8 [maven-release-plugin] prepare for next development iteration https://github.com/codehaus-plexus/plexus-archiver/commit/e4449b2cbfd1aa87223cea8fa7c1a987477587af;>e4449b2 [maven-release-plugin] prepare release plexus-archiver-4.6.2 https://github.com/codehaus-plexus/plexus-archiver/commit/737ac96e761e17c16020adc479b11e78cf3e0e75;>737ac96 [maven-release-plugin] rollback the release of plexus-archiver-4.6.2 https://github.com/codehaus-plexus/plexus-archiver/commit/d950f06756c461975d6f1d014cc1fa8bcf477677;>d950f06 [maven-release-plugin] prepare release plexus-archiver-4.6.2 https://github.com/codehaus-plexus/plexus-archiver/commit/8c65753ba31d8f1a6d0a6e4cd8e01a40e00e;>8c65753 Bump plexus-io from 3.4.0 to 3.4.1 https://github.com/codehaus-plexus/plexus-archiver/commit/b434156c56be930c04ecfa2588917defe458e902;>b434156 Bump zstd-jni from 1.5.4-1 to 1.5.4-2 https://github.com/codehaus-plexus/plexus-archiver/commit/64d3acf94d370e5174c73567a1508d97be665a23;>64d3acf Bump zstd-jni from 1.5.2-5 to 1.5.4-1 Additional commits viewable in https://github.com/codehaus-plexus/plexus-archiver/compare/plexus-archiver-4.5.0...plexus-archiver-4.6.3;>compare view [![Dependabot compatibility
[jira] [Commented] (MRESOURCES-293) Resources should not be read-only
[
https://issues.apache.org/jira/browse/MRESOURCES-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703124#comment-17703124
]
Delany commented on MRESOURCES-293:
---
[~cstamas] maybe just leave it as is? Ad hoc resource copying is covered with
[https://maven.apache.org/plugins/maven-resources-plugin/copy-resources-mojo.html]
We all seem to agree its the documentation that causes the confusion.
> Resources should not be read-only
> -
>
> Key: MRESOURCES-293
> URL: https://issues.apache.org/jira/browse/MRESOURCES-293
> Project: Maven Resources Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Delany
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.3.1
>
>
> With Maven 3.9.0 I'm getting lots of these warnings
> {noformat}
> [WARNING] Parameter 'resources' is read-only, must not be used in
> configuration{noformat}
> Clearly it shouldn't be marked read-only
> https://maven.apache.org/plugins/maven-resources-plugin/examples/resource-directory.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resources-plugin] olamy commented on a diff in pull request #53: [MRESOURCES-295] Drop Plexus legacy code
olamy commented on code in PR #53: URL: https://github.com/apache/maven-resources-plugin/pull/53#discussion_r1143110846 ## src/test/java/org/apache/maven/plugins/resources/filters/ItFilter.java: ## @@ -18,6 +18,9 @@ */ package org.apache.maven.plugins.resources.filters; +import javax.inject.Named; Review Comment: just saying `javax.inject` is now legacy and deprecated in favour of `jakarta.inject`. So ironically the PR title doesn't look correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MRESOURCES-297) Update to parent POM 39, reformat sources
[ https://issues.apache.org/jira/browse/MRESOURCES-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOURCES-297: -- Assignee: Tamas Cservenak > Update to parent POM 39, reformat sources > - > > Key: MRESOURCES-297 > URL: https://issues.apache.org/jira/browse/MRESOURCES-297 > Project: Maven Resources Plugin > Issue Type: Task >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.3.1 > > > Apply latest parent, reformat sources, ignore reformat in blame. -- This message was sent by Atlassian Jira (v8.20.10#820010)
