[GitHub] [maven-compiler-plugin] elharo commented on a change in pull request #34: [MCOMPILER-428] improve incremental compilation documentation
elharo commented on a change in pull request #34: URL: https://github.com/apache/maven-compiler-plugin/pull/34#discussion_r560415436 ## File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java ## @@ -483,7 +483,19 @@ private List fileExtensions; /** - * to enable/disable incrementation compilation feature + * to enable/disable incrementation compilation feature. Review comment: incrementation --> incremental This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] elharo commented on a change in pull request #34: [MCOMPILER-428] improve incremental compilation documentation
elharo commented on a change in pull request #34: URL: https://github.com/apache/maven-compiler-plugin/pull/34#discussion_r514368549 ## File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java ## @@ -483,7 +483,19 @@ private List fileExtensions; /** - * to enable/disable incrementation compilation feature + * to enable/disable incrementation compilation feature. + * This leads to two different modes depending on the underlining compiler. Default javac compiler does the + * following: + * + * true (default) in this mode the compiler plugin determines whether any JAR files the + * current module depends on have been changed in the current build run, or any source file was added, removed or + * changed since the last compilation. If this is the case, the compiler plugin recompiles all sources Review comment: period at end ## File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java ## @@ -483,7 +483,19 @@ private List fileExtensions; /** - * to enable/disable incrementation compilation feature + * to enable/disable incrementation compilation feature. + * This leads to two different modes depending on the underlining compiler. Default javac compiler does the + * following: + * + * true (default) in this mode the compiler plugin determines whether any JAR files the + * current module depends on have been changed in the current build run, or any source file was added, removed or + * changed since the last compilation. If this is the case, the compiler plugin recompiles all sources + * false (not recommended) this only compiles source files which are newer than their + * corresponding class files. That is which have been changed since the last compilation. This does not Review comment: That is... is a sentence fragment ## File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java ## @@ -483,7 +483,19 @@ private List fileExtensions; /** - * to enable/disable incrementation compilation feature + * to enable/disable incrementation compilation feature. + * This leads to two different modes depending on the underlining compiler. Default javac compiler does the Review comment: underlining --> underlying The default javac ## File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java ## @@ -483,7 +483,19 @@ private List fileExtensions; /** - * to enable/disable incrementation compilation feature + * to enable/disable incrementation compilation feature. + * This leads to two different modes depending on the underlining compiler. Default javac compiler does the + * following: + * + * true (default) in this mode the compiler plugin determines whether any JAR files the + * current module depends on have been changed in the current build run, or any source file was added, removed or Review comment: have been --> have build run, --> build run; This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] elharo commented on a change in pull request #34: [MCOMPILER-428] improve incremental compilation documentation
elharo commented on a change in pull request #34: URL: https://github.com/apache/maven-compiler-plugin/pull/34#discussion_r508822671 ## File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java ## @@ -483,7 +483,18 @@ private List fileExtensions; /** - * to enable/disable incrementation compilation feature + * to enable/disable incrementation compilation feature. + * This leads to two different modes + * + * true (default) in this mode the compiler plugin will determine whether any JAR files the + * current module depends on have been changed in the current build run, or any source file was added, removed or + * changed since the last compilation. If this is the case, the compiler plugin recompiles all sources + * false (not recommended) this will only compile source files which are newer than their + * corresponding class files, i.e. which have been changed since the last compilation process. This will not Review comment: ", i.e." --> . That is, delete "process" will not --> does not ## File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java ## @@ -483,7 +483,18 @@ private List fileExtensions; /** - * to enable/disable incrementation compilation feature + * to enable/disable incrementation compilation feature. + * This leads to two different modes + * + * true (default) in this mode the compiler plugin will determine whether any JAR files the Review comment: will determine --> determines (tech writing lives in the eternal present) ## File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java ## @@ -483,7 +483,18 @@ private List fileExtensions; /** - * to enable/disable incrementation compilation feature + * to enable/disable incrementation compilation feature. + * This leads to two different modes + * + * true (default) in this mode the compiler plugin will determine whether any JAR files the + * current module depends on have been changed in the current build run, or any source file was added, removed or + * changed since the last compilation. If this is the case, the compiler plugin recompiles all sources + * false (not recommended) this will only compile source files which are newer than their Review comment: will only compile --> only compiles This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
