[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss commented on issue #473: Deployment into OpenShift

2019-07-11 Thread GitBox
dgrove-oss commented on issue #473: Deployment into OpenShift
URL: 
https://github.com/apache/incubator-openwhisk-deploy-kube/issues/473#issuecomment-510622042
 
 
   Merged #465.  Please give it a try.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss closed issue #473: Deployment into OpenShift

2019-07-11 Thread GitBox
dgrove-oss closed issue #473: Deployment into OpenShift
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/473
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss merged pull request #491: Use most recent release for runtimes and apigateway

2019-07-11 Thread GitBox
dgrove-oss merged pull request #491: Use most recent release for runtimes and 
apigateway
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/491
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss merged pull request #465: first pass at OKD/OpenShift documentation

2019-07-11 Thread GitBox
dgrove-oss merged pull request #465: first pass at OKD/OpenShift documentation
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/465
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah merged pull request #272: Fixed Kafka provider setup

2019-07-11 Thread GitBox
rabbah merged pull request #272: Fixed Kafka provider setup
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/272
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah closed issue #271: Error setup Kafka provider

2019-07-11 Thread GitBox
rabbah closed issue #271: Error setup Kafka provider
URL: https://github.com/apache/incubator-openwhisk-devtools/issues/271
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah commented on issue #271: Error setup Kafka provider

2019-07-11 Thread GitBox
rabbah commented on issue #271: Error setup Kafka provider
URL: 
https://github.com/apache/incubator-openwhisk-devtools/issues/271#issuecomment-510562220
 
 
   closed by #272 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah commented on issue #272: Fixed Kafka provider setup

2019-07-11 Thread GitBox
rabbah commented on issue #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#issuecomment-510562073
 
 
   Thanks @phlucas96!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

2019-07-11 Thread GitBox
rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615681
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
 printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

2019-07-11 Thread GitBox
rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615681
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

2019-07-11 Thread GitBox
rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615166
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
printf "DOCKER_IMAGE_PREFIX=$(DOCKER_IMAGE_PREFIX)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

2019-07-11 Thread GitBox
rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615681
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

2019-07-11 Thread GitBox
rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615166
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
printf "DOCKER_IMAGE_PREFIX=$(DOCKER_IMAGE_PREFIX)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

2019-07-11 Thread GitBox
rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302615681
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   ```suggestion
  printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

2019-07-11 Thread GitBox
rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302614808
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   Actually, can you replace these with 
   ```
   DOCKER_IMAGE_PREFIX ?= openwhisk
   DOCKER_IMAGE_TAG ?= nightly
   ```
   
   which are already defined?
   
   ```
 printf "DOCKER_IMAGE_PREFIX=$(DOCKER_IMAGE_PREFIX)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
 printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah commented on a change in pull request #272: Fixed Kafka provider setup

2019-07-11 Thread GitBox
rabbah commented on a change in pull request #272: Fixed Kafka provider setup
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/272#discussion_r302614808
 
 

 ##
 File path: docker-compose/Makefile
 ##
 @@ -450,6 +450,8 @@ setup-providers:
printf "ENDPOINT_AUTH=`cat $(realpath 
$(OPENWHISK_PROJECT_HOME))/ansible/files/auth.whisk.system`\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "HOST_MACHINE=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
+   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
 
 Review comment:
   Actually, can you replace these with 
   ```
   DOCKER_IMAGE_PREFIX ?= openwhisk
   DOCKER_IMAGE_TAG ?= nightly
   ```
   
   which are already defined?
   
   ```
 printf "DOCKER_IMAGE_PREFIX=$(DOCKER_IMAGE_PREFIX)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
 printf "DOCKER_IMAGE_TAG=$(DOCKER_IMAGE_TAG)\n" >> 
$(TMP_HOME)/tmp/openwhisk/local.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] phlucas96 opened a new pull request #272: Fixed Kafka provider setup

2019-07-11 Thread GitBox
phlucas96 opened a new pull request #272: Fixed Kafka provider setup
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/272
 
 
   Fixes the setup of the Kafka provider. Currently, it gives an error because 
docker-compose tries to pull the docker container with the "latest" tag instead 
of the "nightly" one. 
   
   The changes in the pull request fix this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] phlucas96 commented on issue #271: Error setup Kafka provider

2019-07-11 Thread GitBox
phlucas96 commented on issue #271: Error setup Kafka provider
URL: 
https://github.com/apache/incubator-openwhisk-devtools/issues/271#issuecomment-510527918
 
 
   Ok, I will. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah commented on issue #271: Error setup Kafka provider

2019-07-11 Thread GitBox
rabbah commented on issue #271: Error setup Kafka provider
URL: 
https://github.com/apache/incubator-openwhisk-devtools/issues/271#issuecomment-510527574
 
 
   Thanks @phlucas96 I see the delta. Do you want to submit a PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah removed a comment on issue #271: Error setup Kafka provider

2019-07-11 Thread GitBox
rabbah removed a comment on issue #271: Error setup Kafka provider
URL: 
https://github.com/apache/incubator-openwhisk-devtools/issues/271#issuecomment-510527088
 
 
   @phlucas96 are you on master/head?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] rabbah commented on issue #271: Error setup Kafka provider

2019-07-11 Thread GitBox
rabbah commented on issue #271: Error setup Kafka provider
URL: 
https://github.com/apache/incubator-openwhisk-devtools/issues/271#issuecomment-510527088
 
 
   @phlucas96 are you on master/head?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-devtools] phlucas96 opened a new issue #271: Error setup Kafka provider

2019-07-11 Thread GitBox
phlucas96 opened a new issue #271: Error setup Kafka provider
URL: https://github.com/apache/incubator-openwhisk-devtools/issues/271
 
 
   During the installation of the kafka provider, docker-compose tries to pull 
the openwhisk/controller:"latest" image instead of the "nightly" image, giving 
an error:
   
   ```
   Pulling controller (openwhisk/controller:latest)...
   ERROR: manifest for openwhisk/controller:latest not found
   ```
   
   This is because during the "setup-providers" phase of the Makefile, the 
image prefix and image tag are missing from the "providers.env" file. 
   
   Adding the following lines to the Makefile "setup-providers" phase fixes the 
problem.
   
   ```
   printf "DOCKER_IMAGE_PREFIX"="openwhisk\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
   
   printf "DOCKER_IMAGE_TAG"="nightly\n" >> 
$(TMP_HOME)/tmp/openwhisk/providers.env
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss merged pull request #490: feat: add k8s tolerations support

2019-07-11 Thread GitBox
dgrove-oss merged pull request #490: feat: add k8s tolerations support
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/490
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss commented on issue #490: feat: add k8s tolerations support

2019-07-11 Thread GitBox
dgrove-oss commented on issue #490: feat: add k8s tolerations support
URL: 
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/490#issuecomment-510513021
 
 
   CLA processed; will merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk] style95 commented on issue #4541: Disable MesosContainerFactory from subscribing after close

2019-07-11 Thread GitBox
style95 commented on issue #4541: Disable MesosContainerFactory from 
subscribing after close
URL: 
https://github.com/apache/incubator-openwhisk/pull/4541#issuecomment-510420965
 
 
   I am not quite sure but I think the issue is happening in this way.
   
   `MesosContainerFactory` ask to the `mesosClientActor` which is `testActor` 
in test cases. 
   ```scala
   private def subscribe(): Future[Unit] = {
   logging.info(this, s"subscribing to Mesos master at 
${mesosConfig.masterUrl}")
   mesosClientActor  // here
 .ask(Subscribe)(mesosConfig.timeouts.subscribe)
 .mapTo[SubscribeComplete]
 .map(complete => logging.info(this, s"subscribe completed 
successfully... $complete"))
 .recoverWith {
   case e =>
 logging.error(this, s"subscribe failed... $e}")
 if (closed) Future.successful(()) else subscribe()
 }
 }
   ```
   
   ```scala
   factory = new MesosContainerFactory(
 wskConfig,
 system,
 logging,
 Map("--arg1" -> Set("v1", "v2"), "--arg2" -> Set("v3", "v4"), "other" 
-> Set("v5", "v6")),
 containerArgsConfig,
 mesosConfig = mesosConfig,
 clientFactory = (_, _) => testActor, // here
 taskIdGenerator = testTaskId _)
   ```
   
   Since `testActor` does not respond to the request `Subscribe`, `ask` request 
will be timed out and be caught by `recoverWith`.
   `recoverWith` logic will be asynchronously executed by another thread and 
the thread will call `subscribe()` again and be timed out recursively.
   
   
   So I think one easy way could be to define a simple testing actor which 
respond with static `SubscribeComplete` response against `Subscribe` request 
and pass the testing actor to the `MesosContainerFactory` instead of using just 
`testActor`.
   (We may want to define `AutoPilot` instead of defining a simple actor, but 
anyway)
   
   Since I did not look into the `MesosContainerFactory` logic in-depth, it 
would be great if @tysonnorris confirm this behavior once.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk] mhenke1 merged pull request #4540: Removed unused controller instances config

2019-07-11 Thread GitBox
mhenke1 merged pull request #4540: Removed unused controller instances config
URL: https://github.com/apache/incubator-openwhisk/pull/4540
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk] Guoyoyo commented on issue #4554: openwhisk Hello World error!! wsk api list error !!

2019-07-11 Thread GitBox
Guoyoyo commented on issue #4554: openwhisk Hello World error!! wsk api list 
error !!
URL: 
https://github.com/apache/incubator-openwhisk/issues/4554#issuecomment-510397931
 
 
   supplement:
   
   > creating the hello.js function ...
   > invoking the hello-world function ...
   > adding the function to whisk ...
   > ok: created action hello
   > invoking the function ...
   > invocation result: { "payload": "Hello, World!" }
   > { "payload": "Hello, World!" }
   > creating an API from the hello function ...
   > ok: updated action hello
   > **error: Unable to create API: API creation failure: Unable to obtain 
API(s) from the API Gateway (status code 404): {"status":404,"message":"Not 
Found"}**
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-openwhisk] Guoyoyo opened a new issue #4554: openwhisk Hello World error!! wsk api list error !!

2019-07-11 Thread GitBox
Guoyoyo opened a new issue #4554: openwhisk Hello World error!! wsk api list 
error !!
URL: https://github.com/apache/incubator-openwhisk/issues/4554
 
 
   
   
   ## Environment details:
   
   * Ubuntu 16.04.6   
   * openjdk version "1.8.0_212"
   * docker-compose version 1.21.2
   
   ## Question description about Openwhisk:
   Hello everyone, please give me a big handI'm beat...
   I am going to install the apache openwhisk. I choose the Quick Start 
(Docker-Compose) 
[https://github.com/apache/incubator-openwhisk#quick-start](https://github.com/apache/incubator-openwhisk#quick-start)
   
   It needs many port to install others service e.g. CouchDB, Kafka... in my 
computer, 80 and 9000 port is already used. so i revise the docker-compose.yml 
to assign the other port to replace them. (`80 => 9004 , 9000=> 9005`)
   
   After that, I run `make quick-start `, most service are work which show ok , 
i guess they were successfully installed. In the end, it should output the 
hello-world, but it didn't and show the error. 
   
   > error: Unable to create API: API creation failure: Unable to obtain API(s) 
from the API Gateway (status code 404): {"status":404,"message":"Not Found"}
   
   ## Question description about OpenwhiskCLI:
   I also tried to install openwhiskCLI reference by 
[https://github.com/apache/incubator-openwhisk-cli](https://github.com/apache/incubator-openwhisk-cli)
   the following instructions are what I inputted:
   
   > git clone https://github.com/apache/incubator-openwhisk-cli.git
   > ./gradlew compile –PnativeCompile
   > ./gradlew compile -PbuildPlatforms=linux-amd64
   > #add to the environment variable 
   > sudo mv wsk /usr/local/bin
   
   It seems no problem so far. i can input `wsk`. So, i stated to try an 
example like Hello-world.
   reference: 
[here](https://github.com/apache/incubator-openwhisk/blob/master/docs/samples.md)
   
   The first step:
   Create a JavaScript code example.
   ```
   /**
* Hello world as an OpenWhisk action.
*/
   function main(params) {
   var name = params.name || 'World';
   return {payload:  'Hello, ' + name + '!'};
   }
   ```
   
   When i inputted: `wsk action create hello hello.js`, errors are just 
happened...
   
   > error: Unable to create action 'hello': The connection failed, or timed 
out. (HTTP status code 400)
   
   I surveyed google many times and tried to set a lot @*$(%), but it still not 
work ... omg
   
   like:
   
   `wsk property set --apihost http://172.17.0.1 namespace guest –auth 
23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP
 `
   > ok: whisk API host set to http://172.17.0.1
   
   `wsk action create hello hello.js`
   > error: Unable to create action 'hello': The connection failed, or timed 
out. (HTTP status code 405)
   
   `wsk api list`
   > error: Unable to obtain the API list: The connection failed, or timed out. 
(HTTP status code 404)
   
   `wsk property get`
   > whisk API host  http://172.17.0.1
   whisk auth  
23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP
   whisk namespace _
   client cert
   Client key
   whisk API version   v1
   whisk CLI version   2019-07-11T14:05:29.661+0800
   whisk API build Unknown
   whisk API build number  Unknown
   error: Unable to obtain API build information: The connection failed, or 
timed out. (HTTP status code 404)
   
   I am not sure whether the error is happened due to wsk property set or not ? 
if it is, what should i set for apihost(port needed?) namespace? 
   
   Please guys, if you have experience for openwhisk, help me omg


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services