[frameworks-qqc2-desktop-style] [Bug 402082] Directly using `modelData` in combobox isn't safe

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=402082

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 402082] Directly using `modelData` in combobox isn't safe

[Emmanuel Lepage Vallée]

https://bugs.kde.org/show_bug.cgi?id=402082

--- Comment #2 from Emmanuel Lepage Vallée  ---
In my limited testing, this works

text: controlRoot.textRole != undefined ? model[controlRoot.textRole]
|| "": (
Array.isArray(controlRoot.model) ? modelData[controlRoot.textRole]
:  modelData
)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 402082] Directly using `modelData` in combobox isn't safe

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=402082

David Edmundson  changed:

   What|Removed |Added

Summary|Directly using `modelData`  |Directly using `modelData`
   |isn't safe  |in combobox isn't safe

--- Comment #1 from David Edmundson  ---
The code does try to guard it:

org.kde.desktop/ComboBox.qml:


text: controlRoot.textRole ? (Array.isArray(controlRoot.model) ?
modelData[controlRoot.textRole] : model[controlRoot.textRole]) : modelData


code in QQC1 was:


text: popup.textRole === '' ?
modelData :
  ((popup.modelIsArray ? modelData[popup.textRole] :
model[popup.textRole]) || '')



@Emmanuel could you test if that works for your "totally fine model"

-- 
You are receiving this mail because:
You are watching all bug changes.